guoyunhe (Yunhe Guo)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 3 2016, 7:25 PM (172 w, 1 d)
Availability
Available

Recent Activity

Sun, Oct 20

guoyunhe updated the summary of D24798: Migrate QQC1 to QQC2.
Sun, Oct 20, 10:41 AM · Plasma
guoyunhe added reviewers for D24798: Migrate QQC1 to QQC2: Plasma, Plasma: Workspaces.
Sun, Oct 20, 10:40 AM · Plasma
guoyunhe requested review of D24798: Migrate QQC1 to QQC2.
Sun, Oct 20, 10:39 AM · Plasma

Fri, Oct 18

guoyunhe updated the diff for D24727: Fix NOAA picture of the day provider.

Validate QUrl of image

Fri, Oct 18, 10:57 AM · Plasma

Thu, Oct 17

guoyunhe added a comment to D24727: Fix NOAA picture of the day provider.

Still broken, I'm afraid. Among the console output is the following, which may be helpful:

kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg")
Thu, Oct 17, 6:36 PM · Plasma
guoyunhe updated the diff for D24727: Fix NOAA picture of the day provider.

Change back to the original page URL

Thu, Oct 17, 6:29 PM · Plasma
guoyunhe added a comment to D24727: Fix NOAA picture of the day provider.

This doesn't fix the problem for me. :(

Thu, Oct 17, 6:26 PM · Plasma
guoyunhe added a reviewer for D24727: Fix NOAA picture of the day provider: Plasma.
Thu, Oct 17, 12:50 PM · Plasma
guoyunhe requested review of D24727: Fix NOAA picture of the day provider.
Thu, Oct 17, 12:48 PM · Plasma

Wed, Oct 16

guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

kf5-network.directory has been added to plasma-workspace.

Wed, Oct 16, 10:11 AM · Frameworks

Sat, Oct 12

guoyunhe added inline comments to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Sat, Oct 12, 7:16 AM · Frameworks
guoyunhe updated the diff for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

*.exe should be normal executable in Windows

Sat, Oct 12, 7:15 AM · Frameworks

Wed, Oct 9

guoyunhe committed R883:1553404: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Wed, Oct 9, 8:24 PM
guoyunhe committed R883:1553403: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Wed, Oct 9, 8:23 PM

Mon, Oct 7

guoyunhe updated the summary of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Mon, Oct 7, 9:16 PM · Frameworks
guoyunhe updated the summary of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Mon, Oct 7, 9:11 PM · Frameworks
guoyunhe added a comment to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

It is now working. The condition is so complex. Please help test this patch!

Mon, Oct 7, 8:41 PM · Frameworks
guoyunhe updated the diff for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

Fix *.exe execution condition

Mon, Oct 7, 8:30 PM · Frameworks
guoyunhe updated the summary of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Mon, Oct 7, 5:34 PM · Frameworks
guoyunhe updated the diff for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

"openAsExecute" parameter for ExecutableFileOpenDialog

Mon, Oct 7, 5:22 PM · Frameworks
guoyunhe added a comment to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

I just realized that this patch might be unfinished. In the pop up, you usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually to be executed by Wine? "Execute" will do nothing because it isn't a native executable for Linux/BSD.

Mon, Oct 7, 3:39 PM · Frameworks
guoyunhe added a comment to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

Maybe can we check to see if WINE is installed or if there's a handler for application/x-ms-dos-executable? Otherwise if you don't have WINE installed, won't you see a dialog that gives you the option to execute it when that doesn't work?

Mon, Oct 7, 3:34 PM · Frameworks
guoyunhe added a reviewer for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms: Frameworks.
Mon, Oct 7, 11:12 AM · Frameworks
guoyunhe requested review of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Mon, Oct 7, 11:11 AM · Frameworks

Sun, Oct 6

guoyunhe added a comment to D24436: Add applications-network icon for renaming Internet category to Network.

They can easily rename/link the icon. Correct semantic naming can improve the icon design. In a long view, having the same naming from the freedestop.org specification, to KDE categories, to icons, can reduce confusion.

Sun, Oct 6, 7:20 PM · Frameworks
guoyunhe updated the diff for D24424: Create kf5-network.directory.

Change icon name to applications-network

Sun, Oct 6, 9:41 AM · Plasma
guoyunhe added a dependency for D24424: Create kf5-network.directory: D24436: Add applications-network icon for renaming Internet category to Network.
Sun, Oct 6, 9:40 AM · Plasma
guoyunhe added a dependent revision for D24436: Add applications-network icon for renaming Internet category to Network: D24424: Create kf5-network.directory.
Sun, Oct 6, 9:40 AM · Frameworks
guoyunhe added a reviewer for D24436: Add applications-network icon for renaming Internet category to Network: Breeze.
Sun, Oct 6, 9:39 AM · Frameworks
guoyunhe requested review of D24436: Add applications-network icon for renaming Internet category to Network.
Sun, Oct 6, 9:39 AM · Frameworks

Sat, Oct 5

guoyunhe added a dependency for D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category: D24424: Create kf5-network.directory.
Sat, Oct 5, 2:45 PM · Frameworks
guoyunhe added a dependent revision for D24424: Create kf5-network.directory: D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.
Sat, Oct 5, 2:45 PM · Plasma
guoyunhe updated the summary of D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.
Sat, Oct 5, 2:44 PM · Frameworks
guoyunhe added a reviewer for D24424: Create kf5-network.directory: Plasma.
Sat, Oct 5, 2:44 PM · Plasma
guoyunhe requested review of D24424: Create kf5-network.directory.
Sat, Oct 5, 2:43 PM · Plasma
guoyunhe added a reviewer for D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category: Frameworks.
Sat, Oct 5, 2:40 PM · Frameworks
guoyunhe requested review of D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.
Sat, Oct 5, 2:39 PM · Frameworks
guoyunhe added a comment to D24409: Remove kf5-toys.directory because it will not be used by other packages.

Reverted https://cgit.kde.org/plasma-workspace.git/commit/?id=0e14429e7355e07913ea21ab03abde6dc1ae8a1f

Sat, Oct 5, 2:29 PM · Plasma
guoyunhe added a comment to D24409: Remove kf5-toys.directory because it will not be used by other packages.

D24384 has been accepted and seems no one strongly against it... So I landed it. Can you give this patch an approval? @davidedmundson

Sat, Oct 5, 12:21 PM · Plasma

Fri, Oct 4

guoyunhe updated subscribers of D24409: Remove kf5-toys.directory because it will not be used by other packages.

Ship it (if and only if the other patch is also accepted)

Fri, Oct 4, 10:26 AM · Plasma
guoyunhe added a reviewer for D24409: Remove kf5-toys.directory because it will not be used by other packages: Plasma: Workspaces.
Fri, Oct 4, 10:22 AM · Plasma
guoyunhe requested review of D24409: Remove kf5-toys.directory because it will not be used by other packages.
Fri, Oct 4, 10:22 AM · Plasma
guoyunhe added a comment to D24384: Move Amusement to Games directory instead of Games > Toys.

If I install amor, it would be shown in both Games and Games > Toys. This patch will let it only shows in Games.

Fri, Oct 4, 10:05 AM · Frameworks
guoyunhe updated the diff for D24384: Move Amusement to Games directory instead of Games > Toys.

In case Amusement is under other primary category, let it be placed in its actually primary category, rather than force it in Games.

Fri, Oct 4, 10:01 AM · Frameworks
guoyunhe added a comment to D24384: Move Amusement to Games directory instead of Games > Toys.

In RPM package groups, Amusement is a top level category and Game is its child category. So a game can be categorized as Amusement/Game/Other.

Fri, Oct 4, 9:15 AM · Frameworks
guoyunhe updated the summary of D24384: Move Amusement to Games directory instead of Games > Toys.
Fri, Oct 4, 8:30 AM · Frameworks
guoyunhe updated the diff for D24384: Move Amusement to Games directory instead of Games > Toys.

Update description

Fri, Oct 4, 8:29 AM · Frameworks

Thu, Oct 3

guoyunhe added a comment to D24384: Move Amusement to Games directory instead of Games > Toys.

Have you contacted Valve to tell them amusement is the wrong category for Steam?

Because the spec says Amusement - > a simple amusement

And that's not what steam is

IMHO this patch is wrong and steam is what needs fixing.

Thu, Oct 3, 5:22 PM · Frameworks
guoyunhe updated the diff for D24384: Move Amusement to Games directory instead of Games > Toys.

Fix tabs

Thu, Oct 3, 11:17 AM · Frameworks
guoyunhe added a reviewer for D24384: Move Amusement to Games directory instead of Games > Toys: Frameworks.
Thu, Oct 3, 11:16 AM · Frameworks
guoyunhe requested review of D24384: Move Amusement to Games directory instead of Games > Toys.
Thu, Oct 3, 11:15 AM · Frameworks

Fri, Sep 27

guoyunhe added a comment to D23998: Fix HiDPI rendering issues with Dual Screen.

I track down the issue and the source is this line in konsole:

Fri, Sep 27, 7:11 PM · Kate

Sep 19 2019

guoyunhe added a comment to D23949: Pixel perfect splash art rendering.

I submitted it to GitLab/Invent. Close this.

Sep 19 2019, 12:44 PM · Krita

Sep 18 2019

guoyunhe added a comment to D24034: Fix offset issue in dual hidpi screen.

This really needs to be fixed in Qt. 5.13.1 has an overhaul of the system, please make sure that the patch is still required there and does not make things worse.

And please report positioning issues that you can reproduce in https://bugreports.qt.io/browse/QTBUG-77086

Sep 18 2019, 8:03 AM · Spectacle

Sep 17 2019

guoyunhe updated the diff for D24034: Fix offset issue in dual hidpi screen.

Better code style

Sep 17 2019, 8:54 PM · Spectacle
guoyunhe updated the summary of D24034: Fix offset issue in dual hidpi screen.
Sep 17 2019, 8:14 PM · Spectacle
guoyunhe added a reviewer for D24034: Fix offset issue in dual hidpi screen: Spectacle.
Sep 17 2019, 8:11 PM · Spectacle
guoyunhe updated the summary of D24034: Fix offset issue in dual hidpi screen.
Sep 17 2019, 8:10 PM · Spectacle
guoyunhe requested review of D24034: Fix offset issue in dual hidpi screen.
Sep 17 2019, 8:09 PM · Spectacle
guoyunhe added a comment to D23998: Fix HiDPI rendering issues with Dual Screen.

What happens if e.g. vi or another text editor is open? Do we send the cd... command then to the editor?

I think send terminal input this way is inherently flawed.

Sep 17 2019, 7:18 AM · Kate

Sep 16 2019

guoyunhe added a comment to D23998: Fix HiDPI rendering issues with Dual Screen.

If I know how to fix it in Konsole, I will definitely do it. But I cannot find the cause in KonsolePart. Dolphin took the same solution, instead of call the function, they send cd command. I also pushed it to GitLab/Invent https://invent.kde.org/kde/kate/merge_requests/19/diffs

Sep 16 2019, 5:39 PM · Kate
guoyunhe added a reviewer for D23998: Fix HiDPI rendering issues with Dual Screen: Kate.
Sep 16 2019, 4:54 PM · Kate
guoyunhe requested review of D23998: Fix HiDPI rendering issues with Dual Screen.
Sep 16 2019, 4:54 PM · Kate
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Rename and move the find duplicate button

Sep 16 2019, 2:38 PM · Plasma
guoyunhe abandoned D23775: HiDPI rendering improvement.

Noticed that someone has changed width() to boundingRect() in master branch. I really hope someone can inform me to change the patch. Otherwise, we can never push it forward... Please review D23993

Sep 16 2019, 1:24 PM
guoyunhe requested review of D23993: HiDPI rendering improvement.
Sep 16 2019, 1:20 PM · KDE Applications
guoyunhe abandoned D6813: Use customized font size for Digital Clock applet.

It seems not possible to set font size because others insist the font size should grow with panel. Another alternative widget might be better way to push forward.

Sep 16 2019, 12:05 PM · Plasma
guoyunhe abandoned D17704: Copy to clipboard always copy English texts.
Sep 16 2019, 11:59 AM · Plasma
guoyunhe added a comment to D17704: Copy to clipboard always copy English texts.

Yes, this can be closed because another approach is more useful.

Sep 16 2019, 11:59 AM · Plasma
guoyunhe added a reviewer for D23987: Enable HiDPI rendering for rules dialog and killer dialog.: KWin.
Sep 16 2019, 11:55 AM · KWin
guoyunhe requested review of D23987: Enable HiDPI rendering for rules dialog and killer dialog..
Sep 16 2019, 11:55 AM · KWin
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Fix size policy

Sep 16 2019, 8:22 AM · Plasma
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Avoid scrollbar. Put progressbar and font status to another row.

Sep 16 2019, 7:47 AM · Plasma

Sep 15 2019

guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Similar filter layout as Colors KCM. Move "Scan Duplicates..." button to the bottom button group.

Sep 15 2019, 8:49 PM · Plasma
guoyunhe added a comment to D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Now I can get something like this (the QLineEdit and QPushButton still have different height):

Sep 15 2019, 8:34 PM · Plasma
guoyunhe added a comment to D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Maybe in the interests of Goal: Consistency, let's make the filter feature look the same way that it does in the Colors KCM:

Sep 15 2019, 7:55 PM · Plasma
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Unify button look

Sep 15 2019, 6:28 AM · Plasma

Sep 14 2019

guoyunhe added a comment to D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

I changed it to QToolButton, but it still look different:

Sep 14 2019, 9:15 PM · Plasma
guoyunhe updated the summary of D23949: Pixel perfect splash art rendering.
Sep 14 2019, 8:34 PM · Krita
guoyunhe updated the summary of D23949: Pixel perfect splash art rendering.
Sep 14 2019, 8:33 PM · Krita
guoyunhe requested review of D23949: Pixel perfect splash art rendering.
Sep 14 2019, 8:32 PM · Krita
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

@ndavis can you give review? thanks!

Sep 14 2019, 7:26 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

Changed to currentColor

Sep 14 2019, 7:18 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Remove hardcoded colors

Sep 14 2019, 7:16 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

@GB_2 is it correct now?

Sep 14 2019, 6:59 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Add inline styles

Sep 14 2019, 6:59 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

I was asked to remove the hard code color like: fill="currentColor" and fill="#da4453". But I see other icons have something like style="fill:currentColor". Can anyone tell me correct way of applying colors?

Sep 14 2019, 6:53 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

@ndavis it looks strange when I removed the inline style

Sep 14 2019, 6:37 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

I just followed the email icons' color: check mark is black/white, disable mark is red.

Sep 14 2019, 6:24 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Remove hardcoded colors

Sep 14 2019, 5:54 PM · Frameworks
guoyunhe updated the diff for D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware.

Change icon name. To match patch D23942

Sep 14 2019, 5:43 PM · Plasma
guoyunhe added a comment to D6764: Use a smaller font size for digital clock plasmoid.

I think we can make another applet called Small Digital Clock, which can be an alternative of Digital Clock. Just like we have different alternatives for launcher and task bar.

Sep 14 2019, 5:35 PM · Plasma
guoyunhe added a comment to D7946: CSV characters should not be translated.

How can we push this forward?

Sep 14 2019, 5:30 PM · Calligra: 3.0
guoyunhe abandoned D17246: Unify height of message editor and nickname selector.

There should be a fix for Breeze theme, not individual applications.

Sep 14 2019, 5:29 PM
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

@ndavis, @broulik, @ngraham, I made some change. Can you have another look?

Sep 14 2019, 5:26 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Add 16px icons for font-enable and font-disable

Sep 14 2019, 5:25 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Reduce space between A and marks

Sep 14 2019, 5:00 PM · Frameworks
guoyunhe updated the diff for D23942: Add enablefont and disablefont icon for kfontinst KCM.

Rename enablefont and disablefont icons

Sep 14 2019, 2:18 PM · Frameworks
guoyunhe added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

Please use a more hierarchical name, e.g. "font-enable" and "font-disable", to match the other font icons we have such as "font-size-up" and "font-face"

Sep 14 2019, 2:14 PM · Frameworks
guoyunhe added a reviewer for D23943: HiDPI support: Frameworks.
Sep 14 2019, 1:59 PM · Frameworks