guoyunhe (Yunhe Guo)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 3 2016, 7:25 PM (204 w, 5 d)
Availability
Available

Recent Activity

Sat, May 16

guoyunhe updated the diff for D29140: Show POTD in lock screen.

No delete engine and watcher

Sat, May 16, 10:26 AM · Plasma
guoyunhe updated the diff for D29140: Show POTD in lock screen.

Remove unused slots

Sat, May 16, 9:47 AM · Plasma
guoyunhe updated the diff for D29140: Show POTD in lock screen.

Fix leaks

Sat, May 16, 9:39 AM · Plasma

Fri, May 15

guoyunhe added a comment to D29140: Show POTD in lock screen.

Maybe it is some unknown Qt bug. You can try set wallpaper as Flickr POTD and check if you have ~/.cache/plasmashell/plasma_engine_potd/flickr saved. Anyway, for photos, JPEG makes more sense than PNG.

Fri, May 15, 9:19 AM · Plasma

Thu, May 14

guoyunhe updated the diff for D29140: Show POTD in lock screen.

Code improvement

Thu, May 14, 8:59 AM · Plasma
guoyunhe updated the diff for D29140: Show POTD in lock screen.

Fix small issues

Thu, May 14, 8:08 AM · Plasma
guoyunhe added inline comments to D29140: Show POTD in lock screen.
Thu, May 14, 8:07 AM · Plasma

Wed, May 13

acrouthamel awarded D29140: Show POTD in lock screen a Yellow Medal token.
Wed, May 13, 7:01 PM · Plasma
guoyunhe accepted D29697: Correct more icons.
Wed, May 13, 6:33 AM

Tue, May 12

guoyunhe updated the diff for D29140: Show POTD in lock screen.

Fix watcher when file is recreated

Tue, May 12, 7:52 AM · Plasma
guoyunhe added a comment to D29140: Show POTD in lock screen.

@ngraham the kded module is working now. please have a look!

Tue, May 12, 7:24 AM · Plasma
guoyunhe updated the summary of D29140: Show POTD in lock screen.
Tue, May 12, 7:21 AM · Plasma
guoyunhe updated the diff for D29140: Show POTD in lock screen.

Fix config file path

Tue, May 12, 7:15 AM · Plasma
guoyunhe added a comment to D29140: Show POTD in lock screen.

I created the kded service and it seems running. But it doesn't cache the image as I expected. Don't know how to debug it.

Tue, May 12, 7:05 AM · Plasma
guoyunhe updated the diff for D29140: Show POTD in lock screen.

Clean up libraries

Tue, May 12, 6:50 AM · Plasma
guoyunhe updated the diff for D29140: Show POTD in lock screen.

Add file watcher

Tue, May 12, 6:46 AM · Plasma

Mon, May 11

guoyunhe updated the diff for D29140: Show POTD in lock screen.

Draft for PoTD KDED. Not tested.

Mon, May 11, 9:30 PM · Plasma
guoyunhe added a comment to D29140: Show POTD in lock screen.

I was looking for kded documentation but cannot find a good example. Do you know any?

Mon, May 11, 2:00 PM · Plasma
guoyunhe updated the diff for D29625: Add global shortcut.

Create symlink

Mon, May 11, 1:51 PM · Plasma
guoyunhe updated the diff for D29625: Add global shortcut.

Use KGlobalAccel instead

Mon, May 11, 11:55 AM · Plasma
guoyunhe added a comment to D29625: Add global shortcut.

I think khotkeys is deprecated: https://phabricator.kde.org/T2050

Mon, May 11, 11:33 AM · Plasma
guoyunhe added a reviewer for D29625: Add global shortcut: Plasma.
Mon, May 11, 11:21 AM · Plasma
guoyunhe requested review of D29625: Add global shortcut.
Mon, May 11, 11:18 AM · Plasma

Sat, May 9

guoyunhe committed R883:1568905: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sat, May 9, 2:36 PM
guoyunhe committed R883:1568902: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sat, May 9, 2:20 PM

May 3 2020

guoyunhe added a comment to D22700: Sync scaling DPI from Plasma to SDDM.

When I press the synchronize button, it looks like the -dpi 144 (scale x1.5) option makes the UI elements huge (feel like x2 scale or more):

-dpi 144 works the same for me in Plasma and SDDM, but do file a bug under systemsettings->kcm_sddm and copy paste what you have in /etc/sddm.conf.d/kde_settings.conf. I'll investigate.

May 3 2020, 5:34 PM · Plasma
guoyunhe added a comment to D22700: Sync scaling DPI from Plasma to SDDM.

When I press the synchronize button, it looks like the -dpi 144 (scale x1.5) option makes the UI elements huge (feel like x2 scale or more):

May 3 2020, 12:45 PM · Plasma

Apr 25 2020

guoyunhe added a comment to D29140: Show POTD in lock screen.

Anyway, this patch just focus on fixing the cache issue.

Apr 25 2020, 3:45 PM · Plasma
guoyunhe added a comment to D29140: Show POTD in lock screen.

To totally solve the issue, there are several solutions I can find:

Apr 25 2020, 7:08 AM · Plasma

Apr 24 2020

guoyunhe added a reviewer for D29159: Optimize SVG with sour: Breeze.
Apr 24 2020, 5:16 PM · Frameworks
guoyunhe added a comment to D29072: Optimize SVG.

The diff compare is based on Inkscape PNG output. And you can also check git cola's pixel diff, the diff of icons-dark/actions/22/color-management.svg looks like this (black means no difference):

Apr 24 2020, 5:16 PM · Frameworks
guoyunhe requested review of D29159: Optimize SVG with sour.
Apr 24 2020, 5:15 PM · Frameworks
guoyunhe updated the diff for D29140: Show POTD in lock screen.

Fix APOD and Flicker provider cache

Apr 24 2020, 6:18 AM · Plasma

Apr 23 2020

guoyunhe updated the summary of D29140: Show POTD in lock screen.
Apr 23 2020, 9:38 PM · Plasma
guoyunhe added a reviewer for D29140: Show POTD in lock screen: Plasma.
Apr 23 2020, 7:39 PM · Plasma
guoyunhe requested review of D29140: Show POTD in lock screen.
Apr 23 2020, 7:39 PM · Plasma

Apr 22 2020

guoyunhe added a comment to D29083: correct vscode icon name.

The icon was renamed since 2019. commit

Apr 22 2020, 3:55 PM · Frameworks
guoyunhe added a reviewer for D29083: correct vscode icon name: Breeze.
Apr 22 2020, 6:44 AM · Frameworks
guoyunhe requested review of D29083: correct vscode icon name.
Apr 22 2020, 6:44 AM · Frameworks
guoyunhe added a comment to D29072: Optimize SVG.

I do try scour but the result is disappointing. I get 16 times the following error:

Apr 22 2020, 6:25 AM · Frameworks

Apr 21 2020

guoyunhe updated the diff for D29072: Optimize SVG.
  • Merge some paths
Apr 21 2020, 9:00 PM · Frameworks
guoyunhe updated the summary of D29072: Optimize SVG.
Apr 21 2020, 8:46 PM · Frameworks
guoyunhe added a reviewer for D29072: Optimize SVG: Breeze.
Apr 21 2020, 8:45 PM · Frameworks
guoyunhe requested review of D29072: Optimize SVG.
Apr 21 2020, 8:44 PM · Frameworks
guoyunhe added reviewers for D29040: Use colorful icon instead of monochrome icon for touchpad kcm: Plasma, Breeze.
Apr 21 2020, 8:57 AM · Plasma
guoyunhe added a dependency for D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons: D29040: Use colorful icon instead of monochrome icon for touchpad kcm.
Apr 21 2020, 8:56 AM · Frameworks
guoyunhe added a dependent revision for D29040: Use colorful icon instead of monochrome icon for touchpad kcm: D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons.
Apr 21 2020, 8:56 AM · Plasma
guoyunhe requested review of D29040: Use colorful icon instead of monochrome icon for touchpad kcm.
Apr 21 2020, 8:56 AM · Plasma
guoyunhe updated the summary of D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons.
Apr 21 2020, 8:31 AM · Frameworks
guoyunhe added a reviewer for D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons: Breeze.
Apr 21 2020, 8:30 AM · Frameworks
guoyunhe requested review of D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons.
Apr 21 2020, 8:29 AM · Frameworks

Mar 25 2020

guoyunhe committed R883:1565190: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Mar 25 2020, 9:35 PM
guoyunhe committed R883:1565189: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Mar 25 2020, 9:34 PM

Mar 19 2020

guoyunhe abandoned D25475: Save combobox value instead of index.

Can be closed.

Mar 19 2020, 9:11 PM · Spectacle

Mar 10 2020

guoyunhe committed R883:1563783: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Mar 10 2020, 12:00 PM
guoyunhe committed R883:1563782: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Mar 10 2020, 11:57 AM

Mar 9 2020

guoyunhe added a comment to D27913: Icons for emoji categories.

D27915 is for the change. The ibus dict comes with untranslated categories name. The category names may change. But it seems the dict hasn't been updated that often.

Mar 9 2020, 8:40 PM · Frameworks

Mar 8 2020

guoyunhe added a comment to D27913: Icons for emoji categories.

If we do this, then won't the category icons look different from the actual emoji icons when using a font where the emojis look different?

Mar 8 2020, 6:08 PM · Frameworks

Mar 7 2020

guoyunhe added a comment to D27915: Use breeze icons for categories.

There is something wrong on your system, this is how before looks for me:

Please ignore the content. I only want to compare the left panel.

Yes there is still a difference in the left panel in my screenshot compared to your before screenshot. Not pixelated and all categories colorful

Mar 7 2020, 4:19 PM · Plasma
guoyunhe updated the summary of D27915: Use breeze icons for categories.
Mar 7 2020, 4:13 PM · Plasma
guoyunhe added a comment to D27915: Use breeze icons for categories.

There is something wrong on your system, this is how before looks for me:

Mar 7 2020, 4:11 PM · Plasma
guoyunhe updated the diff for D27915: Use breeze icons for categories.

Change object-group to object

Mar 7 2020, 3:54 PM · Plasma
guoyunhe added a dependent revision for D27913: Icons for emoji categories: D27915: Use breeze icons for categories.
Mar 7 2020, 3:50 PM · Frameworks
guoyunhe added a dependency for D27915: Use breeze icons for categories: D27913: Icons for emoji categories.
Mar 7 2020, 3:50 PM · Plasma
guoyunhe added a reviewer for D27915: Use breeze icons for categories: Plasma.
Mar 7 2020, 3:47 PM · Plasma
guoyunhe updated the summary of D27915: Use breeze icons for categories.
Mar 7 2020, 3:47 PM · Plasma
guoyunhe requested review of D27915: Use breeze icons for categories.
Mar 7 2020, 3:43 PM · Plasma
guoyunhe added a reviewer for D27913: Icons for emoji categories: Breeze.
Mar 7 2020, 3:34 PM · Frameworks
guoyunhe requested review of D27913: Icons for emoji categories.
Mar 7 2020, 3:33 PM · Frameworks

Mar 2 2020

guoyunhe abandoned D27770: HiDPI improvement of left panel.

I think there can be better solution. Use Breeze icons in the left panel instead of rendering the emoji.

Mar 2 2020, 2:23 PM · Plasma
guoyunhe added inline comments to D27770: HiDPI improvement of left panel.
Mar 2 2020, 10:35 AM · Plasma
guoyunhe updated the diff for D27770: HiDPI improvement of left panel.

Fix size

Mar 2 2020, 10:34 AM · Plasma

Mar 1 2020

guoyunhe added a reviewer for D27770: HiDPI improvement of left panel: Plasma.
Mar 1 2020, 8:39 PM · Plasma
guoyunhe requested review of D27770: HiDPI improvement of left panel.
Mar 1 2020, 8:38 PM · Plasma

Feb 22 2020

guoyunhe added inline comments to D27556: HiDPI pixmap.
Feb 22 2020, 8:30 AM · Plasma
guoyunhe updated the diff for D27556: HiDPI pixmap.

Change devicePixelRatio() to devicePixelRatioF()

Feb 22 2020, 8:29 AM · Plasma
guoyunhe added inline comments to D27556: HiDPI pixmap.
Feb 22 2020, 8:27 AM · Plasma
guoyunhe updated the diff for D27556: HiDPI pixmap.

Get DPR from widget instead of app

Feb 22 2020, 8:22 AM · Plasma

Feb 21 2020

guoyunhe updated the summary of D27556: HiDPI pixmap.
Feb 21 2020, 9:00 PM · Plasma
guoyunhe added a reviewer for D27556: HiDPI pixmap: Plasma.
Feb 21 2020, 8:53 PM · Plasma
guoyunhe updated the summary of D27556: HiDPI pixmap.
Feb 21 2020, 8:52 PM · Plasma
guoyunhe requested review of D27556: HiDPI pixmap.
Feb 21 2020, 8:51 PM · Plasma

Feb 1 2020

guoyunhe added a reviewer for D27089: Simplify HTML markups: KWin.
Feb 1 2020, 4:53 PM · KWin
guoyunhe requested review of D27089: Simplify HTML markups.
Feb 1 2020, 4:52 PM · KWin

Jan 20 2020

guoyunhe committed R883:1560888: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jan 20 2020, 10:06 PM
guoyunhe committed R883:1560887: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jan 20 2020, 10:06 PM

Jan 17 2020

guoyunhe added a comment to T12542: Fix circular dependency of applications.menu in KService and plasma-workspace.

Look like we didn't catch the opportunity of Plasma 5.18.0. But I have some idea on the naming.

Jan 17 2020, 3:30 PM · KF6

Jan 15 2020

guoyunhe added a comment to T12542: Fix circular dependency of applications.menu in KService and plasma-workspace.

Move applications.menu from kservice repository to plasma-workspace repository.

Jan 15 2020, 2:40 PM · KF6
guoyunhe added a comment to T12542: Fix circular dependency of applications.menu in KService and plasma-workspace.

applications.menu is installed at /etc/xdg/menu/kf5-applications.menu. The folder contains multiple *.menu files. The freedesktop.org spec is here https://freedesktop.org/wiki/Specifications/menu-spec/

Jan 15 2020, 11:03 AM · KF6
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

I am not 100% sure. It seems installed under /etc/xdg/menus/*.menu. You can install as many *.menu files as you want but keep different names.

Jan 15 2020, 10:51 AM · Frameworks
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

if we copy applications.menu to plasma-workspace and patch it there, it will only be shipped with future plasma releases.

Jan 15 2020, 10:31 AM · Frameworks
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

Then how about I copy this file applications.menu to plasma-workspace? After one or two years, we can delete this file from frameworks. But for compatibility, it will exist in both repositories for some time.

Jan 15 2020, 10:05 AM · Frameworks
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

The dependency D24424 has been landed three month ago. Do you think it is safe to ship this patch now?

Jan 15 2020, 9:52 AM · Frameworks

Jan 4 2020

guoyunhe committed R883:1559516: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jan 4 2020, 10:33 PM
guoyunhe committed R883:1559515: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jan 4 2020, 10:32 PM

Dec 20 2019

guoyunhe added a comment to D23316: Port towards KConfig XT.

With empty spectaclerc it is fine. I forget to keep my original rc file. Probably have a back up in my external drive. Will let you know when I get the backup.

Dec 20 2019, 4:32 PM · Spectacle
guoyunhe added a comment to D23316: Port towards KConfig XT.

Saving option is broken on my system. Clicking "Save" button throws error "Invalid file name". The default pattern is not saved. I have to go to configuration dialog and click "OK" to save the file name pattern.

Dec 20 2019, 9:25 AM · Spectacle
guoyunhe added a comment to D23316: Port towards KConfig XT.

Look good in openSUSE:

Dec 20 2019, 9:13 AM · Spectacle

Dec 16 2019

guoyunhe abandoned D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display.
Dec 16 2019, 8:45 AM · Plasma
guoyunhe added a comment to D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display.

CPU/IO Plasma widgets work pretty well in HiDPI screen. It should be solved if we make it a QML component, reusing the part from Plasma widgets.

Dec 16 2019, 8:31 AM · Plasma