- User Since
- Jul 3 2016, 7:25 PM (184 w, 6 d)
Fri, Jan 17
Look like we didn't catch the opportunity of Plasma 5.18.0. But I have some idea on the naming.
Wed, Jan 15
Move applications.menu from kservice repository to plasma-workspace repository.
applications.menu is installed at /etc/xdg/menu/kf5-applications.menu. The folder contains multiple *.menu files. The freedesktop.org spec is here https://freedesktop.org/wiki/Specifications/menu-spec/
I am not 100% sure. It seems installed under /etc/xdg/menus/*.menu. You can install as many *.menu files as you want but keep different names.
if we copy applications.menu to plasma-workspace and patch it there, it will only be shipped with future plasma releases.
Then how about I copy this file applications.menu to plasma-workspace? After one or two years, we can delete this file from frameworks. But for compatibility, it will exist in both repositories for some time.
The dependency D24424 has been landed three month ago. Do you think it is safe to ship this patch now?
Sat, Jan 4
Fri, Dec 20
With empty spectaclerc it is fine. I forget to keep my original rc file. Probably have a back up in my external drive. Will let you know when I get the backup.
Saving option is broken on my system. Clicking "Save" button throws error "Invalid file name". The default pattern is not saved. I have to go to configuration dialog and click "OK" to save the file name pattern.
Look good in openSUSE:
Dec 16 2019
CPU/IO Plasma widgets work pretty well in HiDPI screen. It should be solved if we make it a QML component, reusing the part from Plasma widgets.
Dec 7 2019
It seems impossible to align them if they are not in one QML file. twinFormLayouts can only refer ids of current context. This happens in several different KCMs. Would be great to have a solution for global alignment. But I think that need some changes to Kirigami.
Dec 6 2019
If your use as QQC2 in your imports, ComboBox need to be changed to QQC2.ComboBox.
Dec 5 2019
Should we reassign a reviewer?
Nov 27 2019
Nov 24 2019
I also think these *.menu and *.directory files should not be required at compile time. And they should better be in same repository because they are connected so closely.
Not sure who should I ping. So I posted in maillist firstname.lastname@example.org
Nov 22 2019
Yeah, look exactly the same, maybe yours is better (with configuration update script). We can close this one when yours get accepted.
Update QQC2 and Kirigami version and remove top level ColumnLayout
I didn't find good solutions for QQC2. It has been a blocker for a long time https://bugs.kde.org/show_bug.cgi?id=403153
Yes, this patch needs minimization. What is the software in your screenshot? @ndavis
update commit message
Nov 20 2019
I checked all KCM modules, the bottom row of buttons are all in same height (like the smaller button in your screenshot). Have you tried reboot?
@ngraham which applications are they? I didn't see similar thing in my system.
Force height consistency
The remaining 1px difference between QPushButton and QLineEdit is caused by content. Depending on fonts, the content size are always different.
Nov 19 2019
Left: JuK (Qt Widgets), Right: Elisa (Qt QML)
In QML applications, buttons and line edits are already same height, the same height as QLineEdit in Qt Widgets applications. If we increase the height of QLineEdit, we have to change QML components' height, too. The amount of work will be bigger. If a view contains a lot of QLineEdit/QComboBox rows (like many KCM views), the content might overflow. So it is safer to make button height shorter.
Nov 18 2019
Keep old translations
Move string changes to another patch
Shorten POTD provider names and remove descriptions that are never used anywhere.
Another approach is to shorten the texts:
Nov 17 2019
Nov 15 2019
Nov 14 2019
I also tried to not use ScrollView but enable ListView's scrollbar:
Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides.
Enable keyboard navigation and proper highlight
Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager:
Nov 13 2019
Add QQC2 namespace
Oct 25 2019
Merge kmaterka's patch D24853
Oct 20 2019
Oct 18 2019
Validate QUrl of image
Oct 17 2019
Change back to the original page URL
Oct 16 2019
kf5-network.directory has been added to plasma-workspace.
Oct 12 2019
*.exe should be normal executable in Windows
Oct 9 2019
Oct 7 2019
It is now working. The condition is so complex. Please help test this patch!
Fix *.exe execution condition
"openAsExecute" parameter for ExecutableFileOpenDialog
I just realized that this patch might be unfinished. In the pop up, you usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually to be executed by Wine? "Execute" will do nothing because it isn't a native executable for Linux/BSD.