guoyunhe (Yunhe Guo)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 3 2016, 7:25 PM (184 w, 6 d)
Availability
Available

Recent Activity

Fri, Jan 17

guoyunhe added a comment to T12542: Fix circular dependency of applications.menu in KService and plasma-workspace.

Look like we didn't catch the opportunity of Plasma 5.18.0. But I have some idea on the naming.

Fri, Jan 17, 3:30 PM · KF6

Wed, Jan 15

guoyunhe added a comment to T12542: Fix circular dependency of applications.menu in KService and plasma-workspace.

Move applications.menu from kservice repository to plasma-workspace repository.

Wed, Jan 15, 2:40 PM · KF6
guoyunhe added a comment to T12542: Fix circular dependency of applications.menu in KService and plasma-workspace.

applications.menu is installed at /etc/xdg/menu/kf5-applications.menu. The folder contains multiple *.menu files. The freedesktop.org spec is here https://freedesktop.org/wiki/Specifications/menu-spec/

Wed, Jan 15, 11:03 AM · KF6
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

I am not 100% sure. It seems installed under /etc/xdg/menus/*.menu. You can install as many *.menu files as you want but keep different names.

Wed, Jan 15, 10:51 AM · Frameworks
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

if we copy applications.menu to plasma-workspace and patch it there, it will only be shipped with future plasma releases.

Wed, Jan 15, 10:31 AM · Frameworks
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

Then how about I copy this file applications.menu to plasma-workspace? After one or two years, we can delete this file from frameworks. But for compatibility, it will exist in both repositories for some time.

Wed, Jan 15, 10:05 AM · Frameworks
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

The dependency D24424 has been landed three month ago. Do you think it is safe to ship this patch now?

Wed, Jan 15, 9:52 AM · Frameworks

Sat, Jan 4

guoyunhe committed R883:1559516: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sat, Jan 4, 10:33 PM
guoyunhe committed R883:1559515: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sat, Jan 4, 10:32 PM

Fri, Dec 20

guoyunhe added a comment to D23316: Port towards KConfig XT.

With empty spectaclerc it is fine. I forget to keep my original rc file. Probably have a back up in my external drive. Will let you know when I get the backup.

Fri, Dec 20, 4:32 PM · Spectacle
guoyunhe added a comment to D23316: Port towards KConfig XT.

Saving option is broken on my system. Clicking "Save" button throws error "Invalid file name". The default pattern is not saved. I have to go to configuration dialog and click "OK" to save the file name pattern.

Fri, Dec 20, 9:25 AM · Spectacle
guoyunhe added a comment to D23316: Port towards KConfig XT.

Look good in openSUSE:

Fri, Dec 20, 9:13 AM · Spectacle

Dec 16 2019

guoyunhe abandoned D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display.
Dec 16 2019, 8:45 AM · Plasma
guoyunhe added a comment to D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display.

CPU/IO Plasma widgets work pretty well in HiDPI screen. It should be solved if we make it a QML component, reusing the part from Plasma widgets.

Dec 16 2019, 8:31 AM · Plasma
Guo Yunhe <i@guoyunhe.me> committed R8:5e30a672c634: CSV characters should not be translated (authored by guoyunhe).
CSV characters should not be translated
Dec 16 2019, 8:28 AM
guoyunhe closed D7946: CSV characters should not be translated.
Dec 16 2019, 8:28 AM · Calligra: 3.0

Dec 7 2019

guoyunhe added a comment to D25459: fix(kcm): improve i18n of device combobox.

It seems impossible to align them if they are not in one QML file. twinFormLayouts can only refer ids of current context. This happens in several different KCMs. Would be great to have a solution for global alignment. But I think that need some changes to Kirigami.

Dec 7 2019, 7:21 AM · Plasma

Dec 6 2019

guoyunhe added a comment to D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2.

If your use as QQC2 in your imports, ComboBox need to be changed to QQC2.ComboBox.

Dec 6 2019, 8:16 AM · Plasma

Dec 5 2019

guoyunhe added a comment to D25459: fix(kcm): improve i18n of device combobox.

Should we reassign a reviewer?

Dec 5 2019, 6:12 AM · Plasma

Nov 27 2019

guoyunhe added a reviewer for D25564: Fix conflicts of shortcuts: Frameworks.
Nov 27 2019, 11:49 AM
guoyunhe requested review of D25564: Fix conflicts of shortcuts.
Nov 27 2019, 11:48 AM

Nov 24 2019

guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

I also think these *.menu and *.directory files should not be required at compile time. And they should better be in same repository because they are connected so closely.

Nov 24 2019, 8:16 PM · Frameworks
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

Not sure who should I ping. So I posted in maillist plasma-devel@kde.org

Nov 24 2019, 7:30 PM · Frameworks
guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

@ngraham @ltoscano should I create bug ticket about the dependency issue we have here?

Nov 24 2019, 7:05 PM · Frameworks

Nov 22 2019

guoyunhe added a comment to D25475: Save combobox value instead of index.

Yeah, look exactly the same, maybe yours is better (with configuration update script). We can close this one when yours get accepted.

Nov 22 2019, 9:50 PM · Spectacle
guoyunhe updated the diff for D25474: Migrate wallpaper config UI to Qt Quick Controls 2 and Kirigami.

Update QQC2 and Kirigami version and remove top level ColumnLayout

Nov 22 2019, 8:21 PM · KDE Edu, Marble
guoyunhe added a reviewer for D25475: Save combobox value instead of index: Spectacle.
Nov 22 2019, 8:16 PM · Spectacle
guoyunhe requested review of D25475: Save combobox value instead of index.
Nov 22 2019, 8:16 PM · Spectacle
guoyunhe added a comment to D25369: Shorten POTD provider names and remove description that is not used anywhere.

I didn't find good solutions for QQC2. It has been a blocker for a long time https://bugs.kde.org/show_bug.cgi?id=403153

Nov 22 2019, 7:38 PM · Plasma
guoyunhe added reviewers for D25474: Migrate wallpaper config UI to Qt Quick Controls 2 and Kirigami: Marble, Plasma.
Nov 22 2019, 7:26 PM · KDE Edu, Marble
guoyunhe requested review of D25474: Migrate wallpaper config UI to Qt Quick Controls 2 and Kirigami.
Nov 22 2019, 7:23 PM · KDE Edu, Marble
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

oxygen-demo5

Nov 22 2019, 3:52 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

Yes, this patch needs minimization. What is the software in your screenshot? @ndavis

Nov 22 2019, 12:03 PM · Plasma
guoyunhe retitled D25459: fix(kcm): improve i18n of device combobox from Device ComboBox: fix label and layout to fix(kcm): fix label and layout of device combobox.
Nov 22 2019, 11:40 AM · Plasma
guoyunhe updated the diff for D25459: fix(kcm): improve i18n of device combobox.

update commit message

Nov 22 2019, 11:39 AM · Plasma
guoyunhe updated the summary of D25459: fix(kcm): improve i18n of device combobox.
Nov 22 2019, 11:34 AM · Plasma
guoyunhe added reviewers for D25459: fix(kcm): improve i18n of device combobox: kde-i18n-doc, Plasma, Localization.
Nov 22 2019, 11:31 AM · Plasma
guoyunhe requested review of D25459: fix(kcm): improve i18n of device combobox.
Nov 22 2019, 11:30 AM · Plasma

Nov 20 2019

guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

I checked all KCM modules, the bottom row of buttons are all in same height (like the smaller button in your screenshot). Have you tried reboot?

Nov 20 2019, 7:19 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

@ngraham which applications are they? I didn't see similar thing in my system.

Nov 20 2019, 6:27 PM · Plasma
guoyunhe updated the summary of D25381: Make QPushButton/QToolButton the same height as QLineEdit.
Nov 20 2019, 4:30 PM · Plasma
guoyunhe updated the diff for D25381: Make QPushButton/QToolButton the same height as QLineEdit.

Force height consistency

Nov 20 2019, 4:30 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

The remaining 1px difference between QPushButton and QLineEdit is caused by content. Depending on fonts, the content size are always different.

Nov 20 2019, 12:54 PM · Plasma
guoyunhe updated the summary of D25381: Make QPushButton/QToolButton the same height as QLineEdit.
Nov 20 2019, 12:49 PM · Plasma

Nov 19 2019

guoyunhe committed R883:1556584: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Nov 19 2019, 11:25 PM
guoyunhe committed R883:1556583: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Nov 19 2019, 11:24 PM
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

Left: JuK (Qt Widgets), Right: Elisa (Qt QML)

Nov 19 2019, 2:57 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

In QML applications, buttons and line edits are already same height, the same height as QLineEdit in Qt Widgets applications. If we increase the height of QLineEdit, we have to change QML components' height, too. The amount of work will be bigger. If a view contains a lot of QLineEdit/QComboBox rows (like many KCM views), the content might overflow. So it is safer to make button height shorter.

Nov 19 2019, 12:02 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

If we do make flat toolbuttons buttons (autoRaise == true) and non-flat buttons the same size, we will need to change the default icon size for all buttons to 22px, or we will have a ton of UI regressions. Any non-flat button with a fixed icon size is going to have a regression. Anyone who was using non-flat buttons with 22px icons to get a bigger clickable area will need to switch to 32px icons. This also means that breeze-icons' problem with 32px icon style consistency will show itself more often.

Nov 19 2019, 9:00 AM · Plasma

Nov 18 2019

guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.

+1 conceptually, this will be nice to finally have fixed.

But might the opposite make more sense? If we make buttons shorter, we're slightly reducing their click targets, but if we make line edits taller, all we're doing it reducing unused whitespace.

Nov 18 2019, 9:39 PM · Plasma
guoyunhe added a comment to D25381: Make QPushButton/QToolButton the same height as QLineEdit.
In D25381#564378, @GB_2 wrote:

Plus in the screenshot it looks like it's still not quite the same height.

Nov 18 2019, 9:09 PM · Plasma
guoyunhe added reviewers for D25381: Make QPushButton/QToolButton the same height as QLineEdit: Breeze, Plasma.
Nov 18 2019, 9:08 PM · Plasma
guoyunhe updated the test plan for D25381: Make QPushButton/QToolButton the same height as QLineEdit.
Nov 18 2019, 9:07 PM · Plasma
guoyunhe requested review of D25381: Make QPushButton/QToolButton the same height as QLineEdit.
Nov 18 2019, 9:04 PM · Plasma
guoyunhe added a comment to D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.

5.17 branch please.

Nov 18 2019, 4:39 PM · Plasma
guoyunhe updated the diff for D25369: Shorten POTD provider names and remove description that is not used anywhere.

Fix typo

Nov 18 2019, 3:58 PM · Plasma
guoyunhe added a comment to D25369: Shorten POTD provider names and remove description that is not used anywhere.

Thanks! Can you add an explanation in the description section of this patch as to why you're removing the Description strings?

Nov 18 2019, 3:54 PM · Plasma
guoyunhe updated the summary of D25369: Shorten POTD provider names and remove description that is not used anywhere.
Nov 18 2019, 3:54 PM · Plasma
guoyunhe updated the diff for D25369: Shorten POTD provider names and remove description that is not used anywhere.

Keep old translations

Nov 18 2019, 3:49 PM · Plasma
guoyunhe updated the diff for D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.

Move string changes to another patch

Nov 18 2019, 3:24 PM · Plasma
guoyunhe updated the summary of D25369: Shorten POTD provider names and remove description that is not used anywhere.
Nov 18 2019, 3:23 PM · Plasma
guoyunhe added reviewers for D25369: Shorten POTD provider names and remove description that is not used anywhere: Plasma, ngraham.
Nov 18 2019, 3:22 PM · Plasma
guoyunhe requested review of D25369: Shorten POTD provider names and remove description that is not used anywhere.
Nov 18 2019, 3:21 PM · Plasma
guoyunhe updated the diff for D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.

Shorten POTD provider names and remove descriptions that are never used anywhere.

Nov 18 2019, 1:09 PM · Plasma
guoyunhe added a comment to D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.

Another approach is to shorten the texts:

Nov 18 2019, 12:58 PM · Plasma

Nov 17 2019

guoyunhe updated the summary of D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.
Nov 17 2019, 2:05 PM · Plasma
guoyunhe added a reviewer for D25354: Fix POTD config ComboBox display issue in Lock Screen KCM: Plasma.
Nov 17 2019, 2:04 PM · Plasma
guoyunhe requested review of D25354: Fix POTD config ComboBox display issue in Lock Screen KCM.
Nov 17 2019, 2:03 PM · Plasma

Nov 15 2019

guoyunhe added reviewers for D25319: Fix issues from D24798 comments by @davidedmundson: Plasma, davidedmundson.
Nov 15 2019, 9:21 AM · Plasma
guoyunhe requested review of D25319: Fix issues from D24798 comments by @davidedmundson.
Nov 15 2019, 9:21 AM · Plasma

Nov 14 2019

guoyunhe added a comment to D24798: Migrate QQC1 to QQC2.

I also tried to not use ScrollView but enable ListView's scrollbar:

Nov 14 2019, 1:16 PM · Plasma
guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides.

Nov 14 2019, 12:32 PM · Plasma
guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Enable keyboard navigation and proper highlight

Nov 14 2019, 9:16 AM · Plasma
guoyunhe added a comment to D24798: Migrate QQC1 to QQC2.

Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager:

Nov 14 2019, 8:21 AM · Plasma

Nov 13 2019

guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Prefix QQC2

Nov 13 2019, 8:56 PM · Plasma
guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Rebase

Nov 13 2019, 8:23 PM · Plasma
guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Add QQC2 namespace

Nov 13 2019, 8:08 PM · Plasma

Oct 25 2019

guoyunhe updated the diff for D24798: Migrate QQC1 to QQC2.

Merge kmaterka's patch D24853

Oct 25 2019, 8:19 AM · Plasma

Oct 20 2019

guoyunhe updated the summary of D24798: Migrate QQC1 to QQC2.
Oct 20 2019, 10:41 AM · Plasma
guoyunhe added reviewers for D24798: Migrate QQC1 to QQC2: Plasma, Plasma: Workspaces.
Oct 20 2019, 10:40 AM · Plasma
guoyunhe requested review of D24798: Migrate QQC1 to QQC2.
Oct 20 2019, 10:39 AM · Plasma

Oct 18 2019

guoyunhe updated the diff for D24727: Fix NOAA picture of the day provider.

Validate QUrl of image

Oct 18 2019, 10:57 AM · Plasma

Oct 17 2019

guoyunhe added a comment to D24727: Fix NOAA picture of the day provider.

Still broken, I'm afraid. Among the console output is the following, which may be helpful:

kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg")
Oct 17 2019, 6:36 PM · Plasma
guoyunhe updated the diff for D24727: Fix NOAA picture of the day provider.

Change back to the original page URL

Oct 17 2019, 6:29 PM · Plasma
guoyunhe added a comment to D24727: Fix NOAA picture of the day provider.

This doesn't fix the problem for me. :(

Oct 17 2019, 6:26 PM · Plasma
guoyunhe added a reviewer for D24727: Fix NOAA picture of the day provider: Plasma.
Oct 17 2019, 12:50 PM · Plasma
guoyunhe requested review of D24727: Fix NOAA picture of the day provider.
Oct 17 2019, 12:48 PM · Plasma

Oct 16 2019

guoyunhe added a comment to D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category.

kf5-network.directory has been added to plasma-workspace.

Oct 16 2019, 10:11 AM · Frameworks

Oct 12 2019

guoyunhe added inline comments to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Oct 12 2019, 7:16 AM · Frameworks
guoyunhe updated the diff for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

*.exe should be normal executable in Windows

Oct 12 2019, 7:15 AM · Frameworks

Oct 9 2019

guoyunhe committed R883:1553404: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Oct 9 2019, 8:24 PM
guoyunhe committed R883:1553403: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Oct 9 2019, 8:23 PM

Oct 7 2019

guoyunhe updated the summary of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Oct 7 2019, 9:16 PM · Frameworks
guoyunhe updated the summary of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Oct 7 2019, 9:11 PM · Frameworks
guoyunhe added a comment to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

It is now working. The condition is so complex. Please help test this patch!

Oct 7 2019, 8:41 PM · Frameworks
guoyunhe updated the diff for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

Fix *.exe execution condition

Oct 7 2019, 8:30 PM · Frameworks
guoyunhe updated the summary of D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.
Oct 7 2019, 5:34 PM · Frameworks
guoyunhe updated the diff for D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

"openAsExecute" parameter for ExecutableFileOpenDialog

Oct 7 2019, 5:22 PM · Frameworks
guoyunhe added a comment to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

I just realized that this patch might be unfinished. In the pop up, you usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually to be executed by Wine? "Execute" will do nothing because it isn't a native executable for Linux/BSD.

Oct 7 2019, 3:39 PM · Frameworks
guoyunhe added a comment to D24463: Treat "application/x-ms-dos-executable" as executable on all platforms.

Maybe can we check to see if WINE is installed or if there's a handler for application/x-ms-dos-executable? Otherwise if you don't have WINE installed, won't you see a dialog that gives you the option to execute it when that doesn't work?

Oct 7 2019, 3:34 PM · Frameworks