guoyunhe (Yunhe Guo)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 3 2016, 7:25 PM (137 w, 3 d)
Availability
Available

Recent Activity

Today

guoyunhe committed R883:1535857: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Thu, Feb 21, 12:03 AM

Yesterday

guoyunhe committed R883:1535856: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Wed, Feb 20, 11:57 PM

Mon, Feb 11

guoyunhe added a comment to D18890: Add button to reset index database and repair Baloo crashing.

If we know the DB is corrupted, and it's just a cache, why do we need a user facing button?

Mon, Feb 11, 7:40 PM · Baloo, Plasma
guoyunhe added inline comments to D18890: Add button to reset index database and repair Baloo crashing.
Mon, Feb 11, 7:32 PM · Baloo, Plasma
guoyunhe updated the diff for D18890: Add button to reset index database and repair Baloo crashing.
  • Make message box translatable
Mon, Feb 11, 7:07 PM · Baloo, Plasma
guoyunhe added a comment to D18890: Add button to reset index database and repair Baloo crashing.

Screenshot:

Mon, Feb 11, 7:06 PM · Baloo, Plasma
guoyunhe updated the diff for D18890: Add button to reset index database and repair Baloo crashing.
  • Add message box for Rebuild Index Database button
Mon, Feb 11, 7:05 PM · Baloo, Plasma

Sun, Feb 10

guoyunhe added a comment to D18890: Add button to reset index database and repair Baloo crashing.

Great! Just one more UI suggestion: use the string "Rebuild Index Database"

Sun, Feb 10, 4:39 PM · Baloo, Plasma
guoyunhe updated the diff for D18890: Add button to reset index database and repair Baloo crashing.
  • Reset index database button align right
Sun, Feb 10, 4:37 PM · Baloo, Plasma
guoyunhe added a comment to D18890: Add button to reset index database and repair Baloo crashing.

I wish this weren't necessary, but I think it's a good idea for the time being.

Can you reduce the button width so it doesn't span the entire layout? It should be as small as possible and right-aligned.

Sun, Feb 10, 4:29 PM · Baloo, Plasma
guoyunhe updated the diff for D18890: Add button to reset index database and repair Baloo crashing.
  • Reset index database button align right
Sun, Feb 10, 4:27 PM · Baloo, Plasma
guoyunhe added a project to D18890: Add button to reset index database and repair Baloo crashing: Baloo.
Sun, Feb 10, 12:15 AM · Baloo, Plasma
guoyunhe added reviewers for D18890: Add button to reset index database and repair Baloo crashing: Plasma, Baloo.
Sun, Feb 10, 12:15 AM · Baloo, Plasma
guoyunhe requested review of D18890: Add button to reset index database and repair Baloo crashing.
Sun, Feb 10, 12:13 AM · Baloo, Plasma

Sun, Jan 27

guoyunhe committed R883:1533980: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sun, Jan 27, 11:26 PM
guoyunhe committed R883:1533979: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sun, Jan 27, 11:25 PM

Jan 5 2019

guoyunhe committed R883:1532189: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jan 5 2019, 9:24 PM
guoyunhe committed R883:1532188: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jan 5 2019, 9:23 PM

Dec 27 2018

guoyunhe committed R883:1531536: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Dec 27 2018, 7:56 AM
guoyunhe committed R883:1531535: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Dec 27 2018, 7:55 AM

Dec 24 2018

guoyunhe updated the diff for D17773: Copy to Clipboard in English.

Hide the "Copy to Clipboard in English" button when the system is already in English.

Dec 24 2018, 12:53 PM · Plasma
guoyunhe added a comment to D17704: Copy to clipboard always copy English texts.

Here is another solution. https://phabricator.kde.org/D17773

Dec 24 2018, 9:50 AM · Plasma
guoyunhe added a reviewer for D17773: Copy to Clipboard in English: Plasma.
Dec 24 2018, 9:47 AM · Plasma
guoyunhe requested review of D17773: Copy to Clipboard in English.
Dec 24 2018, 9:45 AM · Plasma

Dec 20 2018

guoyunhe added a comment to D17704: Copy to clipboard always copy English texts.

I recall in the original patch that copying translated text was something that various folks specifically asked for. Is it really that useless? @gregormi, do you remember the context?

Dec 20 2018, 4:34 PM · Plasma
guoyunhe updated the diff for D17704: Copy to clipboard always copy English texts.

Use untranslated texts for clipboard label pairs

Dec 20 2018, 4:27 PM · Plasma
guoyunhe added a comment to D17704: Copy to clipboard always copy English texts.

If I understand your patch correctly, you only forbid translating the order of text, not the actual text labels.

Dec 20 2018, 3:17 PM · Plasma
guoyunhe added a reviewer for D17704: Copy to clipboard always copy English texts: Plasma.
Dec 20 2018, 9:08 AM · Plasma
guoyunhe requested review of D17704: Copy to clipboard always copy English texts.
Dec 20 2018, 8:14 AM · Plasma

Dec 11 2018

guoyunhe committed R883:1530541: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Dec 11 2018, 10:28 AM
guoyunhe committed R883:1530540: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Dec 11 2018, 10:28 AM

Dec 10 2018

guoyunhe added a comment to D17469: applications-games icon for dark theme.

Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original gray DualShock controller:

100%

200%

Dec 10 2018, 1:39 PM · Frameworks
guoyunhe updated the diff for D17469: applications-games icon for dark theme.

Clean up Inkscape metadata

Dec 10 2018, 9:22 AM · Frameworks
guoyunhe updated the diff for D17469: applications-games icon for dark theme.

Add modified icon with light background

Dec 10 2018, 9:14 AM · Frameworks
guoyunhe added a reviewer for D17469: applications-games icon for dark theme: Breeze.
Dec 10 2018, 8:57 AM · Frameworks
guoyunhe requested review of D17469: applications-games icon for dark theme.
Dec 10 2018, 8:56 AM · Frameworks

Nov 29 2018

guoyunhe requested review of D17246: Unify height of message editor and nickname selector.
Nov 29 2018, 9:35 PM

Nov 12 2018

guoyunhe committed R883:1528221: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Nov 12 2018, 10:33 AM
guoyunhe committed R883:1528220: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Nov 12 2018, 10:32 AM

Nov 7 2018

guoyunhe requested review of D16734: HiDPI: make icons sharp and smooth.
Nov 7 2018, 1:03 PM

Nov 2 2018

guoyunhe committed R883:1527603: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Nov 2 2018, 6:01 AM
guoyunhe committed R883:1527601: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Nov 2 2018, 6:01 AM

Oct 9 2018

guoyunhe committed R883:1526241: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Oct 9 2018, 7:14 PM
guoyunhe committed R883:1526240: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Oct 9 2018, 7:14 PM

Sep 28 2018

guoyunhe committed R883:1525461: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sep 28 2018, 8:42 PM
guoyunhe committed R883:1525460: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sep 28 2018, 8:42 PM

Sep 21 2018

guoyunhe committed R883:1525026: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sep 21 2018, 3:35 PM
guoyunhe committed R883:1525025: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sep 21 2018, 3:35 PM

Sep 10 2018

guoyunhe committed R883:1524520: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sep 10 2018, 9:36 PM
guoyunhe committed R883:1524519: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sep 10 2018, 9:35 PM
guoyunhe committed R883:1524518: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sep 10 2018, 9:00 PM

Aug 30 2018

guoyunhe committed R883:1523776: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Aug 30 2018, 2:01 PM
guoyunhe committed R883:1523775: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Aug 30 2018, 2:01 PM

Aug 22 2018

guoyunhe updated the diff for D14992: Crowdin localization workflow.
  • Use two letter language code
Aug 22 2018, 10:43 AM · Krita: Manual
guoyunhe added a comment to D14342: KDE SVN synchronize script.

Here is another solution using Crowdin platform https://phabricator.kde.org/D14992

Aug 22 2018, 10:05 AM · Krita: Manual
guoyunhe requested review of D14992: Crowdin localization workflow.
Aug 22 2018, 10:02 AM · Krita: Manual

Aug 20 2018

guoyunhe committed R883:1523002: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Aug 20 2018, 7:05 PM
guoyunhe committed R883:1523001: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Aug 20 2018, 7:04 PM
guoyunhe added a comment to D14342: KDE SVN synchronize script.

@ltoscano Do you know where is the script that handles StaticMessages.sh? I want to try if the script can be modified to support multiple pot files.

Aug 20 2018, 2:54 PM · Krita: Manual
guoyunhe added a comment to D14342: KDE SVN synchronize script.

Sorry, I totally forgot that we already discussed this and that StaticMessages.sh only create one file for repository.

The other solution would be helping us to extend the code which calls StaticMessages.sh to support more po files.

Aug 20 2018, 11:46 AM · Krita: Manual

Aug 1 2018

guoyunhe added a comment to D14342: KDE SVN synchronize script.

What worries me a bit is that this checks out the entire svn tree which is huge. Couldn't we make a list of languages that have manual translations, and only checkout out what we need?

Aug 1 2018, 9:57 AM · Krita: Manual

Jul 24 2018

guoyunhe updated the summary of D14342: KDE SVN synchronize script.
Jul 24 2018, 8:19 PM · Krita: Manual
guoyunhe requested review of D14342: KDE SVN synchronize script.
Jul 24 2018, 8:17 PM · Krita: Manual
guoyunhe committed R883:1520846: Update Krita document translation templates.
Update Krita document translation templates
Jul 24 2018, 6:30 PM
guoyunhe committed R883:1520835: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jul 24 2018, 4:13 PM
guoyunhe committed R883:1520834: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jul 24 2018, 4:13 PM
guoyunhe committed R883:1520833: Update Krita Document templates.
Update Krita Document templates
Jul 24 2018, 4:12 PM

Jul 3 2018

guoyunhe committed R883:1519171: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jul 3 2018, 5:51 PM
guoyunhe committed R883:1519170: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jul 3 2018, 5:51 PM

Jun 27 2018

guoyunhe committed R883:1518785: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jun 27 2018, 9:32 AM
guoyunhe committed R883:1518784: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jun 27 2018, 9:32 AM

Jun 19 2018

guoyunhe committed R883:1518266: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jun 19 2018, 6:08 PM
guoyunhe committed R883:1518265: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jun 19 2018, 6:08 PM

Jun 17 2018

guoyunhe added a comment to D13567: Smaller steps for animation speed option.

If there is a mechanism...

https://techbase.kde.org/Development/Tools/Using_kconf_update

But if we're going to do any migration, I have a proposal that's a tiny bit more work, but IMHO better long term:
Lets store the factor in the config.

It would also tie in a lot better with proposed suggestions to sync kwin and plasma animation speeds, something that's rather awkward with kwin's current rather arbitrary "3" for standard.

The KCM can still show a discrete slider, it's just changing the underlying data storage if we're going to change it anyway.

Jun 17 2018, 7:48 PM · KWin
guoyunhe added a comment to D13567: Smaller steps for animation speed option.

We don't break users configuration. There is nothing which justifies that. For example: if the user configured a wallpaper the new wallpaper won't replace it. Only default values my be modified by updates. As soon as a user configured a setting it must not be changed. Users need to be able to trust their software.

We btw have a mechanism to transform configurations. But as I said I don't think all of that is needed. I understand that you want this functionality and it's great that you implemented it, but I very much doubt that it is an improvement for the overall userbase. Due to the fact that the values are no longer balanced I think this degrades the overall user experience.

Jun 17 2018, 9:46 AM · KWin

Jun 16 2018

guoyunhe added a comment to D13567: Smaller steps for animation speed option.

This would break configurations of users.

Also I don't think that such a change is needed as I already expressed in the bug report. It is possible to adjust the speed on a per effect level. I doubt that any user would benefit from a higher granularity.

If users' configuration is one of 0, 1, 2, 3, it won't change anything. If users' configuration is 4, 5 or 6. It only get slightly faster, nothing break.

That means it breaks. It's a change to their configured setting and this is the definition of breakage.

Jun 16 2018, 4:51 PM · KWin
guoyunhe added a comment to D13567: Smaller steps for animation speed option.

This would break configurations of users.

Also I don't think that such a change is needed as I already expressed in the bug report. It is possible to adjust the speed on a per effect level. I doubt that any user would benefit from a higher granularity.

Jun 16 2018, 4:01 PM · KWin
guoyunhe added inline comments to D13567: Smaller steps for animation speed option.
Jun 16 2018, 10:42 AM · KWin
guoyunhe updated the diff for D13567: Smaller steps for animation speed option.
  • Add one stdset="0" back
Jun 16 2018, 10:42 AM · KWin
guoyunhe updated the diff for D13567: Smaller steps for animation speed option.
  • Revert stdset="0" added by Qt Designer
Jun 16 2018, 10:38 AM · KWin
guoyunhe added inline comments to D13567: Smaller steps for animation speed option.
Jun 16 2018, 10:34 AM · KWin
guoyunhe added a reviewer for D13567: Smaller steps for animation speed option: KWin.
Jun 16 2018, 10:25 AM · KWin
guoyunhe updated the diff for D13567: Smaller steps for animation speed option.
  • Fix space format
Jun 16 2018, 10:23 AM · KWin
guoyunhe requested review of D13567: Smaller steps for animation speed option.
Jun 16 2018, 10:13 AM · KWin

Jun 12 2018

guoyunhe committed R883:1517792: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jun 12 2018, 10:52 PM
guoyunhe committed R883:1517791: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jun 12 2018, 10:52 PM

May 18 2018

guoyunhe committed R883:1515917: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
May 18 2018, 11:15 AM
guoyunhe committed R883:1515916: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
May 18 2018, 10:53 AM
guoyunhe committed R883:1515915: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
May 18 2018, 10:08 AM

Apr 26 2018

guoyunhe committed R883:1514616: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Apr 26 2018, 10:49 AM
guoyunhe committed R883:1514612: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Apr 26 2018, 10:35 AM

Apr 17 2018

guoyunhe committed R883:1514145: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Apr 17 2018, 10:06 AM
guoyunhe committed R883:1514144: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Apr 17 2018, 10:04 AM

Apr 5 2018

guoyunhe committed R883:1513530: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Apr 5 2018, 4:53 PM
guoyunhe committed R883:1513529: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Apr 5 2018, 4:52 PM

Mar 29 2018

guoyunhe committed R883:1513118: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Mar 29 2018, 10:55 AM
guoyunhe committed R883:1513117: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Mar 29 2018, 10:54 AM

Mar 18 2018

guoyunhe committed R883:1512527: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Mar 18 2018, 11:49 PM
guoyunhe committed R883:1512526: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Mar 18 2018, 11:48 PM

Mar 16 2018

guoyunhe committed R883:1512397: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Mar 16 2018, 3:19 PM