guoyunhe (Yunhe Guo)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 3 2016, 7:25 PM (163 w, 5 d)
Availability
Available

Recent Activity

Fri, Aug 16

guoyunhe committed R883:1549819: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Fri, Aug 16, 5:30 PM
guoyunhe committed R883:1549818: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Fri, Aug 16, 5:30 PM

Wed, Aug 14

guoyunhe added a comment to D23161: Make media control icons outline style instead of solid style.

Yes, I did a search on the internet and almost all popular music app use solid play/pause/stop icon.

Wed, Aug 14, 8:45 PM · Frameworks
guoyunhe updated the diff for D23161: Make media control icons outline style instead of solid style.

22px icons

Wed, Aug 14, 8:42 PM · Frameworks
guoyunhe updated the diff for D23161: Make media control icons outline style instead of solid style.

Correct SVG format

Wed, Aug 14, 8:13 PM · Frameworks
guoyunhe updated the summary of D23161: Make media control icons outline style instead of solid style.
Wed, Aug 14, 8:00 PM · Frameworks
guoyunhe requested review of D23161: Make media control icons outline style instead of solid style.
Wed, Aug 14, 7:57 PM · Frameworks

Sun, Aug 11

guoyunhe updated the diff for D22535: Make kimpanel a system tray applet.
  • avoid state jumping. lock state when opening kimpanel.
Sun, Aug 11, 8:51 PM · Plasma
guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

Uploaded latest code. It is unfinished. Just for anyone who may accidentally be interested.

Sun, Aug 11, 7:01 PM · Plasma
guoyunhe abandoned D22535: Make kimpanel a system tray applet.
Sun, Aug 11, 6:26 PM · Plasma
guoyunhe updated the diff for D22535: Make kimpanel a system tray applet.
  • UNFINISHED: show icon of current input method in system tray
Sun, Aug 11, 6:25 PM · Plasma
guoyunhe abandoned D22535: Make kimpanel a system tray applet.
Sun, Aug 11, 6:17 PM · Plasma
guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

Added context menu actions to configure keyboard and fcitx. @ngraham do we KCM of ibus or scim?

Sun, Aug 11, 3:38 PM · Plasma
guoyunhe updated the summary of D22535: Make kimpanel a system tray applet.
Sun, Aug 11, 2:48 PM · Plasma

Sat, Aug 10

guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

Making the layout of status panel:

Sat, Aug 10, 8:34 PM · Plasma
guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

Did you delete the old KCM first? If not, it will take precedence and you won't see the new one. The old one is located in the following location:

  • Ubuntu-based distros: [install prefix]/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_keyboard.so
  • Other distros: [install prefix]/usr/lib/qt/plugins/kcm_keyboard.so

    Regardless, I'm super excited to see @gpark's work get revived!
Sat, Aug 10, 7:34 PM · Plasma
guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

I tried to merge @gpark 's branch. It is compiled but I cannot reproduce the UI as shown in demo video. I am not sure how it is connected. So I leave that part untouched for now. I hope I can get in touch with @gpark to understand how the code works. Then we can make another patch for KCM and OSD modules.

Sat, Aug 10, 10:23 AM · Plasma

Fri, Aug 9

guoyunhe added a comment to D22535: Make kimpanel a system tray applet.

@gpark I am trying to pull all your changes into this patch. If I understand correctly, your work is in new_keyboard_kcm branch of repo https://cgit.kde.org/clones/plasma-desktop/gpark/gsoc-kcm-keyboard-revamp.git ?

Fri, Aug 9, 6:07 PM · Plasma
guoyunhe updated the summary of D22535: Make kimpanel a system tray applet.
Fri, Aug 9, 5:28 PM · Plasma
guoyunhe requested review of D23051: Make file bookmark names consistent.
Fri, Aug 9, 4:34 PM · Frameworks

Thu, Aug 8

guoyunhe added a comment to D22925: Fix Unsplash POTD not updating.

It works now. Tested with several different POTD providers.

Thu, Aug 8, 10:55 AM · Plasma

Wed, Aug 7

guoyunhe updated the diff for D22925: Fix Unsplash POTD not updating.

Add import

Wed, Aug 7, 4:55 PM · Plasma
guoyunhe updated the diff for D22925: Fix Unsplash POTD not updating.

Fix CacheProvider's cache validation function

Wed, Aug 7, 4:53 PM · Plasma
guoyunhe added a comment to D22925: Fix Unsplash POTD not updating.

This is not working. Unsplash wallpapers still don't update daily. I need further debugging.

Wed, Aug 7, 10:59 AM · Plasma

Sun, Aug 4

guoyunhe added a comment to D22925: Fix Unsplash POTD not updating.

Have you tested to make sure this doesn't break other providers?

Sun, Aug 4, 2:29 PM · Plasma
guoyunhe updated the summary of D22925: Fix Unsplash POTD not updating.
Sun, Aug 4, 12:52 PM · Plasma
guoyunhe added a reviewer for D22925: Fix Unsplash POTD not updating: Plasma.
Sun, Aug 4, 12:50 PM · Plasma
guoyunhe requested review of D22925: Fix Unsplash POTD not updating.
Sun, Aug 4, 12:49 PM · Plasma

Sat, Jul 27

guoyunhe added inline comments to D22494: Attempt to support different collections of Unsplash.
Sat, Jul 27, 11:04 AM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
  • Unsplash category combobox
Sat, Jul 27, 11:04 AM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
  • Unsplash category combobox
Sat, Jul 27, 10:57 AM · Plasma
guoyunhe added inline comments to D22494: Attempt to support different collections of Unsplash.
Sat, Jul 27, 10:36 AM · Plasma

Fri, Jul 26

guoyunhe added a comment to D22494: Attempt to support different collections of Unsplash.

One UI improvement I could see is to allow multi-selection of categories, so for example you could see images from all the nature-related categories but not Car or Sports.

The way I'd envision this working is that instead of a combo box, a label would display the currently selected categories. Next to it would be a button labeled "Change categories" that would use the multi-page KCM API to take the user to another page with a checkbox for each category. This page would allow selecting any assortment of categories, which would then be listed on the main page. It would be sort of like the corner selector UI in the new Notifications KCM.

Fri, Jul 26, 11:10 AM · Plasma

Thu, Jul 25

guoyunhe added a comment to D22494: Attempt to support different collections of Unsplash.

Nice!

How about adding an "All" entry for the combo box which would show you wallpapers from any category? Is that possible?

Thu, Jul 25, 5:46 PM · Plasma
guoyunhe added a comment to D22494: Attempt to support different collections of Unsplash.

Now it is working again! You will have a Category combobox to choose photo collections from Unsplash

Thu, Jul 25, 3:47 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
  • Unsplash category combobox
Thu, Jul 25, 3:45 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
  • Unsplash category combobox
Thu, Jul 25, 3:42 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
  • Unsplash category combobox
Thu, Jul 25, 3:40 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
  • Unsplash category combobox
Thu, Jul 25, 3:39 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
  • Unsplash category combobox
Thu, Jul 25, 3:38 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
Fix crashing
Thu, Jul 25, 2:29 PM · Plasma
guoyunhe added a comment to D22494: Attempt to support different collections of Unsplash.

The new change try to add a new ComboBox "Category" and pass the value to PODT data engine. This also introduced a new configuration option. But now it makes plasmashell crash without useful error output.

Thu, Jul 25, 1:32 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
  • Unsplash category combobox
Thu, Jul 25, 1:28 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.
  • Unsplash category combobox
Thu, Jul 25, 1:27 PM · Plasma
guoyunhe updated subscribers of D22535: Make kimpanel a system tray applet.

Thanks @hein ! I will check the GSoC project and see if I can continue with that. I see the original author of Kimpanel is @xuetianweng . Let's listen to his opinion.

Thu, Jul 25, 8:38 AM · Plasma

Jul 24 2019

guoyunhe added a comment to D22535: Make kimpanel a system tray applet.
  • The settings window needs to actually offer a way to add and configure input methods. When I look at this very barebones settings window, I have no idea what to do:
Jul 24 2019, 10:40 PM · Plasma

Jul 21 2019

guoyunhe added a comment to D22494: Attempt to support different collections of Unsplash.

Could we only have Unsplash as the provider and the an additional combobox that would allow choosing the category?

+1, this should be a single Unsplash plugin whose user-facing UI has a combobox allowing you to specify the collection.

Jul 21 2019, 8:44 PM · Plasma

Jul 19 2019

guoyunhe added a comment to D22535: Make kimpanel a system tray applet.
In D22535#497694, @apol wrote:

There's already several things in the system tray with a keyboard icon (all different keyboards! xD)
Maybe we could make something a bit more recognizable?

Jul 19 2019, 8:29 AM · Plasma

Jul 18 2019

guoyunhe updated the summary of D22535: Make kimpanel a system tray applet.
Jul 18 2019, 7:01 PM · Plasma
guoyunhe updated the summary of D22535: Make kimpanel a system tray applet.
Jul 18 2019, 7:00 PM · Plasma
guoyunhe requested review of D22535: Make kimpanel a system tray applet.
Jul 18 2019, 6:58 PM · Plasma
guoyunhe committed R883:1547014: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jul 18 2019, 3:33 PM
guoyunhe committed R883:1547013: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jul 18 2019, 3:32 PM

Jul 17 2019

guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.

Change default collectionId to all wallpapers instead of desktop wallpaper

Jul 17 2019, 10:53 AM · Plasma
guoyunhe updated the summary of D22494: Attempt to support different collections of Unsplash.
Jul 17 2019, 10:48 AM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.

Add all Unsplash Wallpaper collections

Jul 17 2019, 10:39 AM · Plasma

Jul 16 2019

guoyunhe updated the summary of D22494: Attempt to support different collections of Unsplash.
Jul 16 2019, 8:10 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.

Better naming

Jul 16 2019, 8:04 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.

Use constructor parameter to pass collection ID

Jul 16 2019, 7:52 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.

Remove KIO linking

Jul 16 2019, 7:40 PM · Plasma
guoyunhe updated the summary of D22494: Attempt to support different collections of Unsplash.
Jul 16 2019, 7:38 PM · Plasma
guoyunhe updated the diff for D22494: Attempt to support different collections of Unsplash.

Solve linking issue

Jul 16 2019, 7:36 PM · Plasma
guoyunhe updated the summary of D22494: Attempt to support different collections of Unsplash.
Jul 16 2019, 6:59 PM · Plasma
guoyunhe requested review of D22494: Attempt to support different collections of Unsplash.
Jul 16 2019, 6:56 PM · Plasma

Jul 14 2019

guoyunhe added a comment to D22451: Unsplash POTD: filter out banner image and pick random photo from latest.

Ah right, that's a property of Image, not QImageItem.

https://doc.qt.io/qt-5/qml-qtquick-image.html#sourceSize-prop

Can you use Image instead?

Jul 14 2019, 12:02 PM · Plasma
guoyunhe added a comment to D22451: Unsplash POTD: filter out banner image and pick random photo from latest.

Instead of smooth: true doing this may achieve the same result with less memory usage:

sourceSize.width: parent.width
sourceSize.height: parent.height
Jul 14 2019, 11:36 AM · Plasma
guoyunhe updated the diff for D22451: Unsplash POTD: filter out banner image and pick random photo from latest.

Enable smoothing for POTD wallpaper

Jul 14 2019, 8:14 AM · Plasma
guoyunhe added a reviewer for D22451: Unsplash POTD: filter out banner image and pick random photo from latest: Plasma.
Jul 14 2019, 8:08 AM · Plasma
guoyunhe requested review of D22451: Unsplash POTD: filter out banner image and pick random photo from latest.
Jul 14 2019, 8:04 AM · Plasma

Jul 12 2019

guoyunhe updated the diff for D22426: Add Unsplash POTD Provider.

Fix Unix new line format

Jul 12 2019, 9:15 PM · Plasma
guoyunhe added a comment to D22426: Add Unsplash POTD Provider.

Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues.

Jul 12 2019, 7:26 PM · Plasma
guoyunhe added a reviewer for D22426: Add Unsplash POTD Provider: Plasma.
Jul 12 2019, 7:09 PM · Plasma
guoyunhe requested review of D22426: Add Unsplash POTD Provider.
Jul 12 2019, 7:08 PM · Plasma

Jun 2 2019

guoyunhe committed R883:1543163: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jun 2 2019, 1:31 PM
guoyunhe committed R883:1543162: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jun 2 2019, 1:30 PM

May 5 2019

guoyunhe committed R883:1541121: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
May 5 2019, 10:52 PM
guoyunhe committed R883:1541120: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
May 5 2019, 10:52 PM

Apr 26 2019

guoyunhe abandoned D19812: Add a web page to view and compare icons of different sizes.

Using a library can save a lot of time. Just like many simple web pages use jQuery, D3, etc.

Apr 26 2019, 7:35 PM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

The documentation website of krita is a different type of repository. This project is going to be distributed and compiled by the distributions, and many of them will have to patch out the minified javascript and replace it with a dependency on a proper packaged version. The idea is that the minified (obscured) version is not the preferred form of distribution (not the "source code"), more or less. So special care should be taken here.

Apr 26 2019, 6:15 PM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

The code is stable version Vue.js. Source is here https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.min.js
Uncompiled version is here https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.js

Apr 26 2019, 6:09 PM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. This would be the perfect place to sneak in malware (not saying you or the author have done this, but that this kind of obfuscated code is a perfect vector for it).

Apr 26 2019, 5:53 PM · Frameworks

Apr 25 2019

guoyunhe committed R883:1540524: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Apr 25 2019, 2:44 PM
guoyunhe committed R883:1540522: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Apr 25 2019, 2:43 PM

Apr 24 2019

guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Hi @ngraham @pino @bcooksley , I have updated the script/configuration. Can you give some further opinion?

Apr 24 2019, 12:11 PM · Frameworks

Apr 10 2019

guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Hi all,

Apr 10 2019, 2:36 PM · Frameworks

Apr 9 2019

guoyunhe committed R883:1539481: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Apr 9 2019, 7:35 PM
guoyunhe committed R883:1539480: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Apr 9 2019, 7:29 PM

Mar 27 2019

guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Output to stderr

Mar 27 2019, 6:35 AM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Don't use remote JavaScript library

Mar 27 2019, 6:25 AM · Frameworks

Mar 24 2019

guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Fix typo

Mar 24 2019, 4:38 PM · Frameworks

Mar 22 2019

guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Improve bash script

Mar 22 2019, 10:55 AM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.
In D19812#436154, @pino wrote:
  • please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to empty string (to prevent typos)
Mar 22 2019, 10:35 AM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Add search function

Mar 22 2019, 7:47 AM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Mar 22 2019, 6:35 AM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Add color blind mode

Mar 22 2019, 6:32 AM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Move build files to CMake build directory

Mar 22 2019, 6:20 AM · Frameworks

Mar 18 2019

guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Thanks, it compiles with CMake now! \o/

I'm not a fan of how it dumps all this stuff in the source directory. Ideally it would put everything to the build directory when doing an out-of-source build so the source dir isn't cluttered up with transient and rapidly-changing information. Then you also wouldn't need to add these files to gitignore.

Mar 18 2019, 11:16 PM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Use typical Breeze background colors

Mar 18 2019, 7:45 PM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Could you use #eff0f1 and #31363b for the light and dark backgrounds since those are the colors we normally use for window backgrounds?

Mar 18 2019, 7:43 PM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Getting closer:

Scanning dependencies of target generate-web
make[2]: generate_web_data.sh: Command not found
CMakeFiles/generate-web.dir/build.make:57: recipe for target 'CMakeFiles/generate-web' failed

Are you able to test this yourself?

Mar 18 2019, 7:05 PM · Frameworks