guoyunhe (Yunhe Guo)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 3 2016, 7:25 PM (146 w, 11 h)
Availability
Available

Recent Activity

Wed, Apr 10

guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Hi all,

Wed, Apr 10, 2:36 PM · Frameworks

Tue, Apr 9

guoyunhe committed R883:1539481: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Tue, Apr 9, 7:35 PM
guoyunhe committed R883:1539480: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Tue, Apr 9, 7:29 PM

Wed, Mar 27

guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Output to stderr

Wed, Mar 27, 6:35 AM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Don't use remote JavaScript library

Wed, Mar 27, 6:25 AM · Frameworks

Sun, Mar 24

guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Fix typo

Sun, Mar 24, 4:38 PM · Frameworks

Mar 22 2019

guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Improve bash script

Mar 22 2019, 10:55 AM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.
In D19812#436154, @pino wrote:
  • please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to empty string (to prevent typos)
Mar 22 2019, 10:35 AM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Add search function

Mar 22 2019, 7:47 AM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Mar 22 2019, 6:35 AM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Add color blind mode

Mar 22 2019, 6:32 AM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Move build files to CMake build directory

Mar 22 2019, 6:20 AM · Frameworks

Mar 18 2019

guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Thanks, it compiles with CMake now! \o/

I'm not a fan of how it dumps all this stuff in the source directory. Ideally it would put everything to the build directory when doing an out-of-source build so the source dir isn't cluttered up with transient and rapidly-changing information. Then you also wouldn't need to add these files to gitignore.

Mar 18 2019, 11:16 PM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Use typical Breeze background colors

Mar 18 2019, 7:45 PM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Could you use #eff0f1 and #31363b for the light and dark backgrounds since those are the colors we normally use for window backgrounds?

Mar 18 2019, 7:43 PM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Getting closer:

Scanning dependencies of target generate-web
make[2]: generate_web_data.sh: Command not found
CMakeFiles/generate-web.dir/build.make:57: recipe for target 'CMakeFiles/generate-web' failed

Are you able to test this yourself?

Mar 18 2019, 7:05 PM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Add ${CMAKE_SOURCE_DIR} prefix to script

Mar 18 2019, 7:03 PM · Frameworks

Mar 17 2019

guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Move outside of generate_binary_resource

Mar 17 2019, 1:02 AM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

I assume this fetches the icons from your local system?

Mar 17 2019, 12:59 AM · Frameworks

Mar 16 2019

guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.
Mar 16 2019, 10:59 PM · Frameworks
guoyunhe added a comment to D19812: Add a web page to view and compare icons of different sizes.

Neato! Looks pretty handy. Two issues I found:

  • generate_web_data.sh isn't executable
  • I'd like to see this run as part of the build process, so that index.html gets updated automatically, and so running it doesn't pollute your source folder since you're of course doing out-of-source builds :) Then you don't have to add the generated text files to .gitignore.
Mar 16 2019, 10:57 PM · Frameworks
guoyunhe added a reviewer for D19812: Add a web page to view and compare icons of different sizes: Breeze.
Mar 16 2019, 10:55 PM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Add CMake build steps for web page

Mar 16 2019, 10:54 PM · Frameworks
guoyunhe updated the diff for D19812: Add a web page to view and compare icons of different sizes.

Fix data updating issues

Mar 16 2019, 10:44 PM · Frameworks
guoyunhe requested review of D19812: Add a web page to view and compare icons of different sizes.
Mar 16 2019, 10:30 PM · Frameworks

Mar 13 2019

guoyunhe added a comment to D17469: Give applications-games and input-gaming more contrast with Breeze Dark.

@guoyunhe Do you mind if I commandeer this?

Mar 13 2019, 8:18 AM · Frameworks

Mar 11 2019

guoyunhe requested review of D19689: Add Simplified Chinese (zh_CN) language selector option.
Mar 11 2019, 4:52 PM · Krita: Manual

Mar 7 2019

guoyunhe committed R883:1536812: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Mar 7 2019, 10:09 AM
guoyunhe committed R883:1536813: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Mar 7 2019, 10:09 AM

Feb 26 2019

guoyunhe added a comment to D18890: Add button to reset index database and repair Baloo crashing.
In D18890#419886, @mart wrote:

If we know the DB is corrupted, and it's just a cache, why do we need a user facing button?

It is also possible to move this function to database corruption handler. One thing I worry about is: if the database corruption is caused by software reason, it will repeat the corrupt-rebuild-corrupt dead loop...

maybe also add an heuristic that if has been automatically rebuilt more than x times in the last y time, stop doing it?

Feb 26 2019, 7:06 PM · Baloo, Plasma

Feb 21 2019

guoyunhe committed R883:1535857: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Feb 21 2019, 12:03 AM

Feb 20 2019

guoyunhe committed R883:1535856: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Feb 20 2019, 11:57 PM

Feb 11 2019

guoyunhe added a comment to D18890: Add button to reset index database and repair Baloo crashing.

If we know the DB is corrupted, and it's just a cache, why do we need a user facing button?

Feb 11 2019, 7:40 PM · Baloo, Plasma
guoyunhe added inline comments to D18890: Add button to reset index database and repair Baloo crashing.
Feb 11 2019, 7:32 PM · Baloo, Plasma
guoyunhe updated the diff for D18890: Add button to reset index database and repair Baloo crashing.
  • Make message box translatable
Feb 11 2019, 7:07 PM · Baloo, Plasma
guoyunhe added a comment to D18890: Add button to reset index database and repair Baloo crashing.

Screenshot:

Feb 11 2019, 7:06 PM · Baloo, Plasma
guoyunhe updated the diff for D18890: Add button to reset index database and repair Baloo crashing.
  • Add message box for Rebuild Index Database button
Feb 11 2019, 7:05 PM · Baloo, Plasma

Feb 10 2019

guoyunhe added a comment to D18890: Add button to reset index database and repair Baloo crashing.

Great! Just one more UI suggestion: use the string "Rebuild Index Database"

Feb 10 2019, 4:39 PM · Baloo, Plasma
guoyunhe updated the diff for D18890: Add button to reset index database and repair Baloo crashing.
  • Reset index database button align right
Feb 10 2019, 4:37 PM · Baloo, Plasma
guoyunhe added a comment to D18890: Add button to reset index database and repair Baloo crashing.

I wish this weren't necessary, but I think it's a good idea for the time being.

Can you reduce the button width so it doesn't span the entire layout? It should be as small as possible and right-aligned.

Feb 10 2019, 4:29 PM · Baloo, Plasma
guoyunhe updated the diff for D18890: Add button to reset index database and repair Baloo crashing.
  • Reset index database button align right
Feb 10 2019, 4:27 PM · Baloo, Plasma
guoyunhe added a project to D18890: Add button to reset index database and repair Baloo crashing: Baloo.
Feb 10 2019, 12:15 AM · Baloo, Plasma
guoyunhe added reviewers for D18890: Add button to reset index database and repair Baloo crashing: Plasma, Baloo.
Feb 10 2019, 12:15 AM · Baloo, Plasma
guoyunhe requested review of D18890: Add button to reset index database and repair Baloo crashing.
Feb 10 2019, 12:13 AM · Baloo, Plasma

Jan 27 2019

guoyunhe committed R883:1533980: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jan 27 2019, 11:26 PM
guoyunhe committed R883:1533979: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jan 27 2019, 11:25 PM

Jan 5 2019

guoyunhe committed R883:1532189: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jan 5 2019, 9:24 PM
guoyunhe committed R883:1532188: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jan 5 2019, 9:23 PM

Dec 27 2018

guoyunhe committed R883:1531536: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Dec 27 2018, 7:56 AM
guoyunhe committed R883:1531535: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Dec 27 2018, 7:55 AM

Dec 24 2018

guoyunhe updated the diff for D17773: Copy to Clipboard in English.

Hide the "Copy to Clipboard in English" button when the system is already in English.

Dec 24 2018, 12:53 PM · Plasma
guoyunhe added a comment to D17704: Copy to clipboard always copy English texts.

Here is another solution. https://phabricator.kde.org/D17773

Dec 24 2018, 9:50 AM · Plasma
guoyunhe added a reviewer for D17773: Copy to Clipboard in English: Plasma.
Dec 24 2018, 9:47 AM · Plasma
guoyunhe requested review of D17773: Copy to Clipboard in English.
Dec 24 2018, 9:45 AM · Plasma

Dec 20 2018

guoyunhe added a comment to D17704: Copy to clipboard always copy English texts.

I recall in the original patch that copying translated text was something that various folks specifically asked for. Is it really that useless? @gregormi, do you remember the context?

Dec 20 2018, 4:34 PM · Plasma
guoyunhe updated the diff for D17704: Copy to clipboard always copy English texts.

Use untranslated texts for clipboard label pairs

Dec 20 2018, 4:27 PM · Plasma
guoyunhe added a comment to D17704: Copy to clipboard always copy English texts.

If I understand your patch correctly, you only forbid translating the order of text, not the actual text labels.

Dec 20 2018, 3:17 PM · Plasma
guoyunhe added a reviewer for D17704: Copy to clipboard always copy English texts: Plasma.
Dec 20 2018, 9:08 AM · Plasma
guoyunhe requested review of D17704: Copy to clipboard always copy English texts.
Dec 20 2018, 8:14 AM · Plasma

Dec 11 2018

guoyunhe committed R883:1530541: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Dec 11 2018, 10:28 AM
guoyunhe committed R883:1530540: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Dec 11 2018, 10:28 AM

Dec 10 2018

guoyunhe added a comment to D17469: Give applications-games and input-gaming more contrast with Breeze Dark.

Here's a rough draft of something similar to the Logitech F 710, but with colors that are more similar to the original gray DualShock controller:

100%

200%

Dec 10 2018, 1:39 PM · Frameworks
guoyunhe updated the diff for D17469: Give applications-games and input-gaming more contrast with Breeze Dark.

Clean up Inkscape metadata

Dec 10 2018, 9:22 AM · Frameworks
guoyunhe updated the diff for D17469: Give applications-games and input-gaming more contrast with Breeze Dark.

Add modified icon with light background

Dec 10 2018, 9:14 AM · Frameworks
guoyunhe added a reviewer for D17469: Give applications-games and input-gaming more contrast with Breeze Dark: Breeze.
Dec 10 2018, 8:57 AM · Frameworks
guoyunhe requested review of D17469: Give applications-games and input-gaming more contrast with Breeze Dark.
Dec 10 2018, 8:56 AM · Frameworks

Nov 29 2018

guoyunhe requested review of D17246: Unify height of message editor and nickname selector.
Nov 29 2018, 9:35 PM

Nov 12 2018

guoyunhe committed R883:1528221: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Nov 12 2018, 10:33 AM
guoyunhe committed R883:1528220: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Nov 12 2018, 10:32 AM

Nov 7 2018

guoyunhe requested review of D16734: HiDPI: make icons sharp and smooth.
Nov 7 2018, 1:03 PM

Nov 2 2018

guoyunhe committed R883:1527603: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Nov 2 2018, 6:01 AM
guoyunhe committed R883:1527601: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Nov 2 2018, 6:01 AM

Oct 9 2018

guoyunhe committed R883:1526241: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Oct 9 2018, 7:14 PM
guoyunhe committed R883:1526240: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Oct 9 2018, 7:14 PM

Sep 28 2018

guoyunhe committed R883:1525461: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sep 28 2018, 8:42 PM
guoyunhe committed R883:1525460: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sep 28 2018, 8:42 PM

Sep 21 2018

guoyunhe committed R883:1525026: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sep 21 2018, 3:35 PM
guoyunhe committed R883:1525025: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sep 21 2018, 3:35 PM

Sep 10 2018

guoyunhe committed R883:1524520: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Sep 10 2018, 9:36 PM
guoyunhe committed R883:1524519: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sep 10 2018, 9:35 PM
guoyunhe committed R883:1524518: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Sep 10 2018, 9:00 PM

Aug 30 2018

guoyunhe committed R883:1523776: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Aug 30 2018, 2:01 PM
guoyunhe committed R883:1523775: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Aug 30 2018, 2:01 PM

Aug 22 2018

guoyunhe updated the diff for D14992: Crowdin localization workflow.
  • Use two letter language code
Aug 22 2018, 10:43 AM · Krita: Manual
guoyunhe added a comment to D14342: KDE SVN synchronize script.

Here is another solution using Crowdin platform https://phabricator.kde.org/D14992

Aug 22 2018, 10:05 AM · Krita: Manual
guoyunhe requested review of D14992: Crowdin localization workflow.
Aug 22 2018, 10:02 AM · Krita: Manual

Aug 20 2018

guoyunhe committed R883:1523002: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Aug 20 2018, 7:05 PM
guoyunhe committed R883:1523001: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Aug 20 2018, 7:04 PM
guoyunhe added a comment to D14342: KDE SVN synchronize script.

@ltoscano Do you know where is the script that handles StaticMessages.sh? I want to try if the script can be modified to support multiple pot files.

Aug 20 2018, 2:54 PM · Krita: Manual
guoyunhe added a comment to D14342: KDE SVN synchronize script.

Sorry, I totally forgot that we already discussed this and that StaticMessages.sh only create one file for repository.

The other solution would be helping us to extend the code which calls StaticMessages.sh to support more po files.

Aug 20 2018, 11:46 AM · Krita: Manual

Aug 1 2018

guoyunhe added a comment to D14342: KDE SVN synchronize script.

What worries me a bit is that this checks out the entire svn tree which is huge. Couldn't we make a list of languages that have manual translations, and only checkout out what we need?

Aug 1 2018, 9:57 AM · Krita: Manual

Jul 24 2018

guoyunhe updated the summary of D14342: KDE SVN synchronize script.
Jul 24 2018, 8:19 PM · Krita: Manual
guoyunhe requested review of D14342: KDE SVN synchronize script.
Jul 24 2018, 8:17 PM · Krita: Manual
guoyunhe committed R883:1520846: Update Krita document translation templates.
Update Krita document translation templates
Jul 24 2018, 6:30 PM
guoyunhe committed R883:1520835: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jul 24 2018, 4:13 PM
guoyunhe committed R883:1520834: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jul 24 2018, 4:13 PM
guoyunhe committed R883:1520833: Update Krita Document templates.
Update Krita Document templates
Jul 24 2018, 4:12 PM

Jul 3 2018

guoyunhe committed R883:1519171: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jul 3 2018, 5:51 PM
guoyunhe committed R883:1519170: Crowdin Sync [kf5-trunk] [zh_CN].
Crowdin Sync [kf5-trunk] [zh_CN]
Jul 3 2018, 5:51 PM

Jun 27 2018

guoyunhe committed R883:1518785: Crowdin Sync [kf5-stable] [zh_CN].
Crowdin Sync [kf5-stable] [zh_CN]
Jun 27 2018, 9:32 AM