Implement ISpellChecker backend for Windows >= 8
ClosedPublic
Actions

Authored by cullmann on Nov 10 2019, 6:28 PM.

Details

Reviewers

vonreth

Group Reviewers

Frameworks

Commits

Summary

Provide ISpellChecker backend for Sonnet on Windows
This avoids to ship all the hunspell dictionaries for Windows.

Repository

R246 Sonnet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

cullmann requested review of this revision.Nov 10 2019, 6:28 PM

Some feedback?
Else I would just try that.
For me it worked fine (obviously).

In D25244#562817, @cullmann wrote:

Some feedback?
Else I would just try that.
For me it worked fine (obviously).

I will try it out over the weekend. It's something I planned to work on myself, but you were faster ;)

Ok, thank you!

I've tried it out and works just fine! :)

Then we can merge this, or?

src/plugins/ispellchecker/ispellcheckerclient.cpp
34	is that needed? It should be handled by the qt main loop?
60	qt main loop again

cullmann marked 2 inline comments as done.Nov 17 2019, 11:45 AM

cullmann added inline comments.

src/plugins/ispellchecker/ispellcheckerclient.cpp
34	The docs state one shall do that in any case and that it stacks. I think there is no harm to do it, just to be sure com is correctly initialized.

This revision is now accepted and ready to land.Nov 17 2019, 1:59 PM

This revision was automatically updated to reflect the committed changes.

cullmann marked an inline comment as done.

This allows to shrink e.g. the Kate installation on Windows from 431 MB to 274 MB, > 150 MB space less occupied ;=)

		Path
M		src/plugins/CMakeLists.txt (4 lines)
A	M	src/plugins/ispellchecker/CMakeLists.txt (15 lines)
A	M	src/plugins/ispellchecker/ispellcheckerclient.h (63 lines)
A	M	src/plugins/ispellchecker/ispellcheckerclient.cpp (80 lines)
A	M	src/plugins/ispellchecker/ispellcheckerdict.h (47 lines)
A	M	src/plugins/ispellchecker/ispellcheckerdict.cpp (97 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69544	be0414d		Nov 10 2019, 6:28 PM	★	★
Diff 2	69874	ea92464	R246:67cbe8776a1f4cd8377494311f94ffbeed94faca	Nov 17 2019, 2:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
22b9d8b884ef	7230736a72f4	b44d966d1682	Christoph Cullmann	set win 8 or later in CMake	Nov 10 2019, 6:26 PM
b44d966d1682	6ff5d1811ca6	2aac19386005	Christoph Cullmann	implement more of the api, allow to add stuff to dict and ignore words	Nov 10 2019, 6:18 PM
2aac19386005	3fb08fb714a2	126b40f0a4e4	Christoph Cullmann	enable for windows	Nov 4 2019, 7:48 PM
126b40f0a4e4	c600bee1967e	64b9f099f129	Christoph Cullmann	suggest works, isCorrect not really	Nov 4 2019, 7:44 PM
64b9f099f129	3a40c4f98bfc	be0414de6b92	Christoph Cullmann	sonnet backend for Windows ISpellChecker COM interface works with Windows >= 8	Nov 4 2019, 7:11 PM