- User Since
- May 24 2016, 11:24 AM (133 w, 6 d)
Wed, Dec 5
Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" in particular. Is this really the trade-off we're faced with? It feels like there are upstream Qt bugs here.
Turns out the label width rounding is enough
Tue, Dec 4
Mon, Dec 3
Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read.
Can host/mprisplugin.cpp deal with payload being null properly?
Fri, Nov 30
I implemented the same hack here locally some time ago and it works perfectly fine if started with spectacle -platform xcb.
Thu, Nov 29
It might work as well to just ignore the "interrupted" state completely and only react when error becomes set.
Wed, Nov 28
OTOH, this patch actually causes a mismatch if one changes the cursor theme in Plasma's cursor theme KCM. (it won't affect GTK applications, they will continue to use breeze...)
Tue, Nov 27
Sat, Nov 24
Yeah, I had a feeling that that might end up as a better place for the fix. Someone else would need to do that patch or help me with it though. I gave it a shot but couldn't get the binding right.
IMO this workaround is generic enough that adding it into ScrollablePage.qml or even templates/private/ScrollView.qml itself is better as it hits almost every use.
Fri, Nov 23
LGTM, but I have no idea about this part of JS.
Thu, Nov 22
Nov 15 2018
Gave it a quick test as well, seems to work fine.
Nov 14 2018
Indeed, I just read the commit message in kcrash:
I'm wondering whether the .protocol to .json conversion is related, because it was part of the same commit.
It looks like all of that is already implemented in libwayland-server.
kwin_wayland just needs to make use of wl_display_add_socket_auto (other compositors do as well).
KWin doesn't need this functionality and shouldn't have this functionality and it would be difficult to implement.
Nov 11 2018
Edit: Indeed, AFAICS Neon's kcrash package seems to be from Oct. 12th...
Nov 6 2018
Looks good to me, but I don't know enough about old X11 stuff like this to accept it.
I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit message.
Nov 5 2018
Nov 3 2018
This file needs to be reformatted anyway.
Nov 2 2018
Use if-else ladder instead of switch-case and fix a typo.
Add Q_ASSERT and xcb_key_symbols_free.
Oct 27 2018
Fix bad merge
Fails to build the KDE4 version here:
Oct 26 2018
Don't use a union. Still works.
Note that the way it's done is
copied from inspired by QXcbConnection.
Oct 23 2018
Oct 21 2018
AFAICT Plasma/5.12 is affected as well, any reason this wasn't landed to 5.12?
Oct 20 2018
Oct 18 2018
Oct 9 2018
I removed the RFC - I'm using this patch since I uploaded and haven't had any issues so far.
Oct 8 2018
Oct 6 2018
Oct 4 2018
AFAICT this won't actually protect much - the open DBus socket is enough to execute arbitrary programs.
Oct 2 2018
Oct 1 2018
I'm not sure whether that's correct - a file with a duration of 1s still has a range of 1s.
LGTM. I just tried how the currentTime property in JS works, it actually behaves like MPRIS' seek does and does not ignore invalid values. That might need a check in SetPosition.
Seek has a different behaviour for position() + offset < 0 and position() + offset == m_length: