fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (151 w, 3 d)
Availability
Available

Recent Activity

Yesterday

fvogt added a comment to D20659: Copy container in Component::cleanUp before interating.
Thu, Apr 18, 6:06 PM · Frameworks
fvogt committed R268:78a711361db3: Copy container in Component::cleanUp before interating (authored by fvogt).
Copy container in Component::cleanUp before interating
Thu, Apr 18, 1:16 PM
fvogt closed D20659: Copy container in Component::cleanUp before interating.
Thu, Apr 18, 1:16 PM · Frameworks
fvogt retitled D20659: Copy container in Component::cleanUp before interating from Detach container in Component::cleanUp before interating to Copy container in Component::cleanUp before interating.
Thu, Apr 18, 12:57 PM · Frameworks
fvogt updated the test plan for D20659: Copy container in Component::cleanUp before interating.
Thu, Apr 18, 12:57 PM · Frameworks
fvogt updated the diff for D20659: Copy container in Component::cleanUp before interating.

Use auto (which might actually make it build)

Thu, Apr 18, 12:34 PM · Frameworks
fvogt requested review of D20659: Copy container in Component::cleanUp before interating.
Thu, Apr 18, 12:32 PM · Frameworks

Tue, Apr 16

fvogt accepted D20582: Only consider player gone if really no longer part of the visible DOM.
Tue, Apr 16, 9:31 AM · Plasma
fvogt accepted D20596: Set Breeze scrollbars only on HTML tag.

No idea about CSS - as this commit is about breaking the style for most cases though it's probably fine.

Tue, Apr 16, 8:49 AM · Plasma
fvogt accepted D20593: Minimize code duplication between node and its children.
Tue, Apr 16, 8:48 AM · Plasma

Mon, Apr 15

fvogt added a comment to D20582: Only consider player gone if really no longer part of the visible DOM.

I see an opportunity for code decuplication here... Not sure how though - maybe

Mon, Apr 15, 6:12 PM · Plasma
fvogt accepted D19857: [DownloadJob] Report total size only if known.
Mon, Apr 15, 6:04 PM · Plasma

Sat, Apr 13

fvogt accepted D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.

Code still looks good to me - I can't comment on the cmake parts though.

Sat, Apr 13, 11:29 AM · Frameworks

Tue, Apr 9

fvogt added a comment to D20407: [Folder View] Improve label crispness.

Sounds good enough to me, let's get this in so openQA won't complain anymore

Tue, Apr 9, 4:51 PM · Plasma
fvogt added a comment to D20407: [Folder View] Improve label crispness.

It was actually discovered by openQA as a regression introduced yesterday: https://openqa.opensuse.org/tests/902646#step/finish_desktop/8 (bad) vs https://openqa.opensuse.org/tests/902110#step/finish_desktop/2 (good)
Probably a side effect of the label width change(s).

Tue, Apr 9, 2:44 PM · Plasma

Mon, Apr 8

fvogt added inline comments to D20227: Remove player from known players list when it disappears.
Mon, Apr 8, 8:53 AM · Plasma

Sun, Apr 7

fvogt accepted D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.
Sun, Apr 7, 10:07 AM · Frameworks

Sat, Apr 6

fvogt added a comment to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.

Looking good to me, @bruns: any addiitonal comments?

Sat, Apr 6, 12:14 PM · Frameworks
fvogt requested changes to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.

Looks good to me otherwise.

Sat, Apr 6, 9:59 AM · Frameworks

Fri, Apr 5

fvogt committed R98:9aa944ead1a8: Merge branch 'Plasma/5.15' (authored by fvogt).
Merge branch 'Plasma/5.15'
Fri, Apr 5, 8:27 AM
fvogt added a comment to D17187: Set the default cursor theme to breeze_cursors.

I just noticed that this change is missing again in 5.15.
Apparently it was reverted (by mistake?) in R98:e1f97ce5 ...

Fri, Apr 5, 8:26 AM · Plasma
fvogt committed R98:b00e12ff3926: Set the default cursor theme to breeze_cursors (authored by fvogt).
Set the default cursor theme to breeze_cursors
Fri, Apr 5, 8:25 AM
fvogt requested changes to D20259: Fix compilation with LibreSSL.

So libressl's API is mostly openssl < 1.1 with some 1.1 functions sprinkled in? That's annoying.
It might be easier to adjust the check for OSSL_110 to not set it with libressl.

Fri, Apr 5, 7:55 AM
fvogt added a comment to D20259: Fix compilation with LibreSSL.

Can you reupload this diff with context?

Fri, Apr 5, 6:56 AM

Tue, Apr 2

fvogt accepted D20201: Fix build with Qt 4.
Tue, Apr 2, 1:20 PM · Plasma
fvogt requested changes to D20201: Fix build with Qt 4.
Tue, Apr 2, 1:11 PM · Plasma
fvogt requested changes to D19857: [DownloadJob] Report total size only if known.

Additionally, the bytesReceived > totalAmount case is currently not handled at all, but I'm not sure whether that's something for KJob or here.

Tue, Apr 2, 9:50 AM · Plasma
fvogt added a comment to D20135: Enable the k3b helper by default.

Adding security team so we can have a second set of eyes on the helper, i couldn't find anything obviously wrong, but you know how auth helpers are :)

Tue, Apr 2, 7:30 AM

Mon, Apr 1

fvogt added a comment to D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz.

I'm very much in favor of this, but don't know anything about the cmake magic involved, so can't really say much about that.

Mon, Apr 1, 12:39 PM · Frameworks

Sun, Mar 31

fvogt added a comment to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.

So unless I am mistaken, I feel this is not a great concern.
I would perhaps need to restrict when statx is used even when STATX_BASIC_STATS is defined to when GLIBC is defined as well.

Yes, please do that.

Will do.

And thinking again about the issue, could we have kio compiled with glibc but running on a system with musl for instance ?
If it is possible, then I need to treat this case as you suggested to handle the runtime dependency on glibc.

Sun, Mar 31, 11:38 AM · Frameworks
fvogt added a comment to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.
In D20096#440830, @pino wrote:

Note that, even if the system supports statx() (so with glibc >= 2.28), you must support systems without it at runtime anyway: for example, if you boot with a kernel older than 4.11 (which IIRC is the version where the syscall was added) then the glibc function will return ENOSYS (IIRC, better check). This can happen for example in containers: you boot a Debian testing container (so with glibc 2.28) on a Debian stable system (with Linux 4.9).

This case is covered by glibc https://github.com/lattera/glibc/blob/895ef79e04a953cac1493863bcae29ad85657ee1/sysdeps/unix/sysv/linux/statx.c
In case the syscall does not exist, glibc provides a generic implementation based on stat.

There are platforms out there which don't use glibc. So I suggest either handling ENOSYS properly by falling back to stat or erroring out if statx is supported but GLIBC not defined.

If the platform does not use glibc, STATX_BASIC_STATS will be false and statx won't be called, the other existing code path will be used.
STATX_BASIC_STATS implies GLIBC and statx availability at least until other C standard libraries support it.

Sun, Mar 31, 11:06 AM · Frameworks
fvogt added a comment to D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28.
In D20096#440830, @pino wrote:

Note that, even if the system supports statx() (so with glibc >= 2.28), you must support systems without it at runtime anyway: for example, if you boot with a kernel older than 4.11 (which IIRC is the version where the syscall was added) then the glibc function will return ENOSYS (IIRC, better check). This can happen for example in containers: you boot a Debian testing container (so with glibc 2.28) on a Debian stable system (with Linux 4.9).

This case is covered by glibc https://github.com/lattera/glibc/blob/895ef79e04a953cac1493863bcae29ad85657ee1/sysdeps/unix/sysv/linux/statx.c
In case the syscall does not exist, glibc provides a generic implementation based on stat.

Sun, Mar 31, 10:16 AM · Frameworks

Sun, Mar 24

fvogt added a comment to T10263: FUSE daemon for accessing KIO Slaves.

@feverfew Sure! I don't know much about GSoC though, I hope that's not an issue.

@fvogt Great, I can tell you more about it on a platform of your choice. What's your preferred method of contact (.e.g email) so we can get a project submitted (deadline is 9th April)?

Sun, Mar 24, 8:26 PM

Mar 19 2019

fvogt added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.

This wasn't supposed to land in Plasma 5.15 as well as master?

Mar 19 2019, 1:56 PM · Frameworks
fvogt committed R242:3aba8a7e10e5: Fix breeze dialog background with Qt 5.12.2 (authored by fvogt).
Fix breeze dialog background with Qt 5.12.2
Mar 19 2019, 1:53 PM
fvogt closed D19821: Fix breeze dialog background with Qt 5.12.2.
Mar 19 2019, 1:53 PM · Frameworks
fvogt added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.

I guess it is very likely, but all the same for the record I will request that this results in a 5.56.2 release of plasma-framework.

Mar 19 2019, 1:52 PM · Frameworks
fvogt added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.

Does this patch cover tooltips as shown in https://i.imgur.com/WrISfNg.png ?

Mar 19 2019, 12:58 PM · Frameworks
fvogt added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.

Is anyone able to review this? If there's no review in 24h I'll merge it as it affects users severely and the fix is trivial.

Mar 19 2019, 8:51 AM · Frameworks

Mar 18 2019

fvogt added a comment to D19821: Fix breeze dialog background with Qt 5.12.2.

There's a special case in ./src/desktoptheme/breeze/icons/audio.svgz and .../battery.svgz: It has color scheme definitions both in a <style id="current-color-scheme" type="text/css"> and a <style type="text/css" id="style5"> element.
It shouldn't have an impact on this bug in particular, but it does still look wrong.

Mar 18 2019, 8:04 AM · Frameworks
fvogt updated the diff for D19821: Fix breeze dialog background with Qt 5.12.2.

One more file.

Mar 18 2019, 8:03 AM · Frameworks

Mar 17 2019

fvogt updated the summary of D19821: Fix breeze dialog background with Qt 5.12.2.
Mar 17 2019, 8:21 PM · Frameworks
fvogt updated the diff for D19821: Fix breeze dialog background with Qt 5.12.2.

Keep the style element, but assign id and type. Fix tooltip.svgz as well.

Mar 17 2019, 8:20 PM · Frameworks
fvogt updated the summary of D19821: Fix breeze dialog background with Qt 5.12.2.
Mar 17 2019, 11:24 AM · Frameworks
fvogt requested review of D19821: Fix breeze dialog background with Qt 5.12.2.
Mar 17 2019, 11:24 AM · Frameworks

Mar 16 2019

fvogt added a comment to T10263: FUSE daemon for accessing KIO Slaves.

@feverfew Sure! I don't know much about GSoC though, I hope that's not an issue.

Mar 16 2019, 5:29 PM
fvogt added a comment to D18845: authority: add support for passing details to polkit.

LGTM to me as well - I'm not familiar with this code at all though.

Mar 16 2019, 10:28 AM

Mar 12 2019

fvogt accepted D19707: Make QQC2 desktop style a RUNTIME dependency.
Mar 12 2019, 2:10 PM · Plasma
fvogt added inline comments to D19707: Make QQC2 desktop style a RUNTIME dependency.
Mar 12 2019, 12:49 PM · Plasma

Feb 27 2019

fvogt committed R242:02ec1b77c23e: Show a warning if a plugin requires a newer version (authored by fvogt).
Show a warning if a plugin requires a newer version
Feb 27 2019, 5:57 PM
fvogt closed D19394: Show a warning if a plugin requires a newer version.
Feb 27 2019, 5:57 PM · Frameworks
fvogt requested review of D19394: Show a warning if a plugin requires a newer version.
Feb 27 2019, 5:51 PM · Frameworks

Feb 21 2019

fvogt committed R120:4b0d05857842: Merge branch 'Plasma/5.15' (authored by fvogt).
Merge branch 'Plasma/5.15'
Feb 21 2019, 9:22 PM
fvogt committed R120:356a1fa9d808: Merge branch 'Plasma/5.12' into Plasma/5.15 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.15
Feb 21 2019, 9:22 PM
fvogt committed R120:7816978b5120: Don't show entries with NoDisplay=true with the applauncher containmentaction (authored by fvogt).
Don't show entries with NoDisplay=true with the applauncher containmentaction
Feb 21 2019, 9:20 PM
fvogt committed R120:8192bd3aec27: Don't show entries with NoDisplay=true with the applauncher containmentaction (authored by fvogt).
Don't show entries with NoDisplay=true with the applauncher containmentaction
Feb 21 2019, 9:19 PM
fvogt closed D19157: Don't show entries with NoDisplay=true with the applauncher containmentaction.
Feb 21 2019, 9:19 PM · Plasma

Feb 19 2019

fvogt requested review of D19157: Don't show entries with NoDisplay=true with the applauncher containmentaction.
Feb 19 2019, 2:10 PM · Plasma

Feb 17 2019

fvogt added a comment to D18735: Improve built-in line/block characters drawing.

Thanks for working on this - I think perhaps this should be committed to master after the 19.04 is branched next month. Objections?

Feb 17 2019, 9:13 PM · Konsole

Feb 15 2019

fvogt added a comment to D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog.

Can you add context to this diff by either using arc or git diff with more context?

Feb 15 2019, 7:52 AM · Frameworks

Feb 9 2019

fvogt resigned from D18735: Improve built-in line/block characters drawing.

I can confirm that it fixes all border display issues that I encountered in the released version.

Feb 9 2019, 10:31 AM · Konsole

Feb 8 2019

fvogt added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

Use @davidedmundson 's approach.

@ngraham Could you please help me to discard D18804 ? This patch does not require it anymore.

Feb 8 2019, 8:27 AM · Plasma

Feb 7 2019

fvogt added a reviewer for D18804: Workaround for the bug 393630 - Framework part: Plasma.
Feb 7 2019, 7:59 AM · Frameworks

Feb 6 2019

fvogt requested changes to D18735: Improve built-in line/block characters drawing.
Feb 6 2019, 7:18 PM · Konsole

Feb 5 2019

fvogt committed R296:856672f370fb: Correct the accept flag of the event object on DragMove (authored by trmdi).
Correct the accept flag of the event object on DragMove
Feb 5 2019, 7:01 PM
fvogt closed D16643: Correct the accept flag of the event object on DragMove .

Landed (phab didn't notice): https://cgit.kde.org/kdeclarative.git/commit/?id=856672f370fb32c7a3c3d1a13d873fb8b767d0e8

Feb 5 2019, 6:59 PM · Frameworks
fvogt accepted D16643: Correct the accept flag of the event object on DragMove .

@trmdi: Do you have push access? If not, which name <mail> should be used for the commit?

Feb 5 2019, 6:47 PM · Frameworks
fvogt added a comment to D16643: Correct the accept flag of the event object on DragMove .

@trmdi: Can you do the small change @bruns suggested? ^ Then it can be landed and everyone's happy :-)

Feb 5 2019, 2:51 PM · Frameworks
fvogt accepted D18750: Bail out if stream is negative.
Feb 5 2019, 10:37 AM
fvogt added a comment to D16643: Correct the accept flag of the event object on DragMove .

The second change fvogt mentioned is IMHO handled quite strangely here - !m_enabled || m_temporaryInhibition is the inverse of !m_enabled || m_temporaryInhibition, so doing a event->ignore() === event->setAccepted(false) prior to the first return statement would cover the ignored case, and allows the event to bubble up.

Feb 5 2019, 8:44 AM · Frameworks

Feb 2 2019

fvogt added a comment to D18662: Add and rename some YaST icons and symlinks.

@fvogt LCP said a Qt bug was the reason that the icons weren't working correctly and that you would know more about it. I never got around to asking you though. Do you know which bug it is?

Feb 2 2019, 11:02 AM · Frameworks

Jan 31 2019

fvogt added a comment to D16643: Correct the accept flag of the event object on DragMove .

I tried to understand what this change does both by trying to reproduce the issue and reading Qt code.
Here the symptom was more drags not getting accepted at all than flipping back and forth, but this patch fixes that as well.

Jan 31 2019, 8:23 PM · Frameworks

Jan 28 2019

fvogt committed R287:51d710adda14: Fix various OOB reads and writes in kimg_tga and kimg_xcf (authored by fvogt).
Fix various OOB reads and writes in kimg_tga and kimg_xcf
Jan 28 2019, 1:21 PM
fvogt closed D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.
Jan 28 2019, 1:21 PM · Frameworks
fvogt updated the test plan for D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.
Jan 28 2019, 9:29 AM · Frameworks
fvogt updated the diff for D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.

Also bail out early if image data known broken.
(Unrelated to the overflow fixes, but nice to have)

Jan 28 2019, 9:24 AM · Frameworks
fvogt requested review of D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.
Jan 28 2019, 8:41 AM · Frameworks

Jan 26 2019

fvogt added a comment to T10397: Qt 5.12 for plasma master.

We've had Qt 5.12 packaged and available since the first alpha and started to build KDE software against the second alpha - would it be possible to do it similarly in the KDE CI?
Starting to build also against pre-release Qt would be helpful as currently KDE CI is lagging behind what rolling release distros actually ship and it might help preventing some issues.

Jan 26 2019, 10:30 AM · build.kde.org

Jan 25 2019

fvogt accepted D18522: Name Wayland socket automatically when no socket name was specified.

Not tested, but looks correct to me. (Famous last words?)

Jan 25 2019, 12:34 PM · KWin
fvogt committed R127:d671fcd0c09d: Add option to use wl_display_add_socket_auto (authored by fvogt).
Add option to use wl_display_add_socket_auto
Jan 25 2019, 12:32 PM
fvogt closed D17122: Add option to use wl_display_add_socket_auto.
Jan 25 2019, 12:32 PM · Frameworks
fvogt updated the diff for D17122: Add option to use wl_display_add_socket_auto.

Replace XDG_RUNTIME_DIR, test still passes

Jan 25 2019, 12:25 PM · Frameworks
fvogt added inline comments to D17122: Add option to use wl_display_add_socket_auto.
Jan 25 2019, 12:15 PM · Frameworks

Jan 21 2019

fvogt accepted D10716: handle wrong password when using sudo which asks for another password.
Jan 21 2019, 1:05 PM · Frameworks

Jan 18 2019

fvogt added a comment to D18366: Fix flickering with Qt 5.12.

This should probably land on Plasma/5.12 as well.

Jan 18 2019, 7:49 PM · KWin
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.
Jan 18 2019, 11:57 AM · Frameworks
fvogt updated the diff for D17122: Add option to use wl_display_add_socket_auto.

Add some style

Jan 18 2019, 11:56 AM · Frameworks
fvogt updated the test plan for D17122: Add option to use wl_display_add_socket_auto.
Jan 18 2019, 10:50 AM · Frameworks
fvogt updated the diff for D17122: Add option to use wl_display_add_socket_auto.

Use a new bool instead.

Jan 18 2019, 10:49 AM · Frameworks
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.

Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old behavior.

That would need changes in KWin though so Plasma 5.16 only :-(

Yes, that's fine. Do you need it for something in 5.15?

Jan 18 2019, 10:21 AM · Frameworks
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.

Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old behavior.

Jan 18 2019, 10:05 AM · Frameworks
fvogt accepted D18353: Compile the virtual backend with older Mesa.

Builds fine!

Jan 18 2019, 10:03 AM · KWin
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.

I don't think we need a second variable effectiveSocketName. Just test if socketName is empty. If it is call wl_display_add_socket_auto, otherwise call wl_display_add_socket.

If socketName is overwritten after using wl_display_add_socket_auto, it's not possible to call start twice without resetting socketName again.

If the actual socket's name is not written to any variable, it's impossible to set WAYLAND_DISPLAY correctly in KWin.

The new variable is used to be fully API compatible except if socketName was explicitly set to an empty string.

Is a Display object meant to be started and terminated more than once? But ok, let's make sure.

Jan 18 2019, 8:48 AM · Frameworks
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.

I don't think we need a second variable effectiveSocketName. Just test if socketName is empty. If it is call wl_display_add_socket_auto, otherwise call wl_display_add_socket.

Jan 18 2019, 7:47 AM · Frameworks

Jan 17 2019

fvogt accepted D18309: don't set python exe to undefined.

Tested with cmake 3.10.2, works.

Jan 17 2019, 8:11 AM · Plasma

Jan 15 2019

fvogt added inline comments to D18182: Fix new file creation leading to dupe items on a fresh view.
Jan 15 2019, 8:50 AM · Plasma

Jan 14 2019

fvogt added inline comments to D10716: handle wrong password when using sudo which asks for another password.
Jan 14 2019, 5:52 PM · Frameworks
fvogt requested changes to D10716: handle wrong password when using sudo which asks for another password.
Jan 14 2019, 4:28 PM · Frameworks
fvogt added inline comments to D10716: handle wrong password when using sudo which asks for another password.
Jan 14 2019, 1:34 PM · Frameworks
fvogt added a reverting change for R241:4e2a815b9a10: Refactor SlaveInterface::calcSpeed: R241:514ea33ead78: Revert "Refactor SlaveInterface::calcSpeed".
Jan 14 2019, 12:55 PM