fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (100 w, 21 h)
Availability
Available

Recent Activity

Today

fvogt added a comment to D10404: Close the plasmoid after updates got installed.

I just noticed I never landed this - fixed now.

Wed, Apr 25, 7:11 AM
fvogt committed R623:f7aef3bb8d7e: Close the plasmoid after updates got installed (authored by fvogt).
Close the plasmoid after updates got installed
Wed, Apr 25, 7:10 AM
fvogt closed D10404: Close the plasmoid after updates got installed.
Wed, Apr 25, 7:10 AM
fvogt requested review of D12510: sddm-theme: Focus the password field if enter pressed in the username field.
Wed, Apr 25, 7:06 AM · Plasma

Yesterday

fvogt added a comment to D12416: Don't try to filter null key combinations.

Plasma/5.12?

Tue, Apr 24, 2:30 PM · KWin

Mon, Apr 23

fvogt added a comment to D12455: kcm_opengl: Fix EGL info retrieval..

What about Plasma/5.12?

Mon, Apr 23, 7:05 PM · Plasma

Sat, Apr 21

fvogt added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

I'm pointing out that I'm in general against any risky changes on X11. If users want to use this features: Wayland is there. KWin is feature frozen on X11 and I highly suggest to the Plasma community to decide the same at the sprint. We will have less maintenance issues due to it.

Sat, Apr 21, 8:01 PM · Plasma
fvogt added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

So I wouldn't trust this thing in Qt to work due to the pain we have in KWin especially with these problems.

Sat, Apr 21, 7:45 PM · Plasma
fvogt abandoned D7929: [WIP] Add new Column View option to KDirOperator.

We're doing a UI and usability overhaul of the Open & Save dialogs in T8552: Polish Open/Save dialogs, and I think perhaps we should revisit this. I'm very strongly in favor of adding column-based navigation to both KDirOperator and also Dolphin (though I understand that's much more difficult). However I don't think it's the end of the world if we can only add it to the open/save dialogs for now, since navigation is the primary use case for these dialogs. On MacOS, column view is practically the only mode I use for navigation, since it's so much faster than the others.

Is there anything we can do to ease the difficulty of the Qt contribution process for you, @fvogt?

Sat, Apr 21, 2:43 PM · Frameworks
fvogt added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

Docs say QT_SCREEN_SCALE_FACTORS doesn't affect the logical DPI. which means you have a 1x scale on one screen 2x on another..they both have the same font size which will just be really wrong.

Sat, Apr 21, 2:33 PM · Plasma
fvogt requested review of D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.
Sat, Apr 21, 1:51 PM · Plasma

Fri, Apr 20

fvogt accepted D9875: Extend parsing ssh prompt.
Fri, Apr 20, 7:05 PM · Plasma
fvogt added inline comments to D9875: Extend parsing ssh prompt.
Fri, Apr 20, 5:48 PM · Plasma
fvogt committed R123:a2083bb29e79: Merge branch 'Plasma/5.12' (authored by fvogt).
Merge branch 'Plasma/5.12'
Fri, Apr 20, 9:16 AM
fvogt committed R123:c879e4fa438f: Also read sddm.conf.d config directories (authored by fvogt).
Also read sddm.conf.d config directories
Fri, Apr 20, 9:15 AM
fvogt closed D12359: Also read sddm.conf.d config directories.
Fri, Apr 20, 9:15 AM · Plasma
fvogt updated the summary of D12359: Also read sddm.conf.d config directories.
Fri, Apr 20, 9:14 AM · Plasma
fvogt updated the diff for D12359: Also read sddm.conf.d config directories.

Improve the commit message.

Fri, Apr 20, 9:13 AM · Plasma
fvogt added a comment to D9875: Extend parsing ssh prompt.

I gave it a quick test - works fine with ssh(-add). I didn't test anything else though.

Fri, Apr 20, 8:12 AM · Plasma
fvogt added a comment to D9875: Extend parsing ssh prompt.

Use of QStringLiteral and nullptr in some cases, but maybe that's just phabricator doing git diff wrong.

Fri, Apr 20, 7:59 AM · Plasma
fvogt requested changes to D9875: Extend parsing ssh prompt.

Rebase looks ok - but now there are too many unrelated changes in the diff. Can you split them?

Fri, Apr 20, 6:50 AM · Plasma

Thu, Apr 19

fvogt committed R123:4af192630606: Use XCursorTheme on wayland as well (authored by fvogt).
Use XCursorTheme on wayland as well
Thu, Apr 19, 7:17 PM
fvogt closed D12361: Use XCursorTheme on wayland as well.
Thu, Apr 19, 7:17 PM · Plasma
fvogt requested review of D12361: Use XCursorTheme on wayland as well.
Thu, Apr 19, 5:38 PM · Plasma
fvogt requested review of D12359: Also read sddm.conf.d config directories.
Thu, Apr 19, 5:25 PM · Plasma
fvogt committed R123:ebdfab7e0867: Read theme.conf of themes (authored by fvogt).
Read theme.conf of themes
Thu, Apr 19, 11:23 AM
fvogt committed R123:b8d0537ba04b: Merge branch 'Plasma/5.12' (authored by fvogt).
Merge branch 'Plasma/5.12'
Thu, Apr 19, 11:23 AM
fvogt closed D12323: Read theme.conf of themes.
Thu, Apr 19, 11:22 AM · Plasma

Wed, Apr 18

fvogt added inline comments to D12323: Read theme.conf of themes.
Wed, Apr 18, 6:37 PM · Plasma
fvogt added a comment to D12323: Read theme.conf of themes.

(Actually targeting the Plasma/5.12 branch)

Wed, Apr 18, 6:19 PM · Plasma
fvogt requested review of D12323: Read theme.conf of themes.
Wed, Apr 18, 6:18 PM · Plasma

Tue, Apr 17

fvogt committed R31:f4f7b599aff5: Fix build with Qt 4 (authored by fvogt).
Fix build with Qt 4
Tue, Apr 17, 11:17 AM
fvogt closed D12277: Fix build with Qt 4.
Tue, Apr 17, 11:17 AM · Plasma
fvogt requested review of D12277: Fix build with Qt 4.
Tue, Apr 17, 11:07 AM · Plasma

Mon, Apr 9

fvogt added inline comments to D12075: Get button mapping from libwacom.
Mon, Apr 9, 8:31 PM

Sun, Apr 8

fvogt accepted D10141: Restore Persistence=session for the file ioslave kauth helper.

No objections from me - as long as the feature is disabled correctly, which it currently isn't.

See also https://phabricator.kde.org/T8075#136728.

https://cgit.kde.org/kio.git/commit/?id=65ab5e9a0c041ffa600afeb65d14b8a487b301a5
I hope this correctly disables it?

Sun, Apr 8, 11:45 AM · Frameworks
fvogt added a comment to D10141: Restore Persistence=session for the file ioslave kauth helper.

No objections from me - as long as the feature is disabled correctly, which it currently isn't.

Sun, Apr 8, 11:33 AM · Frameworks
fvogt added a comment to D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files.

What about Plasma/5.12? It has a minimum of Qt 5.9 as well.

Sun, Apr 8, 10:41 AM · Plasma

Sat, Apr 7

fvogt accepted D11997: Add botan 2 support.
Sat, Apr 7, 8:49 AM

Fri, Apr 6

fvogt requested changes to D11997: Add botan 2 support.
Fri, Apr 6, 9:09 PM
fvogt accepted D11973: Initial libWacom support.

LGTM - compile tested only. My tablet doesn't go into the libwacom codepath anyway.

Fri, Apr 6, 6:10 PM
fvogt added inline comments to D11616: Qca.
Fri, Apr 6, 12:46 PM
fvogt added a comment to D11616: Qca.

Looks good to me, except for the unnecessary checks for nullptr.

Fri, Apr 6, 12:39 PM
fvogt added a comment to D11973: Initial libWacom support.

Looks ok to me, I just added a few suggestions.

Fri, Apr 6, 7:37 AM

Thu, Apr 5

fvogt accepted D11950: Remove traces of polkit-kde-authorization tool.

I don't even have that binary installed and no package contains it here - probably some legacy KDE4 stuff.

Thu, Apr 5, 10:58 AM · Plasma
fvogt added a comment to T8075: Fix security issues with KAuth support in KIO.

Not at all intentional. It just didn't crossed my mind. I suppose the cmake file needs to be patched to not build the helper?

Thu, Apr 5, 7:51 AM · Frameworks
fvogt added a comment to T8075: Fix security issues with KAuth support in KIO.

KAuth support in KIO is currently disabled due to following security issues:

Thu, Apr 5, 6:55 AM · Frameworks

Sat, Mar 31

fvogt committed R166:9c4656cb7a1f: Merge branch 'Applications/18.04' (authored by fvogt).
Merge branch 'Applications/18.04'
Sat, Mar 31, 4:29 PM
fvogt committed R166:aafa575efc2f: Decide to use the wayland backend by looking at XDG_SESSION_TYPE (authored by fvogt).
Decide to use the wayland backend by looking at XDG_SESSION_TYPE
Sat, Mar 31, 4:28 PM
fvogt closed D11655: Decide to use the wayland backend by looking at XDG_SESSION_TYPE.
Sat, Mar 31, 4:28 PM

Fri, Mar 30

fvogt added a comment to D11262: KDE logout screen background color fix.

Since it was already committed to the master branch, wouldn't just need to be cherry-picked into the Plasma/5.12 branch at this point?

Fri, Mar 30, 3:18 PM · Plasma
fvogt added a comment to D11262: KDE logout screen background color fix.

It is meant as one. I am still kinda new here, so I am not exactly sure how to that (without confusing Phabricator).

Fri, Mar 30, 2:57 PM · Plasma
fvogt added a comment to D11262: KDE logout screen background color fix.

This seems to be a bugfix - Plasma/5.12 branch as well?

Fri, Mar 30, 2:16 PM · Plasma

Tue, Mar 27

fvogt committed R126:4d48ba71bf51: Fix build in kcmshell5, accidentially landed the wrong revision (authored by fvogt).
Fix build in kcmshell5, accidentially landed the wrong revision
Tue, Mar 27, 7:32 PM
fvogt updated subscribers of D11754: fix: Klipper notifications visually broken since plasma 5.12.

There was a discussion about this on IRC quite some time ago:

Tue, Mar 27, 7:24 PM · Plasma
fvogt added a comment to D11739: Use platform detection from KWorkSpace in KCMShell.

Given this is just runtime, I suggest we just cut it. If it causes issues then the tests which start failing can be remedied later.

Tue, Mar 27, 6:13 PM · Plasma
fvogt committed R499:9274fe2b2774: Invert build dependency of plasma-workspace on kde-cli-tools (authored by fvogt).
Invert build dependency of plasma-workspace on kde-cli-tools
Tue, Mar 27, 6:12 PM
fvogt added a comment to D11739: Use platform detection from KWorkSpace in KCMShell.

Please update the dependency metadata in kde-build-metadata.
This has broken the CI builds for kde-cli-tools on all platforms.

Tue, Mar 27, 6:04 PM · Plasma
fvogt committed R126:896dd5516cfb: Use platform detection from KWorkSpace in KCMShell (authored by fvogt).
Use platform detection from KWorkSpace in KCMShell
Tue, Mar 27, 5:26 PM
fvogt closed D11739: Use platform detection from KWorkSpace in KCMShell.
Tue, Mar 27, 5:26 PM · Plasma
fvogt updated the diff for D11739: Use platform detection from KWorkSpace in KCMShell.

Do the same as krunner, unset the variable if platform got detected.

Tue, Mar 27, 3:15 PM · Plasma
fvogt requested review of D11739: Use platform detection from KWorkSpace in KCMShell.
Tue, Mar 27, 7:29 AM · Plasma

Mon, Mar 26

fvogt committed R108:0deb8573032b: Merge branch 'Plasma/5.12' (authored by fvogt).
Merge branch 'Plasma/5.12'
Mon, Mar 26, 5:00 PM
fvogt added a comment to D10465: Fix coverswitch broken reflection on multi-monitor setup.

Tomorrow is release of 5.12.4, so I cherry-picked the commit into the Plasma/5.12 branch and merged.

Mon, Mar 26, 5:00 PM · KWin
fvogt committed R108:2eded918977f: [effects/coverswitch] Fix broken reflection on multi-monitor setup (authored by poboiko).
[effects/coverswitch] Fix broken reflection on multi-monitor setup
Mon, Mar 26, 4:58 PM
fvogt committed R102:fa66cfaa1d4e: Merge branch 'Plasma/5.12' (authored by fvogt).
Merge branch 'Plasma/5.12'
Mon, Mar 26, 11:35 AM
fvogt committed R102:fadf1008e452: kcm_energyinfo: Allow changing of the timespan if no data available (authored by fvogt).
kcm_energyinfo: Allow changing of the timespan if no data available
Mon, Mar 26, 11:32 AM
fvogt closed D11712: kcm_energyinfo: Allow changing of the timespan if no data available.
Mon, Mar 26, 11:32 AM · Plasma
fvogt requested review of D11712: kcm_energyinfo: Allow changing of the timespan if no data available.
Mon, Mar 26, 11:30 AM · Plasma

Mar 25 2018

fvogt added a comment to D11616: Qca.

I missed two minor issues - but then it should be good to go.

Mar 25 2018, 7:29 PM
fvogt added a comment to D10465: Fix coverswitch broken reflection on multi-monitor setup.

In general, all fixes which apply to maintained branches and have a low potential of causing regressions should be backported.

Mar 25 2018, 1:22 PM · KWin
fvogt added a comment to D11655: Decide to use the wayland backend by looking at XDG_SESSION_TYPE.

Sure, but that's just what the list in D10816 looked like. Anyway, this probably needs more discussion in Plasma and KDE Apps in general on where to draw the line wrt. wayland opt-in. Nothing for this patch…

Mar 25 2018, 12:12 PM
fvogt updated the diff for D11655: Decide to use the wayland backend by looking at XDG_SESSION_TYPE.

Add comment

Mar 25 2018, 12:12 PM
fvogt added a comment to D11655: Decide to use the wayland backend by looking at XDG_SESSION_TYPE.

Happy to change course here if you can come up with good reasons, but so far I don't see why we should not run with wayland when running on Wayland.

Mar 25 2018, 11:19 AM
fvogt added a comment to D11655: Decide to use the wayland backend by looking at XDG_SESSION_TYPE.

I don't think the code should contain custom handling of environment variables in the long run, it should just use KWindowSystem. Please add a comment so this can be removed again in the future.

Mar 25 2018, 10:56 AM
fvogt updated the diff for D11655: Decide to use the wayland backend by looking at XDG_SESSION_TYPE.

Merge the two conditions

Mar 25 2018, 10:56 AM
fvogt added a comment to D10465: Fix coverswitch broken reflection on multi-monitor setup.

What about the Plasma/5.8 and Plasma/5.12 branches?

Mar 25 2018, 10:43 AM · KWin
fvogt added a comment to D11655: Decide to use the wayland backend by looking at XDG_SESSION_TYPE.

That it doesn't work with -platform is intentional - spectacle uses the xcb platform plugin in wayland sessions now.
The wayland grabber uses DBus, so it works fine even without a wayland connection.
I could change the diff to check for KWindowSystem::isPlatformWayland() || qstrcmp(qgetenv("XDG_SESSION_TYPE"), "wayland") == 0 instead, though.

Mar 25 2018, 10:34 AM

Mar 24 2018

fvogt added a comment to D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM.

XDG_SESSION_TYPE is not set if you run startplasmacompositor from a tty - so should this also check for WAYLAND_DISPLAY or startplasmacompositor set XDG_SESSION_TYPE=wayland?

[...] from developers we can expect to set this variable.

Mar 24 2018, 7:13 PM · Plasma
fvogt added a comment to D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM.

XDG_SESSION_TYPE is not set if you run startplasmacompositor from a tty - so should this also check for WAYLAND_DISPLAY or startplasmacompositor set XDG_SESSION_TYPE=wayland?

Mar 24 2018, 6:32 PM · Plasma
fvogt added a comment to D11655: Decide to use the wayland backend by looking at XDG_SESSION_TYPE.

I'm not sure whether that's set if you run dbus-launch startplasmacompositor from a tty.

Mar 24 2018, 6:29 PM
fvogt requested review of D11655: Decide to use the wayland backend by looking at XDG_SESSION_TYPE.
Mar 24 2018, 6:22 PM

Mar 23 2018

fvogt added a comment to D11616: Qca.

Looks good to me otherwise.

Mar 23 2018, 7:30 PM
fvogt abandoned D10234: LibInput: Queue native libinput events instead of LibInput::Event.
In D10234#232304, @mart wrote:

for @fvogt: as an alternative approach has been pushed, can this be closed?

Mar 23 2018, 6:38 PM · KWin
fvogt requested changes to D9875: Extend parsing ssh prompt.

Sorry that you had to wait so long - it seems there's no active maintainer for this.

Mar 23 2018, 6:34 PM · Plasma
fvogt committed R120:5af288fae1f0: Merge branch 'Plasma/5.12' (authored by fvogt).
Merge branch 'Plasma/5.12'
Mar 23 2018, 11:57 AM
fvogt committed R120:a4a0d5bfd0da: Pass proper click coordinates to SNI ContextMenu calls (authored by fvogt).
Pass proper click coordinates to SNI ContextMenu calls
Mar 23 2018, 11:56 AM
fvogt closed D11600: Pass proper click coordinates to SNI ContextMenu calls.
Mar 23 2018, 11:56 AM · Plasma
fvogt committed R120:8827bb38806e: libdbusmenu-qt: Remove nonexistant actions directly from the menu (authored by fvogt).
libdbusmenu-qt: Remove nonexistant actions directly from the menu
Mar 23 2018, 10:51 AM
fvogt closed D11586: libdbusmenu-qt: Remove nonexistant actions directly from the menu.
Mar 23 2018, 10:51 AM · Plasma
fvogt committed R120:cf2d64fa9718: Set a transient parent for SNI context menus (authored by fvogt).
Set a transient parent for SNI context menus
Mar 23 2018, 10:51 AM
fvogt closed D11584: Set a transient parent for SNI context menus.
Mar 23 2018, 10:51 AM · Plasma
fvogt requested review of D11600: Pass proper click coordinates to SNI ContextMenu calls.
Mar 23 2018, 8:56 AM · Plasma
fvogt updated the diff for D11584: Set a transient parent for SNI context menus.

Split mouse.xy stuff into separate patch.

Mar 23 2018, 8:24 AM · Plasma
fvogt added inline comments to D11584: Set a transient parent for SNI context menus.
Mar 23 2018, 8:21 AM · Plasma
fvogt added inline comments to D11584: Set a transient parent for SNI context menus.
Mar 23 2018, 7:52 AM · Plasma

Mar 22 2018

fvogt added a comment to D11586: libdbusmenu-qt: Remove nonexistant actions directly from the menu.

Looking at the WAYLAND_DEBUG output I think I'm closer to understanding the issue now.

Mar 22 2018, 9:29 PM · Plasma
fvogt updated the diff for D11584: Set a transient parent for SNI context menus.

Now for real. Please arc, cooperate.

Mar 22 2018, 8:10 PM · Plasma
fvogt updated the diff for D11584: Set a transient parent for SNI context menus.

Split into https://phabricator.kde.org/D11586

Mar 22 2018, 8:09 PM · Plasma
fvogt requested review of D11586: libdbusmenu-qt: Remove nonexistant actions directly from the menu.
Mar 22 2018, 8:08 PM · Plasma