- User Since
- May 24 2016, 11:24 AM (194 w, 6 d)
Sat, Feb 15
Fixing some style issues
Address comments. Still works.
Wed, Feb 12
Tue, Feb 4
I'll land tomorrow if no objections.
Does this mean the default fonts have a style name of "Regular" now? That will break setting bold fonts and such, see https://phabricator.kde.org/D9070.
Mon, Feb 3
Fri, Jan 31
The only remaining question from my side is why we have four different gtk configuration files and whether that causes issues.
Besides that, only @meven's comment needs a resolution.
Thu, Jan 30
Make a copy, QObject::children returns const & for some reason, so gets modified during iteration.
D22758 got merged
Hm, totally missed the notification for this...
Wed, Jan 29
Mon, Jan 27
Tested, confirmed to work.
Sun, Jan 26
Sat, Jan 25
Fri, Jan 24
If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa, it should be possible to drop the kconf_update script there.
It might even cause conflicts otherwise.
Tue, Jan 21
Mon, Jan 20
I'll just land this now...
Jan 17 2020
The change itself is correct, but not in relation to the title and summary which are about https://bugreports.qt.io/browse/QTBUG-80967, which was a genuine bug in Qt, fixed in 5.14.1.
What this change fixes is double scaling in applications which enable Qt::AA_EnableHighDpiScaling.
Jan 16 2020
Jan 14 2020
Jan 13 2020
When I tested this, there was a very noticable delay (~10s) between starting the search and items appearing, so the busy indicator is IMO necessary.
Jan 11 2020
Jan 10 2020
Jan 8 2020
Jan 7 2020
IMO it should still be considered if it's the only one.
Dec 26 2019
Dec 23 2019
Dec 22 2019
Dec 12 2019
This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21
I'm wondering whether this might not actually break the "qtchooser" variant - if binaries are in a Qt version specific dir, the path to qdbus would no longer exist after a Qt update without a rebuild of spectacle.
Dec 11 2019
the actual name of the command is qdbus-qt<version> in the distro's Qt
Dec 10 2019
IMO this should be done in KIO, so that all users benefit.
Dec 7 2019
The check for the prefix was added in bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc, while the control.flat one got added much earlier.
Dec 4 2019
Dec 3 2019
Dec 2 2019
Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in the file, so I usually just see < for a HTML page
Dec 1 2019
Unfortunately the kio-fuse -d output is incomplete, probably because Qt was too smart and logged to the journal instead...
It's visible that there are multiple processes reading the file, maybe thumbnailing is in progress?
Can you try with thumbnails in dolphin disabled?
Nov 30 2019
That happens because the .desktop file sets X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb:
I wonder whether the job duplication can just be ignored like this or whether there has to be a "virtual" unique id instead to be able to address duplicated jobs as well.
When cancelling a duplicated job with this patch, are both gone or just one of them?
Nov 29 2019
Nov 25 2019
AFAICT this breaks if LIBDIR != "lib". systemd only looks in /usr/lib AFAICT, so hardcoding to $prefix/lib/systemd might be better.
IMO this should be addressed outside of PBI instead:
- If a captive portal is detected, call CheckConnectivity with a higher frequency (I've never had any issues with this, actually)
- Instead of opening networkcheck.kde.org in the browser when clicking the "Log In" button, open a page which just closes itself
Nov 21 2019
This would work, but why not just emit Seeked(m_position) in setPosition?
Nov 20 2019
Nov 18 2019
I wonder whether this can actually happen, as that header is AFAICT added by the kernel and not from the network.
Nov 15 2019
I wonder whether the getStatus handler could be cleaned up by removing the UNKNOWN value of portStatus and removing the default: case.
Nov 14 2019
It doesn't seem to work here either, but adding the --print-reply argument helps for some reason.
Nov 6 2019
This got implemented in https://phabricator.kde.org/D22571, which is flawed (see the various comments there).
This way the code does what it's supposed to (even though it's flawed), so definitely an improvement.