fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (185 w, 2 d)
Availability
Available

Recent Activity

Yesterday

fvogt added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21

Thu, Dec 12, 7:09 PM · Frameworks
fvogt added a comment to D25883: Find qdbus command correctly.

I'm wondering whether this might not actually break the "qtchooser" variant - if binaries are in a Qt version specific dir, the path to qdbus would no longer exist after a Qt update without a rebuild of spectacle.

Thu, Dec 12, 7:03 PM · Spectacle

Wed, Dec 11

fvogt added a comment to D25883: Find qdbus command correctly.

the actual name of the command is qdbus-qt<version> in the distro's Qt

Wed, Dec 11, 1:07 PM · Spectacle
fvogt added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

Please don't link external sites (GitHub) in the committed message.

RE: Menu
There is nothing in QQC2::Button to add a menu

If we want that it would have to be a custom button subclass, rather than something we support in the style.

Wed, Dec 11, 11:05 AM · Frameworks

Tue, Dec 10

fvogt added a comment to D25856: Show IOSlaves that return local files when in local file mode.

IMO this should be done in KIO, so that all users benefit.

How would you do it in KIO?

Tue, Dec 10, 9:20 PM
fvogt added a comment to D25856: Show IOSlaves that return local files when in local file mode.

IMO this should be done in KIO, so that all users benefit.

Tue, Dec 10, 5:58 PM

Sat, Dec 7

fvogt added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

The check for the prefix was added in bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc, while the control.flat one got added much earlier.

Sat, Dec 7, 10:13 PM · Frameworks
fvogt accepted D25803: [Purpose Plugin] Reset pending reply serial when aborting.
Sat, Dec 7, 9:48 PM · Plasma

Wed, Dec 4

fvogt added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

I just tested writing today, for files opened in 3rd-party apps that get the FUSE mount path. Results:
...

Wed, Dec 4, 4:41 PM · Frameworks

Tue, Dec 3

fvogt added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

I'm afraid that even with that change, the issue is still present. I honestly don't think it would be the worst thing in the world if we always handed the kio-fuse paths to apps that don't use ioslaves.

Tue, Dec 3, 7:57 AM · Frameworks

Mon, Dec 2

fvogt added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in the file, so I usually just see < for a HTML page

Ignoring the elephant in the room which is that this diff forces everything through mountUrl, that's the expected behavior with a plain HTTP URL as the size isn't known until the file is downloaded. So stat reports a size of 1 until the file is actually opened.
This is unavoidable, otherwise every ls would trigger a download of all files. If handling this better is important, HTTPProtocol::stat could use a HEAD request to get the Content-Length, but that doesn't work in all cases either.

Well, we need to fix this or else it's a very serious regression that breaks a huge part of the desktop. Opening links in a web browser is pretty basic functionality.

Mon, Dec 2, 2:21 PM · Frameworks
fvogt added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Please try both of the following:

Done. Here are the log files:

Mon, Dec 2, 12:30 PM · Frameworks
fvogt added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in the file, so I usually just see < for a HTML page

Mon, Dec 2, 12:13 PM · Frameworks

Sun, Dec 1

fvogt added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Unfortunately the kio-fuse -d output is incomplete, probably because Qt was too smart and logged to the journal instead...
It's visible that there are multiple processes reading the file, maybe thumbnailing is in progress?
Can you try with thumbnails in dolphin disabled?

Sun, Dec 1, 12:19 PM · Frameworks

Sat, Nov 30

fvogt added a comment to D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO.

That happens because the .desktop file sets X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb:
https://code.videolan.org/videolan/vlc/blob/master/share/vlc.desktop.in#L124

Sat, Nov 30, 11:18 AM · Frameworks
fvogt added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

I wonder whether the job duplication can just be ignored like this or whether there has to be a "virtual" unique id instead to be able to address duplicated jobs as well.
When cancelling a duplicated job with this patch, are both gone or just one of them?

Sat, Nov 30, 10:45 AM

Fri, Nov 29

fvogt accepted D25569: Also overwrite document.createElement using exportFunction.

Ugly...

Fri, Nov 29, 1:37 PM · Plasma

Mon, Nov 25

fvogt accepted D25107: Add install dir for systemd units.
Mon, Nov 25, 6:06 PM · Build System, Frameworks
fvogt requested changes to D25107: Add install dir for systemd units.
Mon, Nov 25, 1:40 PM · Build System, Frameworks
fvogt reopened D25107: Add install dir for systemd units.

AFAICT this breaks if LIBDIR != "lib". systemd only looks in /usr/lib AFAICT, so hardcoding to $prefix/lib/systemd might be better.

Mon, Nov 25, 1:39 PM · Build System, Frameworks
fvogt requested changes to D25466: Add Captive Portal auto-refresh handling.

IMO this should be addressed outside of PBI instead:

  • If a captive portal is detected, call CheckConnectivity with a higher frequency (I've never had any issues with this, actually)
  • Instead of opening networkcheck.kde.org in the browser when clicking the "Log In" button, open a page which just closes itself
Mon, Nov 25, 12:36 PM · Plasma

Thu, Nov 21

fvogt added a comment to D25403: Drop Position change signal and support Seeked signal.

This would work, but why not just emit Seeked(m_position) in setPosition?

Thu, Nov 21, 10:56 AM · Plasma

Wed, Nov 20

fvogt accepted D25404: Just return applicationDisplayName in MPRIS Identity.
Wed, Nov 20, 3:01 PM · Plasma

Mon, Nov 18

fvogt requested changes to D25363: Fix one more buffer overread in ksysguard network helper.

I wonder whether this can actually happen, as that header is AFAICT added by the kernel and not from the network.

Mon, Nov 18, 9:46 AM · Plasma

Fri, Nov 15

fvogt accepted D25320: Show startup error in popup as well.

I wonder whether the getStatus handler could be cleaned up by removing the UNKNOWN value of portStatus and removing the default: case.

Fri, Nov 15, 10:43 AM · Plasma

Thu, Nov 14

fvogt added a comment to D25293: Use dbus-send instead of qdbus for global shortcuts.

It doesn't seem to work here either, but adding the --print-reply argument helps for some reason.

Thu, Nov 14, 7:59 AM · Spectacle

Nov 6 2019

fvogt reopened T4437: [kwayland] Security filter as "Open".

This got implemented in https://phabricator.kde.org/D22571, which is flawed (see the various comments there).

Nov 6 2019, 12:25 PM · Plasma on Wayland
fvogt accepted D25169: [wayland] Fix sha check of filtered applications.

This way the code does what it's supposed to (even though it's flawed), so definitely an improvement.

Nov 6 2019, 12:18 PM · KWin
fvogt added a comment to D22571: Allow blacklisting some wayland interfaces.

But given you're right about readlink (exe) and read(exe) behaving differently, we should be able to simplify things and have it work.

I shall do that now.

Nov 6 2019, 12:15 PM · KWin
fvogt added inline comments to D22571: Allow blacklisting some wayland interfaces.
Nov 6 2019, 10:09 AM · KWin

Nov 5 2019

fvogt requested changes to D25159: Fix linking to libssh 0.9.1.

The libssh maintainer is likely reverting the change, so this should not be necessary.

Nov 5 2019, 5:58 PM · Frameworks, Dolphin
fvogt committed R120:a1404ce293b5: Merge branch 'Plasma/5.17' (authored by fvogt).
Merge branch 'Plasma/5.17'
Nov 5 2019, 12:30 PM
fvogt committed R120:0ebdf83a2f9e: Make env in plasma-sourceenv.sh call portable (authored by fvogt).
Make env in plasma-sourceenv.sh call portable
Nov 5 2019, 12:26 PM
fvogt closed D25124: Make env in plasma-sourceenv.sh call portable.
Nov 5 2019, 12:26 PM · Plasma

Nov 4 2019

fvogt accepted D25140: kcm/fonts: set initial settings correctly.

LGTM. This now ignores the return value of the xft.get* calls, but that seems to be useless anyway:

Nov 4 2019, 4:17 PM · Plasma
fvogt added a comment to D25140: kcm/fonts: set initial settings correctly.

That seems like just the order of assignments is wrong and more logic isn't actually needed. What about something like this:

Nov 4 2019, 10:39 AM · Plasma

Nov 3 2019

fvogt accepted D25124: Make env in plasma-sourceenv.sh call portable.
Nov 3 2019, 11:53 AM · Plasma

Oct 30 2019

fvogt accepted D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement.

IMO this looks uglier than multiline C macros, but ok...

Oct 30 2019, 11:54 AM · Plasma

Oct 28 2019

fvogt added a comment to D24997: [Lock & Login Screens] Don't use a black shadow with black text.

I think we have a greater conceptual problem here. If the lock and login screens are able to display arbitrary text colors from the user's color scheme, we will never be rid of these kinds of problems. I see two practical solutions:

  • Hardcode white as the text color and black as the shadow color and don't respect the color scheme
Oct 28 2019, 6:37 PM · Plasma
fvogt added a comment to D22571: Allow blacklisting some wayland interfaces.

By just not faking it: LD_PRELOAD=pwn.so /usr/bin/plasmashell

Sure. But that's out of scope. We shoudln't pretend we can completely protect against unsandboxed code running as your user. You're somewhat screwed regardless.

Oct 28 2019, 4:49 PM · KWin
fvogt added inline comments to D22571: Allow blacklisting some wayland interfaces.
Oct 28 2019, 4:03 PM · KWin

Oct 25 2019

fvogt added a comment to D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}.

IMO it's a good thing to have KRunner as application in the menu anyway

It was not in the application menu before
With this change (and without NoDisplay) it will be displayed.

Oct 25 2019, 4:15 PM · Plasma
fvogt accepted D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}.

IMO it's a good thing to have KRunner as application in the menu anyway

Oct 25 2019, 3:42 PM · Plasma
fvogt added a reverting change for R120:b3065f7db0d6: Install krunner desktop file to ${KDE_INSTALL_APPDIR}: R120:a53e8065fbce: Revert "Install krunner desktop file to ${KDE_INSTALL_APPDIR}".
Oct 25 2019, 2:38 PM
fvogt committed R120:a53e8065fbce: Revert "Install krunner desktop file to ${KDE_INSTALL_APPDIR}" (authored by fvogt).
Revert "Install krunner desktop file to ${KDE_INSTALL_APPDIR}"
Oct 25 2019, 2:38 PM

Oct 22 2019

fvogt added a comment to D24870: Fixup new Audio() constructor and apply autoplay prevention evasion to document.createElement.

Is this not needed for <video/> as well?

Oct 22 2019, 6:25 PM · Plasma

Oct 18 2019

fvogt committed R120:be056099b179: Merge branch 'Plasma/5.17' (authored by fvogt).
Merge branch 'Plasma/5.17'
Oct 18 2019, 12:40 PM
fvogt committed R120:595ab88bc2ee: Fix reading environment variables with newline (authored by fvogt).
Fix reading environment variables with newline
Oct 18 2019, 12:39 PM
fvogt closed D24750: Fix reading environment variables with newline.
Oct 18 2019, 12:39 PM · Plasma
D24750: Fix reading environment variables with newline now requires review to proceed.
Oct 18 2019, 9:40 AM · Plasma
fvogt requested review of D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper.
Oct 18 2019, 9:33 AM · Plasma
fvogt added a comment to D24750: Fix reading environment variables with newline.

Note, the "-0" option is only available in GNU env, not in BSD /env... I can't think of a better way to fix this though other than implementing env ourselves in native code.

Oct 18 2019, 7:42 AM · Plasma
fvogt updated the diff for D24750: Fix reading environment variables with newline.

arc is a PoS

Oct 18 2019, 7:38 AM · Plasma
fvogt requested review of D24750: Fix reading environment variables with newline.
Oct 18 2019, 7:37 AM · Plasma

Oct 16 2019

fvogt accepted D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Oct 16 2019, 12:26 PM · Plasma
fvogt accepted D24693: Bail out early when setPluginLoaded would result in no change.
Oct 16 2019, 11:38 AM · Plasma
fvogt accepted D24692: Show version information in about screen.

Tried with old host, no observable change

Oct 16 2019, 11:36 AM · Plasma
fvogt committed R120:f82eb5b519fc: Merge branch 'Plasma/5.17' (authored by fvogt).
Merge branch 'Plasma/5.17'
Oct 16 2019, 6:59 AM
fvogt committed R120:ff84a4e5662e: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0 (authored by fvogt).
[gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0
Oct 16 2019, 6:58 AM
fvogt closed D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0.
Oct 16 2019, 6:58 AM · Plasma

Oct 15 2019

fvogt added a comment to D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0.

Since we watch the file, we will update it as neccessary once kconf_update has written it, right?

Oct 15 2019, 5:03 PM · Plasma
fvogt updated the test plan for D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0.
Oct 15 2019, 3:03 PM · Plasma
fvogt added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

I thought this change was introduced with 0.18.1 though? Aren't distros with an old SDDM using something older than that?

Oct 15 2019, 2:58 PM · Plasma
fvogt added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

FWIW to me https://github.com/sddm/sddm/pull/997 seems correct, and then we would rename the sessions upstream here. My preference would be to make the Wayland session say "Plasma (Wayland)" rather than renaming the X11 session ("Plasma on Xorg" sounds pretty awkward IMO)

Oct 15 2019, 2:51 PM · Plasma
fvogt added a comment to D24666: Be explicit about X11 or Wayland for the dev session names.

See https://phabricator.kde.org/D22210 for a discussion about this.

Oct 15 2019, 2:24 PM · Plasma
fvogt committed R108:f4c6de8ec452: Merge branch 'Plasma/5.17' (authored by fvogt).
Merge branch 'Plasma/5.17'
Oct 15 2019, 2:09 PM
fvogt committed R108:4982dfd5f5ec: glx: Don't use sRGB configs on llvmpipe with depth 16 (authored by fvogt).
glx: Don't use sRGB configs on llvmpipe with depth 16
Oct 15 2019, 2:07 PM
fvogt closed D22203: glx: Don't use sRGB configs on llvmpipe with depth 16.
Oct 15 2019, 2:07 PM · KWin
fvogt requested review of D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0.
Oct 15 2019, 1:51 PM · Plasma

Oct 7 2019

fvogt committed R120:0565c8e615e0: sddm-theme: Set needsFullUserModel=false (authored by fvogt).
sddm-theme: Set needsFullUserModel=false
Oct 7 2019, 8:30 AM
fvogt closed D24333: sddm-theme: Set needsFullUserModel=false.
Oct 7 2019, 8:30 AM · Plasma

Oct 2 2019

fvogt added a comment to D24333: sddm-theme: Set needsFullUserModel=false.

I don't think I follow.

How does the regular non-textfield version of the login screen still work? Surely containsAllUsers will always be false.

Oct 2 2019, 5:47 PM · Plasma

Oct 1 2019

fvogt updated the diff for D24333: sddm-theme: Set needsFullUserModel=false.

Maybe now?

Oct 1 2019, 8:46 AM · Plasma
fvogt updated the diff for D24333: sddm-theme: Set needsFullUserModel=false.

Maybe get rid of the unrelated change?

Oct 1 2019, 8:38 AM · Plasma
fvogt requested review of D24333: sddm-theme: Set needsFullUserModel=false.
Oct 1 2019, 8:37 AM · Plasma

Sep 30 2019

fvogt added inline comments to D24194: Add per-origin media controls blacklist.
Sep 30 2019, 3:11 PM · Plasma
fvogt added inline comments to D22571: Allow blacklisting some wayland interfaces.
Sep 30 2019, 2:45 PM · KWin
fvogt requested changes to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

drop translations, rename to 'Plasma on Xorg'

That would not be symmetric to "Plasma (Wayland)" though as produced by sddm.

Sep 30 2019, 2:45 PM · Plasma

Sep 27 2019

fvogt added inline comments to D24084: Migrate kwin animation speed to kdeglobals.
Sep 27 2019, 9:43 AM · KWin
fvogt added inline comments to D24084: Migrate kwin animation speed to kdeglobals.
Sep 27 2019, 7:57 AM · KWin
fvogt reopened D24084: Migrate kwin animation speed to kdeglobals.
Sep 27 2019, 7:20 AM · KWin

Sep 26 2019

fvogt requested changes to D24245: Add support for passing Unix file descriptors.

Unfortunately, this breaks public API and ABI by modifying KAuth::ActionReply.

Sep 26 2019, 5:01 PM · Frameworks
fvogt accepted D24203: Add settings change listener.

Seems to work on FF ESR

Sep 26 2019, 3:15 PM · Plasma
fvogt added a comment to D24194: Add per-origin media controls blacklist.

AFAICT it doesn't reload the mpris state in the content-script immediately when settings change, can that be implemented?

Sep 26 2019, 2:19 PM · Plasma

Sep 25 2019

fvogt added a comment to D24225: [Notifications] Add spacing after positioning popup for bottom panel.

Seems to work here

Sep 25 2019, 3:07 PM · Plasma

Sep 24 2019

fvogt added inline comments to D24191: Let plugin add additional status information.
Sep 24 2019, 2:07 PM · Plasma
fvogt accepted D24191: Let plugin add additional status information.

Seems a bit weird to merge it at the top-level instead of adding a new key, but it's unlikely to result in abuse.

Sep 24 2019, 2:06 PM · Plasma
fvogt accepted D24190: Let options page scroll.
Sep 24 2019, 2:03 PM · Plasma
fvogt accepted D24165: Add SettingsUtil utility class.

Appears to work on ESR

Sep 24 2019, 1:46 PM · Plasma

Sep 23 2019

fvogt added a comment to D24165: Add SettingsUtil utility class.

Probably needs some Firefox ESR 60 testing to see whether it can deal with the class stuff...

Sep 23 2019, 5:04 PM · Plasma

Sep 20 2019

fvogt added a reviewer for D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid: Frameworks.
Sep 20 2019, 6:02 PM · Frameworks

Sep 19 2019

fvogt added inline comments to D23117: [Look and feel] Add a way for LNF themes to manually specify Splash Screen, Latte Layout and Borderless Maximised Windows.
Sep 19 2019, 4:32 PM · Plasma

Sep 18 2019

fvogt added inline comments to D22571: Allow blacklisting some wayland interfaces.
Sep 18 2019, 2:36 PM · KWin

Sep 16 2019

fvogt committed R120:065a0fcfb035: Fix editing items in SimpleFavoritesModel (authored by fvogt).
Fix editing items in SimpleFavoritesModel
Sep 16 2019, 12:16 PM
fvogt accepted D23151: Implement Web Share API through Purpose.
Sep 16 2019, 8:24 AM · Plasma

Sep 10 2019

fvogt added a comment to T11530: Investigate removal of KIO's KPAC in favor of QNetworkProxy.

libproxy does not link against Qt anymore, they use kreadconfig5 and friends to read the values. So using that should be safe.

Sep 10 2019, 12:13 PM · KF6

Sep 9 2019

fvogt accepted D22203: glx: Don't use sRGB configs on llvmpipe with depth 16.

Tested, works, thanks!

Sep 9 2019, 9:44 AM · KWin

Sep 7 2019

fvogt accepted D23773: Observe title tag only if there actually is a player.
Sep 7 2019, 2:03 PM · Plasma
fvogt added inline comments to D23773: Observe title tag only if there actually is a player.
Sep 7 2019, 1:44 PM · Plasma
fvogt added inline comments to D23773: Observe title tag only if there actually is a player.
Sep 7 2019, 1:11 PM · Plasma