fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (133 w, 6 d)
Availability
Available

Recent Activity

Wed, Dec 5

fvogt added a comment to D17365: Round label width.

Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" in particular. Is this really the trade-off we're faced with? It feels like there are upstream Qt bugs here.

Wed, Dec 5, 3:14 PM · Plasma
fvogt committed R119:02ef57d37b2c: Merge branch 'Plasma/5.14' (authored by fvogt).
Merge branch 'Plasma/5.14'
Wed, Dec 5, 9:55 AM
fvogt committed R119:5323adb7cfac: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.14
Wed, Dec 5, 9:55 AM
fvogt committed R119:3526334e8234: Round label width (authored by fvogt).
Round label width
Wed, Dec 5, 9:55 AM
fvogt closed D17365: Round label width.
Wed, Dec 5, 9:55 AM · Plasma
fvogt updated the summary of D17365: Round label width.
Wed, Dec 5, 9:52 AM · Plasma
fvogt updated the diff for D17365: Round label width.

Turns out the label width rounding is enough

Wed, Dec 5, 9:51 AM · Plasma
fvogt added inline comments to D17365: Round label width.
Wed, Dec 5, 9:50 AM · Plasma
fvogt updated the test plan for D17365: Round label width.
Wed, Dec 5, 9:46 AM · Plasma
fvogt requested review of D17365: Round label width.
Wed, Dec 5, 9:35 AM · Plasma

Tue, Dec 4

fvogt committed R845:383483355253: Merge branch 'Plasma/5.14' (authored by fvogt).
Merge branch 'Plasma/5.14'
Tue, Dec 4, 7:49 PM
fvogt committed R845:ab3c96c5ddbf: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.14
Tue, Dec 4, 7:49 PM
fvogt committed R845:5d3face3c1bb: Fix use of QRegularExpressionMatch (authored by fvogt).
Fix use of QRegularExpressionMatch
Tue, Dec 4, 7:49 PM
fvogt closed D17359: Fix use of QRegularExpressionMatch.
Tue, Dec 4, 7:49 PM · Plasma
fvogt requested review of D17359: Fix use of QRegularExpressionMatch.
Tue, Dec 4, 7:36 PM · Plasma

Mon, Dec 3

fvogt accepted D17326: Make media session property setter more resilient.

Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read.

Mon, Dec 3, 8:36 AM · Plasma
fvogt added a comment to D17326: Make media session property setter more resilient.

It can, processMetadata(data.value(QStringLiteral("metadata")).toObject()); turns it into an empty object when null (or anything but an Object)

Mon, Dec 3, 8:32 AM · Plasma
fvogt added a comment to D17326: Make media session property setter more resilient.

Can host/mprisplugin.cpp deal with payload being null properly?

Mon, Dec 3, 8:21 AM · Plasma

Fri, Nov 30

fvogt added a comment to D17233: Only cancel job when an "error" is set and ignore "interrupted".

LGTM otherwise.

Fri, Nov 30, 7:11 PM · Plasma
fvogt added a comment to D17248: Add Rectangular Region mode on wayland [RFC].

I implemented the same hack here locally some time ago and it works perfectly fine if started with spectacle -platform xcb.

Fri, Nov 30, 2:04 PM · Spectacle

Thu, Nov 29

fvogt added a comment to D17233: Only cancel job when an "error" is set and ignore "interrupted".

It might work as well to just ignore the "interrupted" state completely and only react when error becomes set.

Thu, Nov 29, 6:16 PM · Plasma

Wed, Nov 28

fvogt added a comment to D17187: Set the default cursor theme to breeze_cursors.

OTOH, this patch actually causes a mismatch if one changes the cursor theme in Plasma's cursor theme KCM. (it won't affect GTK applications, they will continue to use breeze...)

Wed, Nov 28, 9:40 AM · Plasma

Tue, Nov 27

fvogt added a comment to D17187: Set the default cursor theme to breeze_cursors.

Actually, if the cursor theme is not set to anything, GTK would just use the session's default. I.e. this patch should not be necessary in the first place.

Tue, Nov 27, 9:15 PM · Plasma
fvogt committed R98:0f63920d8a5f: Merge branch 'Plasma/5.14' (authored by fvogt).
Merge branch 'Plasma/5.14'
Tue, Nov 27, 6:08 PM
fvogt committed R98:427202d44d5e: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.14
Tue, Nov 27, 6:08 PM
fvogt committed R98:dcacaa1d4f7e: Set the default cursor theme to breeze_cursors (authored by fvogt).
Set the default cursor theme to breeze_cursors
Tue, Nov 27, 6:08 PM
fvogt closed D17187: Set the default cursor theme to breeze_cursors.
Tue, Nov 27, 6:08 PM · Plasma
fvogt requested review of D17187: Set the default cursor theme to breeze_cursors.
Tue, Nov 27, 2:49 PM · Plasma

Sat, Nov 24

fvogt added a comment to D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling.

Yeah, I had a feeling that that might end up as a better place for the fix. Someone else would need to do that patch or help me with it though. I gave it a shot but couldn't get the binding right.

Sat, Nov 24, 11:13 PM · Plasma
fvogt added a comment to D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling.

IMO this workaround is generic enough that adding it into ScrollablePage.qml or even templates/private/ScrollView.qml itself is better as it hits almost every use.

Sat, Nov 24, 10:46 PM · Plasma

Fri, Nov 23

fvogt requested review of D17122: RFC: Use wl_display_add_socket_auto by default.
Fri, Nov 23, 1:43 PM · Frameworks
fvogt accepted D16435: Also catch new Audio() elements.

LGTM, but I have no idea about this part of JS.

Fri, Nov 23, 12:57 PM · Plasma

Thu, Nov 22

fvogt accepted D17102: Connect to contextMenu clicked callback only once.
Thu, Nov 22, 3:35 PM · Plasma
fvogt accepted D16889: Listen to KDE Connect device signals.
Thu, Nov 22, 2:46 PM · KDE Connect, Plasma

Nov 15 2018

fvogt accepted D16888: Recreate interrupted download when it is resumed.

Gave it a quick test as well, seems to work fine.

Nov 15 2018, 6:25 PM · Plasma
fvogt added inline comments to D16889: Listen to KDE Connect device signals.
Nov 15 2018, 6:05 PM · KDE Connect, Plasma

Nov 14 2018

fvogt abandoned D16881: Revert "A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon".

Indeed, I just read the commit message in kcrash:

Nov 14 2018, 6:31 PM · KDE Connect
fvogt added a comment to D16881: Revert "A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon".

I'm wondering whether the .protocol to .json conversion is related, because it was part of the same commit.

Nov 14 2018, 5:40 PM · KDE Connect
fvogt requested review of D16881: Revert "A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon".
Nov 14 2018, 5:39 PM · KDE Connect
fvogt added a reverting change for R224:8388ed0603f0: A QApplication object needs to be instantiated for kio-kdeconnect to work on…: D16881: Revert "A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon".
Nov 14 2018, 5:39 PM
fvogt added a comment to D15512: [startplasmacompositor] Add Wayland socket argument.

It looks like all of that is already implemented in libwayland-server.
kwin_wayland just needs to make use of wl_display_add_socket_auto (other compositors do as well).

Nov 14 2018, 12:45 PM · Plasma
fvogt added a comment to D15512: [startplasmacompositor] Add Wayland socket argument.

KWin doesn't need this functionality and shouldn't have this functionality and it would be difficult to implement.

Nov 14 2018, 8:03 AM · Plasma

Nov 11 2018

fvogt added a comment to D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon.

Edit: Indeed, AFAICS Neon's kcrash package seems to be from Oct. 12th...

https://archive.neon.kde.org/user/pool/main/k/kcrash/

Nov 11 2018, 4:32 PM · KDE Connect

Nov 6 2018

fvogt committed R282:fa472e6a5e26: Listen for added DBus interfaces instead of registered services (authored by fvogt).
Listen for added DBus interfaces instead of registered services
Nov 6 2018, 7:19 PM
fvogt closed D16471: Listen for added DBus interfaces instead of registered services.
Nov 6 2018, 7:19 PM · Frameworks
fvogt updated the summary of D16471: Listen for added DBus interfaces instead of registered services.
Nov 6 2018, 7:17 PM · Frameworks
fvogt added a comment to D16530: Drop X11 core fonts code from startkde/startplasma.

Looks good to me, but I don't know enough about old X11 stuff like this to accept it.

Nov 6 2018, 3:51 PM · Plasma
fvogt added a comment to D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon.

I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit message.

Is this workaround/fix only needed on neon or is the message wrong?

I think only Neon ships frameworks 5.51

Nov 6 2018, 3:22 PM · KDE Connect
fvogt added a comment to D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon.

I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit message.

Nov 6 2018, 1:27 PM · KDE Connect

Nov 5 2018

fvogt added a comment to D16471: Listen for added DBus interfaces instead of registered services.

Is this supposed to fix also the issue where when you log into a Plasma session, you first get a notification that it failed to activate a connection and then it gets activated successfuly?

Nov 5 2018, 6:45 PM · Frameworks

Nov 3 2018

fvogt committed R343:298fe1ae0443: Merge branch 'Applications/18.08' (authored by fvogt).
Merge branch 'Applications/18.08'
Nov 3 2018, 3:26 PM
fvogt closed D16631: Don't crash if initializeVideo fails.
Nov 3 2018, 3:25 PM
fvogt committed R343:b8223de8e65d: Don't crash if initializeVideo fails (authored by fvogt).
Don't crash if initializeVideo fails
Nov 3 2018, 3:25 PM
fvogt closed D16434: Fix keyboard layout change notifications.
Nov 3 2018, 12:14 PM · Frameworks
fvogt committed R268:4d28bd4183d2: Fix keyboard layout change notifications (authored by fvogt).
Fix keyboard layout change notifications
Nov 3 2018, 12:14 PM
fvogt updated the diff for D16434: Fix keyboard layout change notifications.

This file needs to be reformatted anyway.

Nov 3 2018, 12:13 PM · Frameworks
fvogt requested review of D16631: Don't crash if initializeVideo fails.
Nov 3 2018, 10:58 AM

Nov 2 2018

fvogt added inline comments to D16434: Fix keyboard layout change notifications.
Nov 2 2018, 7:08 PM · Frameworks
fvogt updated the diff for D16434: Fix keyboard layout change notifications.

Use if-else ladder instead of switch-case and fix a typo.

Nov 2 2018, 7:07 PM · Frameworks
fvogt updated the diff for D16434: Fix keyboard layout change notifications.

Add Q_ASSERT and xcb_key_symbols_free.

Nov 2 2018, 6:52 PM · Frameworks
fvogt closed D16305: Add a QIconEnginePlugin to allow QIcon deserialization.
Nov 2 2018, 12:26 PM · Frameworks
fvogt committed R302:3501660aa3d7: Add a QIconEnginePlugin to allow QIcon deserialization (authored by fvogt).
Add a QIconEnginePlugin to allow QIcon deserialization
Nov 2 2018, 12:26 PM

Oct 27 2018

fvogt updated the diff for D16471: Listen for added DBus interfaces instead of registered services.

Fix bad merge

Oct 27 2018, 11:34 PM · Frameworks
fvogt requested review of D16471: Listen for added DBus interfaces instead of registered services.
Oct 27 2018, 10:56 PM · Frameworks
fvogt committed R318:e13ffcb1a747: Adjust label in the settings page for changed preview behaviour (authored by fvogt).
Adjust label in the settings page for changed preview behaviour
Oct 27 2018, 2:45 PM
fvogt closed D15216: Adjust label in the settings page for changed preview behaviour.
Oct 27 2018, 2:45 PM · Dolphin
fvogt committed R31:663ef0c694b3: Fix build of libbreezecommon with USE_KDE4 (authored by fvogt).
Fix build of libbreezecommon with USE_KDE4
Oct 27 2018, 2:45 PM
fvogt closed D16459: Fix build of libbreezecommon with USE_KDE4.
Oct 27 2018, 2:45 PM · Plasma
fvogt requested review of D16459: Fix build of libbreezecommon with USE_KDE4.
Oct 27 2018, 2:43 PM · Plasma
fvogt reopened D15514: [libbreezecommon] Use box blur instead of FFT blur.

Fails to build the KDE4 version here:

Oct 27 2018, 2:05 PM · Plasma

Oct 26 2018

fvogt updated the diff for D16434: Fix keyboard layout change notifications.

Don't use a union. Still works.

Oct 26 2018, 11:18 AM · Frameworks
fvogt added a comment to D16434: Fix keyboard layout change notifications.

Note that the way it's done is copied from inspired by QXcbConnection.

Oct 26 2018, 11:11 AM · Frameworks
fvogt requested review of D16434: Fix keyboard layout change notifications.
Oct 26 2018, 8:04 AM · Frameworks

Oct 23 2018

fvogt committed R120:54acf31cc716: Merge branch 'Plasma/5.14' (authored by fvogt).
Merge branch 'Plasma/5.14'
Oct 23 2018, 3:28 PM
fvogt committed R120:04d66e67e16d: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.14
Oct 23 2018, 3:23 PM
fvogt committed R120:790f5bf48f2b: Only use wl-shell for the ksmserver greeters on Qt < 5.12 (authored by fvogt).
Only use wl-shell for the ksmserver greeters on Qt < 5.12
Oct 23 2018, 3:18 PM
fvogt closed D16381: Only use wl-shell for the ksmserver greeters on Qt < 5.12.
Oct 23 2018, 3:18 PM · Plasma
fvogt added a comment to D16381: Only use wl-shell for the ksmserver greeters on Qt < 5.12.

I created https://bugreports.qt.io/browse/QTBUG-71350

Oct 23 2018, 3:13 PM · Plasma
fvogt added a comment to D16381: Only use wl-shell for the ksmserver greeters on Qt < 5.12.

Do Qt know it's broken? It shouldn't be

Oct 23 2018, 3:04 PM · Plasma
fvogt requested review of D16381: Only use wl-shell for the ksmserver greeters on Qt < 5.12.
Oct 23 2018, 7:53 AM · Plasma

Oct 21 2018

fvogt reopened D16331: GTK theme treeview style typo/bug fix.

AFAICT Plasma/5.12 is affected as well, any reason this wasn't landed to 5.12?

Oct 21 2018, 9:01 AM · Breeze, Plasma

Oct 20 2018

fvogt committed R124:c37913c5add5: Fix crash on ExternalApp modules (authored by fvogt).
Fix crash on ExternalApp modules
Oct 20 2018, 11:06 AM

Oct 18 2018

fvogt requested review of D16305: Add a QIconEnginePlugin to allow QIcon deserialization.
Oct 18 2018, 6:48 PM · Frameworks

Oct 9 2018

fvogt committed R111:c9747e37c531: Port scripting to Qt WebEngine (authored by fvogt).
Port scripting to Qt WebEngine
Oct 9 2018, 9:45 AM
fvogt closed D15209: Port scripting to Qt WebEngine.
Oct 9 2018, 9:45 AM · Plasma
fvogt added a comment to D15209: Port scripting to Qt WebEngine.

I removed the RFC - I'm using this patch since I uploaded and haven't had any issues so far.

Oct 9 2018, 9:26 AM · Plasma
fvogt retitled D15209: Port scripting to Qt WebEngine from RFC: Port scripting to Qt WebEngine to Port scripting to Qt WebEngine.
Oct 9 2018, 9:25 AM · Plasma

Oct 8 2018

fvogt abandoned D15984: Close unneeded FDs before startup.

The bug reporter said a version of the patch causes busy loops? Is that this one?

Oct 8 2018, 10:56 AM · Plasma

Oct 6 2018

fvogt updated the test plan for D15984: Close unneeded FDs before startup.
Oct 6 2018, 4:44 PM · Plasma
fvogt requested review of D15984: Close unneeded FDs before startup.
Oct 6 2018, 4:43 PM · Plasma

Oct 4 2018

fvogt added a comment to D8532: [WIP] Restrict file extractor with Seccomp.

AFAICT this won't actually protect much - the open DBus socket is enough to execute arbitrary programs.

Oct 4 2018, 3:16 PM · Baloo, Frameworks

Oct 2 2018

fvogt added a comment to D15512: [startplasmacompositor] Add Wayland socket argument.

Is there a real reason against it besides "not necessary"? Maybe that we can't remove the manual override again without breaking some API promise once we have the grand solution of automatically taking the next free Wayland socket?

Oct 2 2018, 1:09 PM · Plasma

Oct 1 2018

fvogt added a comment to D15875: [Media Controller] Disallow seeking beyond end of track.

I'm not sure whether that's correct - a file with a duration of 1s still has a range of 1s.

Oct 1 2018, 11:49 AM · Plasma
fvogt accepted D15863: [MPris Plugin] Support Seek().
Oct 1 2018, 11:31 AM · Plasma
fvogt accepted D15863: [MPris Plugin] Support Seek().

LGTM. I just tried how the currentTime property in JS works, it actually behaves like MPRIS' seek does and does not ignore invalid values. That might need a check in SetPosition.

Oct 1 2018, 11:16 AM · Plasma
fvogt requested changes to D15863: [MPris Plugin] Support Seek().

Seek has a different behaviour for position() + offset < 0 and position() + offset == m_length:

Oct 1 2018, 9:50 AM · Plasma

Sep 24 2018

fvogt accepted D15724: Wait for duration to be known before registering player.
Sep 24 2018, 11:24 AM · Plasma
fvogt added inline comments to D15724: Wait for duration to be known before registering player.
Sep 24 2018, 11:18 AM · Plasma
fvogt added inline comments to D15724: Wait for duration to be known before registering player.
Sep 24 2018, 11:15 AM · Plasma

Sep 23 2018

fvogt added a comment to D15448: Send file contents in chunks.

! In D15448#330352, @ngraham wrote:
How is this looking now that D15426 has gone in?

Sep 23 2018, 10:24 AM