fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (143 w, 5 h)
Availability
Available

Recent Activity

Today

fvogt requested review of D19157: Don't show entries with NoDisplay=true with the applauncher containmentaction.
Tue, Feb 19, 2:10 PM · Plasma

Sun, Feb 17

fvogt added a comment to D18735: Improve built-in line/block characters drawing.

Thanks for working on this - I think perhaps this should be committed to master after the 19.04 is branched next month. Objections?

Sun, Feb 17, 9:13 PM · Konsole

Fri, Feb 15

fvogt added a comment to D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog.

Can you add context to this diff by either using arc or git diff with more context?

Fri, Feb 15, 7:52 AM · Frameworks

Sat, Feb 9

fvogt resigned from D18735: Improve built-in line/block characters drawing.

I can confirm that it fixes all border display issues that I encountered in the released version.

Sat, Feb 9, 10:31 AM · Konsole

Fri, Feb 8

fvogt added a comment to D18805: Workaround for the bug 393630 - SystemTray part.

Use @davidedmundson 's approach.

@ngraham Could you please help me to discard D18804 ? This patch does not require it anymore.

Fri, Feb 8, 8:27 AM · Plasma

Thu, Feb 7

fvogt added a reviewer for D18804: Workaround for the bug 393630 - Framework part: Plasma.
Thu, Feb 7, 7:59 AM · Frameworks

Wed, Feb 6

fvogt requested changes to D18735: Improve built-in line/block characters drawing.
Wed, Feb 6, 7:18 PM · Konsole

Tue, Feb 5

fvogt committed R296:856672f370fb: Correct the accept flag of the event object on DragMove (authored by trmdi).
Correct the accept flag of the event object on DragMove
Tue, Feb 5, 7:01 PM
fvogt closed D16643: Correct the accept flag of the event object on DragMove .

Landed (phab didn't notice): https://cgit.kde.org/kdeclarative.git/commit/?id=856672f370fb32c7a3c3d1a13d873fb8b767d0e8

Tue, Feb 5, 6:59 PM · Frameworks
fvogt accepted D16643: Correct the accept flag of the event object on DragMove .

@trmdi: Do you have push access? If not, which name <mail> should be used for the commit?

Tue, Feb 5, 6:47 PM · Frameworks
fvogt added a comment to D16643: Correct the accept flag of the event object on DragMove .

@trmdi: Can you do the small change @bruns suggested? ^ Then it can be landed and everyone's happy :-)

Tue, Feb 5, 2:51 PM · Frameworks
fvogt accepted D18750: Bail out if stream is negative.
Tue, Feb 5, 10:37 AM
fvogt added a comment to D16643: Correct the accept flag of the event object on DragMove .

The second change fvogt mentioned is IMHO handled quite strangely here - !m_enabled || m_temporaryInhibition is the inverse of !m_enabled || m_temporaryInhibition, so doing a event->ignore() === event->setAccepted(false) prior to the first return statement would cover the ignored case, and allows the event to bubble up.

Tue, Feb 5, 8:44 AM · Frameworks

Sat, Feb 2

fvogt added a comment to D18662: Add and rename some YaST icons and symlinks.

@fvogt LCP said a Qt bug was the reason that the icons weren't working correctly and that you would know more about it. I never got around to asking you though. Do you know which bug it is?

Sat, Feb 2, 11:02 AM · Frameworks

Thu, Jan 31

fvogt added a comment to D16643: Correct the accept flag of the event object on DragMove .

I tried to understand what this change does both by trying to reproduce the issue and reading Qt code.
Here the symptom was more drags not getting accepted at all than flipping back and forth, but this patch fixes that as well.

Thu, Jan 31, 8:23 PM · Frameworks

Mon, Jan 28

fvogt committed R287:51d710adda14: Fix various OOB reads and writes in kimg_tga and kimg_xcf (authored by fvogt).
Fix various OOB reads and writes in kimg_tga and kimg_xcf
Mon, Jan 28, 1:21 PM
fvogt closed D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.
Mon, Jan 28, 1:21 PM · Frameworks
fvogt updated the test plan for D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.
Mon, Jan 28, 9:29 AM · Frameworks
fvogt updated the diff for D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.

Also bail out early if image data known broken.
(Unrelated to the overflow fixes, but nice to have)

Mon, Jan 28, 9:24 AM · Frameworks
fvogt requested review of D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf.
Mon, Jan 28, 8:41 AM · Frameworks

Sat, Jan 26

fvogt added a comment to T10397: Qt 5.12 for plasma master.

We've had Qt 5.12 packaged and available since the first alpha and started to build KDE software against the second alpha - would it be possible to do it similarly in the KDE CI?
Starting to build also against pre-release Qt would be helpful as currently KDE CI is lagging behind what rolling release distros actually ship and it might help preventing some issues.

Sat, Jan 26, 10:30 AM · build.kde.org

Fri, Jan 25

fvogt accepted D18522: Name Wayland socket automatically when no socket name was specified.

Not tested, but looks correct to me. (Famous last words?)

Fri, Jan 25, 12:34 PM · KWin
fvogt committed R127:d671fcd0c09d: Add option to use wl_display_add_socket_auto (authored by fvogt).
Add option to use wl_display_add_socket_auto
Fri, Jan 25, 12:32 PM
fvogt closed D17122: Add option to use wl_display_add_socket_auto.
Fri, Jan 25, 12:32 PM · Frameworks
fvogt updated the diff for D17122: Add option to use wl_display_add_socket_auto.

Replace XDG_RUNTIME_DIR, test still passes

Fri, Jan 25, 12:25 PM · Frameworks
fvogt added inline comments to D17122: Add option to use wl_display_add_socket_auto.
Fri, Jan 25, 12:15 PM · Frameworks

Mon, Jan 21

fvogt accepted D10716: handle wrong password when using sudo which asks for another password.
Mon, Jan 21, 1:05 PM · Frameworks

Jan 18 2019

fvogt added a comment to D18366: Fix flickering with Qt 5.12.

This should probably land on Plasma/5.12 as well.

Jan 18 2019, 7:49 PM · KWin
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.
Jan 18 2019, 11:57 AM · Frameworks
fvogt updated the diff for D17122: Add option to use wl_display_add_socket_auto.

Add some style

Jan 18 2019, 11:56 AM · Frameworks
fvogt updated the test plan for D17122: Add option to use wl_display_add_socket_auto.
Jan 18 2019, 10:50 AM · Frameworks
fvogt updated the diff for D17122: Add option to use wl_display_add_socket_auto.

Use a new bool instead.

Jan 18 2019, 10:49 AM · Frameworks
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.

Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old behavior.

That would need changes in KWin though so Plasma 5.16 only :-(

Yes, that's fine. Do you need it for something in 5.15?

Jan 18 2019, 10:21 AM · Frameworks
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.

Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old behavior.

Jan 18 2019, 10:05 AM · Frameworks
fvogt accepted D18353: Compile the virtual backend with older Mesa.

Builds fine!

Jan 18 2019, 10:03 AM · KWin
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.

I don't think we need a second variable effectiveSocketName. Just test if socketName is empty. If it is call wl_display_add_socket_auto, otherwise call wl_display_add_socket.

If socketName is overwritten after using wl_display_add_socket_auto, it's not possible to call start twice without resetting socketName again.

If the actual socket's name is not written to any variable, it's impossible to set WAYLAND_DISPLAY correctly in KWin.

The new variable is used to be fully API compatible except if socketName was explicitly set to an empty string.

Is a Display object meant to be started and terminated more than once? But ok, let's make sure.

Jan 18 2019, 8:48 AM · Frameworks
fvogt added a comment to D17122: Add option to use wl_display_add_socket_auto.

I don't think we need a second variable effectiveSocketName. Just test if socketName is empty. If it is call wl_display_add_socket_auto, otherwise call wl_display_add_socket.

Jan 18 2019, 7:47 AM · Frameworks

Jan 17 2019

fvogt accepted D18309: don't set python exe to undefined.

Tested with cmake 3.10.2, works.

Jan 17 2019, 8:11 AM · Plasma

Jan 15 2019

fvogt added inline comments to D18182: Fix new file creation leading to dupe items on a fresh view.
Jan 15 2019, 8:50 AM · Plasma

Jan 14 2019

fvogt added inline comments to D10716: handle wrong password when using sudo which asks for another password.
Jan 14 2019, 5:52 PM · Frameworks
fvogt requested changes to D10716: handle wrong password when using sudo which asks for another password.
Jan 14 2019, 4:28 PM · Frameworks
fvogt added inline comments to D10716: handle wrong password when using sudo which asks for another password.
Jan 14 2019, 1:34 PM · Frameworks
fvogt added a reverting change for R241:4e2a815b9a10: Refactor SlaveInterface::calcSpeed: R241:514ea33ead78: Revert "Refactor SlaveInterface::calcSpeed".
Jan 14 2019, 12:55 PM
l10n daemon script <scripty@kde.org> committed R241:514ea33ead78: Revert "Refactor SlaveInterface::calcSpeed" (authored by fvogt).
Revert "Refactor SlaveInterface::calcSpeed"
Jan 14 2019, 12:55 PM
l10n daemon script <scripty@kde.org> committed R241:815f12410b11: Revert "Fix elapsed time check" (authored by fvogt).
Revert "Fix elapsed time check"
Jan 14 2019, 12:55 PM
fvogt added a reverting change for R241:cd2f67c39b25: Fix elapsed time check: R241:815f12410b11: Revert "Fix elapsed time check".
Jan 14 2019, 12:55 PM
fvogt committed R241:b8a5f34b34b6: Revert "Refactor SlaveInterface::calcSpeed" (authored by fvogt).
Revert "Refactor SlaveInterface::calcSpeed"
Jan 14 2019, 12:39 PM
fvogt added a reverting change for R241:4e2a815b9a10: Refactor SlaveInterface::calcSpeed: R241:b8a5f34b34b6: Revert "Refactor SlaveInterface::calcSpeed".
Jan 14 2019, 12:39 PM
fvogt added a reverting change for R241:cd2f67c39b25: Fix elapsed time check: R241:0362f77d51b2: Revert "Fix elapsed time check".
Jan 14 2019, 12:39 PM
fvogt committed R241:0362f77d51b2: Revert "Fix elapsed time check" (authored by fvogt).
Revert "Fix elapsed time check"
Jan 14 2019, 12:39 PM
fvogt requested changes to D17528: Refactor SlaveInterface::calcSpeed.
Jan 14 2019, 12:27 PM · Frameworks

Jan 13 2019

fvogt added a comment to D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor.
In D18233#392685, @zzag wrote:

We should probably update https://community.kde.org/KWin/Wayland as well.

Jan 13 2019, 10:09 PM · Plasma
fvogt committed R120:65e3cc3a58ce: Set XDG_SESSION_TYPE=wayland in startplasmacompositor (authored by fvogt).
Set XDG_SESSION_TYPE=wayland in startplasmacompositor
Jan 13 2019, 10:04 PM
fvogt closed D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor.
Jan 13 2019, 10:04 PM · Plasma
fvogt added a comment to D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor.

The login manager should set this already

Jan 13 2019, 9:19 PM · Plasma
fvogt requested review of D18233: Set XDG_SESSION_TYPE=wayland in startplasmacompositor.
Jan 13 2019, 8:17 PM · Plasma

Jan 11 2019

fvogt added a comment to D10716: handle wrong password when using sudo which asks for another password.

Is it necessary to write the mock su/sudo in python? That introduces a big and mostly unnecessary dependency on python.

Nope but that's what was easiest for me and I'm out of energy for this

The testcases would be simpler if it used QTESTDATA and rows for the su/sudo and correct/incorrect password cases

Something else I need to learn about.

Jan 11 2019, 7:15 PM · Frameworks

Jan 10 2019

fvogt requested changes to D10716: handle wrong password when using sudo which asks for another password.
  • set XDG_CONFIG_HOME to put kdesutestrc not in running users config dir
Jan 10 2019, 6:07 PM · Frameworks
fvogt requested changes to D10716: handle wrong password when using sudo which asks for another password.
Jan 10 2019, 3:57 PM · Frameworks
fvogt requested changes to D10716: handle wrong password when using sudo which asks for another password.
Jan 10 2019, 12:12 PM · Frameworks

Jan 6 2019

fvogt added a comment to T10245: KWin tests requiring opengl are failing.

That's true, but if openSUSE run our unit tests it would be found.

Jan 6 2019, 12:15 AM · build.kde.org

Jan 5 2019

fvogt committed R120:d3ef9523ab46: Merge branch 'Plasma/5.9' (authored by fvogt).
Merge branch 'Plasma/5.9'
Jan 5 2019, 4:10 PM
fvogt committed R120:610b16239315: Merge branch 'Plasma/5.8' into Plasma/5.9 (authored by fvogt).
Merge branch 'Plasma/5.8' into Plasma/5.9
Jan 5 2019, 4:10 PM

Dec 26 2018

fvogt added a comment to D17359: Fix use of QRegularExpressionMatch.

Is this the issue this fix is intended for>

Dec 26 2018, 3:03 PM · Plasma

Dec 22 2018

fvogt added a comment to D17623: Add YaST and new preference icons.

@fvogt @hellcp For some reason YaST Control Center only works with 32px icons from Breeze but it can work with seemingly any size icon from hicolor. If either of you could help me figure out why that is, I would appreciate it.

AFAICT YaST just uses QIcon::fromTheme("foo").pixmap(32, 32) which should work just fine. Did you refresh the icon cache? What's the issue exactly? Do you see the wrong icon, wrong size or no icon at all?

Actually, it works with 32px and 48px Breeze icons, but not 64px. If the Breeze icon is 64px, yast-c-c shows the hicolor icon. If there is no hicolor icon for a module (i.e., I delete all yast-printer icons from hicolor), yast-c-c shows the yast icon, even if there is a Breeze icon at 64px. I'm pretty sure it's not an icon cache issue because there are no issues with changing icons to 48px versions, only 64px has issues.

Dec 22 2018, 1:13 PM · Frameworks

Dec 21 2018

fvogt added a comment to D17623: Add YaST and new preference icons.

@fvogt @hellcp For some reason YaST Control Center only works with 32px icons from Breeze but it can work with seemingly any size icon from hicolor. If either of you could help me figure out why that is, I would appreciate it.

Dec 21 2018, 10:50 PM · Frameworks

Dec 5 2018

fvogt added a comment to D17365: Round label width.

Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" in particular. Is this really the trade-off we're faced with? It feels like there are upstream Qt bugs here.

Dec 5 2018, 3:14 PM · Plasma
fvogt committed R119:02ef57d37b2c: Merge branch 'Plasma/5.14' (authored by fvogt).
Merge branch 'Plasma/5.14'
Dec 5 2018, 9:55 AM
fvogt committed R119:5323adb7cfac: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.14
Dec 5 2018, 9:55 AM
fvogt committed R119:3526334e8234: Round label width (authored by fvogt).
Round label width
Dec 5 2018, 9:55 AM
fvogt closed D17365: Round label width.
Dec 5 2018, 9:55 AM · Plasma
fvogt updated the summary of D17365: Round label width.
Dec 5 2018, 9:52 AM · Plasma
fvogt updated the diff for D17365: Round label width.

Turns out the label width rounding is enough

Dec 5 2018, 9:51 AM · Plasma
fvogt added inline comments to D17365: Round label width.
Dec 5 2018, 9:50 AM · Plasma
fvogt updated the test plan for D17365: Round label width.
Dec 5 2018, 9:46 AM · Plasma
fvogt requested review of D17365: Round label width.
Dec 5 2018, 9:35 AM · Plasma

Dec 4 2018

fvogt committed R845:383483355253: Merge branch 'Plasma/5.14' (authored by fvogt).
Merge branch 'Plasma/5.14'
Dec 4 2018, 7:49 PM
fvogt committed R845:ab3c96c5ddbf: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.14
Dec 4 2018, 7:49 PM
fvogt committed R845:5d3face3c1bb: Fix use of QRegularExpressionMatch (authored by fvogt).
Fix use of QRegularExpressionMatch
Dec 4 2018, 7:49 PM
fvogt closed D17359: Fix use of QRegularExpressionMatch.
Dec 4 2018, 7:49 PM · Plasma
fvogt requested review of D17359: Fix use of QRegularExpressionMatch.
Dec 4 2018, 7:36 PM · Plasma

Dec 3 2018

fvogt accepted D17326: Make media session property setter more resilient.

Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read.

Dec 3 2018, 8:36 AM · Plasma
fvogt added a comment to D17326: Make media session property setter more resilient.

It can, processMetadata(data.value(QStringLiteral("metadata")).toObject()); turns it into an empty object when null (or anything but an Object)

Dec 3 2018, 8:32 AM · Plasma
fvogt added a comment to D17326: Make media session property setter more resilient.

Can host/mprisplugin.cpp deal with payload being null properly?

Dec 3 2018, 8:21 AM · Plasma

Nov 30 2018

fvogt added a comment to D17233: Only cancel job when an "error" is set and ignore "interrupted".

LGTM otherwise.

Nov 30 2018, 7:11 PM · Plasma
fvogt added a comment to D17248: Add Rectangular Region mode on wayland [RFC].

I implemented the same hack here locally some time ago and it works perfectly fine if started with spectacle -platform xcb.

Nov 30 2018, 2:04 PM · Spectacle

Nov 29 2018

fvogt added a comment to D17233: Only cancel job when an "error" is set and ignore "interrupted".

It might work as well to just ignore the "interrupted" state completely and only react when error becomes set.

Nov 29 2018, 6:16 PM · Plasma

Nov 28 2018

fvogt added a comment to D17187: Set the default cursor theme to breeze_cursors.

OTOH, this patch actually causes a mismatch if one changes the cursor theme in Plasma's cursor theme KCM. (it won't affect GTK applications, they will continue to use breeze...)

Nov 28 2018, 9:40 AM · Plasma

Nov 27 2018

fvogt added a comment to D17187: Set the default cursor theme to breeze_cursors.

Actually, if the cursor theme is not set to anything, GTK would just use the session's default. I.e. this patch should not be necessary in the first place.

Nov 27 2018, 9:15 PM · Plasma
fvogt committed R98:0f63920d8a5f: Merge branch 'Plasma/5.14' (authored by fvogt).
Merge branch 'Plasma/5.14'
Nov 27 2018, 6:08 PM
fvogt committed R98:427202d44d5e: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.14
Nov 27 2018, 6:08 PM
fvogt committed R98:dcacaa1d4f7e: Set the default cursor theme to breeze_cursors (authored by fvogt).
Set the default cursor theme to breeze_cursors
Nov 27 2018, 6:08 PM
fvogt closed D17187: Set the default cursor theme to breeze_cursors.
Nov 27 2018, 6:08 PM · Plasma
fvogt requested review of D17187: Set the default cursor theme to breeze_cursors.
Nov 27 2018, 2:49 PM · Plasma

Nov 24 2018

fvogt added a comment to D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling.

Yeah, I had a feeling that that might end up as a better place for the fix. Someone else would need to do that patch or help me with it though. I gave it a shot but couldn't get the binding right.

Nov 24 2018, 11:13 PM · Plasma
fvogt added a comment to D17143: Pixel-align the sidebar's flickables to prevent artifacts when scrolling.

IMO this workaround is generic enough that adding it into ScrollablePage.qml or even templates/private/ScrollView.qml itself is better as it hits almost every use.

Nov 24 2018, 10:46 PM · Plasma

Nov 23 2018

fvogt requested review of D17122: Add option to use wl_display_add_socket_auto.
Nov 23 2018, 1:43 PM · Frameworks
fvogt accepted D16435: Also catch new Audio() elements.

LGTM, but I have no idea about this part of JS.

Nov 23 2018, 12:57 PM · Plasma

Nov 22 2018

fvogt accepted D17102: Connect to contextMenu clicked callback only once.
Nov 22 2018, 3:35 PM · Plasma
fvogt accepted D16889: Listen to KDE Connect device signals.
Nov 22 2018, 2:46 PM · KDE Connect, Plasma