fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (169 w, 2 d)
Availability
Available

Recent Activity

Yesterday

fvogt committed R308:54e18b0d9b0d: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly (authored by fvogt).
Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly
Wed, Aug 21, 11:58 AM
fvogt closed D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly.
Wed, Aug 21, 11:58 AM · Frameworks

Thu, Aug 15

fvogt requested changes to D23151: Implement Web Share API through Purpose.
Thu, Aug 15, 2:49 PM · Plasma
fvogt requested changes to D23151: Implement Web Share API through Purpose.

AFAICT this won't work on wayland and will also break the browser's native implementation once that actually exists.

Thu, Aug 15, 8:21 AM · Plasma

Wed, Aug 14

fvogt accepted D21113: Allow hiding option items depending on available extension and version in the host.
Wed, Aug 14, 9:02 AM · Plasma
fvogt added inline comments to D21113: Allow hiding option items depending on available extension and version in the host.
Wed, Aug 14, 8:47 AM · Plasma

Tue, Aug 13

fvogt accepted D23099: Allow sending a port message and receive a reply.
Tue, Aug 13, 1:03 PM · Plasma
fvogt added inline comments to D23099: Allow sending a port message and receive a reply.
Tue, Aug 13, 9:51 AM · Plasma
fvogt added inline comments to D23099: Allow sending a port message and receive a reply.
Tue, Aug 13, 8:33 AM · Plasma
fvogt accepted D23122: Enable enhanced media controls by default.
Tue, Aug 13, 7:58 AM · Plasma
fvogt accepted D23100: Let settings work with arbitrary input controls.

Didn't test, but looks good

Tue, Aug 13, 7:27 AM · Plasma
fvogt requested changes to D22203: glx: Don't use sRGB configs on llvmpipe.

From the bug report:

Tue, Aug 13, 7:22 AM · KWin

Mon, Aug 12

fvogt accepted D23090: Handle media session callbacks before passing it on to the browser.
Mon, Aug 12, 8:18 PM · Plasma
fvogt added inline comments to D23100: Let settings work with arbitrary input controls.
Mon, Aug 12, 8:17 PM · Plasma
fvogt added a comment to D23099: Allow sending a port message and receive a reply.

IMHO the member variable is really ugly. Messages with and without serial number have to be handled differently anyway, so why not introuce a new handleMessage(event, json, serial) method?

Mon, Aug 12, 6:23 PM · Plasma
fvogt requested changes to D23100: Let settings work with arbitrary input controls.
Mon, Aug 12, 5:36 PM · Plasma
fvogt added inline comments to D23100: Let settings work with arbitrary input controls.
Mon, Aug 12, 5:36 PM · Plasma
fvogt accepted D23107: Slightly prettier debug.

TIL that exists

Mon, Aug 12, 5:24 PM · Plasma
fvogt accepted D23091: Call media session callback with details.
Mon, Aug 12, 5:21 PM · Plasma
fvogt added inline comments to D23090: Handle media session callbacks before passing it on to the browser.
Mon, Aug 12, 5:16 PM · Plasma

Sat, Aug 10

fvogt committed R123:2ce7ccd2dff8: Remove persistence from the kauth helper (authored by fvogt).
Remove persistence from the kauth helper
Sat, Aug 10, 8:34 PM
fvogt closed D23078: Remove persistence from the kauth helper.
Sat, Aug 10, 8:34 PM · Plasma
fvogt requested review of D23078: Remove persistence from the kauth helper.
Sat, Aug 10, 8:23 PM · Plasma

Thu, Aug 8

fvogt added inline comments to D23029: Fix the attica pkgconfig file..
Thu, Aug 8, 12:18 PM · Frameworks
fvogt added a comment to D22979: Security: remove support for $(...) in config keys with [$e] marker..

Does anyone think this can be easily backported to previous versions of KDE in upstream distros such as Kubuntu, etc.?

Thu, Aug 8, 5:31 AM · Frameworks

Wed, Aug 7

fvogt added a comment to D22989: Security: remove support for $(...) in config keys with [$e] marker..

Built fine and Icon[$e]=$(kinfocenter) didn't work anymore as expected.

Wed, Aug 7, 11:42 AM
fvogt accepted D22596: [MPRIS Data Engine] Ignore non-standards compliant players.

Code looks good, if you tested successfully with vlc this can IMO go in

Wed, Aug 7, 9:35 AM · Plasma

Tue, Aug 6

fvogt committed R320:417a2f7cdc2c: Add support for sandboxing thumbnailers (authored by fvogt).
Add support for sandboxing thumbnailers
Tue, Aug 6, 1:04 PM

Mon, Aug 5

fvogt committed R487:b05bc9db032c: Merge branch 'Plasma/5.9' (authored by fvogt).
Merge branch 'Plasma/5.9'
Mon, Aug 5, 12:12 PM
fvogt committed R487:df012f7ad6e4: Merge branch 'Plasma/5.8' into Plasma/5.9 (authored by fvogt).
Merge branch 'Plasma/5.8' into Plasma/5.9
Mon, Aug 5, 12:12 PM

Thu, Aug 1

fvogt added inline comments to D22571: Allow blacklisting some wayland interfaces.
Thu, Aug 1, 12:43 PM · KWin

Tue, Jul 30

fvogt committed R120:444045af72fd: Merge branch 'Plasma/5.16' (authored by fvogt).
Merge branch 'Plasma/5.16'
Tue, Jul 30, 5:46 PM
fvogt committed R120:7fdc614f4226: Bind SQL parameters in firefox bookmarksrunner support (authored by fvogt).
Bind SQL parameters in firefox bookmarksrunner support
Tue, Jul 30, 5:45 PM
fvogt closed D22623: Bind SQL parameters in firefox bookmarksrunner support.
Tue, Jul 30, 5:45 PM · Plasma
fvogt added a comment to D22623: Bind SQL parameters in firefox bookmarksrunner support.

I'll land in 24h if no objections.

Tue, Jul 30, 5:12 PM · Plasma

Mon, Jul 29

fvogt accepted D22813: Don't give up if no results arrive after 500 ms, again..
Mon, Jul 29, 7:10 PM · Plasma
fvogt requested changes to D22813: Don't give up if no results arrive after 500 ms, again..
Mon, Jul 29, 7:06 PM · Plasma
fvogt added a comment to D22571: Allow blacklisting some wayland interfaces.

IMO there should be a clear warning or error message if and why a request was declined.

This can't be done here. We're blocking advertising the protocol, so it's before the client has requested anything.

If we want that sort of thing, we probably need the approach I suggested in the original task, but at this point I think we're probably better off merging something so we can unblock everything that depends on this and then we can build on it later.

Mon, Jul 29, 11:30 AM · KWin

Sat, Jul 27

fvogt added a comment to D22723: Fix RunnerManager::queryFinished().

QObjects live in their own thread and shouldn't be used outside.
https://doc.qt.io/qt-5/qobject.html#thread

In your patch we are emitting the signal from the run thread instead of the actual object's thread. This is wrong.

Sat, Jul 27, 8:28 AM · Frameworks

Fri, Jul 26

fvogt added a comment to D22723: Fix RunnerManager::queryFinished().

I honestly don't see the problem with this patch, one may argue that the ThreadWeaver API is awkward, ok, but this is using it correctly AFAICS, i.e. have a ThreadWeaver::QObjectDecorator, give it a ThreadWeaver::Job on its constructor, and go on from there.

Fri, Jul 26, 7:10 AM · Frameworks
fvogt requested review of D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly.
Fri, Jul 26, 7:06 AM · Frameworks

Thu, Jul 25

fvogt added a comment to D22719: Avoid yet another crash on exit.

Your comment https://bugzilla.opensuse.org/show_bug.cgi?id=1141883#c17 does make wonder if OpenSuse has the latest QtCurve version (or more specifically, if the proposed change is the only fix/workaround for the issue in the latest QtCurve version from git?

Thu, Jul 25, 9:43 AM
fvogt added a comment to D22723: Fix RunnerManager::queryFinished().
In D22723#501907, @apol wrote:

Looks like a hack still, with two Job objects for each job...

What about just merging QObjectDecorator into FindMatchesJobInternal by basically just adding a custom done signal and ignoring the entire "decorators which are actually wrappers" business?

IMO this new FindMatchesJobInternal class makes it even less obvious what's actually going on.

This is how ThreadWeaver and especially QObjectDecorator is meant to be used.

Thu, Jul 25, 7:33 AM · Frameworks

Wed, Jul 24

fvogt added a reviewer for D22723: Fix RunnerManager::queryFinished(): davidedmundson.

Looks like a hack still, with two Job objects for each job...

Wed, Jul 24, 6:27 PM · Frameworks
fvogt added a comment to D22719: Avoid yet another crash on exit.
Didn't know this can happen and lgtm.

Idem (2x).

Out of curiosity: how do you invoke pinentry-qt to trigger the crash, where does the it occur, and what does qApp->arguments()[0] return if there are no arguments? FWIW my own copy of pinentry-qt starts and exits fine, but I don't know how to make it pop up a GUI.

Wed, Jul 24, 4:52 PM
fvogt requested review of D22719: Avoid yet another crash on exit.
Wed, Jul 24, 3:21 PM
fvogt added a comment to D22571: Allow blacklisting some wayland interfaces.

IMO there should be a clear warning or error message if and why a request was declined.

Wed, Jul 24, 10:27 AM · KWin

Jul 23 2019

fvogt committed R1032:f8aef3114579: Use KDE_INSTALL_LOGGINGCATEGORIESDIR in ECM 5.59 (authored by fvogt).
Use KDE_INSTALL_LOGGINGCATEGORIESDIR in ECM 5.59
Jul 23 2019, 9:20 AM
fvogt closed D22650: Use KDE_INSTALL_LOGGINGCATEGORIESDIR in ECM 5.59.
Jul 23 2019, 9:20 AM
fvogt added a comment to D22650: Use KDE_INSTALL_LOGGINGCATEGORIESDIR in ECM 5.59.

(Somewhat OT) I asked dfaure about the header file installation and it's split correctly as kpublictransport is namespaced and this way the include paths match the classes.

Jul 23 2019, 9:16 AM

Jul 22 2019

fvogt updated the summary of D22650: Use KDE_INSTALL_LOGGINGCATEGORIESDIR in ECM 5.59.
Jul 22 2019, 3:10 PM
fvogt requested review of D22650: Use KDE_INSTALL_LOGGINGCATEGORIESDIR in ECM 5.59.
Jul 22 2019, 2:48 PM
fvogt accepted D22641: Inject content script also into about:blank.
Jul 22 2019, 1:03 PM · Plasma
fvogt added a comment to D22641: Inject content script also into about:blank.

An iframe without source, the things web devs come up with...

Jul 22 2019, 1:02 PM · Plasma
fvogt accepted D22642: Monitor entire document rather than the documentElement specifically.
Jul 22 2019, 1:01 PM · Plasma

Jul 21 2019

fvogt requested review of D22623: Bind SQL parameters in firefox bookmarksrunner support.
Jul 21 2019, 6:37 PM · Plasma
fvogt accepted D21112: Support message response and reply callbacks.

Code looks good and seems to work fine in vivaldi, but I get an error in firefox:

Promise resolved after context unloaded
extension.js:78
    sendSettings moz-extension://d1f34b4e-4e97-40a5-b4ac-03dc2fea30a9/extension.js:78

appears to be harmless though?

Jul 21 2019, 11:16 AM · Plasma
fvogt committed R856:8a254b2ec2e0: Fix compile warnings (authored by fvogt).
Fix compile warnings
Jul 21 2019, 10:36 AM
fvogt closed D22607: Fix compile warnings.
Jul 21 2019, 10:36 AM · Plasma
fvogt updated the diff for D22607: Fix compile warnings.

Do it differently.

Jul 21 2019, 10:35 AM · Plasma
fvogt requested review of D22607: Fix compile warnings.
Jul 21 2019, 10:32 AM · Plasma
fvogt added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

drop translations, rename to 'Plasma on Xorg'

Jul 21 2019, 7:58 AM · Plasma

Jul 20 2019

fvogt added a comment to D21112: Support message response and reply callbacks.

Code looks good and seems to work fine in vivaldi, but I get an error in firefox:

Jul 20 2019, 4:40 PM · Plasma
fvogt added a comment to D20830: Add hack to unbreak audio playback through pure JS via new Audio().

Still can't reproduce, but doesn't seem to intruduce a regression either

Jul 20 2019, 3:41 PM · Plasma
fvogt accepted D20830: Add hack to unbreak audio playback through pure JS via new Audio().
Jul 20 2019, 3:36 PM · Plasma

Jul 19 2019

fvogt added a comment to D22562: Add detectPlatform to always use wayland in a wayland session.

Should this be merged to master in addition of 1.x?

Jul 19 2019, 9:12 PM · KDE Connect
fvogt committed R224:f765ffb186f0: Add detectPlatform to always use wayland in a wayland session (authored by fvogt).
Add detectPlatform to always use wayland in a wayland session
Jul 19 2019, 5:57 PM
fvogt closed D22562: Add detectPlatform to always use wayland in a wayland session.
Jul 19 2019, 5:57 PM · KDE Connect
fvogt requested review of D22562: Add detectPlatform to always use wayland in a wayland session.
Jul 19 2019, 3:17 PM · KDE Connect
fvogt added inline comments to D22555: [RFC] Add a kded module to manage various available fuse mount services.
Jul 19 2019, 11:25 AM · Frameworks

Jul 11 2019

fvogt committed R72:8833b4d07682: Install internal libraries with NAMELINK_SKIP (authored by fvogt).
Install internal libraries with NAMELINK_SKIP
Jul 11 2019, 6:27 PM
fvogt closed D22280: Install internal libraries with NAMELINK_SKIP.
Jul 11 2019, 6:27 PM · KDE Edu
fvogt added a comment to D22397: [Fonts KCM] Alter DPI only on explicit user interaction.

Haven't checked whether this is in 5.16 or only a master regression.

Jul 11 2019, 1:22 PM · Plasma

Jul 10 2019

fvogt committed R108:fcad1198ce69: Merge branch 'Plasma/5.16' (authored by fvogt).
Merge branch 'Plasma/5.16'
Jul 10 2019, 9:08 AM
fvogt committed R108:f6b1e028daff: Merge branch 'Plasma/5.12' into Plasma/5.16 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.16
Jul 10 2019, 9:08 AM
fvogt committed R108:c3c030d8b595: Fix creation of kdeglobals if /etc/xdg/kdeglobals present (authored by fvogt).
Fix creation of kdeglobals if /etc/xdg/kdeglobals present
Jul 10 2019, 9:08 AM
fvogt closed D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present.
Jul 10 2019, 9:08 AM · KWin

Jul 5 2019

fvogt requested changes to D15875: [Media Controller] Disallow seeking beyond end of track.

1s file is a corner case as well as 0, cause you have always 2 positions - start and stop.

Jul 5 2019, 12:03 PM · Plasma
fvogt requested changes to D21113: Allow hiding option items depending on available extension and version in the host.
Jul 5 2019, 11:58 AM · Plasma
fvogt accepted D22065: Introduce PluginManager.
Jul 5 2019, 11:20 AM · Plasma

Jul 4 2019

fvogt updated the summary of D22280: Install internal libraries with NAMELINK_SKIP.
Jul 4 2019, 7:59 PM · KDE Edu
fvogt requested review of D22280: Install internal libraries with NAMELINK_SKIP.
Jul 4 2019, 7:24 PM · KDE Edu

Jul 3 2019

fvogt committed R98:a581f3231e02: kconf_update: Also migrate from BreezyGTK (authored by fvogt).
kconf_update: Also migrate from BreezyGTK
Jul 3 2019, 5:16 PM
fvogt closed D22237: kconf_update: Also migrate from BreezyGTK.
Jul 3 2019, 5:16 PM · Plasma
fvogt updated the summary of D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present.
Jul 3 2019, 1:32 PM · KWin
fvogt updated the diff for D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present.

Do it differently.

Jul 3 2019, 1:32 PM · KWin
fvogt added a comment to D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present.

Basically doing
!m_colorScheme.startsWith(QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation))
instead might work, but maybe there are cases with more than once writable location?

Jul 3 2019, 1:10 PM · KWin
fvogt requested review of D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present.
Jul 3 2019, 12:40 PM · KWin
fvogt requested review of D22237: kconf_update: Also migrate from BreezyGTK.
Jul 3 2019, 12:08 PM · Plasma
fvogt added a comment to D22229: Ignore Next/Previous call if CanGoNext/CanGoPrevious are false.

IMO this should be up to the content script, which seems to handle this properly already

Jul 3 2019, 7:29 AM · Plasma
fvogt added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

This patch only helps with the case where SDDM is updated first,

Jul 3 2019, 7:10 AM · Plasma

Jul 2 2019

fvogt added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

This is a necessary step to avoid having two indistinguishable "Plasma" options in SDDM with the linked PR merged and all other DMs , the other option is to have a "Plasma (Wayland) (Wayland)" in sddm only.

Jul 2 2019, 1:59 PM · Plasma
fvogt added a comment to D22203: glx: Don't use sRGB configs on llvmpipe.

llvmpipe generally works fine, just not when using it with cirrus if the kernel uses 16bpp.

Jul 2 2019, 8:32 AM · KWin
fvogt accepted D21927: Use window.postMessage instead of creating a wrapper item.
Jul 2 2019, 7:41 AM · Plasma
fvogt accepted D21968: Set desktopFileName.
Jul 2 2019, 7:21 AM · Plasma
fvogt accepted D22068: Send downloads when downloads plugin is loaded.
Jul 2 2019, 7:14 AM · Plasma

Jul 1 2019

fvogt resigned from D22147: Better use of Qt APIs in Plasma::Theme.
Jul 1 2019, 2:45 PM · Frameworks
fvogt added inline comments to D22147: Better use of Qt APIs in Plasma::Theme.
Jul 1 2019, 2:32 PM · Frameworks
fvogt requested changes to D22147: Better use of Qt APIs in Plasma::Theme.
Jul 1 2019, 2:10 PM · Frameworks

Jun 25 2019

fvogt added inline comments to D22065: Introduce PluginManager.
Jun 25 2019, 8:40 AM · Plasma