- User Since
- May 24 2016, 11:24 AM (100 w, 21 h)
I just noticed I never landed this - fixed now.
Mon, Apr 23
What about Plasma/5.12?
Sat, Apr 21
I'm pointing out that I'm in general against any risky changes on X11. If users want to use this features: Wayland is there. KWin is feature frozen on X11 and I highly suggest to the Plasma community to decide the same at the sprint. We will have less maintenance issues due to it.
So I wouldn't trust this thing in Qt to work due to the pain we have in KWin especially with these problems.
Docs say QT_SCREEN_SCALE_FACTORS doesn't affect the logical DPI. which means you have a 1x scale on one screen 2x on another..they both have the same font size which will just be really wrong.
Fri, Apr 20
Improve the commit message.
I gave it a quick test - works fine with ssh(-add). I didn't test anything else though.
Use of QStringLiteral and nullptr in some cases, but maybe that's just phabricator doing git diff wrong.
Rebase looks ok - but now there are too many unrelated changes in the diff. Can you split them?
Thu, Apr 19
Wed, Apr 18
(Actually targeting the Plasma/5.12 branch)
Tue, Apr 17
Mon, Apr 9
Sun, Apr 8
No objections from me - as long as the feature is disabled correctly, which it currently isn't.
What about Plasma/5.12? It has a minimum of Qt 5.9 as well.
Sat, Apr 7
Fri, Apr 6
LGTM - compile tested only. My tablet doesn't go into the libwacom codepath anyway.
Looks good to me, except for the unnecessary checks for nullptr.
Looks ok to me, I just added a few suggestions.
Thu, Apr 5
I don't even have that binary installed and no package contains it here - probably some legacy KDE4 stuff.
Not at all intentional. It just didn't crossed my mind. I suppose the cmake file needs to be patched to not build the helper?
KAuth support in KIO is currently disabled due to following security issues:
Sat, Mar 31
Fri, Mar 30
This seems to be a bugfix - Plasma/5.12 branch as well?
Tue, Mar 27
There was a discussion about this on IRC quite some time ago:
Given this is just runtime, I suggest we just cut it. If it causes issues then the tests which start failing can be remedied later.
Do the same as krunner, unset the variable if platform got detected.
Mon, Mar 26
Tomorrow is release of 5.12.4, so I cherry-picked the commit into the Plasma/5.12 branch and merged.
Mar 25 2018
I missed two minor issues - but then it should be good to go.
In general, all fixes which apply to maintained branches and have a low potential of causing regressions should be backported.
Sure, but that's just what the list in D10816 looked like. Anyway, this probably needs more discussion in Plasma and KDE Apps in general on where to draw the line wrt. wayland opt-in. Nothing for this patch…
Happy to change course here if you can come up with good reasons, but so far I don't see why we should not run with wayland when running on Wayland.
I don't think the code should contain custom handling of environment variables in the long run, it should just use KWindowSystem. Please add a comment so this can be removed again in the future.
Merge the two conditions
What about the Plasma/5.8 and Plasma/5.12 branches?
That it doesn't work with -platform is intentional - spectacle uses the xcb platform plugin in wayland sessions now.
The wayland grabber uses DBus, so it works fine even without a wayland connection.
I could change the diff to check for KWindowSystem::isPlatformWayland() || qstrcmp(qgetenv("XDG_SESSION_TYPE"), "wayland") == 0 instead, though.
Mar 24 2018
XDG_SESSION_TYPE is not set if you run startplasmacompositor from a tty - so should this also check for WAYLAND_DISPLAY or startplasmacompositor set XDG_SESSION_TYPE=wayland?
I'm not sure whether that's set if you run dbus-launch startplasmacompositor from a tty.
Mar 23 2018
Sorry that you had to wait so long - it seems there's no active maintainer for this.
Split mouse.xy stuff into separate patch.
Mar 22 2018
Looking at the WAYLAND_DEBUG output I think I'm closer to understanding the issue now.
Now for real. Please arc, cooperate.
Split into https://phabricator.kde.org/D11586