fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (112 w, 2 d)
Availability
Available

Recent Activity

Yesterday

fvogt accepted D14209: Listen for player "emptied" signal.

Didn't test myself, but LGTM

Wed, Jul 18, 3:06 PM · Plasma
fvogt added a comment to D14209: Listen for player "emptied" signal.

If the extension translates "emptied" to "stopped", wouldn't it be compatible with older hosts?

Wed, Jul 18, 2:58 PM · Plasma
fvogt added a comment to D7581: HiDPI Support for Gwenview.

Any news here? 18.08 is very close, maybe even too late...

Wed, Jul 18, 9:36 AM

Tue, Jul 10

fvogt added inline comments to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.
Tue, Jul 10, 2:39 PM · Plasma
fvogt added a comment to D13776: Move remaining salt file operations into unprivileged processes.

Are you saying that there are files that root can't read but the user can?

Exactly.

This is really interesting and shows how little i know about stuff, can you point me to some info about when/how this happens?

Tue, Jul 10, 6:44 AM · Plasma

Mon, Jul 9

fvogt added a comment to D13776: Move remaining salt file operations into unprivileged processes.

Are you saying that there are files that root can't read but the user can?

Mon, Jul 9, 3:04 PM · Plasma

Fri, Jul 6

fvogt accepted D13920: [Font Management KCM] Only show on xcb platform.
Fri, Jul 6, 9:46 AM · Plasma

Thu, Jun 28

fvogt added inline comments to D11828: Simplify orPostingIterator and make it faster.
Thu, Jun 28, 5:28 PM · Baloo, Frameworks
fvogt updated the test plan for D13776: Move remaining salt file operations into unprivileged processes.
Thu, Jun 28, 12:02 PM · Plasma
fvogt updated the diff for D13776: Move remaining salt file operations into unprivileged processes.

Fix rebase error

Thu, Jun 28, 11:26 AM · Plasma
fvogt updated the summary of D13776: Move remaining salt file operations into unprivileged processes.
Thu, Jun 28, 11:25 AM · Plasma
fvogt updated the diff for D13776: Move remaining salt file operations into unprivileged processes.

Rebase on master - this only makes sense with the user privileges salt file reading.

Thu, Jun 28, 11:24 AM · Plasma
fvogt requested review of D13776: Move remaining salt file operations into unprivileged processes.
Thu, Jun 28, 7:52 AM · Plasma

Wed, Jun 27

fvogt added a comment to D13752: Build solidautoeject only on FreeBSD.

Umount on eject press still works even without the kded module loaded.

Wed, Jun 27, 9:28 AM · Plasma

Fri, Jun 22

fvogt committed R106:176fb89d409f: Merge branch 'Plasma/5.13' (authored by fvogt).
Merge branch 'Plasma/5.13'
Fri, Jun 22, 8:56 AM
fvogt committed R106:d8b417594781: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.13
Fri, Jun 22, 8:55 AM
fvogt committed R106:d0287c1dea39: Fix leak of pipe FDs in MD RAID code (authored by fvogt).
Fix leak of pipe FDs in MD RAID code
Fri, Jun 22, 8:54 AM
fvogt closed D13664: Fix leak of pipe FDs in MD RAID code.
Fri, Jun 22, 8:54 AM · Plasma

Thu, Jun 21

fvogt updated the test plan for D13664: Fix leak of pipe FDs in MD RAID code.
Thu, Jun 21, 7:53 PM · Plasma
fvogt updated the diff for D13664: Fix leak of pipe FDs in MD RAID code.

Remove cleanup again - it breaks stuff.

Thu, Jun 21, 6:22 PM · Plasma
fvogt updated the summary of D13664: Fix leak of pipe FDs in MD RAID code.
Thu, Jun 21, 5:10 PM · Plasma
fvogt updated the diff for D13664: Fix leak of pipe FDs in MD RAID code.

Comment got lost - readded.

Thu, Jun 21, 5:10 PM · Plasma
fvogt requested review of D13664: Fix leak of pipe FDs in MD RAID code.
Thu, Jun 21, 5:07 PM · Plasma
fvogt committed R127:0e580ae9bdc5: Do not cancel old clipboard selection if it is same as the new one. (authored by michalsrb).
Do not cancel old clipboard selection if it is same as the new one.
Thu, Jun 21, 2:42 PM
fvogt closed D13535: Do not cancel old clipboard selection if it is same as the new one..
Thu, Jun 21, 2:42 PM · Frameworks

Wed, Jun 20

fvogt accepted D13628: Make content-script media player code follow user settings.
Wed, Jun 20, 12:28 PM · Plasma
fvogt added inline comments to D13628: Make content-script media player code follow user settings.
Wed, Jun 20, 11:42 AM · Plasma
fvogt added a comment to D13628: Make content-script media player code follow user settings.

Does it make sense to enable mprisMediaSessions without mpris? As I don't think that is the case, can you make that visible in the UI and change if (items.mprisMediaSessions.enabled) { to if (items.mpris.enabled && items.mprisMediaSessions.enabled) {

Wed, Jun 20, 11:42 AM · Plasma
fvogt requested changes to D13619: Inject script on relevant video nodes not top of DOM.

I don't think this is a good idea - if no player exists, it'll either fail silently or throw an exception on the "element.parentNode" access.

Wed, Jun 20, 7:54 AM · Plasma

Jun 19 2018

fvogt accepted D11616: Openssl fix deprecation warnings.
Jun 19 2018, 9:25 AM
fvogt accepted D13599: Ref KConfig whilst we're using it.
Jun 19 2018, 8:08 AM · Plasma
fvogt added a comment to D13586: Ref KConfig whilst we're using it.

Your shared pointer still goes out of scope, the group's handle to the kconfig object is still the same.

Jun 19 2018, 8:06 AM · Plasma

Jun 18 2018

fvogt updated the diff for D13535: Do not cancel old clipboard selection if it is same as the new one..
  • Add unittest.
Jun 18 2018, 6:38 PM · Frameworks
fvogt added a comment to D13586: Ref KConfig whilst we're using it.

Could this have any relationship to https://bugs.kde.org/show_bug.cgi?id=395401?

Jun 18 2018, 1:36 PM · Plasma
fvogt added a comment to D13586: Ref KConfig whilst we're using it.

I guess KSharedConfig would work as well, that way the KConfig keeps a reference alive.

Jun 18 2018, 12:25 PM · Plasma
fvogt added a comment to D13360: Touchpad KDED module: Convert to JSON metadata.

This doesn't seem to be in Plasma/5.13.

Jun 18 2018, 6:44 AM · Plasma

Jun 14 2018

fvogt added a comment to D13535: Do not cancel old clipboard selection if it is same as the new one..

Yes, a unit test makes sense. I tried to add

Jun 14 2018, 5:25 PM · Frameworks
fvogt requested review of D13535: Do not cancel old clipboard selection if it is same as the new one..
Jun 14 2018, 12:43 PM · Frameworks

Jun 13 2018

fvogt added a comment to D13382: [RFC] Half pixel correction.
In D13382#277983, @zzag wrote:

Also, I have the impression that this patch changes the appearance of windows just slightly, fonts appear sharper. Is that actually possible or is it just a placebo?

Are you using subpixel rendering?

Jun 13 2018, 9:31 PM · KWin
fvogt added a comment to D13382: [RFC] Half pixel correction.

Hm. How does the linear filtering in combination with this patch cause the blurryness?

Jun 13 2018, 5:40 PM · KWin

Jun 12 2018

fvogt added a comment to D9070: KDE platform plugin: don't force default stylename on user-specified fonts.
In D9070#277428, @bkchr wrote:

Hi,
this patch is still no applied, would someone do it? :)
Because it already missed 5.13.

Jun 12 2018, 4:45 PM · Plasma
fvogt committed R135:2e971be576d2: KDE platform plugin: don't force default stylename on user-specified fonts (authored by rjvbb).
KDE platform plugin: don't force default stylename on user-specified fonts
Jun 12 2018, 4:45 PM
fvogt closed D9070: KDE platform plugin: don't force default stylename on user-specified fonts.
Jun 12 2018, 4:45 PM · Plasma

Jun 10 2018

fvogt added a comment to D13461: [effects] Add Scale effect.

IMO it would be more user friendly to have the values in the configuration dialog displayed as inverted percentage values. That way 0% means disabled and 100% is the maximum.

Jun 10 2018, 11:52 AM · KWin

Jun 8 2018

fvogt committed R101:f798dc1dd8b5: Merge branch 'Plasma/5.13' (authored by fvogt).
Merge branch 'Plasma/5.13'
Jun 8 2018, 7:26 PM
fvogt committed R101:d204426ce3e3: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.13
Jun 8 2018, 7:25 PM
fvogt committed R101:c5743089667d: Remove verbose debugging statement (authored by fvogt).
Remove verbose debugging statement
Jun 8 2018, 7:24 PM
fvogt closed D13435: Remove verbose debugging statement.
Jun 8 2018, 7:24 PM · Plasma
fvogt requested review of D13435: Remove verbose debugging statement.
Jun 8 2018, 7:13 PM · Plasma
fvogt added a comment to D13382: [RFC] Half pixel correction.

@zzag: I meant putting it into the description - I already know what this is about :D

Jun 8 2018, 9:44 AM · KWin

Jun 6 2018

fvogt added a comment to D13382: [RFC] Half pixel correction.

Maybe you could add an explanation of what the HPC actually does and why it only affects OpenGL?

Jun 6 2018, 4:49 PM · KWin
fvogt accepted D13378: Handle when the added node itself is audio/video.
Jun 6 2018, 11:21 AM · Plasma
fvogt requested changes to D13378: Handle when the added node itself is audio/video.
Jun 6 2018, 10:02 AM · Plasma
fvogt added a comment to D13378: Handle when the added node itself is audio/video.

I expected that querySelectorAll also looks at the element itself, apparently that's not the case...

Jun 6 2018, 10:01 AM · Plasma
fvogt committed R127:46f333a06508: Fixup @since for skip switcher API (authored by fvogt).
Fixup @since for skip switcher API
Jun 6 2018, 7:15 AM
fvogt closed D13377: Fixup @since for skip switcher API.
Jun 6 2018, 7:15 AM · Frameworks
fvogt requested review of D13377: Fixup @since for skip switcher API.
Jun 6 2018, 7:12 AM · Frameworks

Jun 5 2018

fvogt committed R119:b89618d85dde: Merge branch 'Plasma/5.13' (authored by fvogt).
Merge branch 'Plasma/5.13'
Jun 5 2018, 3:03 PM
fvogt committed R119:3085a40378c3: Fix the icons KCM (authored by fvogt).
Fix the icons KCM
Jun 5 2018, 3:02 PM
fvogt closed D13288: Fix the icons KCM.
Jun 5 2018, 3:02 PM · Plasma
fvogt accepted D13326: Hide settings when run on non-supported platform.
Jun 5 2018, 12:11 PM · Plasma

Jun 4 2018

fvogt committed R242:d15f0fa8322d: Use QDateTime for interfacing with QML (authored by fvogt).
Use QDateTime for interfacing with QML
Jun 4 2018, 8:36 AM
fvogt closed D13222: Use QDateTime for interfacing with QML.
Jun 4 2018, 8:36 AM · Frameworks
fvogt added a comment to D13222: Use QDateTime for interfacing with QML.

If the behavior changed in Qt 5.11, does the new code need a Qt version check, or is the patch backwards-compatible with earlier Qt versions?

Jun 4 2018, 6:43 AM · Frameworks

Jun 2 2018

fvogt added a comment to D13288: Fix the icons KCM.

I didn't actually test this change as-is, I renamed the directory on-disk instead. Should have the same effect though.

Jun 2 2018, 5:18 PM · Plasma
fvogt requested review of D13288: Fix the icons KCM.
Jun 2 2018, 5:17 PM · Plasma

May 30 2018

fvogt requested review of D13222: Use QDateTime for interfacing with QML.
May 30 2018, 7:29 PM · Frameworks
fvogt added a comment to D13128: Make sure ungrab keyboard request is processed before emitting shortcut.

@sontolbonggol Do you have access for pushing this or do you want someone else to do it?

May 30 2018, 1:21 PM · Frameworks

May 24 2018

fvogt added a comment to T8802: New dependency for kpat (required for CI).

@cgiboudeaux : please see the patch in this commit - https://github.com/shlomif/fc-solve/commit/9a2917edf0d13bbefef82a39b896ef14f62da876 - i was aware of these warnings, but ignored them because the fix made performance suffer a little.

May 24 2018, 11:20 AM · build.kde.org

May 23 2018

fvogt added a comment to D13056: Install mozilla native messaging manifest to either /usr/lib or /usr/lib64 based on architecture.

This would work for openSUSE as well (currently we do a manual mv in our .spec file), but I think it might break Debian and Debian-based.

May 23 2018, 8:24 AM · Plasma
fvogt accepted D13013: Small fixes for execute_kwallet.
May 23 2018, 6:47 AM · Plasma

May 22 2018

fvogt committed R856:0db2416dc351: Handle children of added nodes as well (authored by fvogt).
Handle children of added nodes as well
May 22 2018, 7:57 AM
fvogt closed D13001: Handle children of added nodes as well.
May 22 2018, 7:57 AM · Plasma

May 21 2018

fvogt added a comment to D13001: Handle children of added nodes as well.

What's the easiest way to test this? I might just patch the package and see what happens.

May 21 2018, 7:49 PM · Plasma
fvogt updated the diff for D13001: Handle children of added nodes as well.

We've officially arrived in callback hell.

May 21 2018, 7:47 PM · Plasma
fvogt added a comment to D13013: Small fixes for execute_kwallet.

fullSocket was malloc'd by the parent process. free()-ing it is pointless.

May 21 2018, 11:44 AM · Plasma
fvogt accepted D13013: Small fixes for execute_kwallet.
May 21 2018, 11:31 AM · Plasma
fvogt accepted D12991: Ensure the salt file is indeed a regular file.
May 21 2018, 8:47 AM · Plasma

May 20 2018

fvogt added a comment to D12996: Register players when tab becomes audible.

Fixed: https://phabricator.kde.org/D13001

May 20 2018, 2:12 PM · Plasma
fvogt requested review of D13001: Handle children of added nodes as well.
May 20 2018, 2:11 PM · Plasma
fvogt added a comment to D12996: Register players when tab becomes audible.

I don't fully understand why neither createElement nor the mutation observer detect it, though.

May 20 2018, 12:24 PM · Plasma
fvogt requested changes to D12991: Ensure the salt file is indeed a regular file.
May 20 2018, 11:27 AM · Plasma

May 16 2018

fvogt accepted D12909: Don't create salt file if user home directory does not exist.
May 16 2018, 6:03 PM · Plasma
fvogt requested changes to D12909: Don't create salt file if user home directory does not exist.
May 16 2018, 11:42 AM · Plasma
fvogt resigned from D12761: Allow building kio-nfs against standalone libtirpc.

IIRC @cgiboudeaux wrote this exact patch for kio-nfs from KDE 4 as well, but we opted to disable support downstream instead.

May 16 2018, 7:05 AM

May 10 2018

fvogt committed R623:1281d39a0fba: Use \n instead of <br> for the extra part of the summary (authored by fvogt).
Use \n instead of <br> for the extra part of the summary
May 10 2018, 9:37 AM
fvogt closed D12790: Use \n instead of <br> for the extra part of the summary.
May 10 2018, 9:37 AM

May 9 2018

fvogt requested review of D12790: Use \n instead of <br> for the extra part of the summary.
May 9 2018, 8:33 PM

May 2 2018

fvogt added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

The good:

In one setup I was pleasantly surpised at how well it worked. Fonts did behave as expected.
Specatcle was able to capture all screens and individual rects correctly.

The less good:

When I switched round the primary monitor all through the GUI and rebooting I had a right mess. The @1x screen fonts were double the size, the @2x screen were 4x the size.
In this setup spectacle had an issue with "current screen" when it was on the non primary. I assume this problem: https://bugreports.qt.io/browse/QTBUG-64992 .

May 2 2018, 9:04 PM · Plasma
fvogt updated the diff for D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

Fix build

May 2 2018, 8:33 PM · Plasma
fvogt added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

As for this patch. It needs Qt patches, so it's definitely not 5.13, possibly not even 5.14 material.

After 5.13.0 I'm willing to give this a fair test.
If it indeed does work great, cool.

May 2 2018, 12:49 PM · Plasma
fvogt added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

It is, for things that aren't Qt

May 2 2018, 12:41 PM · Plasma
fvogt added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.

-1 from here as well, it won't and it can't work reliably, it would be pretty much a false promise

May 2 2018, 12:31 PM · Plasma

Apr 26 2018

fvogt committed R120:d825967c00f6: Merge branch 'Plasma/5.12' (authored by fvogt).
Merge branch 'Plasma/5.12'
Apr 26 2018, 12:44 PM
fvogt committed R120:145654902663: sddm-theme: Focus the password field if enter pressed in the username field (authored by fvogt).
sddm-theme: Focus the password field if enter pressed in the username field
Apr 26 2018, 12:42 PM
fvogt closed D12510: sddm-theme: Focus the password field if enter pressed in the username field.
Apr 26 2018, 12:42 PM · Plasma

Apr 25 2018

fvogt added a comment to D12513: CVE-2018-10361: privilege escalation.

There's a typo in the title, it should be "privilege escalation".

Apr 25 2018, 11:00 AM · Frameworks, Kate
fvogt added a comment to D10404: Close the plasmoid after updates got installed.

I just noticed I never landed this - fixed now.

Apr 25 2018, 7:11 AM
fvogt committed R623:f7aef3bb8d7e: Close the plasmoid after updates got installed (authored by fvogt).
Close the plasmoid after updates got installed
Apr 25 2018, 7:10 AM
fvogt closed D10404: Close the plasmoid after updates got installed.
Apr 25 2018, 7:10 AM