- User Since
- May 24 2016, 11:24 AM (159 w, 5 d)
Fri, Jun 14
Remove whitespace change. Will land on Monday if no objections.
Thu, Jun 13
Indeed unused, but I wonder whether doing it explicitly in D21113 is prettier...
Tue, Jun 11
Untested, but looks good. Seems to apply to Plasma/5.12 as well.
Mon, Jun 10
Sat, Jun 8
Fri, Jun 7
Thu, Jun 6
New algorithm with no delay if not necessary.
Wed, Jun 5
Code duplication is better than polluting the API.
Wed, May 29
Tue, May 28
Mon, May 27
Couldn't find anything wrong, but I'm currently missing the overview of all MPRIS stuff in here to actually review properly...
browser.runtime.sendMessage does not seem to have a callback parameter.
Wed, May 22
IMO some of the slots taking a QString/QStringList instead of their QUrl counterpart should have a comment why this is the case.
From a first glance a method isUrlOpen(QString) looks weird, but with a comment that would be come clearer.
Tue, May 21
Yes, but the workaround here has no actual downsides, and the upside is avoiding a guaranteed crash with the still latest non-development release of Qt.
It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.
Tested on top of the 5.16 beta, works fine. Please add a comment referencing the QTBUG though, so that this doesn't get reintroduced by accident.
May 16 2019
May 15 2019
May 8 2019
May 7 2019
May 2 2019
Version 1.0.1 is part of Tumbleweed, just zypper in 'cmake(KF5PulseAudioQt)' or pulseaudio-qt-devel.
Apr 30 2019
What about Plasma/5.12 and Plasma/5.15?
Apr 26 2019
Apr 25 2019
I'm not sure why this is necessary - during new Audio the created object can't play anything by itself as src is not set.
If just doing createdAudio.paused = false after the removeChild is not enough, is that because the DOM modifications are queued and executed after the audio started playing?
The RPM as well (luckily, that would've been a mess otherwise)
Apr 23 2019
Apr 22 2019
Apr 18 2019
Use auto (which might actually make it build)
Apr 16 2019
No idea about CSS - as this commit is about breaking the style for most cases though it's probably fine.
Apr 15 2019
I see an opportunity for code decuplication here... Not sure how though - maybe
Apr 13 2019
Code still looks good to me - I can't comment on the cmake parts though.
Apr 9 2019
Sounds good enough to me, let's get this in so openQA won't complain anymore
It was actually discovered by openQA as a regression introduced yesterday: https://openqa.opensuse.org/tests/902646#step/finish_desktop/8 (bad) vs https://openqa.opensuse.org/tests/902110#step/finish_desktop/2 (good)
Probably a side effect of the label width change(s).
Apr 8 2019
Apr 7 2019
Apr 6 2019
Looking good to me, @bruns: any addiitonal comments?
Looks good to me otherwise.
Apr 5 2019
So libressl's API is mostly openssl < 1.1 with some 1.1 functions sprinkled in? That's annoying.
It might be easier to adjust the check for OSSL_110 to not set it with libressl.
Can you reupload this diff with context?
Apr 2 2019
Additionally, the bytesReceived > totalAmount case is currently not handled at all, but I'm not sure whether that's something for KJob or here.
Adding security team so we can have a second set of eyes on the helper, i couldn't find anything obviously wrong, but you know how auth helpers are :)
Apr 1 2019
I'm very much in favor of this, but don't know anything about the cmake magic involved, so can't really say much about that.