- User Since
- May 24 2016, 11:24 AM (151 w, 3 d)
Use auto (which might actually make it build)
Tue, Apr 16
No idea about CSS - as this commit is about breaking the style for most cases though it's probably fine.
Mon, Apr 15
I see an opportunity for code decuplication here... Not sure how though - maybe
Sat, Apr 13
Code still looks good to me - I can't comment on the cmake parts though.
Tue, Apr 9
Sounds good enough to me, let's get this in so openQA won't complain anymore
It was actually discovered by openQA as a regression introduced yesterday: https://openqa.opensuse.org/tests/902646#step/finish_desktop/8 (bad) vs https://openqa.opensuse.org/tests/902110#step/finish_desktop/2 (good)
Probably a side effect of the label width change(s).
Mon, Apr 8
Sun, Apr 7
Sat, Apr 6
Looking good to me, @bruns: any addiitonal comments?
Looks good to me otherwise.
Fri, Apr 5
So libressl's API is mostly openssl < 1.1 with some 1.1 functions sprinkled in? That's annoying.
It might be easier to adjust the check for OSSL_110 to not set it with libressl.
Can you reupload this diff with context?
Tue, Apr 2
Additionally, the bytesReceived > totalAmount case is currently not handled at all, but I'm not sure whether that's something for KJob or here.
Adding security team so we can have a second set of eyes on the helper, i couldn't find anything obviously wrong, but you know how auth helpers are :)
Mon, Apr 1
I'm very much in favor of this, but don't know anything about the cmake magic involved, so can't really say much about that.
Sun, Mar 31
Sun, Mar 24
Mar 19 2019
Is anyone able to review this? If there's no review in 24h I'll merge it as it affects users severely and the fix is trivial.
Mar 18 2019
There's a special case in ./src/desktoptheme/breeze/icons/audio.svgz and .../battery.svgz: It has color scheme definitions both in a <style id="current-color-scheme" type="text/css"> and a <style type="text/css" id="style5"> element.
It shouldn't have an impact on this bug in particular, but it does still look wrong.
One more file.
Mar 17 2019
Keep the style element, but assign id and type. Fix tooltip.svgz as well.
Mar 16 2019
@feverfew Sure! I don't know much about GSoC though, I hope that's not an issue.
LGTM to me as well - I'm not familiar with this code at all though.
Mar 12 2019
Feb 27 2019
Feb 21 2019
Feb 19 2019
Feb 17 2019
Feb 15 2019
Can you add context to this diff by either using arc or git diff with more context?
Feb 9 2019
I can confirm that it fixes all border display issues that I encountered in the released version.
Feb 8 2019
Feb 7 2019
Feb 6 2019
Feb 5 2019
Landed (phab didn't notice): https://cgit.kde.org/kdeclarative.git/commit/?id=856672f370fb32c7a3c3d1a13d873fb8b767d0e8
@trmdi: Do you have push access? If not, which name <mail> should be used for the commit?
The second change fvogt mentioned is IMHO handled quite strangely here - !m_enabled || m_temporaryInhibition is the inverse of !m_enabled || m_temporaryInhibition, so doing a event->ignore() === event->setAccepted(false) prior to the first return statement would cover the ignored case, and allows the event to bubble up.
Feb 2 2019
Jan 31 2019
I tried to understand what this change does both by trying to reproduce the issue and reading Qt code.
Here the symptom was more drags not getting accepted at all than flipping back and forth, but this patch fixes that as well.
Jan 28 2019
Also bail out early if image data known broken.
(Unrelated to the overflow fixes, but nice to have)
Jan 26 2019
We've had Qt 5.12 packaged and available since the first alpha and started to build KDE software against the second alpha - would it be possible to do it similarly in the KDE CI?
Starting to build also against pre-release Qt would be helpful as currently KDE CI is lagging behind what rolling release distros actually ship and it might help preventing some issues.
Jan 25 2019
Not tested, but looks correct to me. (Famous last words?)
Replace XDG_RUNTIME_DIR, test still passes
Jan 21 2019
Jan 18 2019
This should probably land on Plasma/5.12 as well.
Add some style
Use a new bool instead.
Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old behavior.
Jan 17 2019
Tested with cmake 3.10.2, works.