- User Since
- May 24 2016, 11:24 AM (125 w, 4 d)
AFAICT Plasma/5.12 is affected as well, any reason this wasn't landed to 5.12?
Thu, Oct 18
Tue, Oct 9
I removed the RFC - I'm using this patch since I uploaded and haven't had any issues so far.
Mon, Oct 8
Sat, Oct 6
Thu, Oct 4
AFAICT this won't actually protect much - the open DBus socket is enough to execute arbitrary programs.
Tue, Oct 2
Mon, Oct 1
I'm not sure whether that's correct - a file with a duration of 1s still has a range of 1s.
LGTM. I just tried how the currentTime property in JS works, it actually behaves like MPRIS' seek does and does not ignore invalid values. That might need a check in SetPosition.
Seek has a different behaviour for position() + offset < 0 and position() + offset == m_length:
Mon, Sep 24
Sun, Sep 23
Sat, Sep 22
@svuorela accessmanagertest already tests whether the AMR works in general. Do you mean a test which ensures there is no performance regression?
Sep 19 2018
IMO it should just check for both and prefer qdbus-qt5 if available.
Sep 16 2018
Sep 15 2018
The bigger, the better (=faster).
The 0xFFFFFF limit in KIO itself is due to the protocol only having 24 bits for size AFAIK - KLocalSocket can handle more than that at once without copying.
I'm not sure where TransferJob is used actually. It worked fine with more than 14MiB as well.
Sep 14 2018
I'm against this - kwin_wayland should just pick the next available socket if wayland-0 is not available. That's also what Xorg does and is IMO the expected behaviour.
Sep 13 2018
Sep 12 2018
Use same value as kio-sftp
The empty "if" is kept for readability.
Avoid reallocation in slotData if removing m_offset frees enough space.
Save m_offset bytes in slotData as well.
Sep 11 2018
- Actually make it work
- Free memory if m_offset is half of the array size
- Bail out if maxSize < 0
Depending on how AccessManagerReply is used, it might be necessary to do m_data.remove(0, m_offset); m_offset = 0; if m_offset grows too large to not leak memory. Can a KIO expert answer this?
Sep 6 2018
This will likely not work with ACLs.
Sep 4 2018
I tried it - except for the not anymore disappearing icons I can't spot any difference.
Sep 2 2018
At the very least, this patch should have changed the label in the Confirmations tab from "Show previews for:" to "Show previews in the view for:", to fix the inconsistency Mark pointed out.
Sep 1 2018
Aug 31 2018
In openSUSE the lifecycle data is part of /etc/product.d/openSUSE.product (openSUSE-release package) which receives updates through the regular channel.
The zypp PK backend reads those files and using "get-distro-upgrades" a list of available update targets can be acquired:
With a few modification the patch is correct and necessary though.
Aug 29 2018
Landed as https://commits.kde.org/dolphin/1d943518ad2b7f6f26bbe05588134758ec424055.
Phab didn't close this revision, presumably because it's in "Needs Review" state.
Do the same for the information panel
Of course, that's the main and only point of this patch.
@broulik doesn't use tooltips himself - so I'll wait a day whether someone who does objects to this
Aug 28 2018
Aug 27 2018
I get the same result: This is not possible to achieve using Qt WebEngine. See upstream bug https://bugreports.qt.io/browse/QTBUG-46129
Aug 22 2018
Aug 20 2018
Quit kwalletd if option was selected.
Aug 17 2018
On neon it won't work as the kernel everything is built against (so the minimum API/ABI) is too old. You'll either have to hack around that by messing with include paths or use something more recent.
Aug 14 2018
A different approach of fixing this is to do something like
There are uses of QVariant in method parameters, so this is most likely affected by https://bugs.kde.org/show_bug.cgi?id=397338