- User Since
- May 24 2016, 11:24 AM (185 w, 2 d)
This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21
I'm wondering whether this might not actually break the "qtchooser" variant - if binaries are in a Qt version specific dir, the path to qdbus would no longer exist after a Qt update without a rebuild of spectacle.
Wed, Dec 11
the actual name of the command is qdbus-qt<version> in the distro's Qt
Tue, Dec 10
IMO this should be done in KIO, so that all users benefit.
Sat, Dec 7
The check for the prefix was added in bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc, while the control.flat one got added much earlier.
Wed, Dec 4
Tue, Dec 3
Mon, Dec 2
Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in the file, so I usually just see < for a HTML page
Sun, Dec 1
Unfortunately the kio-fuse -d output is incomplete, probably because Qt was too smart and logged to the journal instead...
It's visible that there are multiple processes reading the file, maybe thumbnailing is in progress?
Can you try with thumbnails in dolphin disabled?
Sat, Nov 30
That happens because the .desktop file sets X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb:
I wonder whether the job duplication can just be ignored like this or whether there has to be a "virtual" unique id instead to be able to address duplicated jobs as well.
When cancelling a duplicated job with this patch, are both gone or just one of them?
Fri, Nov 29
Mon, Nov 25
AFAICT this breaks if LIBDIR != "lib". systemd only looks in /usr/lib AFAICT, so hardcoding to $prefix/lib/systemd might be better.
IMO this should be addressed outside of PBI instead:
- If a captive portal is detected, call CheckConnectivity with a higher frequency (I've never had any issues with this, actually)
- Instead of opening networkcheck.kde.org in the browser when clicking the "Log In" button, open a page which just closes itself
Thu, Nov 21
This would work, but why not just emit Seeked(m_position) in setPosition?
Wed, Nov 20
Mon, Nov 18
I wonder whether this can actually happen, as that header is AFAICT added by the kernel and not from the network.
Fri, Nov 15
I wonder whether the getStatus handler could be cleaned up by removing the UNKNOWN value of portStatus and removing the default: case.
Thu, Nov 14
It doesn't seem to work here either, but adding the --print-reply argument helps for some reason.
Nov 6 2019
This got implemented in https://phabricator.kde.org/D22571, which is flawed (see the various comments there).
This way the code does what it's supposed to (even though it's flawed), so definitely an improvement.
Nov 5 2019
The libssh maintainer is likely reverting the change, so this should not be necessary.
Nov 4 2019
LGTM. This now ignores the return value of the xft.get* calls, but that seems to be useless anyway:
That seems like just the order of assignments is wrong and more logic isn't actually needed. What about something like this:
Nov 3 2019
Oct 30 2019
IMO this looks uglier than multiline C macros, but ok...
Oct 28 2019
Oct 25 2019
IMO it's a good thing to have KRunner as application in the menu anyway
Oct 22 2019
Is this not needed for <video/> as well?
Oct 18 2019
Note, the "-0" option is only available in GNU env, not in BSD /env... I can't think of a better way to fix this though other than implementing env ourselves in native code.
arc is a PoS
Oct 16 2019
Tried with old host, no observable change
Oct 15 2019
See https://phabricator.kde.org/D22210 for a discussion about this.
Oct 7 2019
Oct 2 2019
Oct 1 2019
Maybe get rid of the unrelated change?
Sep 30 2019
Sep 27 2019
Sep 26 2019
Unfortunately, this breaks public API and ABI by modifying KAuth::ActionReply.
Seems to work on FF ESR
AFAICT it doesn't reload the mpris state in the content-script immediately when settings change, can that be implemented?
Sep 25 2019
Seems to work here
Sep 24 2019
Seems a bit weird to merge it at the top-level instead of adding a new key, but it's unlikely to result in abuse.
Appears to work on ESR
Sep 23 2019
Probably needs some Firefox ESR 60 testing to see whether it can deal with the class stuff...
Sep 20 2019
Sep 19 2019
Sep 18 2019
Sep 16 2019
Sep 10 2019
libproxy does not link against Qt anymore, they use kreadconfig5 and friends to read the values. So using that should be safe.
Sep 9 2019
Tested, works, thanks!