- User Since
- May 24 2016, 11:24 AM (210 w, 2 d)
Mon, May 18
Sun, May 17
Landed to invent - hopefully correctly: https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec
Sat, May 16
Fri, May 8
For some reason I can't get the reminder to trigger.
Thu, May 7
Apr 28 2020
Didn't test myself, but apparently you did, so LGTM.
Apr 27 2020
Apr 24 2020
AFAICT (take with a grain of salt, I'm a JS n00b) this doesn't catch something like this:
FIXED-IN: 5.19.0 (or should we consider this a bugfix and land it on the stable branch?)
Apr 19 2020
Apr 18 2020
Repository R120 Plasma Workspace
Apr 17 2020
Proper fix with refactoring will take too long, let's take this for now.
Tested, works. I didn't even notice that it broke...
Apr 15 2020
Apr 13 2020
Just have to make sure not to add anything to DEFAULT_EXTENSION_SETTINGS.mpris.websiteSettings now. Previously that would've been ignored.
Apr 10 2020
Looks fragile, but I don't have a better idea either.
I guess spotify had unsave-eval, but not unsafe-inline, so this method just breaks different pages...
Apr 9 2020
I just tried this with google translate on FF ESR 68(.1.0 IIRC) and it worked, but there was an error about the content security policy having blocked an eval. The error is gone if the extension is disabled.
So this needs a test with spotify/nextcloud. Do you have any public URL?
I'm not sure about the // Firefox enforces Content-Security-Policy also for scripts injected by the content-script part, but I'm not sure how to test it.
Note: Remains to be tested on non-firefox and old firefox ESR.
D28709 conflicts/supersedes this now. window.Audio.prototype != Audio is a separate issue though, which might still need fixing.
Use full URL in comment
I can't find a better way to do this either...
So was the case handled by line 805 completely broken?
That sounds like a Qt bug, which fails to use the QT_SCREEN_SCALE_FACTORS value for pixmaps for some reason. Is it a multi-monitor setup? Can you open a new issue with details and a screenshot?
Apr 6 2020
For false positives the player would get added again by the playing event, which is not ideal, but as it doesn't require a reload it's IMO close enough.
If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again?
Apr 4 2020
Apr 3 2020
I assume there is a reason why MTPDevice::getDevice() has code for handling this very specific case, so I wouldn't just remove it without figuring out why: https://i.redd.it/hfnl7xo8yovy.gif
There is no such thing as an "invalid device" at that point anymore. There's only nullptr.
Mar 28 2020
Mar 5 2020
Do it differently, just like it's done below
The split arguments are already available as parts above, as used in the klauncher call AFAICT.
Mar 2 2020
Treat scripting as a feature instead
Currently processui/scripting.cpp has this:
Feb 27 2020
I need some input on how to express HAVE_QTWEBENGINEWIDGETS with this. Currently it would fail to build if Qt5WebEngineWidgets is installed but Qt5WebChannel isn't.
Feb 26 2020
Feb 25 2020
Feb 24 2020
Save the comments, this looks reasonable to me.
Feb 18 2020
Note that this behaviour of sddm is not in any release yet - only in git.
As there's no reason to clear the environment, wouldn't it be more useful if StartServiceJob would only allow adding/overwriting variables?
StartProcessJob does not need an option to set the environment at all AFAICT.
Feb 15 2020
Fixing some style issues
Address comments. Still works.
Feb 12 2020
Feb 4 2020
I'll land tomorrow if no objections.