fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (86 w, 6 d)
Availability
Available

Recent Activity

Today

fvogt added inline comments to D9998: Actually quit threads nicely.
Mon, Jan 22, 7:56 AM · Plasma
fvogt committed R161:ed092b96f7af: Actually quit threads nicely (authored by fvogt).
Actually quit threads nicely
Mon, Jan 22, 7:53 AM
fvogt closed D9998: Actually quit threads nicely.
Mon, Jan 22, 7:53 AM · Plasma

Yesterday

fvogt updated the diff for D9998: Actually quit threads nicely.

Add comments to explain the magic values

Sun, Jan 21, 10:58 AM · Plasma
fvogt added inline comments to D9998: Actually quit threads nicely.
Sun, Jan 21, 10:39 AM · Plasma

Sat, Jan 20

fvogt accepted D9072: make ksshaskpass work with git-lfs.

so you mean instead of a one line change fiddling with file descriptors is a better way ?
I don't think so.

And effectively I was told that passing a 0 pointer to kwallet is wrong.
https://mail.kde.org/pipermail/kde-frameworks-devel/2017-May/045085.html

Sat, Jan 20, 11:02 PM · Plasma
fvogt added a comment to D9998: Actually quit threads nicely.

If it's not running event loop why run is called?

Sat, Jan 20, 9:43 PM · Plasma
fvogt added a reviewer for D9998: Actually quit threads nicely: anthonyfieroni.
Sat, Jan 20, 9:27 PM · Plasma
fvogt added a comment to D9072: make ksshaskpass work with git-lfs.
In D9072#189303, @fvogt wrote:

Looks good to me, but I wonder whether

KWallet writes an error to stderr when a 0-winId is given to openWallet() which is received by git-lfs and aborts the operation.

should be fixed more in a more general way as well.

Like how ?

Sat, Jan 20, 4:29 PM · Plasma

Thu, Jan 18

fvogt added a comment to D9966: [KIO] Fix issues with sharing of file descriptor.

Thanks for the quick reaction!

Thu, Jan 18, 9:10 PM · Frameworks

Tue, Jan 16

fvogt committed R241:95f6e4929333: Fix overlap of the first item in KFilePlacesView (authored by fvogt).
Fix overlap of the first item in KFilePlacesView
Tue, Jan 16, 5:59 PM
fvogt closed D9863: Fix overlap of the first item in KFilePlacesView.
Tue, Jan 16, 5:59 PM · Frameworks

Mon, Jan 15

fvogt reopened D9844: Don't stat(/etc/localtime) between read() and write() copying files.

Reverted in master as this broke various important ioslaves, like desktop and trash.

Mon, Jan 15, 11:33 AM · Frameworks
fvogt added a reverting commit for R241:f7e00b40a6d3: Don't stat(/etc/localtime) between read() and write() copying files: R241:16b21e7223f5: Revert "Don't stat(/etc/localtime) between read() and write() copying files".
Mon, Jan 15, 11:33 AM
fvogt committed R241:16b21e7223f5: Revert "Don't stat(/etc/localtime) between read() and write() copying files" (authored by fvogt).
Revert "Don't stat(/etc/localtime) between read() and write() copying files"
Mon, Jan 15, 11:33 AM
fvogt committed R241:a1e242589792: Revert "Initialize nextTimeoutMsecs to 0" (authored by fvogt).
Revert "Initialize nextTimeoutMsecs to 0"
Mon, Jan 15, 11:33 AM
fvogt added a reverting commit for R241:017eb3f19fd3: Initialize nextTimeoutMsecs to 0: R241:a1e242589792: Revert "Initialize nextTimeoutMsecs to 0".
Mon, Jan 15, 11:33 AM
fvogt committed R111:f28072080b89: Add a per-process CPU usage graph shown in the process list (authored by fvogt).
Add a per-process CPU usage graph shown in the process list
Mon, Jan 15, 9:58 AM
fvogt closed D9689: Add a per-process CPU usage graph shown in the process list.
Mon, Jan 15, 9:58 AM · Plasma
fvogt committed R108:eb69e87288d3: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account (authored by fvogt).
Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account
Mon, Jan 15, 7:59 AM
fvogt closed D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account.

Fixed up the trailing whitespace in line 165 and landed: https://commits.kde.org/kwin/eb69e87288d37fdb13eca32ca807ed8279f912af

Mon, Jan 15, 7:58 AM · KWin

Sun, Jan 14

fvogt updated the diff for D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account.

Move the added functions from the class into the xkb.cpp's static scope.

Sun, Jan 14, 8:49 PM · KWin
Restricted Application edited projects for D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account, added: Plasma; removed KWin.

I wasn't aware of this secure_getenv functionality.

Sun, Jan 14, 8:45 PM · KWin
Restricted Application edited projects for D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account, added: Plasma; removed KWin.
Sun, Jan 14, 1:04 PM · KWin

Sat, Jan 13

fvogt committed R134:86ab5059134a: Fix source actions in the configuration (authored by fvogt).
Fix source actions in the configuration
Sat, Jan 13, 2:17 PM
fvogt closed D9845: Fix source actions in the configuration.
Sat, Jan 13, 2:17 PM · Plasma

Fri, Jan 12

fvogt updated the diff for D9689: Add a per-process CPU usage graph shown in the process list.

Declare PercentageHistoryEntry as Q_PRIMITIVE_TYPE

Fri, Jan 12, 9:18 AM · Plasma
fvogt committed R241:248941a0f4b4: Fix KFilePreviewGenerator::LayoutBlocker (authored by fvogt).
Fix KFilePreviewGenerator::LayoutBlocker
Fri, Jan 12, 8:55 AM
fvogt closed D9830: Fix KFilePreviewGenerator::LayoutBlocker.
Fri, Jan 12, 8:55 AM · Frameworks
fvogt added a comment to D9830: Fix KFilePreviewGenerator::LayoutBlocker.

I certainly hope QListView doesn't trigger a nested event loop, that would be horribly nasty and the cause for a million more problems.... (up to and including crashes when closing the view/window while this is happening). But I'm assuming this is just a supposition, and I'm strongly hoping it's unfounded ;-)

Fri, Jan 12, 8:54 AM · Frameworks
fvogt added a comment to D9830: Fix KFilePreviewGenerator::LayoutBlocker.

Nice investigation and fix! Do you happen to know the actual change in Qt which broke this? Wondering if it should 1) be mentioned in the commit log, 2) lead to an #if QT_VERSION.
But if it's just a supposition, then that's fine, don't spend a week tracking down the change in Qt :-)

Fri, Jan 12, 8:46 AM · Frameworks
fvogt committed R108:e302f87598de: Properly detect Gallium drivers with newer Mesa (authored by fvogt).
Properly detect Gallium drivers with newer Mesa
Fri, Jan 12, 8:05 AM
fvogt closed D9495: Properly detect Gallium drivers with newer Mesa.
Fri, Jan 12, 8:05 AM · Plasma

Thu, Jan 11

fvogt updated the summary of D9830: Fix KFilePreviewGenerator::LayoutBlocker.
Thu, Jan 11, 9:20 PM · Frameworks
fvogt added a comment to D9072: make ksshaskpass work with git-lfs.

Looks good to me, but I wonder whether

Thu, Jan 11, 11:02 AM · Plasma

Wed, Jan 10

fvogt committed R134:124dd510d5a4: Fix scrolling with keyboard (authored by fvogt).
Fix scrolling with keyboard
Wed, Jan 10, 7:25 PM
fvogt updated the diff for D9689: Add a per-process CPU usage graph shown in the process list.

Address review comments.

Wed, Jan 10, 6:03 PM · Plasma
fvogt committed R119:c9e036e24873: Support font/ttf and font/otf mimetypes in kfontinst (authored by fvogt).
Support font/ttf and font/otf mimetypes in kfontinst
Wed, Jan 10, 9:40 AM
fvogt closed D9738: Support font/ttf and font/otf mimetypes in kfontinst.
Wed, Jan 10, 9:40 AM · Plasma

Mon, Jan 8

fvogt added inline comments to D9738: Support font/ttf and font/otf mimetypes in kfontinst.
Mon, Jan 8, 6:36 PM · Plasma
fvogt added a comment to D9719: Initial per-screen rotation handling.
In D9719#187517, @fvogt wrote:

IIRC the screen indices are not in any defined order, so just a reboot might invalidate the configuration.

I assume this could be fixed fairly easily by just passing the QScreen's name instead of the index to the autoRotateTablet method.

As far as I understand, this also means switching ScreenSpace (and probably ScreenMap as a result) to using output names instead of screen index too (because autoRotateTablet now checks which output is currently mapped). Conversion between output name and screen index inside autoRotateTablet doesn't seem like a good idea since it's gonna make it un-testable?

Mon, Jan 8, 1:53 PM
fvogt updated the diff for D9689: Add a per-process CPU usage graph shown in the process list.

Rebase on current master. (Apparently my local master wasn't setup to follow origin...)

Mon, Jan 8, 12:39 PM · Plasma
fvogt retitled D9689: Add a per-process CPU usage graph shown in the process list from [WIP] Add a per-process CPU usage graph shown in the process list to Add a per-process CPU usage graph shown in the process list.
Mon, Jan 8, 9:46 AM · Plasma
fvogt updated the diff for D9689: Add a per-process CPU usage graph shown in the process list.

Address review comments.

Mon, Jan 8, 9:46 AM · Plasma
fvogt added a comment to D9719: Initial per-screen rotation handling.

IIRC the screen indices are not in any defined order, so just a reboot might invalidate the configuration.

Mon, Jan 8, 6:43 AM

Sat, Jan 6

fvogt updated the diff for D9689: Add a per-process CPU usage graph shown in the process list.

Forgot to save ProcessModel.cpp before git commit.

Sat, Jan 6, 3:02 PM · Plasma
fvogt updated the diff for D9689: Add a per-process CPU usage graph shown in the process list.

Instead of updating the last entry's timestamp if the value is the same, add a new
entry only if the latest entry has a certain age.
Otherwise, the interpolation results would look differently and processes had different
lengths of histroy graphs depending on the values, which looks odd.

Sat, Jan 6, 2:41 PM · Plasma
fvogt updated the diff for D9689: Add a per-process CPU usage graph shown in the process list.

Remove the history tail before appending the head to never exceed the reserved vector size

Sat, Jan 6, 1:11 AM · Plasma

Thu, Jan 4

fvogt committed R486:d58e20ee6520: Add support for OpenSSL 1.1.0 (authored by fvogt).
Add support for OpenSSL 1.1.0
Thu, Jan 4, 7:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Jan 4, 7:02 PM
fvogt committed R236:9a46dd5199ee: Fix crash in setMainWindow on wayland (authored by fvogt).
Fix crash in setMainWindow on wayland
Thu, Jan 4, 12:08 PM
fvogt closed D9593: Fix crash in setMainWindow on wayland.
Thu, Jan 4, 12:07 PM · Frameworks

Wed, Jan 3

fvogt added a comment to D9593: Fix crash in setMainWindow on wayland.

Ping? This should probably go into 5.42.

Wed, Jan 3, 6:02 PM · Frameworks

Tue, Jan 2

fvogt committed R530:17d5878d56da: Implement hotplugging on Xlib (authored by fvogt).
Implement hotplugging on Xlib
Tue, Jan 2, 7:11 PM
fvogt closed D9576: Implement hotplugging on Xlib.
Tue, Jan 2, 7:11 PM
fvogt added a comment to D9576: Implement hotplugging on Xlib.

It might even be possible to merge both x11eventnotifier "backends" into one x11eventnotifier.cpp that way,
depending on whether one big #ifdef is better or worse than multiple smaller #ifdef

Tue, Jan 2, 7:10 PM
fvogt added a comment to D9614: Tablet hotplug detection for xlib backend.

I did it slightly different in https://phabricator.kde.org/D9576 already.

Tue, Jan 2, 6:37 PM
fvogt committed R120:32932b44e6f0: Move calls depending on $DISPLAY from startplasmacompositor to startplasma (authored by fvogt).
Move calls depending on $DISPLAY from startplasmacompositor to startplasma
Tue, Jan 2, 5:06 PM
fvogt closed D9597: Move calls depending on $DISPLAY from startplasmacompositor to startplasma.
Tue, Jan 2, 5:06 PM · Plasma
fvogt updated the diff for D9597: Move calls depending on $DISPLAY from startplasmacompositor to startplasma.

I don't see any such calls in kwin_wayland before the session is started, but sure.

Tue, Jan 2, 1:27 PM · Plasma
fvogt committed R623:3203b654db93: List known updates on startup (authored by fvogt).
List known updates on startup
Tue, Jan 2, 12:09 PM
fvogt closed D9508: List known updates on startup.
Tue, Jan 2, 12:09 PM
fvogt committed R623:b372eae9c718: Show that the last check failed if no updates available (authored by fvogt).
Show that the last check failed if no updates available
Tue, Jan 2, 12:09 PM
fvogt committed R623:d9708fb7efea: Only save the last update timestep on success (authored by fvogt).
Only save the last update timestep on success
Tue, Jan 2, 12:08 PM
fvogt closed D9504: Show that the last check failed if no updates available.
Tue, Jan 2, 12:08 PM
fvogt closed D9503: Only save the last update timestep on success.
Tue, Jan 2, 12:08 PM

Sun, Dec 31

fvogt added inline comments to D9416: Add support for OpenSSL 1.1.0.
Sun, Dec 31, 1:59 PM
fvogt added inline comments to D9416: Add support for OpenSSL 1.1.0.
Sun, Dec 31, 12:00 PM
fvogt added a comment to D9416: Add support for OpenSSL 1.1.0.

If there's no reply until Wednesday, I'll land this as it'll be two weeks old by then.

Sun, Dec 31, 12:37 AM

Fri, Dec 29

fvogt committed R120:361ee31606fb: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB… (authored by fvogt).
startplasmacompositor: If available, query org.freedesktop.locale1 for XKB…
Fri, Dec 29, 5:47 PM
fvogt closed D9512: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB defaults.
Fri, Dec 29, 5:47 PM · Plasma

Thu, Dec 28

fvogt added a comment to D9512: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB defaults.
In D9512#183207, @fvogt wrote:

However, only KWin knows that the user didn't specify a custom layout, so just relaying the locale1 properties to kwin during autostart won't work.

Actually it's not only KWin knowing that. KWin just reads a kconfig, we can do the same in the script and thus do the dbus calls only if no config is set.

Thu, Dec 28, 12:01 PM · Plasma

Wed, Dec 27

fvogt added a comment to D9512: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB defaults.

This could also be done in kcminit phase 0, it's a bit later and can then be done with slightly more stuff in parallel - also it'd be C++ so you can at least send all 4 DBus requests before blocking on the first.

As long as you update both the DBus environment and the klaunch environment, everything else will then inherit it.
(kcms/input/main.cpp has an example of that)

Wed, Dec 27, 2:06 PM · Plasma
fvogt added a comment to D9512: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB defaults.

It's not really a fallback. It'll be used until the user specifies a keyboard layout manually in the configuration.

Wed, Dec 27, 1:03 PM · Plasma

Tue, Dec 26

fvogt created D9512: startplasmacompositor: If available, query org.freedesktop.locale1 for XKB defaults.
Tue, Dec 26, 9:10 PM · Plasma
fvogt added a comment to D9508: List known updates on startup.

Alternatively, if a possible notification on startup is unexpected, there could be a separate state for "not checked yet".

Tue, Dec 26, 3:19 PM
fvogt created D9508: List known updates on startup.
Tue, Dec 26, 3:12 PM

Mon, Dec 25

fvogt created D9504: Show that the last check failed if no updates available.
Mon, Dec 25, 5:15 PM
fvogt created D9503: Only save the last update timestep on success.
Mon, Dec 25, 5:13 PM
Restricted Application edited projects for D9495: Properly detect Gallium drivers with newer Mesa, added: KWin; removed Plasma.

I consider detecting for newer driver a feature.

That might make things more difficult for downstreams, however.

Yes, of course. That's an issue which has created problems for me for years. KWin releases and mesa releases are not synced. This results in KWin not having a chance to be tested against latest Mesa. Distros combine these things. Like here openSUSE apparently combines a two year old KWin with a new Mesa.

Mon, Dec 25, 11:08 AM · Plasma

Sun, Dec 24

fvogt added a comment to D9496: Fix greeter crashing with software rendering on wayland.

The kwinglutils.cpp in kscreenlocker are not a 1:1 copy from KWin. It has everything specific from KWin removed.

I think the best solution would be to take the same approach and "manually" cherry-pick the patch.

Sun, Dec 24, 1:51 PM · Plasma
fvogt committed R133:483e0a1492d7: Merge branch 'Plasma/5.11' (authored by fvogt).
Merge branch 'Plasma/5.11'
Sun, Dec 24, 1:50 PM
fvogt committed R133:9959ead329d1: Adjust kwinglplatform.cpp for Mesa renderer string changes (authored by fvogt).
Adjust kwinglplatform.cpp for Mesa renderer string changes
Sun, Dec 24, 1:49 PM
fvogt added a comment to D9496: Fix greeter crashing with software rendering on wayland.

I'm not sure what to do with the https://phabricator.kde.org/D9495 fixes for kscreenlocker.
Just copying over the files with the bug fixed won't work as it depends on XCB and libexpoxy now and needs to know whether it's running on EGL or GLX (KWin::NoOpenGLPlatformInterface should work, I guess).
Should I just "backport" the gallium fix into kwinglplatform.cpp for 5.11? What to do for master? Branching kwinglplatform.cpp here is probably not a good idea.

Sun, Dec 24, 12:47 PM · Plasma
fvogt committed R133:dcb8e89585ac: Merge branch 'Plasma/5.11' (authored by fvogt).
Merge branch 'Plasma/5.11'
Sun, Dec 24, 11:08 AM
fvogt committed R133:f6307641e51e: Fix greeter crashing with software rendering on wayland (authored by fvogt).
Fix greeter crashing with software rendering on wayland
Sun, Dec 24, 10:55 AM
fvogt closed D9496: Fix greeter crashing with software rendering on wayland.
Sun, Dec 24, 10:55 AM · Plasma
Restricted Application edited projects for D9495: Properly detect Gallium drivers with newer Mesa, added: KWin; removed Plasma.

Please in master and not 5.8

Sun, Dec 24, 10:49 AM · Plasma

Sat, Dec 23

fvogt updated the diff for D9496: Fix greeter crashing with software rendering on wayland.

Re-add blank line.

Sat, Dec 23, 10:49 PM · Plasma
fvogt added a dependency for D9496: Fix greeter crashing with software rendering on wayland: D9495: Properly detect Gallium drivers with newer Mesa.
Sat, Dec 23, 10:43 PM · Plasma
fvogt added a dependent revision for D9495: Properly detect Gallium drivers with newer Mesa: D9496: Fix greeter crashing with software rendering on wayland.
Sat, Dec 23, 10:43 PM · Plasma
fvogt added a comment to D9496: Fix greeter crashing with software rendering on wayland.

Also needs https://phabricator.kde.org/D9495 as llvmpipe/softpipe are not detected properly without.

Sat, Dec 23, 10:43 PM · Plasma
fvogt created D9496: Fix greeter crashing with software rendering on wayland.
Sat, Dec 23, 10:42 PM · Plasma
fvogt created D9495: Properly detect Gallium drivers with newer Mesa.
Sat, Dec 23, 10:33 PM · Plasma

Dec 23 2017

fvogt committed R733:2114c4d115a9: Merge branch 'Applications/17.12' (authored by fvogt).
Merge branch 'Applications/17.12'
Dec 23 2017, 12:10 PM
fvogt closed D9485: Send the correct hostname with the HELO/EHLO command.
Dec 23 2017, 12:09 PM · KDE PIM
fvogt committed R733:5199ed07428a: Send the correct hostname with the HELO/EHLO command (authored by fvogt).
Send the correct hostname with the HELO/EHLO command
Dec 23 2017, 12:09 PM
fvogt committed R733:ec2afd27c790: Fix duplicate authentication (authored by fvogt).
Fix duplicate authentication
Dec 23 2017, 12:09 PM
fvogt closed D9476: Fix duplicate authentication.
Dec 23 2017, 12:09 PM · KDE PIM

Dec 22 2017

fvogt added a dependency for D9485: Send the correct hostname with the HELO/EHLO command: D9476: Fix duplicate authentication.
Dec 22 2017, 10:24 PM · KDE PIM