- User Since
- May 24 2016, 11:24 AM (86 w, 6 d)
Add comments to explain the magic values
Sat, Jan 20
Thu, Jan 18
Thanks for the quick reaction!
Tue, Jan 16
Mon, Jan 15
Reverted in master as this broke various important ioslaves, like desktop and trash.
Fixed up the trailing whitespace in line 165 and landed: https://commits.kde.org/kwin/eb69e87288d37fdb13eca32ca807ed8279f912af
Sun, Jan 14
Move the added functions from the class into the xkb.cpp's static scope.
Sat, Jan 13
Fri, Jan 12
Declare PercentageHistoryEntry as Q_PRIMITIVE_TYPE
Thu, Jan 11
Looks good to me, but I wonder whether
Wed, Jan 10
Address review comments.
Mon, Jan 8
Rebase on current master. (Apparently my local master wasn't setup to follow origin...)
Address review comments.
IIRC the screen indices are not in any defined order, so just a reboot might invalidate the configuration.
Sat, Jan 6
Forgot to save ProcessModel.cpp before git commit.
Instead of updating the last entry's timestamp if the value is the same, add a new
entry only if the latest entry has a certain age.
Otherwise, the interpolation results would look differently and processes had different
lengths of histroy graphs depending on the values, which looks odd.
Remove the history tail before appending the head to never exceed the reserved vector size
Thu, Jan 4
Wed, Jan 3
Ping? This should probably go into 5.42.
Tue, Jan 2
It might even be possible to merge both x11eventnotifier "backends" into one x11eventnotifier.cpp that way,
depending on whether one big #ifdef is better or worse than multiple smaller #ifdef
I did it slightly different in https://phabricator.kde.org/D9576 already.
I don't see any such calls in kwin_wayland before the session is started, but sure.
Sun, Dec 31
If there's no reply until Wednesday, I'll land this as it'll be two weeks old by then.
Fri, Dec 29
Thu, Dec 28
Wed, Dec 27
It's not really a fallback. It'll be used until the user specifies a keyboard layout manually in the configuration.
Tue, Dec 26
Alternatively, if a possible notification on startup is unexpected, there could be a separate state for "not checked yet".
Mon, Dec 25
Sun, Dec 24
I'm not sure what to do with the https://phabricator.kde.org/D9495 fixes for kscreenlocker.
Just copying over the files with the bug fixed won't work as it depends on XCB and libexpoxy now and needs to know whether it's running on EGL or GLX (KWin::NoOpenGLPlatformInterface should work, I guess).
Should I just "backport" the gallium fix into kwinglplatform.cpp for 5.11? What to do for master? Branching kwinglplatform.cpp here is probably not a good idea.
Sat, Dec 23
Re-add blank line.
Also needs https://phabricator.kde.org/D9495 as llvmpipe/softpipe are not detected properly without.