fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (177 w, 4 d)
Availability
Available

Recent Activity

Yesterday

fvogt committed R120:be056099b179: Merge branch 'Plasma/5.17' (authored by fvogt).
Merge branch 'Plasma/5.17'
Fri, Oct 18, 12:40 PM
fvogt committed R120:595ab88bc2ee: Fix reading environment variables with newline (authored by fvogt).
Fix reading environment variables with newline
Fri, Oct 18, 12:39 PM
fvogt closed D24750: Fix reading environment variables with newline.
Fri, Oct 18, 12:39 PM · Plasma
D24750: Fix reading environment variables with newline now requires review to proceed.
Fri, Oct 18, 9:40 AM · Plasma
fvogt requested review of D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper.
Fri, Oct 18, 9:33 AM · Plasma
fvogt added a comment to D24750: Fix reading environment variables with newline.

Note, the "-0" option is only available in GNU env, not in BSD /env... I can't think of a better way to fix this though other than implementing env ourselves in native code.

Fri, Oct 18, 7:42 AM · Plasma
fvogt updated the diff for D24750: Fix reading environment variables with newline.

arc is a PoS

Fri, Oct 18, 7:38 AM · Plasma
fvogt requested review of D24750: Fix reading environment variables with newline.
Fri, Oct 18, 7:37 AM · Plasma

Wed, Oct 16

fvogt accepted D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.
Wed, Oct 16, 12:26 PM · Plasma
fvogt accepted D24693: Bail out early when setPluginLoaded would result in no change.
Wed, Oct 16, 11:38 AM · Plasma
fvogt accepted D24692: Show version information in about screen.

Tried with old host, no observable change

Wed, Oct 16, 11:36 AM · Plasma
fvogt committed R120:f82eb5b519fc: Merge branch 'Plasma/5.17' (authored by fvogt).
Merge branch 'Plasma/5.17'
Wed, Oct 16, 6:59 AM
fvogt committed R120:ff84a4e5662e: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0 (authored by fvogt).
[gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0
Wed, Oct 16, 6:58 AM
fvogt closed D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0.
Wed, Oct 16, 6:58 AM · Plasma

Tue, Oct 15

fvogt added a comment to D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0.

Since we watch the file, we will update it as neccessary once kconf_update has written it, right?

Tue, Oct 15, 5:03 PM · Plasma
fvogt updated the test plan for D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0.
Tue, Oct 15, 3:03 PM · Plasma
fvogt added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

I thought this change was introduced with 0.18.1 though? Aren't distros with an old SDDM using something older than that?

Tue, Oct 15, 2:58 PM · Plasma
fvogt added a comment to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

FWIW to me https://github.com/sddm/sddm/pull/997 seems correct, and then we would rename the sessions upstream here. My preference would be to make the Wayland session say "Plasma (Wayland)" rather than renaming the X11 session ("Plasma on Xorg" sounds pretty awkward IMO)

Tue, Oct 15, 2:51 PM · Plasma
fvogt added a comment to D24666: Be explicit about X11 or Wayland for the dev session names.

See https://phabricator.kde.org/D22210 for a discussion about this.

Tue, Oct 15, 2:24 PM · Plasma
fvogt committed R108:f4c6de8ec452: Merge branch 'Plasma/5.17' (authored by fvogt).
Merge branch 'Plasma/5.17'
Tue, Oct 15, 2:09 PM
fvogt committed R108:4982dfd5f5ec: glx: Don't use sRGB configs on llvmpipe with depth 16 (authored by fvogt).
glx: Don't use sRGB configs on llvmpipe with depth 16
Tue, Oct 15, 2:07 PM
fvogt closed D22203: glx: Don't use sRGB configs on llvmpipe with depth 16.
Tue, Oct 15, 2:07 PM · KWin
fvogt requested review of D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0.
Tue, Oct 15, 1:51 PM · Plasma

Mon, Oct 7

fvogt committed R120:0565c8e615e0: sddm-theme: Set needsFullUserModel=false (authored by fvogt).
sddm-theme: Set needsFullUserModel=false
Mon, Oct 7, 8:30 AM
fvogt closed D24333: sddm-theme: Set needsFullUserModel=false.
Mon, Oct 7, 8:30 AM · Plasma

Wed, Oct 2

fvogt added a comment to D24333: sddm-theme: Set needsFullUserModel=false.

I don't think I follow.

How does the regular non-textfield version of the login screen still work? Surely containsAllUsers will always be false.

Wed, Oct 2, 5:47 PM · Plasma

Tue, Oct 1

fvogt updated the diff for D24333: sddm-theme: Set needsFullUserModel=false.

Maybe now?

Tue, Oct 1, 8:46 AM · Plasma
fvogt updated the diff for D24333: sddm-theme: Set needsFullUserModel=false.

Maybe get rid of the unrelated change?

Tue, Oct 1, 8:38 AM · Plasma
fvogt requested review of D24333: sddm-theme: Set needsFullUserModel=false.
Tue, Oct 1, 8:37 AM · Plasma

Mon, Sep 30

fvogt added inline comments to D24194: Add per-origin media controls blacklist.
Mon, Sep 30, 3:11 PM · Plasma
fvogt added inline comments to D22571: Allow blacklisting some wayland interfaces.
Mon, Sep 30, 2:45 PM · KWin
fvogt requested changes to D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop.

drop translations, rename to 'Plasma on Xorg'

That would not be symmetric to "Plasma (Wayland)" though as produced by sddm.

Mon, Sep 30, 2:45 PM · Plasma

Fri, Sep 27

fvogt added inline comments to D24084: Migrate kwin animation speed to kdeglobals.
Fri, Sep 27, 9:43 AM · KWin
fvogt added inline comments to D24084: Migrate kwin animation speed to kdeglobals.
Fri, Sep 27, 7:57 AM · KWin
fvogt reopened D24084: Migrate kwin animation speed to kdeglobals.
Fri, Sep 27, 7:20 AM · KWin

Thu, Sep 26

fvogt requested changes to D24245: Add support for passing Unix file descriptors.

Unfortunately, this breaks public API and ABI by modifying KAuth::ActionReply.

Thu, Sep 26, 5:01 PM · Frameworks
fvogt accepted D24203: Add settings change listener.

Seems to work on FF ESR

Thu, Sep 26, 3:15 PM · Plasma
fvogt added a comment to D24194: Add per-origin media controls blacklist.

AFAICT it doesn't reload the mpris state in the content-script immediately when settings change, can that be implemented?

Thu, Sep 26, 2:19 PM · Plasma

Wed, Sep 25

fvogt added a comment to D24225: [Notifications] Add spacing after positioning popup for bottom panel.

Seems to work here

Wed, Sep 25, 3:07 PM · Plasma

Tue, Sep 24

fvogt added inline comments to D24191: Let plugin add additional status information.
Tue, Sep 24, 2:07 PM · Plasma
fvogt accepted D24191: Let plugin add additional status information.

Seems a bit weird to merge it at the top-level instead of adding a new key, but it's unlikely to result in abuse.

Tue, Sep 24, 2:06 PM · Plasma
fvogt accepted D24190: Let options page scroll.
Tue, Sep 24, 2:03 PM · Plasma
fvogt accepted D24165: Add SettingsUtil utility class.

Appears to work on ESR

Tue, Sep 24, 1:46 PM · Plasma

Mon, Sep 23

fvogt added a comment to D24165: Add SettingsUtil utility class.

Probably needs some Firefox ESR 60 testing to see whether it can deal with the class stuff...

Mon, Sep 23, 5:04 PM · Plasma

Fri, Sep 20

fvogt added a reviewer for D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid: Frameworks.
Fri, Sep 20, 6:02 PM · Frameworks

Sep 19 2019

fvogt added inline comments to D23117: [Look and feel] Add a way for LNF themes to manually specify a splash screen.
Sep 19 2019, 4:32 PM · Plasma

Sep 18 2019

fvogt added inline comments to D22571: Allow blacklisting some wayland interfaces.
Sep 18 2019, 2:36 PM · KWin

Sep 16 2019

fvogt committed R120:065a0fcfb035: Fix editing items in SimpleFavoritesModel (authored by fvogt).
Fix editing items in SimpleFavoritesModel
Sep 16 2019, 12:16 PM
fvogt accepted D23151: Implement Web Share API through Purpose.
Sep 16 2019, 8:24 AM · Plasma

Sep 10 2019

fvogt added a comment to T11530: Investigate removal of KIO's KPAC in favor of QNetworkProxy.

libproxy does not link against Qt anymore, they use kreadconfig5 and friends to read the values. So using that should be safe.

Sep 10 2019, 12:13 PM · KF6

Sep 9 2019

fvogt accepted D22203: glx: Don't use sRGB configs on llvmpipe with depth 16.

Tested, works, thanks!

Sep 9 2019, 9:44 AM · KWin

Sep 7 2019

fvogt accepted D23773: Observe title tag only if there actually is a player.
Sep 7 2019, 2:03 PM · Plasma
fvogt added inline comments to D23773: Observe title tag only if there actually is a player.
Sep 7 2019, 1:44 PM · Plasma
fvogt added inline comments to D23773: Observe title tag only if there actually is a player.
Sep 7 2019, 1:11 PM · Plasma
fvogt added inline comments to D23773: Observe title tag only if there actually is a player.
Sep 7 2019, 12:54 PM · Plasma

Sep 5 2019

fvogt accepted D23729: Add "freebsd" as supported platform key.
Sep 5 2019, 11:47 AM · Plasma

Sep 4 2019

fvogt accepted D23714: Manipulate Document prototype for createElement.

The same approach should probably be used for other overrides as well, like navigator.mediaSession.setActionHandler and window.Audio. That's unrelated to the bug though.

Sep 4 2019, 8:44 AM · Plasma

Sep 3 2019

fvogt accepted D23709: Add option to store download origin url in xattr.
Sep 3 2019, 6:00 PM · Plasma
fvogt accepted D23709: Add option to store download origin url in xattr.

LGTM, but maybe move into a separate method instead? There's already too much in DownloadJob::update...

Sep 3 2019, 4:49 PM · Plasma
fvogt accepted D23686: Allow a setting to declaratively depend on another one.

Works. I don't think the CSS indentation style works for data-depends-settings-value="FALSE" though, that would just be weird.

Sep 3 2019, 12:12 PM · Plasma
fvogt added a comment to D23694: Add support for sshfs to the fstab backend.

fuse.sshfs is used by kdeconnect as well, does that cause some kind of conflict?

Sep 3 2019, 11:48 AM · Frameworks

Sep 2 2019

fvogt committed R623:92675896ed9d: Add support for license prompts (authored by fvogt).
Add support for license prompts
Sep 2 2019, 2:10 PM
fvogt closed D23462: Add support for license prompts.
Sep 2 2019, 2:10 PM

Aug 29 2019

fvogt accepted D23568: Use custom event rather than window.postMessage.

Tested, works fine

Aug 29 2019, 5:04 PM · Plasma
fvogt added a comment to D23568: Use custom event rather than window.postMessage.

What we could also do which I just realized is that we could send a CustomEvent to the window instead of using postMessage
Basically what we did before except without a wrapper div as while the JavaScript contexts are different, events posted to window are visible from the content script.

Aug 29 2019, 4:48 PM · Plasma
fvogt added a comment to D23568: Use custom event rather than window.postMessage.

Always provide a specific targetOrigin, not *, if you know where the other window's document should be located. Failing to provide a specific target discloses the data you send to any interested malicious site.

Aug 29 2019, 3:20 PM · Plasma

Aug 28 2019

fvogt accepted D23518: Disable media controls and tabsrunner in Firefox again.

Accepting, but I REALLY don't like this as it makes the behaviour on firefox quite different compared to other browsers for no good reason.

Aug 28 2019, 8:51 AM · Plasma

Aug 26 2019

fvogt added reviewers for D23462: Add support for license prompts: bruns, antlarr.
Aug 26 2019, 3:07 PM
fvogt requested review of D23462: Add support for license prompts.
Aug 26 2019, 1:24 PM
fvogt committed R320:9e1221bb8b24: Merge branch 'Applications/19.08' (authored by fvogt).
Merge branch 'Applications/19.08'
Aug 26 2019, 9:19 AM
fvogt committed R320:8c42ec63200f: Fixing bug where MTP slave does not return error in stat()/mimetype() (authored by feverfew).
Fixing bug where MTP slave does not return error in stat()/mimetype()
Aug 26 2019, 9:18 AM
fvogt closed D23454: Fixing bug where MTP slave does not return error in stat()/mimetype().
Aug 26 2019, 9:18 AM · Frameworks, Dolphin

Aug 24 2019

fvogt committed R116:876b2c34fdd5: Fix build error caused by bad merge (authored by fvogt).
Fix build error caused by bad merge
Aug 24 2019, 6:10 PM

Aug 23 2019

fvogt accepted D23374: [Tabs Runner] Reply to all requests.
Aug 23 2019, 11:22 AM · Plasma

Aug 21 2019

fvogt committed R308:54e18b0d9b0d: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly (authored by fvogt).
Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly
Aug 21 2019, 11:58 AM
fvogt closed D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly.
Aug 21 2019, 11:58 AM · Frameworks

Aug 15 2019

fvogt requested changes to D23151: Implement Web Share API through Purpose.
Aug 15 2019, 2:49 PM · Plasma
fvogt requested changes to D23151: Implement Web Share API through Purpose.

AFAICT this won't work on wayland and will also break the browser's native implementation once that actually exists.

Aug 15 2019, 8:21 AM · Plasma

Aug 14 2019

fvogt accepted D21113: Allow hiding option items depending on available extension and version in the host.
Aug 14 2019, 9:02 AM · Plasma
fvogt added inline comments to D21113: Allow hiding option items depending on available extension and version in the host.
Aug 14 2019, 8:47 AM · Plasma

Aug 13 2019

fvogt accepted D23099: Allow sending a port message and receive a reply.
Aug 13 2019, 1:03 PM · Plasma
fvogt added inline comments to D23099: Allow sending a port message and receive a reply.
Aug 13 2019, 9:51 AM · Plasma
fvogt added inline comments to D23099: Allow sending a port message and receive a reply.
Aug 13 2019, 8:33 AM · Plasma
fvogt accepted D23122: Enable enhanced media controls by default.
Aug 13 2019, 7:58 AM · Plasma
fvogt accepted D23100: Let settings work with arbitrary input controls.

Didn't test, but looks good

Aug 13 2019, 7:27 AM · Plasma
fvogt requested changes to D22203: glx: Don't use sRGB configs on llvmpipe with depth 16.

From the bug report:

Aug 13 2019, 7:22 AM · KWin

Aug 12 2019

fvogt accepted D23090: Handle media session callbacks before passing it on to the browser.
Aug 12 2019, 8:18 PM · Plasma
fvogt added inline comments to D23100: Let settings work with arbitrary input controls.
Aug 12 2019, 8:17 PM · Plasma
fvogt added a comment to D23099: Allow sending a port message and receive a reply.

IMHO the member variable is really ugly. Messages with and without serial number have to be handled differently anyway, so why not introuce a new handleMessage(event, json, serial) method?

Aug 12 2019, 6:23 PM · Plasma
fvogt requested changes to D23100: Let settings work with arbitrary input controls.
Aug 12 2019, 5:36 PM · Plasma
fvogt added inline comments to D23100: Let settings work with arbitrary input controls.
Aug 12 2019, 5:36 PM · Plasma
fvogt accepted D23107: Slightly prettier debug.

TIL that exists

Aug 12 2019, 5:24 PM · Plasma
fvogt accepted D23091: Call media session callback with details.
Aug 12 2019, 5:21 PM · Plasma
fvogt added inline comments to D23090: Handle media session callbacks before passing it on to the browser.
Aug 12 2019, 5:16 PM · Plasma

Aug 10 2019

fvogt committed R123:2ce7ccd2dff8: Remove persistence from the kauth helper (authored by fvogt).
Remove persistence from the kauth helper
Aug 10 2019, 8:34 PM
fvogt closed D23078: Remove persistence from the kauth helper.
Aug 10 2019, 8:34 PM · Plasma
fvogt requested review of D23078: Remove persistence from the kauth helper.
Aug 10 2019, 8:23 PM · Plasma

Aug 8 2019

fvogt added inline comments to D23029: Fix the attica pkgconfig file..
Aug 8 2019, 12:18 PM · Frameworks
fvogt added a comment to D22979: Security: remove support for $(...) in config keys with [$e] marker..

Does anyone think this can be easily backported to previous versions of KDE in upstream distros such as Kubuntu, etc.?

Aug 8 2019, 5:31 AM · Frameworks

Aug 7 2019

fvogt added a comment to D22989: Security: remove support for $(...) in config keys with [$e] marker..

Built fine and Icon[$e]=$(kinfocenter) didn't work anymore as expected.

Aug 7 2019, 11:42 AM