fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (210 w, 2 d)
Availability
Available

Recent Activity

Mon, May 18

fvogt accepted D29691: Restore ability to send tel: URLs to the phone.
Mon, May 18, 9:33 AM · Plasma

Sun, May 17

fvogt added a comment to D29800: Fix URL being passed as argument when launching a .desktop file.

Landed to invent - hopefully correctly: https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec

Sun, May 17, 9:45 AM · Frameworks
fvogt committed R241:84e9372f4fa2: Fix URL being passed as argument when launching a .desktop file (authored by fvogt).
Fix URL being passed as argument when launching a .desktop file
Sun, May 17, 9:44 AM
fvogt closed D29800: Fix URL being passed as argument when launching a .desktop file.
Sun, May 17, 9:44 AM · Frameworks

Sat, May 16

fvogt requested review of D29800: Fix URL being passed as argument when launching a .desktop file.
Sat, May 16, 6:07 PM · Frameworks

Fri, May 8

fvogt requested changes to D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave.

For some reason I can't get the reminder to trigger.

Fri, May 8, 3:49 PM · Plasma
fvogt accepted D29393: Use player "poster" as album cover if available.
Fri, May 8, 7:14 AM · Plasma

Thu, May 7

fvogt added a comment to D29503: Pixel align children of GridViewInternal.

I can't reproduce it, but I wonder if this could fix or help https://bugs.kde.org/show_bug.cgi?id=417488?

Thu, May 7, 1:32 PM · Frameworks
fvogt committed R296:9725a21bcd0e: Pixel align children of GridViewInternal (authored by fvogt).
Pixel align children of GridViewInternal
Thu, May 7, 9:59 AM
fvogt closed D29503: Pixel align children of GridViewInternal.
Thu, May 7, 9:59 AM · Frameworks
fvogt requested review of D29503: Pixel align children of GridViewInternal.
Thu, May 7, 9:47 AM · Frameworks

Apr 28 2020

fvogt accepted D28926: Signal player gone in "pagehide" not "beforeunload".

Didn't test myself, but apparently you did, so LGTM.

Apr 28 2020, 1:17 PM · Plasma

Apr 27 2020

fvogt committed R134:6ef9094f6db1: Make it compile against qt5.15. SkipEmptyParts is part of Qt::. (authored by mlaurent).
Make it compile against qt5.15. SkipEmptyParts is part of Qt::.
Apr 27 2020, 11:56 AM

Apr 24 2020

fvogt added a comment to D28936: Use a Proxy object to detect changes within the MediaMetadata.

this doesn't catch something like this

Yeah it doesn't. I thought I could "monitor" an Object but the caller actually has to use the Proxy for it to detect anything :/

Any ideas? :)

Apr 24 2020, 1:51 PM · Plasma
fvogt added a comment to D28936: Use a Proxy object to detect changes within the MediaMetadata.

AFAICT (take with a grain of salt, I'm a JS n00b) this doesn't catch something like this:

Apr 24 2020, 1:43 PM · Plasma
fvogt added a comment to D28658: [krdb] Drop GTK2 colour exporting.

FIXED-IN: 5.19.0 (or should we consider this a bugfix and land it on the stable branch?)

Apr 24 2020, 1:24 PM · Plasma

Apr 19 2020

fvogt accepted D28965: Support Brave browser.
Apr 19 2020, 9:00 AM · Plasma

Apr 18 2020

fvogt accepted D28939: Don't offer sending non-http(s) links and sources via KDE Connect.

Repository R120 Plasma Workspace

Apr 18 2020, 11:32 AM · Plasma

Apr 17 2020

fvogt committed R120:a28e110cbb15: krunner: Prevent regression (authored by apol).
krunner: Prevent regression
Apr 17 2020, 11:59 AM
fvogt closed D28853: krunner: Prevent regression.
Apr 17 2020, 11:59 AM · Plasma
fvogt accepted D28853: krunner: Prevent regression.

Proper fix with refactoring will take too long, let's take this for now.

Apr 17 2020, 8:26 AM · Plasma
fvogt requested changes to D28889: Avoid crash in KWin::DrmOutput::updateCursor.
Apr 17 2020, 8:26 AM · KWin
fvogt accepted D28893: Detect Vivaldi based on binary name.

Tested, works. I didn't even notice that it broke...

Apr 17 2020, 6:33 AM · Plasma

Apr 15 2020

fvogt requested changes to D28856: Save disabling of desktop file components in kglobalshortcutsrc.
Apr 15 2020, 3:20 PM · Frameworks
fvogt added a comment to D24956: Consider desktop files with NoDisplay attribute.

[14:12] <d_ed> DavidRedondo1: my understanding is that a system might ship "konsole opens with control+t" . The UI allows you to remove that. This would remove the entry in kglobalshortcutsrc, but because it's still in the system defaults file as soon as you log in again it'll add it back

[14:25] <DavidRedondo1> d_ed, fvogt Apparently the runtime writes the hidden thing when a component is cleanedUp https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n135
[14:27] <DavidRedondo1> Does that fail or something when the file is not writeable?
[14:31] <DavidRedondo1> I think it fails
[14:31] <DavidRedondo1> I just tested it

if it is indeed broken...then we may as well just merge this.

Apr 15 2020, 2:49 PM · Frameworks
fvogt added a comment to D24956: Consider desktop files with NoDisplay attribute.

kglobalshortcutseditor.cpp
needs updating to match

I think you're right with your reasoning about NoDisplay, but we do want something to be able to mask system files. From the spec should we be checking Hidden= ?

Apr 15 2020, 12:48 PM · Frameworks
fvogt accepted D28707: Show purpose context menu only when enabled.
Apr 15 2020, 8:47 AM · Plasma

Apr 13 2020

fvogt accepted D28791: Manually merge stored and default settings.
Apr 13 2020, 1:06 PM · Plasma
fvogt accepted D28791: Manually merge stored and default settings.

Just have to make sure not to add anything to DEFAULT_EXTENSION_SETTINGS.mpris.websiteSettings now. Previously that would've been ignored.

Apr 13 2020, 12:54 PM · Plasma

Apr 10 2020

fvogt added a comment to D28709: Implement executeScript for Firefox.

I've originally injected breeze scroll bar CSS as style with src in the extension but that also cause other issues where websites weren't allowed to access the different origin of the style sheet...

Apr 10 2020, 12:02 PM · Plasma
fvogt accepted D28719: [Purpose Plugin] Detect cancelling the prompt more reliable.

Looks fragile, but I don't have a better idea either.

Apr 10 2020, 10:29 AM · Plasma
fvogt accepted D28705: Don't consider player gone when it only got temporarily added by us.

Yeah, wondering the same... maybe it didn't. Anyway this also fixes Spotify's previous/next buttons not working since when the player is gone we clear media session actions (not sure if that is someting we should do though)

Apr 10 2020, 10:23 AM · Plasma
fvogt abandoned D28709: Implement executeScript for Firefox.

I guess spotify had unsave-eval, but not unsafe-inline, so this method just breaks different pages...

Apr 10 2020, 10:05 AM · Plasma

Apr 9 2020

fvogt added a comment to D28709: Implement executeScript for Firefox.

I just tried this with google translate on FF ESR 68(.1.0 IIRC) and it worked, but there was an error about the content security policy having blocked an eval. The error is gone if the extension is disabled.
So this needs a test with spotify/nextcloud. Do you have any public URL?

Apr 9 2020, 9:21 PM · Plasma
fvogt added a comment to D28709: Implement executeScript for Firefox.

I'm not sure about the // Firefox enforces Content-Security-Policy also for scripts injected by the content-script part, but I'm not sure how to test it.

Apr 9 2020, 6:55 PM · Plasma
fvogt added a comment to D28709: Implement executeScript for Firefox.

Note: Remains to be tested on non-firefox and old firefox ESR.

Apr 9 2020, 6:52 PM · Plasma
fvogt added a comment to D28706: Restore old Audio prototype after exportFunction.

D28709 conflicts/supersedes this now. window.Audio.prototype != Audio is a separate issue though, which might still need fixing.

Apr 9 2020, 6:51 PM · Plasma
fvogt updated the diff for D28709: Implement executeScript for Firefox.

Use full URL in comment

Apr 9 2020, 6:50 PM · Plasma
fvogt requested review of D28709: Implement executeScript for Firefox.
Apr 9 2020, 6:48 PM · Plasma
fvogt accepted D28706: Restore old Audio prototype after exportFunction.

I can't find a better way to do this either...

Apr 9 2020, 6:23 PM · Plasma
fvogt added a comment to D28705: Don't consider player gone when it only got temporarily added by us.

It worked on Chrome, and the properties can be accessed from the same context.
It's just that the mutation.removedNodes loop above which is in content script cannot access those JS properties, so I had to change it, so it can.

Apr 9 2020, 5:42 PM · Plasma
fvogt added a comment to D28705: Don't consider player gone when it only got temporarily added by us.

So was the case handled by line 805 completely broken?

Apr 9 2020, 5:05 PM · Plasma
fvogt added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

That sounds like a Qt bug, which fails to use the QT_SCREEN_SCALE_FACTORS value for pixmaps for some reason. Is it a multi-monitor setup? Can you open a new issue with details and a screenshot?

Apr 9 2020, 6:03 AM · Plasma

Apr 6 2020

fvogt accepted D28614: Add better player tab crash handling.

For false positives the player would get added again by the playing event, which is not ideal, but as it doesn't require a reload it's IMO close enough.

Apr 6 2020, 10:08 AM · Plasma
fvogt added a comment to D28614: Add better player tab crash handling.

If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again?

I believe whenever a player starts playing again, it is propagated through MPRIS again. The playerGone handling is no different from the player being removed from DOM and being added back.

Apr 6 2020, 9:47 AM · Plasma
fvogt added a comment to D28614: Add better player tab crash handling.

If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again?

Apr 6 2020, 8:44 AM · Plasma
fvogt accepted D28290: Sync terminal with KIOFuse mount when browing remote directories.
Apr 6 2020, 6:17 AM · Dolphin

Apr 4 2020

fvogt added inline comments to D28134: Add ColorUtils.
Apr 4 2020, 4:47 PM · Kirigami

Apr 3 2020

fvogt added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

I assume there is a reason why MTPDevice::getDevice() has code for handling this very specific case, so I wouldn't just remove it without figuring out why: https://i.redd.it/hfnl7xo8yovy.gif

Apr 3 2020, 3:35 PM · Frameworks, Dolphin
fvogt added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

What you're suggesting is to change MTPDevice::getDevice to return the old device if reopening fails - but reopening without releasing might not work.

This seems to be a robust solution IMO, why do you suspect this might not work?

Apr 3 2020, 12:43 PM · Frameworks, Dolphin
fvogt added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

I see we don't speak in same language :)
LIBMTP_Open_Raw_Device_Uncached(&m_rawdevice);
returns nullptr that's normal since device is inaccessible, i mean it does not need to call LIBMTP_Release_Device using m_mtpdevice is safe it's not nullptr, it's just a disconnected device and libmtp knows that.

Apr 3 2020, 12:27 PM · Frameworks, Dolphin
fvogt added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

There is no such thing as an "invalid device" at that point anymore. There's only nullptr.

Apr 3 2020, 12:04 PM · Frameworks, Dolphin
fvogt added a comment to D28535: [KIO-MTP] Fix null pointer dereference.

You're right about bug report, but it can fail in any other place, just in particular version it happen in updateStorageInfo Can we cache getDevice in m_device (in constructor) then use it everywhere. I think libmtp has guard against disconnected device and will not crash.

Apr 3 2020, 11:40 AM · Frameworks, Dolphin

Mar 28 2020

fvogt requested changes to D28290: Sync terminal with KIOFuse mount when browing remote directories.
Mar 28 2020, 3:11 PM · Dolphin

Mar 5 2020

fvogt committed R268:8e14750977c6: Fix "Make it compile against last qt5.15 without deprecated method. QProcess… (authored by fvogt).
Fix "Make it compile against last qt5.15 without deprecated method. QProcess…
Mar 5 2020, 2:02 PM
fvogt added a reverting change for R268:59cbea835502: Make it compile against last qt5.15 without deprecated method. QProcess…: R268:8e14750977c6: Fix "Make it compile against last qt5.15 without deprecated method. QProcess….
Mar 5 2020, 2:02 PM
fvogt closed D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated".
Mar 5 2020, 2:02 PM · Frameworks
fvogt updated the test plan for D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated".
Mar 5 2020, 1:45 PM · Frameworks
fvogt retitled D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated" from Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated" to Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated".
Mar 5 2020, 1:42 PM · Frameworks
fvogt updated the diff for D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated".

Do it differently, just like it's done below

Mar 5 2020, 1:42 PM · Frameworks
fvogt added a comment to D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated".

if splitting is already done why this code re-call "m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString())" ?
=> QProcess::startDetached(commands, parts) no ?

Mar 5 2020, 1:39 PM · Frameworks
fvogt added a comment to D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated".

The split arguments are already available as parts above, as used in the klauncher call AFAICT.

Mar 5 2020, 12:15 PM · Frameworks
fvogt added a reviewer for D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated": mlaurent.
Mar 5 2020, 10:46 AM · Frameworks
fvogt requested review of D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated".
Mar 5 2020, 10:46 AM · Frameworks
fvogt added a reverting change for R268:59cbea835502: Make it compile against last qt5.15 without deprecated method. QProcess…: D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated".
Mar 5 2020, 10:46 AM

Mar 2 2020

fvogt committed R111:ba7f78716af6: Only link to Qt5WebChannel if Qt5WebEngineWidgets available (authored by fvogt).
Only link to Qt5WebChannel if Qt5WebEngineWidgets available
Mar 2 2020, 9:26 AM
fvogt committed R111:d4bc89ff9dc4: Merge branch 'Plasma/5.18' (authored by fvogt).
Merge branch 'Plasma/5.18'
Mar 2 2020, 9:26 AM
fvogt closed D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.
Mar 2 2020, 9:26 AM · Plasma
fvogt added inline comments to D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.
Mar 2 2020, 9:19 AM · Plasma
fvogt updated the summary of D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.
Mar 2 2020, 9:09 AM · Plasma
fvogt updated the diff for D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.

Treat scripting as a feature instead

Mar 2 2020, 9:08 AM · Plasma
fvogt added a comment to D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.

Currently processui/scripting.cpp has this:

Mar 2 2020, 8:52 AM · Plasma

Feb 27 2020

fvogt planned changes to D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.

I need some input on how to express HAVE_QTWEBENGINEWIDGETS with this. Currently it would fail to build if Qt5WebEngineWidgets is installed but Qt5WebChannel isn't.

Feb 27 2020, 4:21 PM · Plasma
fvogt updated the summary of D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.
Feb 27 2020, 4:20 PM · Plasma

Feb 26 2020

fvogt added a comment to D27643: FileChooser: download remote files to a cache location to open them through the portal.

I have never used fuse. I see you can use kio-fuse over dbus to mount a file, but you still have to unmount it, which will be a problem, because from the portal I don't know whether the app is still using it or not.

kio-fuse was designed with this in mind and does not even support unmounting. When the file isn't being used anymore, it drops everything except what's needed to reopen the file when requested.

If anyone is familiar with fuse and have solution in mind, can you give me a hint?

In this case it would be as easy as just calling org.kde.KIOFuse org.kde.KIOFuse.VFS mountUrl with the url and it gets a local path back.

This should ideally be handled transparently by the KDE file dialog though.

I will make the portal not to freeze the app when there is no local file selected and we can revisit this later. As I can see, there is not even a stable relase of kio-fuse,

Feb 26 2020, 12:34 PM · Plasma
fvogt added a comment to D27643: FileChooser: download remote files to a cache location to open them through the portal.

I have never used fuse. I see you can use kio-fuse over dbus to mount a file, but you still have to unmount it, which will be a problem, because from the portal I don't know whether the app is still using it or not.

Feb 26 2020, 8:49 AM · Plasma

Feb 25 2020

fvogt added a comment to D27643: FileChooser: download remote files to a cache location to open them through the portal.

Shouldn't KIO take care of this stuff automatically? I wouldn't want to lose streaming support for Flatpak apps.

Feb 25 2020, 3:01 PM · Plasma

Feb 24 2020

fvogt closed D27423: Don't show an error for a failed automatic refresh.
Feb 24 2020, 7:51 AM
fvogt committed R623:4d6cfaea1dd4: Don't show an error for a failed automatic refresh (authored by fvogt).
Don't show an error for a failed automatic refresh
Feb 24 2020, 7:51 AM
fvogt added a comment to D27423: Don't show an error for a failed automatic refresh.

Save the comments, this looks reasonable to me.

Feb 24 2020, 7:51 AM

Feb 18 2020

fvogt added a comment to D27358: Sync ("Wayland") appending to match SDDM.

Note that this behaviour of sddm is not in any release yet - only in git.

Feb 18 2020, 2:44 PM · Plasma
fvogt added a comment to D27457: Move kcminit_startup and kded to plasma-session.

As there's no reason to clear the environment, wouldn't it be more useful if StartServiceJob would only allow adding/overwriting variables?
StartProcessJob does not need an option to set the environment at all AFAICT.

Feb 18 2020, 10:09 AM · Plasma
fvogt added inline comments to D27457: Move kcminit_startup and kded to plasma-session.
Feb 18 2020, 8:51 AM · Plasma
fvogt requested changes to D27457: Move kcminit_startup and kded to plasma-session.
Feb 18 2020, 8:37 AM · Plasma
fvogt reopened D27457: Move kcminit_startup and kded to plasma-session.
Feb 18 2020, 8:37 AM · Plasma

Feb 15 2020

fvogt updated the diff for D27423: Don't show an error for a failed automatic refresh.

Fixing some style issues

Feb 15 2020, 3:56 PM
fvogt added inline comments to D27423: Don't show an error for a failed automatic refresh.
Feb 15 2020, 3:54 PM
fvogt updated the diff for D27423: Don't show an error for a failed automatic refresh.

Address comments. Still works.

Feb 15 2020, 3:53 PM
fvogt requested review of D27423: Don't show an error for a failed automatic refresh.
Feb 15 2020, 2:23 PM

Feb 12 2020

fvogt requested review of D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.
Feb 12 2020, 2:18 PM · Plasma

Feb 4 2020

fvogt added a comment to D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.

Could this be the fix for https://bugs.kde.org/show_bug.cgi?id=398908, or part of it?

Feb 4 2020, 6:38 PM · Frameworks
fvogt committed R98:9f332e6b89ed: Merge branch 'Plasma/5.18' (authored by fvogt).
Merge branch 'Plasma/5.18'
Feb 4 2020, 5:44 PM
fvogt committed R98:5250ab3baa3a: Drop kconf_update module, handled by kde-gtk-config now (authored by fvogt).
Drop kconf_update module, handled by kde-gtk-config now
Feb 4 2020, 5:42 PM
fvogt closed D26947: Drop kconf_update module, handled by kde-gtk-config now.
Feb 4 2020, 5:42 PM · Plasma
fvogt closed D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.
Feb 4 2020, 10:45 AM · Frameworks
fvogt committed R241:213ed50634c0: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu (authored by fvogt).
Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu
Feb 4 2020, 10:45 AM
fvogt added a comment to D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.

User feedback: "so far so good, 160 MB Memory usage"
Does not sound reassuring, I guess the user meant 160 MB compared to 200MB or similar prior to patch.

Feb 4 2020, 10:41 AM · Frameworks
fvogt updated the test plan for D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.
Feb 4 2020, 10:41 AM · Frameworks
fvogt added a comment to D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.

I'll land tomorrow if no objections.

Feb 4 2020, 10:33 AM · Frameworks
fvogt closed D26842: Fix fonts KCM button state.

Does this mean the default fonts have a style name of "Regular" now? That will break setting bold fonts and such, see https://phabricator.kde.org/D9070.

Default is not serialized in the configuration file (because it's the default value).

I do some check with current KCM version, and when we save it, we end up with font=Noto Sans,10,-1,5,87,1,0,0,0,0,Regular
Because nearest font algorithm return the regular one. So if I well understood everything this patch will not break anything.

Feb 4 2020, 10:13 AM · Plasma