fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (194 w, 6 d)
Availability
Available

Recent Activity

Sat, Feb 15

fvogt updated the diff for D27423: Don't show an error for a failed automatic refresh.

Fixing some style issues

Sat, Feb 15, 3:56 PM
fvogt added inline comments to D27423: Don't show an error for a failed automatic refresh.
Sat, Feb 15, 3:54 PM
fvogt updated the diff for D27423: Don't show an error for a failed automatic refresh.

Address comments. Still works.

Sat, Feb 15, 3:53 PM
fvogt requested review of D27423: Don't show an error for a failed automatic refresh.
Sat, Feb 15, 2:23 PM

Wed, Feb 12

fvogt requested review of D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available.
Wed, Feb 12, 2:18 PM · Plasma

Tue, Feb 4

fvogt added a comment to D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.

Could this be the fix for https://bugs.kde.org/show_bug.cgi?id=398908, or part of it?

Tue, Feb 4, 6:38 PM · Frameworks
fvogt committed R98:9f332e6b89ed: Merge branch 'Plasma/5.18' (authored by fvogt).
Merge branch 'Plasma/5.18'
Tue, Feb 4, 5:44 PM
fvogt committed R98:5250ab3baa3a: Drop kconf_update module, handled by kde-gtk-config now (authored by fvogt).
Drop kconf_update module, handled by kde-gtk-config now
Tue, Feb 4, 5:42 PM
fvogt closed D26947: Drop kconf_update module, handled by kde-gtk-config now.
Tue, Feb 4, 5:42 PM · Plasma
fvogt closed D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.
Tue, Feb 4, 10:45 AM · Frameworks
fvogt committed R241:213ed50634c0: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu (authored by fvogt).
Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu
Tue, Feb 4, 10:45 AM
fvogt added a comment to D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.

User feedback: "so far so good, 160 MB Memory usage"
Does not sound reassuring, I guess the user meant 160 MB compared to 200MB or similar prior to patch.

Tue, Feb 4, 10:41 AM · Frameworks
fvogt updated the test plan for D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.
Tue, Feb 4, 10:41 AM · Frameworks
fvogt added a comment to D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.

I'll land tomorrow if no objections.

Tue, Feb 4, 10:33 AM · Frameworks
fvogt closed D26842: Fix fonts KCM button state.

Does this mean the default fonts have a style name of "Regular" now? That will break setting bold fonts and such, see https://phabricator.kde.org/D9070.

Default is not serialized in the configuration file (because it's the default value).

I do some check with current KCM version, and when we save it, we end up with font=Noto Sans,10,-1,5,87,1,0,0,0,0,Regular
Because nearest font algorithm return the regular one. So if I well understood everything this patch will not break anything.

Tue, Feb 4, 10:13 AM · Plasma
fvogt reopened D26842: Fix fonts KCM button state.

Does this mean the default fonts have a style name of "Regular" now? That will break setting bold fonts and such, see https://phabricator.kde.org/D9070.

Tue, Feb 4, 9:33 AM · Plasma

Mon, Feb 3

fvogt accepted D26891: Upgrade theme to Breeze GTK on startup.

LGTM now. @meven and @fvogt, you good with this too?

Mon, Feb 3, 6:24 PM · Plasma

Fri, Jan 31

fvogt added a comment to D26891: Upgrade theme to Breeze GTK on startup.

The only remaining question from my side is why we have four different gtk configuration files and whether that causes issues.
Besides that, only @meven's comment needs a resolution.

Fri, Jan 31, 9:25 PM · Plasma

Thu, Jan 30

fvogt updated the test plan for D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.
Thu, Jan 30, 12:41 PM · Frameworks
fvogt added inline comments to D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.
Thu, Jan 30, 8:47 AM · Frameworks
fvogt added inline comments to D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.
Thu, Jan 30, 8:43 AM · Frameworks
fvogt updated the diff for D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.

Make a copy, QObject::children returns const & for some reason, so gets modified during iteration.

Thu, Jan 30, 8:31 AM · Frameworks
fvogt abandoned D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect.

D22758 got merged

Thu, Jan 30, 8:09 AM · Frameworks
fvogt added a comment to D22719: Avoid yet another crash on exit.

Hm, totally missed the notification for this...

Thu, Jan 30, 8:06 AM

Wed, Jan 29

fvogt requested review of D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu.
Wed, Jan 29, 6:55 PM · Frameworks

Mon, Jan 27

fvogt added a comment to D26947: Drop kconf_update module, handled by kde-gtk-config now.

5.18 I suppose?

Mon, Jan 27, 6:14 PM · Plasma
fvogt added a dependent revision for D26891: Upgrade theme to Breeze GTK on startup: D26947: Drop kconf_update module, handled by kde-gtk-config now.
Mon, Jan 27, 4:09 PM · Plasma
fvogt added a dependency for D26947: Drop kconf_update module, handled by kde-gtk-config now: D26891: Upgrade theme to Breeze GTK on startup.
Mon, Jan 27, 4:09 PM · Plasma
fvogt requested review of D26947: Drop kconf_update module, handled by kde-gtk-config now.
Mon, Jan 27, 4:09 PM · Plasma
fvogt added a comment to D26891: Upgrade theme to Breeze GTK on startup.

Tested, confirmed to work.

Mon, Jan 27, 3:16 PM · Plasma
fvogt committed R108:383cec583ee9: Merge branch 'Plasma/5.18' (authored by fvogt).
Merge branch 'Plasma/5.18'
Mon, Jan 27, 3:12 PM
fvogt committed R108:53af330d8f3e: Fix kwin.upd not running if python 2 not installed (authored by fvogt).
Fix kwin.upd not running if python 2 not installed
Mon, Jan 27, 3:12 PM
fvogt closed D26942: Fix kwin.upd not running if python 2 not installed.
Mon, Jan 27, 3:12 PM · KWin
fvogt requested review of D26942: Fix kwin.upd not running if python 2 not installed.
Mon, Jan 27, 2:54 PM · KWin

Sun, Jan 26

fvogt added inline comments to D26891: Upgrade theme to Breeze GTK on startup.
Sun, Jan 26, 11:08 AM · Plasma

Sat, Jan 25

fvogt added a comment to D26891: Upgrade theme to Breeze GTK on startup.

@fvogt Do I understand correctly, that kconf_update script also run on Plasma update, if I add a new Id to one of .upd file (or add one with new Id)? For example from 5.17 to 5.18?

Sat, Jan 25, 11:34 PM · Plasma
fvogt added a comment to D26891: Upgrade theme to Breeze GTK on startup.

It should only do the migration once, like the kconf_update script.

From where migration script is launched? Can the migration script itself be a standalone entity, that uses kded module for requesting the current theme ans setting whatever it wants in every config?

Sat, Jan 25, 2:24 PM · Plasma

Fri, Jan 24

fvogt added a comment to D26891: Upgrade theme to Breeze GTK on startup.

If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa, it should be possible to drop the kconf_update script there.
It might even cause conflicts otherwise.

If I understood correctly, this script replaces the theme setting from orion/oxygen-gtk to Breeze. But what if a user wants to actually use Oxygen for GTK theme?

Fri, Jan 24, 1:12 PM · Plasma
fvogt added a comment to D26891: Upgrade theme to Breeze GTK on startup.

If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa, it should be possible to drop the kconf_update script there.
It might even cause conflicts otherwise.

Fri, Jan 24, 12:03 PM · Plasma
fvogt added inline comments to D26891: Upgrade theme to Breeze GTK on startup.
Fri, Jan 24, 10:38 AM · Plasma

Tue, Jan 21

fvogt committed R120:63eea455da22: Merge branch 'Plasma/5.18' (authored by fvogt).
Merge branch 'Plasma/5.18'
Tue, Jan 21, 10:59 AM
fvogt committed R120:ea66bff2af84: Also disable automatic scaling on Qt >= 5.14 (authored by fvogt).
Also disable automatic scaling on Qt >= 5.14
Tue, Jan 21, 10:59 AM
fvogt closed D26185: Also disable automatic scaling on Qt >= 5.14.
Tue, Jan 21, 10:59 AM · Plasma
fvogt accepted D26185: Also disable automatic scaling on Qt >= 5.14.
Tue, Jan 21, 10:47 AM · Plasma
fvogt updated the test plan for D26185: Also disable automatic scaling on Qt >= 5.14.
Tue, Jan 21, 10:46 AM · Plasma

Mon, Jan 20

fvogt committed R105:e19146459b1e: Extend parsing ssh prompt (authored by pali).
Extend parsing ssh prompt
Mon, Jan 20, 8:27 AM
fvogt closed D9875: Extend parsing ssh prompt.
Mon, Jan 20, 8:27 AM · Plasma
fvogt updated the diff for D9875: Extend parsing ssh prompt.

Rebased

Mon, Jan 20, 8:24 AM · Plasma
fvogt commandeered D9875: Extend parsing ssh prompt.
Mon, Jan 20, 8:22 AM · Plasma
fvogt added a comment to D9875: Extend parsing ssh prompt.

I'll just land this now...

Mon, Jan 20, 8:05 AM · Plasma

Jan 17 2020

fvogt updated the test plan for D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper.
Jan 17 2020, 10:46 AM · Plasma
fvogt committed R133:cefa4fc5b72f: Merge branch 'Plasma/5.18' (authored by fvogt).
Merge branch 'Plasma/5.18'
Jan 17 2020, 10:08 AM
fvogt committed R133:48bc3b7c3e50: Merge branch 'Plasma/5.12' into Plasma/5.18 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.18
Jan 17 2020, 10:08 AM
fvogt committed R133:08178c059fd3: Load user information once on startup (authored by fvogt).
Load user information once on startup
Jan 17 2020, 10:07 AM
fvogt closed D26722: Load user information once on startup.
Jan 17 2020, 10:07 AM · Plasma
fvogt requested review of D26722: Load user information once on startup.
Jan 17 2020, 9:58 AM · Plasma
fvogt added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

The change itself is correct, but not in relation to the title and summary which are about https://bugreports.qt.io/browse/QTBUG-80967, which was a genuine bug in Qt, fixed in 5.14.1.
What this change fixes is double scaling in applications which enable Qt::AA_EnableHighDpiScaling.

Jan 17 2020, 8:15 AM · Plasma

Jan 16 2020

fvogt added a comment to D9875: Extend parsing ssh prompt.

Ping.

Jan 16 2020, 4:07 PM · Plasma

Jan 14 2020

fvogt added a comment to D25856: Show IOSlaves that return local files when in local file mode.

IMO this should be done in KIO, so that all users benefit.

How would you do it in KIO?

Add code to KFileDialog to allow specific protocols/slaves if the file scheme is supported.

I would guess something in the slave interface sort of like KDE-KIO-Protocols in json/.protocol files expect it would be about supported output scheme instead of input/handled.
Something like KDE-KIO-Output-Protocols
Then there would be an equivalent to KProtocolInfoFactory::findProtocol to get those, like KProtocolInfoFactory::findOutputProtocol
Basically ioslaves desktop file recentlyused trash and tags would have "file" set in there.

Jan 14 2020, 2:07 PM

Jan 13 2020

fvogt added a comment to D26640: [applets/weather] Port weather station picker to QQC2+ListView.

When I tested this, there was a very noticable delay (~10s) between starting the search and items appearing, so the busy indicator is IMO necessary.

Jan 13 2020, 9:20 PM · Plasma

Jan 11 2020

fvogt resigned from D8208: Add Duplicate feature.
Jan 11 2020, 7:12 PM · Dolphin
fvogt added a comment to D8208: Add Duplicate feature.

@fvogt "test.foo" becoming "test.foo copy" is intentional because .foo isn't a known valid extension, and it's valid for files to have dots in their names. In general the approach of using QMimeDatabase supports this, solves the problems of using QFileInfo that @pino pointed out, and also allows seamless support for filename extensions with two dots in them (e.g. tar.gz).

If I go back to using QFileInfo to chop up the file into filename + extension, then there's the difficult choice of what kind of file to fail on: If I use QFileInfo::suffix(), it will fail for extensions with two dots like .tar.gz; if I use QFileInfo::completeSuffix(), that fails for files with dots in their names outside of the extension.

Each approach has drawbacks. Which would you find acceptable?

Why trying to append 'copy' in the base name whith possible headaches while you could simply do something like 'Copy N#1 of /original file name/' ?

Jan 11 2020, 1:47 PM · Dolphin
fvogt added a comment to D8208: Add Duplicate feature.

@fvogt "test.foo" becoming "test.foo copy" is intentional because .foo isn't a known valid extension, and it's valid for files to have dots in their names. In general the approach of using QMimeDatabase supports this, solves the problems of using QFileInfo that @pino pointed out, and also allows seamless support for filename extensions with two dots in them (e.g. tar.gz).

If I go back to using QFileInfo to chop up the file into filename + extension, then there's the difficult choice of what kind of file to fail on: If I use QFileInfo::suffix(), it will fail for extensions with two dots like .tar.gz; if I use QFileInfo::completeSuffix(), that fails for files with dots in their names outside of the extension.

Each approach has drawbacks. Which would you find acceptable?

Jan 11 2020, 11:23 AM · Dolphin

Jan 10 2020

fvogt requested changes to D8208: Add Duplicate feature.
Jan 10 2020, 9:08 PM · Dolphin

Jan 8 2020

fvogt accepted D26191: Add support for FileJob->truncate() in smb/sftp slaves.
Jan 8 2020, 8:10 PM · Frameworks, Dolphin

Jan 7 2020

fvogt added a comment to D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer.

IMO it should still be considered if it's the only one.

Jan 7 2020, 10:49 AM · Plasma
fvogt added inline comments to D26444: [RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed.
Jan 7 2020, 8:43 AM · Plasma

Dec 26 2019

fvogt added a comment to D9875: Extend parsing ssh prompt.
In D9875#583106, @pali wrote:

Is there anything else or something which blocks merging this change into upstream git repository?

Dec 26 2019, 10:27 AM · Plasma

Dec 23 2019

fvogt requested changes to D26191: Add support for FileJob->truncate() in smb/sftp slaves.
Dec 23 2019, 7:01 PM · Frameworks, Dolphin

Dec 22 2019

fvogt accepted D26157: Port QRegExp to QRegularExpression.
Dec 22 2019, 6:26 PM · Frameworks

Dec 12 2019

fvogt added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

This fixed the button label, but the menu itself is unsuable due to a black text on dark background: https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21

Dec 12 2019, 7:09 PM · Frameworks
fvogt added a comment to D25883: Find qdbus command correctly.

I'm wondering whether this might not actually break the "qtchooser" variant - if binaries are in a Qt version specific dir, the path to qdbus would no longer exist after a Qt update without a rebuild of spectacle.

Dec 12 2019, 7:03 PM · Spectacle

Dec 11 2019

fvogt added a comment to D25883: Find qdbus command correctly.

the actual name of the command is qdbus-qt<version> in the distro's Qt

Dec 11 2019, 1:07 PM · Spectacle
fvogt added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

Please don't link external sites (GitHub) in the committed message.

RE: Menu
There is nothing in QQC2::Button to add a menu

If we want that it would have to be a custom button subclass, rather than something we support in the style.

Dec 11 2019, 11:05 AM · Frameworks

Dec 10 2019

fvogt added a comment to D25856: Show IOSlaves that return local files when in local file mode.

IMO this should be done in KIO, so that all users benefit.

How would you do it in KIO?

Dec 10 2019, 9:20 PM
fvogt added a comment to D25856: Show IOSlaves that return local files when in local file mode.

IMO this should be done in KIO, so that all users benefit.

Dec 10 2019, 5:58 PM

Dec 7 2019

fvogt added a comment to D25699: [PC3 ToolButton] Have the label take into account complementary color schemes.

The check for the prefix was added in bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc, while the control.flat one got added much earlier.

Dec 7 2019, 10:13 PM · Frameworks
fvogt accepted D25803: [Purpose Plugin] Reset pending reply serial when aborting.
Dec 7 2019, 9:48 PM · Plasma

Dec 4 2019

fvogt added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

I just tested writing today, for files opened in 3rd-party apps that get the FUSE mount path. Results:
...

Dec 4 2019, 4:41 PM · Frameworks

Dec 3 2019

fvogt added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

I'm afraid that even with that change, the issue is still present. I honestly don't think it would be the worst thing in the world if we always handed the kio-fuse paths to apps that don't use ioslaves.

Dec 3 2019, 7:57 AM · Frameworks

Dec 2 2019

fvogt added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in the file, so I usually just see < for a HTML page

Ignoring the elephant in the room which is that this diff forces everything through mountUrl, that's the expected behavior with a plain HTTP URL as the size isn't known until the file is downloaded. So stat reports a size of 1 until the file is actually opened.
This is unavoidable, otherwise every ls would trigger a download of all files. If handling this better is important, HTTPProtocol::stat could use a HEAD request to get the Content-Length, but that doesn't work in all cases either.

Well, we need to fix this or else it's a very serious regression that breaks a huge part of the desktop. Opening links in a web browser is pretty basic functionality.

Dec 2 2019, 2:21 PM · Frameworks
fvogt added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Please try both of the following:

Done. Here are the log files:

Dec 2 2019, 12:30 PM · Frameworks
fvogt added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in the file, so I usually just see < for a HTML page

Dec 2 2019, 12:13 PM · Frameworks

Dec 1 2019

fvogt added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

Unfortunately the kio-fuse -d output is incomplete, probably because Qt was too smart and logged to the journal instead...
It's visible that there are multiple processes reading the file, maybe thumbnailing is in progress?
Can you try with thumbnails in dolphin disabled?

Dec 1 2019, 12:19 PM · Frameworks

Nov 30 2019

fvogt added a comment to D23384: Adding support for mounting KIOFuse URLs for applications that don't use KIO.

That happens because the .desktop file sets X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb:
https://code.videolan.org/videolan/vlc/blob/master/share/vlc.desktop.in#L124

Nov 30 2019, 11:18 AM · Frameworks
fvogt added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

I wonder whether the job duplication can just be ignored like this or whether there has to be a "virtual" unique id instead to be able to address duplicated jobs as well.
When cancelling a duplicated job with this patch, are both gone or just one of them?

Nov 30 2019, 10:45 AM

Nov 29 2019

fvogt accepted D25569: Also overwrite document.createElement using exportFunction.

Ugly...

Nov 29 2019, 1:37 PM · Plasma

Nov 25 2019

fvogt accepted D25107: Add install dir for systemd units.
Nov 25 2019, 6:06 PM · Build System, Frameworks
fvogt requested changes to D25107: Add install dir for systemd units.
Nov 25 2019, 1:40 PM · Build System, Frameworks
fvogt reopened D25107: Add install dir for systemd units.

AFAICT this breaks if LIBDIR != "lib". systemd only looks in /usr/lib AFAICT, so hardcoding to $prefix/lib/systemd might be better.

Nov 25 2019, 1:39 PM · Build System, Frameworks
fvogt requested changes to D25466: Add Captive Portal auto-refresh handling.

IMO this should be addressed outside of PBI instead:

  • If a captive portal is detected, call CheckConnectivity with a higher frequency (I've never had any issues with this, actually)
  • Instead of opening networkcheck.kde.org in the browser when clicking the "Log In" button, open a page which just closes itself
Nov 25 2019, 12:36 PM · Plasma

Nov 21 2019

fvogt added a comment to D25403: Drop Position change signal and support Seeked signal.

This would work, but why not just emit Seeked(m_position) in setPosition?

Nov 21 2019, 10:56 AM · Plasma

Nov 20 2019

fvogt accepted D25404: Just return applicationDisplayName in MPRIS Identity.
Nov 20 2019, 3:01 PM · Plasma

Nov 18 2019

fvogt requested changes to D25363: Fix one more buffer overread in ksysguard network helper.

I wonder whether this can actually happen, as that header is AFAICT added by the kernel and not from the network.

Nov 18 2019, 9:46 AM · Plasma

Nov 15 2019

fvogt accepted D25320: Show startup error in popup as well.

I wonder whether the getStatus handler could be cleaned up by removing the UNKNOWN value of portStatus and removing the default: case.

Nov 15 2019, 10:43 AM · Plasma

Nov 14 2019

fvogt added a comment to D25293: Use dbus-send instead of qdbus for global shortcuts.

It doesn't seem to work here either, but adding the --print-reply argument helps for some reason.

Nov 14 2019, 7:59 AM · Spectacle

Nov 6 2019

fvogt reopened T4437: [kwayland] Security filter as "Open".

This got implemented in https://phabricator.kde.org/D22571, which is flawed (see the various comments there).

Nov 6 2019, 12:25 PM · Plasma on Wayland
fvogt accepted D25169: [wayland] Fix sha check of filtered applications.

This way the code does what it's supposed to (even though it's flawed), so definitely an improvement.

Nov 6 2019, 12:18 PM · KWin
fvogt added a comment to D22571: Allow blacklisting some wayland interfaces.

But given you're right about readlink (exe) and read(exe) behaving differently, we should be able to simplify things and have it work.

I shall do that now.

Nov 6 2019, 12:15 PM · KWin
fvogt added inline comments to D22571: Allow blacklisting some wayland interfaces.
Nov 6 2019, 10:09 AM · KWin