fvogt (Fabian Vogt)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 24 2016, 11:24 AM (125 w, 4 d)
Availability
Available

Recent Activity

Today

fvogt reopened D16331: GTK theme treeview style typo/bug fix.

AFAICT Plasma/5.12 is affected as well, any reason this wasn't landed to 5.12?

Sun, Oct 21, 9:01 AM · Plasma, Breeze

Yesterday

fvogt committed R124:c37913c5add5: Fix crash on ExternalApp modules (authored by fvogt).
Fix crash on ExternalApp modules
Sat, Oct 20, 11:06 AM

Thu, Oct 18

fvogt requested review of D16305: Add a QIconEnginePlugin to allow QIcon deserialization.
Thu, Oct 18, 6:48 PM · Frameworks

Tue, Oct 9

fvogt committed R111:c9747e37c531: Port scripting to Qt WebEngine (authored by fvogt).
Port scripting to Qt WebEngine
Tue, Oct 9, 9:45 AM
fvogt closed D15209: Port scripting to Qt WebEngine.
Tue, Oct 9, 9:45 AM · Plasma
fvogt added a comment to D15209: Port scripting to Qt WebEngine.

I removed the RFC - I'm using this patch since I uploaded and haven't had any issues so far.

Tue, Oct 9, 9:26 AM · Plasma
fvogt retitled D15209: Port scripting to Qt WebEngine from RFC: Port scripting to Qt WebEngine to Port scripting to Qt WebEngine.
Tue, Oct 9, 9:25 AM · Plasma

Mon, Oct 8

fvogt abandoned D15984: Close unneeded FDs before startup.

The bug reporter said a version of the patch causes busy loops? Is that this one?

Mon, Oct 8, 10:56 AM · Plasma

Sat, Oct 6

fvogt updated the test plan for D15984: Close unneeded FDs before startup.
Sat, Oct 6, 4:44 PM · Plasma
fvogt requested review of D15984: Close unneeded FDs before startup.
Sat, Oct 6, 4:43 PM · Plasma

Thu, Oct 4

fvogt added a comment to D8532: [WIP] Restrict file extractor with Seccomp.

AFAICT this won't actually protect much - the open DBus socket is enough to execute arbitrary programs.

Thu, Oct 4, 3:16 PM · Baloo, Frameworks

Tue, Oct 2

fvogt added a comment to D15512: [startplasmacompositor] Add Wayland socket argument.

Is there a real reason against it besides "not necessary"? Maybe that we can't remove the manual override again without breaking some API promise once we have the grand solution of automatically taking the next free Wayland socket?

Tue, Oct 2, 1:09 PM · Plasma

Mon, Oct 1

fvogt added a comment to D15875: [Media Controller] Disallow seeking beyond end of track.

I'm not sure whether that's correct - a file with a duration of 1s still has a range of 1s.

Mon, Oct 1, 11:49 AM · Plasma
fvogt accepted D15863: [MPris Plugin] Support Seek().
Mon, Oct 1, 11:31 AM · Plasma
fvogt accepted D15863: [MPris Plugin] Support Seek().

LGTM. I just tried how the currentTime property in JS works, it actually behaves like MPRIS' seek does and does not ignore invalid values. That might need a check in SetPosition.

Mon, Oct 1, 11:16 AM · Plasma
fvogt requested changes to D15863: [MPris Plugin] Support Seek().

Seek has a different behaviour for position() + offset < 0 and position() + offset == m_length:

Mon, Oct 1, 9:50 AM · Plasma

Mon, Sep 24

fvogt accepted D15724: Wait for duration to be known before registering player.
Mon, Sep 24, 11:24 AM · Plasma
fvogt added inline comments to D15724: Wait for duration to be known before registering player.
Mon, Sep 24, 11:18 AM · Plasma
fvogt added inline comments to D15724: Wait for duration to be known before registering player.
Mon, Sep 24, 11:15 AM · Plasma

Sun, Sep 23

fvogt added a comment to D15448: Send file contents in chunks.

! In D15448#330352, @ngraham wrote:
How is this looking now that D15426 has gone in?

Sun, Sep 23, 10:24 AM
fvogt committed R219:1b710a46d04a: Send file contents in chunks (authored by fvogt).
Send file contents in chunks
Sun, Sep 23, 10:18 AM
fvogt committed R219:df2f3cadb5a1: Merge branch '1.2' (authored by fvogt).
Merge branch '1.2'
Sun, Sep 23, 10:18 AM
fvogt closed D15448: Send file contents in chunks.
Sun, Sep 23, 10:18 AM

Sat, Sep 22

fvogt committed R241:d2d52da38016: Avoid QByteArray::remove in AccessManagerReply::readData (authored by fvogt).
Avoid QByteArray::remove in AccessManagerReply::readData
Sat, Sep 22, 4:23 PM
fvogt closed D15426: Avoid QByteArray::remove in AccessManagerReply::readData.
Sat, Sep 22, 4:23 PM · Frameworks
fvogt added a comment to D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

@svuorela accessmanagertest already tests whether the AMR works in general. Do you mean a test which ensures there is no performance regression?

Sat, Sep 22, 4:21 PM · Frameworks

Sep 19 2018

fvogt added a comment to D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.

IMO it should just check for both and prefer qdbus-qt5 if available.

Yes, that was my starting patch, but then I got unsure about the great picture.
If going this route, any shell script wizard proposal how to change checkToolsInPath in kdevplatform_shell_environment.sh to check for both variants, without adding too much boilerplate code?

Sep 19 2018, 7:32 PM · KDevelop
fvogt added a comment to D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.

IMO it should just check for both and prefer qdbus-qt5 if available.

Sep 19 2018, 6:29 PM · KDevelop

Sep 16 2018

fvogt added inline comments to D15448: Send file contents in chunks.
Sep 16 2018, 7:32 PM
fvogt updated the diff for D15448: Send file contents in chunks.

Address comments.

Sep 16 2018, 7:32 PM
fvogt updated the diff for D15448: Send file contents in chunks.

Use QByteArray::fromRawData

Sep 16 2018, 9:12 AM

Sep 15 2018

fvogt added a comment to D15448: Send file contents in chunks.

The bigger, the better (=faster).
The 0xFFFFFF limit in KIO itself is due to the protocol only having 24 bits for size AFAIK - KLocalSocket can handle more than that at once without copying.
I'm not sure where TransferJob is used actually. It worked fine with more than 14MiB as well.

Sep 15 2018, 2:59 PM

Sep 14 2018

fvogt added a comment to D15512: [startplasmacompositor] Add Wayland socket argument.

I'm against this - kwin_wayland should just pick the next available socket if wayland-0 is not available. That's also what Xorg does and is IMO the expected behaviour.

Maybe this would be nice, haven't thought about it yet. But what speaks in any case against a manual override?

Sep 14 2018, 8:11 PM · Plasma
fvogt added a comment to D15512: [startplasmacompositor] Add Wayland socket argument.

I'm against this - kwin_wayland should just pick the next available socket if wayland-0 is not available. That's also what Xorg does and is IMO the expected behaviour.

Sep 14 2018, 7:08 PM · Plasma
fvogt committed R99:61392c48d15e: Merge branch 'Plasma/5.14' (authored by fvogt).
Merge branch 'Plasma/5.14'
Sep 14 2018, 6:41 PM
fvogt committed R99:74e631cb9808: Merge branch 'Plasma/5.13' into Plasma/5.14 (authored by fvogt).
Merge branch 'Plasma/5.13' into Plasma/5.14
Sep 14 2018, 6:41 PM
fvogt committed R99:562054bfe635: Merge branch 'Plasma/5.12' into Plasma/5.13 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.13
Sep 14 2018, 6:40 PM
fvogt committed R99:7d1c7c30ab34: Merge remote-tracking branch 'origin/Plasma/5.11' into Plasma/5.12 (authored by fvogt).
Merge remote-tracking branch 'origin/Plasma/5.11' into Plasma/5.12
Sep 14 2018, 6:40 PM
fvogt committed R123:1ea6533d9e0d: Merge branch 'Plasma/5.14' (authored by fvogt).
Merge branch 'Plasma/5.14'
Sep 14 2018, 12:35 PM
fvogt committed R123:f746728b5d96: Merge branch 'Plasma/5.12' into Plasma/5.14 (authored by fvogt).
Merge branch 'Plasma/5.12' into Plasma/5.14
Sep 14 2018, 12:34 PM
fvogt committed R123:0497a6e917c9: Workaround QTBUG-47066 to fix crash on startup (authored by fvogt).
Workaround QTBUG-47066 to fix crash on startup
Sep 14 2018, 12:34 PM
fvogt committed R123:a21dd3486b12: Workaround QTBUG-47066 to fix crash on startup (authored by fvogt).
Workaround QTBUG-47066 to fix crash on startup
Sep 14 2018, 12:34 PM
fvogt closed D15498: Workaround QTBUG-47066 to fix crash on startup.
Sep 14 2018, 12:34 PM · Plasma
fvogt requested review of D15498: Workaround QTBUG-47066 to fix crash on startup.
Sep 14 2018, 9:35 AM · Plasma

Sep 13 2018

fvogt committed R31:51cedac0889b: Disable the title bar separator by default (authored by fvogt).
Disable the title bar separator by default
Sep 13 2018, 5:25 AM
fvogt closed D10429: Disable the title bar separator by default.
Sep 13 2018, 5:25 AM · Plasma

Sep 12 2018

fvogt updated the summary of D15448: Send file contents in chunks.
Sep 12 2018, 3:11 PM
fvogt updated the diff for D15448: Send file contents in chunks.

Use same value as kio-sftp

Sep 12 2018, 3:11 PM
fvogt updated the diff for D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

Remove code.

Sep 12 2018, 1:54 PM · Frameworks
fvogt added a comment to D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

For the trivial case, do the clear in readData().

For the non-trivial case:

  1. in readData(), no memmoves were ever done. Currently, if you have e.g. 50 kB in m_data, you read 2 * 16 kB, and move the remaining 18 kB to the front. You can instead just read 3 * 16 + 2 kB.

It's always a cpu/memory trade off. I prefer KISS to premature optimization.

if you remove the || m_offset * 2 >= m_data.length(), it gets even simpler, and does less work (especially for the readAll() case). The garbage collection is already done in slotData.

Sep 12 2018, 1:42 PM · Frameworks
fvogt updated the diff for D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

The empty "if" is kept for readability.

Sep 12 2018, 12:12 PM · Frameworks
fvogt requested review of D15448: Send file contents in chunks.
Sep 12 2018, 9:43 AM
fvogt updated the diff for D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

Avoid reallocation in slotData if removing m_offset frees enough space.

Sep 12 2018, 8:19 AM · Frameworks
fvogt added a comment to D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

For the trivial case, do the clear in readData().

For the non-trivial case:

  1. in readData(), no memmoves were ever done. Currently, if you have e.g. 50 kB in m_data, you read 2 * 16 kB, and move the remaining 18 kB to the front. You can instead just read 3 * 16 + 2 kB.
Sep 12 2018, 8:01 AM · Frameworks
fvogt updated the diff for D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

Save m_offset bytes in slotData as well.

Sep 12 2018, 7:57 AM · Frameworks

Sep 11 2018

fvogt added inline comments to D15426: Avoid QByteArray::remove in AccessManagerReply::readData.
Sep 11 2018, 6:51 PM · Frameworks
fvogt updated the summary of D15426: Avoid QByteArray::remove in AccessManagerReply::readData.
Sep 11 2018, 5:41 PM · Frameworks
fvogt updated the diff for D15426: Avoid QByteArray::remove in AccessManagerReply::readData.
  • Actually make it work
  • Free memory if m_offset is half of the array size
  • Bail out if maxSize < 0
Sep 11 2018, 5:34 PM · Frameworks
fvogt updated the test plan for D15426: Avoid QByteArray::remove in AccessManagerReply::readData.
Sep 11 2018, 5:33 PM · Frameworks
fvogt added a comment to D15426: Avoid QByteArray::remove in AccessManagerReply::readData.

Depending on how AccessManagerReply is used, it might be necessary to do m_data.remove(0, m_offset); m_offset = 0; if m_offset grows too large to not leak memory. Can a KIO expert answer this?

Sep 11 2018, 1:33 PM · Frameworks
fvogt requested review of D15426: Avoid QByteArray::remove in AccessManagerReply::readData.
Sep 11 2018, 1:27 PM · Frameworks
fvogt resigned from D14536: [scripting] Port ScriptedEffects to QJSEngine.
Sep 11 2018, 11:20 AM · KWin
fvogt added inline comments to D14536: [scripting] Port ScriptedEffects to QJSEngine.
Sep 11 2018, 9:10 AM · KWin

Sep 6 2018

fvogt requested changes to D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable().

This will likely not work with ACLs.

Sep 6 2018, 1:29 PM · Frameworks

Sep 4 2018

fvogt added inline comments to D14536: [scripting] Port ScriptedEffects to QJSEngine.
Sep 4 2018, 7:56 AM · KWin
fvogt accepted D15255: Don't use QIcon::Selected state for selected icon.

I tried it - except for the not anymore disappearing icons I can't spot any difference.

Sep 4 2018, 6:55 AM · Dolphin

Sep 2 2018

fvogt added a comment to D15138: Consider all thumbnailers for the information panel and tooltips.

At the very least, this patch should have changed the label in the Confirmations tab from "Show previews for:" to "Show previews in the view for:", to fix the inconsistency Mark pointed out.

Sep 2 2018, 10:12 AM · Dolphin
fvogt requested review of D15216: Adjust label in the settings page for changed preview behaviour.
Sep 2 2018, 10:10 AM · Dolphin

Sep 1 2018

fvogt requested review of D15209: Port scripting to Qt WebEngine.
Sep 1 2018, 4:43 PM · Plasma
fvogt committed R320:13fa6f05be93: Merge branch 'Applications/18.08' (authored by fvogt).
Merge branch 'Applications/18.08'
Sep 1 2018, 11:07 AM
fvogt committed R320:bfbef9f61a17: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1 (authored by fvogt).
Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1
Sep 1 2018, 11:06 AM
fvogt closed D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1.
Sep 1 2018, 11:06 AM

Aug 31 2018

fvogt added a comment to T9381: Discover show EOL message on 16.04?.

In openSUSE the lifecycle data is part of /etc/product.d/openSUSE.product (openSUSE-release package) which receives updates through the regular channel.
The zypp PK backend reads those files and using "get-distro-upgrades" a list of available update targets can be acquired:
https://github.com/hughsie/PackageKit/blob/576cfb3d2568e88e01d823bef98c3981ad9d54f1/backends/zypp/pk-backend-zypp.cpp#L2205

Aug 31 2018, 6:00 PM · KDE Neon : bionic
fvogt added a comment to D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero.

With a few modification the patch is correct and necessary though.

Aug 31 2018, 8:29 AM · Frameworks

Aug 29 2018

fvogt committed R318:1d943518ad2b: Consider all thumbnailers for the information panel and tooltips (authored by fvogt).
Consider all thumbnailers for the information panel and tooltips
Aug 29 2018, 3:51 PM
fvogt closed D15138: Consider all thumbnailers for the information panel and tooltips.
Aug 29 2018, 3:51 PM · Dolphin
fvogt added a comment to D15138: Consider all thumbnailers for the information panel and tooltips.

Landed as https://commits.kde.org/dolphin/1d943518ad2b7f6f26bbe05588134758ec424055.
Phab didn't close this revision, presumably because it's in "Needs Review" state.

Aug 29 2018, 3:29 PM · Dolphin
fvogt updated the test plan for D15138: Consider all thumbnailers for the information panel and tooltips.
Aug 29 2018, 2:48 PM · Dolphin
fvogt updated the diff for D15138: Consider all thumbnailers for the information panel and tooltips.

Do the same for the information panel

Aug 29 2018, 2:47 PM · Dolphin
fvogt added a comment to D15138: Consider all thumbnailers for the information panel and tooltips.

Of course, that's the main and only point of this patch.

Aug 29 2018, 9:26 AM · Dolphin
fvogt added a comment to D15138: Consider all thumbnailers for the information panel and tooltips.

@broulik doesn't use tooltips himself - so I'll wait a day whether someone who does objects to this

Aug 29 2018, 8:08 AM · Dolphin
fvogt requested review of D15138: Consider all thumbnailers for the information panel and tooltips.
Aug 29 2018, 8:01 AM · Dolphin

Aug 28 2018

fvogt requested review of D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1.
Aug 28 2018, 7:22 AM

Aug 27 2018

fvogt accepted D15095: [RFC] Remove HTML thumbnailer.

I get the same result: This is not possible to achieve using Qt WebEngine. See upstream bug https://bugreports.qt.io/browse/QTBUG-46129

Aug 27 2018, 7:48 PM
fvogt updated the summary of D15095: [RFC] Remove HTML thumbnailer.
Aug 27 2018, 11:25 AM

Aug 22 2018

fvogt committed R135:893175d8c38b: Don't depend on the exact version of Breeze (authored by fvogt).
Don't depend on the exact version of Breeze
Aug 22 2018, 9:06 PM
fvogt closed D15008: Don't depend on the exact version of Breeze.
Aug 22 2018, 9:06 PM · Plasma
fvogt requested review of D15008: Don't depend on the exact version of Breeze.
Aug 22 2018, 9:01 PM · Plasma
fvogt committed R120:6e5c9e9b1666: Use QJSValue as method parameter type for the scripting interface (authored by fvogt).
Use QJSValue as method parameter type for the scripting interface
Aug 22 2018, 12:23 PM
fvogt closed D14822: Use QJSValue as method parameter type for the scripting interface.
Aug 22 2018, 12:23 PM · Plasma
fvogt added a comment to D14822: Use QJSValue as method parameter type for the scripting interface.

Ping.

Aug 22 2018, 12:11 PM · Plasma

Aug 20 2018

fvogt added inline comments to D14723: Add option to disable KWallet entirely in the new wallet dialog.
Aug 20 2018, 7:38 PM · Frameworks
fvogt updated the diff for D14723: Add option to disable KWallet entirely in the new wallet dialog.

Quit kwalletd if option was selected.

Aug 20 2018, 7:36 PM · Frameworks
fvogt added inline comments to D14822: Use QJSValue as method parameter type for the scripting interface.
Aug 20 2018, 1:04 PM · Plasma

Aug 17 2018

fvogt requested changes to D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available.

On neon it won't work as the kernel everything is built against (so the minimum API/ABI) is too old. You'll either have to hack around that by messing with include paths or use something more recent.

Aug 17 2018, 7:29 AM · Frameworks

Aug 14 2018

fvogt added a comment to D14822: Use QJSValue as method parameter type for the scripting interface.

A different approach of fixing this is to do something like

Aug 14 2018, 12:22 PM · Plasma
fvogt added inline comments to D14822: Use QJSValue as method parameter type for the scripting interface.
Aug 14 2018, 11:00 AM · Plasma
fvogt requested changes to D14536: [scripting] Port ScriptedEffects to QJSEngine.

There are uses of QVariant in method parameters, so this is most likely affected by https://bugs.kde.org/show_bug.cgi?id=397338

Aug 14 2018, 10:04 AM · KWin
fvogt requested review of D14822: Use QJSValue as method parameter type for the scripting interface.
Aug 14 2018, 9:52 AM · Plasma

Aug 11 2018

fvogt added a comment to D14723: Add option to disable KWallet entirely in the new wallet dialog.

Isn't this actually bad for the privacy goal? AFAIK some apps will just write the password in cleartext in a config file when kwallet is not present.

Aug 11 2018, 4:26 PM · Frameworks