- User Since
- May 24 2016, 11:24 AM (169 w, 2 d)
Thu, Aug 15
AFAICT this won't work on wayland and will also break the browser's native implementation once that actually exists.
Wed, Aug 14
Tue, Aug 13
Didn't test, but looks good
From the bug report:
Mon, Aug 12
IMHO the member variable is really ugly. Messages with and without serial number have to be handled differently anyway, so why not introuce a new handleMessage(event, json, serial) method?
Sat, Aug 10
Thu, Aug 8
Wed, Aug 7
Built fine and Icon[$e]=$(kinfocenter) didn't work anymore as expected.
Code looks good, if you tested successfully with vlc this can IMO go in
Tue, Aug 6
Mon, Aug 5
Thu, Aug 1
Tue, Jul 30
I'll land in 24h if no objections.
Mon, Jul 29
Sat, Jul 27
QObjects live in their own thread and shouldn't be used outside.
In your patch we are emitting the signal from the run thread instead of the actual object's thread. This is wrong.
Fri, Jul 26
Thu, Jul 25
Wed, Jul 24
Looks like a hack still, with two Job objects for each job...
IMO there should be a clear warning or error message if and why a request was declined.
Jul 23 2019
(Somewhat OT) I asked dfaure about the header file installation and it's split correctly as kpublictransport is namespaced and this way the include paths match the classes.
Jul 22 2019
An iframe without source, the things web devs come up with...
Jul 21 2019
Do it differently.
Jul 20 2019
Code looks good and seems to work fine in vivaldi, but I get an error in firefox:
Still can't reproduce, but doesn't seem to intruduce a regression either
Jul 19 2019
Jul 11 2019
Haven't checked whether this is in 5.16 or only a master regression.
Jul 10 2019
Jul 5 2019
Jul 4 2019
Jul 3 2019
Do it differently.
instead might work, but maybe there are cases with more than once writable location?
IMO this should be up to the content script, which seems to handle this properly already
This patch only helps with the case where SDDM is updated first,
Jul 2 2019
This is a necessary step to avoid having two indistinguishable "Plasma" options in SDDM with the linked PR merged and all other DMs , the other option is to have a "Plasma (Wayland) (Wayland)" in sddm only.
llvmpipe generally works fine, just not when using it with cirrus if the kernel uses 16bpp.