[WIP] Add Bahrain Holiday File
ClosedPublic

Authored by safaalfulaij on Aug 11 2018, 11:07 PM.

Diff Detail

Repository
R175 PIM: KHolidays
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
safaalfulaij created this revision.Aug 11 2018, 11:07 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 11 2018, 11:07 PM
safaalfulaij requested review of this revision.Aug 11 2018, 11:07 PM

I tried to read about a way to extend the holiday if happened in a weekend day but couldn't find one.
If any day of a holiday happen to be in a Friday or Saturday (Weekend days in Bahrain), the next working day will be a holiday.
Example: Eid ul-Fitr is 3 days, starting from Thursday. It happens on Thursday, Friday, Satarday, Sunday and Monday, where Sunday and Monday are not actually holidays, but they are now so that a holiday is really a day-off and not a usual weekend day.
I'll be done once I solve this for all the holidays in the file.

Fix source
Add shifts

sorry, I completely missed this.
I'll take a look

winterz added a comment.EditedOct 28 2018, 5:05 PM

I'll commit this for you.
it seems to work, at least as much as I can tell.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 28 2018, 5:08 PM
This revision was automatically updated to reflect the committed changes.

I'll commit this for you.
it seems to work, at least as much as I can tell.

Thanks a lot!
It works, yes. There is a small issue, but I think it's not that of a deal. I might get my hands with KHolidays, one day, and check how things work :)