Make checkboxes look better in the General settings page

Authored by safaalfulaij on Sep 7 2018, 4:23 PM.



Keep the checkbox text with the checkbox itself.
Fix the strange looking autosave option.

Test Plan


Diff Detail

R37 Krita
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
safaalfulaij created this revision.Sep 7 2018, 4:23 PM
Restricted Application added a project: Krita. · View Herald TranscriptSep 7 2018, 4:23 PM
safaalfulaij requested review of this revision.Sep 7 2018, 4:23 PM
safaalfulaij added a subscriber: ngraham.EditedSep 7 2018, 4:29 PM


“Window” before:

“Window” after:

“Misc.” before:

“Misc.” after - enabled:

“Misc.” after - disabled:

Of course it be great if we can use KPluralHandlingSpinBox, but I am not entirely sure about dependencies and import stuff, so I'll keep this for real developers :)

ngraham requested changes to this revision.EditedSep 7 2018, 4:50 PM
ngraham added a reviewer: VDG.

“Window” after:

Even though it's technically correct to align the controls and have checkbox labels on the right, it unfortunately creates a bit of a visual regression due to the addition of all the whitespace on the left. We had long discussions on this very subject in D12571 and T8655 and eventually came up with the idea that in situations like this, the top-most checkbox should get a left label that serves as a sort of section header for all of the checkboxes. If the checkboxes have no logical grouping, even just "General" would suffice. Also, add a whitespace separator between the four checkboxes and the controls above them. See also and

“Misc.” after - enabled:


These views could really benefit from better logical grouping of controls using whitespace and left-aligned pseudo-header labels. Look at Dolphin's settings window in 18.08 or git master for an example. But all of that can be done in a separate patch. :)

This revision now requires changes to proceed.Sep 7 2018, 4:50 PM
abetts added a subscriber: abetts.Sep 7 2018, 4:59 PM

Thank you for adopting the new layout. Please note that there may be instances when the center alignment of controls won't make visual sense. Let us know. However, it is looking great so far!

Add "General:" and a spacer.

Unique name for spacer (be in the safe side)

Awesome. Mind updating the screenshot?

No changes to “Misc.” from lasst screenshot.

Krita is a huge software and many parts can be enhanced visually. One may not be able to do everything alone, especially if he's changing something artists use :)
Now I have to fix some RTL bugs in customized controls.

ngraham accepted this revision.Sep 7 2018, 5:19 PM


This revision is now accepted and ready to land.Sep 7 2018, 5:19 PM
This revision was automatically updated to reflect the committed changes.