winterz (Allen Winter)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 30 2015, 4:43 PM (190 w, 2 d)
Availability
Available

Recent Activity

Sun, Apr 21

winterz committed R175:398e3dee7bbe: holiday_mu_en - Holidays 2019 in Mauritius (authored by winterz).
holiday_mu_en - Holidays 2019 in Mauritius
Sun, Apr 21, 2:56 PM
winterz committed R175:a09e8e1c682d: holiday_th_en-gb - update for 2019 (authored by winterz).
holiday_th_en-gb - update for 2019
Sun, Apr 21, 2:26 PM
winterz committed R175:e1acddf5cc10: Update Japanese holidays by N.Higa (authored by winterz).
Update Japanese holidays by N.Higa
Sun, Apr 21, 2:13 PM
winterz closed D20507: Update Japanese holidays.
Sun, Apr 21, 2:13 PM · KDE PIM
winterz committed R175:3b160fd9000b: Add public holidays for Lower Saxony (Germany) Committed for mmustac (authored by winterz).
Add public holidays for Lower Saxony (Germany) Committed for mmustac
Sun, Apr 21, 2:13 PM
winterz closed D20571: Add public holidays for Lower Saxony (Germany).
Sun, Apr 21, 2:13 PM · KDE PIM

Wed, Apr 17

winterz accepted D20642: calendarsupport does not depend on KIMAP, so don't search for it.

yes please

Wed, Apr 17, 8:06 PM · KDE PIM

Mon, Apr 15

winterz committed R172:ba28e5d36b0e: Fix some compiler warnings (authored by winterz).
Fix some compiler warnings
Mon, Apr 15, 12:28 PM
winterz closed D20547: KCalCore: Fix some compiler warnings.
Mon, Apr 15, 12:28 PM · KDE PIM

Sun, Apr 14

winterz updated the diff for D20547: KCalCore: Fix some compiler warnings.

remove commented out lines I added during testing

Sun, Apr 14, 4:27 PM · KDE PIM
winterz requested review of D20547: KCalCore: Fix some compiler warnings.
Sun, Apr 14, 4:26 PM · KDE PIM
winterz committed R172:2c8cab692dde: various - minor coding style improvements (authored by winterz).
various - minor coding style improvements
Sun, Apr 14, 3:38 PM
winterz committed R172:6528d0f0da50: calendar_p.h, utils.cpp, recurrencehelper_p.h - include guard (authored by winterz).
calendar_p.h, utils.cpp, recurrencehelper_p.h - include guard
Sun, Apr 14, 2:36 PM
winterz committed R172:fff709b91e8e: icalformat_p.h - remove ancient unnecessary TODO comment (authored by winterz).
icalformat_p.h - remove ancient unnecessary TODO comment
Sun, Apr 14, 2:36 PM

Sat, Apr 6

winterz committed R16:3aebd00dee90: .krazy - skip src/fs/fat12.cpp since it makes i18ncheckarg hang (authored by winterz).
.krazy - skip src/fs/fat12.cpp since it makes i18ncheckarg hang
Sat, Apr 6, 3:37 PM

Wed, Apr 3

winterz abandoned D20207: Avoid CollectionAclPage::save() crash.

goodie

Wed, Apr 3, 5:17 PM · KDE PIM

Tue, Apr 2

winterz requested review of D20207: Avoid CollectionAclPage::save() crash.
Tue, Apr 2, 4:21 PM · KDE PIM

Thu, Mar 28

winterz committed R459:58c437a5ec3a: contact-editor/.../CMakeLists.txt - don't build in nicknamewidget (authored by winterz).
contact-editor/.../CMakeLists.txt - don't build in nicknamewidget
Thu, Mar 28, 2:52 PM
winterz closed D20091: GeneralInfoEditor Test dll linkage.
Thu, Mar 28, 2:52 PM · KDE PIM
winterz accepted D19092: Add bison minimum version of 2.4.1 due to %code.

I'm for this.
I never created such a patch because I wasn't sure what minimum version was needed.

Thu, Mar 28, 2:21 PM · Frameworks
winterz requested review of D20091: GeneralInfoEditor Test dll linkage.
Thu, Mar 28, 1:50 PM · KDE PIM

Wed, Mar 27

winterz added a comment to D20079: Fix crash due to using an attribute from a collection that went out of scope.

I applied this patch locally for testing. so far so good.

Wed, Mar 27, 4:05 PM · KDE PIM

Mar 23 2019

winterz added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

this would be a nice addition to Krazy. on my todo list.

Mar 23 2019, 3:57 PM · Build System, Frameworks

Dec 30 2018

winterz closed D17792: Muslim (religious) holidays in Mauritius.
Dec 30 2018, 1:44 PM · KDE PIM
winterz committed R175:e53d2df3bf1e: holidays/plan2/holiday_mu_en - updated for 2019 (authored by winterz).
holidays/plan2/holiday_mu_en - updated for 2019
Dec 30 2018, 1:43 PM
winterz closed D17791: Holidays 2019 in Mauritius.
Dec 30 2018, 1:43 PM · KDE PIM

Dec 29 2018

winterz accepted D17792: Muslim (religious) holidays in Mauritius.

do you have commit access? If not I can commit for you

Dec 29 2018, 2:23 PM · KDE PIM
winterz accepted D17791: Holidays 2019 in Mauritius.

do you have commit access? If not I can commit for you

Dec 29 2018, 2:23 PM · KDE PIM

Dec 18 2018

winterz committed R175:6355859c6011: holiday_th_en-gb - update for 2019 (authored by winterz).
holiday_th_en-gb - update for 2019
Dec 18 2018, 10:35 PM

Dec 10 2018

winterz committed R81:cae534ca44d2: CMakeLists.txt - revert restoring the Hebrew plugin (authored by winterz).
CMakeLists.txt - revert restoring the Hebrew plugin
Dec 10 2018, 1:44 PM

Dec 9 2018

winterz committed R81:e2d95b5b5a11: Merge branch 'master' of https://anongit.kde.org/kdepim-addons (authored by winterz).
Merge branch 'master' of https://anongit.kde.org/kdepim-addons
Dec 9 2018, 8:14 PM
winterz committed R81:f4af74a7847a: plugins/hebrew - restore Jewish holidays KOrganizer plugin CMakeList.txt - find… (authored by winterz).
plugins/hebrew - restore Jewish holidays KOrganizer plugin CMakeList.txt - find…
Dec 9 2018, 8:14 PM
winterz committed R81:3893489872ce: CMakeList.txt - find KDELibs4Support, needed for Hebrew plugin (authored by winterz).
CMakeList.txt - find KDELibs4Support, needed for Hebrew plugin
Dec 9 2018, 8:10 PM
winterz committed R81:ac97505f1dc5: restore Jewish holidays KOrganizer plugin (authored by winterz).
restore Jewish holidays KOrganizer plugin
Dec 9 2018, 8:09 PM

Dec 4 2018

winterz committed R175:7e69d734c150: README.md - add basic instructions for testing holiday files (authored by winterz).
README.md - add basic instructions for testing holiday files
Dec 4 2018, 10:27 PM
winterz committed R175:f7c023459542: various calendars - fix syntax errors (authored by winterz).
various calendars - fix syntax errors
Dec 4 2018, 10:22 PM

Nov 29 2018

winterz committed R94:44b24d86f8c0: Merge branch 'Applications/18.12' (authored by winterz).
Merge branch 'Applications/18.12'
Nov 29 2018, 2:25 PM
winterz committed R94:32bbd45cdbbb: templateparserextracthtmlinfo.cpp - deleteLater in dtor (authored by winterz).
templateparserextracthtmlinfo.cpp - deleteLater in dtor
Nov 29 2018, 2:25 PM

Oct 31 2018

winterz added a comment to R210:709d5c4eb9c8: Patch from David Fries.

this patch breaks my geometry changes upon restart of korgac.

Oct 31 2018, 2:01 PM

Oct 28 2018

winterz added a comment to D16440: Provide OpenStreetMap links to location information in events [WIP].

Volker has a good point. Incidences can have geo coordinates so an even better idea is to provide location based on that.

Oct 28 2018, 5:23 PM · KDE PIM
winterz committed R175:e4ee7baf2c2e: Add Bahrain Holiday File (authored by winterz).
Add Bahrain Holiday File
Oct 28 2018, 5:08 PM
winterz closed D14753: [WIP] Add Bahrain Holiday File.
Oct 28 2018, 5:08 PM · KDE PIM
winterz added a comment to D14753: [WIP] Add Bahrain Holiday File.

I'll commit this for you.
it seems to work, at least as much as I can tell.

Oct 28 2018, 5:05 PM · KDE PIM

Oct 26 2018

winterz added a comment to D14753: [WIP] Add Bahrain Holiday File.

sorry, I completely missed this.
I'll take a look

Oct 26 2018, 4:06 PM · KDE PIM

Oct 25 2018

winterz committed R74:534aa592b4a0: clazy.cmake - provides a nice message if the user mistyped the checker name (authored by winterz).
clazy.cmake - provides a nice message if the user mistyped the checker name
Oct 25 2018, 9:07 PM
winterz closed D16195: Clazy: improved explanations.
Oct 25 2018, 9:06 PM

Oct 18 2018

winterz added a comment to D16300: Remove double underscore (__) from header include guards.

fyi, krazy in strict mode will check for leading and trailing underscores on the include guards.
I don't run krazy in strict mode on the EBN, however.

Oct 18 2018, 5:53 PM · Frameworks, Kate

Oct 15 2018

winterz updated the diff for D16195: Clazy: improved explanations.

rebased

Oct 15 2018, 12:21 PM

Oct 14 2018

winterz requested review of D16195: Clazy: improved explanations.
Oct 14 2018, 12:46 PM

Oct 10 2018

winterz added a comment to D16114: Fix keyboard editting of start/end times of VTODOs.
void KTimeComboBox::timeChanged (const QTime & time) [signal]
    Signal if the time has been changed either manually by the user or programatically.
Oct 10 2018, 8:20 PM · KDE PIM
winterz accepted D16114: Fix keyboard editting of start/end times of VTODOs.
Oct 10 2018, 8:12 PM · KDE PIM

Sep 30 2018

winterz requested review of D15854: Clazy: fix --list and --explain command line options.
Sep 30 2018, 12:10 PM

Sep 15 2018

winterz committed R175:3254245838b1: add Ivory Coast holidays (French) Thanks Lukas. seems to work from my limited… (authored by winterz).
add Ivory Coast holidays (French) Thanks Lukas. seems to work from my limited…
Sep 15 2018, 2:29 PM
winterz committed R175:eb1d23a58f90: holiday_hk_* - fix date for Tuen Ng Festival in 2019 BUG: 398670 FIXED-IN: 5.51. (authored by winterz).
holiday_hk_* - fix date for Tuen Ng Festival in 2019 BUG: 398670 FIXED-IN: 5.51.
Sep 15 2018, 2:18 PM

Aug 27 2018

winterz added a comment to D15092: Implement proper equinox and solstice calculation algorithm.

ship it!

Aug 27 2018, 3:20 PM · KDE PIM
winterz accepted D15092: Implement proper equinox and solstice calculation algorithm.

one last question. we are adding a static public method. should we increase the version number?

Aug 27 2018, 2:25 PM · KDE PIM
winterz added a comment to D15092: Implement proper equinox and solstice calculation algorithm.

Yay Dan!
add the @since and we're good to go

Aug 27 2018, 10:58 AM · KDE PIM

Aug 15 2018

winterz added a comment to D14853: Don't fetch missing parts from the resource..

Thank you David.
I can finally save in FatCRM again.

Aug 15 2018, 12:02 PM · KDE PIM

Aug 12 2018

winterz committed R175:7cb3167194b5: src/CMakeLists.txt - install headers the frameworks-way (authored by winterz).
src/CMakeLists.txt - install headers the frameworks-way
Aug 12 2018, 4:17 PM
winterz closed D14754: KHolidays: Install headers according to the frameworks way.
Aug 12 2018, 4:17 PM · KDE PIM
winterz updated the diff for D14754: KHolidays: Install headers according to the frameworks way.

the installed layout looks like this now:

Aug 12 2018, 2:29 PM · KDE PIM
winterz added a comment to D14754: KHolidays: Install headers according to the frameworks way.

I followed the example of KArchive
If KParts is the the better example I will change the patch accordingly.

Aug 12 2018, 12:43 PM · KDE PIM

Aug 11 2018

winterz requested review of D14754: KHolidays: Install headers according to the frameworks way.
Aug 11 2018, 11:15 PM · KDE PIM
winterz committed R79:44fda8c6cfca: src/kaevent.cpp - use CamelCase header for KHolidays (authored by winterz).
src/kaevent.cpp - use CamelCase header for KHolidays
Aug 11 2018, 11:14 PM

Aug 6 2018

winterz added a comment to D14585: avoid crash in MonitorPrivate::emitItemsNotification accessing empty list.

I would appreciate a quick resolution to this crash or at least a temporary commit of Martin's patch.
In the meantime I will commit locally so kontact doesn't crash every time I send an email.

Aug 6 2018, 1:49 PM · KDE PIM

Aug 2 2018

winterz added a comment to D14563: Add CLDR-based country to ISO code mapping.

no objections. looks ok to me.

Aug 2 2018, 7:31 PM · KDE PIM
winterz added inline comments to D14563: Add CLDR-based country to ISO code mapping.
Aug 2 2018, 5:33 PM · KDE PIM

Aug 1 2018

winterz accepted D14537: Install the sunrise/sunset computation header.

absolutely

Aug 1 2018, 4:14 PM · KDE PIM

Jul 31 2018

winterz added a comment to D14524: Fix compiler warning -Wimplicit-fallthrough.

agree that Q_FALLTHROUGH(); is a better idea.
it doesn't duplicate code and it informs the reader that the fallthrough is intentional

Jul 31 2018, 9:07 PM · Frameworks, Kate

Jul 21 2018

winterz committed R175:c3fca749a879: .gitignore - I like to see .diff files so I know if I have patches to apply (authored by winterz).
.gitignore - I like to see .diff files so I know if I have patches to apply
Jul 21 2018, 1:31 PM
winterz committed R175:8c49f9b3dfe2: more Japanese holiday updates from phanect (authored by winterz).
more Japanese holiday updates from phanect
Jul 21 2018, 1:30 PM
winterz closed D14154: re-add updates by Firas Kraiem.
Jul 21 2018, 1:30 PM · KDE PIM

Jul 9 2018

winterz added a comment to D13828: Revert "updated Japanese holidays (in Japanese and English)".

please close this

Jul 9 2018, 11:35 AM · KDE PIM

Jul 8 2018

winterz committed R175:1c2ecfbf9570: holiday_jp_ja, holiday_jp-en_us - updated Thanks for the patch phanect (authored by winterz).
holiday_jp_ja, holiday_jp-en_us - updated Thanks for the patch phanect
Jul 8 2018, 4:08 PM
winterz closed D13812: Revert "updated Japanese holidays (in Japanese and English)".
Jul 8 2018, 4:08 PM · KDE PIM

Jul 2 2018

winterz accepted D13857: Remove dead code.
Jul 2 2018, 7:28 PM · KDE PIM

Jun 6 2018

winterz committed R210:8ec9b5644744: searchdialog_base.ui - add missing tooltip and whatsthis (authored by winterz).
searchdialog_base.ui - add missing tooltip and whatsthis
Jun 6 2018, 12:30 PM

Jun 4 2018

winterz committed R175:a1a34ece1bbb: holidays/plan2/holiday_jp_* - add missing metainfo (authored by winterz).
holidays/plan2/holiday_jp_* - add missing metainfo
Jun 4 2018, 1:22 PM
winterz committed R210:2b752a8ca31b: src/prefs/koprefsdialog.cpp - allow clearing the Holiday region selector (authored by winterz).
src/prefs/koprefsdialog.cpp - allow clearing the Holiday region selector
Jun 4 2018, 12:49 PM

Jun 3 2018

winterz committed R175:49f6abb6035f: updated Japanese holidays (in Japanese and English) BUG: 365241 FIXED-IN: 5.48.0 (authored by winterz).
updated Japanese holidays (in Japanese and English) BUG: 365241 FIXED-IN: 5.48.0
Jun 3 2018, 5:54 PM
winterz committed R175:c7a676924c4d: holidays/plan2/holiday_th_en-gb - updated Thailand (UK English) for 2018 BUG… (authored by winterz).
holidays/plan2/holiday_th_en-gb - updated Thailand (UK English) for 2018 BUG…
Jun 3 2018, 5:30 PM
winterz committed R175:2ef82aef74c0: add Venezula holidays (Spanish) BUG: 334305 FIXED-IN: 5.48.0 (authored by winterz).
add Venezula holidays (Spanish) BUG: 334305 FIXED-IN: 5.48.0
Jun 3 2018, 5:18 PM
winterz committed R210:0f2d4b59cb37: various - now we can configure multiple holiday regions (authored by winterz).
various - now we can configure multiple holiday regions
Jun 3 2018, 4:57 PM
winterz committed R75:cd549ed30928: various - add support for multiple holiday regions (authored by winterz).
various - add support for multiple holiday regions
Jun 3 2018, 4:35 PM
winterz committed R76:f58efa19b9a5: various - support multiple holiday regions (authored by winterz).
various - support multiple holiday regions
Jun 3 2018, 4:15 PM
winterz accepted D13300: PimUniqueApplication: make newInstance virtual..
Jun 3 2018, 12:25 PM · KDE PIM

May 29 2018

winterz committed R210:6bf4b9d54097: Merge branch 'Applications/18.04' (authored by winterz).
Merge branch 'Applications/18.04'
May 29 2018, 5:39 PM
winterz committed R210:7a2df1e6ed39: koviewmanager.cpp - use the fallback when selecting the date for Day View BUG… (authored by winterz).
koviewmanager.cpp - use the fallback when selecting the date for Day View BUG…
May 29 2018, 5:37 PM

May 20 2018

winterz accepted D13002: Fix countryToISO() returning the local country for unknown country names.

I guess this QLocale::bcp47Name() is useless in this situation.

May 20 2018, 3:25 PM · KDE PIM
winterz committed R76:f0ffff73872e: timelabels.cpp - Don't call QList::first() on temporary (found by clazy) (authored by winterz).
timelabels.cpp - Don't call QList::first() on temporary (found by clazy)
May 20 2018, 1:59 PM
winterz committed R76:c49a4b43e3fb: src/agenda/agenda.cpp - const ref range-loop (found by clazy) (authored by winterz).
src/agenda/agenda.cpp - const ref range-loop (found by clazy)
May 20 2018, 1:59 PM

May 19 2018

winterz committed R76:de6b6c8d54d0: todo/todoviewquickaddline - rename returnPressed() slot (for clazy) (authored by winterz).
todo/todoviewquickaddline - rename returnPressed() slot (for clazy)
May 19 2018, 7:49 PM
winterz committed R76:ff98e501db24: src/agenda/calendardecoration.h - de-const some signals (found by clazy) (authored by winterz).
src/agenda/calendardecoration.h - de-const some signals (found by clazy)
May 19 2018, 7:48 PM
winterz committed R76:88d0381697f6: src/agenda/agenda.cpp - Q_EMIT showNewEventPopupSignal (found by clazy) minor… (authored by winterz).
src/agenda/agenda.cpp - Q_EMIT showNewEventPopupSignal (found by clazy) minor…
May 19 2018, 7:32 PM
winterz committed R76:e6c56731183c: src/eventview.h - eventDurationHint is not a SLOT (found by clazy) (authored by winterz).
src/eventview.h - eventDurationHint is not a SLOT (found by clazy)
May 19 2018, 7:32 PM
winterz committed R76:41f996cee34f: src/agenda/agendaview.cpp - removed unused variable found by clazy and some… (authored by winterz).
src/agenda/agendaview.cpp - removed unused variable found by clazy and some…
May 19 2018, 7:32 PM

May 18 2018

winterz committed R75:e632f9aa0ffb: calprinter.h - fix doPrint signature to use fully qualified slot args found by… (authored by winterz).
calprinter.h - fix doPrint signature to use fully qualified slot args found by…
May 18 2018, 10:07 PM
winterz committed R75:74c66cfe3004: src/printing/calprintpluginbase.cpp - restore code removed by accident clazy… (authored by winterz).
src/printing/calprintpluginbase.cpp - restore code removed by accident clazy…
May 18 2018, 10:07 PM
winterz committed R75:e4a09dc36a23: src/calendarutils.cpp - normalize a SLOT/SIGNAL (authored by winterz).
src/calendarutils.cpp - normalize a SLOT/SIGNAL
May 18 2018, 10:07 PM

May 12 2018

winterz committed R210:4ff4e1e932a4: views/collectionview/calendardelegate.cpp - show calendar tooltips (authored by winterz).
views/collectionview/calendardelegate.cpp - show calendar tooltips
May 12 2018, 8:32 PM