People winterz

winterz (Allen Winter)
User

Projects

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 30 2015, 4:43 PM (450 w, 5 d)
Availability
Available

Recent Activity
View All

Jun 11 2020

winterz committed R172:536b15fd6b2c: Check for write error in save() if the disk is full (authored by djarvie).
Check for write error in save() if the disk is full
Jun 11 2020, 5:59 AM
winterz committed R172:4cc61e2847d9: Check for write error in save() if the disk is full (authored by djarvie).
Check for write error in save() if the disk is full
Jun 11 2020, 5:59 AM
winterz committed R172:d5968e55d509: Correct icon names for recurring to-dos (authored by gjditchfield).
Correct icon names for recurring to-dos
Jun 11 2020, 5:58 AM
winterz committed R173:10d07e38d467: Merge Request feddback: better i18n for RTL languages; coding style (authored by gjditchfield).
Merge Request feddback: better i18n for RTL languages; coding style
Jun 11 2020, 3:57 AM
winterz committed R173:f412fd3bfcb0: Change include name to one Jenkins may understand (authored by gjditchfield).
Change include name to one Jenkins may understand
Jun 11 2020, 3:57 AM
winterz committed R173:d91d69d9c77f: Improve tool tips for to-dos (authored by gjditchfield).
Improve tool tips for to-dos
Jun 11 2020, 3:57 AM
winterz committed R173:d0d2c30657be: Improve tool tips for to-dos (authored by gjditchfield).
Improve tool tips for to-dos
Jun 11 2020, 3:57 AM

Jun 9 2020

winterz committed R206:0a9572ca759a: fix compile with Qt5.13 by including QDBusPendingCall (authored by winterz).
fix compile with Qt5.13 by including QDBusPendingCall
Jun 9 2020, 12:34 PM

May 30 2020

winterz committed R175:b8d529bdd253: holidayparserdriverplan.cpp,holidayscannerplan_p.h - update urls (authored by winterz).
holidayparserdriverplan.cpp,holidayscannerplan_p.h - update urls
May 30 2020, 5:17 PM
winterz committed R175:2bc88ac9fdd7: holidayparserdriverplan_p.h,holidayscannerplan_p.h - explicit ctors (authored by winterz).
holidayparserdriverplan_p.h,holidayscannerplan_p.h - explicit ctors
May 30 2020, 5:17 PM
winterz committed R175:911a380a4954: .krazy - remove a lot of unnecessary SKIPs (authored by winterz).
.krazy - remove a lot of unnecessary SKIPs
May 30 2020, 5:17 PM
winterz committed R241:60a4ccbe1ac6: src/widgets/imagefilter.cpp - fix a Krazy exclude (authored by winterz).
src/widgets/imagefilter.cpp - fix a Krazy exclude
May 30 2020, 3:28 PM

May 22 2020

winterz committed R81:05860c7e34c6: Merge branch 'bug/string-fixes' (authored by winterz).
Merge branch 'bug/string-fixes'
May 22 2020, 3:20 PM
winterz committed R733:c862ab31ae02: Revert "Fix clazy warning" (authored by winterz).
Revert "Fix clazy warning"
May 22 2020, 12:08 PM
winterz added a reverting change for R733:80d61bbda1ac: Fix clazy warning: R733:c862ab31ae02: Revert "Fix clazy warning".
May 22 2020, 12:08 PM

May 19 2020

winterz committed R94:c7c9276f636f: sendlater/sendlatertimedatewidget_p.h - fix compile (authored by winterz).
sendlater/sendlatertimedatewidget_p.h - fix compile
May 19 2020, 3:07 PM

May 18 2020

winterz committed R205:cd803e0ccc4a: src/lib/spinbox2.cpp - fix compile on Qt version < 5.14 (authored by winterz).
src/lib/spinbox2.cpp - fix compile on Qt version < 5.14
May 18 2020, 2:54 PM

May 17 2020

winterz committed R210:bfc435f52a3f: README.md - add a basic intro README (authored by winterz).
README.md - add a basic intro README
May 17 2020, 7:24 PM
winterz committed R210:7785796dce65: logo.png - Add the application icon for gitlab (authored by winterz).
logo.png - Add the application icon for gitlab
May 17 2020, 3:22 PM

May 14 2020

winterz added a comment to D29754: Add memory to includes.

never mind.
I just commited a fix in 76f4c097e9661ff893abd227efef5cd2316b44a9

May 14 2020, 7:56 PM · KDE PIM
winterz committed R94:76f4c097e966: followupreminderselectdatedialog.h - include <memory> (authored by winterz).
followupreminderselectdatedialog.h - include <memory>
May 14 2020, 7:56 PM
winterz added a comment to D29754: Add memory to includes.

can you commit this ASAP? I'm getting the same compile error.

May 14 2020, 7:52 PM · KDE PIM

May 13 2020

winterz committed R175:b1291acbfc09: Update Taiwanese holidays (authored by nhiga).
Update Taiwanese holidays
May 13 2020, 10:14 PM
winterz closed D29223: Update Taiwanese holidays.
May 13 2020, 10:14 PM · Frameworks, KDE PIM
winterz committed R78:cea869f3b6a4: incidencedialog.cpp - ask to set a default events folder. (authored by winterz).
incidencedialog.cpp - ask to set a default events folder.
May 13 2020, 7:40 PM
winterz closed D29725: incidencedialog.cpp - ask to set a default events folder..
May 13 2020, 7:40 PM · KDE PIM
winterz updated the summary of D29725: incidencedialog.cpp - ask to set a default events folder..
May 13 2020, 4:47 PM · KDE PIM
winterz added a reviewer for D29725: incidencedialog.cpp - ask to set a default events folder.: mlaurent.
May 13 2020, 4:45 PM · KDE PIM
winterz requested review of D29725: incidencedialog.cpp - ask to set a default events folder..
May 13 2020, 4:40 PM · KDE PIM

May 12 2020

winterz committed R75:98cd8632cd7a: utils.cpp - handle ICalDrag::populateMimeData return value (authored by winterz).
utils.cpp - handle ICalDrag::populateMimeData return value
May 12 2020, 7:33 PM
winterz committed R75:7fa4ab6d9b7e: utils.[cpp,h] - clean includes (authored by winterz).
utils.[cpp,h] - clean includes
May 12 2020, 7:33 PM
winterz accepted D29677: korgac: re-add 10 days check.
May 12 2020, 2:24 PM · KDE PIM
winterz accepted D29360: korgac: on first run, show alarms from the last 10 days..

thanks David.

May 12 2020, 1:04 PM · KDE PIM

May 11 2020

winterz committed R210:964e43d5f23e: koprefsdialog.cpp - less clutter in holidays combobox (authored by winterz).
koprefsdialog.cpp - less clutter in holidays combobox
May 11 2020, 1:15 PM
winterz closed D29576: koprefsdialog.cpp - less clutter in holidays combobox.
May 11 2020, 1:15 PM · KDE PIM
winterz committed R175:7f7533260efc: holidayregion.cpp - provide translatable strings for the German regions. (authored by winterz).
holidayregion.cpp - provide translatable strings for the German regions.
May 11 2020, 1:15 PM
winterz closed D29575: holidayregion.cpp - provide translatable strings for the German regions..
May 11 2020, 1:15 PM · Frameworks

May 10 2020

winterz added a comment to D29223: Update Taiwanese holidays.

all opposed to this patch please speak up soon

May 10 2020, 2:11 PM · Frameworks, KDE PIM
winterz updated the diff for D29575: holidayregion.cpp - provide translatable strings for the German regions..

QLatin1-ify

May 10 2020, 2:02 PM · Frameworks

May 9 2020

winterz updated the diff for D29576: koprefsdialog.cpp - less clutter in holidays combobox.

remove bogus line I pasted in by mistake

May 9 2020, 9:44 PM · KDE PIM
winterz updated the diff for D29575: holidayregion.cpp - provide translatable strings for the German regions..

don't try to provide translatable string for unknown subdivisions

May 9 2020, 9:43 PM · Frameworks
winterz requested review of D29576: koprefsdialog.cpp - less clutter in holidays combobox.
May 9 2020, 9:32 PM · KDE PIM
winterz added a comment to D29575: holidayregion.cpp - provide translatable strings for the German regions..

I'm guessing it's ok to depend on K5I18N ?

May 9 2020, 9:23 PM · Frameworks
winterz requested review of D29575: holidayregion.cpp - provide translatable strings for the German regions..
May 9 2020, 9:21 PM · Frameworks
winterz committed R175:8b3f65ed1f40: holidays_de-foo - set name field for all German holiday files (authored by winterz).
holidays_de-foo - set name field for all German holiday files
May 9 2020, 9:15 PM
winterz committed R175:4bdc6f618e77: holiday-de-<foo> - where foo is a region is Germany (authored by winterz).
holiday-de-<foo> - where foo is a region is Germany
May 9 2020, 9:15 PM

May 8 2020

winterz accepted D29531: Add --view option to open contact.

(minor) English to be consistent with the incidence view mode in KOrganizer. otherwise good to go.

May 8 2020, 9:02 PM · KDE PIM
winterz accepted D29543: Import UriHandler code from KdepimDBusInterfaces.
May 8 2020, 8:53 PM · KDE PIM
winterz added inline comments to D29543: Import UriHandler code from KdepimDBusInterfaces.
May 8 2020, 7:47 PM · KDE PIM
winterz accepted D29530: Add --view option to display incidence.

(minor) English wording could be improved a bit. otherwise lgtm

May 8 2020, 2:45 PM · KDE PIM

May 7 2020

winterz committed R74:ff9df02d41a7: Merge branch '1.6' (authored by winterz).
Merge branch '1.6'
May 7 2020, 8:41 PM
winterz closed D29348: clazy.cmake - don't print level3 checker list.
May 7 2020, 8:41 PM
winterz committed R74:85527221ebbe: clazy.cmake - don't print level3 checker list (authored by winterz).
clazy.cmake - don't print level3 checker list
May 7 2020, 8:41 PM
winterz abandoned D29349: clazy.cmake - make it a bash script.

@smartins told me that @aacid will do the right thing and turn the bash code into general shell code

May 7 2020, 8:36 PM

May 6 2020

winterz added a comment to D29416: Show all available holiday regions.

I understand the motivation for this change. However, it is pretty ugly and verbose.

May 6 2020, 8:02 PM · KDE PIM

May 4 2020

winterz added a comment to D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday.

I committed this one for Weisi Dai

May 4 2020, 10:20 PM · Frameworks
winterz committed R175:682b18f75ca7: holidays/plan2/holiday_gb-sct_en-gb (authored by weisi).
holidays/plan2/holiday_gb-sct_en-gb
May 4 2020, 10:19 PM
winterz closed D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday.
May 4 2020, 10:19 PM · Frameworks
winterz accepted D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday.

do you need me to commit this for you?

May 4 2020, 9:36 PM · Frameworks
winterz accepted D29415: Add holiday file for DE-BE (Germany/Berlin).

I don't know German and I don't know the Berlin holidays.
but the tests pass and in general things look fine.

May 4 2020, 9:32 PM · Frameworks

May 2 2020

winterz planned changes to D29349: clazy.cmake - make it a bash script.

I'm having second thoughts about this. perhaps converting the bash code to generic shell is best.

May 2 2020, 1:08 PM

May 1 2020

winterz updated subscribers of D29349: clazy.cmake - make it a bash script.
May 1 2020, 7:40 PM
winterz requested review of D29349: clazy.cmake - make it a bash script.
May 1 2020, 7:40 PM
winterz updated subscribers of D29348: clazy.cmake - don't print level3 checker list.
May 1 2020, 7:36 PM
winterz requested review of D29348: clazy.cmake - don't print level3 checker list.
May 1 2020, 7:36 PM

Apr 18 2020

winterz committed R210:be8662babac5: alarmdialog - clean includes (authored by winterz).
alarmdialog - clean includes
Apr 18 2020, 9:22 PM
winterz committed R210:a51fcc52aaaa: src/akonadicollectionview.cpp - remove dead code (authored by winterz).
src/akonadicollectionview.cpp - remove dead code
Apr 18 2020, 9:22 PM
winterz committed R210:5390a5902c48: alarmdialog - remove Suspend Duration save/restore/set/reset (authored by winterz).
alarmdialog - remove Suspend Duration save/restore/set/reset
Apr 18 2020, 8:12 PM
winterz committed R210:586506667f25: akonadicollectionview.cpp - add some KUIT and minor cleaning (authored by winterz).
akonadicollectionview.cpp - add some KUIT and minor cleaning
Apr 18 2020, 5:24 PM
winterz committed R170:32cb293c766e: Akonadi Calendar Standard Actions: s/Calendar Folder/Folder/ (authored by winterz).
Akonadi Calendar Standard Actions: s/Calendar Folder/Folder/
Apr 18 2020, 5:21 PM
winterz closed D28948: Akonadi Calendar Standard Actions: use "Folder" instead of "Calendar Folder".
Apr 18 2020, 5:21 PM · KDE PIM
winterz committed R210:feda10e9f15b: akonadicollectionview.cpp - "Set as Default Folder" (authored by winterz).
akonadicollectionview.cpp - "Set as Default Folder"
Apr 18 2020, 4:58 PM
winterz committed R210:2376c61f3541: rearrange the collectionview_contextmenu items (authored by winterz).
rearrange the collectionview_contextmenu items
Apr 18 2020, 4:52 PM
winterz added a comment to D28948: Akonadi Calendar Standard Actions: use "Folder" instead of "Calendar Folder".

my first time using 'arc'.

Apr 18 2020, 4:37 PM · KDE PIM
winterz added reviewers for D28948: Akonadi Calendar Standard Actions: use "Folder" instead of "Calendar Folder": dfaure, mlaurent, dvratil, vkrause.
Apr 18 2020, 4:36 PM · KDE PIM
winterz requested review of D28948: Akonadi Calendar Standard Actions: use "Folder" instead of "Calendar Folder".
Apr 18 2020, 4:34 PM · KDE PIM
winterz accepted D28943: KOrganizer: remove "Disable Color", simplify contextmenu structure.
Apr 18 2020, 2:25 PM
winterz added a comment to D28775: [KJots] Fix bookmarks actions.

Would you like to take over maintainership for KJots? I thought KJots was in the unmaintained pile.

Apr 18 2020, 12:55 PM · KDE PIM

Apr 17 2020

winterz added a comment to D28874: Taiwanese holidays.
In D28874#650661, @ngraham wrote:

Do you not have commit access? I thought you were the maintainer based on the repo's history!

Yes of course.
I'm asking for assistance at this time.

Apr 17 2020, 9:41 PM · Frameworks
winterz accepted D28891: Nicaragua Holidays.

other than the indentation in the .qrc file this is good to go.. tests pass

Apr 17 2020, 6:56 PM · Frameworks
winterz accepted D28874: Taiwanese holidays.

looks good. all tests pass.

Apr 17 2020, 6:53 PM · Frameworks
winterz added a comment to D28874: Taiwanese holidays.

remove holidays/0001-added-holiday_tw_zh-and-updated-holiday.qrc.patch

Apr 17 2020, 3:10 PM · Frameworks
winterz added inline comments to D28891: Nicaragua Holidays.
Apr 17 2020, 3:09 PM · Frameworks

Apr 16 2020

winterz added a comment to D28874: Taiwanese holidays.

problems:

  • "religous" should be "religious"
  • missing ':' at the start of Constitution Day
    • missing ':' at the start of Christmas Day
Apr 16 2020, 3:38 PM · Frameworks
winterz requested changes to D28874: Taiwanese holidays.

testing fails. don't know why yet.

Apr 16 2020, 3:30 PM · Frameworks
winterz added a comment to D28759: Akonadi-contacts: define BUILD_TESTING in order that CONTACTEDITOR_TESTS_EXPORT is properly defined.

ping. we need to get this sorted. the CI is complaining daily about the broken build on Windows

Apr 16 2020, 2:30 PM · KDE PIM
winterz added a comment to D28874: Taiwanese holidays.

you need to add the change to holidays.qrc to this patch

Apr 16 2020, 2:02 PM · Frameworks

Apr 15 2020

winterz added a comment to D28846: KOrganizer: port from KRun::runCommand to KIO::CommandLauncherJob.

set KF5_VERSION to 5.69.50 in the frameworks library and require that version in korganizer?

Apr 15 2020, 12:08 PM · KDE PIM

Apr 14 2020

winterz added a comment to D28834: Add metadata properties to calendar.

I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now

Apr 14 2020, 7:04 PM · KDE PIM
winterz accepted D28834: Add metadata properties to calendar.
Apr 14 2020, 6:57 PM · KDE PIM
winterz added a comment to D28834: Add metadata properties to calendar.

looks good.
nice touch using Q_EMIT.

Apr 14 2020, 6:47 PM · KDE PIM

Apr 12 2020

winterz updated the diff for D28759: Akonadi-contacts: define BUILD_TESTING in order that CONTACTEDITOR_TESTS_EXPORT is properly defined.
Apr 12 2020, 11:25 AM · KDE PIM

Apr 11 2020

winterz requested review of D28759: Akonadi-contacts: define BUILD_TESTING in order that CONTACTEDITOR_TESTS_EXPORT is properly defined.
Apr 11 2020, 4:21 PM · KDE PIM

Apr 8 2020

winterz added a comment to D28134: Add ColorUtils.
In D28134#643899, @kossebau wrote:

Seems to no be compatible with Qt 5.12, see failing on CI: https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console

Apr 8 2020, 11:29 AM · Kirigami

Apr 4 2020

winterz accepted D28567: Fix typo in D-Bus path.
Apr 4 2020, 4:45 PM · KDE PIM

Apr 2 2020

winterz accepted D28436: [IncidenceTreeModel] Update UID if it was changed.

The code is ok. I admit I don't understand how this could happen. Google is changing the UID?

Apr 2 2020, 9:02 PM · KDE PIM
winterz committed R210:4cbe9e49b171: Merge branch 'release/20.04' (authored by winterz).
Merge branch 'release/20.04'
Apr 2 2020, 3:58 PM
winterz committed R210:99151643d735: fix crashing dialogs for Category and Filter managers (authored by winterz).
fix crashing dialogs for Category and Filter managers
Apr 2 2020, 3:57 PM
winterz committed R210:ab0fde6786e3: actionmanager - adding lots of tooltip, statustip, whatsthis (authored by winterz).
actionmanager - adding lots of tooltip, statustip, whatsthis
Apr 2 2020, 12:05 PM

Mar 30 2020

winterz closed D28361: KCalendarCore: fix fallback to vCalendar loading on iCalendar load failure.
Mar 30 2020, 9:54 PM · KDE PIM