winterz (Allen Winter)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 30 2015, 4:43 PM (207 w, 4 d)
Availability
Available

Recent Activity

Jul 19 2019

winterz committed R206:201eac97eba5: summaryview_part.h - fix build by including QMap (authored by winterz).
summaryview_part.h - fix build by including QMap
Jul 19 2019, 4:59 PM

Jul 18 2019

winterz committed R206:28a8cf907b3c: summaryview_part.h - fix build by including QMap (authored by winterz).
summaryview_part.h - fix build by including QMap
Jul 18 2019, 7:35 PM
winterz committed R286:67c57a042458: taglibextractortest.cpp - fix build with include <QSet> (authored by winterz).
taglibextractortest.cpp - fix build with include <QSet>
Jul 18 2019, 7:04 PM

Jun 19 2019

winterz added a comment to D21464: IMAP: Option to use system proxy settings (Configuration and GUI).

can you update the kmail docbook accordingly?

Jun 19 2019, 1:08 PM · KDE PIM

Jun 10 2019

winterz added a comment to D21737: Fix infinite loop when mThreadingCache is 'corrupted'.

tested locally and it works fine!
+1 from me.

Jun 10 2019, 9:39 PM · KDE PIM
winterz added a comment to D21737: Fix infinite loop when mThreadingCache is 'corrupted'.

I have a folder that always goes into infiinite loop mode. I can test this

Jun 10 2019, 9:31 PM · KDE PIM

Jun 6 2019

winterz accepted D21625: Allow parts (like kmail) to set a custom caption in guiActivateEvent.

yay

Jun 6 2019, 4:51 PM · KDE PIM
winterz accepted D21626: Fix kontact crash on logout..
Jun 6 2019, 4:51 PM · KDE PIM

May 30 2019

winterz accepted D21498: Make KCalCore::Person a Q_GADGET.
May 30 2019, 9:47 PM · KDE PIM
winterz accepted D21215: Create second-type duration for 0 delay durations in ical format..

should be ok.
no objections.

May 30 2019, 9:43 PM · KDE PIM

May 21 2019

winterz committed R165:983f44d880c9: src/server/storage/dbconfigpostgresql.cpp - fix compile (authored by winterz).
src/server/storage/dbconfigpostgresql.cpp - fix compile
May 21 2019, 5:10 PM

May 15 2019

winterz accepted D21223: Put the IM protocol files into a QResource.

Yep. tested locally and fixes the problem

May 15 2019, 1:28 PM · KDE PIM

May 13 2019

winterz accepted D21101: Don't inherit Attendee from Person.

agree that fullName() -> aBetterName() change should go into a separate patch.
+1

May 13 2019, 4:17 PM · KDE PIM

May 12 2019

winterz added a comment to D21158: Replace sprintf with QString::asprintf.

also see this crash in impptest

May 12 2019, 9:04 PM · KDE PIM
winterz added a comment to D21160: Replace sprintf with QString::asprintf.

I've also been seeing those test failures for a long time.
seems to break if you aren't in the CET timezone (or somesuch). Harmless, but annoying.

May 12 2019, 9:03 PM · KDE PIM

May 9 2019

winterz added a comment to D21101: Don't inherit Attendee from Person.

deprecate fullName() and replace with fullEmail()?

May 9 2019, 8:25 PM · KDE PIM

May 6 2019

winterz committed R172:81ff0ed3fcfe: various clang-tidy fixes (authored by winterz).
various clang-tidy fixes
May 6 2019, 9:07 PM
winterz closed D21036: KCalCore: Misc clang-tidy fixes.
May 6 2019, 9:07 PM · KDE PIM
winterz committed R174:60ff2f4633c6: various - clang-tidy fixes (authored by winterz).
various - clang-tidy fixes
May 6 2019, 9:06 PM
winterz closed D21051: KContacts - clang-tidy fixes.
May 6 2019, 9:06 PM · KDE PIM
winterz updated the summary of D21051: KContacts - clang-tidy fixes.
May 6 2019, 9:03 PM · KDE PIM
winterz requested review of D21051: KContacts - clang-tidy fixes.
May 6 2019, 5:37 PM · KDE PIM
winterz updated the diff for D21036: KCalCore: Misc clang-tidy fixes.

remove unnecssary clang-analyzer-optin.cplusplus.VirtualCall fixes and add NOLINT comments so clang-tidy ignores them

May 6 2019, 5:02 PM · KDE PIM
winterz added a comment to D21036: KCalCore: Misc clang-tidy fixes.

Well, technically, calling virtual methods from ctor in dtor in those particular cases is safe and your changes do not have any impact, since the standard says that when a ctor/dtor calls a virtual function of the object currently under construction/destruction the override called is that of the current ctor's/dtor's class - in other words, it will never call an override in a more-derived class (and calling an override in a superclass is safe, because that one is already constructed/not yet destroyed). This would only be a problem (or undefined behavior, rather) if any of those methods were pure virtual, which they are not so this might be considered a false-positive from clazy.

Edit: there's also some trickyness in this when non-linear inheritance in involved, but that's not the case here either.

May 6 2019, 3:48 PM · KDE PIM

May 5 2019

winterz requested review of D21036: KCalCore: Misc clang-tidy fixes.
May 5 2019, 5:45 PM · KDE PIM
winterz closed D21016: KCalCore : Clang-Tidy performance-unnecessary-copy-init fixes.
May 5 2019, 1:44 PM · KDE PIM
winterz committed R172:6ec370096c1a: Clang-Tidy performance-unnecessary-copy-init fixes (authored by winterz).
Clang-Tidy performance-unnecessary-copy-init fixes
May 5 2019, 1:44 PM

May 4 2019

winterz committed R477:22b347c65e78: src/saslplugin/config.h - remove unneeded strtol config (authored by winterz).
src/saslplugin/config.h - remove unneeded strtol config
May 4 2019, 4:57 PM
winterz committed R44:52eab15d70e1: resources/gmail/saslplugin/config.h - remove unused strol check (authored by winterz).
resources/gmail/saslplugin/config.h - remove unused strol check
May 4 2019, 4:48 PM
winterz requested review of D21016: KCalCore : Clang-Tidy performance-unnecessary-copy-init fixes.
May 4 2019, 4:21 PM · KDE PIM
winterz committed R172:b8b0e6ed0b1a: various - clazy fixes (authored by winterz).
various - clazy fixes
May 4 2019, 3:12 PM
winterz closed D20881: KCalCore Clazy fixes.
May 4 2019, 3:12 PM · KDE PIM

May 3 2019

winterz committed R172:1a701d11317f: .gitignore -- I like to see .diff's (they could be patches) (authored by winterz).
.gitignore -- I like to see .diff's (they could be patches)
May 3 2019, 7:14 PM
winterz added a comment to D20881: KCalCore Clazy fixes.

ping

May 3 2019, 4:15 PM · KDE PIM

May 2 2019

winterz committed R174:0636ad0859d4: various - fix compile warnings dealing with Q_REQUIRED_RESULT (authored by winterz).
various - fix compile warnings dealing with Q_REQUIRED_RESULT
May 2 2019, 9:54 PM
winterz closed D20945: KContacts - fix compile warnings .
May 2 2019, 9:54 PM · KDE PIM
winterz added inline comments to D20945: KContacts - fix compile warnings .
May 2 2019, 3:30 PM · KDE PIM
winterz updated the diff for D20945: KContacts - fix compile warnings .

Pino's suggestion
added tests

May 2 2019, 2:02 PM · KDE PIM
winterz added inline comments to D20945: KContacts - fix compile warnings .
May 2 2019, 11:57 AM · KDE PIM

May 1 2019

winterz requested review of D20945: KContacts - fix compile warnings .
May 1 2019, 8:59 PM · KDE PIM
winterz committed R175:b7cd6a04b0a0: holidays/plan2/holiday_zm_en-gb - add Zambia holidays (authored by winterz).
holidays/plan2/holiday_zm_en-gb - add Zambia holidays
May 1 2019, 2:56 PM
winterz committed R175:a80ebde8aac3: holidays/plan2/holiday_lv_lv - fix Midsummer's Day (authored by winterz).
holidays/plan2/holiday_lv_lv - fix Midsummer's Day
May 1 2019, 2:56 PM
winterz closed D20928: Fixed/added Midsummer's Day in holiday_lv_lv.
May 1 2019, 2:56 PM · KDE PIM
winterz accepted D20932: Remove the copy of Akonadi's supertrait.h.

I'll assume you rebuilt all of kde pim ok

May 1 2019, 1:55 PM · KDE PIM

Apr 30 2019

winterz updated the diff for D20881: KCalCore Clazy fixes.

missing changes for QLatin1String()
thanks for noticing Achim

Apr 30 2019, 7:28 PM · KDE PIM
winterz committed R94:62112cbe4a0d: messageviewer.kcfg.cmake - DeleteInvitationEmailsAfterSendingReply default=false (authored by winterz).
messageviewer.kcfg.cmake - DeleteInvitationEmailsAfterSendingReply default=false
Apr 30 2019, 3:36 PM
winterz closed D20922: Messagelib - change default for DeleteInvitationEmailsAfterSendingReply.
Apr 30 2019, 3:36 PM · KDE PIM
winterz requested review of D20922: Messagelib - change default for DeleteInvitationEmailsAfterSendingReply.
Apr 30 2019, 1:16 PM · KDE PIM

Apr 29 2019

winterz updated the diff for D20881: KCalCore Clazy fixes.

Dan's comments and suggestions

Apr 29 2019, 10:12 PM · KDE PIM
winterz added inline comments to D20881: KCalCore Clazy fixes.
Apr 29 2019, 10:01 PM · KDE PIM
winterz added a comment to D20881: KCalCore Clazy fixes.

I will fix those 'auto' variables. I had planned a clang-tidy round of cleanups, but I can do the auto stuff here.
your other suggestions are also good. I'll handle them.

Apr 29 2019, 7:19 PM · KDE PIM

Apr 28 2019

winterz requested review of D20881: KCalCore Clazy fixes.
Apr 28 2019, 5:26 PM · KDE PIM

Apr 24 2019

winterz committed R44:573041c909b0: CMakeLists.txt - improve description for xdg generation option (authored by winterz).
CMakeLists.txt - improve description for xdg generation option
Apr 24 2019, 12:39 PM
winterz committed R165:83bb78832580: CMakeLists.txt - improve description for xdg generation option (authored by winterz).
CMakeLists.txt - improve description for xdg generation option
Apr 24 2019, 12:32 PM

Apr 21 2019

winterz committed R175:398e3dee7bbe: holiday_mu_en - Holidays 2019 in Mauritius (authored by winterz).
holiday_mu_en - Holidays 2019 in Mauritius
Apr 21 2019, 2:56 PM
winterz committed R175:a09e8e1c682d: holiday_th_en-gb - update for 2019 (authored by winterz).
holiday_th_en-gb - update for 2019
Apr 21 2019, 2:26 PM
winterz committed R175:e1acddf5cc10: Update Japanese holidays by N.Higa (authored by winterz).
Update Japanese holidays by N.Higa
Apr 21 2019, 2:13 PM
winterz closed D20507: Update Japanese holidays.
Apr 21 2019, 2:13 PM · KDE PIM
winterz committed R175:3b160fd9000b: Add public holidays for Lower Saxony (Germany) Committed for mmustac (authored by winterz).
Add public holidays for Lower Saxony (Germany) Committed for mmustac
Apr 21 2019, 2:13 PM
winterz closed D20571: Add public holidays for Lower Saxony (Germany).
Apr 21 2019, 2:13 PM · KDE PIM

Apr 17 2019

winterz accepted D20642: calendarsupport does not depend on KIMAP, so don't search for it.

yes please

Apr 17 2019, 8:06 PM · KDE PIM

Apr 15 2019

winterz committed R172:ba28e5d36b0e: Fix some compiler warnings (authored by winterz).
Fix some compiler warnings
Apr 15 2019, 12:28 PM
winterz closed D20547: KCalCore: Fix some compiler warnings.
Apr 15 2019, 12:28 PM · KDE PIM

Apr 14 2019

winterz updated the diff for D20547: KCalCore: Fix some compiler warnings.

remove commented out lines I added during testing

Apr 14 2019, 4:27 PM · KDE PIM
winterz requested review of D20547: KCalCore: Fix some compiler warnings.
Apr 14 2019, 4:26 PM · KDE PIM
winterz committed R172:2c8cab692dde: various - minor coding style improvements (authored by winterz).
various - minor coding style improvements
Apr 14 2019, 3:38 PM
winterz committed R172:6528d0f0da50: calendar_p.h, utils.cpp, recurrencehelper_p.h - include guard (authored by winterz).
calendar_p.h, utils.cpp, recurrencehelper_p.h - include guard
Apr 14 2019, 2:36 PM
winterz committed R172:fff709b91e8e: icalformat_p.h - remove ancient unnecessary TODO comment (authored by winterz).
icalformat_p.h - remove ancient unnecessary TODO comment
Apr 14 2019, 2:36 PM

Apr 6 2019

winterz committed R16:3aebd00dee90: .krazy - skip src/fs/fat12.cpp since it makes i18ncheckarg hang (authored by winterz).
.krazy - skip src/fs/fat12.cpp since it makes i18ncheckarg hang
Apr 6 2019, 3:37 PM

Apr 3 2019

winterz abandoned D20207: Avoid CollectionAclPage::save() crash.

goodie

Apr 3 2019, 5:17 PM · KDE PIM

Apr 2 2019

winterz requested review of D20207: Avoid CollectionAclPage::save() crash.
Apr 2 2019, 4:21 PM · KDE PIM

Mar 28 2019

winterz committed R459:58c437a5ec3a: contact-editor/.../CMakeLists.txt - don't build in nicknamewidget (authored by winterz).
contact-editor/.../CMakeLists.txt - don't build in nicknamewidget
Mar 28 2019, 2:52 PM
winterz closed D20091: GeneralInfoEditor Test dll linkage.
Mar 28 2019, 2:52 PM · KDE PIM
winterz accepted D19092: Add bison minimum version of 2.4.1 due to %code.

I'm for this.
I never created such a patch because I wasn't sure what minimum version was needed.

Mar 28 2019, 2:21 PM · Frameworks
winterz requested review of D20091: GeneralInfoEditor Test dll linkage.
Mar 28 2019, 1:50 PM · KDE PIM

Mar 27 2019

winterz added a comment to D20079: Fix crash due to using an attribute from a collection that went out of scope.

I applied this patch locally for testing. so far so good.

Mar 27 2019, 4:05 PM · KDE PIM

Mar 23 2019

winterz added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

this would be a nice addition to Krazy. on my todo list.

Mar 23 2019, 3:57 PM · Build System, Frameworks

Dec 30 2018

winterz closed D17792: Muslim (religious) holidays in Mauritius.
Dec 30 2018, 1:44 PM · KDE PIM
winterz committed R175:e53d2df3bf1e: holidays/plan2/holiday_mu_en - updated for 2019 (authored by winterz).
holidays/plan2/holiday_mu_en - updated for 2019
Dec 30 2018, 1:43 PM
winterz closed D17791: Holidays 2019 in Mauritius.
Dec 30 2018, 1:43 PM · KDE PIM

Dec 29 2018

winterz accepted D17792: Muslim (religious) holidays in Mauritius.

do you have commit access? If not I can commit for you

Dec 29 2018, 2:23 PM · KDE PIM
winterz accepted D17791: Holidays 2019 in Mauritius.

do you have commit access? If not I can commit for you

Dec 29 2018, 2:23 PM · KDE PIM

Dec 18 2018

winterz committed R175:6355859c6011: holiday_th_en-gb - update for 2019 (authored by winterz).
holiday_th_en-gb - update for 2019
Dec 18 2018, 10:35 PM

Dec 10 2018

winterz committed R81:cae534ca44d2: CMakeLists.txt - revert restoring the Hebrew plugin (authored by winterz).
CMakeLists.txt - revert restoring the Hebrew plugin
Dec 10 2018, 1:44 PM

Dec 9 2018

winterz committed R81:e2d95b5b5a11: Merge branch 'master' of https://anongit.kde.org/kdepim-addons (authored by winterz).
Merge branch 'master' of https://anongit.kde.org/kdepim-addons
Dec 9 2018, 8:14 PM
winterz committed R81:f4af74a7847a: plugins/hebrew - restore Jewish holidays KOrganizer plugin CMakeList.txt - find… (authored by winterz).
plugins/hebrew - restore Jewish holidays KOrganizer plugin CMakeList.txt - find…
Dec 9 2018, 8:14 PM
winterz committed R81:3893489872ce: CMakeList.txt - find KDELibs4Support, needed for Hebrew plugin (authored by winterz).
CMakeList.txt - find KDELibs4Support, needed for Hebrew plugin
Dec 9 2018, 8:10 PM
winterz committed R81:ac97505f1dc5: restore Jewish holidays KOrganizer plugin (authored by winterz).
restore Jewish holidays KOrganizer plugin
Dec 9 2018, 8:09 PM

Dec 4 2018

winterz committed R175:7e69d734c150: README.md - add basic instructions for testing holiday files (authored by winterz).
README.md - add basic instructions for testing holiday files
Dec 4 2018, 10:27 PM
winterz committed R175:f7c023459542: various calendars - fix syntax errors (authored by winterz).
various calendars - fix syntax errors
Dec 4 2018, 10:22 PM

Nov 29 2018

winterz committed R94:44b24d86f8c0: Merge branch 'Applications/18.12' (authored by winterz).
Merge branch 'Applications/18.12'
Nov 29 2018, 2:25 PM
winterz committed R94:32bbd45cdbbb: templateparserextracthtmlinfo.cpp - deleteLater in dtor (authored by winterz).
templateparserextracthtmlinfo.cpp - deleteLater in dtor
Nov 29 2018, 2:25 PM

Oct 31 2018

winterz added a comment to R210:709d5c4eb9c8: Patch from David Fries.

this patch breaks my geometry changes upon restart of korgac.

Oct 31 2018, 2:01 PM

Oct 28 2018

winterz added a comment to D16440: Provide OpenStreetMap links to location information in events [WIP].

Volker has a good point. Incidences can have geo coordinates so an even better idea is to provide location based on that.

Oct 28 2018, 5:23 PM · KDE PIM
winterz committed R175:e4ee7baf2c2e: Add Bahrain Holiday File (authored by winterz).
Add Bahrain Holiday File
Oct 28 2018, 5:08 PM
winterz closed D14753: [WIP] Add Bahrain Holiday File.
Oct 28 2018, 5:08 PM · KDE PIM
winterz added a comment to D14753: [WIP] Add Bahrain Holiday File.

I'll commit this for you.
it seems to work, at least as much as I can tell.

Oct 28 2018, 5:05 PM · KDE PIM

Oct 26 2018

winterz added a comment to D14753: [WIP] Add Bahrain Holiday File.

sorry, I completely missed this.
I'll take a look

Oct 26 2018, 4:06 PM · KDE PIM

Oct 25 2018

winterz committed R74:534aa592b4a0: clazy.cmake - provides a nice message if the user mistyped the checker name (authored by winterz).
clazy.cmake - provides a nice message if the user mistyped the checker name
Oct 25 2018, 9:07 PM
winterz closed D16195: Clazy: improved explanations.
Oct 25 2018, 9:06 PM