In D25857#575016, @vkrause wrote:

In D25857#575013, @winterz wrote:

problem though. anyone using libical < 3.0.6 (possibly including the CI) will have problems with test failures. I don't know a non-painful way around that.
for distros/users still with libical < 3.0.6 we'll just have to tell them to upgrade.

Are you sure? I think we wont be generating the COUNT property on older versions anymore either with this, so tests should work there too.

I guess the only workable answer for everyone is "upgrade your libical to 3.0.6"

I'm so happy to see this fix.
I was unable to duplicate the problems reported in https://bugs.kde.org/show_bug.cgi?id=412751

please send me a list of urls that don't have https: and I'll add them to the whitelist

In D25621#569644, @mlaurent wrote:

Hi allen
Why you abandonned all your patch ?

See new review using arcanist at https://phabricator.kde.org/D25621

minor improvements , and fix 1 oopsie.

yay!

In D25458#566144, @dvratil wrote:

In D25458#566142, @winterz wrote:

In D25458#566129, @dvratil wrote:

Fix the patch, arc sucks.

Off topic, but @mlaurent told me to use arcanist because my commandline generated 'git diff' patches suck. what's the deal?

It handles multi-commit changes incorrectly or not at all. Which is known about arcanist, but I'm just so used to Github/Gitlub at this point, this makes me grumpy...Phabricator is a decent review tool, but arcanist IMO sucks, compared to how easy Github/Gitlab flow is...

In D25458#566129, @dvratil wrote:

Fix the patch, arc sucks.

yes :)

Thank you David.
I'm very much in favor of this once you have the blocking figured-out.

Volker, if you do this:
remove the commented 'add_subdirectory(hebrew) ' line from korganizer/plugins/CMakelists.txt along with the entire plugins/hebrew subdirectory

abandoning.
however, this was committed in e031408f12dadff675a92a06eb9449a52e78d124
sorry I forgot to wait for the final review

ping

I will apply the patch locally and see what happens.

I can't argue with the code or with your logic.

introduce a new , non-exported helper function isColorDark() .

I just committed this e031408f12dadff675a92a06eb9449a52e78d124
sorry I forgot to wait for the final review

FYI: Today I added a Krazy checker to do this. Should see results on the EBN in a day or 2.

oh, please add this to the stable branch if not too much trouble. or I can do that.

thanks Albert. I learned something new.

I am a long-time advocate of columnLimits; however, in our modern world of programming I think 100 is too short.

In D24739#549483, @mlaurent wrote:

is it in all language we have Month + year ?

I have no idea

I wonder if the original way was done for translation purposes? In any event, I think relying on localization makes more sense.

I'm not sure I like this code.

Thanks to @montel for mentoring me :)

save/restore application settings

+1
will fix the problem I reported.

can you update the kmail docbook accordingly?

tested locally and it works fine!
+1 from me.

I have a folder that always goes into infiinite loop mode. I can test this

yay

should be ok.
no objections.