winterz (Allen Winter)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 30 2015, 4:43 PM (223 w, 4 d)
Availability
Available

Recent Activity

Yesterday

winterz accepted D25931: Make incidence geographic coordinate also accessible as a property.
Thu, Dec 12, 8:39 PM · KDE PIM

Tue, Dec 10

winterz accepted D25857: Fix RRULE generation for timezones.

problem though. anyone using libical < 3.0.6 (possibly including the CI) will have problems with test failures. I don't know a non-painful way around that.
for distros/users still with libical < 3.0.6 we'll just have to tell them to upgrade.

Are you sure? I think we wont be generating the COUNT property on older versions anymore either with this, so tests should work there too.

Tue, Dec 10, 5:34 PM · KDE PIM
winterz added a comment to D25857: Fix RRULE generation for timezones.

I guess the only workable answer for everyone is "upgrade your libical to 3.0.6"

Tue, Dec 10, 5:30 PM · KDE PIM
winterz added a comment to D25857: Fix RRULE generation for timezones.

I'm so happy to see this fix.
I was unable to duplicate the problems reported in https://bugs.kde.org/show_bug.cgi?id=412751

Tue, Dec 10, 5:28 PM · KDE PIM

Thu, Dec 5

winterz added a comment to D25753: EBN extra-cmake-modules transport cleanup.

please send me a list of urls that don't have https: and I'll add them to the whitelist

Thu, Dec 5, 9:26 PM · Build System, Frameworks

Sat, Nov 30

winterz committed R175:748d0219f3f3: add Lebanon holidays (authored by winterz).
add Lebanon holidays
Sat, Nov 30, 4:55 PM
winterz added a comment to D25621: [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.

Hi allen
Why you abandonned all your patch ?

Sat, Nov 30, 2:44 PM · KDE PIM

Fri, Nov 29

winterz abandoned D25598: [kdepim-runtime] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Fri, Nov 29, 10:25 PM · KDE PIM
winterz abandoned D25597: [AkonadiConsole] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Fri, Nov 29, 10:25 PM · KDE PIM
winterz abandoned D25596: [mailcommon] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Fri, Nov 29, 10:24 PM · KDE PIM
winterz abandoned D25621: [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Fri, Nov 29, 10:22 PM · KDE PIM
winterz abandoned D25595: [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.

See new review using arcanist at https://phabricator.kde.org/D25621

Fri, Nov 29, 10:09 PM · KDE PIM
winterz updated the summary of D25621: [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Fri, Nov 29, 10:08 PM · KDE PIM
winterz requested review of D25621: [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Fri, Nov 29, 10:07 PM · KDE PIM

Thu, Nov 28

winterz requested review of D25598: [kdepim-runtime] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Thu, Nov 28, 5:16 PM · KDE PIM
winterz requested review of D25597: [AkonadiConsole] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Thu, Nov 28, 4:51 PM · KDE PIM
winterz updated the diff for D25595: [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.

minor improvements , and fix 1 oopsie.

Thu, Nov 28, 4:47 PM · KDE PIM
winterz updated the summary of D25596: [mailcommon] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Thu, Nov 28, 4:34 PM · KDE PIM
winterz requested review of D25596: [mailcommon] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Thu, Nov 28, 4:34 PM · KDE PIM
winterz updated the summary of D25595: [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Thu, Nov 28, 4:25 PM · KDE PIM
winterz requested review of D25595: [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.
Thu, Nov 28, 4:23 PM · KDE PIM
winterz committed R95:da0a214ad64a: folderdialog -fix compile (authored by winterz).
folderdialog -fix compile
Thu, Nov 28, 3:14 PM

Tue, Nov 26

winterz added a comment to D25106: Also allow invoking session restoration logic when apps are manually launched.

yay!

Tue, Nov 26, 4:38 PM · Frameworks

Fri, Nov 22

winterz added a comment to D25458: Attempt to make tests on CI more robust.

Fix the patch, arc sucks.

Off topic, but @mlaurent told me to use arcanist because my commandline generated 'git diff' patches suck. what's the deal?

It handles multi-commit changes incorrectly or not at all. Which is known about arcanist, but I'm just so used to Github/Gitlub at this point, this makes me grumpy...Phabricator is a decent review tool, but arcanist IMO sucks, compared to how easy Github/Gitlab flow is...

Fri, Nov 22, 3:18 PM · KDE PIM
winterz updated subscribers of D25458: Attempt to make tests on CI more robust.

Fix the patch, arc sucks.

Fri, Nov 22, 1:47 PM · KDE PIM

Wed, Nov 20

winterz added a comment to D25399: korgac: honour notification inhibition by delaying reminders.

yes :)

Wed, Nov 20, 4:27 PM · KDE PIM

Tue, Nov 19

winterz added a comment to D25399: korgac: honour notification inhibition by delaying reminders.

Thank you David.
I'm very much in favor of this once you have the blocking figured-out.

Tue, Nov 19, 1:22 PM · KDE PIM

Mon, Nov 18

winterz added a comment to D25373: Remove dead QCalendarSystem code.

Volker, if you do this:
remove the commented 'add_subdirectory(hebrew) ' line from korganizer/plugins/CMakelists.txt along with the entire plugins/hebrew subdirectory

Mon, Nov 18, 7:54 PM · KDE PIM

Sun, Nov 17

winterz committed R76:0ec26410da35: Month View: background color computation for dark mode theme (authored by winterz).
Month View: background color computation for dark mode theme
Sun, Nov 17, 2:06 PM

Sat, Nov 16

winterz committed R76:614f757286cb: Month View: background color computation for dark mode theme (authored by winterz).
Month View: background color computation for dark mode theme
Sat, Nov 16, 3:46 PM
winterz closed D25262: KOrganizer Month View: better background color computation for dark mode them.
Sat, Nov 16, 3:46 PM · KDE PIM
winterz abandoned D24991: KOrganizer Agenda View: Compute Grid Lines Color.

abandoning.
however, this was committed in e031408f12dadff675a92a06eb9449a52e78d124
sorry I forgot to wait for the final review

Sat, Nov 16, 3:04 PM · KDE PIM
winterz added a reviewer for D25262: KOrganizer Month View: better background color computation for dark mode them: mlaurent.

ping

Sat, Nov 16, 2:54 PM · KDE PIM

Fri, Nov 15

winterz added a comment to D25289: Read floating date time as LocalTime..

I will apply the patch locally and see what happens.

Fri, Nov 15, 5:51 PM · KDE PIM

Wed, Nov 13

winterz added a comment to D25289: Read floating date time as LocalTime..

I can't argue with the code or with your logic.

Wed, Nov 13, 10:12 PM · KDE PIM

Nov 11 2019

winterz committed R76:f99e855a7c4c: Merge branch 'release/19.12' (authored by winterz).
Merge branch 'release/19.12'
Nov 11 2019, 10:25 PM
winterz committed R76:010612e5ac08: month/monthitem.cpp - fix chronological sorting in day block (authored by winterz).
month/monthitem.cpp - fix chronological sorting in day block
Nov 11 2019, 10:24 PM
winterz closed D25266: KOrganizer Month View: fix chronological sorting.
Nov 11 2019, 10:24 PM · KDE PIM
winterz requested review of D25266: KOrganizer Month View: fix chronological sorting.
Nov 11 2019, 9:04 PM · KDE PIM
winterz updated the diff for D25262: KOrganizer Month View: better background color computation for dark mode them.

introduce a new , non-exported helper function isColorDark() .

Nov 11 2019, 6:31 PM · KDE PIM
winterz requested review of D25262: KOrganizer Month View: better background color computation for dark mode them.
Nov 11 2019, 6:06 PM · KDE PIM
winterz added a comment to D24991: KOrganizer Agenda View: Compute Grid Lines Color.

I just committed this e031408f12dadff675a92a06eb9449a52e78d124
sorry I forgot to wait for the final review

Nov 11 2019, 5:08 PM · KDE PIM
winterz updated the diff for D24991: KOrganizer Agenda View: Compute Grid Lines Color.
Nov 11 2019, 5:07 PM · KDE PIM
winterz committed R76:5c3db09d2ad4: Merge branch 'release/19.12' (authored by winterz).
Merge branch 'release/19.12'
Nov 11 2019, 5:02 PM
winterz committed R76:e031408f12da: agenda/agenda.cpp - grid colors when not using system settings (authored by winterz).
agenda/agenda.cpp - grid colors when not using system settings
Nov 11 2019, 4:53 PM

Nov 9 2019

winterz committed R165:529be1966c9d: Merge branch 'Applications/19.08' (authored by winterz).
Merge branch 'Applications/19.08'
Nov 9 2019, 8:43 PM
winterz committed R165:5f43522898a4: tests/libs/etm_test_app/main.cpp - update kde pim url (authored by winterz).
tests/libs/etm_test_app/main.cpp - update kde pim url
Nov 9 2019, 8:43 PM
winterz committed R81:58fd5e81b13b: examples - update urls that were pointing to pim.kde.org (authored by winterz).
examples - update urls that were pointing to pim.kde.org
Nov 9 2019, 8:41 PM
winterz committed R44:2669dbbeb00a: Mainpage.dox - update urls for community and techbase (authored by winterz).
Mainpage.dox - update urls for community and techbase
Nov 9 2019, 8:36 PM
winterz committed R198:cdc22dcc07b2: Merge branch 'Applications/19.08' (authored by winterz).
Merge branch 'Applications/19.08'
Nov 9 2019, 8:28 PM
winterz committed R198:a478cd44acae: konsolekalendar.cpp - html export credit url (authored by winterz).
konsolekalendar.cpp - html export credit url
Nov 9 2019, 8:27 PM
winterz committed R208:55fb55dfa952: HACKING, README - update the url for the coding style doc (authored by winterz).
HACKING, README - update the url for the coding style doc
Nov 9 2019, 8:20 PM
winterz committed R209:3b07d8c280a0: HACKING - update location of coding style documentation (authored by winterz).
HACKING - update location of coding style documentation
Nov 9 2019, 8:16 PM

Nov 8 2019

winterz added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

FYI: Today I added a Krazy checker to do this. Should see results on the EBN in a day or 2.

Nov 8 2019, 10:33 PM · Build System, Frameworks

Nov 7 2019

winterz committed R74:0dd7fd11a33e: Merge branch '1.6' (authored by winterz).
Merge branch '1.6'
Nov 7 2019, 3:51 PM
winterz committed R74:848e8148e35e: CMakeLists.txt, clazy.cmake - use greadlink on MacOS (authored by winterz).
CMakeLists.txt, clazy.cmake - use greadlink on MacOS
Nov 7 2019, 3:46 PM
winterz abandoned D24992: KOrganizer Agenda View: Compute Grid Lines Color (Another idea).
Nov 7 2019, 3:18 PM · KDE PIM

Oct 30 2019

winterz added a comment to D25080: NavBar: Use standaloneMonthName instead of monthName.

oh, please add this to the stable branch if not too much trouble. or I can do that.

Oct 30 2019, 4:31 PM · KDE PIM
winterz accepted D25080: NavBar: Use standaloneMonthName instead of monthName.

thanks Albert. I learned something new.

Oct 30 2019, 4:31 PM · KDE PIM

Oct 27 2019

winterz requested review of D24992: KOrganizer Agenda View: Compute Grid Lines Color (Another idea).
Oct 27 2019, 9:17 PM · KDE PIM
winterz updated the summary of D24991: KOrganizer Agenda View: Compute Grid Lines Color.
Oct 27 2019, 8:29 PM · KDE PIM
winterz added a reviewer for D24991: KOrganizer Agenda View: Compute Grid Lines Color: mlaurent.
Oct 27 2019, 8:04 PM · KDE PIM
winterz requested review of D24991: KOrganizer Agenda View: Compute Grid Lines Color.
Oct 27 2019, 8:04 PM · KDE PIM

Oct 21 2019

winterz added a comment to D24826: Enforce 100 chars line width.

I am a long-time advocate of columnLimits; however, in our modern world of programming I think 100 is too short.

Oct 21 2019, 1:03 PM · Build System, Frameworks

Oct 20 2019

winterz committed R78:1dc11d6c2d7e: Merge branch 'Applications/19.08' (authored by winterz).
Merge branch 'Applications/19.08'
Oct 20 2019, 8:56 PM
winterz committed R78:dd6795cec401: incidencealarm.cpp - allow double-click to edit an alarm (authored by winterz).
incidencealarm.cpp - allow double-click to edit an alarm
Oct 20 2019, 8:49 PM
winterz closed D24806: IncidenceEditor: allow double-click to edit an alarm.
Oct 20 2019, 8:48 PM · KDE PIM
winterz updated the diff for D24806: IncidenceEditor: allow double-click to edit an alarm.
Oct 20 2019, 7:47 PM · KDE PIM
winterz requested review of D24806: IncidenceEditor: allow double-click to edit an alarm.
Oct 20 2019, 3:43 PM · KDE PIM
winterz committed R76:a9d23ce1d5d8: src/month/monthscene.cpp - use QDate stringification (authored by winterz).
src/month/monthscene.cpp - use QDate stringification
Oct 20 2019, 3:18 PM
winterz closed D24739: KOrganizer Month View: use QDate stringification.
Oct 20 2019, 3:18 PM · KDE PIM

Oct 18 2019

winterz added a comment to D24739: KOrganizer Month View: use QDate stringification.

is it in all language we have Month + year ?

I have no idea

Oct 18 2019, 12:57 PM · KDE PIM

Oct 17 2019

winterz updated the diff for D24739: KOrganizer Month View: use QDate stringification.

I wonder if the original way was done for translation purposes? In any event, I think relying on localization makes more sense.

Oct 17 2019, 4:01 PM · KDE PIM
winterz requested review of D24739: KOrganizer Month View: use QDate stringification.
Oct 17 2019, 2:55 PM · KDE PIM
winterz added a comment to D24638: KOrganizer Month View: remove comma in Year.

I'm not sure I like this code.

Oct 17 2019, 1:04 PM · KDE PIM

Oct 15 2019

winterz committed R210:5fe06ce07ec0: Merge branch 'Applications/19.08' (authored by winterz).
Merge branch 'Applications/19.08'
Oct 15 2019, 4:44 PM
winterz committed R210:d4b52772038e: Make Get New Stuff work again (authored by winterz).
Make Get New Stuff work again
Oct 15 2019, 4:44 PM
winterz closed D24633: KOrganizer : Fix Get Hot New Stuff.
Oct 15 2019, 4:44 PM · KDE PIM
winterz committed R76:f94435bfffec: Merge branch 'Applications/19.08' (authored by winterz).
Merge branch 'Applications/19.08'
Oct 15 2019, 1:06 PM
winterz closed D24638: KOrganizer Month View: remove comma in Year.
Oct 15 2019, 1:06 PM · KDE PIM
winterz committed R76:a5c067fbc83c: month/monthscene.cpp - remove comma in year (in the title) (authored by winterz).
month/monthscene.cpp - remove comma in year (in the title)
Oct 15 2019, 1:06 PM
winterz updated the diff for D24633: KOrganizer : Fix Get Hot New Stuff.

Thanks to @montel for mentoring me :)

Oct 15 2019, 12:55 PM · KDE PIM
winterz abandoned D24646: KMail: Improve poorly written notification text if no password entered to collect email.
Oct 15 2019, 11:53 AM · KDE PIM

Oct 14 2019

winterz requested review of D24646: KMail: Improve poorly written notification text if no password entered to collect email.
Oct 14 2019, 9:40 PM · KDE PIM
winterz requested review of D24638: KOrganizer Month View: remove comma in Year.
Oct 14 2019, 4:41 PM · KDE PIM
winterz updated the diff for D24633: KOrganizer : Fix Get Hot New Stuff.

save/restore application settings

Oct 14 2019, 3:20 PM · KDE PIM
winterz requested review of D24633: KOrganizer : Fix Get Hot New Stuff.
Oct 14 2019, 3:00 PM · KDE PIM

Oct 11 2019

winterz committed R1003:b51e08cf5448: src/pdf/pdfdocument.cpp - fix compile for older popplers (authored by winterz).
src/pdf/pdfdocument.cpp - fix compile for older popplers
Oct 11 2019, 10:13 PM

Sep 13 2019

winterz added a comment to D23930: Set XCB to required if building the X backend.

+1
will fix the problem I reported.

Sep 13 2019, 3:52 PM · Frameworks

Jul 19 2019

winterz committed R206:201eac97eba5: summaryview_part.h - fix build by including QMap (authored by winterz).
summaryview_part.h - fix build by including QMap
Jul 19 2019, 4:59 PM

Jul 18 2019

winterz committed R206:28a8cf907b3c: summaryview_part.h - fix build by including QMap (authored by winterz).
summaryview_part.h - fix build by including QMap
Jul 18 2019, 7:35 PM
winterz committed R286:67c57a042458: taglibextractortest.cpp - fix build with include <QSet> (authored by winterz).
taglibextractortest.cpp - fix build with include <QSet>
Jul 18 2019, 7:04 PM

Jun 19 2019

winterz added a comment to D21464: IMAP: Option to use system proxy settings (Configuration and GUI).

can you update the kmail docbook accordingly?

Jun 19 2019, 1:08 PM · KDE PIM

Jun 10 2019

winterz added a comment to D21737: Fix infinite loop when mThreadingCache is 'corrupted'.

tested locally and it works fine!
+1 from me.

Jun 10 2019, 9:39 PM · KDE PIM
winterz added a comment to D21737: Fix infinite loop when mThreadingCache is 'corrupted'.

I have a folder that always goes into infiinite loop mode. I can test this

Jun 10 2019, 9:31 PM · KDE PIM

Jun 6 2019

winterz accepted D21625: Allow parts (like kmail) to set a custom caption in guiActivateEvent.

yay

Jun 6 2019, 4:51 PM · KDE PIM
winterz accepted D21626: Fix kontact crash on logout..
Jun 6 2019, 4:51 PM · KDE PIM

May 30 2019

winterz accepted D21498: Make KCalCore::Person a Q_GADGET.
May 30 2019, 9:47 PM · KDE PIM
winterz accepted D21215: Create second-type duration for 0 delay durations in ical format..

should be ok.
no objections.

May 30 2019, 9:43 PM · KDE PIM

May 21 2019

winterz committed R165:983f44d880c9: src/server/storage/dbconfigpostgresql.cpp - fix compile (authored by winterz).
src/server/storage/dbconfigpostgresql.cpp - fix compile
May 21 2019, 5:10 PM