Allow Ctrl+Wheel to zoom in/out on the target text

Authored by sdepiets on Jul 16 2018, 7:31 AM.



Allow Ctrl+Wheel to zoom in and out of the target text (change its font size) when the wheel navigation is disabled.
This makes the target field more consistent with the source field.
By default the QTextEdit Qt component allows Ctrl+Wheel zooming only for read only fields.

Diff Detail

R456 Lokalize
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
sdepiets requested review of this revision.Jul 16 2018, 7:31 AM
sdepiets created this revision.
sdepiets edited the summary of this revision. (Show Details)Jul 16 2018, 7:32 AM
sdepiets added a project: Localization.
sdepiets updated this revision to Diff 37848.Jul 16 2018, 7:35 AM

Fix tab and replace by spaces

Thank you!
I see the problem you are solving, but this is a less optimal solution.
This way the user must change the size with every launch of the app, and this is if he knows how to :) (no to mention he should change the size of both the boxes to match, or it will be ugly looking)
A solution that is used in Linux version is much better (a font setting)

I agree this is suboptimal but it doesn't require the font selection (it's only the zoom).
I can find some use cases, especially with oriental languages, where you might prefer having different sizes for your English source and your local contents so it can still help.

aacid accepted this revision.Jul 21 2018, 7:11 PM

I think this is fine, if we let people zoom on the top area, we should let people zoom on the zoom one, but i agree with Safa this is not the actual fix for bug 375251

So for me if you want to commit this, go ahead, but make sure you don't mark the bug as fixed when commiting

This revision is now accepted and ready to land.Jul 21 2018, 7:11 PM
This revision was automatically updated to reflect the committed changes.