Feed Advanced Search

Nov 3 2019

safaalfulaij added a comment to D24720: [applets/systemtray] Rewrite popups with layouts.

Hi :)
Please tag me in case you need any RTL help.
Yes, headers are aligned based on direction before, which was bad. It's almost better to align them to the other side even if they're not translated. You never know.
And good that you spotted the issue with QML's Layouts regarding RTL:)

Nov 3 2019, 3:50 PM · Plasma

Sep 21 2019

safaalfulaij added a comment to T11579: Unify navigation through sidebar categories/views.

Let's not forget digiKam :)

Sep 21 2019, 2:24 PM · Goal: Consistency, KDE Human Interface Guidelines, VDG

Aug 21 2019

safaalfulaij added a comment to T11070: Better (online) localization.

I've checked Weblate in more details now, as well as the documentation. hmmm, not very bad. Proper permissions, fast browsing, checks, good UI, good editing box, etc etc..
We tried once to translate KDE docs by pootle, but it was a horrible thing at that time becuase of bad SVN integration. By that we had to have each single file translated with anything so that it can be uploaded and pushed to the server, or we can't push anything (not sure why, my teammate was doing that back then). I've removed all those files now.

Aug 21 2019, 6:44 PM · Goal Setting 2019
safaalfulaij added a comment to T11070: Better (online) localization.

Languages like Japanese and Korean are less than 70 % translated, Arabic, Hindi, Bengali and African languages are worse, despite those are spoken in countries representing millions of potential users and community members.

Aug 21 2019, 3:23 PM · Goal Setting 2019

Jul 23 2019

safaalfulaij added a comment to D13219: Locale-aware formatting of numbers on status bar.

I’ve just tested this, but changing %1 to %L1 doesn’t seem work; the %L1 is displayed verbatim.

Jul 23 2019, 2:13 PM · Localization

Jun 25 2019

safaalfulaij added a comment to D22069: Localize long number strings.

This is great! Thanks!
Same issue in here: https://phabricator.kde.org/D13219
I'm not sure if this is the correct way of fixing it, but I think there isn't any other prvoided by Qt, other then QLocale::toString. Maybe it's the easy way here :)

Jun 25 2019, 7:53 PM · Frameworks

Jun 1 2019

safaalfulaij added a comment to T10891: Breeze theme evolution.

And what would happen to menus? How will that centered toolbar look with menus on the left?
How it will work with KDevelop for example?


Or Krita?

Jun 1 2019, 10:37 PM · Plasma, VDG, Breeze

May 31 2019

safaalfulaij added a comment to T10863: When writing in Kate in a RTL language, Kate acts weird.

Even in Qt there aren't many (if any) developers who understands RTL text. That is why many bugs I reported to Qt didn't get resolved till now.

May 31 2019, 12:24 PM · Kate

May 29 2019

safaalfulaij added a comment to T10863: When writing in Kate in a RTL language, Kate acts weird.

Issue 1: https://bugs.kde.org/show_bug.cgi?id=385694 (In Qt, it happens only with bidi: https://bugreports.qt.io/browse/QTBUG-71489)
Issue 2: Yes, this happens. I don't know if a bug is reported or not. I remember seeing this with normal LTR text as well, and it got fixed. (I think some height algorithm was changed)
Issue 3: Seems related to issue 1.
Issue 4: This is new. So hitting up in the wrapped RTL text segments takes you to the beginning of the segment, not up to other segments.

May 29 2019, 10:59 PM · Kate

May 8 2019

safaalfulaij accepted D21080: fix some layouts to look correct when reversed (typical for RTL locale).

Can't test, but seems fine.
Thanks for informing! :)

May 8 2019, 2:12 PM · Elisa

Mar 17 2019

safaalfulaij added a comment to D19785: DocumentPrivate: Review del/backspace.

Wow! Great :)
Thanks for looking into this, but I'm afraid that the problem isn't with backspace/del, but with the cursor positioning, at least for RTL and mixed text.
I actually found this to be a problem in Qt after trying to solve it myself in KTextEditor: https://bugreports.qt.io/browse/QTBUG-65508
Not sure what's the root of the problem :(

Mar 17 2019, 4:57 PM · Frameworks, Kate

Jan 13 2019

safaalfulaij added a comment to T8871: Systematic KCM reorganisation.

-- Emoticons (or should we delete this because it's useless, as discussed in the VDG room?

Jan 13 2019, 8:53 PM · Plasma: KCM Redesign, VDG
safaalfulaij added a comment to T8871: Systematic KCM reorganisation.

Just here for emoticons. We know that removing a feature will lead to a bug report, don't we?
Both Konversation and Choqok are using emotions to display emoji (even thought they are not supported officially anymore in Konvi, but that won't last for long, hopefully).
It is such a small KCM that just makes life easier for the users of those apps, why removing them? I rememberd one of the KDE goals was to implement a global text edit controls that support emoji by default. Even if we don't have that yet, but when we do, we certainly want users to be able to change the icons.
I don't plan to go to Telegram channel to get to know that. I don't need to. KDE uses Phabricator and IRC to be public to everybody and accessible, not private and require softwares and registration.

Jan 13 2019, 8:37 PM · Plasma: KCM Redesign, VDG
safaalfulaij committed R37:097d7e617aa2: Refactor KisNodeDelegate and support RTL (authored by safaalfulaij).
Refactor KisNodeDelegate and support RTL
Jan 13 2019, 12:37 PM
safaalfulaij closed D15590: [WIP] Refactor KisNodeDelegate and support RTL.
Jan 13 2019, 12:37 PM · Krita

Jan 6 2019

safaalfulaij added a comment to D16421: Improve emblem contrast, legibility and consistency.

mmm, sorry. I saw this today and I just took a minute to understand it. How does this looks consistent with the theme, or even nice (really sorry)? Please teach me.
Thank you.

Jan 6 2019, 10:18 AM · Frameworks

Jan 3 2019

safaalfulaij added a comment to T6859: Falkon - VDG feedback.

I am using the latest version and I really think that the background in the icon is too light. Like check the other apps (Dolphin, Firefox, KSysGuard, System Settings, etc). They don't use such light colors. Maybe with a bigger version it's fine, but the smaller (much more important and used version) is not.

Jan 3 2019, 8:57 PM · Falkon
safaalfulaij updated the diff for D15590: [WIP] Refactor KisNodeDelegate and support RTL.

Addressed comments.

Jan 3 2019, 10:54 AM · Krita
safaalfulaij abandoned D10083: [Look and Feel] Reverse the button order.

Thanks for making stuff consistent! :)

Jan 3 2019, 7:40 AM · Plasma

Dec 26 2018

safaalfulaij added a comment to D15590: [WIP] Refactor KisNodeDelegate and support RTL.

Hi @dkazakov!
Well, basically (please ignore the Arabic/English text changing):
Before:

Dec 26 2018, 4:52 PM · Krita

Dec 7 2018

safaalfulaij updated the diff for D15590: [WIP] Refactor KisNodeDelegate and support RTL.

Minor changes

Dec 7 2018, 9:29 PM · Krita
safaalfulaij updated the diff for D15590: [WIP] Refactor KisNodeDelegate and support RTL.

Update based on comments given by bond

Dec 7 2018, 9:25 PM · Krita

Oct 29 2018

safaalfulaij planned changes to D15590: [WIP] Refactor KisNodeDelegate and support RTL.

Hi :)
tbh, I stopped working on it once I uploaded it. I'll get back to it soon, but need to fix my Linux working machine.
I will most probably change QRectFs to QRects again, and maybe make the comments a bit better.
Then I have to figure out why rendering of the items isn't updated in the moment of showing/hiding the layer.

Oct 29 2018, 6:33 PM · Krita

Oct 28 2018

safaalfulaij added a comment to D14753: [WIP] Add Bahrain Holiday File.

I'll commit this for you.
it seems to work, at least as much as I can tell.

Oct 28 2018, 8:30 PM · KDE PIM

Oct 7 2018

safaalfulaij added inline comments to D15829: make units and prefixes of formatValue translatable.
Oct 7 2018, 1:44 PM · Frameworks
safaalfulaij accepted D15829: make units and prefixes of formatValue translatable.

Thanks!
I think this solved all my issues. I can for meter unit change the formatting so that tr("%1 %2", "no Prefix") is translated to "%1%2" and choose to keep the dot or remove it in the unitStrings translation. ("bit" -> ".bit", "m" -> "m")
By the way, shouldn't that also be the case for English? I don't see people write "1 m" but "1m", "200 B" but "200B", same for Hz, not sure about bits. The space is not there when abbreviation is used.

Oct 7 2018, 1:40 PM · Frameworks

Sep 29 2018

safaalfulaij added a comment to D15829: make units and prefixes of formatValue translatable.

I came into anther problem, this time with the unit selection.
In Arabic, we don't put a dot between the prefix and the unit if we're talking about meters (mm, cm, km), but we do with other units (k.Byte, M.Byte, G.Byte).

Sep 29 2018, 3:00 PM · Frameworks
safaalfulaij added a comment to D15829: make units and prefixes of formatValue translatable.

Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen.

Sep 29 2018, 1:36 PM · Frameworks

Sep 27 2018

safaalfulaij added a comment to D15808: Refactor touch docker..

Uhm, I just followed the include that was written in the documentation for button http://doc.qt.io/qt-5/qml-qtquick-controls-button.html

Sep 27 2018, 10:49 PM · Krita
safaalfulaij added a comment to D15808: Refactor touch docker..

I understand that it's entirely up to Krita devs what suits best, but I really think that QQC1 shouldn't be used anymore. It is depracted and replaced by QQC2 (Although the latter is still lacking some stuff).
This is not a comment on this patch specifically, but to the whole QtQuick code in Krita.
Who knows, maybe I work on that one day if no one took the task.. :D

Sep 27 2018, 10:22 PM · Krita

Sep 23 2018

safaalfulaij added a comment to D12443: fix bitrate unit.

Can we please first answer this and this before going on with this? I feel they are just ignored without any reasonable explanation. Thanks.

Sep 23 2018, 8:04 PM · Baloo

Sep 21 2018

safaalfulaij added a comment to D15683: Add lock icon to desktop context menu.

Why not also add icons to other items instead of other X number of commits coming later by Y number of people?
Yes, some don't have “group” icon (like sort, where only ascending and descending are available), but I don't see a problem if we used any “child” one as “group”, like ascending for sorting, center for alignement, etc.

Sep 21 2018, 8:52 PM · Plasma

Sep 18 2018

safaalfulaij added a comment to D15590: [WIP] Refactor KisNodeDelegate and support RTL.

Alright. This changes many manual code to code that is dynamic, easy to understand and to maintain (for both LTR and RTL layouts).

Sep 18 2018, 2:14 PM · Krita
safaalfulaij requested review of D15590: [WIP] Refactor KisNodeDelegate and support RTL.
Sep 18 2018, 1:56 PM · Krita

Sep 17 2018

safaalfulaij added a comment to T7184: Explore using VLC as an alternative to Qt Multimedia on desktop targets.

I forgot for a second that you don't need video support. Well I'm not entirely sure if QtAV supports many audio formats, but it depends on ffmpeg which I believe support many. I have very little knowledge here and just wanted to add some info about the existence of QtAV :)

Sep 17 2018, 6:25 AM · Elisa

Sep 16 2018

safaalfulaij added a comment to T7184: Explore using VLC as an alternative to Qt Multimedia on desktop targets.

Digikam switched to QtAV once and they said it's better for cross-platform. It also has a QML interface and a similar API to Qt Multimedia. I think you should check that first before VLC.

Sep 16 2018, 6:46 PM · Elisa

Sep 8 2018

safaalfulaij committed R37:75d94198e19c: Make checkboxes look better in the General settings page (authored by safaalfulaij).
Make checkboxes look better in the General settings page
Sep 8 2018, 7:45 AM
safaalfulaij closed D15335: Make checkboxes look better in the General settings page.
Sep 8 2018, 7:44 AM · Krita

Sep 7 2018

safaalfulaij added a comment to D15335: Make checkboxes look better in the General settings page.

No changes to “Misc.” from lasst screenshot.

Sep 7 2018, 5:18 PM · Krita
safaalfulaij updated the diff for D15335: Make checkboxes look better in the General settings page.

Unique name for spacer (be in the safe side)

Sep 7 2018, 5:09 PM · Krita
safaalfulaij updated the diff for D15335: Make checkboxes look better in the General settings page.

Add "General:" and a spacer.

Sep 7 2018, 5:07 PM · Krita
safaalfulaij updated subscribers of D15335: Make checkboxes look better in the General settings page.

Of course it be great if we can use KPluralHandlingSpinBox, but I am not entirely sure about dependencies and import stuff, so I'll keep this for real developers :)

Sep 7 2018, 4:29 PM · Krita
safaalfulaij requested review of D15335: Make checkboxes look better in the General settings page.
Sep 7 2018, 4:23 PM · Krita
safaalfulaij committed R37:5d8e118527ed: Fix the layout direction of 3 widgets (authored by safaalfulaij).
Fix the layout direction of 3 widgets
Sep 7 2018, 3:52 PM
safaalfulaij closed D15329: Fix the layout direction of 3 widgets.
Sep 7 2018, 3:52 PM · Krita
safaalfulaij added a comment to D15329: Fix the layout direction of 3 widgets.

These are much nicer! Can we do it this way?

Sep 7 2018, 3:50 PM · Krita
safaalfulaij added a comment to D15329: Fix the layout direction of 3 widgets.

One way:

Sep 7 2018, 11:19 AM · Krita
safaalfulaij updated subscribers of D15329: Fix the layout direction of 3 widgets.

The label in the Image Properties dialog didn't really change at all.

Sep 7 2018, 10:59 AM · Krita
safaalfulaij requested review of D15329: Fix the layout direction of 3 widgets.
Sep 7 2018, 10:46 AM · Krita

Sep 6 2018

safaalfulaij added a comment to D15309: [Calendar] Wrap day name index around.

I thought that this is a feature/cool look :D
Thanks a lot!

Sep 6 2018, 10:40 AM · Frameworks

Aug 27 2018

safaalfulaij added a comment to T9041: New "Home" tab for Kickoff.

This is nice! Let’s not forget that we have applications that have a name with more than 2 words (GIMP, Plasma X Explorer, KMail Import Wizard, and some others.). They aren’t many, but we don’t have any idea about 3rd-party apps. Maybe this is why applications are having horizontal items so the name can fit however long it is.
Possible solutions:

  • Get rid of the name in favorites section and just use the icon.
  • Resize sections and give the favorites the biggist area, then narraw down the number of allowed favorites and use a bigger item.
  • Use marquee text (up and down) for long names.
Aug 27 2018, 9:12 AM · Plasma, VDG

Aug 25 2018

safaalfulaij committed R883:1523282: Update Arabic translations..
Update Arabic translations.
Aug 25 2018, 1:19 PM

Aug 24 2018

safaalfulaij added a comment to D15011: [Kickoff] Make the search field always look like a search field.

Exactly! In your second proposal I don't think the serachbox sticks out, even as it is. At least to me it looks fine. At the same time it is drawing back, albeit not totally, to old Kickoff so there would have to be good designer conceptualization and solution for how to keep it modern.

When I look at Kickoff now and just think narrowly: how can I make the search more prominent and keep designer consistency, what makes most sense to me is to reuse the horizontal blue line we already have as a Kickoff tab selection indicator, and even as the indicators of open windows and plasmoids. These lines are indeed minimalist. Unfortunately that looks terrible:

(deleted screenshot from reply)

Not even making it a classic Breeze 1px line feels right, although I guess it's a bit better:

(deleted screenshot from reply)

I've had a look at that setup. It's pretty sleek. But we have to consider that YouTube still keeps a full-fledged serachbox on their homepage, and the channel is a less important of a place. So if we apply that to Kickoff, it looks like this:

(deleted screenshot from reply)

And then when it's opened it would look like this:

(deleted screenshot from reply)

IMO we still haven't solved the problem of it not being obvious that you can search. Maybe having a search icon isn't a bad idea though, but I think we'd still have to make it more obvious somehow:

(deleted screenshot from reply)

This was just a little foray into what is possible, nothing definitive or great. In the pictures I've shortened the search box so that there is equal distance from the left and right edge of Kickoff, for symmetry reasons mostly, but also because I am a bit bothered that the Favorites tab is wasting about 60% of horizontal space on nothing and I didn't want to drag attention to the right side. This may be fixed when we get a new Home tab and isn't too important right now anyway.

Aug 24 2018, 4:45 PM · Plasma
safaalfulaij added a comment to D15011: [Kickoff] Make the search field always look like a search field.

Why don't we have a simple search icon that indicates that one can search in the kickoff, and once you click on it you get switched to the search layout, where you'll find a note saying you can also search by direct typing, and a “Got it” as many websites does? Youtube doesn’t force a long search input in the channel page.

Aug 24 2018, 7:19 AM · Plasma

Aug 23 2018

safaalfulaij added a comment to D15011: [Kickoff] Make the search field always look like a search field.

The original issue (in Neon/Kubuntu task, not sure) was that Kickoff is not clear if one can search or not, because of text changing. Why not just keeping the current “Type to search” label as is, and move the user@host text up as in the patch?

Aug 23 2018, 12:02 PM · Plasma

Aug 21 2018

safaalfulaij added a comment to T9460: Consider a more user-friendly SpinBox control.

It's important that we treat all input devices as first-class citizens. Saying, "pshah, just use a real mouse" or "nobody should click on this, the hidden accelerator gesture is more efficient" isn't acceptable. We have GUI interfaces precisely because those hidden accelerator interfaces are only suitable for power users and experts. They are critically important and we should never impair them, but we shouldn't fall into the trap of assuming they're suitable for everyone.

Aug 21 2018, 2:21 PM · KDE Human Interface Guidelines, Kirigami, Breeze, VDG
safaalfulaij added a comment to T9460: Consider a more user-friendly SpinBox control.

I'm pretty sure no one uses these buttons if they have an actual mouse, but just the wheel. And I can say that those who use the touchpad don't need to change this (I don't see a usecase where one using his touchpad instead of a proper mouse, will need to change such values that are kept in settings mostly).

Aug 21 2018, 7:02 AM · KDE Human Interface Guidelines, Kirigami, Breeze, VDG

Aug 16 2018

safaalfulaij added a comment to D14869: [RFC] Increase default font sizes by 1 pt.

I use an old laptop with 1280×800 display (not like you should really count for it, this is old).

Aug 16 2018, 8:29 AM · Plasma
safaalfulaij added a comment to T4474: Centralized booking system.

Well, I always said that DamnedLies is much better than anything eles (Pootle/Transifex/Weblate/etc), but I think we need to keep normal SVN access available as we have lots of file in KDE that are just few strings, and the whole process of downloading translating uploading for each one will be a huge headache :)

Aug 16 2018, 5:29 AM · Localization

Aug 12 2018

safaalfulaij updated the diff for D14753: [WIP] Add Bahrain Holiday File.

Fix source
Add shifts

Aug 12 2018, 7:33 AM · KDE PIM

Aug 11 2018

safaalfulaij added a comment to D14753: [WIP] Add Bahrain Holiday File.

I tried to read about a way to extend the holiday if happened in a weekend day but couldn't find one.
If any day of a holiday happen to be in a Friday or Saturday (Weekend days in Bahrain), the next working day will be a holiday.
Example: Eid ul-Fitr is 3 days, starting from Thursday. It happens on Thursday, Friday, Satarday, Sunday and Monday, where Sunday and Monday are not actually holidays, but they are now so that a holiday is really a day-off and not a usual weekend day.
I'll be done once I solve this for all the holidays in the file.

Aug 11 2018, 11:16 PM · KDE PIM
safaalfulaij requested review of D14753: [WIP] Add Bahrain Holiday File.
Aug 11 2018, 11:07 PM · KDE PIM

Aug 10 2018

safaalfulaij retitled D14733: [KFormat] Add human readable list displaying function from [KFormat] Add human readble list displaying function to [KFormat] Add human readable list displaying function.
Aug 10 2018, 7:00 PM · Frameworks
safaalfulaij added a comment to T7927: Fonts “easy mode”.
In T7927#154291, @rkflx wrote:

Again, not true! Did you actually try this or look at the code before commenting? Changing the font name of all fonts via the button won't change the fixed font. (The only oddity is that changing the size will make the small font the same size as the other fonts.)

Ah, indeed I had not used it, because I assumed that "Adjust All Fonts" will adjust all fonts. When a button will manifestly not do what its label says it will do, that's a problem.

Aug 10 2018, 6:56 PM · VDG, Plasma: KCM Redesign
safaalfulaij added a comment to D14733: [KFormat] Add human readable list displaying function.

You should start with
a) a use case
b) show it actually matches the needs of different languages.

For e.g. englisch and the most european languages, two different positions are sufficent. Also, the AndListType and the UnitListType are identical. What is missing is a format where no conjunction is used, i.e. all lists elements are joined using ', '

Aug 10 2018, 6:47 PM · Frameworks
safaalfulaij updated the diff for D14733: [KFormat] Add human readable list displaying function.

Fix test
No unrelated changes

Aug 10 2018, 6:25 PM · Frameworks
safaalfulaij added a comment to T7927: Fonts “easy mode”.
In T7927#154109, @rkflx wrote:

How about a simple plus/minus button, which affects all different font types at once? (IOW, providing an inline "easy" alternative to the Adjust All button for a single topic.)

I could get behind that. The Adjust All Fonts... button has always rubbed me wrong because it will always produce incorrect output for the Fixed Width and Small fonts that then needs to be manually fixed. If we implement your suggestion, I'd be okay with the original proposed separation with the font settings on one tab and the anti-aliasing settings on another tab.

Aug 10 2018, 5:40 PM · VDG, Plasma: KCM Redesign
safaalfulaij added a comment to D14733: [KFormat] Add human readable list displaying function.

Tbh I don't fully understand the struct and find statments (just saw working similar code and edited-copy-pasted). I prefer if someone can continue this instead of me.

Aug 10 2018, 3:57 PM · Frameworks
safaalfulaij requested review of D14733: [KFormat] Add human readable list displaying function.
Aug 10 2018, 3:52 PM · Frameworks

Aug 9 2018

safaalfulaij added a comment to D13584: KFormat: Replace byte specific implementation with generic one.

Can we please take a look at this before continuing here?

Aug 9 2018, 10:46 AM · Frameworks

Aug 7 2018

safaalfulaij added a comment to D13583: KFormat: Allow usage of quantities beyond bytes and seconds.

Yes. As you said, these are symbols. For the names there may be transliterations, the symbols stay the same, to avoid ambiguities. This also matches my experience with datasheets, the text may be chinese, but measurements are given in SI units.

Aug 7 2018, 9:15 PM · Frameworks

Aug 3 2018

safaalfulaij added a comment to D13219: Locale-aware formatting of numbers on status bar.

Since this turned already into a discussion, shall we use %Lx version for KF5 libraries using Qt's translation system? I mean in the source text.

Aug 3 2018, 1:04 PM · Localization

Aug 2 2018

safaalfulaij accepted D14565: Fix overflow in rounding code.

Worked great, thanks!
Maybe you should use largeValue instead of largevalue.
But please take an approval from a developer, it worked for me but I have no idea if it can cause any trouble :)

Aug 2 2018, 8:38 PM · Frameworks

Jul 29 2018

safaalfulaij added a comment to D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button.
  1. Does this mean that PlasmaComponents is semi or fully deprecated or "legacy", and we should be porting Plasma stuff to Kirigami instead?
  2. Since there's no Kirigami TextField, what do we do with this patch? Is there any reason why we can't improve the PC3 TextField to match the features that the PC2 TextField has? Or should we create a Kirigami TextField instead and port current PC2/3 clients to use it?
Jul 29 2018, 11:03 AM · Frameworks

Jul 26 2018

safaalfulaij added a comment to D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button.

Great! Now I know why the port to PC3 didn't start :D
Now to the patch. First, by this we will allow the user to get text under the icon, which will be impossible to read.
Second is what I'm here for :)
The clear button placement and icon should not follow the locale, but the actual text imh. You can write Arabic in an English system, and vice versa.

Jul 26 2018, 9:00 PM · Frameworks

Jul 16 2018

safaalfulaij added a comment to D14151: Allow Ctrl+Wheel to zoom in/out on the target text.

Thank you!
I see the problem you are solving, but this is a less optimal solution.
This way the user must change the size with every launch of the app, and this is if he knows how to :) (no to mention he should change the size of both the boxes to match, or it will be ugly looking)
A solution that is used in Linux version is much better (a font setting)

Jul 16 2018, 8:50 AM · Localization

Jul 14 2018

safaalfulaij added a comment to T8984: Enclosing placeholders by isolation characters.

Do you mean that those markers are needed anytime there is a mixed string with a translated part (which could be LTR or RTL) and a fixed part which has always the same direction?

Jul 14 2018, 1:57 PM · Localization
safaalfulaij added a comment to T8984: Enclosing placeholders by isolation characters.

First, sorry for any language mistakes.

Jul 14 2018, 1:10 PM · Localization

Jun 13 2018

safaalfulaij added a comment to T8984: Enclosing placeholders by isolation characters.
In T8984#147453, @aacid wrote:

I already disagreed that method is the correct solution, so no it's not "the same way"

Jun 13 2018, 10:20 PM · Localization
safaalfulaij added a comment to T8984: Enclosing placeholders by isolation characters.
In T8984#147444, @aacid wrote:

You mean changing every single i18n() call that uses a placeholder? or something else?

Jun 13 2018, 9:32 PM · Localization

Jun 12 2018

safaalfulaij added inline comments to D13174: New layout for the search bar..
Jun 12 2018, 6:00 PM · Konsole

Jun 9 2018

safaalfulaij created T8984: Enclosing placeholders by isolation characters.
Jun 9 2018, 4:56 PM · Localization

Jun 8 2018

safaalfulaij added a comment to D13372: Mouse KCM Redesign Using Kirigami.

Small question, why we're not using QQC2-based controls?

Jun 8 2018, 12:43 PM · Plasma

Jun 5 2018

safaalfulaij added a comment to D13219: Locale-aware formatting of numbers on status bar.
Jun 5 2018, 2:17 PM · Localization

Jun 3 2018

safaalfulaij added a comment to D13219: Locale-aware formatting of numbers on status bar.

Just saying... :)

Jun 3 2018, 5:13 PM · Localization

May 31 2018

safaalfulaij added a comment to D13098: Right-align all translation count columns in Project Overview.

Thank you. lokalize --reverse works for me. I’ve now modified the behaviour so that the numeric columns are right-aligned for *both* RTL and LTR languages: https://cgit.kde.org/lokalize.git/commit/?id=83590be3996e2c2013f69ce8a850f508c4db9d53

May 31 2018, 4:53 PM · Localization

May 30 2018

safaalfulaij added a comment to D13098: Right-align all translation count columns in Project Overview.

Hm, I’m trying to test this, but I’m not sure how I can get a RTL layout. If I run

LC_ALL=ar_en.UTF-8 lokalize

I get some Arabic-looking digits in the four translation count columns, but they are left-aligned (before the patch). But they should be right-aligned?

May 30 2018, 6:13 AM · Localization

May 29 2018

safaalfulaij added a comment to D13098: Right-align all translation count columns in Project Overview.

Sorry for reaching late.
This is a nice imporovment, it just needs one bit to work with RTL layouts as well :)
Right now, and before this patch, it's being displayed correctly (aligned to right).

May 29 2018, 7:04 AM · Localization

May 17 2018

safaalfulaij added inline comments to D12904: Fixed ugly message dialog on Compare by Content error.
May 17 2018, 11:16 PM · Krusader

Apr 15 2018

safaalfulaij added a comment to D12130: Use the more user-friendly string "File type" in the save dialogs.

Btw, the qt tag is from Qt3 days. I'm not sure if it must be richtext, if so then a simple html or even KUIT markups are better choice :)

Apr 15 2018, 3:47 AM · Frameworks

Apr 12 2018

safaalfulaij added inline comments to D12102: Port Language KCM to Qt Quick.
Apr 12 2018, 4:29 AM · Kirigami, Plasma

Mar 19 2018

safaalfulaij added a comment to T8198: Extend the text tool..

Hi :)
I'd like to thank you all for the work done on supporting SVG and RTL text. This is really appreciated.

I was testing one of the last nightly (or beta) builds and found out that the direction of Arabic text is LTR. The special SVG "direction" property is needed for the direction to be applied.

Another small issue: If you typed a LTR sentence and then hit Enter then typed a RTL sentence, (and you applied the direction property to the RTL one), you'll get this: :)

Font-variant for all sorts of open type features. (This will require modifying QT itself to get access to Harfbuzz)

This will be really beneficial for many software, but I'm not sure Qt will expose that stuff so easily...
As you know, Scribus went the long way and added support by using HarfBuzz directly.

That's all. Thanks!

Could you please report a bug for these at bugs.kde.org? Phabricator comments are too difficult to track bugs in.

(Also, add a screenshot of what it looks like in the editor then)

Mar 19 2018, 3:29 PM · Krita: Abyss

Mar 17 2018

safaalfulaij added a comment to T8198: Extend the text tool..

Hi :)
I'd like to thank you all for the work done on supporting SVG and RTL text. This is really appreciated.

Mar 17 2018, 11:29 AM · Krita: Abyss

Feb 25 2018

safaalfulaij committed R883:1511355: Update Arabic translations..
Update Arabic translations.
Feb 25 2018, 12:34 PM

Feb 19 2018

safaalfulaij accepted D10592: fix RTL appearance for ComboBox.

Now since I'm a reviewer, sure :)

Feb 19 2018, 6:04 PM · Frameworks, Plasma
safaalfulaij added a comment to D10592: fix RTL appearance for ComboBox.

@safaalfulaij is there a green light for this?

Feb 19 2018, 5:33 PM · Frameworks, Plasma

Feb 16 2018

safaalfulaij added inline comments to D10592: fix RTL appearance for ComboBox.
Feb 16 2018, 9:13 PM · Frameworks, Plasma
safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

Reported: https://bugreports.qt.io/browse/QTBUG-66446
Although this is really unlikly to happen, a widget having a combobox, but this is the case of Latte where the whole config overlay is just a MouseArea.

Feb 16 2018, 11:15 AM · Frameworks, Plasma
safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3

Feb 16 2018, 10:52 AM · Frameworks, Plasma
safaalfulaij added a comment to D9275: fix RTL appearance for ComboBox.

I've done some more testing and read some Qt docs. Popup item get reparented to the window once displayed, so LayoutMirroring is applied to it only at that point (applying it to the contentItem).
So my comments above about Popup not inheerting Item are wrong, sorry.
I'm still not sure if this is needed really.

Feb 16 2018, 10:20 AM · Frameworks, Plasma