Deprecate Panel icon size and port away from it
Closed, ResolvedPublic

Description

KIconLoader::Panel is used as a maximum icon size for panel applets. This is problematic for the following reasons:

  1. It is not communicated to the user that this is a maximum size, and communicating it is somewhat challenging with the current UI
  2. Most panel applets no longer respect it, instead either setting a hardcoded maximum size (rare) or scaling with the panel and respecting its margins, so using it as originally intended no longer really works
  3. Since it's configurable, users can change it, see no visible effects, forget to change it back, and then complain when Kickoff's panel icon is too small if they make their panel thick

Even in its heyday, the only conceivable application of the maximum panel icon size being configurable separately from the panel thickness itself is to be able to have a thick panel with small icons in it. This functionality was already mostly implemented with @niccolove's margins separator feature, and anything beyond that seems like pointless over-configurability to me.

I'd like to propose that we deprecate this icon size, port any users of it to use KIconLoader::Enormous for their maximum size instead, and then remove the configuration UI from the Icons KCM.

ngraham created this task.Apr 5 2021, 7:03 PM

Seems correct to me

ndavis added a subscriber: ndavis.Apr 6 2021, 1:24 AM

makes sense to me too

PlasmaCore.Units.iconSizeHints.panel is still used a lot

All should be ported away from and instead take up maximum space according to panel thickness, so that all applets have consistent sizing properties that are based on something easy to understand: the panel thickness.

As far as I can tell most usages don't actually affect anything, so I don't think there's a practical consistency problem.

See https://invent.kde.org/plasma/bluedevil/-/merge_requests/115

Right, because we've been removing the feature in fits and starts over time. It used to be a consistency problem. At this point it's just dead code.

nicolasfella moved this task from Backlog to Done on the KF6 board.May 28 2023, 10:28 PM
ngraham closed this task as Resolved.Jan 11 2024, 6:44 PM
ngraham claimed this task.

This is done in Plasma 6.