davidre (David Redondo)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 21 2018, 9:30 AM (79 w, 6 h)
Availability
Available

Recent Activity

Mon, May 25

davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Mon, May 25, 9:34 AM · Spectacle

Sat, May 23

davidre committed R237:24e0799ccc85: Add KStandardShortcut::findByName(const QString&) and deprecate find(const… (authored by davidre).
Add KStandardShortcut::findByName(const QString&) and deprecate find(const…
Sat, May 23, 8:10 AM

Fri, May 22

davidre committed R237:9bbf7cf53f57: Fix KStandardShortcut::find(const char*) (authored by davidre).
Fix KStandardShortcut::find(const char*)
Fri, May 22, 8:12 PM

Wed, May 20

davidre committed R166:84f85ab4d8f8: Add logo for gitlab (authored by davidre).
Add logo for gitlab
Wed, May 20, 11:51 AM
davidre committed R166:f12561da49a1: Update README and CONTRIBUTING for gitlab and release service (authored by davidre).
Update README and CONTRIBUTING for gitlab and release service
Wed, May 20, 11:40 AM

Tue, May 19

davidre committed R119:1eecde8bcda2: Fix typo (authored by davidre).
Fix typo
Tue, May 19, 4:07 PM
davidre added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

I assume that you mean:

Action after taking a screenshot: [] Save image to default folder location
                                  [] Copy image to clipboard

What about Copy file location to clipboard after saving, would that stay in the Save settings tab?
If yes - we'd have a problem if a users sets both of the checkboxes above and has Copy file location to clipboard after saving also set.

Tue, May 19, 3:24 PM · Spectacle
davidre accepted D29589: Remove unused variable.
Tue, May 19, 7:32 AM · Spectacle
davidre added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

Tue, May 19, 7:32 AM · Spectacle

Sat, May 16

davidre accepted D29802: Require out-of-source builds.
Sat, May 16, 8:18 PM · Frameworks
davidre requested changes to D29802: Require out-of-source builds.

I don't think we want to require in source builds

Sat, May 16, 7:55 PM · Frameworks
davidre added inline comments to D29140: Show POTD in lock screen.
Sat, May 16, 9:56 AM · Plasma
davidre added a comment to D29140: Show POTD in lock screen.

Flickr works here

For the leaks, I really have no idea. (also asked some friends but no help) C++ isn't my primary programming language. If you can share some document/tutorials/examples...

In C++ there is automatic and dynamic storage duration (and some others but you don't need to care about them for now). Automatic is the normal when you write

 void f() {
    int i = 0;
    [complicated code]
}

i is automatically allocated at the start of the function and deallocated at the end of the function. Objects with automatic storage duration are deallocated at the end of the scope they were declared in. You can't use a variable that you declare in a for loop or inside an if block outside of them because the scope they were declared in (the foor loop or the if block) has ended. You can also manually create a scope by wrapping code with braces.

Sat, May 16, 8:23 AM · Plasma

Thu, May 14

davidre added a comment to D29140: Show POTD in lock screen.

I don't get how saving as a png fails if we have the image as QImage.

Thu, May 14, 3:09 PM · Plasma
davidre added a comment to T7266: Standard Shortcuts.

I wonder if this could be integrated into the new Global Shortcuts KCM (after renaming it to just "Shortcuts"). We could add a new category called "Common shortcuts" under the Applications section. What do you think, @davidre?

I think it could work. I'm not sure if it should be under Applications. I think it could be missed there. I would introduce a new section called "Common Shortcuts" or "Standard Shortcuts". Then I would like to categorize all current KStandardShortcuts (either in the kcm or on frameworks side) to have multiple things in the category like Editing or Navigation for Example. This would also make it easier to find specific shortcuts.

Thu, May 14, 8:13 AM · Plasma: KCM Redesign
davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

I didn't review the entire code yet but seems much cleaner. A very welcome refactor!
I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Thu, May 14, 8:03 AM · Spectacle
davidre added a comment to D29140: Show POTD in lock screen.

I fail to see what the kded module actually does. Or is it the case that simply requesting the data from the engine causes it to cache the image on disk? Maybe that should be documented.

Thu, May 14, 7:22 AM · Plasma

Wed, May 13

davidre planned changes to D29701: Disable horizontal scrollbar in kcm.
Wed, May 13, 12:56 PM · Plasma
davidre planned changes to D29703: Disable horizontal scrollbars.
Wed, May 13, 12:56 PM · Plasma
davidre planned changes to D29704: Disable horizonal scrollbars.
Wed, May 13, 12:55 PM · Plasma
davidre added a reviewer for D29703: Disable horizontal scrollbars: Plasma.
Wed, May 13, 12:49 PM · Plasma
davidre updated the diff for D29703: Disable horizontal scrollbars.

do it for all

Wed, May 13, 12:49 PM · Plasma
davidre added a reviewer for D29704: Disable horizonal scrollbars: Plasma.
Wed, May 13, 12:37 PM · Plasma
davidre retitled D29704: Disable horizonal scrollbars from [kcms/baloo] Disable horizonal scrollbar to Disable horizonal scrollbars.
Wed, May 13, 12:36 PM · Plasma
davidre updated the diff for D29704: Disable horizonal scrollbars.

Do it for every scrollview

Wed, May 13, 12:36 PM · Plasma
davidre requested review of D29704: Disable horizonal scrollbars.
Wed, May 13, 11:04 AM · Plasma
davidre requested review of D29703: Disable horizontal scrollbars.
Wed, May 13, 10:57 AM · Plasma
davidre added a comment to D29701: Disable horizontal scrollbar in kcm.

Should this go to master, too? Or should we hope that we need the workaround only for 5.18 and 5.19 and the qtbug will be fixed eventually?

Wed, May 13, 10:52 AM · Plasma
davidre updated the diff for D29701: Disable horizontal scrollbar in kcm.

.

Wed, May 13, 10:51 AM · Plasma
davidre requested review of D29701: Disable horizontal scrollbar in kcm.
Wed, May 13, 10:49 AM · Plasma
davidre added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

Wed, May 13, 7:10 AM · Spectacle

Tue, May 12

davidre committed R119:847d9216e0c1: [kcms/keys] Use better collator settings (authored by davidre).
[kcms/keys] Use better collator settings
Tue, May 12, 7:10 AM
davidre closed D29632: [kcms/keys] Use better collator settings.
Tue, May 12, 7:10 AM · Plasma
davidre updated the diff for D29632: [kcms/keys] Use better collator settings.

numeric

Tue, May 12, 7:09 AM · Plasma
davidre closed D29644: Select application after it is added.
Tue, May 12, 7:03 AM · Plasma
davidre committed R119:bc5c1d882ed8: Select application after it is added (authored by davidre).
Select application after it is added
Tue, May 12, 7:03 AM
davidre committed R119:12a14a789da4: [kcms/keys] Really ignore unknown action (authored by davidre).
[kcms/keys] Really ignore unknown action
Tue, May 12, 6:58 AM
davidre closed D29579: [kcms/keys] Really ignore unknown action.
Tue, May 12, 6:58 AM · Plasma
davidre committed R119:fcb04768142f: [kcms/keys] Make saving sync (authored by davidre).
[kcms/keys] Make saving sync
Tue, May 12, 6:58 AM
davidre closed D29635: [kcms/keys] Make saving sync.
Tue, May 12, 6:58 AM · Plasma
davidre updated the diff for D29644: Select application after it is added.

Use PropertyAction

Tue, May 12, 6:52 AM · Plasma

Mon, May 11

davidre updated the summary of D29644: Select application after it is added.
Mon, May 11, 3:36 PM · Plasma
davidre requested review of D29644: Select application after it is added.
Mon, May 11, 3:35 PM · Plasma
davidre added inline comments to D29632: [kcms/keys] Use better collator settings.
Mon, May 11, 3:06 PM · Plasma
davidre requested review of D29635: [kcms/keys] Make saving sync.
Mon, May 11, 2:17 PM · Plasma
davidre retitled D29632: [kcms/keys] Use better collator settings from Use better collator settings to [kcms/keys] Use better collator settings.
Mon, May 11, 1:34 PM · Plasma
davidre requested review of D29632: [kcms/keys] Use better collator settings.
Mon, May 11, 1:33 PM · Plasma
davidre committed R166:a0226fc3b84e: Merge branch 'release/20.04' (authored by davidre).
Merge branch 'release/20.04'
Mon, May 11, 1:31 PM
davidre committed R166:b851ca17ae57: Disconnect after receiving screenshot signal (authored by davidre).
Disconnect after receiving screenshot signal
Mon, May 11, 1:29 PM
davidre closed D29620: Disconnect after receiving screenshot signal.
Mon, May 11, 1:29 PM · Spectacle
davidre committed R120:5459a533974e: Improve StatusNotifierTest (authored by davidre).
Improve StatusNotifierTest
Mon, May 11, 12:44 PM
davidre closed D29619: Improve StatusNotifierTest.
Mon, May 11, 12:44 PM · Plasma
davidre updated the diff for D28208: Move sni icon handling logic from data engine to applet.
  • fix
Mon, May 11, 12:43 PM · Plasma
davidre added a comment to D29625: Add global shortcut.

-1 for khotkeys.

Mon, May 11, 11:36 AM · Plasma
davidre added a comment to D29625: Add global shortcut.

-1 for khotkeys.

Mon, May 11, 11:34 AM · Plasma
davidre added a comment to D29550: Add selection support for already taken screenshots.

Ah I see, the select button will change the pixmap what is saved/copied but not the displayed one?

Mon, May 11, 8:40 AM · Spectacle
davidre requested review of D29620: Disconnect after receiving screenshot signal.
Mon, May 11, 8:38 AM · Spectacle
davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

I would like to keep the option. We currently just start a new `Qprocess with "spectacle" would that still work?

Mon, May 11, 8:19 AM · Spectacle
davidre added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

Mon, May 11, 8:16 AM · Spectacle
davidre added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

Mon, May 11, 8:12 AM · Spectacle
davidre added a comment to D29550: Add selection support for already taken screenshots.

Very cool! However I can't seem to figure out a way to select a selection.
How do you think does this relate to D22074? Maybe we can integrate both patches somehow?

Mon, May 11, 8:07 AM · Spectacle
davidre added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

So on screen we have the non rectangular pixel perfect pixmap but we return a rectangular pixmap? Which size will that have?

Mon, May 11, 8:00 AM · Spectacle
davidre accepted D29475: [Global Shortcuts KCM] Also check PortableText.
Mon, May 11, 7:48 AM · Plasma
davidre abandoned D29580: [kcms/keys] Also consider portable text when filtering.
Mon, May 11, 7:48 AM · Plasma
davidre updated the diff for D28208: Move sni icon handling logic from data engine to applet.
  • Rebase without test
Mon, May 11, 7:44 AM · Plasma
davidre added a comment to D29619: Improve StatusNotifierTest.

Mon, May 11, 7:32 AM · Plasma
davidre requested review of D29619: Improve StatusNotifierTest.
Mon, May 11, 7:31 AM · Plasma

Sun, May 10

davidre requested review of D29580: [kcms/keys] Also consider portable text when filtering.
Sun, May 10, 10:19 AM · Plasma
davidre requested review of D29579: [kcms/keys] Really ignore unknown action.
Sun, May 10, 10:12 AM · Plasma

Thu, May 7

davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Just a heads up you don't need to use the weird lvariable, theParam code style. See discussion in https://phabricator.kde.org/D21042

Thu, May 7, 9:45 AM · Spectacle

Mon, May 4

davidre added a comment to T13075: Move all things in Plasma to PC3, and then to QQC2.

Why go through QStyle then? We have much more Plasma themes and plasma theme can also be used a quick controls style. The only problem is that in Plasma we want to have two different styles in the same process which is currently not possible. Kai had the idea of a proxy quick controls style which would select the approbiate style plasma or org.kde.desktop depending on if something is part of the shell or not (like the config windows) but that needs investigation if that is possible/feasible.

Mon, May 4, 5:02 PM · Goal: Consistency, VDG, Plasma

Sat, May 2

davidre added a comment to T13075: Move all things in Plasma to PC3, and then to QQC2.

So you want to remove plasma themes?

Sat, May 2, 6:58 PM · Goal: Consistency, VDG, Plasma

Thu, Apr 30

davidre committed R119:1ee6660ceb62: Rewrite of the global shortcuts kcm (authored by davidre).
Rewrite of the global shortcuts kcm
Thu, Apr 30, 4:51 PM
davidre closed T7267: Global Shortcuts as Resolved by committing R119:1ee6660ceb62: Rewrite of the global shortcuts kcm.
Thu, Apr 30, 4:51 PM · Plasma: KCM Redesign
davidre closed D28744: Rewrite of the global shortcuts kcm.
Thu, Apr 30, 4:51 PM · Plasma

Wed, Apr 29

davidre added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Can you add some more explanation what the code does in the summary?

Wed, Apr 29, 6:00 PM · Spectacle
davidre abandoned D25144: [RFC][Global Shortcuts KCM] Categorize into Applications and System Services.

Superseeded by total rewrite of the kcm

Wed, Apr 29, 1:33 PM · Plasma
davidre added a comment to D28744: Rewrite of the global shortcuts kcm.

I find that I'm not able to set shortcuts involving the space key. The key sequence get repeated twice in the button and the Apply button ever becomes enabled. Can you reproduce?

Wed, Apr 29, 9:53 AM · Plasma
davidre committed R308:e56def21a286: Print a warning if runner is incompatible with KRunner (authored by davidre).
Print a warning if runner is incompatible with KRunner
Wed, Apr 29, 7:31 AM
davidre closed D28624: Print a warning if runner is incompatible with KRunner.
Wed, Apr 29, 7:31 AM · Frameworks

Tue, Apr 28

davidre added a comment to D28093: [breeze-icons] add TeamViewer tray icons.

Couldn't we put the tray icon in the plasma theme?

Tue, Apr 28, 3:45 PM · Frameworks
davidre updated the diff for D28744: Rewrite of the global shortcuts kcm.
  • Reinstate the pointingHand mouseAreas
  • Make delegate automatically expand if it's the only one
Tue, Apr 28, 3:36 PM · Plasma
davidre committed R166:f00994d98aed: Remove PLASMA_MIN_VERSION (authored by davidre).
Remove PLASMA_MIN_VERSION
Tue, Apr 28, 3:03 PM
davidre updated the diff for D28744: Rewrite of the global shortcuts kcm.
  • Make the delegate use states
Tue, Apr 28, 1:49 PM · Plasma
davidre added a comment to D29154: Use QWindow overload of QIcon::pixmap.

I did some digging and think that things should be repainted when they change screen
https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#_ZN13QWidgetWindow18handleScreenChangeEv

Tue, Apr 28, 11:48 AM · Plasma
davidre added inline comments to D29232: Introduce the Header color set.
Tue, Apr 28, 6:58 AM · Frameworks

Mon, Apr 27

davidre added inline comments to D29232: Introduce the Header color set.
Mon, Apr 27, 8:25 PM · Frameworks

Apr 27 2020

davidre added a comment to D29225: Resize all item style.

Yeah I don't think we are going to just randomly change that many constants based on two screenshots. This needs a wide discussion imo with what goals to achieve and the problems with the current breeze and much more comparisons.

Apr 27 2020, 3:12 PM
davidre updated the diff for D28744: Rewrite of the global shortcuts kcm.

rebasae

Apr 27 2020, 7:29 AM · Plasma
davidre updated the diff for D28744: Rewrite of the global shortcuts kcm.
  • Use model.* properties
  • Use placeholder message
  • Still don't know why model properties are undefined when switching components
Apr 27 2020, 7:25 AM · Plasma

Apr 25 2020

davidre added a comment to T10568: Opacity Shortcuts Suggestion for Kubuntu.
In T10568#228110, @ach wrote:

FWIW I agree with David argument in the bug report and to reject the suggestion for 2 more global shortcuts.

Nevertheless you have IMHO a valid point: hard discoverability. The global shortcut
settings page could be enhanced. Enhancing this would not only help others finding
you personal favourite feature(s) but all others too.

Adding 'User Feedback' what global shortcuts people really set, could help in
future decision what action is probably a candidate for a global shortcut.

stay healthy, Achim

Apr 25 2020, 1:25 PM · Kubuntu
davidre added a comment to D29140: Show POTD in lock screen.

To totally solve the issue, there are several solutions I can find:

  1. POTD need to have a daemon process that can always access network. The lock screen send request to the daemon through DBus or other protocol.
  2. Create an invisible lock screen widget in the desktop, so it fetches and updates the POTD even before screen locks.

    The second option is much easier to do. Both will cause some performance impact.
Apr 25 2020, 9:34 AM · Plasma
davidre added a comment to D29154: Use QWindow overload of QIcon::pixmap.

Actually everything in the sidebad is very blurry at 2x

Apr 25 2020, 9:03 AM · Plasma
davidre added a comment to D29154: Use QWindow overload of QIcon::pixmap.
In D29154#656690, @apol wrote:

This is what it looks like for me with the patch applied.

scale 1x:


scale 2x:

master:
scale 1x:


scale 2x:

I can see a noticeable wonky-ness on 1x master, so I'd say this patch helps.

Apr 25 2020, 9:03 AM · Plasma

Apr 24 2020

davidre added a comment to D29157: force systemsettings for kcms.

Maybe todo remove?

Apr 24 2020, 5:23 PM · Plasma
davidre added a comment to D29154: Use QWindow overload of QIcon::pixmap.
In D29154#656585, @apol wrote:

+1

I did the same thing for kirigami @ D29100 and plasma-framework @ D29102 yesterday after looking at Qt's code and assessing it was the right thing to do.
I am not familiar with Breeze's code but the patch is sound.

I do have all of the dpis so if you tell me how I'll test it.

This should probably fix the BUG 418869.

Apr 24 2020, 5:21 PM · Plasma
davidre updated the diff for D29154: Use QWindow overload of QIcon::pixmap.

Correct code style when I'm touching these lines either way

Apr 24 2020, 3:15 PM · Plasma
davidre retitled D29154: Use QWindow overload of QIcon::pixmap from Use QWindow overload of icon.pixmap to Use QWindow overload of QIcon::pixmap.
Apr 24 2020, 3:10 PM · Plasma
davidre added a reviewer for D29154: Use QWindow overload of QIcon::pixmap: davidedmundson.
Apr 24 2020, 3:09 PM · Plasma
davidre requested review of D29154: Use QWindow overload of QIcon::pixmap.
Apr 24 2020, 3:09 PM · Plasma