davidre (David Redondo)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 21 2018, 9:30 AM (85 w, 2 d)
Availability
Available

Recent Activity

Yesterday

davidre updated subscribers of T7285: File associations.

The Konqueror part should be dropped and put into Konq itself imo @dfaure

Fri, Jul 10, 1:51 PM · Plasma: KCM Redesign

Sun, Jun 28

davidre added a comment to T11316: Systematic KCM reorganisation: Workspace section.

Is Krunner the only place where it works or are there other places?

Sun, Jun 28, 4:29 PM · Plasma, VDG

Thu, Jun 25

davidre added a comment to T7293: Web shortcuts (also to be rethinked?).

It should be in the Seach category imo and not shortcuts. It has nothing to do with keyboard shortcuts.

Thu, Jun 25, 4:13 PM · Plasma: KCM Redesign
davidre added a comment to T7288: Task Switcher.

Do we need Main and alternative which are basically just the same thing twice? There will be of course people who make use of it in their workflow

Thu, Jun 25, 4:11 PM · Plasma: KCM Redesign

Mon, Jun 15

davidre added a comment to T13285: Plasma virtual sprint 2020 feedback.
Did you have any problems with software used? (BigBlueButton and Greenlight)

Sometimes the camera feeds were frozen and I could only unfreeze them by reloading the page

What can be improved in software?

I think it should be possible to see notes and chat at the same time

Was the echo test faster after the first day, also if any one was still having problems with it?

For me it was sometimes faster, sometimes slower without a pattern that I could spot

Mon, Jun 15, 9:10 AM · Plasma, Akademy Tools

Sat, Jun 13

davidre added a comment to D29154: Use QWindow overload of QIcon::pixmap.

In my testing dragging a window to a screen with a different scalefactor has no issue and @apol said for him it's better than the status quo. So I would like to land this

Sat, Jun 13, 3:54 PM · Plasma

Jun 10 2020

davidre added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

The alternative is just less documented AFAICT.
IRC the alternative is about adding xml files that generate code.

Jun 10 2020, 7:57 AM · Spectacle
davidre accepted D29408: Wayland: allow to take immediate and delayed screenshots.

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

Jun 10 2020, 7:47 AM · Spectacle
davidre added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

Very short nice!

Jun 10 2020, 7:44 AM · Spectacle

Jun 9 2020

davidre committed R858:c7ee522c05ce: Prevent delegates and scrollbar overlapping in combobox popups (authored by davidre).
Prevent delegates and scrollbar overlapping in combobox popups
Jun 9 2020, 11:41 AM

Jun 8 2020

davidre committed R118:fbb726976389: Center the Comparison sheet and move slider into the header (authored by davidre).
Center the Comparison sheet and move slider into the header
Jun 8 2020, 10:40 AM
davidre added a comment to D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

Ping

Jun 8 2020, 7:31 AM · Frameworks
davidre added a comment to D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi.

Ping

Jun 8 2020, 7:30 AM · Kirigami

Jun 3 2020

davidre accepted D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Well it is not a flaw, it is by design.
--new-instance launches an instance without dbus connection and unique instance.
The first one without --new-instance will be the dbus unique instance.

Alright I guess. Should we maybe even hide it from the user visible options then?

Jun 3 2020, 12:20 PM · Spectacle

May 25 2020

davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

May 25 2020, 9:34 AM · Spectacle

May 23 2020

davidre committed R237:24e0799ccc85: Add KStandardShortcut::findByName(const QString&) and deprecate find(const… (authored by davidre).
Add KStandardShortcut::findByName(const QString&) and deprecate find(const…
May 23 2020, 8:10 AM

May 22 2020

davidre committed R237:9bbf7cf53f57: Fix KStandardShortcut::find(const char*) (authored by davidre).
Fix KStandardShortcut::find(const char*)
May 22 2020, 8:12 PM

May 20 2020

davidre committed R166:84f85ab4d8f8: Add logo for gitlab (authored by davidre).
Add logo for gitlab
May 20 2020, 11:51 AM
davidre committed R166:f12561da49a1: Update README and CONTRIBUTING for gitlab and release service (authored by davidre).
Update README and CONTRIBUTING for gitlab and release service
May 20 2020, 11:40 AM

May 19 2020

davidre committed R119:1eecde8bcda2: Fix typo (authored by davidre).
Fix typo
May 19 2020, 4:07 PM
davidre added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

I assume that you mean:

Action after taking a screenshot: [] Save image to default folder location
                                  [] Copy image to clipboard

What about Copy file location to clipboard after saving, would that stay in the Save settings tab?
If yes - we'd have a problem if a users sets both of the checkboxes above and has Copy file location to clipboard after saving also set.

May 19 2020, 3:24 PM · Spectacle
davidre accepted D29589: Remove unused variable.
May 19 2020, 7:32 AM · Spectacle
davidre added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

May 19 2020, 7:32 AM · Spectacle

May 16 2020

davidre accepted D29802: Require out-of-source builds.
May 16 2020, 8:18 PM · Frameworks
davidre requested changes to D29802: Require out-of-source builds.

I don't think we want to require in source builds

May 16 2020, 7:55 PM · Frameworks
davidre added inline comments to D29140: Show POTD in lock screen.
May 16 2020, 9:56 AM · Plasma
davidre added a comment to D29140: Show POTD in lock screen.

Flickr works here

For the leaks, I really have no idea. (also asked some friends but no help) C++ isn't my primary programming language. If you can share some document/tutorials/examples...

In C++ there is automatic and dynamic storage duration (and some others but you don't need to care about them for now). Automatic is the normal when you write

 void f() {
    int i = 0;
    [complicated code]
}

i is automatically allocated at the start of the function and deallocated at the end of the function. Objects with automatic storage duration are deallocated at the end of the scope they were declared in. You can't use a variable that you declare in a for loop or inside an if block outside of them because the scope they were declared in (the foor loop or the if block) has ended. You can also manually create a scope by wrapping code with braces.

May 16 2020, 8:23 AM · Plasma

May 14 2020

davidre added a comment to D29140: Show POTD in lock screen.

I don't get how saving as a png fails if we have the image as QImage.

May 14 2020, 3:09 PM · Plasma
davidre added a comment to T7266: Standard Shortcuts.

I wonder if this could be integrated into the new Global Shortcuts KCM (after renaming it to just "Shortcuts"). We could add a new category called "Common shortcuts" under the Applications section. What do you think, @davidre?

I think it could work. I'm not sure if it should be under Applications. I think it could be missed there. I would introduce a new section called "Common Shortcuts" or "Standard Shortcuts". Then I would like to categorize all current KStandardShortcuts (either in the kcm or on frameworks side) to have multiple things in the category like Editing or Navigation for Example. This would also make it easier to find specific shortcuts.

May 14 2020, 8:13 AM · Plasma: KCM Redesign
davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

I didn't review the entire code yet but seems much cleaner. A very welcome refactor!
I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

May 14 2020, 8:03 AM · Spectacle
davidre added a comment to D29140: Show POTD in lock screen.

I fail to see what the kded module actually does. Or is it the case that simply requesting the data from the engine causes it to cache the image on disk? Maybe that should be documented.

May 14 2020, 7:22 AM · Plasma

May 13 2020

davidre planned changes to D29701: Disable horizontal scrollbar in kcm.
May 13 2020, 12:56 PM · Plasma
davidre planned changes to D29703: Disable horizontal scrollbars.
May 13 2020, 12:56 PM · Plasma
davidre planned changes to D29704: Disable horizonal scrollbars.
May 13 2020, 12:55 PM · Plasma
davidre added a reviewer for D29703: Disable horizontal scrollbars: Plasma.
May 13 2020, 12:49 PM · Plasma
davidre updated the diff for D29703: Disable horizontal scrollbars.

do it for all

May 13 2020, 12:49 PM · Plasma
davidre added a reviewer for D29704: Disable horizonal scrollbars: Plasma.
May 13 2020, 12:37 PM · Plasma
davidre retitled D29704: Disable horizonal scrollbars from [kcms/baloo] Disable horizonal scrollbar to Disable horizonal scrollbars.
May 13 2020, 12:36 PM · Plasma
davidre updated the diff for D29704: Disable horizonal scrollbars.

Do it for every scrollview

May 13 2020, 12:36 PM · Plasma
davidre requested review of D29704: Disable horizonal scrollbars.
May 13 2020, 11:04 AM · Plasma
davidre requested review of D29703: Disable horizontal scrollbars.
May 13 2020, 10:57 AM · Plasma
davidre added a comment to D29701: Disable horizontal scrollbar in kcm.

Should this go to master, too? Or should we hope that we need the workaround only for 5.18 and 5.19 and the qtbug will be fixed eventually?

May 13 2020, 10:52 AM · Plasma
davidre updated the diff for D29701: Disable horizontal scrollbar in kcm.

.

May 13 2020, 10:51 AM · Plasma
davidre requested review of D29701: Disable horizontal scrollbar in kcm.
May 13 2020, 10:49 AM · Plasma
davidre added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

May 13 2020, 7:10 AM · Spectacle

May 12 2020

davidre committed R119:847d9216e0c1: [kcms/keys] Use better collator settings (authored by davidre).
[kcms/keys] Use better collator settings
May 12 2020, 7:10 AM
davidre closed D29632: [kcms/keys] Use better collator settings.
May 12 2020, 7:10 AM · Plasma
davidre updated the diff for D29632: [kcms/keys] Use better collator settings.

numeric

May 12 2020, 7:09 AM · Plasma
davidre closed D29644: Select application after it is added.
May 12 2020, 7:03 AM · Plasma
davidre committed R119:bc5c1d882ed8: Select application after it is added (authored by davidre).
Select application after it is added
May 12 2020, 7:03 AM
davidre committed R119:12a14a789da4: [kcms/keys] Really ignore unknown action (authored by davidre).
[kcms/keys] Really ignore unknown action
May 12 2020, 6:58 AM
davidre closed D29579: [kcms/keys] Really ignore unknown action.
May 12 2020, 6:58 AM · Plasma
davidre committed R119:fcb04768142f: [kcms/keys] Make saving sync (authored by davidre).
[kcms/keys] Make saving sync
May 12 2020, 6:58 AM
davidre closed D29635: [kcms/keys] Make saving sync.
May 12 2020, 6:58 AM · Plasma
davidre updated the diff for D29644: Select application after it is added.

Use PropertyAction

May 12 2020, 6:52 AM · Plasma

May 11 2020

davidre updated the summary of D29644: Select application after it is added.
May 11 2020, 3:36 PM · Plasma
davidre requested review of D29644: Select application after it is added.
May 11 2020, 3:35 PM · Plasma
davidre added inline comments to D29632: [kcms/keys] Use better collator settings.
May 11 2020, 3:06 PM · Plasma
davidre requested review of D29635: [kcms/keys] Make saving sync.
May 11 2020, 2:17 PM · Plasma
davidre retitled D29632: [kcms/keys] Use better collator settings from Use better collator settings to [kcms/keys] Use better collator settings.
May 11 2020, 1:34 PM · Plasma
davidre requested review of D29632: [kcms/keys] Use better collator settings.
May 11 2020, 1:33 PM · Plasma
davidre committed R166:a0226fc3b84e: Merge branch 'release/20.04' (authored by davidre).
Merge branch 'release/20.04'
May 11 2020, 1:31 PM
davidre committed R166:b851ca17ae57: Disconnect after receiving screenshot signal (authored by davidre).
Disconnect after receiving screenshot signal
May 11 2020, 1:29 PM
davidre closed D29620: Disconnect after receiving screenshot signal.
May 11 2020, 1:29 PM · Spectacle
davidre committed R120:5459a533974e: Improve StatusNotifierTest (authored by davidre).
Improve StatusNotifierTest
May 11 2020, 12:44 PM
davidre closed D29619: Improve StatusNotifierTest.
May 11 2020, 12:44 PM · Plasma
davidre updated the diff for D28208: Move sni icon handling logic from data engine to applet.
  • fix
May 11 2020, 12:43 PM · Plasma
davidre added a comment to D29625: Add global shortcut.

-1 for khotkeys.

May 11 2020, 11:36 AM · Plasma
davidre added a comment to D29625: Add global shortcut.

-1 for khotkeys.

May 11 2020, 11:34 AM · Plasma
davidre added a comment to D29550: Add selection support for already taken screenshots.

Ah I see, the select button will change the pixmap what is saved/copied but not the displayed one?

May 11 2020, 8:40 AM · Spectacle
davidre requested review of D29620: Disconnect after receiving screenshot signal.
May 11 2020, 8:38 AM · Spectacle
davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

I would like to keep the option. We currently just start a new `Qprocess with "spectacle" would that still work?

May 11 2020, 8:19 AM · Spectacle
davidre added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

May 11 2020, 8:16 AM · Spectacle
davidre added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

May 11 2020, 8:12 AM · Spectacle
davidre added a comment to D29550: Add selection support for already taken screenshots.

Very cool! However I can't seem to figure out a way to select a selection.
How do you think does this relate to D22074? Maybe we can integrate both patches somehow?

May 11 2020, 8:07 AM · Spectacle
davidre added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

So on screen we have the non rectangular pixel perfect pixmap but we return a rectangular pixmap? Which size will that have?

May 11 2020, 8:00 AM · Spectacle
davidre accepted D29475: [Global Shortcuts KCM] Also check PortableText.
May 11 2020, 7:48 AM · Plasma
davidre abandoned D29580: [kcms/keys] Also consider portable text when filtering.
May 11 2020, 7:48 AM · Plasma
davidre updated the diff for D28208: Move sni icon handling logic from data engine to applet.
  • Rebase without test
May 11 2020, 7:44 AM · Plasma
davidre added a comment to D29619: Improve StatusNotifierTest.

May 11 2020, 7:32 AM · Plasma
davidre requested review of D29619: Improve StatusNotifierTest.
May 11 2020, 7:31 AM · Plasma

May 10 2020

davidre requested review of D29580: [kcms/keys] Also consider portable text when filtering.
May 10 2020, 10:19 AM · Plasma
davidre requested review of D29579: [kcms/keys] Really ignore unknown action.
May 10 2020, 10:12 AM · Plasma

May 7 2020

davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Just a heads up you don't need to use the weird lvariable, theParam code style. See discussion in https://phabricator.kde.org/D21042

May 7 2020, 9:45 AM · Spectacle

May 4 2020

davidre added a comment to T13075: Move all things in Plasma to PC3, and then to QQC2.

Why go through QStyle then? We have much more Plasma themes and plasma theme can also be used a quick controls style. The only problem is that in Plasma we want to have two different styles in the same process which is currently not possible. Kai had the idea of a proxy quick controls style which would select the approbiate style plasma or org.kde.desktop depending on if something is part of the shell or not (like the config windows) but that needs investigation if that is possible/feasible.

May 4 2020, 5:02 PM · Goal: Consistency, VDG, Plasma

May 2 2020

davidre added a comment to T13075: Move all things in Plasma to PC3, and then to QQC2.

So you want to remove plasma themes?

May 2 2020, 6:58 PM · Goal: Consistency, VDG, Plasma

Apr 30 2020

davidre committed R119:1ee6660ceb62: Rewrite of the global shortcuts kcm (authored by davidre).
Rewrite of the global shortcuts kcm
Apr 30 2020, 4:51 PM
davidre closed T7267: Global Shortcuts as Resolved by committing R119:1ee6660ceb62: Rewrite of the global shortcuts kcm.
Apr 30 2020, 4:51 PM · Plasma: KCM Redesign
davidre closed D28744: Rewrite of the global shortcuts kcm.
Apr 30 2020, 4:51 PM · Plasma

Apr 29 2020

davidre added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Can you add some more explanation what the code does in the summary?

Apr 29 2020, 6:00 PM · Spectacle
davidre abandoned D25144: [RFC][Global Shortcuts KCM] Categorize into Applications and System Services.

Superseeded by total rewrite of the kcm

Apr 29 2020, 1:33 PM · Plasma
davidre added a comment to D28744: Rewrite of the global shortcuts kcm.

I find that I'm not able to set shortcuts involving the space key. The key sequence get repeated twice in the button and the Apply button ever becomes enabled. Can you reproduce?

Apr 29 2020, 9:53 AM · Plasma
davidre committed R308:e56def21a286: Print a warning if runner is incompatible with KRunner (authored by davidre).
Print a warning if runner is incompatible with KRunner
Apr 29 2020, 7:31 AM
davidre closed D28624: Print a warning if runner is incompatible with KRunner.
Apr 29 2020, 7:31 AM · Frameworks

Apr 28 2020

davidre added a comment to D28093: [breeze-icons] add TeamViewer tray icons.

Couldn't we put the tray icon in the plasma theme?

Apr 28 2020, 3:45 PM · Frameworks
davidre updated the diff for D28744: Rewrite of the global shortcuts kcm.
  • Reinstate the pointingHand mouseAreas
  • Make delegate automatically expand if it's the only one
Apr 28 2020, 3:36 PM · Plasma
davidre committed R166:f00994d98aed: Remove PLASMA_MIN_VERSION (authored by davidre).
Remove PLASMA_MIN_VERSION
Apr 28 2020, 3:03 PM
davidre updated the diff for D28744: Rewrite of the global shortcuts kcm.
  • Make the delegate use states
Apr 28 2020, 1:49 PM · Plasma
davidre added a comment to D29154: Use QWindow overload of QIcon::pixmap.

I did some digging and think that things should be repainted when they change screen
https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#_ZN13QWidgetWindow18handleScreenChangeEv

Apr 28 2020, 11:48 AM · Plasma
davidre added inline comments to D29232: Introduce the Header color set.
Apr 28 2020, 6:58 AM · Frameworks