davidre (David Redondo)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 21 2018, 9:30 AM (29 w, 4 d)
Availability
Available

Recent Activity

Today

davidre planned changes to D21638: Display delay in the taskmanager.

I think will use a Animation for the progress bar which seems less akward then using the second timer.

Sun, Jun 16, 2:10 PM · Spectacle

Yesterday

davidre added a comment to D21651: Count down the seconds until a screenshot is taken in the window title.

Wouldn't ceil do the same?

Sat, Jun 15, 7:40 AM · Spectacle

Wed, Jun 12

davidre committed R32:75a222b64e26: Grepview - Introduce a new intermediate level corresponding to lines (authored by davidre).
Grepview - Introduce a new intermediate level corresponding to lines
Wed, Jun 12, 2:53 PM
davidre closed D21580: Grepview - Introduce a new intermediate level corresponding to lines.
Wed, Jun 12, 2:53 PM · KDevelop
davidre added a comment to D21580: Grepview - Introduce a new intermediate level corresponding to lines.

ping

Wed, Jun 12, 1:13 PM · KDevelop
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Also unminimize when screenshot fails/is canceled
Wed, Jun 12, 12:49 PM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Unused leftover
Wed, Jun 12, 12:22 PM · Spectacle
davidre added inline comments to D21638: Display delay in the taskmanager.
Wed, Jun 12, 12:16 PM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Use deleteLater() to delete Timer
Wed, Jun 12, 12:15 PM · Spectacle
davidre updated the task description for T10574: Make shortcuts consistent.
Wed, Jun 12, 8:36 AM · Spectacle

Sun, Jun 9

davidre added a comment to T10997: Improve check box design.

Maybe something to consider:

Sun, Jun 9, 8:39 AM · VDG, Breeze

Sat, Jun 8

davidre added a comment to D21638: Display delay in the taskmanager.

I think your setup simply exposes that the assumption that 200ms is enough is not always true. Is there something special about it?

Sat, Jun 8, 1:23 PM · Spectacle
davidre added a comment to D21638: Display delay in the taskmanager.

If you look inside SpectacleCore::takeNewScreenshot there is already the delay added. And for me it hides itself in time as it should

Sat, Jun 8, 11:17 AM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Start the capture timer only after the delay
Sat, Jun 8, 7:07 AM · Spectacle

Fri, Jun 7

davidre added inline comments to D21638: Display delay in the taskmanager.
Fri, Jun 7, 1:41 PM · Spectacle
davidre updated the test plan for D21638: Display delay in the taskmanager.
Fri, Jun 7, 1:41 PM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.

go back to continuous

Fri, Jun 7, 1:33 PM · Spectacle
davidre added a comment to D21638: Display delay in the taskmanager.

I have never done a review before and I feel like I am going a bit over the top with the testing here. But it's too late now. :)

Edit: I set up arcanist and tested your diff and everything is fine with the delay.
...
About the update rate: I think there are actually two different cases:
If the time is relatively low (<7s or something) then having an update every second isn't that helpful. For example for a 3s delay there would be two ticks total: 1/3 and 2/3. I think for these cases a smoothly filling bar would be best and look great.
For longer delay times a tick every second makes sense because one can very easily tell the rythm of the ticking if it happens 7 times or more. When one gets a feel for the ticking then one can tell exactly when the screenshot is going to be taken. I think a smoothly filling bar could work here as well though.

I don't think having two different behaviors is a good idea. I fear that one could think that one or the other are broken.
With your feedback and from others I would say let's go with continuous.

Another idea probably unrelated to this commit: Maybe the window title itself could additionally count down the seconds in the task manager. Like "Spectacle -- 3s"

I like that idea! Maybe you can do a patch for that? :)

Fri, Jun 7, 1:28 PM · Spectacle
davidre updated the test plan for D21638: Display delay in the taskmanager.
Fri, Jun 7, 9:27 AM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.
  • Comments

I thought 1 second was a bit to long so trying 500ms now

Fri, Jun 7, 9:19 AM · Spectacle
davidre updated the diff for D21638: Display delay in the taskmanager.

Better default

Fri, Jun 7, 6:50 AM · Spectacle
davidre updated the summary of D21638: Display delay in the taskmanager.
Fri, Jun 7, 6:49 AM · Spectacle
davidre added 1 blocking reviewer(s) for D21638: Display delay in the taskmanager: broulik.

Because this is heavily based on @broulik work from KDevelop he needs to agree to relicensing his code from GPL 2 to LGPL 2.

Fri, Jun 7, 6:39 AM · Spectacle
davidre added reviewers for D21638: Display delay in the taskmanager: Spectacle, broulik, felixernst.
Fri, Jun 7, 6:36 AM · Spectacle
davidre requested review of D21638: Display delay in the taskmanager.
Fri, Jun 7, 6:33 AM · Spectacle

Wed, Jun 5

davidre edited P399 (An Untitled Masterwork).
Wed, Jun 5, 3:24 PM
davidre created P399 (An Untitled Masterwork) in the S1 KDE Community space.
Wed, Jun 5, 3:24 PM
davidre committed R166:0a1f081ebe75: Change defaultSaveLocation to use QUrl (authored by davidre).
Change defaultSaveLocation to use QUrl
Wed, Jun 5, 1:45 PM
davidre closed D21556: Change defaultSaveLocation to use QUrl.
Wed, Jun 5, 1:45 PM · Spectacle

Tue, Jun 4

davidre updated the diff for D21580: Grepview - Introduce a new intermediate level corresponding to lines.

Missing idx_line

Tue, Jun 4, 3:07 PM · KDevelop
davidre updated the test plan for D21580: Grepview - Introduce a new intermediate level corresponding to lines.
Tue, Jun 4, 3:02 PM · KDevelop
davidre requested review of D21580: Grepview - Introduce a new intermediate level corresponding to lines.
Tue, Jun 4, 3:01 PM · KDevelop

Mon, Jun 3

davidre added inline comments to D21556: Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 7:34 PM · Spectacle
davidre updated the diff for D21556: Change defaultSaveLocation to use QUrl.

Remove leftover isReadable()

Mon, Jun 3, 7:34 PM · Spectacle
davidre updated the summary of D21556: Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 5:29 PM · Spectacle
davidre added inline comments to D21556: Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 9:45 AM · Spectacle
davidre updated the diff for D21556: Change defaultSaveLocation to use QUrl.
  • change to Qurl
Mon, Jun 3, 9:42 AM · Spectacle
davidre retitled D21556: Change defaultSaveLocation to use QUrl from Fix default save location to Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 9:41 AM · Spectacle
davidre added a comment to D21556: Change defaultSaveLocation to use QUrl.

Shouldn't that return a QUrl with QUrl::fromLocalFile then?

Mon, Jun 3, 9:40 AM · Spectacle
davidre updated the diff for D21556: Change defaultSaveLocation to use QUrl.

spaces around +

Mon, Jun 3, 8:10 AM · Spectacle
davidre requested review of D21556: Change defaultSaveLocation to use QUrl.
Mon, Jun 3, 8:08 AM · Spectacle

Fri, May 31

davidre created P396 (An Untitled Masterwork) in the S1 KDE Community space.
Fri, May 31, 10:45 AM

Thu, May 30

davidre closed D21095: Use qOverload instead of static_cast inside connect.
Thu, May 30, 12:24 PM · Spectacle
davidre committed R166:71232f7ef5fb: Use qOverload instead of static_cast inside connect (authored by davidre).
Use qOverload instead of static_cast inside connect
Thu, May 30, 12:24 PM

Wed, May 29

davidre added a comment to D21095: Use qOverload instead of static_cast inside connect.

Ping

Wed, May 29, 3:09 PM · Spectacle

Mon, May 27

davidre added a comment to T10873: Make QML tooltips consistent.

If I remember correctly in D18809 there was problem I had when using this style. There two tooltips would be visible and overlap eacht other (the tooltip of the listitem and the action tooltip). So this style doesn't work everywhere

Mon, May 27, 8:51 AM · Frameworks, VDG, Plasma

Fri, May 24

davidre closed D21384: Don't use QTimer::callOnTimeout.
Fri, May 24, 5:30 PM · Spectacle
davidre committed R166:bdbe5589a998: Don't use QTimer::callOnTimeout (authored by davidre).
Don't use QTimer::callOnTimeout
Fri, May 24, 5:30 PM
davidre added inline comments to D21384: Don't use QTimer::callOnTimeout.
Fri, May 24, 5:29 PM · Spectacle
davidre updated the diff for D21384: Don't use QTimer::callOnTimeout.
  • formatting
Fri, May 24, 5:28 PM · Spectacle
davidre requested review of D21384: Don't use QTimer::callOnTimeout.
Fri, May 24, 3:41 PM · Spectacle
davidre committed R166:cd3f5562a7d5: Reset the hide timer if a new inline Message is displayed (authored by davidre).
Reset the hide timer if a new inline Message is displayed
Fri, May 24, 6:41 AM
davidre closed D21352: Reset the hide timer if a new inline Message is displayed.
Fri, May 24, 6:41 AM · Spectacle

Thu, May 23

davidre committed R230:cca2c36ef129: Add davidre to relicensecheck.pl (authored by davidre).
Add davidre to relicensecheck.pl
Thu, May 23, 8:59 PM
davidre updated the diff for D21352: Reset the hide timer if a new inline Message is displayed.
  • Remove check for isActive
Thu, May 23, 8:36 AM · Spectacle
davidre added a comment to D21352: Reset the hide timer if a new inline Message is displayed.

You call start() only from inside the check, so you can just remove your stop() call above?

But that would have the same issue I'm trying to solve? There are two cases

Thu, May 23, 7:57 AM · Spectacle
davidre added a comment to D21352: Reset the hide timer if a new inline Message is displayed.

Buf if we want display a persistent inlinemessage (MessageDuration::Persistent) we don't want to unconditionally restart it.

Thu, May 23, 7:44 AM · Spectacle

Wed, May 22

davidre added a comment to D21095: Use qOverload instead of static_cast inside connect.

ping

Wed, May 22, 8:14 PM · Spectacle
davidre requested review of D21352: Reset the hide timer if a new inline Message is displayed.
Wed, May 22, 7:56 PM · Spectacle
davidre added a comment to D21334: Show inline message after image has been saved.

I see another bug however: If a message is displayed that times out after 10 seconds and inside that time frame (let's say after 8 seconds) another inline message is shown (even if it it should be persistent) the widget hides after 2 seconds. But this bug existed before this patch (i.e with sharing and copying to the clipboard).

Right. But that pre-existing problem becomes more severe the more of these messages we add. I guess we can fix that in another patch though.

Do you have commit access yet?

Wed, May 22, 4:58 PM · Spectacle
davidre added a comment to D21334: Show inline message after image has been saved.

I see another bug however: If a message is displayed that times out after 10 seconds and inside that time frame (let's say after 8 seconds) another inline message is shown (even if it it should be persistent) the widget hides after 2 seconds. But this bug existed before this patch (i.e with sharing and copying to the clipboard).

Wed, May 22, 4:49 PM · Spectacle
davidre added a comment to D21334: Show inline message after image has been saved.

Are you sure? The image saved messages should also time out and do for me too. You just have to wait the time specified in line 371 i.e. 10 seconds.

Wed, May 22, 4:43 PM · Spectacle
davidre updated the diff for D21334: Show inline message after image has been saved.
  • Properly remove the actions before showing a new inline message
Wed, May 22, 3:53 PM · Spectacle
davidre updated the test plan for D21334: Show inline message after image has been saved.
Wed, May 22, 3:47 PM · Spectacle
davidre updated the test plan for D21334: Show inline message after image has been saved.
Wed, May 22, 3:46 PM · Spectacle
davidre updated the diff for D21334: Show inline message after image has been saved.
  • Show button to open folder
Wed, May 22, 3:41 PM · Spectacle
davidre added a comment to D21334: Show inline message after image has been saved.

Thanks never knew that. After thinking about it I prefer the InlineMessage. In my mind it's unusual to show a notification for something which is the normal workflow. The purpose of a notification is to get a user's attention that something has happened.
I had the idea while using KMail yesterday actually. If you save an attachment in KMail an InlineMessage is shown (including the Button you described) and I thought to myself "Why doesn't Spectacle have this".

Wed, May 22, 1:58 PM · Spectacle
davidre added a comment to D21334: Show inline message after image has been saved.

+1, I feel like this makes sense, because in this use case you don't get a notification. Or... maybe it should generate a notification?

If we keep this, I'm not sure a link is the appropriate UI. Typically links are used to go to a website in the user's mind so they might not connect it with the locally-saved file. For this, how about a button in the KMessageWidget saying "Show Containing Folder"? This is done by adding a new QAction to the widget.

Wed, May 22, 1:20 PM · Spectacle
davidre updated the test plan for D21334: Show inline message after image has been saved.
Wed, May 22, 10:44 AM · Spectacle
davidre requested review of D21334: Show inline message after image has been saved.
Wed, May 22, 10:43 AM · Spectacle

May 15 2019

davidre added a comment to D21095: Use qOverload instead of static_cast inside connect.

Pinging this one too

May 15 2019, 2:34 PM · Spectacle
davidre added a comment to D19745: Fix system tray UI/UX & refactor.

So, I've merged done git rebase on master — just one conflicting line, rewritten after me in a better way. But now I have no way to test it, because CMake Error Could not find a configuration file for package "ECM" that is compatible with requested version "5.58.0" and even all-up-to-date Arch Linux does not provide those pieces. I've installed the latest CMake from the testing repository, but other versioning issues showed up.

I'm not a big fan of submitting without checking, but I don't see any other way around.

ECM is an KDE project https://api.kde.org/ecm/ and part of frameworks. Try installing extra-cmake-modules (don't know the exact name on arch).

May 15 2019, 11:47 AM · Plasma
davidre added a comment to D21052: Don't exit when running in gui mode and notification times out .

I don't have commit access so actually you would have to do that for me ;)

May 15 2019, 7:50 AM · Spectacle

May 14 2019

davidre added a comment to D21052: Don't exit when running in gui mode and notification times out .

ping

May 14 2019, 5:28 PM · Spectacle
davidre added inline comments to D21195: [RFC] Create a Change Colors menu (with toolbar button).
May 14 2019, 7:22 AM · Okular

May 13 2019

davidre added inline comments to D21195: [RFC] Create a Change Colors menu (with toolbar button).
May 13 2019, 9:11 PM · Okular
davidre updated the test plan for D21052: Don't exit when running in gui mode and notification times out .
May 13 2019, 11:16 AM · Spectacle
davidre updated the test plan for D21052: Don't exit when running in gui mode and notification times out .
May 13 2019, 11:15 AM · Spectacle

May 9 2019

davidre requested review of D21095: Use qOverload instead of static_cast inside connect.
May 9 2019, 11:58 AM · Spectacle

May 7 2019

davidre added a comment to D21052: Don't exit when running in gui mode and notification times out .

I know this isn't the most elegant way but I didn't want to introduce a new class member that is updated in DbusStartAgent or make notify a member to disconnect from.

May 7 2019, 11:16 AM · Spectacle

May 6 2019

davidre updated the summary of D21052: Don't exit when running in gui mode and notification times out .
May 6 2019, 6:57 PM · Spectacle
davidre updated the summary of D21052: Don't exit when running in gui mode and notification times out .
May 6 2019, 6:51 PM · Spectacle
davidre requested review of D21052: Don't exit when running in gui mode and notification times out .
May 6 2019, 6:51 PM · Spectacle
davidre resigned from D21042: Refactor Spectacle's platform backends.
May 6 2019, 5:30 PM · Spectacle, KDE Applications
davidre added inline comments to D21042: Refactor Spectacle's platform backends.
May 6 2019, 9:30 AM · Spectacle, KDE Applications
davidre added inline comments to D21042: Refactor Spectacle's platform backends.
May 6 2019, 7:52 AM · Spectacle, KDE Applications
davidre requested changes to D21042: Refactor Spectacle's platform backends.
May 6 2019, 6:34 AM · Spectacle, KDE Applications
davidre added a comment to D21042: Refactor Spectacle's platform backends.

Have to agree with Nate regarding the naming convention you are using - feels odd to me. I don't think lConfigMgr is more readable than configManager. Also following a style guide which you can't make public is a strange move in a community like KDE.

May 6 2019, 6:34 AM · Spectacle, KDE Applications

May 4 2019

davidre added a comment to D20976: Respect the user-configured mimetype when dragging an image from the main window.

Works, but lets's step back for a moment.
Is this behavior expected and can be anticipated by the user? I suppose if you drag and drop to Dolphin or some other filemanager it's fine. But if I have JPEG with some lower quality configured and drag the perfect pixmap from Spectacle to GIMP to edit it or do some annotations it suddenly is of lower quality which is quite surprising without knowing that a temporary file with the default settings is created in the background.

May 4 2019, 9:02 AM · Spectacle

May 3 2019

davidre added reviewers for D20985: Set compression to 50 is the format is png: Spectacle, cfeck, ngraham.
May 3 2019, 9:20 AM · Spectacle
davidre requested review of D20985: Set compression to 50 is the format is png.
May 3 2019, 9:18 AM · Spectacle
davidre added a reverting change for R166:0f259d9be2bd: Change default compression quality from 90 to 89: D20985: Set compression to 50 is the format is png.
May 3 2019, 9:18 AM

Apr 30 2019

davidre added a comment to D19591: Add Compression Quality slider for lossy formats.

19.04.1 tagging is on Monday, I think we should aim to fix it for this release. I don't have much time at the moment but I could put a patch together on Friday/the weekend.

Apr 30 2019, 1:31 PM · Spectacle

Apr 16 2019

davidre added a comment to D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues.

I haven't found a way to align Kirigami.FormLayout together in a repeater.

Maybe you could use twinFormLayouts like in D19873 and D19932?

Apr 16 2019, 9:28 AM · Plasma

Apr 12 2019

davidre added a comment to D19591: Add Compression Quality slider for lossy formats.

P370 (Warning may write many files)
All judging from file sizes:
JPG/JPEG: Quality has an effect
PIC: compression 0 disables compression (enabled by default?)
PNG: see above
TIF/TIFF: same as PIC
WEBP: only quality seems to have an effect

Apr 12 2019, 1:10 PM · Spectacle
davidre created P370 (An Untitled Masterwork) in the S1 KDE Community space.
Apr 12 2019, 1:04 PM

Apr 11 2019

davidre added a comment to D19591: Add Compression Quality slider for lossy formats.

I looked into Qt and it actually uses compression. It just falls back to quality if compression is not set. See: https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/image/qpnghandler.cpp#n1075
I did a quick test P367 and it seems to work. The question now is do we want to special case this for png to not accidentally break another format (would be a quick fix) or to enable it for all formats that support it. In my opinion if we do the latter we should now do testing (maybe automated?) to not run into weird quality/compression interactions for other formats.
@nrother Do you want to fix it for 19.04.1?

Apr 11 2019, 2:12 PM · Spectacle
davidre created P367 (An Untitled Masterwork) in the S1 KDE Community space.
Apr 11 2019, 2:03 PM

Apr 9 2019

davidre added a comment to T10636: Announcement text for the Applications 19.04 release.

Go for it!

Apr 9 2019, 12:06 PM · KDE Promo, KDE Applications
davidre added a comment to T10636: Announcement text for the Applications 19.04 release.

Yeah seems fine.
One small nitpick, you could always tweak the template the new thing is that you don't have to manually type it but click on the available placeholders.
So

Save settings now shows you what the filename of a screenshot will look like. You can tweak the filename template to your preferences by clicking on the available placeholders in addition to typing them in.

?

Apr 9 2019, 11:58 AM · KDE Promo, KDE Applications