- User Since
- Nov 21 2018, 9:30 AM (29 w, 4 d)
I think will use a Animation for the progress bar which seems less akward then using the second timer.
Wouldn't ceil do the same?
Wed, Jun 12
- Also unminimize when screenshot fails/is canceled
- Unused leftover
- Use deleteLater() to delete Timer
Sun, Jun 9
Maybe something to consider:
Sat, Jun 8
I think your setup simply exposes that the assumption that 200ms is enough is not always true. Is there something special about it?
If you look inside SpectacleCore::takeNewScreenshot there is already the delay added. And for me it hides itself in time as it should
- Start the capture timer only after the delay
Fri, Jun 7
go back to continuous
I don't think having two different behaviors is a good idea. I fear that one could think that one or the other are broken.
With your feedback and from others I would say let's go with continuous.
Another idea probably unrelated to this commit: Maybe the window title itself could additionally count down the seconds in the task manager. Like "Spectacle -- 3s"
I like that idea! Maybe you can do a patch for that? :)
I thought 1 second was a bit to long so trying 500ms now
Because this is heavily based on @broulik work from KDevelop he needs to agree to relicensing his code from GPL 2 to LGPL 2.
Wed, Jun 5
Tue, Jun 4
Mon, Jun 3
Remove leftover isReadable()
- change to Qurl
spaces around +
Fri, May 31
Thu, May 30
Wed, May 29
Mon, May 27
If I remember correctly in D18809 there was problem I had when using this style. There two tooltips would be visible and overlap eacht other (the tooltip of the listitem and the action tooltip). So this style doesn't work everywhere
Fri, May 24
Thu, May 23
- Remove check for isActive
But that would have the same issue I'm trying to solve? There are two cases
Buf if we want display a persistent inlinemessage (MessageDuration::Persistent) we don't want to unconditionally restart it.
Wed, May 22
I see another bug however: If a message is displayed that times out after 10 seconds and inside that time frame (let's say after 8 seconds) another inline message is shown (even if it it should be persistent) the widget hides after 2 seconds. But this bug existed before this patch (i.e with sharing and copying to the clipboard).
Are you sure? The image saved messages should also time out and do for me too. You just have to wait the time specified in line 371 i.e. 10 seconds.
- Properly remove the actions before showing a new inline message
- Show button to open folder
Thanks never knew that. After thinking about it I prefer the InlineMessage. In my mind it's unusual to show a notification for something which is the normal workflow. The purpose of a notification is to get a user's attention that something has happened.
I had the idea while using KMail yesterday actually. If you save an attachment in KMail an InlineMessage is shown (including the Button you described) and I thought to myself "Why doesn't Spectacle have this".
May 15 2019
Pinging this one too
ECM is an KDE project https://api.kde.org/ecm/ and part of frameworks. Try installing extra-cmake-modules (don't know the exact name on arch).
I don't have commit access so actually you would have to do that for me ;)
May 14 2019
May 13 2019
May 9 2019
May 7 2019
I know this isn't the most elegant way but I didn't want to introduce a new class member that is updated in DbusStartAgent or make notify a member to disconnect from.
May 6 2019
Have to agree with Nate regarding the naming convention you are using - feels odd to me. I don't think lConfigMgr is more readable than configManager. Also following a style guide which you can't make public is a strange move in a community like KDE.
May 4 2019
Works, but lets's step back for a moment.
Is this behavior expected and can be anticipated by the user? I suppose if you drag and drop to Dolphin or some other filemanager it's fine. But if I have JPEG with some lower quality configured and drag the perfect pixmap from Spectacle to GIMP to edit it or do some annotations it suddenly is of lower quality which is quite surprising without knowing that a temporary file with the default settings is created in the background.
May 3 2019
Apr 30 2019
19.04.1 tagging is on Monday, I think we should aim to fix it for this release. I don't have much time at the moment but I could put a patch together on Friday/the weekend.
Apr 16 2019
I haven't found a way to align Kirigami.FormLayout together in a repeater.
Apr 12 2019
P370 (Warning may write many files)
All judging from file sizes:
JPG/JPEG: Quality has an effect
PIC: compression 0 disables compression (enabled by default?)
PNG: see above
TIF/TIFF: same as PIC
WEBP: only quality seems to have an effect
Apr 11 2019
I looked into Qt and it actually uses compression. It just falls back to quality if compression is not set. See: https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/image/qpnghandler.cpp#n1075
I did a quick test P367 and it seems to work. The question now is do we want to special case this for png to not accidentally break another format (would be a quick fix) or to enable it for all formats that support it. In my opinion if we do the latter we should now do testing (maybe automated?) to not run into weird quality/compression interactions for other formats.
@nrother Do you want to fix it for 19.04.1?
Apr 9 2019
Go for it!
Yeah seems fine.
One small nitpick, you could always tweak the template the new thing is that you don't have to manually type it but click on the available placeholders.
Save settings now shows you what the filename of a screenshot will look like. You can tweak the filename template to your preferences by clicking on the available placeholders in addition to typing them in.