- User Since
- Nov 21 2018, 9:30 AM (66 w, 2 d)
Tue, Feb 25
That title is now not optimal isn't it? 1. It's not only in KCModule 2. It also shows unsaved settings
Mon, Feb 24
- Introduce Plasma::Theme::palette
I disagree but it's not my call
Also we need to have this on Windows, too.
Breeze-icons is part of Frameworks and these were exported/installed files. A user could easily have a reference to one of the files somewhere.
Sun, Feb 23
Sat, Feb 22
Fri, Feb 21
The editmarks should probably respect the visibility of the associated widget. In this picture I use a invisble lineedit to manage the settings of the QButtonGroup beneath (QButtonGroup isn't supported by KCOnfigDialogManager)
How does it look? Will this be opt in for other users of KConfigDialogManager?
So I think this is ready to be merged and I would do so this weekend
Thu, Feb 20
Wed, Feb 19
Code style and typos
I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired.
Could you also add documentation to whatever https://api.kde.org/frameworks/kconfig/html/kconfig_compiler.html is generated from?
Tue, Feb 18
Mon, Feb 17
Very well thought through proposal! +
Do your second step here imo
If you touch the xsd do you neeed to increase the version number?
There is now not clickable space between items:
At least it should be clickable
units is the id of the Object in the org.kde.desktop style (and in the default units file). But that is not true for all styles: In kirigamiplasmadesktopstyle it's unitsRoot and in kirigamiplasmastyle it doesn't have an id. The proper way to acess Units is through Kirigami.Units. If you are using plasma.core it also clashes with units. (I hope that's correct)
Can you explain the process of choosing which frameworks to highlight?
Can we not add more stuff to krdb, please?
Sun, Feb 16
I think the commit message got bit messed up David, pls fix before commiting :)
After clicking through the before after I still think it's to much
I think 0 doesn't look cramped at all. Increasing the spacing also increases the space usage . -1 from me
I guess? Note that I authored this diff :)
Sat, Feb 15
Add new files
Fri, Feb 14
remove debug remains
Explicitly set TextColor and palettes of the labels and react to parent changes . For example necessary for konsole
that uses stylesheet which break palette propagation and reparents the widget after creation.
Stretch is in https://doc.qt.io/qt-5/qfont.html#Stretch-enum
Thu, Feb 13
remove unused variable
Wed, Feb 12
For reference the dialog from plasma-framework:
Tue, Feb 11
Mon, Feb 10
Fri, Feb 7
As I said on Telegram, consistency is not merging two on the outside similar looking things. It's making our software look and behave in similar ways like having reusable components and solutions or the most common elements (hello Frameworks!). The same is true for KParts using this technology we can build applications that all serve their specific purpose but have the same look and behavior of their core part (for example Konsole and Yakuake). Of course you could merge all these apps but that way you end up with behemoths of apps with giant codebases and complicated configuration options to support all possible use cases with code that is overly complex and brittle because of said options.
Ping, how should I proceed?
If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :)