add kirigami-gallery icon
Needs ReviewPublic

Authored by mbruchert on Fri, Feb 7, 6:31 PM.

Details

Reviewers
mart
ndavis
Group Reviewers
VDG

Diff Detail

Repository
R266 Breeze Icons
Branch
arcpatch-D27223
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22597
Build 22615: arc lint + arc unit
mbruchert created this revision.Fri, Feb 7, 6:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFri, Feb 7, 6:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mbruchert requested review of this revision.Fri, Feb 7, 6:31 PM
mbruchert updated this revision to Diff 75194.Fri, Feb 7, 6:37 PM
  • align pixel grid
mbruchert updated this revision to Diff 75228.Sat, Feb 8, 10:48 AM
  • fix typo
mbruchert retitled this revision from add kirigami-galery icon to add kirigami-gallery icon.Sat, Feb 8, 10:49 AM
mbruchert removed a reviewer: marcorichetta.
mbruchert added a reviewer: mart.
ndavis requested changes to this revision.Sat, Feb 15, 6:00 PM
ndavis added a subscriber: ndavis.

You've got a duplicate copy of the icon in there. The bottom shadow should also be changed to be dark gray, like a darker version of the normal background color rather than a dark blue.

This revision now requires changes to proceed.Sat, Feb 15, 6:00 PM
mbruchert updated this revision to Diff 75771.Sun, Feb 16, 3:03 PM
  • fix issues
mbruchert updated this revision to Diff 75772.Sun, Feb 16, 3:05 PM
  • fix issues

I have no Idea why the diff deletes the ktrip icon.
unfortunately I cant fix that because I have no Idea how to do that with git.

ognarb added a subscriber: ognarb.Sun, Feb 16, 3:57 PM

I have no Idea why the diff deletes the ktrip icon.
unfortunately I cant fix that because I have no Idea how to do that with git.

You can try to execute this git command to solve this problem :)

git checkout origin/master icons/apps/48/ktrip.svg
mbruchert updated this revision to Diff 75859.Mon, Feb 17, 8:05 PM
  • fix issues

thank you so much!