Reorganize colorscheme colors and use them in a logical manner
Open, NormalPublic

Description

Currently, we have a lot of colorscheme colors. We don't even use all of them. The ones that we do use aren't always used in a consistent or even logical manner.

Examples of illogical and inconsistent usage:

  • The button and menu item focus color is actually controlled by the View Focus Decoration color
  • The Task Manager highlight color is controlled by the Button Focus Decoration color.
  • QPalette::Highlight is mapped to Selection Background and is used somewhat interchangeably with Focus Decoration colors. This works fine for the current version of breeze, but not for any color scheme that uses a different Selection Background color from the Focus Decoration color.
  • View NegativeText is used for MDI widget titlebars instead of Button NegativeText.
NOTE: I am looking for usage in the Breeze QStyle, QQC2/Kirigami, Breeze icons and the Breeze Plasma desktop theme.

Unused colors:

  • Window: Alternate Background, Focus Decoration, Hover Decoration
  • Button: Alternate Background
  • Selection: Alternate Background, Focus Decoration, Hover Decoration
  • Tooltip: Alternate Background, Focus Decoration, Hover Decoration
  • Complementary: Most of these aren't used, but this is because it's uncommon to use an alternative colorscheme for some parts of the UI.

Possibly unused colors:

  • I don't know for sure, but I would assume that all text colors are used.
ndavis created this task.Sep 17 2019, 7:22 PM
ndavis triaged this task as Normal priority.
ndavis moved this task from Reported to Apps Implementation on the Goal: Consistency board.
ndavis updated the task description. (Show Details)
filipf added a subscriber: VDG.Sep 23 2019, 5:00 PM

But it's not only about Plasma right? KColorScheme can also be used by applications. For example the complementary colors are especially targeted at applications if you read the documentation.

Complementary: I don't think any of these are used.

Quick lxr search, for example:
kdeconnect uses Kirigami.Theme.complementaryTextColor
ktouch uses it
as does kdenlive

When you think about reorganizing please note that all these enums are part of the public API of a frameworks library.

But it's not only about Plasma right? KColorScheme can also be used by applications. For example the complementary colors are especially targeted at applications if you read the documentation.

Complementary: I don't think any of these are used.

Quick lxr search, for example:
kdeconnect uses Kirigami.Theme.complementaryTextColor
ktouch uses it
as does kdenlive

When you think about reorganizing please note that all these enums are part of the public API of a frameworks library.

TBH, I forgot this task existed, so I never updated it. I've learned more about KColorScheme since writing it. Yes, complementary colors are used.

ndavis updated the task description. (Show Details)Sun, Dec 22, 4:55 PM