roberts (Lindsay Roberts)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2016, 11:45 AM (158 w, 3 d)
Availability
Available

Recent Activity

Oct 6 2018

roberts committed R319:f5cc6d6c9061: Restore new tab behavior (authored by roberts).
Restore new tab behavior
Oct 6 2018, 12:58 PM
roberts closed D15828: Restore new tab behavior.
Oct 6 2018, 12:58 PM · Konsole
roberts added a comment to D15828: Restore new tab behavior.

@hindenburg, @tcanabrava: I cannot find a pending a review that would re-add this functionality. Should I push this or do you want to deal with it separately?

Oct 6 2018, 7:37 AM · Konsole
roberts updated the summary of D15828: Restore new tab behavior.
Oct 6 2018, 7:32 AM · Konsole

Sep 29 2018

roberts requested review of D15828: Restore new tab behavior.
Sep 29 2018, 8:48 AM · Konsole

Jun 6 2018

roberts added a comment to M112: System Settings Alpha Graphic Redesign.

FWIW, I agree with @ngraham here, interactive elements should be visible in the view at rest. Buttons appearing on hover violates the principle of least surprise, makes selection unpredictable, and raises cognitive load.

Jun 6 2018, 7:48 PM · KDE Developers, VDG

May 6 2018

roberts committed R102:e38d60fb23f7: kcm_opengl: Fix retrieval of DRI information (authored by roberts).
kcm_opengl: Fix retrieval of DRI information
May 6 2018, 7:10 AM
roberts closed D12476: kcm_opengl: Fix retrieval of DRI information.
May 6 2018, 7:10 AM · Plasma

May 5 2018

roberts added a comment to D12476: kcm_opengl: Fix retrieval of DRI information.

It will fail gracefully, it checks for the presence of these /proc or /sys files and only acts if they exist. This code is only called if an EGL context is successfully created in any case, and in fact on Wayland rendering _is_ always direct.

May 5 2018, 9:21 AM · Plasma

May 3 2018

roberts updated the diff for D12476: kcm_opengl: Fix retrieval of DRI information.

Update to set IsDirect under Wayland.

May 3 2018, 6:32 PM · Plasma
roberts added a comment to D12476: kcm_opengl: Fix retrieval of DRI information.

Alexey: That sounds great, but unfortunately I can't get a wayland session to log in no matter how hard I try, so I can't confirm your changes. I'd suggest creating a separate review with your additions if you want to pursue this.

May 3 2018, 5:33 PM · Plasma

Apr 24 2018

roberts added inline comments to D12476: kcm_opengl: Fix retrieval of DRI information.
Apr 24 2018, 5:15 PM · Plasma
roberts updated the diff for D12476: kcm_opengl: Fix retrieval of DRI information.

Update to use /driver over /driver/module per review.

Apr 24 2018, 5:10 PM · Plasma
roberts abandoned D12499: kcm_opengl: Update to use /driver over /driver/module per review..
Apr 24 2018, 5:09 PM · Plasma
roberts requested review of D12499: kcm_opengl: Update to use /driver over /driver/module per review..
Apr 24 2018, 5:07 PM · Plasma

Apr 23 2018

roberts requested review of D12476: kcm_opengl: Fix retrieval of DRI information.
Apr 23 2018, 7:08 PM · Plasma
roberts committed R102:f4af6581d03e: kcm_opengl: Fix EGL info retrieval. (authored by roberts).
kcm_opengl: Fix EGL info retrieval.
Apr 23 2018, 7:02 PM
roberts closed D12455: kcm_opengl: Fix EGL info retrieval..
Apr 23 2018, 7:02 PM · Plasma

Apr 22 2018

roberts requested review of D12455: kcm_opengl: Fix EGL info retrieval..
Apr 22 2018, 6:09 PM · Plasma

Jul 23 2017

roberts committed R278:68c1040510d7: Remove header reliance on QWidget (authored by roberts).
Remove header reliance on QWidget
Jul 23 2017, 8:06 AM

Dec 30 2016

roberts committed R120:e43b89e2b9f3: Systray: Move all icon resolution to dataengine (authored by roberts).
Systray: Move all icon resolution to dataengine
Dec 30 2016, 6:28 PM

Oct 30 2016

roberts committed R120:8dbda77a3b8a: systemmonitor: Optimise source updates. (authored by roberts).
systemmonitor: Optimise source updates.
Oct 30 2016, 3:26 PM
roberts closed D3141: systemmonitor: Optimise source updates. by committing R120:8dbda77a3b8a: systemmonitor: Optimise source updates..
Oct 30 2016, 3:26 PM · Plasma

Oct 23 2016

roberts added reviewers for D3141: systemmonitor: Optimise source updates.: Plasma, apol.
Oct 23 2016, 12:40 PM · Plasma
roberts retitled D3141: systemmonitor: Optimise source updates. from to systemmonitor: Optimise source updates..
Oct 23 2016, 12:38 PM · Plasma

Oct 14 2016

roberts accepted D3049: Support passing generic QIcon through PlasmaWindow interface.

Looks good to me now.

Oct 14 2016, 6:12 PM · Plasma on Wayland

Oct 13 2016

roberts added inline comments to D3049: Support passing generic QIcon through PlasmaWindow interface.
Oct 13 2016, 6:32 PM · Plasma on Wayland

Oct 10 2016

roberts committed R120:749f60b89f4a: Systray: Move all icon resolution to dataengine (authored by roberts).
Systray: Move all icon resolution to dataengine
Oct 10 2016, 5:35 PM
roberts closed D2986: Systray: Move all icon resolution to dataengine by committing R120:749f60b89f4a: Systray: Move all icon resolution to dataengine.
Oct 10 2016, 5:35 PM · Plasma

Oct 9 2016

roberts updated the diff for D2986: Systray: Move all icon resolution to dataengine.

Recreated diff with arc.

Oct 9 2016, 1:30 PM · Plasma

Oct 8 2016

roberts updated the diff for D2986: Systray: Move all icon resolution to dataengine.
Oct 8 2016, 12:12 PM · Plasma
roberts retitled D2986: Systray: Move all icon resolution to dataengine from to Systray: Move all icon resolution to dataengine.
Oct 8 2016, 12:07 PM · Plasma