knauss (Sandro Knauß)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 12:50 PM (227 w, 4 d)
Availability
Available

Recent Activity

Tue, Aug 20

knauss accepted D23299: Generalize the HTML warning box for inline messages.
Tue, Aug 20, 9:11 PM · KDE PIM

Sun, Aug 18

knauss added a comment to D22900: Fix failing autotest grantleeheaderformattertest.

That's only one part of the fix. But we also want to test the Fancy date format: see D21442.

Sun, Aug 18, 8:48 AM · KDE PIM
knauss added a comment to D23167: Test grantleeheaderstyle's formatting of spamassassin headers.

This patch will only work if kdepim-addons run make install before running the tests. This issue is fixed by patch D21444 especially the part that diff on messageviewer/src/antispam/antispamconfig.cpp.

Sun, Aug 18, 8:43 AM · KDE PIM
knauss added a comment to D23165: Fix CI failure in autotest grantleeheaderstyletest.

This is not the way it should be fixed. I already added a patch that fixes that issue (but havn't commited it yet).

Sun, Aug 18, 8:37 AM · KDE PIM

Jun 24 2019

knauss accepted D19113: Text fix: Less -> Fewer options.

I also like your suggestion to use only "More >>" and "Fewer <<".

Jun 24 2019, 11:42 AM · KDE PIM
knauss added a comment to D21448: WIP: Cleanup headerstyle_util interface..

So why do you want to remove it in the first place, if you know there's a code in a header style plugin that uses those methods? And what is your proposed fix for kdepim-addons?

Jun 24 2019, 11:37 AM · KDE PIM
knauss retitled D21448: WIP: Cleanup headerstyle_util interface. from Cleanup headerstyle_util interface. to WIP: Cleanup headerstyle_util interface..
Jun 24 2019, 11:35 AM · KDE PIM
knauss updated subscribers of D21444: Run grantleeheaderstyletest without kdepim-addons and without pre installat messagelib..
Jun 24 2019, 11:30 AM · KDE PIM

Jun 20 2019

knauss added inline comments to D21444: Run grantleeheaderstyletest without kdepim-addons and without pre installat messagelib..
Jun 20 2019, 4:41 PM · KDE PIM
knauss added a comment to D21448: WIP: Cleanup headerstyle_util interface..

I assume you checked that everything still builds? I see some reference to this method in kdepim-addons?

Jun 20 2019, 4:31 PM · KDE PIM
knauss added a comment to D21447: Display resentFrom after vcard and organisation..

What does resentFrom actually represent? The sender of the vcard, if the vcard is not of the sender?

Jun 20 2019, 4:30 PM · KDE PIM

May 28 2019

knauss added inline comments to D15760: WIP: Interface for mail headers in MimeTreeParser.
May 28 2019, 10:24 AM · KDE PIM
knauss added a revision to T8568: Create Interface to MimeTreeParser for Headers: D21450: WIP: Use a HeaderFormatter to seperate process/view..
May 28 2019, 10:12 AM · KDE Privacy Goal, KDE PIM
knauss requested review of D21450: WIP: Use a HeaderFormatter to seperate process/view..
May 28 2019, 10:12 AM · KDE PIM
knauss requested review of D21449: Split css classes, to style different parts..
May 28 2019, 10:11 AM · KDE PIM
knauss requested review of D21448: WIP: Cleanup headerstyle_util interface..
May 28 2019, 10:11 AM · KDE PIM
knauss requested review of D21447: Display resentFrom after vcard and organisation..
May 28 2019, 10:11 AM · KDE PIM
knauss requested review of D21446: Use FancyLong from KMime..
May 28 2019, 10:11 AM · KDE PIM
knauss requested review of D21445: Switch from KMime::Headers::Date -> QDateTime for message header..
May 28 2019, 10:10 AM · KDE PIM
knauss requested review of D21444: Run grantleeheaderstyletest without kdepim-addons and without pre installat messagelib..
May 28 2019, 10:10 AM · KDE PIM
knauss requested review of D21443: Fix grantleeheaderstyletest..
May 28 2019, 10:09 AM · KDE PIM
knauss requested review of D21442: Fix grantleeheaderformattertest date tests.
May 28 2019, 10:09 AM · KDE PIM

May 19 2019

knauss accepted D21154: Automatically run pg_upgrade when major PostgreSQL upgrade is detected.

It looks fine now. The two open issues will be addressed separately.

May 19 2019, 8:20 PM · KDE PIM

May 14 2019

knauss added inline comments to D21154: Automatically run pg_upgrade when major PostgreSQL upgrade is detected.
May 14 2019, 10:53 PM · KDE PIM

May 13 2019

knauss added a comment to D21154: Automatically run pg_upgrade when major PostgreSQL upgrade is detected.

overall I like this patch - that is great an brings postgresql more to a usable db interface.

May 13 2019, 9:26 PM · KDE PIM

May 12 2019

knauss committed R94:a13359849ef0: Merge branch 'Applications/19.04' (authored by knauss).
Merge branch 'Applications/19.04'
May 12 2019, 9:59 PM
knauss committed R94:a5d0ad10ced2: enable TemplateParserJobTest::test_replyPlain again. (authored by knauss).
enable TemplateParserJobTest::test_replyPlain again.
May 12 2019, 9:59 PM
knauss committed R94:a58286aec8f3: Merge branch 'CVE-2019-10732' into Applications/19.04 (authored by knauss).
Merge branch 'CVE-2019-10732' into Applications/19.04
May 12 2019, 9:59 PM
knauss committed R94:ac360b3a57ea: Decryption Oracle based on forwarding PGP or S/MIME mails (CVE-2019-10732) (authored by knauss).
Decryption Oracle based on forwarding PGP or S/MIME mails (CVE-2019-10732)
May 12 2019, 9:59 PM
knauss committed R94:d7f78cc22e3a: Refresh TemplateParserJobTest::test_convertedHtml logic (authored by knauss).
Refresh TemplateParserJobTest::test_convertedHtml logic
May 12 2019, 9:59 PM
knauss committed R94:8f9b85b664be: Make unexpected data leak harder via reply. (authored by knauss).
Make unexpected data leak harder via reply.
May 12 2019, 9:59 PM
knauss closed D20847: Decryption Oracle based on forwarding PGP or S/MIME mails (CVE-2019-10732).
May 12 2019, 9:59 PM · KDE PIM
knauss committed R94:676893d23d56: Rename convertedHtmlContent-> convertedHtmlContent for reply_Plain (authored by knauss).
Rename convertedHtmlContent-> convertedHtmlContent for reply_Plain
May 12 2019, 9:59 PM
knauss committed R94:bd031ba2ede8: TemplateParser: test htmlReply. (authored by knauss).
TemplateParser: test htmlReply.
May 12 2019, 9:59 PM
knauss committed R94:6173d7fdc198: Add test cases for a Decryption Oracle based on PGP inline. (authored by knauss).
Add test cases for a Decryption Oracle based on PGP inline.
May 12 2019, 9:59 PM
knauss committed R94:ab3c3a0de869: templateparserjobtest: HTML mime parts are handled differently (authored by knauss).
templateparserjobtest: HTML mime parts are handled differently
May 12 2019, 9:59 PM
knauss committed R94:9f77a5fdab23: Add test for a normal encrypted message, to make sure decrpytion works. (authored by knauss).
Add test for a normal encrypted message, to make sure decrpytion works.
May 12 2019, 9:59 PM
knauss closed D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
May 12 2019, 9:59 PM · KDE PIM
knauss committed R94:d397aa46e809: Test mails for Decryption Oracle based on replying to PGP or S/MIME. (authored by knauss).
Test mails for Decryption Oracle based on replying to PGP or S/MIME.
May 12 2019, 9:59 PM
knauss committed R94:ab56b25bdd21: Distinguish between mMsg and mOrigMsg. (authored by knauss).
Distinguish between mMsg and mOrigMsg.
May 12 2019, 9:59 PM
knauss committed R94:fa225b1a115d: MimeTreeParser returns wrong content for inline mesasges with multiple… (authored by knauss).
MimeTreeParser returns wrong content for inline mesasges with multiple…
May 12 2019, 9:59 PM
knauss closed D20756: Distinguish between mMsg and mOrigMsg..
May 12 2019, 9:59 PM · KDE PIM
knauss requested review of D21168: create-abi-dump: Handle clang/*/include directories..
May 12 2019, 9:31 PM
knauss added a revision to T3689: Add abi compliance checker to CI: D21168: create-abi-dump: Handle clang/*/include directories..
May 12 2019, 9:31 PM · build.kde.org

Apr 26 2019

knauss added a comment to D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).

@security-team: should I split the commits code/test so they are easier to backport? On the other side adding the tests also to old code makes it more clear that this is fixed.

Apr 26 2019, 3:50 PM · KDE PIM
knauss updated the test plan for D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
Apr 26 2019, 3:48 PM · KDE PIM
knauss requested review of D20848: WIP: Constructing replies without attachments?.
Apr 26 2019, 3:47 PM · KDE PIM
knauss requested review of D20847: Decryption Oracle based on forwarding PGP or S/MIME mails (CVE-2019-10732).
Apr 26 2019, 3:41 PM · KDE PIM

Apr 25 2019

knauss updated the test plan for D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
Apr 25 2019, 12:42 PM · KDE PIM
knauss added a comment to D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).

The review is getting a little bit messy, because of all those new test data.

Apr 25 2019, 12:37 PM · KDE PIM
knauss updated the summary of D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
Apr 25 2019, 12:30 PM · KDE PIM
knauss updated the diff for D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
  • Add test cases for a Decryption Oracle based on PGP inline.
  • TemplateParser: test htmlReply.
  • Rename convertedHtmlContent-> convertedHtmlContent for reply_Plain
  • Make unexpected data leak harder via reply.
Apr 25 2019, 12:29 PM · KDE PIM
knauss updated the diff for D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
  • Add test for a normal encrypted message, to make sure decrpytion works.
  • templateparserjobtest: HTML mime parts are handled differently
  • WIP: Decryption Oracle is also possible with PGP inline.
  • TemplateParser: test htmlReply.
  • Rename convertedHtmlContent-> convertedHtmlContent for reply_Plain
  • Make unexpected data leak harder via reply.
Apr 25 2019, 12:27 PM · KDE PIM

Apr 24 2019

knauss added a comment to D20728: Adapt to printing model changes.

Please add a simple test case to make sure we catch those changes by tests.

Apr 24 2019, 8:34 PM · KDE PIM
knauss accepted D20793: Simplify GenericGrantleeFormatter.

seems good.

Apr 24 2019, 8:33 PM · KDE PIM
knauss closed D20770: Remove unused ObjectTreeParser::copyContentFrom..
Apr 24 2019, 8:25 PM · KDE PIM
knauss committed R94:e2031122c98f: Remove unused ObjectTreeParser::copyContentFrom. (authored by knauss).
Remove unused ObjectTreeParser::copyContentFrom.
Apr 24 2019, 8:25 PM
knauss committed R94:b8f95cd1fdf3: Add tests for ObjectTreeParser::htmlContent. (authored by knauss).
Add tests for ObjectTreeParser::htmlContent.
Apr 24 2019, 8:25 PM
knauss closed D20751: Add tests for ObjectTreeParser::htmlContent..
Apr 24 2019, 8:25 PM · KDE PIM
knauss committed R94:d6d2ca6d84c8: Move most of UnencryptedMessageTest tests to MimeTreeParser. (authored by knauss).
Move most of UnencryptedMessageTest tests to MimeTreeParser.
Apr 24 2019, 8:25 PM
knauss closed D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..
Apr 24 2019, 8:25 PM · KDE PIM

Apr 23 2019

knauss updated the diff for D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
  • MimeTreeParser returns wrong content for inline mesasges with multiple encrypted blocks.
  • TemplateParser: test htmlReply.
Apr 23 2019, 10:26 PM · KDE PIM
knauss updated the summary of D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
Apr 23 2019, 10:20 PM · KDE PIM
knauss updated the summary of D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
Apr 23 2019, 3:34 PM · KDE PIM
knauss updated the diff for D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
  • Add test for a normal encrypted message, to make sure decryption works.
  • templateparserjobtest: HTML mime parts are handled differently
  • WIP: Decryption Oracle is also possible with PGP inline.
Apr 23 2019, 3:27 PM · KDE PIM
knauss requested review of D20770: Remove unused ObjectTreeParser::copyContentFrom..
Apr 23 2019, 3:19 PM · KDE PIM
knauss added a revision to T3689: Add abi compliance checker to CI: D20769: abi-compliance-checker: disable clang include directories completly..
Apr 23 2019, 2:22 PM · build.kde.org
knauss requested review of D20769: abi-compliance-checker: disable clang include directories completly..
Apr 23 2019, 2:22 PM
knauss committed R94:880296b804bb: Refresh TemplateParserJobTest::test_convertedHtml logic (authored by knauss).
Refresh TemplateParserJobTest::test_convertedHtml logic
Apr 23 2019, 2:12 PM
knauss closed D20755: Refresh TemplateParserJobTest::test_convertedHtml logic.
Apr 23 2019, 2:12 PM · KDE PIM
knauss committed R94:102a0c5c3a69: Unique names for test rows. (authored by knauss).
Unique names for test rows.
Apr 23 2019, 2:12 PM
knauss committed R94:f6bfa4538808: enable TemplateParserJobTest::test_replyPlain again. (authored by knauss).
enable TemplateParserJobTest::test_replyPlain again.
Apr 23 2019, 2:12 PM
knauss closed D20754: Unique names for test rows..
Apr 23 2019, 2:12 PM · KDE PIM
knauss closed D20753: enable TemplateParserJobTest::test_replyPlain again..
Apr 23 2019, 2:12 PM · KDE PIM
knauss added a comment to D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).

This makes sense I think (and should go in IMHO), but I'm not sure if it is complete to cover all of bug 404698.

  • Do we need to be concerned about forwarding (which does include attachments AFAIK)?

make sense, yes.

Apr 23 2019, 2:04 PM · KDE PIM
knauss added a comment to D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).

Sorry if this is a stupid question :D

But does this test make sense?

I mean how is the test supposed to decrypt the encrypted part of it? How does it know the keys/password/whatever to decrypt it?

Apr 23 2019, 1:52 PM · KDE PIM
knauss updated the summary of D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..
Apr 23 2019, 1:42 PM · KDE PIM
knauss added a comment to D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..

This is git logic, that it defines this as a copy. And I think git it more or less right, as we can't move every tests because some tests need MessageViewer::BufferedHtmlWriter. Only

Apr 23 2019, 1:41 PM · KDE PIM
knauss updated the diff for D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..

update description.

Apr 23 2019, 1:41 PM · KDE PIM

Apr 22 2019

knauss added a comment to D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).

So these pass? There's no bug?

Apr 22 2019, 9:24 PM · KDE PIM
knauss added a dependent revision for D20753: enable TemplateParserJobTest::test_replyPlain again.: D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
Apr 22 2019, 9:22 PM · KDE PIM
knauss added a dependency for D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732): D20753: enable TemplateParserJobTest::test_replyPlain again..
Apr 22 2019, 9:22 PM · KDE PIM
knauss requested review of D20757: Decryption Oracle based on replying to PGP or S/MIME (CVE-2019-10732).
Apr 22 2019, 8:51 PM · KDE PIM
knauss requested review of D20756: Distinguish between mMsg and mOrigMsg..
Apr 22 2019, 8:49 PM · KDE PIM
knauss requested review of D20755: Refresh TemplateParserJobTest::test_convertedHtml logic.
Apr 22 2019, 8:49 PM · KDE PIM
knauss requested review of D20754: Unique names for test rows..
Apr 22 2019, 8:48 PM · KDE PIM
knauss requested review of D20753: enable TemplateParserJobTest::test_replyPlain again..
Apr 22 2019, 8:48 PM · KDE PIM
knauss requested review of D20751: Add tests for ObjectTreeParser::htmlContent..
Apr 22 2019, 8:48 PM · KDE PIM
knauss requested review of D20750: Move most of UnencryptedMessageTest tests to MimeTreeParser..
Apr 22 2019, 8:48 PM · KDE PIM
knauss committed R94:393520925c64: fix typo. (authored by knauss).
fix typo.
Apr 22 2019, 8:46 PM

Mar 26 2019

knauss added a comment to T10724: List of applications respecting tor proxy settings.
  • pidgin
    • use the proxy settings from the preferences and make use every account is taking the general proxy setting.
    • nice thing about this, that you can enable/disable tor on an account base.
Mar 26 2019, 12:40 PM · KDE Privacy Goal
knauss updated the task description for T10716: Add check for accidental http: usage.
Mar 26 2019, 11:42 AM · KDE Privacy Goal
knauss added a parent task for T10733: Application to change routing to the internet: T10732: apptication to monitor all ongoing traffic.
Mar 26 2019, 11:41 AM · KDE Privacy Goal
knauss added a subtask for T10732: apptication to monitor all ongoing traffic: T10733: Application to change routing to the internet.
Mar 26 2019, 11:41 AM · VDG, KDE Privacy Goal
knauss created T10733: Application to change routing to the internet.
Mar 26 2019, 11:31 AM · KDE Privacy Goal
knauss added a comment to T10732: apptication to monitor all ongoing traffic.

@vkrause: I havn't found the tool you mentioned "tcpconnect"?

Mar 26 2019, 11:27 AM · VDG, KDE Privacy Goal
knauss triaged T10732: apptication to monitor all ongoing traffic as Normal priority.
Mar 26 2019, 11:27 AM · VDG, KDE Privacy Goal
knauss closed T8622: sprint for privacy goal as Resolved.
Mar 26 2019, 10:08 AM · KDE Privacy Goal
knauss added a comment to T10728: Use HSTS for QNetworkAccessManager.

and for a kde wide search:
https://lxr.kde.org/search?_filestring=&_string=setStrictTransportSecurityEnabled

Mar 26 2019, 9:36 AM · KDE Privacy Goal

Mar 25 2019

knauss edited projects for T10731: files.kde.org redirects to mirrors with http only, added: Sysadmin; removed Websites.
Mar 25 2019, 9:32 PM · Sysadmin, KDE Privacy Goal