knauss (Sandro Knauß)
User

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 12:50 PM (192 w, 13 h)
Availability
Available

Recent Activity

Fri, Dec 14

knauss added inline comments to D17579: Handle cases where tailing "/" in CMAKE_PREFIX_PATH fails the detection of additional include directories..
Fri, Dec 14, 7:33 PM
knauss added a revision to T3689: Add abi compliance checker to CI: D17579: Handle cases where tailing "/" in CMAKE_PREFIX_PATH fails the detection of additional include directories..
Fri, Dec 14, 4:32 PM · build.kde.org
knauss requested review of D17579: Handle cases where tailing "/" in CMAKE_PREFIX_PATH fails the detection of additional include directories..
Fri, Dec 14, 4:32 PM

Thu, Dec 13

knauss added a comment to T3689: Add abi compliance checker to CI.

@bcooksley for akonadi-search we need some special settings for the abi-create step. Where we should store such settings?

Thu, Dec 13, 3:08 PM · build.kde.org
knauss updated the task description for T3689: Add abi compliance checker to CI.
Thu, Dec 13, 10:51 AM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

okay with merging D17534 CI now successfully builds the abis for the mentioned packages. (I modified the last comment)

Thu, Dec 13, 10:41 AM · build.kde.org

Wed, Dec 12

knauss added a comment to T3689: Add abi compliance checker to CI.

I use the ci-docker images to test the create-abi, but I can't reproduce why those are failing:

Wed, Dec 12, 10:01 PM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

I now looked at every repository that failed to build successfully a ABI dump
for Pim. Most of them build successful, but a few of them have issues:

Wed, Dec 12, 9:41 PM · build.kde.org
knauss committed R93:dbdee6637476: Merge branch 'Applications/18.12' (authored by knauss).
Merge branch 'Applications/18.12'
Wed, Dec 12, 8:25 PM
knauss committed R93:a371c851f325: Add missing include. (authored by knauss).
Add missing include.
Wed, Dec 12, 8:25 PM
knauss updated subscribers of T3689: Add abi compliance checker to CI.

I now looked at every repository that failed to build successfully a ABI dump for Frameworks.
As I'm not really deep into the Framworks code, so I'm unsure, if those are real issues or if those Frameworks need special handling.
Please give me any response you have to those issues. (@aacid , @dfaure, @kde-frameworks-devel)

Wed, Dec 12, 7:48 PM · build.kde.org
knauss added a revision to T3689: Add abi compliance checker to CI: D17534: Fix create-abi for more repositories..
Wed, Dec 12, 11:23 AM · build.kde.org
knauss requested review of D17534: Fix create-abi for more repositories..
Wed, Dec 12, 11:23 AM

Mon, Dec 10

knauss added a revision to T3689: Add abi compliance checker to CI: D17476: skip static libraries like kimaptest..
Mon, Dec 10, 2:39 PM · build.kde.org
knauss requested review of D17476: skip static libraries like kimaptest..
Mon, Dec 10, 2:39 PM
knauss updated the task description for T3689: Add abi compliance checker to CI.
Mon, Dec 10, 1:34 PM · build.kde.org

Sun, Dec 9

knauss added a comment to D17431: Find qplatformdefs.h for create-abi..

We're only intending on monitoring the ABI on Linux correct?

Sun, Dec 9, 1:19 PM

Sat, Dec 8

knauss updated the test plan for D17431: Find qplatformdefs.h for create-abi..
Sat, Dec 8, 2:54 PM
knauss added a revision to T3689: Add abi compliance checker to CI: D17431: Find qplatformdefs.h for create-abi..
Sat, Dec 8, 2:48 PM · build.kde.org
knauss requested review of D17431: Find qplatformdefs.h for create-abi..
Sat, Dec 8, 2:48 PM

Wed, Nov 28

knauss updated the task description for T3689: Add abi compliance checker to CI.
Wed, Nov 28, 2:59 PM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

YEAH - the artifacts are now generated. Thaks a lot!

Wed, Nov 28, 2:18 PM · build.kde.org
knauss added a comment to T8622: sprint for privacy goal.

mail to find a date is sent now.

Wed, Nov 28, 12:57 PM · Goal settings 2017
knauss added a comment to T8622: sprint for privacy goal.

Find a date at: https://bitpoll.mafiasi.de/poll/8BYKJA5B/

Wed, Nov 28, 12:52 PM · Goal settings 2017

Tue, Nov 27

knauss added a comment to T3689: Add abi compliance checker to CI.

okay still the artifacts are not saved:

Tue, Nov 27, 8:57 PM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

Yes most parts are resolved. But still packages have build errors in the create-abi step. Like:
https://build.kde.org/job/Applications/job/kdav/job/kf5-qt5%20SUSEQt5.9/50/console

Tue, Nov 27, 8:39 AM · build.kde.org

Mon, Nov 26

knauss added a comment to T3689: Add abi compliance checker to CI.

@bcooksley: Thanks, the script now runs successfully *yeah* But the artifacts are not saved, because of a typo
compat_reports/*_compat_reports.html -> compat_reports/*_compat_report.html

Mon, Nov 26, 2:33 PM · build.kde.org

Sun, Nov 25

knauss added a comment to T3689: Add abi compliance checker to CI.

Okay I see R857:a2c2c8fc3f9f in the ci-tooling repo, but jenkins jobs were not updated. When will the jobs been updated?

Sun, Nov 25, 6:52 PM · build.kde.org

Thu, Nov 22

knauss updated the test plan for D17099: Enable check-abi for SuseQt5.X builds..
Thu, Nov 22, 12:10 PM
knauss added a comment to T3689: Add abi compliance checker to CI.

Okay now the last step: enabling check-abi for our builds: D17099

Thu, Nov 22, 12:09 PM · build.kde.org
knauss added a revision to T3689: Add abi compliance checker to CI: D17099: Enable check-abi for SuseQt5.X builds..
Thu, Nov 22, 12:07 PM · build.kde.org
knauss requested review of D17099: Enable check-abi for SuseQt5.X builds..
Thu, Nov 22, 12:07 PM
knauss committed R94:1a4d6c48acdb: use external compatible include. (authored by knauss).
use external compatible include.
Thu, Nov 22, 11:04 AM

Tue, Nov 20

knauss added a comment to T3689: Add abi compliance checker to CI.

fix missing parameter platform:

diff --git a/helpers/create-abi-dump.py b/helpers/create-abi-dump.py
index ef29138..cc9830b 100755
--- a/helpers/create-abi-dump.py
+++ b/helpers/create-abi-dump.py
@@ -312,7 +312,7 @@ for library in foundLibraries:
                 "branchGroup": arguments.branchGroup,
                 "platform": arguments.platform,
         }
-        packageName = "{name}_{scmRevision}_{platform}".format(name=library.name, scmRevision=scmRevision)
+        packageName = "{name}_{scmRevision}_{platform}".format(name=library.name, scmRevision=scmRevision, platform=arguments.platform)
         ourArchive.storePackage(packageName, fileName, scmRevision, extraMetadata)
     except subprocess.CalledProcessError as e:
         retval = e.returncode
Tue, Nov 20, 4:58 PM · build.kde.org

Nov 14 2018

knauss added a comment to T8622: sprint for privacy goal.

Here my first email draft for the doodle. Please proofread and change like you think:

Nov 14 2018, 1:39 PM · Goal settings 2017

Nov 12 2018

knauss added a comment to D16719: Handle different Archive contentsSuffixes..

The metadata not being uptodate is getting only an issue, if the metadata is important. With the normal tar files the only field used from the metadata is the timestamp check, but this even used as internal stuff. Even the checksum is not used to check, that the download was correctly. As the metadata is not used for anything outside the class, you won't even notice if the metadata does not match the data.

On the other side I can fully understand your point of view . As we won't change the contentsSuffix, when there would be a update of the package.

Sorry, i'm not sure what you're concerned about happening here. While I appreciate your code is leaning on the metadata more, the window of time during which you could potentially have a newer individual metadata file vs. the server manifest is perhaps a couple of seconds at most (because we move the file over first, then update the individual metadata file, and finally rebuild the master manifest file).

I also note that a job would be comparing against prior runs of itself, so you are guaranteed that nobody else will publish a new result (Plus given you put the commit hash in the archive name, once published files should never change correct?).

To use KCoreAddons as an example, the only job that can add results to that job are the jobs for KCoreAddons itself, and because jobs can only run one at a time you'll never have a collision (because you're contained within the branch group and platform constraints as well).

In regards to publishing the updated manifest file, the publishPackage invocation doesn't return until the publishing process completes in full - so the capture command in the build job can't finish and exit until the server manifest is up to date.

Nov 12 2018, 7:49 PM
knauss added a comment to D16717: Add script to delete not needed abidumps..

Given that what is really interesting is tagged releases, perhaps instead of collecting ABI Dumps from normal builds, there should be special collection jobs run around release time (you could use a modified version of build-product-dependencies.py for this)?

Nov 12 2018, 7:09 PM

Nov 11 2018

knauss updated the diff for D16680: Build ABIs for all libraries even one is failing..

rebase.

Nov 11 2018, 8:08 AM

Nov 10 2018

knauss added a comment to T3689: Add abi compliance checker to CI.

Yes, you will need to split by that as well. This is handled normally by having one repository per platform but for ABI dumps you will have to handle that in the metadata.

Nov 10 2018, 10:33 PM · build.kde.org
knauss updated the diff for D16589: Add script to check the ABI of the created libraries..

Only work on correct platform.

Nov 10 2018, 10:33 PM
knauss requested review of D16814: add platform to metadata for create-abi-build..
Nov 10 2018, 10:29 PM
knauss added a revision to T3689: Add abi compliance checker to CI: D16814: add platform to metadata for create-abi-build..
Nov 10 2018, 10:29 PM · build.kde.org
knauss updated the diff for D16589: Add script to check the ABI of the created libraries..

rename stableBuild -> keepBranchGroup.

Nov 10 2018, 10:17 PM
knauss updated the diff for D16680: Build ABIs for all libraries even one is failing..

update environment.

Nov 10 2018, 10:11 PM
knauss updated the diff for D16719: Handle different Archive contentsSuffixes..

Fix issues.

Nov 10 2018, 10:06 PM
knauss added a comment to D16719: Handle different Archive contentsSuffixes..

We can rely on the serverManifest being the latest information here, as the window of time between the master manifest file being downloaded and parsed and resources fetched should be less than a minute at the maximum.

In the case of the ABI Reference information, you don't know about build results until they're published in the master manifest in any case as each result is stored by the latest Git commit hash. This also means that results won't change after they've been published, so for your usecase you can depend on the server manifest containing the latest information.

For the dependencies used by the rest of the system, at worst a build uses a slightly out of date result (and to date this hasn't been an issue, and is highly unlikely to occur in any case). The window of time where this would potentially happen is perhaps a maximum of 30-45 seconds.

If we were to fetch the individual metadata files that would defeat part of the reason for caching the files on the nodes locally (reducing master server load). In the case of some projects, they depend on upwards of 20-30 projects, and at least one of our build nodes is located in Canada (which has much greater latency to the master server), so this would cause builds for those projects to take much longer.

Nov 10 2018, 9:56 PM
knauss added a comment to D16717: Add script to delete not needed abidumps..

The Jenkins master does not hold copies of any of the repositories, however from my understanding you are primarily interested in the oldest result set so that shouldn't need a list of tags (it can infer a tag exists from the metadata)?

Nov 10 2018, 8:43 AM
knauss added inline comments to D16589: Add script to check the ABI of the created libraries..
Nov 10 2018, 8:37 AM

Nov 8 2018

knauss added a comment to T3689: Add abi compliance checker to CI.

Oh frameworks is built against different Qt versions (Qt5.9 and Qt5.10). We should to save the abidumps in separately for different Qt versions, as different Qt version may trigger different ABIs. Okay than we need to use platform in the abidumps, too.

Nov 8 2018, 1:47 PM · build.kde.org
knauss added a comment to D16717: Add script to delete not needed abidumps..

This utility will have to run on the server, rather than on the individual build nodes (they have very limited access to the master repository)
We'd therefore look to run this over all projects at once, rather than on a project by project basis - thoughts on how to accomplish this?

Nov 8 2018, 1:41 PM
knauss added inline comments to D16719: Handle different Archive contentsSuffixes..
Nov 8 2018, 1:37 PM
knauss added a comment to D16719: Handle different Archive contentsSuffixes..

For retrievePackage we have the issue about race-condition:

  • serverManifest is only downloaded once when initalizing the Archive -> may have outdated information
  • localMetadata and package are more tight together IMO that's why it makes sense to always use localMetadata as reference.
Nov 8 2018, 1:35 PM
knauss updated the diff for D16719: Handle different Archive contentsSuffixes..

fixes issues raised by ben.

Nov 8 2018, 1:17 PM
knauss updated the diff for D16719: Handle different Archive contentsSuffixes..

update indent.

Nov 8 2018, 12:59 PM
knauss updated the diff for D16589: Add script to check the ABI of the created libraries..

add documentation to Version and replace branch with branchGroup.

Nov 8 2018, 10:56 AM
knauss updated the diff for D16705: Add branch and project information to package metadata..

use branchGroup instead of git branch.

Nov 8 2018, 9:48 AM

Nov 7 2018

knauss added inline comments to D16705: Add branch and project information to package metadata..
Nov 7 2018, 9:33 AM

Nov 6 2018

knauss updated the diff for D16589: Add script to check the ABI of the created libraries..

just a small update.

Nov 6 2018, 9:07 PM
knauss added a revision to T3689: Add abi compliance checker to CI: D16719: Handle different Archive contentsSuffixes..
Nov 6 2018, 9:05 PM · build.kde.org
knauss requested review of D16719: Handle different Archive contentsSuffixes..
Nov 6 2018, 9:05 PM
knauss requested review of D16717: Add script to delete not needed abidumps..
Nov 6 2018, 8:13 PM
knauss added a revision to T3689: Add abi compliance checker to CI: D16717: Add script to delete not needed abidumps..
Nov 6 2018, 8:13 PM · build.kde.org
knauss added a comment to D16589: Add script to check the ABI of the created libraries..

After thinking more about it I implement the whole logic different.

Nov 6 2018, 7:11 PM
knauss updated the diff for D16589: Add script to check the ABI of the created libraries..

add logic to find the last released version of a library.

Nov 6 2018, 7:01 PM
knauss added inline comments to D16589: Add script to check the ABI of the created libraries..
Nov 6 2018, 12:10 PM
knauss updated the diff for D16589: Add script to check the ABI of the created libraries..

Fixed bcooksley issues.

Nov 6 2018, 12:10 PM
knauss requested review of D16705: Add branch and project information to package metadata..
Nov 6 2018, 12:07 PM
knauss added a revision to T3689: Add abi compliance checker to CI: D16705: Add branch and project information to package metadata..
Nov 6 2018, 12:07 PM · build.kde.org

Nov 5 2018

knauss added a comment to D16589: Add script to check the ABI of the created libraries..

than we have no blockers anymore.

Nov 5 2018, 6:58 PM
knauss updated the diff for D16589: Add script to check the ABI of the created libraries..

cleanup if we store .abidump files in build-artifacts.

Nov 5 2018, 12:34 PM
knauss requested review of D16680: Build ABIs for all libraries even one is failing..
Nov 5 2018, 12:32 PM
knauss added a revision to T3689: Add abi compliance checker to CI: D16680: Build ABIs for all libraries even one is failing..
Nov 5 2018, 12:31 PM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

D16589 now saves the the reports into $WORKSPACE/compat_report/LIB_NAME_compat_report.html.
Before activating the check-abi.py script we need to cleanup the build-artifacts.kde.org ABIReference directory and I need to cleanup check-abi.py to not create the symlinks.

Nov 5 2018, 11:59 AM · build.kde.org
knauss added inline comments to D16589: Add script to check the ABI of the created libraries..
Nov 5 2018, 11:55 AM
knauss updated the diff for D16589: Add script to check the ABI of the created libraries..
  • run for all libraries, do not stop at first failure.
  • safe comapt_reports to a place where it is accessible by jenkins for artifacts.
  • cleanup script.
Nov 5 2018, 11:20 AM
knauss added a comment to T8567: Add DKIM Status.

Keep in mind:

  • Automatically checking DKIM signature for every mail can have a privacy breach, as you trigger automatically access to the internet - what happens if the server creates one cert per mail, than the server can tell when you access/view the mail.
  • When viewing old mails, the cert may be expired /replaced already.
Nov 5 2018, 10:01 AM · KDE PIM

Nov 3 2018

knauss added a comment to T3689: Add abi compliance checker to CI.

so I need to specify the exact path to html files, for the archiveArtifacts? The default is compat_reports/LIB_NAME/V1_to_V2/compat_report.html, but I can change this to \$WORKSPACE/LIB_NAME_compat_report.html than it would be '*.html'.

Nov 3 2018, 10:26 PM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

Do I just need to copy them to \$WORKSPACE directory and than tell Jenkins to store *.html. Like this:

Nov 3 2018, 10:17 PM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.
Nov 3 2018, 4:35 PM · build.kde.org

Nov 2 2018

knauss added inline comments to D16581: Not every data we store in the package is a tar file..
Nov 2 2018, 8:52 PM
knauss added a comment to T3689: Add abi compliance checker to CI.

Alas there is no native Jenkins publishing plugin - https://issues.jenkins-ci.org/browse/JENKINS-48221

This means we'd have to publish the actual compatibility report.

The easiest way in this case would probably be using Jenkins artifact system, which would attach the report as an artifact to the job.

Nov 2 2018, 9:38 AM · build.kde.org

Nov 1 2018

knauss added inline comments to D16589: Add script to check the ABI of the created libraries..
Nov 1 2018, 2:23 PM
knauss added a comment to T3689: Add abi compliance checker to CI.

I now created a first script to check the ABI in D16589. How we get the compat_report.html available in jenkins? (D16581 should make it possiible to get rid of the creation/removal symlinks.)

Nov 1 2018, 2:22 PM · build.kde.org
knauss added a revision to T3689: Add abi compliance checker to CI: D16589: Add script to check the ABI of the created libraries..
Nov 1 2018, 2:16 PM · build.kde.org
knauss requested review of D16589: Add script to check the ABI of the created libraries..
Nov 1 2018, 2:16 PM
knauss added inline comments to D16581: Not every data we store in the package is a tar file..
Nov 1 2018, 11:34 AM
knauss updated the diff for D16581: Not every data we store in the package is a tar file..

Fixed Ben's issues.

Nov 1 2018, 11:32 AM
knauss added a comment to T3689: Add abi compliance checker to CI.

Also I need the project name in the metadata, otherwise I would need to reparse the buildlog again.

Nov 1 2018, 10:41 AM · build.kde.org
knauss edited tasks for D16581: Not every data we store in the package is a tar file., added: T3689: Add abi compliance checker to CI; removed Unknown Object (Maniphest Task).
Nov 1 2018, 10:21 AM
knauss added a revision to T3689: Add abi compliance checker to CI: D16581: Not every data we store in the package is a tar file..
Nov 1 2018, 10:21 AM · build.kde.org
knauss requested review of D16581: Not every data we store in the package is a tar file..
Nov 1 2018, 10:20 AM
knauss added a comment to T3689: Add abi compliance checker to CI.

I need a way to differ the stable/master branch builds afterwards. branchGroup is suitable for that, as it also gives the information about the Qt version used. But any other other field is also fine, like branch. Maybe we can also modify the Archive.name and Archive.platform so we have different directories for stable/master builds.

Nov 1 2018, 10:18 AM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

yes I was referring to exactly this.

Nov 1 2018, 10:05 AM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

Can you somehow get an overview, where we get an error for the ABI checker? I was wondering, why only some parts of messagelib are inside the ABIReference repo and found, that the ABI checker was failing for KF5MessageViewer.

Nov 1 2018, 9:33 AM · build.kde.org

Oct 21 2018

knauss added inline comments to D15760: WIP: Interface for mail headers in MimeTreeParser.
Oct 21 2018, 6:57 PM · KDE PIM
knauss added a comment to T3689: Add abi compliance checker to CI.

Cool, now I'm happy about the metadata and the data itself.
Can you keep enable this build of ABI References for some packages (stable+master) enabled for several build, so I have test data for the next step, where I need to compare the ABI against each other. I want some packages, so I cover more cases for the begining.

Oct 21 2018, 1:29 PM · build.kde.org

Oct 18 2018

knauss added inline comments to D11915: extend Package class to store additional metadata..
Oct 18 2018, 10:39 AM
knauss added a comment to D11915: extend Package class to store additional metadata..

fixed the issues from @bcooksley

Oct 18 2018, 10:38 AM
knauss updated the diff for D11915: extend Package class to store additional metadata..

use git log to extract current hash.

Oct 18 2018, 10:36 AM
knauss added a comment to D15760: WIP: Interface for mail headers in MimeTreeParser.

vkrause: ping

Oct 18 2018, 9:58 AM · KDE PIM