knauss (Sandro Knauß)
User

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2015, 12:50 PM (183 w, 4 d)
Availability
Available

Recent Activity

Today

knauss added inline comments to D11915: extend Package class to store additional metadata..
Thu, Oct 18, 10:39 AM
knauss added a comment to D11915: extend Package class to store additional metadata..

fixed the issues from @bcooksley

Thu, Oct 18, 10:38 AM
knauss updated the diff for D11915: extend Package class to store additional metadata..

use git log to extract current hash.

Thu, Oct 18, 10:36 AM
knauss added a comment to D15760: WIP: Interface for mail headers in MimeTreeParser.

vkrause: ping

Thu, Oct 18, 9:58 AM · KDE PIM
knauss added a comment to T3689: Add abi compliance checker to CI.

The suffix .tar is added by the Archive.storePackage method line 163 but we need to rewrite the whole Archive logic a bit as it expects the tar on other places too. For the moment I would ignore this, as the data is correct. IMO: it more a cosmetic issue. I keep this in mind and fix this when implementing the next step.

Thu, Oct 18, 9:52 AM · build.kde.org
knauss updated the diff for D11915: extend Package class to store additional metadata..

new context.

Thu, Oct 18, 9:44 AM

Thu, Oct 11

knauss added a comment to D15997: Make KPimGAPI optional.

KMailTransport is a PIM library in the first place. PIM already depends on WebEngine, so I'm not much in favor of this change, sorry.

(and afaik the only platform that we support that struggles with QtWebEngine is BSD, but even they somehow managed to hack around it and have it)

Thu, Oct 11, 10:13 PM · KDE PIM

Thu, Oct 4

knauss added inline comments to D15727: Prepare environment to be able to test grantleeheaderstyle..
Thu, Oct 4, 1:03 PM · KDE PIM

Wed, Oct 3

knauss added a comment to T8622: sprint for privacy goal.

I'll got ACK from Les Magnas that they are fully free before April.

Wed, Oct 3, 1:40 PM · Goal settings 2017
knauss added a comment to D15916: Rewrite the painting part of agandaitem.

I recommend to use https://community.kde.org/KDE_PIM/Docker to create a build environment for master.
Do you have already a identity acount (https://identity.kde.org/)? Otherwise others can push for you, if you tell us your mailaddress to add to the commits.
Normally we push the first couple of patches to get known each other and afterwards do the identity account, as you have full access to all KDE repos with an identity account.

Wed, Oct 3, 1:19 PM · KDE PIM: Junior Jobs, KDE PIM
knauss added a comment to D15760: WIP: Interface for mail headers in MimeTreeParser.

And what about the idea of a "HeaderObject" instead of methos inside nodehelper?

Wed, Oct 3, 1:12 PM · KDE PIM

Thu, Sep 27

knauss added a comment to T8622: sprint for privacy goal.

@aacid: right, for a lot a big shared room is fine and for most a two persons room is fine. But I think we also need the possibility for people to have a single room one or two.

Thu, Sep 27, 8:24 AM · Goal settings 2017
knauss added a comment to T9758: kdepim-runtime does not provide imap kio slave.

And the mail:/ kio interface may be interesting for this task:

Thu, Sep 27, 8:20 AM · KDE PIM

Wed, Sep 26

knauss added a comment to D15760: WIP: Interface for mail headers in MimeTreeParser.

@vkrause: Unfortunately I forgotten what we discussed at Akademy what a better interface would look like. That's why I started now to implement that one. I think we thought at something like a "HeaderObject":

const auto headerObject = nodeHelper->headerObject(message);
headerObject->hasHeader("to");
headerObject->header("simple"); /return Base
headerObject->asAddressList("to");
headerObject->date();
Wed, Sep 26, 7:57 AM · KDE PIM
knauss updated the diff for D15760: WIP: Interface for mail headers in MimeTreeParser.

now realy remove the part I don't want the RR.

Wed, Sep 26, 7:45 AM · KDE PIM
knauss added a task to D15760: WIP: Interface for mail headers in MimeTreeParser: T8568: Create Interface to MimeTreeParser for Headers.
Wed, Sep 26, 7:42 AM · KDE PIM
knauss added a revision to T8568: Create Interface to MimeTreeParser for Headers: D15760: WIP: Interface for mail headers in MimeTreeParser.
Wed, Sep 26, 7:42 AM · KDE PIM
knauss added a reviewer for D15760: WIP: Interface for mail headers in MimeTreeParser: vkrause.
Wed, Sep 26, 7:41 AM · KDE PIM
knauss updated the diff for D15760: WIP: Interface for mail headers in MimeTreeParser.

remove parts that shuld not have got to the review request.

Wed, Sep 26, 7:39 AM · KDE PIM
knauss requested review of D15760: WIP: Interface for mail headers in MimeTreeParser.
Wed, Sep 26, 7:37 AM · KDE PIM

Mon, Sep 24

knauss added a comment to D15727: Prepare environment to be able to test grantleeheaderstyle..

@dfaure: you made tests form frameworks run without installing, so maybe there are already some ecm foo available for that...

Mon, Sep 24, 1:00 PM · KDE PIM
knauss added a reviewer for D15727: Prepare environment to be able to test grantleeheaderstyle.: KDE PIM.
Mon, Sep 24, 12:58 PM · KDE PIM
knauss requested review of D15727: Prepare environment to be able to test grantleeheaderstyle..
Mon, Sep 24, 12:57 PM · KDE PIM
knauss updated the diff for D15706: add additional includes to abi-complience-checker..

do not reindent xml.

Mon, Sep 24, 12:19 PM · Sysadmin
knauss added a comment to D15706: add additional includes to abi-complience-checker..

I can't push:
Pushing changes to "origin/master".
FATAL: W any sysadmin/ci-tooling knauss DENIED by fallthru
(or you mis-spelled the reponame)
fatal: Could not read from remote repository.

Mon, Sep 24, 12:18 PM · Sysadmin

Sun, Sep 23

knauss committed R81:b3ce018aa46d: Use new messageviewer interface. (authored by knauss).
Use new messageviewer interface.
Sun, Sep 23, 2:29 PM
knauss committed R94:529936406790: bump version because of API changes. (authored by knauss).
bump version because of API changes.
Sun, Sep 23, 2:14 PM
knauss committed R94:ff564eea7a47: use static methods instead of private methods. (authored by knauss).
use static methods instead of private methods.
Sun, Sep 23, 2:14 PM
knauss committed R94:e6f82b5b2c03: GrantleeHeaderFormatter: Move list and date formatter into grantlee. (authored by knauss).
GrantleeHeaderFormatter: Move list and date formatter into grantlee.
Sun, Sep 23, 2:14 PM
knauss closed D13039: GrantleeHeaderFormatter: Move list and date formatter into grantlee..
Sun, Sep 23, 2:14 PM · KDE PIM
knauss committed R81:1eeec3c97d31: Add test cases for enterpriseheaderstyleplugin. (authored by knauss).
Add test cases for enterpriseheaderstyleplugin.
Sun, Sep 23, 2:00 PM
knauss committed R81:3f2028e7dc35: make enterpriseheaderstyle tests passing. (authored by knauss).
make enterpriseheaderstyle tests passing.
Sun, Sep 23, 2:00 PM
knauss committed R81:9db03339a919: Add test cases for briefheaderstyleplugin. (authored by knauss).
Add test cases for briefheaderstyleplugin.
Sun, Sep 23, 2:00 PM
knauss committed R81:0581d3e9f755: make FancyHeaderStyle test passing. (authored by knauss).
make FancyHeaderStyle test passing.
Sun, Sep 23, 2:00 PM
knauss committed R81:492be839f5a4: Add test cases for fancyheaderstyleplugin. (authored by knauss).
Add test cases for fancyheaderstyleplugin.
Sun, Sep 23, 2:00 PM
knauss committed R81:70f78d015ca1: fixup (authored by knauss).
fixup
Sun, Sep 23, 2:00 PM
knauss committed R81:bbb1fad2402c: prepare messageviewerheaderplugins for real header tests. (authored by knauss).
prepare messageviewerheaderplugins for real header tests.
Sun, Sep 23, 2:00 PM
knauss moved T3689: Add abi compliance checker to CI from Awaiting Response to Backlog on the build.kde.org board.

okay made KTextEditor built successfully with the patch D15706.

Sun, Sep 23, 11:05 AM · build.kde.org
knauss added a project to D15706: add additional includes to abi-complience-checker.: Sysadmin.
Sun, Sep 23, 11:03 AM · Sysadmin
knauss requested review of D15706: add additional includes to abi-complience-checker..
Sun, Sep 23, 11:02 AM · Sysadmin
knauss added a revision to T3689: Add abi compliance checker to CI: D15706: add additional includes to abi-complience-checker..
Sun, Sep 23, 11:02 AM · build.kde.org

Sep 11 2018

knauss added a comment to T8622: sprint for privacy goal.

The Linux Hotel in Essen-Host (https://www.linuxhotel.de, German only) is are really nice location. I was there once some years ago and forgotten about it :D I ask them today by phone, but they can only host at maximum 25 persons. And this only if several share a two bed room. They proposed to asl "Unperfekt Haus" in Essen Cetrum (https://www.unperfekthaus.de, German only).

Sep 11 2018, 4:43 PM · Goal settings 2017

Sep 9 2018

knauss added a comment to T8622: sprint for privacy goal.

Together with @stolborg , we are evaluatiing currently two options:

  • Les Magnas (France, Provence, Pierrerue): http://auxsaisons.free.fr/
    • 2h by train/bus reachable from Marseilles (nearest airport)
    • how people get from the bus station to the venue ( shuttle service needed)
  • local scout huts in Denmark (likely far out and lessluxurious)
    • do we need to cook by ourselfs (I know people, who like to cook for us)
    • how people reach the venue?
    • can people sleep in small rooms?
Sep 9 2018, 1:05 PM · Goal settings 2017

Sep 3 2018

knauss added a comment to T9595: [KAddressbook] Use KPeople model for contact list.

Next I'm going to look into the Akonadi plugin for KPeople, which should feed KPeople with Akonadi contacts. There is indeed some disabled code in KPeople, I'm going to look into it next
NB: Daniel told that, since KPeople is inside Frameworks, it cannot depend on Akonadi, so we'll have to move it to Akonadi code base eventually.

Sep 3 2018, 1:35 PM · KDE PIM

Aug 23 2018

knauss added a comment to T3689: Add abi compliance checker to CI.

sorry, it will properly take some time till I'll find time to look into it. I'm still traveling around and will be at home with the beginning of september...

Aug 23 2018, 9:17 PM · build.kde.org

Aug 20 2018

knauss committed R94:acfc7b8f5d8d: fix small typo. (authored by knauss).
fix small typo.
Aug 20 2018, 5:38 PM
knauss committed R92:62ed990e8102: fix typo. (authored by knauss).
fix typo.
Aug 20 2018, 5:33 PM

Aug 19 2018

knauss added a comment to T8408: Autocrypt support for kmail.

I'm also with you aheineke, that this Autoencrypt is not the smartest solution for email encryption. As Thunderbird already sends those headers it is very good if we support it, too. And I see some gain in some usecases where Autoencrypt makes the life easier.

Aug 19 2018, 1:17 PM · KDE PIM: Junior Jobs, KDE PIM
knauss updated the task description for T8408: Autocrypt support for kmail.
Aug 19 2018, 1:12 PM · KDE PIM: Junior Jobs, KDE PIM

Aug 16 2018

knauss added a project to T8408: Autocrypt support for kmail: KDE PIM: Junior Jobs.
Aug 16 2018, 3:42 PM · KDE PIM: Junior Jobs, KDE PIM
knauss renamed KDE PIM: Junior Jobs from KDE Pim: Junior Jobs to KDE PIM: Junior Jobs.
Aug 16 2018, 3:37 PM
knauss set the color for KDE PIM: Junior Jobs to Pink.
Aug 16 2018, 3:34 PM
knauss edited projects for T9330: Add new kdebugsettings syntax (Allow to filter result against IDENTIFIER), added: KDE PIM (Applications 18.12 (master)); removed KDE PIM.
Aug 16 2018, 3:28 PM · KDE PIM (Applications 18.12 (master))
knauss renamed KDE PIM (Applications 18.12 (master)) from KDE PIM (Applications 18.12 (master)) to Applications 18.12 (master).
Aug 16 2018, 3:27 PM
knauss created KDE PIM (Applications 18.12 (master)).
Aug 16 2018, 3:26 PM
knauss archived KDE PIM (Applications 18.08 (master)).
Aug 16 2018, 3:24 PM
knauss closed T639: [Akonadi] Notification Payloads as Resolved.

This feature is fixed within 18.08.0

Aug 16 2018, 3:22 PM · KDE PIM (Applications 18.08 (master))
knauss closed T8478: [KSMTP] OAuth support as Resolved.

This feature is fixed within 18.08.0

Aug 16 2018, 3:22 PM · KDE PIM (Applications 18.08 (master))
knauss added a comment to T8622: sprint for privacy goal.

I would stepup for planing such a sprint.
I've a place in mind in France near Grange Neuve, but I have to find the flyer with the correct name...
I think about doing the print next spring.

Aug 16 2018, 3:20 PM · Goal settings 2017
knauss reassigned T956: Push Syndication to Framesworks from dvratil to vkrause.

volker signed up for this :D

Aug 16 2018, 2:43 PM · KDE PIM (Applications 18.12 (master)), Frameworks
knauss moved T8568: Create Interface to MimeTreeParser for Headers from Application 18.12 (master) to In Progress on the KDE PIM board.
Aug 16 2018, 2:40 PM · KDE PIM
knauss edited projects for T8568: Create Interface to MimeTreeParser for Headers, added: KDE PIM; removed KDE PIM (Applications 18.08 (master)).
Aug 16 2018, 2:40 PM · KDE PIM

Aug 10 2018

knauss committed R490:555bf47d2fc2: Merge branch 'Applications/18.08' (authored by knauss).
Merge branch 'Applications/18.08'
Aug 10 2018, 2:03 PM
knauss committed R490:68946de0c12f: need for static_cast to fix the test. (authored by knauss).
need for static_cast to fix the test.
Aug 10 2018, 2:03 PM
knauss committed R490:a66f412163c7: Fix noMatchingMime test. (authored by knauss).
Fix noMatchingMime test.
Aug 10 2018, 1:55 PM
knauss committed R490:c68d95fea719: merge Application/18.08 (authored by knauss).
merge Application/18.08
Aug 10 2018, 1:55 PM
knauss committed R490:042edc225fe2: Fix noMatchingMime test. (authored by knauss).
Fix noMatchingMime test.
Aug 10 2018, 1:52 PM

Jul 22 2018

knauss added a comment to T3689: Add abi compliance checker to CI.

The Package class is designed to use the newest version, not the oldest, and doesn't retain older versions (they're overwritten on upload) so that model won't work given our current constraints. I'll see what can be done about making it run though so you get that initial data.

Jul 22 2018, 7:28 PM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

but that's why I made the package name unique {lib.name}_{srcRevision} (D11916), I thought this would make sure, that each build will create a unique tarball.

Jul 22 2018, 7:27 PM · build.kde.org
knauss moved T3689: Add abi compliance checker to CI from Awaiting Response to In Progress on the build.kde.org board.

In terms of creating the reference dataset, the best way is probably a dedicated job, much like the existing Dependency Builds, which builds a specified release tag for all the projects which are receiving this coverage in turn.

Jul 22 2018, 11:21 AM · build.kde.org

Jun 21 2018

knauss committed R165:d56d770c333e: Enable Json output for dbustracer. (authored by knauss).
Enable Json output for dbustracer.
Jun 21 2018, 12:02 PM
knauss closed D13041: Enable Json output for dbustracer..
Jun 21 2018, 12:02 PM · KDE PIM
knauss committed R165:d16513f2807e: Protocol: QJsonObject for tracer. (authored by knauss).
Protocol: QJsonObject for tracer.
Jun 21 2018, 12:00 PM
knauss closed D13104: Protocol: QJsonObject for tracer..
Jun 21 2018, 12:00 PM · KDE PIM

Jun 20 2018

knauss added a comment to T3689: Add abi compliance checker to CI.

@pino: it is just a warning and it successfully creates a dump without ctags. and i havn#t found what feature is enabled by ctags.

Jun 20 2018, 2:16 AM · build.kde.org

Jun 18 2018

knauss added a comment to T3689: Add abi compliance checker to CI.

well removing clang was the easiest part to make sure that the gcc call is not called with "-I/usr/include/clang/AST -I/usr/lib64/clang/6.0.0/include"

Jun 18 2018, 10:56 PM · build.kde.org
knauss added a comment to T3689: Add abi compliance checker to CI.

@bcooksley thanks for the script it has some issues ( python instead of python3 and one missing cd .. before running python) :

Jun 18 2018, 8:58 PM · build.kde.org

Jun 17 2018

knauss added a comment to T3689: Add abi compliance checker to CI.

I can't use the ci-docker because I don't manage it to create a build environment to build kde applications without building all frameworks. Can I download the whole envrionment somehow to have the same build to test?

Jun 17 2018, 1:50 AM · build.kde.org

Jun 15 2018

knauss added a comment to T639: [Akonadi] Notification Payloads.

@dkurz: the idea is that we will close it with the first version realeased with it. This way we see what is not released already.

Jun 15 2018, 11:26 PM · KDE PIM (Applications 18.08 (master))

Jun 6 2018

knauss added a comment to T3689: Add abi compliance checker to CI.

The error looks like that we need other gcc-options to compile for Frameworks. But I do not find the correct options - maybe we should ask Framework devs, if they now this.

Jun 6 2018, 12:26 PM · build.kde.org

Jun 2 2018

knauss updated the diff for D13041: Enable Json output for dbustracer..

use new function Protocol::toJson

Jun 2 2018, 9:51 PM · KDE PIM
knauss updated the diff for D13104: Protocol: QJsonObject for tracer..

chain up to Command->toJson()

Jun 2 2018, 9:50 PM · KDE PIM

May 31 2018

knauss requested review of D13231: fix build against OpenSSL 1.1.
May 31 2018, 9:49 AM · Kopete

May 30 2018

knauss added a comment to T8568: Create Interface to MimeTreeParser for Headers.

For the header interface:

  • what's the KMime::Message* parameter for, shouldn't this be coming from the nodehelper context (in particular since we might want to deviate from what KMime has)?

i do not get what you mean.

May 30 2018, 5:06 PM · KDE PIM

May 28 2018

knauss added inline comments to D13104: Protocol: QJsonObject for tracer..
May 28 2018, 9:21 PM · KDE PIM
knauss updated the diff for D13104: Protocol: QJsonObject for tracer..

fixing issues raised

May 28 2018, 9:21 PM · KDE PIM
knauss added inline comments to D13104: Protocol: QJsonObject for tracer..
May 28 2018, 9:22 AM · KDE PIM

May 25 2018

knauss updated the diff for D13041: Enable Json output for dbustracer..

no Akonadi namespace.

May 25 2018, 9:30 AM · KDE PIM
knauss requested review of D13104: Protocol: QJsonObject for tracer..
May 25 2018, 9:22 AM · KDE PIM
knauss updated the diff for D13041: Enable Json output for dbustracer..

Rely on QJsonObject variant of JSON creation.
ouput only DebugString OR JSON.

May 25 2018, 9:21 AM · KDE PIM

May 24 2018

knauss accepted D13096: Ensure we always reset the external reference override.
May 24 2018, 4:00 PM · KDE PIM
knauss added inline comments to D13041: Enable Json output for dbustracer..
May 24 2018, 8:19 AM · KDE PIM

May 23 2018

knauss added a comment to T8568: Create Interface to MimeTreeParser for Headers.

We need an Interface for the headers:

May 23 2018, 9:13 PM · KDE PIM
knauss committed R94:5258ac0cd84a: use showMailAction form GrantleeHeaderStyle in formatter. (authored by knauss).
use showMailAction form GrantleeHeaderStyle in formatter.
May 23 2018, 7:40 AM
knauss closed D13016: use showMailAction form GrantleeHeaderStyle in formatter..
May 23 2018, 7:40 AM · KDE PIM
knauss added inline comments to D13041: Enable Json output for dbustracer..
May 23 2018, 7:38 AM · KDE PIM

May 22 2018

knauss requested review of D13041: Enable Json output for dbustracer..
May 22 2018, 2:24 PM · KDE PIM
knauss committed R165:a78f5786a110: fix toJson method. (authored by knauss).
fix toJson method.
May 22 2018, 2:24 PM
knauss requested review of D13039: GrantleeHeaderFormatter: Move list and date formatter into grantlee..
May 22 2018, 1:03 PM · KDE PIM
knauss updated the diff for D13016: use showMailAction form GrantleeHeaderStyle in formatter..

remove showMailAction now completly.

May 22 2018, 1:03 PM · KDE PIM