Feed Advanced Search

Today

ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

Making the parts with background color transparent would be better, right? That would even work on systems which don’t access the stylesheet.

Mon, Jul 22, 6:04 PM · Frameworks
ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I can understand it.

Mon, Jul 22, 5:29 PM · Frameworks
ndavis requested changes to D22653: Add view-qrcode icons.
Mon, Jul 22, 4:59 PM · Frameworks
ndavis added a comment to D22653: Add view-qrcode icons.

Hi! Thanks for the patch. There are few things I'd like you to change before I accept this.

Mon, Jul 22, 4:55 PM · Frameworks
ndavis committed R266:78c382599bcd: Fix typo in stylesheets (authored by ndavis).
Fix typo in stylesheets
Mon, Jul 22, 4:09 PM
ndavis committed R266:822b3ae3f88a: Change Highlight to ButtonFocus in stylesheets (authored by ndavis).
Change Highlight to ButtonFocus in stylesheets
Mon, Jul 22, 4:08 PM
ndavis closed D22647: Change Highlight to ButtonFocus in stylesheets.
Mon, Jul 22, 4:08 PM · Frameworks
ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

Other icons with fold in the bottom I could find:

  • document-duplicate
  • document-revert-symbolic[-rtl]
  • kt-restore-defaults
  • password-copy
  • viewpdf
  • xml-node-duplicate
  • user-desktop-symbolic
  • document-multiple
  • folder-documents[-symbolic]
  • emblem-documents-symbolic

    Most icons indeed have the fold at the top, especially Mimetypes icons look great. :)
Mon, Jul 22, 3:58 PM · Frameworks
ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

Makes sense, so I’m flipping snap-page now. Is that written down somewhere?

Mon, Jul 22, 3:57 PM · Frameworks
ndavis added a comment to D22647: Change Highlight to ButtonFocus in stylesheets.

Right, I see that there's actually no regression. In principle, can you describe what a color scheme needs to do to avoid this situation?

Mon, Jul 22, 2:27 PM · Frameworks
ndavis added a comment to D22647: Change Highlight to ButtonFocus in stylesheets.

Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet.

This will require documentation changes as well on https://hig.kde.org/style/icon.html and https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

Mon, Jul 22, 2:19 PM · Frameworks
ndavis added a comment to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

I'll give the latest changes a proper review in a little while.

Mon, Jul 22, 2:14 PM · Frameworks
ndavis retitled D22647: Change Highlight to ButtonFocus in stylesheets from Change Highlight to ViewFocus in stylesheets to Change Highlight to ButtonFocus in stylesheets.
Mon, Jul 22, 2:04 PM · Frameworks
ndavis updated the diff for D22647: Change Highlight to ButtonFocus in stylesheets.

Change ViewFocus to ButtonFocus to match some elements in the Breeze desktop theme

Mon, Jul 22, 2:04 PM · Frameworks
ndavis updated the test plan for D22647: Change Highlight to ButtonFocus in stylesheets.
Mon, Jul 22, 1:59 PM · Frameworks
ndavis requested review of D22647: Change Highlight to ButtonFocus in stylesheets.
Mon, Jul 22, 1:56 PM · Frameworks
ndavis requested changes to D22617: Add view-pages-* icons, as needed in Okular for page layout selection.

Nice work!

Mon, Jul 22, 1:29 AM · Frameworks

Yesterday

ndavis committed R242:249365e327fa: Remove hardcoded colors (view.svg, system.svg) (authored by ndavis).
Remove hardcoded colors (view.svg, system.svg)
Sun, Jul 21, 8:10 AM

Fri, Jul 19

ndavis added a comment to T11247: Attract LXQt to KDE.

LXQt's biggest problem is that Plasma itself is now so lightweight that it infringes on LXQt's stated reason for existence. Accordingly, I don't really think it would make sense for LXQt to join KDE; rather, LXQt will probably die off naturally due to lack of a real niche it can sustainably inhabit, and hopefully we can recruit its refugee developers to KDE-land. I think they're already using some KDE Frameworks, right? If so, they're already gaining some familiarity with our technology stack. All we need to do is encourage that.

Maybe then add a lite/hight performance mode to Plasma in settings? In Windows there is something like this, but it doesn't work.

Fri, Jul 19, 10:25 PM · KDE Promo
ndavis added a comment to D22324: [RFC] Also animate the Cancel button.

I think it looks pretty cool!

Fri, Jul 19, 5:10 PM · Spectacle
ndavis added a comment to T11124: Unify highlight effect style.

Finally there is still the issue of the HighlightedText foreground color in the palette. It is chosen to have high contrast against the highligh (=focus) color background. This is why it is white in the default color scheme. You should not change this, if you do not want to break other widget themes, or break text selection. If you want to manually lighten the focus/highlight color, by adding some translucency, so that you do not have to change the text color, you must make sure to use the QPalette::Text or QPalette::WindowText role, rather than modifying the palette's HighlightedText role. For monochrome icons there is the extra complication that the QIcon::Selected state will by default use the HighlightedText role for its main color. So what you would then need is to use the QIcon::Normal state instead of ::Selected, everywhere you do not want this color change to happen.

Fri, Jul 19, 3:33 AM · VDG

Thu, Jul 18

ndavis accepted D22541: Update refresh and restart icons to reflect new breeze-icons versions.

Looks good!

Thu, Jul 18, 9:07 PM · Frameworks
ndavis accepted D22534: Use clockwise arrows for *refresh* and update-* icons.

Looks good!

Thu, Jul 18, 7:07 PM · Frameworks

Wed, Jul 17

ndavis added a comment to D22493: [Notifications] Move history items' icons over to the left a bit.

Is it just me or does vertical alignment look off now? How does it affect the popup layout?

Wed, Jul 17, 9:36 AM · Plasma

Mon, Jul 15

ndavis added a comment to T11093: Consistency.

I'm willing to do work on this, but I'd like to say that I think there is room for some variety.

Mon, Jul 15, 10:28 PM · Goal Setting 2019
ndavis updated the task description for T11093: Consistency.
Mon, Jul 15, 9:51 PM · Goal Setting 2019
ndavis added a comment to D22481: Do not show play/pause button when no media is playing.

This is how the widget currently looks:

Mon, Jul 15, 7:03 PM · Plasma
ndavis added a comment to D22452: Fix text color in non-selected tabs in Firefox.

The latest version of this patch is better because it works well for people using the Breeze GTK theme with the Breeze colorscheme and it doesn't make the Breeze Dark GTK theme worse when combined with the Breeze Dark colorscheme. However, it does cause Breeze GTK to look odd when used with the Breeze Dark colorscheme:

Mon, Jul 15, 5:02 PM · Plasma
ndavis added a comment to T11124: Unify highlight effect style.

Can I change the selection background color and use the selection color for the background of highlights? Then the regular highlight color could be used mainly for line highlights and outlines.

Mon, Jul 15, 1:45 PM · VDG
ndavis abandoned D22003: Change selected text color to black.

Abandoning because it can negatively affect other widget styles.

Mon, Jul 15, 12:50 PM · Frameworks
ndavis abandoned D22000: [colors/Breeze] Change selected text color to black.

Abandoning because it can negatively affect other widget styles.

Mon, Jul 15, 12:47 PM · Plasma
ndavis added a comment to T11124: Unify highlight effect style.

Thanks for the color overview. I'll avoid changing the highlighted text color in the colorscheme.

Mon, Jul 15, 12:40 PM · VDG
ndavis added a comment to T11124: Unify highlight effect style.

...Which reminds me, these QStyle changes are going to need to be replicated in qqc2-desktop-style too. And maybe also Kirigami in some places.

Mon, Jul 15, 4:19 AM · VDG

Sun, Jul 14

ndavis added a comment to T11124: Unify highlight effect style.
  • For the record: toolbar buttons (or rather QToolButtons) can have focus too, when they are used outside of toolbars (and there are examples of such everywhere, for instance when you have an "open" button next to a text entry for selecting a file.
Sun, Jul 14, 10:05 PM · VDG
ndavis requested changes to D22452: Fix text color in non-selected tabs in Firefox.

This causes a problem with Breeze and Breeze Dark when the titlebar is enabled.

Sun, Jul 14, 12:02 PM · Plasma
ndavis added a comment to T10997: Improve check box design.
In T10997#191697, @mglb wrote:

I think the symbol is too small for dashed line:


I'll see how it works with a little larger check mark

Sun, Jul 14, 11:21 AM · VDG, Breeze
ndavis added a comment to T11124: Unify highlight effect style.

I need some help coming up with a consistent way of showing a distinct difference between mouse hover, keyboard focus and the sunken state. Here's what I know about how different widget types use these.

Sun, Jul 14, 11:07 AM · VDG
ndavis accepted D22452: Fix text color in non-selected tabs in Firefox.
Sun, Jul 14, 10:50 AM · Plasma
ndavis requested changes to D22452: Fix text color in non-selected tabs in Firefox.
Sun, Jul 14, 10:50 AM · Plasma
ndavis added a comment to D22452: Fix text color in non-selected tabs in Firefox.
In D22452#495224, @zzag wrote:

I'm not a Breeze GTK maintainer or developer

There is currently no maintainer of breeze-gtk

Sun, Jul 14, 10:49 AM · Plasma
ndavis accepted D22452: Fix text color in non-selected tabs in Firefox.

Looks good to me.

Sun, Jul 14, 9:53 AM · Plasma
ndavis added inline comments to D22452: Fix text color in non-selected tabs in Firefox.
Sun, Jul 14, 9:35 AM · Plasma
ndavis added a comment to D22452: Fix text color in non-selected tabs in Firefox.

Can you post a picture of what this change is supposed to do? I see that you are hardcoding a color here. Have you tested the change with Breeze Dark?

Sun, Jul 14, 9:31 AM · Plasma

Tue, Jul 9

ndavis requested review of D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".
Tue, Jul 9, 10:03 PM · Plasma

Sat, Jul 6

ndavis accepted D22297: Add id="current-color-scheme" to collapse-all icons.

LGTM

Sat, Jul 6, 5:47 PM · Frameworks

Fri, Jul 5

ndavis added a comment to D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.

Works for me. Tested RTL with kate --reverse.

Fri, Jul 5, 4:51 PM · Plasma
ndavis accepted D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.
Fri, Jul 5, 4:49 PM · Plasma
ndavis requested changes to D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.

Actually, I did find one problem that I missed from before:

Fri, Jul 5, 4:05 AM · Plasma
ndavis accepted D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.

As far as I can tell, there aren't any problems with this patch. Some apps like Spectacle and the system tray settings don't follow the new style, but they don't use Qt Widgets for the sidebar.

Fri, Jul 5, 3:58 AM · Plasma
ndavis added a comment to D22147: Better use of Qt APIs in Plasma::Theme.
In D22147#491119, @apol wrote:

I've compiled this with the latest commits, but the problem hasn't gone away.

Try removing .cache/plasma-svgelements-default_v5.60.0 and .cache/plasma_theme_default_v5.60.0.kcache.

Fri, Jul 5, 12:23 AM · Frameworks

Thu, Jul 4

ndavis committed R296:f18d43b7ffd8: [GridDelegate] Fix gaps in corners of thumbnailArea highlight (authored by ndavis).
[GridDelegate] Fix gaps in corners of thumbnailArea highlight
Thu, Jul 4, 9:05 PM
ndavis closed D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.
Thu, Jul 4, 9:05 PM · Frameworks
ndavis added a comment to D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.

Since this apparently doesn't need review,

This is not what I said. What I said is "thanks, it looks fantastic" is not a proper review and hence irrelevant. What I expect for a proper review is

  • does the patch achieve the behavior matching its title, and is it the intended behavior
  • does the code look legit (compiles, properly formatted, etc.)
  • is there a better way to achieve the same
  • does the patch break other things, and how can it be improved so that it doesn't If you can provide such a review I'd be happy to modify the patch accordingly.

I'll resign.

Thu, Jul 4, 7:42 PM · Plasma
ndavis added a comment to D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.

Anyone want to approve or request changes? It's not perfect, but it's a simple improvement. The ideal solution would require us to work around a problem with QML where images can't have their corners rounded by a parent object's border radius.

Thu, Jul 4, 6:27 PM · Frameworks
ndavis updated the diff for D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.
  • Remove radius when thumbnail is present
Thu, Jul 4, 6:25 PM · Frameworks
ndavis resigned from D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background.

Since this apparently doesn't need review, I'll resign.

Thu, Jul 4, 5:23 PM · Plasma
ndavis added a comment to D22259: Reduce default sidebar icon size.

I like the idea of having a thinner sidebar, but I don't like the idea of having unlabelled views by default. I think hiding labels would hurt usability for first time users.

I was on the fence about hiding the text for exactly that reason. But since the text is so wide it keeps the sidebar huge too. From a usability standpoint I think the tooltips might be enough, but I'm not a designer.

Thu, Jul 4, 5:17 PM · Okular
ndavis added a comment to D22275: [Svg] Fix porting error from QRegExp::exactMatch.

I can confirm this fixes the problem here: https://phabricator.kde.org/D22147#490563

Thu, Jul 4, 4:01 PM · Frameworks
ndavis added a comment to D22147: Better use of Qt APIs in Plasma::Theme.

I've compiled this with the latest commits, but the problem hasn't gone away.

Thu, Jul 4, 3:48 PM · Frameworks
ndavis added a comment to D22147: Better use of Qt APIs in Plasma::Theme.

@apol This patch seems to have caused a bug in the way icons are loaded for the system tray:

Thu, Jul 4, 7:28 AM · Frameworks
ndavis added a comment to D22259: Reduce default sidebar icon size.

I like the idea of having a thinner sidebar, but I don't like the idea of having unlabeled views by default. I think hiding labels would hurt usability for first time users.

Thu, Jul 4, 3:06 AM · Okular
ndavis added a comment to P426 dot story draft.

Are we sure Breeze doesn't already have a maintainer? It would be good not to offend the existing one by implying that he will be replaced. Although I guess it's possible for more than one person to be a maintainer. I believe that is the case with KWin since Martin stepped down.

Thu, Jul 4, 2:01 AM

Wed, Jul 3

ndavis added a comment to D22191: Implement syncing of theme preferences between SDDM and Plasma.
In D22191#489915, @GB_2 wrote:

I think then you would have to type in your password every time you change a setting.

Would you really? There couldn't be a service running with the right permissions that automatically synchronizes settings on logout/user switch/shutdown/when a change is detected? It seems like it should be possible, but I don't know what the security implications would be.

It's copying to sddm owned directories so it does need root permissions... something would have to be worked out, not sure what the possibilities are though. Also this would have to be enabled by default solely for single user systems, otherwise you run the risk of the login screen always changing appearance based on the user that was last logged in.

Wed, Jul 3, 4:38 PM · Plasma
ndavis committed R31:bc29a577ff60: Add highlightBackgroundColor() (authored by ndavis).
Add highlightBackgroundColor()
Wed, Jul 3, 6:59 AM
ndavis committed R31:a130915b4eb3: Change QListView style (authored by ndavis).
Change QListView style
Wed, Jul 3, 6:59 AM
ndavis committed R31:1a828febb4fc: Add renderTableItemSelection (authored by ndavis).
Add renderTableItemSelection
Wed, Jul 3, 6:59 AM
ndavis committed R31:c9101c249726: Fix frame sides (authored by ndavis).
Fix frame sides
Wed, Jul 3, 6:59 AM
ndavis committed R31:85bcb9dd1d3d: Remove qtquickcontrols dir (authored by ndavis).
Remove qtquickcontrols dir
Wed, Jul 3, 6:59 AM
ndavis committed R31:107577271a40: - fixed "missing override" warnings - removed useless "virtual" specifications… (authored by hpereiradacosta).
- fixed "missing override" warnings - removed useless "virtual" specifications…
Wed, Jul 3, 6:59 AM
ndavis added a comment to D22191: Implement syncing of theme preferences between SDDM and Plasma.
In D22191#489915, @GB_2 wrote:

Settings UI:

This control layout seems to imply that a user must press the "Sync" button every time they change their user settings.

Wouldn't a checkbox for continual synchronization and a button for resetting make more sense?

I think then you would have to type in your password every time you change a setting.

Wed, Jul 3, 6:10 AM · Plasma
ndavis created T11172: Reduce the size of the Breeze repository.
Wed, Jul 3, 5:42 AM · Plasma, Breeze

Tue, Jul 2

ndavis added a comment to D22191: Implement syncing of theme preferences between SDDM and Plasma.

Settings UI:

Tue, Jul 2, 10:24 PM · Plasma

Mon, Jul 1

ndavis added a comment to T11124: Unify highlight effect style.

For tool buttons it might be nice to use the Kickoff effect (when pressed). When hovered over they can look the same as they do now = only show a border.

Mon, Jul 1, 4:53 PM · VDG

Sun, Jun 30

ndavis added a comment to D22102: Implement apply-on-double-click for all grid view KCM delegates.

Maybe I should move back and examine the rationale for the proposal.

Right now, I find it *extremely* annoying, slow, and frustrating to test new themes, colors, icons, wallpapers, etc. The workflow is to click on the delegate, and then click on the Apply button in the corner of the window, or use its hidden Alt accelerator. If I want to see 5 items, I do this five times. If I want to look through 20 items, I do this 20 times. Every time I do this, I get frustrated and feel like it should be doable in a faster way.

This proposal is one way to resolve the issue. I don't personally see a problem with the hidden double-click accelerator (obviously, or else I wouldn't have submitted the patch :) ), but if people don't like this approach, I hope we can have a conversation about alternative approaches to resolve the underlying issue of the test-multiple-items-in-a-grid-view-KCM workflow being quite slow. I can think of a few:

  • Move to the instant apply paradigm
  • Add Preview buttons to all delegates that "virtually" apply the item to everything visible on screen
  • Do the above, but on hover or selection, with a visible message that says "this is just a preview", click Apply to apply these settings"
  • Probably way more
Sun, Jun 30, 6:31 PM · Frameworks
ndavis added a comment to D10362: Change reveal password button logic.

I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password.

Sun, Jun 30, 5:12 PM · Frameworks, Plasma
ndavis accepted D22167: [plasma-workspace] Use new activities icon.
Sun, Jun 30, 4:33 PM · Plasma
ndavis accepted D22169: [plasma-active-window-control] Use new activities icon.
Sun, Jun 30, 4:32 PM · Plasma
ndavis accepted D22168: [plasma-desktop] Use new activities icon.
Sun, Jun 30, 4:30 PM · Plasma
ndavis accepted D22170: [latte-dock] Use new activities icon.
Sun, Jun 30, 4:30 PM · Plasma
ndavis accepted D22171: [colord-kde] Use more appropriate icon, because the activities icon got changed.
Sun, Jun 30, 4:29 PM
ndavis accepted D22172: [kio-extras] Use new activities icon.
Sun, Jun 30, 4:28 PM · Frameworks, Dolphin
ndavis accepted D22173: [kactivities] Use new activities icon.
Sun, Jun 30, 4:28 PM · Frameworks
ndavis added a comment to D10362: Change reveal password button logic.
Sun, Jun 30, 3:07 PM · Frameworks, Plasma
ndavis added a comment to D10362: Change reveal password button logic.

-1 for the current version

Sun, Jun 30, 3:04 PM · Frameworks, Plasma

Sat, Jun 29

ndavis accepted D22155: Add new activities and virtual desktops icons.

I'm accepting this, but make sure you don't land this until you've submitted the other patches.

Sat, Jun 29, 11:57 PM · Frameworks
ndavis added a comment to D22155: Add new activities and virtual desktops icons.

Nice job!

Sat, Jun 29, 4:28 PM · Frameworks

Fri, Jun 28

ndavis accepted D22128: [Kickoff] Redo tab bar separator's geometry.

Sorry, my bad once again. I hadn't actually applied D22108. It works for me now. The tab highlight width problem must be somewhere else since this patch didn't introduce that regression.

Fri, Jun 28, 9:38 PM · Plasma
ndavis requested changes to D22128: [Kickoff] Redo tab bar separator's geometry.

whoops, didn't mean to accept

Fri, Jun 28, 9:35 PM · Plasma
ndavis accepted D22128: [Kickoff] Redo tab bar separator's geometry.

Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen):

Fri, Jun 28, 9:34 PM · Plasma
ndavis committed R31:49c5b6966ecd: Remove qtquickcontrols dir (authored by ndavis).
Remove qtquickcontrols dir
Fri, Jun 28, 7:39 PM
ndavis closed D21969: Remove qtquickcontrols dir.
Fri, Jun 28, 7:39 PM · Plasma
ndavis added a comment to D22128: [Kickoff] Redo tab bar separator's geometry.

Since these seem to be scaled 2x, the thicker (6px@2x) highlight is more desirable.

Fri, Jun 28, 12:06 AM · Plasma

Thu, Jun 27

ndavis added a comment to D22128: [Kickoff] Redo tab bar separator's geometry.

Why is the tab highlight thicker in these

Thu, Jun 27, 11:58 PM · Plasma
ndavis added a reviewer for D22127: Add button to swap X and Y in Plot Setup dialog: Kalzium.
Thu, Jun 27, 9:31 PM · KDE Edu, Kalzium
ndavis added a reviewer for D22127: Add button to swap X and Y in Plot Setup dialog: tcanabrava.
Thu, Jun 27, 9:31 PM · KDE Edu, Kalzium
ndavis committed R834:d600673fa89a: Add snoretoast icon (authored by ndavis).
Add snoretoast icon
Thu, Jun 27, 8:25 PM
ndavis closed D22126: Add snoretoast icon.
Thu, Jun 27, 8:25 PM
ndavis retitled D22126: Add snoretoast icon from Add data/snoretoast.svg to Add snoretoast icon.
Thu, Jun 27, 8:24 PM
ndavis added a comment to D22126: Add snoretoast icon.

The WhatsApp icon seems to be about 96px, if it has margins.

Thu, Jun 27, 8:22 PM
ndavis updated the diff for D22126: Add snoretoast icon.
  • Add 96px png
Thu, Jun 27, 8:22 PM