Feed Advanced Search

Today

ndavis added a comment to D25015: Update breeze theme shadows.

Just in case you misunderstood me, when I said create the corners from rounded rectangles, I meant create the rounded rectangle and cut off the parts you don't need so that you're left with corners that you can place however you need. If you're not aware of it, check out Inkscape's Path menu. It has a ton of useful stuff for sculpting shapes.

Sun, Jan 19, 3:39 PM · Frameworks
ndavis added a comment to D25015: Update breeze theme shadows.

I'll trust your judgement on the masks and corners. If there's a problem, it can be patched. I know this stuff can be super janky at times.

Sun, Jan 19, 2:53 PM · Frameworks
ndavis added a comment to D25015: Update breeze theme shadows.

I noticed a few things.

Sun, Jan 19, 4:22 AM · Frameworks
ndavis added a comment to D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons.

For some reason, the corners of the checkbox indicator don't overlap perfectly with the corners of the base checkbox, even though the corners are exactly the same in the SVGs.

Sun, Jan 19, 3:09 AM · Frameworks
ndavis updated the test plan for D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons.
Sun, Jan 19, 3:02 AM · Frameworks
ndavis updated the summary of D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons.
Sun, Jan 19, 3:00 AM · Frameworks
ndavis added a comment to D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons.

This patch has a few problems and some things to consider.

Sun, Jan 19, 3:00 AM · Frameworks
ndavis requested review of D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons.
Sun, Jan 19, 2:52 AM · Frameworks

Yesterday

ndavis added a comment to D24706: [RFC] Change button style.

KScreen uses QML, so it may well be that the buttons were rotated using QML's rotation property, which does rotate the frame, since that's rendered by qqc2-desktop-style's StyleItem as a sub-part of the button.

Sat, Jan 18, 7:19 PM · Breeze, VDG, Plasma
ndavis added a comment to D26739: [applets/Task Manager] Refine tooltip highlight effect.

Yeah. I don't disagree. But if I just ensure that the highlight effect is the highest item, the borders still get obscured by the player controls and album art. And the rounded corners of the highlight leave a pixel or two of the art to escape the bounds too.

Sat, Jan 18, 5:17 AM · Plasma
ndavis added inline comments to D26739: [applets/Task Manager] Refine tooltip highlight effect.
Sat, Jan 18, 5:08 AM · Plasma
ndavis added a dependent revision for D26743: Add active, link, visited, negative, neutral and positive background colors: D26746: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:44 AM · Kirigami
ndavis added a dependency for D26746: Add active, link, visited, negative, neutral and positive background colors: D26743: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:44 AM · Kirigami, Plasma
ndavis added a dependent revision for D26743: Add active, link, visited, negative, neutral and positive background colors: D26745: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:43 AM · Kirigami
ndavis added a dependency for D26745: Add active, link, visited, negative, neutral and positive background colors: D26743: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:43 AM · Plasma
ndavis requested review of D26746: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:43 AM · Kirigami, Plasma
ndavis added reviewers for D26745: Add active, link, visited, negative, neutral and positive background colors: Plasma, Kirigami.
Sat, Jan 18, 2:40 AM · Plasma
ndavis added a reviewer for D26743: Add active, link, visited, negative, neutral and positive background colors: Plasma.
Sat, Jan 18, 2:39 AM · Kirigami
ndavis requested review of D26745: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:37 AM · Plasma
ndavis added a comment to D26739: [applets/Task Manager] Refine tooltip highlight effect.

Not a fan of the inner frame. We should avoid making frames within frames. I don't think it really needs changing, except that the sides cover the blue border frame.

Sat, Jan 18, 2:12 AM · Plasma
ndavis updated the summary of D26743: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 1:44 AM · Kirigami
ndavis requested review of D26743: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 1:41 AM · Kirigami

Fri, Jan 17

ndavis added a comment to D24706: [RFC] Change button style.

If application developers need a rotated button, they need to rotate only the contents, not the frame.

Fri, Jan 17, 3:22 PM · Breeze, VDG, Plasma
ndavis added a comment to D24706: [RFC] Change button style.

TBH, the current way control shadows are rendered seems kind of wrong anyway. The shadow is rendered within the button, so when you rotate a button, the shadow gets rotated as well.

Fri, Jan 17, 2:29 AM · Breeze, VDG, Plasma
ndavis added a comment to D24706: [RFC] Change button style.

I think I'm going to need bigger, fancier shadows to get a good pressed movement (besides changing background color) with the diagonal movement removed.

Fri, Jan 17, 2:27 AM · Breeze, VDG, Plasma
ndavis added a comment to D24706: [RFC] Change button style.

Thanks Noah.

So you're the boss after all (as the de- facto Breeze maintainer now), and I think we should follow your lead design-wise. But it might also be interesting to have a discussion about what we want this to accomplish.

Personally here's my wishlist:

  1. Make it much more visually obvious which button is the default button
  2. Make the focused state look less like what most people would assume is the appearance for the default button
  3. Avoid making the focused state look too subtle
  4. Make the pressed state look more "pressed"

    I think this patch does #3 and #4, but not #1 or #2. However it's possible that the focus style you've chosen will be just fine once the selection effects look like this everywhere for consistency, and if the default button gets a stronger look.
Fri, Jan 17, 1:20 AM · Breeze, VDG, Plasma
ndavis added a comment to D24706: [RFC] Change button style.

There were some conflicts, so this isn't exactly how it was before.

Fri, Jan 17, 12:22 AM · Breeze, VDG, Plasma
ndavis updated the diff for D24706: [RFC] Change button style.

Rebase

Fri, Jan 17, 12:22 AM · Breeze, VDG, Plasma

Thu, Jan 16

ndavis accepted D26703: Add icon for text/vnd.kde.kcrash-report.
Thu, Jan 16, 2:55 PM · Frameworks
ndavis added a comment to D26655: show a thin separator between view and scrollbar.

Vertical scrollbar taking the corner without the column header change:

Thu, Jan 16, 2:15 PM · Plasma
ndavis added a comment to D26655: show a thin separator between view and scrollbar.

As a side note: I have been using this code for a couple of days now, and while I think the separator looks well for vertical scrollbars, when you have both vertical and horizontal, ... this will need some getting used to.
See:


This is with a thin handle, but having the thick one does not really improve. The view looks like a frame inside a frame, first one being off-centered.
I have no clue how this can be improved

Thu, Jan 16, 2:12 PM · Plasma

Wed, Jan 15

ndavis added a comment to D26655: show a thin separator between view and scrollbar.

I noticed that when hovering on the scrollbar border, while the view area is not focused, the scrollbar handle is light gray (Breeze Dark, dark gray for Breeze) instead of blue. Moving the mouse just slightly more to the right turns the scrollbar handle blue.

Wed, Jan 15, 8:31 PM · Plasma
ndavis added a comment to D26655: show a thin separator between view and scrollbar.
In D26655#595033, @mart wrote:

moving the points half a pixel in renderArrow seems to fix it, but it may have sideeffects for arrows used in other places..

Wed, Jan 15, 7:30 PM · Plasma
ndavis committed R31:d336cca26b8e: Use Text instead of WindowText for scrollbar border (authored by ndavis).
Use Text instead of WindowText for scrollbar border
Wed, Jan 15, 7:22 PM
ndavis committed R31:e606b2643eb4: Fix hardcoded scrollbar separator width (authored by ndavis).
Fix hardcoded scrollbar separator width
Wed, Jan 15, 7:19 PM
ndavis accepted D26671: Cleanup and add 22px media repeat icons.
Wed, Jan 15, 6:07 PM · Frameworks
ndavis added a comment to D26655: show a thin separator between view and scrollbar.

+1 to this change.

Wed, Jan 15, 4:16 PM · Plasma
ndavis accepted D26685: Make the scrollbar always thick.
Wed, Jan 15, 3:52 PM · Plasma

Tue, Jan 14

ndavis added a comment to D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse.

So you can't tab around to end up focusing the text field?

Tue, Jan 14, 2:30 PM · Frameworks
ndavis accepted D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse.
Tue, Jan 14, 4:08 AM · Frameworks

Mon, Jan 13

ndavis committed R31:3e9cd8d1e551: Make checkboxes/radiobuttons use Window Background in windows and View… (authored by ndavis).
Make checkboxes/radiobuttons use Window Background in windows and View…
Mon, Jan 13, 9:17 PM
ndavis closed D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists.
Mon, Jan 13, 9:17 PM · Plasma
ndavis added a member for Plasma 6: ndavis.
Mon, Jan 13, 8:38 PM
ndavis updated the diff for D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists.

Fix formatting

Mon, Jan 13, 8:05 PM · Plasma
ndavis updated the test plan for D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists.
Mon, Jan 13, 8:03 PM · Plasma
ndavis added a comment to D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists.

After this patch, should I remove isSelectedItem()? It's currently unused.

Mon, Jan 13, 8:00 PM · Plasma
ndavis added a comment to D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists.

Otherwise, it should be Window Background. Doing it that way would preserve the original look in most cases.

This would lead to some regression (I think) for unchecked checkboxes in lists. (because of window background being used).

Mon, Jan 13, 7:54 PM · Plasma
ndavis added reviewers for D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists: hpereiradacosta, ngraham.
Mon, Jan 13, 7:53 PM · Plasma
ndavis requested review of D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists.
Mon, Jan 13, 7:51 PM · Plasma
ndavis committed R31:3577d15fd8fc: Improve checkbox/radiobutton style code formatting (authored by ndavis).
Improve checkbox/radiobutton style code formatting
Mon, Jan 13, 7:02 PM
ndavis added a comment to D26572: Always render checkbox/radiobutton background.

What I meant is that I did not change the color of the checkbox background in this patch. I only made it so that the background would always be rendered.

Mon, Jan 13, 7:00 PM · Plasma
ndavis added a comment to D26572: Always render checkbox/radiobutton background.

in more detail: imagine a color scheme where window background is black, window text is white, view background is white view text is black.
you will get a white square on a white background for unchecked checkbox ...
I would really revert this part of the change

Mon, Jan 13, 6:07 PM · Plasma
ndavis added a comment to D26572: Always render checkbox/radiobutton background.

Oh, I should have brought this up before landing, but any opinions about always using QPalette::Base (View Background) for the background color? I asked on the VDG channel and people seemed to be unanimously in favor of using View Background as the background color.

Mon, Jan 13, 3:16 PM · Plasma
ndavis committed R31:98781f18df86: Always render checkbox/radiobutton background (authored by ndavis).
Always render checkbox/radiobutton background
Mon, Jan 13, 3:12 PM
ndavis closed D26572: Always render checkbox/radiobutton background.
Mon, Jan 13, 3:12 PM · Plasma
ndavis updated subscribers of D26271: [Applet]Update layout based on T10470.

Since it's @cfeck's bug report, I'll add him to the subscribers.

Mon, Jan 13, 1:51 PM · Plasma
ndavis added a comment to D26271: [Applet]Update layout based on T10470.

Found this request to display the name of the stream https://bugs.kde.org/show_bug.cgi?id=409453 .
Which was done, but remove here. Maybe should leave it too?
With a quick check, not many applications have this information.

Mon, Jan 13, 1:49 PM · Plasma
ndavis added a comment to D26572: Always render checkbox/radiobutton background.

Since this improves checkbox visibility when rendered over images, should we or should we not do this?

Mon, Jan 13, 11:47 AM · Plasma

Sun, Jan 12

ndavis added a comment to D26595: Add network-wireless-hotspot icon.

Hmm, at normal size, the 8, 16, and 22px versions look too busy to me.:

Sun, Jan 12, 10:45 AM · Frameworks

Sat, Jan 11

ndavis added a comment to D26587: [GTK3] Improve Electron menubar legibility.

Hmm this makes inactive tabs even harder to spot than already :/

Sat, Jan 11, 6:16 PM · Plasma
ndavis added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

These are the 2 Zephyr styles I found. They're not very popular and haven't been updated since 2015. I guess it wouldn't hurt to use Zephyr.
https://store.kde.org/p/1005426/
https://store.kde.org/p/1005427/

Sat, Jan 11, 5:42 PM · VDG, Plasma, Breeze
ndavis added inline comments to D26587: [GTK3] Improve Electron menubar legibility.
Sat, Jan 11, 5:40 PM · Plasma
ndavis accepted D26587: [GTK3] Improve Electron menubar legibility.

I think this is fine.

Sat, Jan 11, 5:37 PM · Plasma
ndavis added reviewers for D26572: Always render checkbox/radiobutton background: Plasma, hpereiradacosta, ngraham.
Sat, Jan 11, 7:50 AM · Plasma

Fri, Jan 10

ndavis updated the diff for D26572: Always render checkbox/radiobutton background.

remove .clangd/

Fri, Jan 10, 7:48 PM · Plasma
ndavis requested review of D26572: Always render checkbox/radiobutton background.
Fri, Jan 10, 7:30 PM · Plasma
ndavis accepted D26555: Rename 'nepomuk' Plasma Theme icons to 'search'.

Icons in the desktop theme that are made to replace icons in the icon theme need to be kept up to date with the icon theme. I'm accepting this as it is, but if @davidre thinks we should continue to support the use of the nepomuk icon name, then include both in the desktop theme. If this seems inelegant, that's because comprehensive icon support is not very pretty, technically. breeze-icons is filled with tons of symlinks for compatibility and there's really nothing we can do about it.

Fri, Jan 10, 3:27 PM · Frameworks

Thu, Jan 9

ndavis updated subscribers of D25814: [KColorScheme] Add SeparatorColor.

I wonder if a path forward is to move this option into Breeze itself and keep it out of the color scheme. We would add an option for "dark separators when using a dark color scheme" in the super hidden Breeze settings window.

Thu, Jan 9, 7:43 PM · Frameworks
ndavis added a comment to T12308: Dolphin UI redesign.

So are we officially abandoning the idea of moving the Breadbcrumbs/URL Navigator into the toolbar? Shall we close T11663?

Thu, Jan 9, 5:15 PM · Dolphin, Goal: All About the Apps, VDG
ndavis added a comment to D26530: ScrollView: Do not overlay scrollbars over contents.

+1 to not using overlay scrollbars on desktop and mimicking their look instead.

Thu, Jan 9, 4:49 AM · Plasma

Wed, Jan 8

ndavis updated the task description for T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.
Wed, Jan 8, 2:09 PM · VDG, Plasma, Breeze
ndavis renamed T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it from Use a different repo for the new version of the Breeze widget style to Use a different repo for the new version of the Breeze widget style and come up with a name for it.
Wed, Jan 8, 2:08 PM · VDG, Plasma, Breeze
ndavis added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

I don't think we should change the icon style to be more rounded. I don't think it would be worth the time and effort required. I also don't like the Breeze Round Corners theme. You can't just round the corners and call it a finished job. Many of those objects depicted have ruined proportions and jagged edges from being clipped.

Wed, Jan 8, 2:01 PM · VDG, Plasma, Breeze

Tue, Jan 7

ndavis added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

This is specifically about a new repo for the new version of the Breeze QStyle and maybe the KDecoration too, which are currently in the breeze repo.

Tue, Jan 7, 10:01 AM · VDG, Plasma, Breeze
ndavis renamed T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it from Use a different repo for the new version of Breeze to Use a different repo for the new version of the Breeze widget style.
Tue, Jan 7, 9:56 AM · VDG, Plasma, Breeze
ndavis accepted D25343: Add an initial page for animations.
Tue, Jan 7, 5:04 AM · VDG, KDE Human Interface Guidelines, Goal: Consistency
ndavis accepted D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow.

+1

Tue, Jan 7, 12:49 AM · Plasma
ndavis added a comment to T12308: Dolphin UI redesign.

I agree, quite nice.

I wonder if we should make the status bar span the entire bottom of the window, not just the view area. And maybe we should keep it with a gray background. That way there would be two gray bars at the top and bottom of the window anchoring everything in the middle.

What do you think?

Tue, Jan 7, 12:12 AM · Dolphin, Goal: All About the Apps, VDG

Mon, Jan 6

ndavis added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

Zephyr is super appropriate—a breeze from the west—but the name reminds me of generic military FPS games for some reason. Also what @cblack said.

Mon, Jan 6, 4:39 PM · VDG, Plasma, Breeze
ndavis added a comment to T12308: Dolphin UI redesign.

If we leave it where it is, what I'd like to do is make it more of a distinct element so that it doesn't blend into the toolbar like it does right now. I think @manueljlin had some mockups showing that which looked pretty good.

Mon, Jan 6, 4:19 PM · Dolphin, Goal: All About the Apps, VDG
ndavis added a comment to T12308: Dolphin UI redesign.

It seems to me that moving the url navigator to the toolbar creates more problems than it solves, because of split views.

What for? Just to be similar to other filemanagers? How many of them have split views anyway?

Mon, Jan 6, 3:56 PM · Dolphin, Goal: All About the Apps, VDG
ndavis added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

I'd like to avoid association with anything violent or negative.

Mon, Jan 6, 1:20 PM · VDG, Plasma, Breeze
ndavis added a comment to D26271: [Applet]Update layout based on T10470.

It is a theme problem. Breeze light also has problem.
Widgets take color from Plasma Style. While in applications are fine.
I checked with this widget to compare.

Mon, Jan 6, 11:47 AM · Plasma
ndavis added a comment to D26271: [Applet]Update layout based on T10470.

Why do the unchecked radiobuttons have a dark outline in your screenshot?

Mon, Jan 6, 10:08 AM · Plasma
ndavis added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

We could also come up with a completely different name.

Mon, Jan 6, 2:55 AM · VDG, Plasma, Breeze
ndavis added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

What should we call the new version of Breeze so we can use it as the repo name? I thought about Breeze 2 or Breeze 6, but those seem like they might cause confusion for users, especially if distros continue to package the old version of Breeze along side the new version.

Mon, Jan 6, 2:55 AM · VDG, Plasma, Breeze

Sun, Jan 5

ndavis added a comment to D26441: New icon for KTimeTracker.

The top part looks a bit too flat and wide. There's also nothing attaching it to the body, so it looks like it's floating.

Sun, Jan 5, 8:52 PM · Frameworks
ndavis accepted D26404: Turn application/x-ms-shortcut into an actual shortcut icon.

Make sure you copy to breeze dark as well

Sun, Jan 5, 8:34 PM · Frameworks
ndavis added a comment to T11052: Accent Colors, Color Ramps and other improvements to theming..

@ndavis by "this" do you mean the whole accent color idea? If so, I don't really agree, sorry. No matter how easy we make it to edit color schemes, doing so will still be a much more heavyweight experience and a less discoverable feature compared to a simple color picker exposed at the top level of the KCM that overrides the color scheme's highlight color. The idea of an accent color feature is basically saying, "this is the color in the current color that the user is most likely to want to change to suit their personal aesthetic preferences, so let's make it really really easy to do so."

Sun, Jan 5, 7:15 AM · Plasma, VDG
ndavis requested changes to D26404: Turn application/x-ms-shortcut into an actual shortcut icon.

For 16/22px, symlinking to existing monochrome link icons is acceptable.

Sun, Jan 5, 6:32 AM · Frameworks
ndavis accepted D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections.
Sun, Jan 5, 6:25 AM · Plasma
ndavis added a comment to T11052: Accent Colors, Color Ramps and other improvements to theming..

I don't see a great benefit to implementing this. While the addition of an accent color feature and an improved color scheme editor are not mutually exclusive, I think that an easier color scheme editor would significantly reduce the need for an accent color feature.

Sun, Jan 5, 3:21 AM · Plasma, VDG

Sat, Jan 4

ndavis added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

The downside of course is that it could take years to roll out the new theme if we make it a separate fork/codebase. If we do go that route, I'd like to try for an aggressive timetable and not get stuck in analysis paralysis and shooting for absolute perfection.

Sat, Jan 4, 3:57 AM · VDG, Plasma, Breeze
ndavis accepted D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel.
Sat, Jan 4, 2:54 AM · Plasma
ndavis added a comment to T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.

Are you going to open a sysadmin ticket about this?

Sat, Jan 4, 2:35 AM · VDG, Plasma, Breeze

Fri, Jan 3

ndavis added a parent task for T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it: T10891: Breeze theme evolution.
Fri, Jan 3, 11:47 PM · VDG, Plasma, Breeze
ndavis added a subtask for T10891: Breeze theme evolution: T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it.
Fri, Jan 3, 11:47 PM · Plasma 6, Plasma, VDG, Breeze
ndavis triaged T12488: Use a different repo for the new version of the Breeze widget style and come up with a name for it as Normal priority.
Fri, Jan 3, 11:47 PM · VDG, Plasma, Breeze
ndavis requested changes to D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel.

Actually, this does have some negative effects on the appearance.

Fri, Jan 3, 6:59 AM · Plasma
ndavis accepted D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel.

This works for me. Is it possible to enforce a minimum font size?

Fri, Jan 3, 6:49 AM · Plasma