Feed Advanced Search

Yesterday

ndavis added a watcher for Plasma Accessibility: ndavis.
Sun, Sep 22, 8:11 PM
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

Is there any way we can preserve the original goal of using a monochrome icon here for small sizes?

Sun, Sep 22, 6:48 PM · Plasma
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

Those are in the System Tray, which always shows monochrome icons. Show Desktop is a standalone widget, which has logic to switch its icon between monochrome and colorful icons depending on the size of the container that the icon is inside.

Sun, Sep 22, 6:29 PM · Plasma
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

Is there any way we can preserve the original goal of using a monochrome icon here for small sizes?

Yes, it is already done. Lower the panel icon size to 16 or 22 px.

That doesn't help the huge fraction of people who never touch the default settings though. What's especially silly IMO is that the default panel height is 36px, at which size everything with a colorful icon version gets the colorful version... but if you reduce the panel height just one tick to 34px, the icons get smaller and everything becomes monochrome and it all looks great.

I feel like we should either slightly reduce the default height of the panel to 34px, or change its icon sizing logic so that the threshold for everything turning colorful happens at some size that's greater than 36px.

Why the Notifications, Volume, Network, etc. icons are monochrome, but "Show desktop" and "Minimize all" icons is hard to make a monochrome?
Colored icon of "Show desktop" and "Minimize all" is bigger that other monochrome icons.

Sun, Sep 22, 6:27 PM · Plasma
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

I really don't like that in the Plasma 5.17 Beta you returned a colored icon, when in Plasma 5.16 you added a monochrome icon i was glad. I don't like this regression. We need to talk with Consistency and VDG about how to return and make a monochrome icon better.

Sun, Sep 22, 6:00 PM · Plasma
ndavis added a comment to D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size".

Is there any way we can preserve the original goal of using a monochrome icon here for small sizes?

Sun, Sep 22, 5:13 PM · Plasma
ndavis added a comment to D24127: Fix toggle button colours.

@cblack Can you change the focus state to only have a blue outline? This behavior is really confusing, even though it seems consistent with Breeze: -snip-

I'd rather not diverge from the Breeze here for a few reasons:

  • I don't have a guarantee that Breeze is going to have the exact same change
  • Breeze GTK is supposed to look like the current state of Breeze, with adaptations where necessary due to differences between GTK and Qt

    If Breeze gets the change, I'll add it.
Sun, Sep 22, 5:59 AM · Plasma

Sat, Sep 21

ndavis added a subtask for T11316: Systematic KCM reorganisation: Workspace section: T11730: Move desktop effects out of the Desktop Effects KCM and into KCMs related to their functions.
Sat, Sep 21, 7:44 AM · Plasma, VDG
ndavis added a parent task for T11730: Move desktop effects out of the Desktop Effects KCM and into KCMs related to their functions: T11316: Systematic KCM reorganisation: Workspace section.
Sat, Sep 21, 7:44 AM · Plasma, VDG
ndavis edited projects for T11730: Move desktop effects out of the Desktop Effects KCM and into KCMs related to their functions, added: Plasma; removed KWin.
Sat, Sep 21, 7:31 AM · Plasma, VDG
ndavis created T11730: Move desktop effects out of the Desktop Effects KCM and into KCMs related to their functions.
Sat, Sep 21, 7:30 AM · Plasma, VDG
ndavis added a comment to D24127: Fix toggle button colours.

This behavior is really confusing, even though it seems consistent with Breeze

I really dislike this about Breeze itself and would welcome a fix there too. Then maybe we can make the default button actually be blue, rather than an almost-indistinguishable shade of gray (See https://bugs.kde.org/show_bug.cgi?id=386158).

Sat, Sep 21, 2:01 AM · Plasma
ndavis added a comment to D24127: Fix toggle button colours.

In the beginning of the video where it looks like I'm just hovering, I'm actually clicking once a second.

Sat, Sep 21, 1:57 AM · Plasma
ndavis requested changes to D24127: Fix toggle button colours.
Sat, Sep 21, 1:56 AM · Plasma
ndavis added a comment to D24127: Fix toggle button colours.

@cblack Can you change the focus state to only have a blue outline? This behavior is really confusing, even though it seems consistent with Breeze:

Sat, Sep 21, 1:56 AM · Plasma
ndavis added a comment to D24127: Fix toggle button colours.

Ah, I only tested Breeze Dark, which uses the same white text color for everything.

Sat, Sep 21, 1:52 AM · Plasma
ndavis accepted D24127: Fix toggle button colours.
Sat, Sep 21, 1:51 AM · Plasma
ndavis added a comment to D12992: New elisa icon.

icons/apps/22/elisa.svg does not apply cleanly. Not sure why.

Sat, Sep 21, 1:44 AM · Frameworks, Elisa
ndavis added a comment to D24125: [GTK3] Scrollbars now have proper states.

Sliders look fixed, but the scrollbar still isn't right. The scrollbar should have the same groove color as the sliders.

Sat, Sep 21, 1:34 AM · Plasma
ndavis added a comment to D24125: [GTK3] Scrollbars now have proper states.

Nothing changed

Sat, Sep 21, 1:19 AM · Plasma
ndavis accepted D24126: [GTK3] CSD windows show handles on .solid-csd.
Sat, Sep 21, 1:17 AM · Plasma
ndavis added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

Looks fixed on my end

Sat, Sep 21, 1:17 AM · Plasma
ndavis added a comment to D24125: [GTK3] Scrollbars now have proper states.

I think the alpha levels need to be swapped.

Sat, Sep 21, 1:13 AM · Plasma
ndavis added a comment to D24125: [GTK3] Scrollbars now have proper states.

The slider backgrounds are too bright on Breeze

Sat, Sep 21, 1:09 AM · Plasma
ndavis added a comment to D24125: [GTK3] Scrollbars now have proper states.

Actually, not sure if this code works how I think it works. 0.2 should actually be less dark than 0.3 if I understand it correctly.

Sat, Sep 21, 12:28 AM · Plasma
ndavis added inline comments to D24125: [GTK3] Scrollbars now have proper states.
Sat, Sep 21, 12:25 AM · Plasma

Fri, Sep 20

ndavis added a comment to D24126: [GTK3] CSD windows show handles on .solid-csd.

What is that white dot in the corner?

Fri, Sep 20, 11:18 PM · Plasma
ndavis added a comment to D24121: [GTK3] Assorted bugfixes.

Could you separate these into different patches? It's generally not good practice to land a bunch of unrelated changes in one commit.

Fri, Sep 20, 9:07 PM · Plasma

Thu, Sep 19

ndavis added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

Works just as well as it did before the patch for me.

Thu, Sep 19, 7:00 PM · Plasma
ndavis accepted D24070: Don't use toolTipMainText to show info, rather use the second line.
Thu, Sep 19, 6:53 PM · Plasma
ndavis added a comment to D24091: Move "Full Screen Mode" item from Settings menu to View menu.

Do you think I should always have a separator above the Full Screen menu item? This should generally work fine, but it means that in case the MergeLocal content is empty, there will be two separators in a row. I don't know how likely this is to ever happen, but it could. Thoughts?

I'm not sure what MergeLocal does or when it would be empty.

Thu, Sep 19, 4:56 PM · Frameworks
ndavis accepted D24091: Move "Full Screen Mode" item from Settings menu to View menu.
Thu, Sep 19, 4:32 PM · Frameworks
ndavis added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

I think it's redundant to say "change level" since the percentage is always the charge level. I also think keeping the language consistent is a good idea. The volume tooltip says "Volume at %", which is why I originally suggested "Battery at %".

Thu, Sep 19, 3:57 PM · Plasma
ndavis added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.
In D24070#534719, @mthw wrote:

@ndavis So, generally, you would like to switch the two lines?

Thu, Sep 19, 3:53 PM · Plasma
ndavis added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

Volume shows the percentage in the main title so this is inconsistent now.
Perhaps instead show some other information like remaining time in the subtext?

Yes, perhaps it should be like this:

Battery at 100%
Plugged in, not charging

Yeah, that makes sense to me. Put the primary information in the first line, and additional information in the second line. For example:

4:58 remaining
55% Battery charge level
2:08 until fully charged
78% Battery charge level
2:08 until fully charged
78% Battery charge level
Battery 100% charged
Plugged in

(not totally sure about that last one, just an idea)

Thu, Sep 19, 3:51 PM · Plasma
ndavis added a comment to T10243: Some KDE applications could use better icons.

Most common problems for me are: (1) path that is correctly displayed but can't be edited with Inkscape, just moved around

Thu, Sep 19, 3:41 PM · KDE Applications, VDG
ndavis added a comment to D24070: Don't use toolTipMainText to show info, rather use the second line.

Volume shows the percentage in the main title so this is inconsistent now.
Perhaps instead show some other information like remaining time in the subtext?

Thu, Sep 19, 12:19 PM · Plasma
ndavis added a comment to T10243: Some KDE applications could use better icons.

EDIT: I have already said this here and there but please don't run any automated script to SVG icons, because when opening them back in Inkscape they are corrupted and everytime I edit a Breeze icon I have to do additional work to fix shapes and gradients corrupted by the scripts.

This is something you should bring up in the VDG chatroom and discuss with @ndavis in particular as we currently make heavy use of these scripts for optimization purposes. Hopefully we can come up with a solution together.

Thu, Sep 19, 1:26 AM · KDE Applications, VDG

Wed, Sep 18

ndavis accepted D23712: [Cuttlefish] Overhaul program, use Kirigami.

It would be nice to have this in the stable release.

Wed, Sep 18, 6:16 AM · Plasma

Tue, Sep 17

ndavis updated the task description for T11713: Reorganize colorscheme colors and use them in a logical manner.
Tue, Sep 17, 7:33 PM · Plasma, Consistency, VDG, Breeze
ndavis added a project to T11713: Reorganize colorscheme colors and use them in a logical manner: Plasma.
Tue, Sep 17, 7:32 PM · Plasma, Consistency, VDG, Breeze
ndavis accepted D24033: Add Meta+Space as a default shortcut to activate KRunner.

+1, but I'm curious what others have to say. I definitely agree that Meta should be for global shortcuts and global desktop shell related shortcuts in particular.

Tue, Sep 17, 7:26 PM · Plasma
ndavis moved T11713: Reorganize colorscheme colors and use them in a logical manner from Reported to Apps Implementation on the Consistency board.
Tue, Sep 17, 7:22 PM · Plasma, Consistency, VDG, Breeze
ndavis triaged T11713: Reorganize colorscheme colors and use them in a logical manner as Normal priority.
Tue, Sep 17, 7:22 PM · Plasma, Consistency, VDG, Breeze
ndavis accepted D24015: Added scripts to create a webfont out of all breeze action icons.
Tue, Sep 17, 4:41 PM · Frameworks
ndavis closed D24008: Make renderDialGroove() area match the maximum renderDialContents() area.
Tue, Sep 17, 4:40 PM · Plasma
ndavis committed R31:8e63d4509267: Make renderDialGroove() area match the maximum renderDialContents() area (authored by ndavis).
Make renderDialGroove() area match the maximum renderDialContents() area
Tue, Sep 17, 4:40 PM
ndavis updated the diff for D24008: Make renderDialGroove() area match the maximum renderDialContents() area.

Remove extra declaration of first

Tue, Sep 17, 4:40 PM · Plasma
ndavis accepted D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running.
Tue, Sep 17, 4:36 PM · Plasma

Mon, Sep 16

ndavis added a comment to D23798: Polish Displays KCM UI.

The orientation toolbuttons seem oversized.

Mon, Sep 16, 10:35 PM · Plasma
ndavis added a comment to D24008: Make renderDialGroove() area match the maximum renderDialContents() area.

Doesn't this mean that the visual appearance of the dial will change depending on what the maximum value is?

Mon, Sep 16, 9:12 PM · Plasma
ndavis added a comment to D21815: [sddm-theme] Start moving from QQC1 to QQC2.

Is this screenshot outdated? Why does the selected item extend outside the width of the list?

Mon, Sep 16, 8:51 PM · Plasma
ndavis updated the test plan for D24008: Make renderDialGroove() area match the maximum renderDialContents() area.
Mon, Sep 16, 8:41 PM · Plasma
ndavis requested review of D24008: Make renderDialGroove() area match the maximum renderDialContents() area.
Mon, Sep 16, 8:38 PM · Plasma
ndavis committed R856:abb875246a30: Add document-share* icons (authored by ndavis).
Add document-share* icons
Mon, Sep 16, 4:14 PM
ndavis closed D23997: Add document-share* icons.
Mon, Sep 16, 4:14 PM · Plasma
ndavis requested review of D23997: Add document-share* icons.
Mon, Sep 16, 4:10 PM · Plasma

Sun, Sep 15

ndavis added a comment to D23712: [Cuttlefish] Overhaul program, use Kirigami.

There seems to be a blank entry at the bottom of the category list:

Sun, Sep 15, 9:17 PM · Plasma
ndavis added a comment to D23712: [Cuttlefish] Overhaul program, use Kirigami.

The clickable area is significantly smaller than the highlight.

Sun, Sep 15, 9:15 PM · Plasma
ndavis added a comment to D23712: [Cuttlefish] Overhaul program, use Kirigami.

Text still gets cut off on the left side:

Sun, Sep 15, 9:14 PM · Plasma
ndavis added a comment to D23712: [Cuttlefish] Overhaul program, use Kirigami.

The sidebar seems a bit wide. Maybe remove the 128px view? As a Breeze icon designer, I don't really need it.

Sun, Sep 15, 9:13 PM · Plasma
ndavis added a comment to D23712: [Cuttlefish] Overhaul program, use Kirigami.

The colorscheme selector does not work

Sun, Sep 15, 9:08 PM · Plasma

Sat, Sep 14

ndavis accepted D23942: Add enablefont and disablefont icon for kfontinst KCM.
Sat, Sep 14, 9:38 PM · Frameworks
ndavis added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.
In D23942#531337, @GB_2 wrote:

Shouldn't the checkmark be green?

FWIW, both should be black/white. Disabling is not a destructive action like removing.

Sat, Sep 14, 6:07 PM · Frameworks
ndavis added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

@ndavis, @broulik, @ngraham, I made some change. Can you have another look?

Sat, Sep 14, 5:47 PM · Frameworks
ndavis added a comment to D23942: Add enablefont and disablefont icon for kfontinst KCM.

Oof, all of the font icons that contain an 'A' need to be cleaned up someday. The 'A's aren't even 16px tall and the line thickness and alignment is all over the place. I guess that's something for another patch. For now, we should maintain consistency with the existing font icons.

Sat, Sep 14, 2:16 PM · Frameworks
ndavis requested changes to D23942: Add enablefont and disablefont icon for kfontinst KCM.

There's a bit too much space around the checkmark.

Sat, Sep 14, 2:14 PM · Frameworks

Fri, Sep 13

ndavis added a comment to D23932: WIP Implement backends as plugins.

Flexibility sounds good, but how am I supposed to know what I'm looking at or what options to pick? Perhaps it's better to handle the backends automatically, if possible?

Fri, Sep 13, 8:31 PM · Spectacle

Thu, Sep 12

ndavis added projects to T11124: Unify highlight effect style: Breeze, Plasma.
Thu, Sep 12, 2:09 PM · Plasma, Breeze, Consistency, VDG
ndavis added a project to T11192: Create a HIG entry for highlight effect: KDE Human Interface Guidelines.
Thu, Sep 12, 2:08 PM · KDE Human Interface Guidelines, Consistency, VDG
ndavis moved T11192: Create a HIG entry for highlight effect from Reported to HIG Specification on the Consistency board.
Thu, Sep 12, 2:07 PM · KDE Human Interface Guidelines, Consistency, VDG
ndavis added a project to T11192: Create a HIG entry for highlight effect: Consistency.
Thu, Sep 12, 2:07 PM · KDE Human Interface Guidelines, Consistency, VDG
ndavis moved T11124: Unify highlight effect style from Reported to VDG Discussion on the Consistency board.
Thu, Sep 12, 2:06 PM · Plasma, Breeze, Consistency, VDG
ndavis added a project to T11124: Unify highlight effect style: Consistency.
Thu, Sep 12, 2:06 PM · Plasma, Breeze, Consistency, VDG
ndavis added a member for Consistency: ndavis.
Thu, Sep 12, 2:03 PM
ndavis accepted D23389: Use visible buttons to switch the default device.
Thu, Sep 12, 12:57 AM · Plasma

Wed, Sep 11

ndavis requested changes to D23389: Use visible buttons to switch the default device.
Wed, Sep 11, 11:55 PM · Plasma
ndavis added a comment to D23389: Use visible buttons to switch the default device.

I find the use of filled and empty stars visually odd. They're like Jerry-rigged radio buttons that look like PushButtons. We also can't guarantee that star-shape will be empty and favorite will be filled in 3rd party icon themes.

Wed, Sep 11, 11:46 PM · Plasma
ndavis added a comment to R98:523249683744: [GTK3] Make CSD window decorations 18px instead of 16px.

I have some buttons that are half white and full white sometimes when they should not be. This is the latest version.

Wed, Sep 11, 5:00 PM
ndavis added a reviewer for D23879: Add Qt Designer icon symlink: ndavis.

We should probably redo or completely remove the current Qt icons since they're very Qt4 and look outdated. Unless the current Qt icons are updated, I don't think we should have this symlink.

Wed, Sep 11, 4:24 PM · Frameworks
ndavis added a comment to D23876: [applets/kickoff] Tweak padding for lists.

Better, but now the padding is inconsistent between the sides and bottom:

Wed, Sep 11, 3:10 PM · Plasma
ndavis added a comment to D23876: [applets/kickoff] Tweak padding for lists.

Look at the top of the view in both screenshots and bottom of the view in the 2nd. Rather than cutting off the content of the items right at the separator as they go out of the visible area, they get cut off early. I think the way they were cut off before was better. I'm guessing that the area around the separator was extended.

Wed, Sep 11, 3:02 PM · Plasma
ndavis requested changes to D23848: Add Breeze icons for Jupyter Notebook files.

The spheres around the planet need better pixel alignment, particularly on the 16, 22 and 32px versions. The planet itself could have better pixel alignment too, but it's not as critical.

Wed, Sep 11, 12:11 AM · Frameworks

Tue, Sep 10

ndavis accepted D23850: Use more appropriate icon that's colorful at small sizes.
Tue, Sep 10, 8:28 PM
ndavis accepted D23845: Add a mode to center actions and omit the title when using a ToolBar style.
Tue, Sep 10, 7:22 PM · Kirigami
ndavis accepted D23847: When in Desktop view, show a desktop-style toolbar with centered actions.
Tue, Sep 10, 7:20 PM
ndavis added a comment to T11093: Improve Consistency across the Board.

Here's my 2 cents:

I think toolbars themselves are also inconsistent. Some icons will be followed by text, while some will not, and some icon-only buttons are also mixed with icon+text buttons. you can see, for example, here and here how that mixing happens.

Taking two other DEs as reference, their toolbars are usually only icons, icons with text, or just text, all with minimal mixing. The result is a uniform, consistent look, which makes them look really pleasing to the eyes. Examples: Gnome, MacOS.

In case of icon-only toolbars, tooltips on mouse over or a button press could give a description of the button's purpose. Having intuitive buttons for each action would be the ideal, though, as you'd be able to ditch the text, keep the toolbars compact, and free up space for more actions.

Tue, Sep 10, 2:24 PM · Consistency, Goal Setting 2019
ndavis added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

Fair enough.

Tue, Sep 10, 3:27 AM · Dolphin
ndavis added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

Why not just keep New Tab/Window in the Context menu? The hamburger is already a bit overfull. The context menu isn't that long by comparison and it wouldn't be any longer than it is with a folder selected.

Tue, Sep 10, 12:24 AM · Dolphin
ndavis added a comment to T11526: Create an HIG for large colorful action icons.

I guess we can create colorful versions of action items on a need-to-have basis, as long as we commit to not using them for actual actions in buttons etc. for our own apps.

Tue, Sep 10, 12:16 AM · Breeze, VDG
ndavis accepted D23778: Remove superfluous 32px recent documents icons.
Tue, Sep 10, 12:14 AM · Frameworks

Mon, Sep 9

ndavis added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

Why is it that sometimes Create New is in its own section and sometimes it's grouped with Open With or New Tab/Window?

As for Add to Places, perhaps it should just be in its own section above the services section? It doesn't really go with anything else and I was never bothered by it being in its own section.

One of the reasons why I wanted to do this patch is because I think single-item sections are ugly and make the menu feel cramped and overwhelming, and the goal was to get rid of them as much as possible.

Mon, Sep 9, 7:21 PM · Dolphin
ndavis added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

Why is it that sometimes Create New is in its own section and sometimes it's grouped with Open With or New Tab/Window?

Mon, Sep 9, 5:33 PM · Dolphin
ndavis accepted D23803: [Folder View] Add subtle shadows to icons.

+1

Mon, Sep 9, 5:18 PM · Plasma
ndavis added a comment to D23798: Polish Displays KCM UI.

What are "Values of an output"? I don't understand what these 2 settings do.

Mon, Sep 9, 3:35 PM · Plasma
ndavis added a comment to T11526: Create an HIG for large colorful action icons.

IMO we should not be using action icons in these larger sizes in the first place--at least not in apps. The places where we are doing this should be corrected in the apps themselves.

For example Okular's sidebar category chooser is something I'm actually working on removing and transforming into a more standard combobox-based category chooser UI.

In the Places panel we should be using places icons for entries so that they have pretty large sizes.

Plasma uses large >22px monochrome icons in a lot of places, so maybe we should concentrate on that. I think they can look acceptable at up to 32px size, maybe with bigger line weights. At larger sizes, it's probably not appropriate to use a monochrome icon, which suggests that if only a monochrome icon is available, it should be 32px in size as a maximum, and if more space is needed, we should maybe enclose it in a visible button with larger bounds rather than making it a toolbutton.

Mon, Sep 9, 2:43 PM · Breeze, VDG
ndavis added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.
  • A user may wish to duplicate the current view in a new tab or window
  • A user may wish to create a file inside of a folder while at the level of a higher folder in tree/details view
Mon, Sep 9, 11:20 AM · Dolphin

Sun, Sep 8

ndavis triaged T11526: Create an HIG for large colorful action icons as Normal priority.
Sun, Sep 8, 6:57 PM · Breeze, VDG
ndavis created T11526: Create an HIG for large colorful action icons.
Sun, Sep 8, 6:57 PM · Breeze, VDG
ndavis added a comment to D23757: Clean up hamburger menu and viewport and single-folder context menus.

It might make sense to put Add to Places next to Assign Tags. They're slightly related in that they're meant to make accessing some files or folders faster.

Sun, Sep 8, 12:53 PM · Dolphin