Feed Advanced Search

Today

ndavis added a comment to T8755: Use colors from the color scheme for the Task Manager's accent color.

It seems that it works with Breeze but not Breeze Dark, which stays blue regardless of color scheme. I am on Plasma 5.12 LTS admittedly.

This is because the Breeze Light and Breeze Dark desktop themes come with their own built-in colorschemes. If you want your desktop theme to be the same as your system colorscheme, use Breeze, even if you're using a dark colorscheme.

The reason why there are 2 desktop themes with built-in colors is that a user may want to have something like a dark panel with light applications.

Why does the blue color need to be hardcoded is my question

TBH, I just copied the Breeze Dark colorscheme and pasted it here: https://cgit.kde.org/plasma-framework.git/tree/src/desktoptheme/breeze-dark

Maybe if I removed the color settings for everything except the background and text colors, it would get the rest from the system colorscheme, but I don't know.

From what I can gather that would work!

Tue, May 21, 12:32 AM · VDG, Plasma, Breeze

Yesterday

ndavis added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.

Can you use the NegativeText color from the colorscheme instead of a custom danger color?

Mon, May 20, 11:28 PM · Dolphin
ndavis added a comment to T8755: Use colors from the color scheme for the Task Manager's accent color.

It seems that it works with Breeze but not Breeze Dark, which stays blue regardless of color scheme. I am on Plasma 5.12 LTS admittedly.

This is because the Breeze Light and Breeze Dark desktop themes come with their own built-in colorschemes. If you want your desktop theme to be the same as your system colorscheme, use Breeze, even if you're using a dark colorscheme.

The reason why there are 2 desktop themes with built-in colors is that a user may want to have something like a dark panel with light applications.

Why does the blue color need to be hardcoded is my question

Mon, May 20, 11:21 PM · VDG, Plasma, Breeze
ndavis added a comment to T8755: Use colors from the color scheme for the Task Manager's accent color.

It seems that it works with Breeze but not Breeze Dark, which stays blue regardless of color scheme. I am on Plasma 5.12 LTS admittedly.

Mon, May 20, 10:39 PM · VDG, Plasma, Breeze
ndavis added a comment to T8755: Use colors from the color scheme for the Task Manager's accent color.

Never mind, turns out they weren't hardcoded from the start, so opacity was never an issue. @lavender I'm not sure what you're actually requesting now. Are you asking for a utility that will generate colorschemes that are based around a single color?

Mon, May 20, 9:13 PM · VDG, Plasma, Breeze
ndavis added a comment to T8755: Use colors from the color scheme for the Task Manager's accent color.

Actually, the opacity and stylesheets work fine for the drive-multipartition icon. Maybe the stylesheets don't work because of the conflicting opacity and fill-opacity values? Maybe it's opacity in particular that's the problem? drive-multipartition uses fill-opacity.

Mon, May 20, 7:05 PM · VDG, Plasma, Breeze
ndavis added a comment to T8755: Use colors from the color scheme for the Task Manager's accent color.

Anyway, +1, we should do this. It should actually be pretty easy since I believe the SVGs already have support for reading data from the color scheme. So maybe all we need to do is wire that up rather than using a hardcoded color.

@ndavis, do you know if this is possible?

Mon, May 20, 6:53 PM · VDG, Plasma, Breeze
ndavis committed R266:2847d7c8716c: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip (authored by ndavis).
Symlink arrow-*-double to go-*-skip, add 24px go-*-skip
Mon, May 20, 7:20 AM
ndavis closed D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip.
Mon, May 20, 7:20 AM · Frameworks
ndavis committed R985:8515db8e98e3: Update icon margin info (authored by ndavis).
Update icon margin info
Mon, May 20, 3:29 AM

Sun, May 19

ndavis added a comment to D20689: Elide tab titles left so key information at the end of the string doesn't get cut off.

Can you elide up to the forward slash and not after unless there is no room? Like this:

Sun, May 19, 7:07 PM · Dolphin

Fri, May 17

ndavis accepted D21264: Display accurate status message during installation.
Fri, May 17, 8:40 PM

Wed, May 15

ndavis accepted D21234: Use a more conventional sidebar header apparance in desktop view.

I think this is much better. I like the inclusion of a home button as well.

Wed, May 15, 9:36 PM · Plasma
ndavis added a comment to D21234: Use a more conventional sidebar header apparance in desktop view.

I noticed that there is a difference between the padding around the search bar in SySe and Discover. Do you know why this is?

Wed, May 15, 8:20 PM · Plasma
ndavis committed R266:2078a10ea1b0: Change input-* device icon styles, add 16px icons (authored by ndavis).
Change input-* device icon styles, add 16px icons
Wed, May 15, 4:42 PM
ndavis closed D20708: Change input-* device icon styles, add 16px icons.
Wed, May 15, 4:42 PM · Frameworks
ndavis accepted D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser.

LGTM, visually.

Wed, May 15, 4:26 AM · Plasma
ndavis accepted D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI.

Alright, LGTM then.

Wed, May 15, 2:48 AM · Plasma
ndavis added a comment to D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI.

It does on the desktop, yes. On mobile, it's always visible.

Wed, May 15, 2:40 AM · Plasma
ndavis accepted D21218: Create new icon for Knights based on Anjuta's icon.

LGTM

Wed, May 15, 2:35 AM · Frameworks
ndavis accepted D21194: [Holidays plugin] Port partially to QQC2 and modernize UI.

No visual changes, so LGTM

Wed, May 15, 2:17 AM · Plasma
ndavis accepted D21189: [System tray] Modernize "Entries" category.

LGTM, visually

Wed, May 15, 2:15 AM · Plasma
ndavis added a comment to D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI.

Does the button to remove items show up on hover? I don't see it anywhere.

Wed, May 15, 2:14 AM · Plasma
ndavis accepted D21193: [Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout.

LGTM, visually

Wed, May 15, 2:09 AM · Plasma
ndavis requested changes to D21218: Create new icon for Knights based on Anjuta's icon.

Once you've optimized the SVGs, I'll approve this.

Wed, May 15, 1:11 AM · Frameworks

Tue, May 14

ndavis added a comment to D21218: Create new icon for Knights based on Anjuta's icon.

Why not mirror the Anjuta icon and use the same background color as the original Knights icon? So that it looks closer to the original.

Tue, May 14, 5:06 PM · Frameworks
ndavis updated the test plan for D20708: Change input-* device icon styles, add 16px icons.
Tue, May 14, 6:43 AM · Frameworks
ndavis updated the diff for D20708: Change input-* device icon styles, add 16px icons.

Add new dialog-input-devices icons

Tue, May 14, 6:38 AM · Frameworks
ndavis added a comment to D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.

In practice, the thumbnail delegates are much smaller; is anyone gonna notice that (famous last words)?

Tue, May 14, 6:20 AM · Frameworks

Sat, May 11

ndavis added a comment to D20708: Change input-* device icon styles, add 16px icons.

Even if only Inkscape currently uses the icon, as a rule we ignore that kind of information for code/content in Frameworks, because in principle any app could use it. It's more important for the icon to be semantically correct for any app that wants to use it than it is for it to match its current sole user.

For dialog-input-devices, I would accept an icon that includes a drawing tablet, but not one that has only a drawing tablet.

Sat, May 11, 3:51 PM · Frameworks
ndavis added a comment to D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight.

Which still leaves you with fixing the gaps when there's not thumbnail. I'd suggest to do:

radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2

and call it a day :P

Sat, May 11, 3:13 PM · Frameworks
ndavis abandoned D15934: Add battery and bluetooth icons for other DE compatibility.
Sat, May 11, 1:25 AM · Frameworks

Fri, May 10

ndavis added a comment to D12445: Add shortcut for application menu.

+1 for this feature.

Fri, May 10, 5:11 PM · KWin

Wed, May 8

ndavis added a comment to T10875: Plasma 5.16 Release: Wallpaper competition.

@paulb, VDG, would you guys be okay with changing the forum post's rules to have the following?

  1. Do not add the Plasma version number into your wallpaper. Any logos or text, such as the (Plasma logo) must be integrated into the design of the wallpaper itself, not just added on top as text
Wed, May 8, 4:14 PM · KDE Promo
ndavis updated the test plan for D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip.
Wed, May 8, 3:27 PM · Frameworks
ndavis requested review of D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip.
Wed, May 8, 3:25 PM · Frameworks

Tue, May 7

ndavis added a comment to D21063: Symlink arrow-*-double to go-*-skip.

Whoops. Forgot there were no 24px go-*-skip icons. I'll have to fix that and then the patch will work.

Tue, May 7, 4:51 PM · Frameworks
ndavis committed R266:04be2a08ab1b: Symlink arrow-*-double to go-*-skip (authored by ndavis).
Symlink arrow-*-double to go-*-skip
Tue, May 7, 2:56 PM
ndavis closed D21063: Symlink arrow-*-double to go-*-skip.
Tue, May 7, 2:56 PM · Frameworks
ndavis updated the test plan for D21063: Symlink arrow-*-double to go-*-skip.
Tue, May 7, 8:54 AM · Frameworks
ndavis requested review of D21063: Symlink arrow-*-double to go-*-skip.
Tue, May 7, 8:52 AM · Frameworks

Mon, May 6

ndavis added a comment to T10891: Breeze theme evolution.
Mon, May 6, 6:54 PM · VDG, Breeze

Fri, May 3

ndavis accepted D20997: Simplify applet keyboard shortcut chooser's explanatory text.

Yeah, I wonder how often people's eyes glaze over by the time they get halfway through the old description.

Fri, May 3, 6:48 PM · Plasma
ndavis updated the task description for T10413: Specify how to use and classify monochrome vs color icons.
Fri, May 3, 1:52 PM · Plasma, VDG, Breeze
ndavis added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.

Yeah, it would definitely require some work. But I think the results would be worth it. Maybe a good task for the Usability & Productivity sprint if close coordination with others would be useful?

Fri, May 3, 4:56 AM · VDG

Thu, May 2

ndavis added a comment to T10875: Plasma 5.16 Release: Wallpaper competition.

@ndavis, would you like to be a judge?

Thu, May 2, 4:13 PM · KDE Promo
ndavis updated the task description for T10875: Plasma 5.16 Release: Wallpaper competition.
Thu, May 2, 9:07 AM · KDE Promo
ndavis added a comment to T10875: Plasma 5.16 Release: Wallpaper competition.
  1. You can submit as many entries as you want [OR NOT. WHAT DO YOU THINK?]
Thu, May 2, 8:03 AM · KDE Promo
ndavis added a comment to T10875: Plasma 5.16 Release: Wallpaper competition.

I agree with the intention, although in practice you could just get people scrapping the metadata anyway or giving up on submitting a wallpaper.

Thu, May 2, 7:58 AM · KDE Promo

Wed, May 1

ndavis added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.

Ah, I see what you mean, yeah. If a lot of the existing ones aren't even made to align to the pixel grid , I think that's even more reason to move away from the style. Line-art not aligned to the grid seems pretty pointless.

Maybe the larger versions could be scaled down with a script and then just individually tweaked?

Wed, May 1, 3:04 AM · VDG
ndavis added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.

Those 22px versions look totally fine, I say. But I see what you mean for the 16px versions. Maybe we could permit those to be widened by an extra pixel on each side. But is it really impossible to fit stuff into that existing size? For the C++ one for example, perhaps the plus signs could actually be inside the C instead of above and to the right. For the other one, maybe the internal frame around those lines could be dropped.

Wed, May 1, 2:28 AM · VDG
ndavis added a comment to T10870: Consider using colorful rather than monochrome icons for small places, devices, and mimetype icons.

I somewhat agree that it looks better, but this might increase the difficulty of making new mimetype icons significantly. If we were allowed to have no margins on 16 and 22 px color icons like with the emblems, then it would be easier. In order to avoid restricting the horizontal space for the inner symbols we already had, we'd need to make the icons kind of like this:

Wed, May 1, 12:17 AM · VDG

Mon, Apr 29

ndavis added a comment to T10413: Specify how to use and classify monochrome vs color icons.
In T10413#183297, @GB_2 wrote:

Figuring this out would be very useful for the new default Show Desktop widget.

Mon, Apr 29, 1:18 PM · Plasma, VDG, Breeze

Sat, Apr 27

ndavis added a comment to D20851: [Pager] Improve label legibility.

[...] In the first screenshot you can see that the number "1" is actually almost invisible. I'm open to suggestions for alternative ways to improve this.

Sat, Apr 27, 1:34 AM · Plasma

Fri, Apr 26

ndavis added a comment to D20851: [Pager] Improve label legibility.

To me, the white text with the shadows doesn't really improve legibility and just looks "off"

Fri, Apr 26, 7:08 PM · Plasma
ndavis added a comment to D19812: Add a web page to view and compare icons of different sizes.

TBH I wonder how useful this actually is. Hopefully some of the other folks involved in making icons (@ndavis, @GB_2, @trickyricky26) can comment on whether or not this would be useful for them.

Fri, Apr 26, 12:13 AM · Frameworks

Thu, Apr 25

ndavis committed R242:176643f48c84: Fix wrong group names for 22, 32 px in audio.svg (authored by ndavis).
Fix wrong group names for 22, 32 px in audio.svg
Thu, Apr 25, 6:01 PM
ndavis closed D20825: Fix wrong group names for 22, 32 px in audio.svg.
Thu, Apr 25, 6:01 PM · Frameworks
ndavis requested review of D20825: Fix wrong group names for 22, 32 px in audio.svg.
Thu, Apr 25, 5:55 PM · Frameworks

Tue, Apr 23

ndavis accepted D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

LGTM

Tue, Apr 23, 5:03 PM · Frameworks
ndavis added a comment to D20746: Remove disable for showing only minimized tasks on Icons only task manager.

@hein You appear to have been the one who created the first version of this line, but I can't figure out why it was added.

Tue, Apr 23, 4:48 PM · Plasma
ndavis abandoned D20654: Update elevation.rst to match default shadow settings.

The change has been commited.

Tue, Apr 23, 3:27 PM
ndavis added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

More like center version in this SVG:

Tue, Apr 23, 10:00 AM · Frameworks
ndavis added a comment to D20693: Remove pixelated border.

+1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked.

Tue, Apr 23, 9:38 AM · KNewStuff, Frameworks

Mon, Apr 22

ndavis committed R242:b5ec56091ed3: Add more icon sizes for audio, configure, distribute (authored by ndavis).
Add more icon sizes for audio, configure, distribute
Mon, Apr 22, 12:42 PM
ndavis closed D20695: Add more icon sizes for audio, configure, distribute.
Mon, Apr 22, 12:42 PM · Frameworks
ndavis added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

The 22px version needs to have 1px thick lines and 3px margins on each side.

Mon, Apr 22, 12:36 PM · Frameworks
ndavis requested changes to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

I'll accept this if you also make 22px versions.

Mon, Apr 22, 6:44 AM · Frameworks
ndavis added a comment to D20708: Change input-* device icon styles, add 16px icons.

Actually, dialog-input-devices is used by inkscape for configuring pointing devices and tablets. AFAIK, only Inkscape uses that icon. If I made it show more types of devices, it would be more accurate to use a tablet. Looking at the Input Devices dock in Inkscape, it doesn't seem like it would be used much for configuring mice, so it might be better if it was just a symlink to the input-tablet icon.

Mon, Apr 22, 2:26 AM · Frameworks
ndavis added a comment to D20708: Change input-* device icon styles, add 16px icons.

Overall very nice.

Instead of symlinking input-mouse to dialog-input-devices, I think it might make more sense to rename dialog-input-devices to be input-mouse and then change the dialog-input-devices so that it depicts more than one input device, to reinforce its name. Maybe a mouse + keyboard?

Mon, Apr 22, 2:01 AM · Frameworks

Sun, Apr 21

ndavis added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".
In D20700#453565, @GB_2 wrote:

list-remove is just a minus icon, which has no context and looks weird when used alone, without list-add next to it. An example where the new icon can be used is D20576.

Sun, Apr 21, 4:25 PM · Frameworks
ndavis updated the test plan for D20708: Change input-* device icon styles, add 16px icons.
Sun, Apr 21, 1:17 PM · Frameworks
ndavis requested review of D20708: Change input-* device icon styles, add 16px icons.
Sun, Apr 21, 1:13 PM · Frameworks
ndavis added a comment to D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none".

Why does list-remove need an alternative?

Sun, Apr 21, 12:22 PM · Frameworks

Apr 20 2019

ndavis updated the diff for D20695: Add more icon sizes for audio, configure, distribute.

Fix 16-16-audio-volume-muted

Apr 20 2019, 11:03 AM · Frameworks
ndavis updated the test plan for D20695: Add more icon sizes for audio, configure, distribute.
Apr 20 2019, 11:02 AM · Frameworks
ndavis updated the test plan for D20695: Add more icon sizes for audio, configure, distribute.
Apr 20 2019, 10:57 AM · Frameworks
ndavis updated the diff for D20695: Add more icon sizes for audio, configure, distribute.

Add 16px audio icons

Apr 20 2019, 10:56 AM · Frameworks
ndavis planned changes to D20695: Add more icon sizes for audio, configure, distribute.

Oops, looks like I need 16px audio icons as well for the volume/mute icons inside the opened audio widget.

Apr 20 2019, 10:37 AM · Frameworks
ndavis updated the test plan for D20695: Add more icon sizes for audio, configure, distribute.
Apr 20 2019, 10:22 AM · Frameworks
ndavis requested review of D20695: Add more icon sizes for audio, configure, distribute.
Apr 20 2019, 10:19 AM · Frameworks

Apr 19 2019

ndavis accepted D20672: Add an icon for Thunderbolt KCM.
Apr 19 2019, 3:15 PM · Frameworks
ndavis requested changes to D20672: Add an icon for Thunderbolt KCM.

Actually, one last thing. Can you save it as a plain SVG so that it isn't filled with Inkscape metadata?

Apr 19 2019, 2:44 PM · Frameworks
ndavis accepted D20672: Add an icon for Thunderbolt KCM.

I like the new top color.

Apr 19 2019, 2:40 PM · Frameworks
ndavis requested changes to D20672: Add an icon for Thunderbolt KCM.

A few problems:

Apr 19 2019, 11:12 AM · Frameworks

Apr 18 2019

ndavis added a reviewer for D20654: Update elevation.rst to match default shadow settings: KDE Human Interface Guidelines.
Apr 18 2019, 9:01 AM
ndavis requested review of D20654: Update elevation.rst to match default shadow settings.
Apr 18 2019, 9:00 AM

Apr 17 2019

ndavis committed R242:cdad9c38c110: Fix stylesheet support for audio-volume-medium (authored by ndavis).
Fix stylesheet support for audio-volume-medium
Apr 17 2019, 6:11 PM
ndavis committed R242:bd8264e92869: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze… (authored by ndavis).
Update audio, drive, edit, go, list, media, plasmavault icons to match breeze…
Apr 17 2019, 5:53 PM
ndavis closed D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.
Apr 17 2019, 5:52 PM · Frameworks
ndavis added a comment to D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.

One concern:

Apr 17 2019, 2:44 AM · Frameworks
ndavis added a reviewer for D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons: Plasma.
Apr 17 2019, 2:43 AM · Frameworks
ndavis updated the test plan for D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.
Apr 17 2019, 2:40 AM · Frameworks
ndavis requested review of D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons.
Apr 17 2019, 2:36 AM · Frameworks

Apr 16 2019

ndavis committed R242:0ff81fe4c728: Align z's to pixel grid in system.svg (authored by ndavis).
Align z's to pixel grid in system.svg
Apr 16 2019, 12:46 PM
ndavis closed D20597: Align z's to pixel grid in system.svg.
Apr 16 2019, 12:46 PM · Frameworks
ndavis updated the summary of D20597: Align z's to pixel grid in system.svg.
Apr 16 2019, 8:28 AM · Frameworks
ndavis requested review of D20597: Align z's to pixel grid in system.svg.
Apr 16 2019, 8:26 AM · Frameworks
ndavis committed R266:db9fdceac1ac: Sharpen Z's in system-suspend* icons (authored by ndavis).
Sharpen Z's in system-suspend* icons
Apr 16 2019, 8:23 AM
ndavis closed D20586: Sharpen Z's in system-suspend* icons.
Apr 16 2019, 8:23 AM · Frameworks