- Queries
- All Stories
- Search
- Advanced Search
All Stories
Mar 22 2019
@ngraham I have made a couple of changes to the patch since you reviewed.
Namely addin refreshPreview() and using refreshMetaData for a different purpose.
This was needed otherwise the patch introduced a bug.
Hello. No, sorry, I don't think I have it.
Do you have commit access?
Improve bash script
In D19812#436154, @pino wrote:
- please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to empty string (to prevent typos)
I'm not sure the promotion a problem in practice in this view. Yes, the promoted task would disappear, but you'd have a project appearing instead and its children would still be there I guess. It's what I'd expect.
No, thanks, I have a sponsor, but I don't have commit access. Please push it for me.
Fair enough. LGTM :)
Hi @lueck. No, I do not have commit access. To be honest, I am not even sure if this change should be made on the trunc branch or the stable branch.
Few notes on the new generate_web_data.sh script:
- please quote the paths properly, otherwise it will break when either the source directory or the build directory contain e.g. spaces
- it does not seem using any bash-specific features, so make it using /bin/sh, to help non-Linux Unices (where usually bash is not available by default, and/or not in /bin)
- please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to empty string (to prevent typos)
@aspotashev does this work, too?
I guess you guys would consider this to be too risky for 5.15? (Although a lot of Nvidia owners - me included - are dying to get this fix).
Redoing the commit to set full name in the commit
Add search function