- User Since
- Aug 22 2016, 1:56 PM (143 w, 6 d)
Tue, May 21
Wed, May 15
Tue, May 14
Mon, May 13
Tue, May 7
Wed, May 1
Tue, Apr 30
Apr 17 2019
Apr 15 2019
Apr 13 2019
Apr 12 2019
Apr 9 2019
Ooops, this didn't work as expected. This should have been a revision of D19327.
There is only small changes:
- Updated commit message.
- In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools.
- In karbon/data/karbon.rc: Removal of the "format" menu (not used) and adding the "format_pagelayout" action to "settings" menu (where it was originally).
Apr 5 2019
Apr 3 2019
Apr 2 2019
Mar 31 2019
Mar 25 2019
Yes, looks sane, I'll deal with it.
I think this should be ok
Mar 22 2019
Mar 21 2019
Mar 20 2019
Yes, sorry, as you say better done separatly.
The directory README also states "Temporary local copy of Brad Hards' rtf-qt library.", though as upstream hasn't had changes since 2011, it seems like a permanent one by now.
Strange indents, could you fix it?
Mar 15 2019
Mar 14 2019
Mar 13 2019
Sorry, only checked HeadersFooters which seems to work fine also with invalidating.
Ok, it works in calligra if stuff is invalidated like in the original:
Accepting was a bit premature.
I found the problem with my system (qt 5.12 has some changes in drag/drop).
Anyway this does not work in calligra, give me a little time to figure it out.
Mar 12 2019
Yup, it was my system acting up, so please commit.
Mar 11 2019
Hmmm, my system seems very broken atm, so cannot test anything with confidence.
I'll get back to you when I get it sorted.
Naah, doesn't work with calligra. I think you need scaling also for the widget case.
A few points:
- KChartPrintingParameters::setScaleFactor( ) is needed?
- Line 1357: Use nullptr
- Patch dosen't apply for me, git gives no reason so don't know why.
Mar 9 2019
Mar 7 2019
Mar 1 2019
Feb 28 2019
Feb 27 2019
Feb 26 2019
Feb 25 2019
Can we get a conclussion to this?
@Camilla Have you come up with any more unit tests?
No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.
Feb 22 2019
Yes, pdf docs work, it is almost 100% handled by poppler.
A lot of code was duplicated between pageapp and karbon
and has been removed from karbon:
Shouldn't that be a separate change - or does multi-page support come automatically with this change?
Well, my initial thought, but there was going to be quite a few intermidiate solutions mainly because
the KoPACanvas cannot be subclassed, so I decided to do everything in one go.