danders (Dag Andersen)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 22 2016, 1:56 PM (143 w, 6 d)
Availability
Available

Recent Activity

Tue, May 21

danders committed R1026:83e8214635d9: Add task description (if any) to task name tooltip (authored by danders).
Add task description (if any) to task name tooltip
Tue, May 21, 11:09 AM
danders committed R1026:e1ce1e4bf300: Never set an invalid datetime on a KGantt::DateTimeGrid, it asserts (authored by danders).
Never set an invalid datetime on a KGantt::DateTimeGrid, it asserts
Tue, May 21, 9:30 AM
danders committed R1026:f97b50453e1a: Calendar: Check for and handle invalid date (authored by danders).
Calendar: Check for and handle invalid date
Tue, May 21, 7:11 AM
danders committed R1026:c3885717a93b: Fix recalculation of started projects (authored by danders).
Fix recalculation of started projects
Tue, May 21, 7:11 AM

Wed, May 15

danders committed R1026:74b50bb46a77: Bug 309038 - Add priority feature, use value for levelling/scheduling. (authored by danders).
Bug 309038 - Add priority feature, use value for levelling/scheduling.
Wed, May 15, 9:28 AM
danders committed R1026:7edcd9782362: MainProjectDialog: Make "General" tab the default (authored by danders).
MainProjectDialog: Make "General" tab the default
Wed, May 15, 9:28 AM

Tue, May 14

danders committed R1026:6656ad19a352: Add documents to project dialog (authored by danders).
Add documents to project dialog
Tue, May 14, 10:18 AM
danders committed R1026:98ba3b4215b6: mprove edit/view Documents. (authored by danders).
mprove edit/view Documents.
Tue, May 14, 10:18 AM
danders committed R1026:8d51c4abf035: WorkPackageView: Enable the same task editing as in other taskviews (authored by danders).
WorkPackageView: Enable the same task editing as in other taskviews
Tue, May 14, 10:18 AM

Mon, May 13

danders committed R1026:dffca2e1f10d: Improve progress dialog (authored by danders).
Improve progress dialog
Mon, May 13, 12:37 PM
danders committed R1026:59987183b165: Avoid creating extra document when opening projects in WelcomeView (authored by danders).
Avoid creating extra document when opening projects in WelcomeView
Mon, May 13, 12:37 PM
danders committed R1026:d4e888094bf6: Re-calculate from current/selected date when re-scheduling started projects (authored by danders).
Re-calculate from current/selected date when re-scheduling started projects
Mon, May 13, 12:37 PM

Tue, May 7

danders committed R1026:c1b285c36983: ++debug (authored by danders).
++debug
Tue, May 7, 9:58 AM
danders committed R1026:2bc870faa371: Add import filter for Gnome Planner project files (authored by danders).
Add import filter for Gnome Planner project files
Tue, May 7, 9:58 AM
danders committed R1026:0c4a8c9c23b9: Fix tooltip for resource availabe until (authored by danders).
Fix tooltip for resource availabe until
Tue, May 7, 9:58 AM
danders committed R1026:2dd23c3eea6a: Remove unnecessary and wrong assert (authored by danders).
Remove unnecessary and wrong assert
Tue, May 7, 9:58 AM
danders committed R1026:69868c8a7179: WorkPackage: Fix fixme (authored by danders).
WorkPackage: Fix fixme
Tue, May 7, 9:58 AM
danders committed R1026:3648ae9a4213: WorkPackage: Fix missing contextmenu in list view (authored by danders).
WorkPackage: Fix missing contextmenu in list view
Tue, May 7, 9:58 AM
danders committed R1026:e4c6f6557799: WorkPackage:CompletionDialog: Fix update of progress entries (authored by danders).
WorkPackage:CompletionDialog: Fix update of progress entries
Tue, May 7, 9:58 AM

Wed, May 1

danders committed R1026:8bf2c262fe96: Use "Per Resource" as default edit mode in the progress dialog (authored by danders).
Use "Per Resource" as default edit mode in the progress dialog
Wed, May 1, 10:19 AM
danders committed R1026:e95d48942f00: WorkPackage: Set component data properly (authored by danders).
WorkPackage: Set component data properly
Wed, May 1, 10:19 AM
danders committed R1026:71a3416624c3: WorkPackage: Improve package sending ui (authored by danders).
WorkPackage: Improve package sending ui
Wed, May 1, 10:19 AM
danders committed R1026:6b93579249a5: WorkPackage: debug (authored by danders).
WorkPackage: debug
Wed, May 1, 10:19 AM
danders committed R1026:3ac732c4b4ba: Report workpackage progress by default (authored by danders).
Report workpackage progress by default
Wed, May 1, 10:19 AM

Tue, Apr 30

danders committed R1026:5d3944e66074: Fix readonly rc menu name (authored by danders).
Fix readonly rc menu name
Tue, Apr 30, 9:56 AM
danders committed R1026:048fef17cce1: Add dialog to reload assignments of shared resources (authored by danders).
Add dialog to reload assignments of shared resources
Tue, Apr 30, 9:56 AM

Apr 17 2019

danders committed R1026:3151ee23d21c: List unscheduled/scheduling schedules in the selection menu (authored by danders).
List unscheduled/scheduling schedules in the selection menu
Apr 17 2019, 8:43 AM
danders committed R1026:745e9ccdd4c4: GanttView: Add contextmenu -> Show Unscheduled Tasks (authored by danders).
GanttView: Add contextmenu -> Show Unscheduled Tasks
Apr 17 2019, 8:43 AM
danders committed R1026:62ba89e45cfb: Scheduler plugins: emit started/finished signals (authored by danders).
Scheduler plugins: emit started/finished signals
Apr 17 2019, 8:43 AM
danders committed R1026:12b8a859077b: Gantt view: Do not set invalid datetime on dattimegrid, it will crash (authored by danders).
Gantt view: Do not set invalid datetime on dattimegrid, it will crash
Apr 17 2019, 8:43 AM
danders committed R1026:bae235e59b74: Schedule::Log: Declare matatype (authored by danders).
Schedule::Log: Declare matatype
Apr 17 2019, 8:43 AM

Apr 15 2019

danders committed R1026:95884eea0a94: Project: --debug (authored by danders).
Project: --debug
Apr 15 2019, 8:45 AM
danders committed R1026:52bfd09de4fd: NodeItemModel: Fix save/insert for copy/paste and drag/drop (authored by danders).
NodeItemModel: Fix save/insert for copy/paste and drag/drop
Apr 15 2019, 8:45 AM
danders committed R1026:d44f8e1c7ed3: InsertProjectXmlCommand.cpp: Fix/expand unit test (authored by danders).
InsertProjectXmlCommand.cpp: Fix/expand unit test
Apr 15 2019, 8:45 AM
danders committed R1026:3bf651234370: InsertProjectXmlCommand: Insert at posiotion of node, not after (authored by danders).
InsertProjectXmlCommand: Insert at posiotion of node, not after
Apr 15 2019, 8:45 AM
danders committed R1026:6abd8bc9a706: Add save control of relations (authored by danders).
Add save control of relations
Apr 15 2019, 8:45 AM

Apr 13 2019

danders committed R1026:11795b412f76: InsertProjectXmlCommand: Add dependnecies + unit test (authored by danders).
InsertProjectXmlCommand: Add dependnecies + unit test
Apr 13 2019, 11:28 AM

Apr 12 2019

danders committed R1026:fcf546d8deae: Increase xml loading control (authored by danders).
Increase xml loading control
Apr 12 2019, 10:19 AM
danders committed R1026:ed7e58407d92: WIP: Add new command for copy/paste, drag/drop functionallity + unit test (authored by danders).
WIP: Add new command for copy/paste, drag/drop functionallity + unit test
Apr 12 2019, 10:19 AM
danders committed R1026:99396b82eff1: Unsplit all DoubleTreeViewBase based views by default (authored by danders).
Unsplit all DoubleTreeViewBase based views by default
Apr 12 2019, 10:19 AM
danders committed R1026:5e75f682b8a0: DoubleTreeViewBase: In case slaveview is hidden by default, show it if it shall… (authored by danders).
DoubleTreeViewBase: In case slaveview is hidden by default, show it if it shall…
Apr 12 2019, 10:19 AM
danders committed R1026:7b3c710e863d: Allow to drag/drop non-baselined tasks on a baselined project (authored by danders).
Allow to drag/drop non-baselined tasks on a baselined project
Apr 12 2019, 10:19 AM

Apr 9 2019

danders committed R1026:2ac44802c6a7: ResourceEditor: Hide overtime rate by default, it is not implemented (authored by danders).
ResourceEditor: Hide overtime rate by default, it is not implemented
Apr 9 2019, 8:19 AM
danders added a comment to D20400: Karbon: Enable multi page capability.

Ooops, this didn't work as expected. This should have been a revision of D19327.
There is only small changes:

  1. Updated commit message.
  2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools.
  3. In karbon/data/karbon.rc: Removal of the "format" menu (not used) and adding the "format_pagelayout" action to "settings" menu (where it was originally).
Apr 9 2019, 7:05 AM · Calligra: 3.0
danders requested review of D20400: Karbon: Enable multi page capability.
Apr 9 2019, 6:40 AM · Calligra: 3.0

Apr 5 2019

danders committed R1026:3561c34c3654: TaskStatusView: Replace columns statusnote with description (authored by danders).
TaskStatusView: Replace columns statusnote with description
Apr 5 2019, 9:08 AM
danders committed R1026:cc620142e585: Do not use double treeviews as default (authored by danders).
Do not use double treeviews as default
Apr 5 2019, 9:08 AM
danders committed R1026:46b858dd68ed: TaskEditor: Enable Delete action also when *one* task is selected and a… (authored by danders).
TaskEditor: Enable Delete action also when *one* task is selected and a…
Apr 5 2019, 9:07 AM

Apr 3 2019

danders committed R478:00025b7a88a2: Move Q_DECLARE_OPERATORS_FOR_FLAGS out of namespace (authored by danders).
Move Q_DECLARE_OPERATORS_FOR_FLAGS out of namespace
Apr 3 2019, 12:52 PM
danders committed R1026:20c57a6983eb: Fix compile on suse sytems (authored by danders).
Fix compile on suse sytems
Apr 3 2019, 12:45 PM
danders committed R1026:72da632d9409: KF5 4.45 is good enough (authored by danders).
KF5 4.45 is good enough
Apr 3 2019, 12:45 PM

Apr 2 2019

danders committed R1026:d0aaa4fec4ba: TaskEditor: Add copy/paste and copy by drag/drop (authored by danders).
TaskEditor: Add copy/paste and copy by drag/drop
Apr 2 2019, 11:43 AM

Mar 31 2019

danders committed R1026:2e4086255bf8: Revert "Check if plocy 0059 braks CI" (authored by danders).
Revert "Check if plocy 0059 braks CI"
Mar 31 2019, 11:36 AM
danders added a reverting change for R1026:38042a6c71c9: Check if plocy 0059 braks CI: R1026:2e4086255bf8: Revert "Check if plocy 0059 braks CI".
Mar 31 2019, 11:36 AM
danders committed R1026:38042a6c71c9: Check if plocy 0059 braks CI (authored by danders).
Check if plocy 0059 braks CI
Mar 31 2019, 10:59 AM
danders added a reverting change for R1026:25fd5e5c8c48: Check if policy 0026 make CI fail: R1026:4206ee11d336: Revert "Check if policy 0026 make CI fail".
Mar 31 2019, 10:46 AM
danders committed R1026:4206ee11d336: Revert "Check if policy 0026 make CI fail" (authored by danders).
Revert "Check if policy 0026 make CI fail"
Mar 31 2019, 10:46 AM
danders committed R1026:25fd5e5c8c48: Check if policy 0026 make CI fail (authored by danders).
Check if policy 0026 make CI fail
Mar 31 2019, 9:55 AM

Mar 25 2019

danders committed R1026:3232c70c5a9d: D11971: Use same keyword separator for read and write (authored by danders).
D11971: Use same keyword separator for read and write
Mar 25 2019, 2:18 PM
danders committed R8:e52edfd1b50f: D11971: Use same keyword separator for read and write (authored by danders).
D11971: Use same keyword separator for read and write
Mar 25 2019, 1:49 PM
danders closed D11971: Use same keyword separator for read and write.
Mar 25 2019, 1:49 PM · Calligra: 3.0
danders added a comment to D11971: Use same keyword separator for read and write.

Yes, looks sane, I'll deal with it.

Mar 25 2019, 9:08 AM · Calligra: 3.0
danders accepted D19884: Avoid deprecated QAbstractItemModel::reset().

I think this should be ok

Mar 25 2019, 8:58 AM · Calligra: 3.0
danders accepted D19973: MsooXmlCommonRead: protect member for double free.
Mar 25 2019, 8:53 AM · Calligra: 3.0

Mar 22 2019

danders accepted D19941: Avoid deprecated setSupportedDragActions.
Mar 22 2019, 8:14 AM · Calligra: 3.0

Mar 21 2019

danders accepted D19938: Avoid deprecated QRegion::subtract().
Mar 21 2019, 12:22 PM · Calligra: 3.0
danders committed R1026:fb6af1cbcae5: Add drag/drop and copy/paste using text/html and text/plain mimetypes (authored by danders).
Add drag/drop and copy/paste using text/html and text/plain mimetypes
Mar 21 2019, 10:49 AM
danders committed R1026:46a8232b9016: WelcomeView: Do not open project twice on mouseclick (authored by danders).
WelcomeView: Do not open project twice on mouseclick
Mar 21 2019, 10:49 AM

Mar 20 2019

danders added a comment to D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?

That's what I commented on the summary. On some parts rtf-qt uses plain spaces for indentation and those parts look good. Then in the same file other methods might have a hard tab or a hard tab followed by spaces. If you really want, I can try to retain the old whitespace, but it's indentation-wise more or less broken already anyway :) Alternatively could run astyle for the subdirectory, though maybe best done as separate commit.

Yes, sorry, as you say better done separatly.

The directory README also states "Temporary local copy of Brad Hards' rtf-qt library.", though as upstream hasn't had changes since 2011, it seems like a permanent one by now.

Probably.

Mar 20 2019, 12:39 PM · Calligra: 3.0
danders accepted D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?
Otherwise ok.

Mar 20 2019, 11:32 AM · Calligra: 3.0
danders added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 20 2019, 10:57 AM · Calligra: 3.0
danders accepted D19885: Implement logging category for excel plugins.
Mar 20 2019, 10:31 AM · Calligra: 3.0

Mar 15 2019

danders added a reviewer for D19759: Remove unsupported attributes from QGraphicsWidgets: boemann.
Mar 15 2019, 7:56 AM · Calligra: 3.0
danders accepted D19760: Support Qt <5.7 on KoShape flag usage.
Mar 15 2019, 7:43 AM · Calligra: 3.0
danders accepted D19761: Remove obsolete syncX() workaround.
Mar 15 2019, 7:39 AM · Calligra: 3.0

Mar 14 2019

danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

I have applied this patch (it does not apply, so did it manually) along with D19680 and D19685.

I do not see the patches from  D19680 and D19685 in kdiagram master branch
Mar 14 2019, 8:24 AM
danders created T10614: Reimplement Chart::paint() to fix printing issues.
Mar 14 2019, 8:21 AM

Mar 13 2019

danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Just to be sure, you checked printing, generating png and pdf from the DrawInPainter example with D19680 and D19685 applied and didn't noticed any unusual ?

Ok, it works in calligra if stuff is invalidated like in the original:

d->isPlanesLayoutDirty = true;
d->isFloatingLegendsLayoutDirty = true;
invalidateLayoutTree( d->dataAndLegendLayout );
d->dataAndLegendLayout->setGeometry( QRect( QPoint(), rect.size() ) );

I don't know if you need it both before and after painting.

This code was the reason for the initial bug report, because it does not care about header/footer positions (see recent HeaderFooterAdvanced example).

In the opposite calling KChart::setGeometry() covers all geometry, which can be verified with recent HeaderFooterAdvanced example and this patch applied.

With this patch, the DrawInPainter example shows a slightly different behavior with respect to the extension of the diagram. Previously the diagram was adapted to the size of the drawing area by changing the aspect ratio. This patch preserves the original aspect ratio, which can be desired. Maybe you can make this switchable.

Sorry, only checked HeadersFooters which seems to work fine also with invalidating.

Mar 13 2019, 12:39 PM
danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Ok, it works in calligra if stuff is invalidated like in the original:

Mar 13 2019, 10:15 AM
danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Accepting was a bit premature.
I found the problem with my system (qt 5.12 has some changes in drag/drop).
Anyway this does not work in calligra, give me a little time to figure it out.

Mar 13 2019, 8:30 AM

Mar 12 2019

danders accepted D19541: Reimplement Chart::paint() to fix printing issues.

Yup, it was my system acting up, so please commit.

Mar 12 2019, 11:46 AM

Mar 11 2019

danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Hmmm, my system seems very broken atm, so cannot test anything with confidence.
I'll get back to you when I get it sorted.

Mar 11 2019, 12:20 PM
danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Naah, doesn't work with calligra. I think you need scaling also for the widget case.

Mar 11 2019, 10:34 AM
danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

A few points:

  • KChartPrintingParameters::setScaleFactor( ) is needed?
  • Line 1357: Use nullptr
  • Patch dosen't apply for me, git gives no reason so don't know why.
Mar 11 2019, 9:12 AM

Mar 9 2019

danders accepted D19516: Extend advanded headers/footers example with printing support.
Mar 9 2019, 12:18 PM

Mar 7 2019

danders added a comment to D19216: Karbon: Enable multi page capability.
That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.

Heh, I've had the opportunity to work closely with professional infographists so I picked up a thing or two about using applications like Illustrator and InDesign :)

How to indicate a transparent area of an object is yet another subject, with a related but not identical purpose.

That said it might make more sense for this "testing background" to be part of the document and not a general setting - if the use case is as you say then the testing background would also be different for different projects

True. I was reacting to *re*moving a setting completely, not to moving it to a more appropriate context.

Mar 7 2019, 11:32 AM · Calligra: 3.0

Mar 1 2019

danders created T10540: calligraplan fails on suseQt5.10.
Mar 1 2019, 9:10 AM
danders committed R1026:c12f04da3ff4: WelcomeView: Improve keyboard selection of recent file (authored by danders).
WelcomeView: Improve keyboard selection of recent file
Mar 1 2019, 7:47 AM

Feb 28 2019

danders committed R1026:fb9f93270b4d: Update ui file created with qt3 (authored by danders).
Update ui file created with qt3
Feb 28 2019, 10:01 AM
danders committed R1026:c452ef0b1c39: Gantt: Add timeline configuration (authored by danders).
Gantt: Add timeline configuration
Feb 28 2019, 9:33 AM

Feb 27 2019

danders committed R1026:767e39771f75: MainProjectDialog: Fix layout (authored by danders).
MainProjectDialog: Fix layout
Feb 27 2019, 8:47 AM

Feb 26 2019

danders committed R1026:de688b202a12: Fix compile (authored by danders).
Fix compile
Feb 26 2019, 12:27 PM
danders committed R1026:b4d4d12e0706: Add timeline to gantt chart (authored by danders).
Add timeline to gantt chart
Feb 26 2019, 11:03 AM
danders committed R1026:763eaaa41a43: Fix some cmake polizies & add KGantt version check (authored by danders).
Fix some cmake polizies & add KGantt version check
Feb 26 2019, 11:03 AM
danders requested review of D19327: Karbon: Enable multi page capability.
Feb 26 2019, 7:27 AM · Calligra: 3.0

Feb 25 2019

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Can we get a conclussion to this?
@Camilla Have you come up with any more unit tests?

Feb 25 2019, 12:16 PM · Calligra: 3.0
danders added inline comments to D19216: Karbon: Enable multi page capability.
Feb 25 2019, 11:41 AM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.

Canvas color:
I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed.

A custom canvas colour feature doesn't strike me as odd, nor that it isn't printed (printing it WITHOUT setting a dedicated option would seem wrong to me).

What about when you use an inversed theme, isn't a custom canvas colour required then if you want to see your black line art on a light (white) canvas?

No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.

Feb 25 2019, 11:23 AM · Calligra: 3.0

Feb 22 2019

danders added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 2:18 PM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.

This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would just leave all other pages of the document alone).

You should also test with PDF documents; in my experience Karbon 3.1 works well enough with them.

Yes, pdf docs work, it is almost 100% handled by poppler.

...

A lot of code was duplicated between pageapp and karbon
and has been removed from karbon:

Shouldn't that be a separate change - or does multi-page support come automatically with this change?

Well, my initial thought, but there was going to be quite a few intermidiate solutions mainly because
the KoPACanvas cannot be subclassed, so I decided to do everything in one go.

Feb 22 2019, 1:22 PM · Calligra: 3.0