danders (Dag Andersen)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 22 2016, 1:56 PM (126 w, 1 d)
Availability
Available

Recent Activity

Yesterday

danders committed R8:9d7cb140f98e: Q_ENUM is not available in Qt 5.3 (authored by danders).
Q_ENUM is not available in Qt 5.3
Tue, Jan 22, 10:29 AM
danders added a reviewer for D18448: Replaced "distraction free" with "fullscreen" - BUG:378527: boemann.
Tue, Jan 22, 8:54 AM · Calligra: 3.0

Fri, Jan 18

danders committed R1026:37c3de48cd73: Add global macros file (authored by danders).
Add global macros file
Fri, Jan 18, 11:11 AM
danders committed R1026:ccd92c1d7b24: Various clazy fixes, mainly container stuff (authored by danders).
Various clazy fixes, mainly container stuff
Fri, Jan 18, 11:00 AM
danders committed R1026:4e0135372a9c: clazy: QMap -> QHash + temporary container detach (authored by danders).
clazy: QMap -> QHash + temporary container detach
Fri, Jan 18, 11:00 AM

Thu, Jan 17

danders committed R1026:b3a601eef489: Cmake version to 3.0 and set POLICY CMP0071 NEW (authored by danders).
Cmake version to 3.0 and set POLICY CMP0071 NEW
Thu, Jan 17, 11:05 AM
danders committed R1026:ad1851a2d717: Fix comment so it does not confuse moc (authored by danders).
Fix comment so it does not confuse moc
Thu, Jan 17, 11:05 AM
danders committed R1026:c64198dfe695: Bump required version to Qt 5.9 / KF5 5.53 (authored by danders).
Bump required version to Qt 5.9 / KF5 5.53
Thu, Jan 17, 11:05 AM
danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Ran this patch against new unit tests and it fixes all the expected ones, namely those where all cells in first row is merged with cells in second row.
Test results without patch: https://build.kde.org/job/Calligra/job/calligra/job/kf5-qt5%20SUSEQt5.10/lastCompletedBuild/testReport/projectroot.libs.textlayout/tests/libs_kotextlayout_TestTableLayout
See uploaded file for result with patch.

Thu, Jan 17, 6:40 AM · Calligra: 3.0

Wed, Jan 16

danders committed R8:7f40c71e6740: More tables unit tests: Mainly with headers (authored by danders).
More tables unit tests: Mainly with headers
Wed, Jan 16, 10:42 AM
danders committed R8:92c941ac7a83: Add tables unit test: Test row height > root area height (authored by danders).
Add tables unit test: Test row height > root area height
Wed, Jan 16, 10:42 AM
danders added a comment to D18251: Bump required Qt version to 5.9.

I would like to wait with this if there is not a compelling issue like bugs.
Calligra uses this and tries to stay conservative due to some users using old qt.

Wed, Jan 16, 9:11 AM

Tue, Jan 15

danders committed R8:666ae5b484cc: Add new table layout unit tests (authored by danders).
Add new table layout unit tests
Tue, Jan 15, 11:06 AM
danders closed D18095: Add new table layout unit tests.
Tue, Jan 15, 11:06 AM · Calligra: 3.0
danders added a comment to D18095: Add new table layout unit tests.

Even if they do not all pass, I think they should be commited if the tests/methods are ok and the reason for not passing are genuin bugs, no?

Tue, Jan 15, 11:02 AM · Calligra: 3.0
danders committed R8:b490ad8b18d1: OOXml filters: Replace accidentally moved include file (authored by danders).
OOXml filters: Replace accidentally moved include file
Tue, Jan 15, 10:19 AM
danders committed R8:8b7444fd822a: Disable build of sheets tableshape (authored by danders).
Disable build of sheets tableshape
Tue, Jan 15, 9:46 AM

Fri, Jan 11

danders committed R8:c7537de50f13: Fix comment that confuses moc (authored by danders).
Fix comment that confuses moc
Fri, Jan 11, 8:19 AM
danders committed R8:19e961d28073: Set CMP0071 to NEW (moc processes generated files too) (authored by danders).
Set CMP0071 to NEW (moc processes generated files too)
Fri, Jan 11, 8:19 AM
danders committed R8:21912c781578: Add a KoEmbeddedDcoumentLoader class to centralize loading code (authored by danders).
Add a KoEmbeddedDcoumentLoader class to centralize loading code
Fri, Jan 11, 8:19 AM
danders committed R8:f7bc66b2006f: Fix comment that confuses moc (authored by danders).
Fix comment that confuses moc
Fri, Jan 11, 8:19 AM

Thu, Jan 10

danders updated the diff for D18095: Add new table layout unit tests.

Add a test that trigger a loop in the table layout

Thu, Jan 10, 10:16 AM · Calligra: 3.0

Tue, Jan 8

danders added a comment to D18095: Add new table layout unit tests.

No, all do not pass, generally when the first row is merged, layout fails.
(I am trying to provoke problems similar to bug 381341 that we have tried to fix in D15428.)

Tue, Jan 8, 1:51 PM · Calligra: 3.0
danders added a comment to D18095: Add new table layout unit tests.

Not trivial (for me) to get data out of layout so it is hard to create robust tests.
I don't think I have been able to create a test to simulate the loop excactly.
Also, uncertain wether the MockRootAreaProvider is sufficient.
Any ideas/comments wellcome.

Tue, Jan 8, 12:41 PM · Calligra: 3.0
danders requested review of D18095: Add new table layout unit tests.
Tue, Jan 8, 12:37 PM · Calligra: 3.0

Fri, Jan 4

danders accepted D17903: Drop unused dependencies.

Could yo remove lines 178-181 too?

Fri, Jan 4, 7:02 AM
danders accepted D17902: Re-add accidentally removed test for QCA, KF5Wallet is optional.
Fri, Jan 4, 7:00 AM

Dec 20 2018

danders committed R8:d9468823bfe2: Callout: Improve ui (resize/rotate) (authored by danders).
Callout: Improve ui (resize/rotate)
Dec 20 2018, 10:10 AM
danders committed R8:8b947f0498bb: Proper fix for LOs inverted rotate/skew angle and wrong default unit (authored by danders).
Proper fix for LOs inverted rotate/skew angle and wrong default unit
Dec 20 2018, 8:10 AM
danders committed R1026:f7c10594066d: Fix incorrect if statements in dependency editor (authored by danders).
Fix incorrect if statements in dependency editor
Dec 20 2018, 7:49 AM
danders committed R1026:c7c7a53492aa: CalendarEditor: Do not use same name for slots and signals (authored by danders).
CalendarEditor: Do not use same name for slots and signals
Dec 20 2018, 7:49 AM
danders committed R1026:e00e81c195fd: kptviewbase.h: --warning: override *all* (authored by danders).
kptviewbase.h: --warning: override *all*
Dec 20 2018, 7:49 AM
danders committed R1026:d635f12bb856: Move misplaced getter from slot (authored by danders).
Move misplaced getter from slot
Dec 20 2018, 7:49 AM
danders committed R1026:59d8afdb0a9b: Fix unused parameters and normalize connects (authored by danders).
Fix unused parameters and normalize connects
Dec 20 2018, 7:49 AM
danders committed R1026:04f52fec4a65: CalendarEditor: Call ItemViewSettupDialog with correct parameters (authored by danders).
CalendarEditor: Call ItemViewSettupDialog with correct parameters
Dec 20 2018, 7:49 AM
danders committed R1026:71865e0f1110: KoPrintingDialog: Use correct enum in switch (authored by danders).
KoPrintingDialog: Use correct enum in switch
Dec 20 2018, 7:49 AM

Dec 18 2018

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Fidled a little more with this, and found several problems when table with merged cells is split over pages,
like unmerged cell painted on both pages (empty on first page), caret not shown in selected cell and sometimes shown in prev cell.

Dec 18 2018, 8:48 AM · Calligra: 3.0

Dec 17 2018

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

No you misunderstand. I wasn't talking about you diff - I want to know what it is we are trying to accomplish. in spoken words

Dec 17 2018, 11:51 AM · Calligra: 3.0
danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Dan I like your diff better - I don't think it's completely there but it's a better starting point

On a more conceptual level, what should happen if the design of table is such that headers can't fit on a virgin page? What should we do.? One one hand it should be there but on the other hand we will never get to show the real part of the table ever.
What is the solution we should aim for?

Dec 17 2018, 11:32 AM · Calligra: 3.0
danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Yep, it's look like same approach to mine, did you try mine or it's not correct in all cases?

Dec 17 2018, 11:28 AM · Calligra: 3.0
danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

I ended up in the same spot as you:
Since all columns in row 0 spans rows, totalMisFit will always be set to true and the whole table is layed out on next page, and next page again and again ...

Dec 17 2018, 10:43 AM · Calligra: 3.0

Dec 14 2018

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Ok, think I'm on to something.
Testing with the 1.doc in bug 381341. It seems it fails on the table in approx page 222 (open in LO)
with text in 0,0: Экономический субъект
Stepping through the KoTextLayoutTableArea::layoutRow(), it seems *all* columns in row 0 (at least) spans rows and hence (I think) layouting does not work.

Dec 14 2018, 12:34 PM · Calligra: 3.0

Dec 12 2018

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Had a closer look at this. Afaics we get an infinit loop when a table is 'totally misfit',
Can't say I understand the table layout logic, but my assumption is that if a row is a total misfit it can't just be ignored,
so breaking off the row layout loop in this case seems to work:

Dec 12 2018, 2:25 PM · Calligra: 3.0

Dec 9 2018

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Would it be possible to make a unit test?

Dec 9 2018, 3:42 PM · Calligra: 3.0

Nov 19 2018

danders committed R8:af3241cc5e86: Callout: "Fix" rotation of callouts (authored by danders).
Callout: "Fix" rotation of callouts
Nov 19 2018, 11:16 AM
danders committed R8:8e76ed3fcbb0: Pigment: Remove annoying debug (authored by danders).
Pigment: Remove annoying debug
Nov 19 2018, 11:16 AM

Nov 16 2018

danders committed R8:7ace94f9fcba: Words: Add (experimental) test to be run after install (authored by danders).
Words: Add (experimental) test to be run after install
Nov 16 2018, 9:53 AM
danders committed R8:632297be400a: Add a bash script to test installed apps (authored by danders).
Add a bash script to test installed apps
Nov 16 2018, 9:53 AM
danders committed R8:94bbb5e5f77a: Benchmark loading: Give document time to clean up after loading before closing (authored by danders).
Benchmark loading: Give document time to clean up after loading before closing
Nov 16 2018, 9:52 AM
danders committed R8:81e397dff5af: Do not disable tests on BSD (authored by danders).
Do not disable tests on BSD
Nov 16 2018, 9:52 AM

Nov 15 2018

danders committed R478:47b29c22f907: Fix the last QFlags compile warning (authored by danders).
Fix the last QFlags compile warning
Nov 15 2018, 8:47 AM
danders closed D16774: Fix the last QFlags compile warning.
Nov 15 2018, 8:47 AM

Nov 14 2018

danders committed R8:2e1aaae999f3: CalloutShape: Add a new shape to handle callouts (authored by danders).
CalloutShape: Add a new shape to handle callouts
Nov 14 2018, 10:00 AM
danders closed D16756: CalloutShape: Add a new shape to handle callouts.
Nov 14 2018, 10:00 AM · Calligra: 3.0
danders committed R8:00bbdb9c3241: KoPrintingDialog: Use correct enum in switch (authored by danders).
KoPrintingDialog: Use correct enum in switch
Nov 14 2018, 10:00 AM
danders committed R8:eb9adcb39e3e: KoDialog: Move getter out of slots (authored by danders).
KoDialog: Move getter out of slots
Nov 14 2018, 9:59 AM
danders committed R8:557b3062b7c3: Remove mention of plan (authored by danders).
Remove mention of plan
Nov 14 2018, 9:59 AM
danders committed R1026:dce32df387b4: Mark unused parameters (authored by danders).
Mark unused parameters
Nov 14 2018, 8:13 AM
danders committed R499:252db27e5fe1: Fix calligraplan dependencies (authored by danders).
Fix calligraplan dependencies
Nov 14 2018, 7:53 AM
danders committed R1026:f7555a17193c: KoDialog: Move misplaced getter from slots (authored by danders).
KoDialog: Move misplaced getter from slots
Nov 14 2018, 7:39 AM
danders committed R1026:b28cca97ebee: Fix range-loop (authored by danders).
Fix range-loop
Nov 14 2018, 7:39 AM
danders committed R8:b17547e0ef43: KoToolBoxButton: Cleanup include files (authored by danders).
KoToolBoxButton: Cleanup include files
Nov 14 2018, 7:17 AM

Nov 13 2018

danders updated subscribers of T10014: Please enable calligraplan on CI.

No action, so maybe I created this in the wrong way?

Nov 13 2018, 12:18 PM · build.kde.org
danders committed R1026:0537829a9c04: Signals needs full namespace (authored by danders).
Signals needs full namespace
Nov 13 2018, 12:15 PM
danders committed R1026:0ac40a9b2787: Fix clazy-detaching-temporary (authored by danders).
Fix clazy-detaching-temporary
Nov 13 2018, 12:15 PM
danders committed R1026:d95d2b971a3f: Fix incorrect-emit (authored by danders).
Fix incorrect-emit
Nov 13 2018, 12:15 PM
danders committed R1026:f76e3346ffe8: Fix qstring-arg (authored by danders).
Fix qstring-arg
Nov 13 2018, 12:15 PM
danders committed R1026:cc27c7f7594a: Fix qproperty-without-notify (authored by danders).
Fix qproperty-without-notify
Nov 13 2018, 12:15 PM
danders committed R1026:d49cce6f01a1: Fix fully-qualified-moc-types (authored by danders).
Fix fully-qualified-moc-types
Nov 13 2018, 12:15 PM
danders committed R1026:17b30884beda: More clazy-fully-qualified-moc-types (authored by danders).
More clazy-fully-qualified-moc-types
Nov 13 2018, 12:15 PM

Nov 12 2018

danders committed R1026:7e405bc2aee8: Fix clazy-fully-qualified-moc-types (authored by danders).
Fix clazy-fully-qualified-moc-types
Nov 12 2018, 2:09 PM
danders committed R1026:71e87b946695: Q_ENUMS -> Q_ENUM (authored by danders).
Q_ENUMS -> Q_ENUM
Nov 12 2018, 2:09 PM
danders committed R1026:5bd0da556fe7: More kplato -> plan renames (authored by danders).
More kplato -> plan renames
Nov 12 2018, 2:09 PM
danders committed R1026:83266521f5b4: Use direct access to qmap values (first(), firstKey()) (authored by danders).
Use direct access to qmap values (first(), firstKey())
Nov 12 2018, 2:09 PM
danders committed R1026:eedc3da814c2: Nore kplato -> plan renames (authored by danders).
Nore kplato -> plan renames
Nov 12 2018, 2:09 PM

Nov 9 2018

danders created T10014: Please enable calligraplan on CI.
Nov 9 2018, 1:08 PM · build.kde.org
danders committed R499:06c90bb918c3: Move calligraplan from calligra to separate repo (authored by danders).
Move calligraplan from calligra to separate repo
Nov 9 2018, 1:02 PM
danders committed R1026:3f5ca5df6e37: Rename all kplato -> plan (authored by danders).
Rename all kplato -> plan
Nov 9 2018, 1:00 PM
danders committed R1026:0ba3532909cc: Update TODO (authored by danders).
Update TODO
Nov 9 2018, 1:00 PM
danders committed R1026:e9d5810902c1: Remove search unused contacs libs (authored by danders).
Remove search unused contacs libs
Nov 9 2018, 1:00 PM
danders committed R8:fe117b16d8c3: Plan has moved to separate repo (authored by danders).
Plan has moved to separate repo
Nov 9 2018, 11:25 AM
danders requested review of D16774: Fix the last QFlags compile warning.
Nov 9 2018, 9:32 AM
danders committed R1026:cae52c028051: Cleanup CMakeLists.txt after move from calligra (authored by danders).
Cleanup CMakeLists.txt after move from calligra
Nov 9 2018, 7:34 AM

Nov 8 2018

danders requested review of D16756: CalloutShape: Add a new shape to handle callouts.
Nov 8 2018, 11:38 AM · Calligra: 3.0

Nov 7 2018

danders committed R8:9aeb741f9091: ShapeCollection: Use ChartShape_Bar as default quickshape (authored by danders).
ShapeCollection: Use ChartShape_Bar as default quickshape
Nov 7 2018, 11:04 AM
danders committed R8:5fb935f691f6: Sheets: Use ChartShape_Bar as quick shape (authored by danders).
Sheets: Use ChartShape_Bar as quick shape
Nov 7 2018, 11:04 AM
danders committed R8:bbd46212aed0: ShapeCollection: Use new order property to order shapes (authored by danders).
ShapeCollection: Use new order property to order shapes
Nov 7 2018, 11:04 AM
danders committed R8:c65f7e2bebe0: ChartShape: Give charts human names + order properly (authored by danders).
ChartShape: Give charts human names + order properly
Nov 7 2018, 11:04 AM
danders committed R8:8953a58cc192: ShapeCollection: Port away from model reset() + debug (authored by danders).
ShapeCollection: Port away from model reset() + debug
Nov 7 2018, 11:04 AM
danders committed R8:1723d9bbe5f9: Flake: Make it possible to specifically order shapes in the shape selector (authored by danders).
Flake: Make it possible to specifically order shapes in the shape selector
Nov 7 2018, 11:04 AM
danders committed R478:b15db327cb4f: KGantt: Use bitwise NOT for flags (authored by danders).
KGantt: Use bitwise NOT for flags
Nov 7 2018, 8:21 AM
danders committed R478:df1038c9a033: Use nullptr (authored by danders).
Use nullptr
Nov 7 2018, 8:21 AM

Nov 5 2018

danders committed R8:caffa566d8d2: Words: Fix interop problem with LO/OO (authored by danders).
Words: Fix interop problem with LO/OO
Nov 5 2018, 12:05 PM
danders closed D16679: Words: Fix interop problem with LO/OO.
Nov 5 2018, 12:05 PM · Calligra: 3.0
danders requested review of D16679: Words: Fix interop problem with LO/OO.
Nov 5 2018, 11:43 AM · Calligra: 3.0

Nov 1 2018

danders committed R8:e9c3638cea9c: Odf: Filter debug to avoid message overflow (authored by danders).
Odf: Filter debug to avoid message overflow
Nov 1 2018, 1:01 PM
danders committed R8:b3f53b0c21ff: KoTosContainer: Save auto-grow* flags = false to avoid LO resizing shapes (authored by danders).
KoTosContainer: Save auto-grow* flags = false to avoid LO resizing shapes
Nov 1 2018, 1:01 PM
danders committed R8:434ec0ec44eb: Stencils: Fix invalid odf in database.odg (authored by danders).
Stencils: Fix invalid odf in database.odg
Nov 1 2018, 1:01 PM
danders accepted D16545: Fix warnings about nullptr for flags.

Yes, I have patch for nullptr, not pushed yet.

Nov 1 2018, 7:01 AM

Oct 31 2018

danders accepted D16540: KChart: Connect slots explicitly instead of using auto-connections.
Oct 31 2018, 12:05 PM