danders (Dag Andersen)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 22 2016, 1:56 PM (135 w, 20 h)
Availability
Available

Recent Activity

Yesterday

danders committed R1026:3232c70c5a9d: D11971: Use same keyword separator for read and write (authored by danders).
D11971: Use same keyword separator for read and write
Mon, Mar 25, 2:18 PM
danders committed R8:e52edfd1b50f: D11971: Use same keyword separator for read and write (authored by danders).
D11971: Use same keyword separator for read and write
Mon, Mar 25, 1:49 PM
danders closed D11971: Use same keyword separator for read and write.
Mon, Mar 25, 1:49 PM · Calligra: 3.0
danders added a comment to D11971: Use same keyword separator for read and write.

Yes, looks sane, I'll deal with it.

Mon, Mar 25, 9:08 AM · Calligra: 3.0
danders accepted D19884: Avoid deprecated QAbstractItemModel::reset().

I think this should be ok

Mon, Mar 25, 8:58 AM · Calligra: 3.0
danders accepted D19973: MsooXmlCommonRead: protect member for double free.
Mon, Mar 25, 8:53 AM · Calligra: 3.0

Fri, Mar 22

danders accepted D19941: Avoid deprecated setSupportedDragActions.
Fri, Mar 22, 8:14 AM · Calligra: 3.0

Thu, Mar 21

danders accepted D19938: Avoid deprecated QRegion::subtract().
Thu, Mar 21, 12:22 PM · Calligra: 3.0
danders committed R1026:fb6af1cbcae5: Add drag/drop and copy/paste using text/html and text/plain mimetypes (authored by danders).
Add drag/drop and copy/paste using text/html and text/plain mimetypes
Thu, Mar 21, 10:49 AM
danders committed R1026:46a8232b9016: WelcomeView: Do not open project twice on mouseclick (authored by danders).
WelcomeView: Do not open project twice on mouseclick
Thu, Mar 21, 10:49 AM

Wed, Mar 20

danders added a comment to D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?

That's what I commented on the summary. On some parts rtf-qt uses plain spaces for indentation and those parts look good. Then in the same file other methods might have a hard tab or a hard tab followed by spaces. If you really want, I can try to retain the old whitespace, but it's indentation-wise more or less broken already anyway :) Alternatively could run astyle for the subdirectory, though maybe best done as separate commit.

Yes, sorry, as you say better done separatly.

The directory README also states "Temporary local copy of Brad Hards' rtf-qt library.", though as upstream hasn't had changes since 2011, it seems like a permanent one by now.

Probably.

Wed, Mar 20, 12:39 PM · Calligra: 3.0
danders accepted D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?
Otherwise ok.

Wed, Mar 20, 11:32 AM · Calligra: 3.0
danders added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Wed, Mar 20, 10:57 AM · Calligra: 3.0
danders accepted D19885: Implement logging category for excel plugins.
Wed, Mar 20, 10:31 AM · Calligra: 3.0

Fri, Mar 15

danders added a reviewer for D19759: Remove unsupported attributes from QGraphicsWidgets: boemann.
Fri, Mar 15, 7:56 AM · Calligra: 3.0
danders accepted D19760: Support Qt <5.7 on KoShape flag usage.
Fri, Mar 15, 7:43 AM · Calligra: 3.0
danders accepted D19761: Remove obsolete syncX() workaround.
Fri, Mar 15, 7:39 AM · Calligra: 3.0

Thu, Mar 14

danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

I have applied this patch (it does not apply, so did it manually) along with D19680 and D19685.

I do not see the patches from  D19680 and D19685 in kdiagram master branch
Thu, Mar 14, 8:24 AM
danders created T10614: Reimplement Chart::paint() to fix printing issues.
Thu, Mar 14, 8:21 AM

Wed, Mar 13

danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Just to be sure, you checked printing, generating png and pdf from the DrawInPainter example with D19680 and D19685 applied and didn't noticed any unusual ?

Ok, it works in calligra if stuff is invalidated like in the original:

d->isPlanesLayoutDirty = true;
d->isFloatingLegendsLayoutDirty = true;
invalidateLayoutTree( d->dataAndLegendLayout );
d->dataAndLegendLayout->setGeometry( QRect( QPoint(), rect.size() ) );

I don't know if you need it both before and after painting.

This code was the reason for the initial bug report, because it does not care about header/footer positions (see recent HeaderFooterAdvanced example).

In the opposite calling KChart::setGeometry() covers all geometry, which can be verified with recent HeaderFooterAdvanced example and this patch applied.

With this patch, the DrawInPainter example shows a slightly different behavior with respect to the extension of the diagram. Previously the diagram was adapted to the size of the drawing area by changing the aspect ratio. This patch preserves the original aspect ratio, which can be desired. Maybe you can make this switchable.

Sorry, only checked HeadersFooters which seems to work fine also with invalidating.

Wed, Mar 13, 12:39 PM
danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Ok, it works in calligra if stuff is invalidated like in the original:

Wed, Mar 13, 10:15 AM
danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Accepting was a bit premature.
I found the problem with my system (qt 5.12 has some changes in drag/drop).
Anyway this does not work in calligra, give me a little time to figure it out.

Wed, Mar 13, 8:30 AM

Tue, Mar 12

danders accepted D19541: Reimplement Chart::paint() to fix printing issues.

Yup, it was my system acting up, so please commit.

Tue, Mar 12, 11:46 AM

Mon, Mar 11

danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Hmmm, my system seems very broken atm, so cannot test anything with confidence.
I'll get back to you when I get it sorted.

Mon, Mar 11, 12:20 PM
danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

Naah, doesn't work with calligra. I think you need scaling also for the widget case.

Mon, Mar 11, 10:34 AM
danders added a comment to D19541: Reimplement Chart::paint() to fix printing issues.

A few points:

  • KChartPrintingParameters::setScaleFactor( ) is needed?
  • Line 1357: Use nullptr
  • Patch dosen't apply for me, git gives no reason so don't know why.
Mon, Mar 11, 9:12 AM

Sat, Mar 9

danders accepted D19516: Extend advanded headers/footers example with printing support.
Sat, Mar 9, 12:18 PM

Thu, Mar 7

danders added a comment to D19216: Karbon: Enable multi page capability.
That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown.

Heh, I've had the opportunity to work closely with professional infographists so I picked up a thing or two about using applications like Illustrator and InDesign :)

How to indicate a transparent area of an object is yet another subject, with a related but not identical purpose.

That said it might make more sense for this "testing background" to be part of the document and not a general setting - if the use case is as you say then the testing background would also be different for different projects

True. I was reacting to *re*moving a setting completely, not to moving it to a more appropriate context.

Thu, Mar 7, 11:32 AM · Calligra: 3.0

Fri, Mar 1

danders created T10540: calligraplan fails on suseQt5.10.
Fri, Mar 1, 9:10 AM
danders committed R1026:c12f04da3ff4: WelcomeView: Improve keyboard selection of recent file (authored by danders).
WelcomeView: Improve keyboard selection of recent file
Fri, Mar 1, 7:47 AM

Thu, Feb 28

danders committed R1026:fb9f93270b4d: Update ui file created with qt3 (authored by danders).
Update ui file created with qt3
Thu, Feb 28, 10:01 AM
danders committed R1026:c452ef0b1c39: Gantt: Add timeline configuration (authored by danders).
Gantt: Add timeline configuration
Thu, Feb 28, 9:33 AM

Wed, Feb 27

danders committed R1026:767e39771f75: MainProjectDialog: Fix layout (authored by danders).
MainProjectDialog: Fix layout
Wed, Feb 27, 8:47 AM

Tue, Feb 26

danders committed R1026:de688b202a12: Fix compile (authored by danders).
Fix compile
Tue, Feb 26, 12:27 PM
danders committed R1026:b4d4d12e0706: Add timeline to gantt chart (authored by danders).
Add timeline to gantt chart
Tue, Feb 26, 11:03 AM
danders committed R1026:763eaaa41a43: Fix some cmake polizies & add KGantt version check (authored by danders).
Fix some cmake polizies & add KGantt version check
Tue, Feb 26, 11:03 AM
danders requested review of D19327: Karbon: Enable multi page capability.
Tue, Feb 26, 7:27 AM · Calligra: 3.0

Mon, Feb 25

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Can we get a conclussion to this?
@Camilla Have you come up with any more unit tests?

Mon, Feb 25, 12:16 PM · Calligra: 3.0
danders added inline comments to D19216: Karbon: Enable multi page capability.
Mon, Feb 25, 11:41 AM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.

Canvas color:
I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed.

A custom canvas colour feature doesn't strike me as odd, nor that it isn't printed (printing it WITHOUT setting a dedicated option would seem wrong to me).

What about when you use an inversed theme, isn't a custom canvas colour required then if you want to see your black line art on a light (white) canvas?

No, the canvas is part of the document and must never be themed. The canvas background is as much part of your drawing as any line you put on it.

Mon, Feb 25, 11:23 AM · Calligra: 3.0

Feb 22 2019

danders added inline comments to D19216: Karbon: Enable multi page capability.
Feb 22 2019, 2:18 PM · Calligra: 3.0
danders added a comment to D19216: Karbon: Enable multi page capability.

This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would just leave all other pages of the document alone).

You should also test with PDF documents; in my experience Karbon 3.1 works well enough with them.

Yes, pdf docs work, it is almost 100% handled by poppler.

...

A lot of code was duplicated between pageapp and karbon
and has been removed from karbon:

Shouldn't that be a separate change - or does multi-page support come automatically with this change?

Well, my initial thought, but there was going to be quite a few intermidiate solutions mainly because
the KoPACanvas cannot be subclassed, so I decided to do everything in one go.

Feb 22 2019, 1:22 PM · Calligra: 3.0
danders requested review of D19216: Karbon: Enable multi page capability.
Feb 22 2019, 10:00 AM · Calligra: 3.0

Feb 21 2019

danders added a comment to D19132: Update libs/widgets to c++11.

Thanks for the review, I will work next on libs/{pigment,version,widgetutils}.

Hmm, maybe wait with pigment, according to rempt, only krita actually used it.
I haven't looked into it, but if that is the case probably we should dump it.

Feb 21 2019, 11:38 AM · Calligra: 3.0
danders accepted D19132: Update libs/widgets to c++11.

Ok, I can't say I have scrutinized every change, but...
Could you give a heads up when you continue with other parts or else there may be merge problems.
I'm working on karbon and pageapp atm, so please keep off :)

Feb 21 2019, 9:53 AM · Calligra: 3.0

Feb 19 2019

danders added a reviewer for D19132: Update libs/widgets to c++11: leinir.

Hmmm. wasn't it somethng with ms windows and for loops, leinir?
Also, I think there may be detachment issues with them, clazy can tell.
There is a qAsConst() solution but that is not supported in the qt version we need to support.
If there are issues, maybe drop the for loops for now.

Feb 19 2019, 9:55 AM · Calligra: 3.0
danders committed R8:163830f65454: Stage: Add show/hide page margins (authored by danders).
Stage: Add show/hide page margins
Feb 19 2019, 9:46 AM
danders committed R8:a856499212e2: Add show/hide page margins to pageapp (authored by danders).
Add show/hide page margins to pageapp
Feb 19 2019, 9:46 AM

Feb 15 2019

danders committed R8:360ffba5449f: KoModeBox: assert -> Q_ASSERT (authored by danders).
KoModeBox: assert -> Q_ASSERT
Feb 15 2019, 8:22 AM
danders committed R8:3bd65f5e47da: KoPACanvas: Activate touch events (authored by danders).
KoPACanvas: Activate touch events
Feb 15 2019, 7:58 AM

Feb 14 2019

danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Thanks, I'm checking it out now...
Just a couple of things:
Keywords needs to be on a separate line to have effect, see https://community.kde.org/Infrastructure/Git/Hooks
Also FIXED-IN is nice to add.

Feb 14 2019, 10:10 AM · Calligra: 3.0

Feb 13 2019

danders committed R8:6d3af99ae79c: Sheets: Remove cmake automoc warnings (authored by danders).
Sheets: Remove cmake automoc warnings
Feb 13 2019, 9:11 AM
danders committed R8:d11e63457aab: Activate stencils docker in all apps (authored by danders).
Activate stencils docker in all apps
Feb 13 2019, 8:51 AM
danders closed D18843: Activate stencils docker in all apps.
Feb 13 2019, 8:51 AM · Calligra: 3.0
danders added a comment to D18963: Improve KoModeBox display in horizontal Mode.

Please remove trailing whitespace.

Feb 13 2019, 8:41 AM · Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email

Feb 13 2019, 8:22 AM · Calligra: 3.0

Feb 12 2019

danders added a comment to T3689: Add abi compliance checker to CI.

So far I understood abi-dumper is something different - I use abi-complience-checker to create those dumps.

Feb 12 2019, 8:46 AM · build.kde.org
danders committed R8:f3b3a219ea60: Move stencils from karbon to plugins/stencilsdocker (authored by danders).
Move stencils from karbon to plugins/stencilsdocker
Feb 12 2019, 8:18 AM

Feb 11 2019

danders accepted D18866: Use check_symbol_exists instead of check_function_exists.
Feb 11 2019, 9:56 AM · Calligra: 3.0
danders committed R8:9d4a8b32e43d: Words: Fix crash after loading of ott file fails (authored by danders).
Words: Fix crash after loading of ott file fails
Feb 11 2019, 8:33 AM

Feb 9 2019

danders added a comment to D18866: Use check_symbol_exists instead of check_function_exists.

What about the other ​check_function_exists, should they also be changed?
Also, do you know when ​check_symbol_exists was introduced?
We still use cmake 2.8.12.

Feb 9 2019, 10:04 AM · Calligra: 3.0

Feb 8 2019

danders requested review of D18843: Activate stencils docker in all apps.
Feb 8 2019, 9:44 AM · Calligra: 3.0
danders abandoned D18841: StencilBoxDocker: Make the docker collapsed by default.

mistake

Feb 8 2019, 9:28 AM · Calligra: 3.0
danders requested review of D18841: StencilBoxDocker: Make the docker collapsed by default.
Feb 8 2019, 9:24 AM · Calligra: 3.0
danders committed R8:805d3a144ebe: StencilBoxDocker: Do not show by default (authored by danders).
StencilBoxDocker: Do not show by default
Feb 8 2019, 9:17 AM
danders committed R8:de606e8d0c7b: Docker factory: Add a defaultVisiple() method (authored by danders).
Docker factory: Add a defaultVisiple() method
Feb 8 2019, 9:17 AM
danders committed R8:edb0d7aa09b8: KoDockFactoryBase: Make it possible to control default visibility (authored by danders).
KoDockFactoryBase: Make it possible to control default visibility
Feb 8 2019, 9:16 AM

Feb 7 2019

danders committed R8:25b32ea189e2: TestTableLayout: QEXPECT_FAIL a couple of tests and mark with TODO (authored by danders).
TestTableLayout: QEXPECT_FAIL a couple of tests and mark with TODO
Feb 7 2019, 10:10 AM
danders committed R8:5ad30f6133c1: StencilBoxDocker: Forgot to add this file (authored by danders).
StencilBoxDocker: Forgot to add this file
Feb 7 2019, 9:56 AM
danders committed R8:719d731f4ae1: StencilsBoxDocker: Load stencils in separate thread, to not impact app startup… (authored by danders).
StencilsBoxDocker: Load stencils in separate thread, to not impact app startup…
Feb 7 2019, 9:56 AM

Feb 6 2019

danders added a comment to T3689: Add abi compliance checker to CI.

Hmmm. do not know how to proceed with this without the actual libs available.
I have tried building against a new lib and runing with old lib, with no problems.
I was unsuccesful using abi-dumper on the old lib, so cannot check if it gives the same output as for f7f9ca1a7a8bfd550022ca4aafe3bb2985a1bee4 above.
I guess I have to live with this atm and see how things shape up in the furure...

Feb 6 2019, 9:46 AM · build.kde.org

Feb 5 2019

danders committed R478:174860aade1d: KChart: Do not ref private headers in KChart convinience header (authored by danders).
KChart: Do not ref private headers in KChart convinience header
Feb 5 2019, 9:39 AM
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Ok, it's accepted so please commit/push/land

Feb 5 2019, 8:16 AM · Calligra: 3.0
danders committed R8:039b9af91749: ConnectionTool: Fix creation of connections and handle undo (authored by danders).
ConnectionTool: Fix creation of connections and handle undo
Feb 5 2019, 8:03 AM
danders committed R8:501ac762d939: KUndo2Command: Add an addCommand() method to make it possible to create macro… (authored by danders).
KUndo2Command: Add an addCommand() method to make it possible to create macro…
Feb 5 2019, 8:03 AM
danders committed R8:0e4a23e00aca: KoConnectionShape: Do not create a path when all handles point to the same point (authored by danders).
KoConnectionShape: Do not create a path when all handles point to the same point
Feb 5 2019, 8:03 AM

Jan 31 2019

danders accepted D18466: Fixed calligra crashing when opening remote document.

Yes, close.
When export to pdf, the mainwindow is not shown and since we don't exit, the app will hang.
You need to invert the check in KoApplication line 460 so the window is shown.

Jan 31 2019, 10:51 AM · Calligra: 3.0
danders added a comment to T3689: Add abi compliance checker to CI.

I get ABI error on use of QPair and QSet in kdiagram:
https://build.kde.org/job/Calligra/job/kdiagram/job/kf5-qt5%20SUSEQt5.10/8/artifact/compat_reports/KGantt_compat_report.html#Type_Binary_Problems_Medium
Afaics these lines have not been changed since last release.
I have added a public getter to the class, but it does not complain about that, so...
Also it does not complain about similar use in calligra (although not *exactly* the same, calligra uses other datatypes)
Can anybody shed any light on this?

Jan 31 2019, 10:01 AM · build.kde.org
danders committed R478:789c307fe4c3: KGantt: Fix an include (authored by danders).
KGantt: Fix an include
Jan 31 2019, 8:46 AM
danders committed R478:47688decf353: KChart: Do not include private headers and headers of non-exported classes in… (authored by danders).
KChart: Do not include private headers and headers of non-exported classes in…
Jan 31 2019, 8:13 AM

Jan 30 2019

danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Yeah, well there are some half done designs in here :(

Jan 30 2019, 2:02 PM · Calligra: 3.0
danders added a comment to D18466: Fixed calligra crashing when opening remote document.

Regarding the completed slot, the doc says:
--print Only print and exit
--export-pdf Only export to PDF and exit

Jan 30 2019, 12:52 PM · Calligra: 3.0
danders committed R478:ec9659021986: KGantt: Add timeline (authored by danders).
KGantt: Add timeline
Jan 30 2019, 12:17 PM
danders added a reverting change for R478:f7f9ca1a7a8b: KGantt: Add timeline: R478:ba17c7f036aa: Revert "KGantt: Add timeline".
Jan 30 2019, 7:14 AM
danders committed R478:ba17c7f036aa: Revert "KGantt: Add timeline" (authored by danders).
Revert "KGantt: Add timeline"
Jan 30 2019, 7:14 AM

Jan 29 2019

danders committed R478:f7f9ca1a7a8b: KGantt: Add timeline (authored by danders).
KGantt: Add timeline
Jan 29 2019, 11:43 AM

Jan 28 2019

danders added a comment to D15428: [textlayout] Don't enter infinite loop when table is misfit.

Well, unit tests has been added that fails without this patch and passes with this patch.
If there are more test cases needed, please add them so that we can get this patch committed soon...

Jan 28 2019, 12:11 PM · Calligra: 3.0
danders committed R1026:fbfc8854590c: CamelCase (authored by danders).
CamelCase
Jan 28 2019, 10:44 AM
danders committed R1026:542575061eb7: Remove missed test stuff GIT_SILENT (authored by danders).
Remove missed test stuff GIT_SILENT
Jan 28 2019, 10:34 AM
danders committed R1026:08e5b7b3d78f: Split out performance classes from ktptaskstatusview (authored by danders).
Split out performance classes from ktptaskstatusview
Jan 28 2019, 10:31 AM
danders committed R1026:51f7c8dd882c: Some signals needs to be disconnected when object is destroyd (authored by danders).
Some signals needs to be disconnected when object is destroyd
Jan 28 2019, 10:31 AM

Jan 27 2019

danders added a comment to D18466: Fixed calligra crashing when opening remote document.

I'm not sure on how to do that, do you have any tip?
openDocumentInternal is called by openDocument, which is called in KoApplication just before checking the arguments. When it sees the print argument, it calls slotFilePrint. openDocumentInternal downloads the document in async. Should it be made not async, or is there another way to make it wait until the other process ends? Also, "slotLoadCanceled" is already implemented, or were you talking about something else?

Jan 27 2019, 9:13 AM · Calligra: 3.0

Jan 25 2019

danders added a comment to D18466: Fixed calligra crashing when opening remote document.

I think the problem is that slotFilePrint() is called (in KoApplication::start()) before the document is actually loaded.
Probably we need to start printing in a slot connected to KoMainWindow::loadCompleted() instead.
And to be safe, we also need to handle loadCanceled().
And the same for exportToPdf, I think.

Jan 25 2019, 7:17 AM · Calligra: 3.0

Jan 24 2019

danders committed R1026:9c4e47b706e2: Inform cmake/moc about our scheduler plugin macro (authored by danders).
Inform cmake/moc about our scheduler plugin macro
Jan 24 2019, 8:47 AM
danders committed R1026:4fd1f7226741: clazy:exclude=qmap-with-pointer-key (authored by danders).
clazy:exclude=qmap-with-pointer-key
Jan 24 2019, 8:47 AM
danders committed R1026:3b770a173f93: Remove no longer needed hack to hide calligra tools (authored by danders).
Remove no longer needed hack to hide calligra tools
Jan 24 2019, 8:47 AM
danders committed R1026:7b0372b13a6f: With new connect api, we get called by destroyd() signal (authored by danders).
With new connect api, we get called by destroyd() signal
Jan 24 2019, 8:47 AM

Jan 23 2019

danders committed R1026:475249896582: Clean up connects (authored by danders).
Clean up connects
Jan 23 2019, 2:17 PM
danders committed R1026:bda43904ba52: clazy:excludeall=qstring-arg, intentional use of multi arg (authored by danders).
clazy:excludeall=qstring-arg, intentional use of multi arg
Jan 23 2019, 10:12 AM
danders committed R1026:3e2c8a6ed2e7: clazy fizes old-style-connect (authored by danders).
clazy fizes old-style-connect
Jan 23 2019, 10:12 AM