Differential D19911

Convert foreach to for loops
ClosedPublic
Actions

Authored by meven on Mar 20 2019, 10:42 AM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Commits
R318:6dbabdfee650: Convert foreach to for loops
Test Plan

Compile

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Mar 20 2019, 10:42 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptMar 20 2019, 10:42 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.Mar 20 2019, 10:42 AM
ngraham accepted this revision.Mar 20 2019, 3:03 PM
This revision is now accepted and ready to land.Mar 20 2019, 3:03 PM
elvisangelaccio added inline comments.Mar 20 2019, 7:34 PM
src/panels/information/informationpanel.cpp
188–189

This will detach the container. Please put customContextMenuActions() in a const variable first.

elvisangelaccio requested changes to this revision.Mar 20 2019, 7:34 PM
This revision now requires changes to proceed.Mar 20 2019, 7:34 PM
meven updated this revision to Diff 54456.Mar 20 2019, 9:56 PM

Avoid detaching a const

meven marked an inline comment as done.Mar 20 2019, 9:56 PM
elvisangelaccio accepted this revision.Mar 20 2019, 10:05 PM
This revision is now accepted and ready to land.Mar 20 2019, 10:05 PM
meven added a comment.Mar 21 2019, 11:40 AM

For future reference https://www.kdab.com/goodbye-q_foreach/ for why and how to replace foreach

Closed by commit R318:6dbabdfee650: Convert foreach to for loops (authored by meven). · Explain WhyMar 22 2019, 9:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 54541

View Options

src/panels/information/informationpanel.cpp

Loading...