Differential D19969

Add some tests for ExportManager::formatFilename
ClosedPublic
Actions

Authored by davidre on Mar 22 2019, 11:29 AM.

Tags

Subscribers

ngraham, Spectacle

Details

Reviewers

Group Reviewers

Commits

R166:c18c16ee1476: Add some tests for ExportManager::formatFilename

Summary

This adds some tests for formatFilename to ensure that by for example changing placeholders or working on the parsing logic we don't break anything.

Test Plan

Run the tests.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidre created this revision.Mar 22 2019, 11:29 AM

Restricted Application added a project: Spectacle. · View Herald TranscriptMar 22 2019, 11:29 AM

Restricted Application added a subscriber: Spectacle. · View Herald Transcript

davidre requested review of this revision.Mar 22 2019, 11:29 AM

Harbormaster completed remote builds in B9973: Diff 54548.Mar 22 2019, 11:29 AM

davidre added a reviewer: Spectacle.Mar 22 2019, 11:33 AM

Add some more test cases

Harbormaster completed remote builds in B10023: Diff 54635.Mar 23 2019, 7:44 PM

Very nice.

This revision is now accepted and ready to land.Mar 24 2019, 4:07 PM

Closed by commit R166:c18c16ee1476: Add some tests for ExportManager::formatFilename (authored by davidre, committed by ngraham). · Explain WhyMar 24 2019, 4:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (3 lines)
M			src/ExportManager.h (1 line)
M			src/ExportManager.cpp (5 lines)
A	M		tests/CMakeLists.txt (9 lines)
A	M		tests/FilenameTest.cpp (91 lines)

Diff 54684

CMakeLists.txt

Loading...

src/ExportManager.h

Loading...

src/ExportManager.cpp

Loading...

tests/CMakeLists.txt

Loading...

tests/FilenameTest.cpp

Loading...