albertvaka (Albert Vaca Cintora)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 11 2015, 4:03 PM (192 w, 4 d)
Availability
Available

Recent Activity

Mon, May 20

albertvaka committed R225:ea136498b491: Re-generate cert if it's for a different device ID (authored by albertvaka).
Re-generate cert if it's for a different device ID
Mon, May 20, 10:25 PM
albertvaka updated the diff for D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

Rebasing.

Mon, May 20, 10:19 PM
albertvaka committed R225:3087530da560: Coding style. (authored by albertvaka).
Coding style.
Mon, May 20, 10:16 PM

Fri, May 17

albertvaka accepted D21247: [pretty please] allow fetching of cover art in mpris plugin from connected computer.

LGTM

Fri, May 17, 11:38 AM · KDE Connect

Wed, May 8

albertvaka committed R224:5ddaadd47123: More logging and remove redundant check as per CR (authored by albertvaka).
More logging and remove redundant check as per CR
Wed, May 8, 10:04 PM
albertvaka committed R224:8c65f093cbd1: Fix build (authored by albertvaka).
Fix build
Wed, May 8, 10:04 PM
albertvaka committed R224:3fc7df550ba0: Better error handling when loading cert and key (authored by albertvaka).
Better error handling when loading cert and key
Wed, May 8, 10:04 PM
albertvaka committed R225:5f4db1ac164b: Re-generate cert if it's for a different device ID (authored by albertvaka).
Re-generate cert if it's for a different device ID
Wed, May 8, 9:58 PM
albertvaka committed R224:3a2ada53993f: Better error handling when loading cert and key (authored by albertvaka).
Better error handling when loading cert and key
Wed, May 8, 9:15 PM
albertvaka committed R224:d4c716be1f31: More logging and remove redundant check as per CR (authored by albertvaka).
More logging and remove redundant check as per CR
Wed, May 8, 9:11 PM
albertvaka committed R224:760ab3e1bbaf: Fix build (authored by albertvaka).
Fix build
Wed, May 8, 9:11 PM
albertvaka committed R224:09ba6b763182: Better error handling when loading cert and key (authored by albertvaka).
Better error handling when loading cert and key
Wed, May 8, 9:11 PM

Sun, May 5

albertvaka committed R877:8cf027043779: Replaced phonon by qmultimedia (authored by albertvaka).
Replaced phonon by qmultimedia
Sun, May 5, 9:15 PM

Wed, May 1

albertvaka committed R225:2bfd9c645f79: Release 1.12.7 (authored by albertvaka).
Release 1.12.7
Wed, May 1, 12:48 PM
albertvaka committed R224:3eb2f67d3899: Fixme from 2014 is probably not a fixme (authored by albertvaka).
Fixme from 2014 is probably not a fixme
Wed, May 1, 12:46 PM
albertvaka committed R225:87ddf4799949: Upgrade gradle plugin for AS 3.4 (authored by albertvaka).
Upgrade gradle plugin for AS 3.4
Wed, May 1, 12:34 PM

Apr 18 2019

albertvaka committed R225:235e93be5e83: More unclosed stuff found by lgtm.com (authored by albertvaka).
More unclosed stuff found by lgtm.com
Apr 18 2019, 7:07 PM
albertvaka committed R225:aa776739b7fe: Try-with-resources on inputstreams (authored by albertvaka).
Try-with-resources on inputstreams
Apr 18 2019, 7:00 PM
albertvaka committed R225:168b16527c43: Remove compat with protocol 6 with RSA encryption (authored by albertvaka).
Remove compat with protocol 6 with RSA encryption
Apr 18 2019, 5:57 PM

Apr 17 2019

albertvaka committed R225:be85d28d911d: Remove compat with protocol 6 (authored by albertvaka).
Remove compat with protocol 6
Apr 17 2019, 6:25 PM

Apr 15 2019

albertvaka added a reverting change for R224:a19713fbebe7: Remove FileItemActionPlugin: R224:c8b51fb33944: Restore FileItemActionPlugin.
Apr 15 2019, 8:36 PM
albertvaka committed R224:c8b51fb33944: Restore FileItemActionPlugin (authored by albertvaka).
Restore FileItemActionPlugin
Apr 15 2019, 8:36 PM

Mar 29 2019

albertvaka added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

Any update on this? Is it good to merge?

Mar 29 2019, 11:18 PM

Mar 24 2019

albertvaka closed D20015: Add phonon-vlc backend for FindMyDevice plugin (WIn32 port).
Mar 24 2019, 7:21 PM
albertvaka committed R877:a0d8fa3d2ac4: Add phonon-vlc backend for FindMyDevice plugin (WIn32 port) (authored by brute4s99).
Add phonon-vlc backend for FindMyDevice plugin (WIn32 port)
Mar 24 2019, 7:21 PM
albertvaka accepted D20015: Add phonon-vlc backend for FindMyDevice plugin (WIn32 port).

+1

Mar 24 2019, 7:18 PM

Mar 23 2019

albertvaka committed R225:8ff45db1f37a: Bump version to release (authored by albertvaka).
Bump version to release
Mar 23 2019, 8:54 PM

Mar 22 2019

albertvaka committed R224:3dd470137810: Remove mention to SMS from telephony plugin description (authored by albertvaka).
Remove mention to SMS from telephony plugin description
Mar 22 2019, 7:52 AM
albertvaka committed R225:7b6d8a4c357e: Remove mention to SMS from the description (authored by albertvaka).
Remove mention to SMS from the description
Mar 22 2019, 7:40 AM
albertvaka committed R225:ca90b64094b3: Bump version to release (authored by albertvaka).
Bump version to release
Mar 22 2019, 7:40 AM

Mar 21 2019

albertvaka committed R224:b6f61e097fff: fix Ring for Windows port (authored by brute4s99).
fix Ring for Windows port
Mar 21 2019, 10:26 PM
albertvaka committed R225:a8bc4f24c719: Fix crash on old API (authored by albertvaka).
Fix crash on old API
Mar 21 2019, 10:02 PM
albertvaka committed R225:3b82cd44e43c: After unbinding, this will prevent other code from using any view (authored by albertvaka).
After unbinding, this will prevent other code from using any view
Mar 21 2019, 10:02 PM
albertvaka committed R225:7dc023385ef3: Remove directives that aren't needed (authored by albertvaka).
Remove directives that aren't needed
Mar 21 2019, 8:50 AM

Mar 20 2019

albertvaka committed R225:aada931d6a2f: Re-enable SMS plugin now that we know the secrets to approval (authored by albertvaka).
Re-enable SMS plugin now that we know the secrets to approval
Mar 20 2019, 10:48 PM
albertvaka committed R225:a918f0cfe632: Bump version to release (authored by albertvaka).
Bump version to release
Mar 20 2019, 10:48 PM
albertvaka added a reverting change for R225:7799f7e817df: Stop using ClassIndex, it seems to be causing problems: R225:eed77c530ba5: Revert "Stop using ClassIndex, it seems to be causing problems".
Mar 20 2019, 9:37 PM
albertvaka committed R225:eed77c530ba5: Revert "Stop using ClassIndex, it seems to be causing problems" (authored by albertvaka).
Revert "Stop using ClassIndex, it seems to be causing problems"
Mar 20 2019, 9:37 PM
albertvaka committed R225:3b7edf2d2f42: Merge branch 'master' into play-store (authored by albertvaka).
Merge branch 'master' into play-store
Mar 20 2019, 9:36 PM
albertvaka committed R225:37657388c6a9: Uppercasing some stuff (authored by albertvaka).
Uppercasing some stuff
Mar 20 2019, 9:14 PM
albertvaka committed R225:360e4bc1cb9b: Fix ConcurrentModificationException (authored by albertvaka).
Fix ConcurrentModificationException
Mar 20 2019, 9:14 PM
albertvaka committed R225:b689548aa953: Remove private API usage (authored by albertvaka).
Remove private API usage
Mar 20 2019, 9:07 PM
albertvaka committed R225:adac026dfa93: Change RunCommand to runWithPlugin (authored by albertvaka).
Change RunCommand to runWithPlugin
Mar 20 2019, 9:07 PM
albertvaka committed R225:4d38f9753ca8: Disable plugin that breaks on Android 4 (authored by albertvaka).
Disable plugin that breaks on Android 4
Mar 20 2019, 8:47 AM
albertvaka committed R225:18548fb6dfb2: Added missing "unregister" (authored by albertvaka).
Added missing "unregister"
Mar 20 2019, 8:36 AM

Mar 19 2019

albertvaka committed R225:7799f7e817df: Stop using ClassIndex, it seems to be causing problems (authored by albertvaka).
Stop using ClassIndex, it seems to be causing problems
Mar 19 2019, 9:50 PM
albertvaka committed R225:8db8937927a6: Update version to release (to Play Store only) (authored by albertvaka).
Update version to release (to Play Store only)
Mar 19 2019, 8:03 AM
albertvaka committed R225:13e6f2d25011: Emergency update to fix Play Store's policy violation (authored by albertvaka).
Emergency update to fix Play Store's policy violation
Mar 19 2019, 8:03 AM

Mar 18 2019

albertvaka added a comment to D17790: Port away from QCA.

I split the generation from loading, to a separate function and added some error checks if the key can't be loaded, is empty, etc.

Mar 18 2019, 7:41 PM · KDE Connect
albertvaka added a comment to D17790: Port away from QCA.

I changed this code so rebasing this is not trivial now :/

Mar 18 2019, 7:39 PM · KDE Connect

Mar 14 2019

albertvaka committed R224:ad21af639ff4: Assert after waiting and not before (authored by albertvaka).
Assert after waiting and not before
Mar 14 2019, 1:27 PM
albertvaka committed R224:d72e4a1131c4: Fix build on CI for Windows (authored by albertvaka).
Fix build on CI for Windows
Mar 14 2019, 11:39 AM

Mar 8 2019

albertvaka committed R225:e033aad42507: Bump version to release (authored by albertvaka).
Bump version to release
Mar 8 2019, 7:46 PM
albertvaka updated the diff for D16491: Allow shares from desktop to be canceled.

Rebased

Mar 8 2019, 5:37 PM · KDE Connect
albertvaka accepted D16491: Allow shares from desktop to be canceled.

Tested on my OnePlus and it works well.

Mar 8 2019, 5:32 PM · KDE Connect
albertvaka accepted D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Fixes it for the OnePlus 6

Mar 8 2019, 2:00 PM · KDE Connect
albertvaka committed R225:f48b5612c71d: Fragments must be public classes (authored by albertvaka).
Fragments must be public classes
Mar 8 2019, 1:50 PM

Mar 7 2019

albertvaka added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

I've tested it on API 19, API 21, and API 28 and seems to work well.

Mar 7 2019, 8:45 PM · KDE Connect
albertvaka added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Sorry for all this updates to your patch >.< I thought rebasing would be way simpler...

Mar 7 2019, 7:57 PM · KDE Connect
albertvaka updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Updated to new getOptionalPermissionExplanationDialog interface

Mar 7 2019, 7:56 PM · KDE Connect
albertvaka updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Now without conflicts

Mar 7 2019, 7:26 PM · KDE Connect
albertvaka updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Rebased

Mar 7 2019, 7:20 PM · KDE Connect
albertvaka added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

The field shouldn't be editable only clickable what API are you testing on? I'll have a look tomorrow. Signed my contract today so having a little party tonight

Mar 7 2019, 7:18 PM · KDE Connect
albertvaka added a reviewer for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above): albertvaka.
Mar 7 2019, 6:56 PM · KDE Connect
albertvaka added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

This has been stuck for super long, I'm really sorry... testing now.

Mar 7 2019, 6:55 PM · KDE Connect
albertvaka committed R224:0ecf00822b06: Fixed warnings (authored by albertvaka).
Fixed warnings
Mar 7 2019, 6:48 PM
albertvaka added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

Yes, the issue happens on Windows. And I think it always happens, because the line before the one I added reads: "prefix the path with dev-utils/bin"... and Craft's python3.exe is installed right there.

Mar 7 2019, 5:39 PM
albertvaka committed R225:f568c420fa57: Bump version to release (authored by albertvaka).
Bump version to release
Mar 7 2019, 11:48 AM
albertvaka committed R225:0226712ab56d: Upgrade gradle plugin (authored by albertvaka).
Upgrade gradle plugin
Mar 7 2019, 11:19 AM
albertvaka committed R225:e4275d85f63f: Change the plugin description, it doesn't actually take pictures (authored by albertvaka).
Change the plugin description, it doesn't actually take pictures
Mar 7 2019, 11:12 AM
albertvaka added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

I'm not sure this is the good solution, or if something is broken in my setup and I'm the only one experiencing this problem.

Mar 7 2019, 10:08 AM
albertvaka requested review of D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.
Mar 7 2019, 10:06 AM

Mar 4 2019

albertvaka accepted D18142: [Android] Add photo plugin.
Mar 4 2019, 10:41 PM · KDE Connect
albertvaka added inline comments to D18140: Add plugin for taking photos on remote device.
Mar 4 2019, 10:38 PM · KDE Connect
albertvaka accepted D18140: Add plugin for taking photos on remote device.

Let's merge this.

Mar 4 2019, 10:37 PM · KDE Connect

Feb 22 2019

albertvaka added a comment to D18140: Add plugin for taking photos on remote device.

There are plenty of use cases. Using your phone as a scanner is a common one, for example.

macOS already has this feature and people think of plenty of uses for it on that platform.

Feb 22 2019, 8:16 PM · KDE Connect
albertvaka committed R225:ef6c6a6dca1f: Fix crash opening notifications settings (authored by albertvaka).
Fix crash opening notifications settings
Feb 22 2019, 7:08 PM
albertvaka requested changes to D17862: Add Windows support to findthisdevice/Ring plugin.

In the file findthisdevice_config.cpp there is the same defaultSound() function. It needs to be changed there as well or, ideally, use the same function from both files instead of duplicating it.

Feb 22 2019, 6:43 PM · KDE Connect

Feb 20 2019

albertvaka accepted D17976: Fix file opening.
Feb 20 2019, 5:14 PM · KDE Connect

Feb 12 2019

albertvaka committed R224:9d7fe401f8cf: This should do (authored by albertvaka).
This should do
Feb 12 2019, 11:29 PM
albertvaka committed R224:a4241402165f: Trying to fix test for FreeBSD (authored by albertvaka).
Trying to fix test for FreeBSD
Feb 12 2019, 11:22 PM
albertvaka committed R224:10c370cc5154: More useful error text (authored by albertvaka).
More useful error text
Feb 12 2019, 11:13 PM
albertvaka committed R224:695a0e1b6ba8: Make test better (authored by albertvaka).
Make test better
Feb 12 2019, 11:13 PM
albertvaka committed R224:a8e9c0d00275: Make test not crash (authored by albertvaka).
Make test not crash
Feb 12 2019, 11:13 PM
albertvaka committed R224:8142a2c92fcb: Fix wrong size being passed (QString::size -> QFile::size) (authored by albertvaka).
Fix wrong size being passed (QString::size -> QFile::size)
Feb 12 2019, 11:13 PM
albertvaka committed R224:395536b382f0: Remove unused include (authored by albertvaka).
Remove unused include
Feb 12 2019, 11:13 PM
albertvaka committed R224:4d059af839e0: Wait for both client and server sockets (authored by albertvaka).
Wait for both client and server sockets
Feb 12 2019, 11:13 PM
albertvaka committed R225:311c1c73ca79: Trying to make the presentation plugin text more clear (authored by albertvaka).
Trying to make the presentation plugin text more clear
Feb 12 2019, 1:59 PM
albertvaka committed R225:6250b6798571: Notifications plugin now shows as "without permission" instead of "failed" (authored by albertvaka).
Notifications plugin now shows as "without permission" instead of "failed"
Feb 12 2019, 12:23 PM

Feb 11 2019

albertvaka committed R225:b1904a69953b: Fixed all tests (authored by albertvaka).
Fixed all tests
Feb 11 2019, 8:45 PM
albertvaka committed R225:78b38b5a0038: Use ClassIndex to create a list of plugins in compile time (authored by albertvaka).
Use ClassIndex to create a list of plugins in compile time
Feb 11 2019, 7:08 PM
albertvaka committed R225:33c9f70cb53e: build.gradle: Bump dependencies minor versions (authored by albertvaka).
build.gradle: Bump dependencies minor versions
Feb 11 2019, 7:01 PM
albertvaka committed R225:bd23eb924d32: These maps are accessed concurrently, better use a thread-safe container (authored by albertvaka).
These maps are accessed concurrently, better use a thread-safe container
Feb 11 2019, 4:56 PM

Feb 9 2019

albertvaka committed R225:ec66b86dbbb8: Set artist in MediaSession (authored by nicolasfella).
Set artist in MediaSession
Feb 9 2019, 12:08 PM
albertvaka committed R225:b529ab74840c: Removed stale comment from old code (authored by albertvaka).
Removed stale comment from old code
Feb 9 2019, 11:12 AM
albertvaka committed R225:d4286e7f170e: Made setupTcpListener and setupUdpListener more similar (authored by albertvaka).
Made setupTcpListener and setupUdpListener more similar
Feb 9 2019, 11:12 AM

Feb 8 2019

albertvaka committed R225:dca60706a3b6: Remove legacy UDP port support (authored by albertvaka).
Remove legacy UDP port support
Feb 8 2019, 12:06 PM

Jan 25 2019

albertvaka accepted D16071: Use input field from Kaidan.

Approving to unlock this, but if we want to put this in Kirigami so it is shared with other projects someone needs to take the ownership to make it happen. Otherwise it's difficult it gets done.

Jan 25 2019, 12:30 PM · KDE Connect

Jan 21 2019

albertvaka added a comment to D18140: Add plugin for taking photos on remote device.
In D18140#392884, @apol wrote:

Can you elaborate a bit on the use-case?

Jan 21 2019, 3:44 PM · KDE Connect
albertvaka accepted D18354: Simplify notification handling.

LGTM, just two comments.

Jan 21 2019, 3:42 PM · KDE Connect