albertvaka (Albert Vaca Cintora)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 11 2015, 4:03 PM (179 w, 6 d)
Availability
Available

Recent Activity

Wed, Feb 20

albertvaka accepted D17976: Fix file opening.
Wed, Feb 20, 5:14 PM · KDE Connect

Tue, Feb 12

albertvaka committed R224:9d7fe401f8cf: This should do (authored by albertvaka).
This should do
Tue, Feb 12, 11:29 PM
albertvaka committed R224:a4241402165f: Trying to fix test for FreeBSD (authored by albertvaka).
Trying to fix test for FreeBSD
Tue, Feb 12, 11:22 PM
albertvaka committed R224:10c370cc5154: More useful error text (authored by albertvaka).
More useful error text
Tue, Feb 12, 11:13 PM
albertvaka committed R224:695a0e1b6ba8: Make test better (authored by albertvaka).
Make test better
Tue, Feb 12, 11:13 PM
albertvaka committed R224:a8e9c0d00275: Make test not crash (authored by albertvaka).
Make test not crash
Tue, Feb 12, 11:13 PM
albertvaka committed R224:8142a2c92fcb: Fix wrong size being passed (QString::size -> QFile::size) (authored by albertvaka).
Fix wrong size being passed (QString::size -> QFile::size)
Tue, Feb 12, 11:13 PM
albertvaka committed R224:395536b382f0: Remove unused include (authored by albertvaka).
Remove unused include
Tue, Feb 12, 11:13 PM
albertvaka committed R224:4d059af839e0: Wait for both client and server sockets (authored by albertvaka).
Wait for both client and server sockets
Tue, Feb 12, 11:13 PM
albertvaka committed R225:311c1c73ca79: Trying to make the presentation plugin text more clear (authored by albertvaka).
Trying to make the presentation plugin text more clear
Tue, Feb 12, 1:59 PM
albertvaka committed R225:6250b6798571: Notifications plugin now shows as "without permission" instead of "failed" (authored by albertvaka).
Notifications plugin now shows as "without permission" instead of "failed"
Tue, Feb 12, 12:23 PM

Mon, Feb 11

albertvaka committed R225:b1904a69953b: Fixed all tests (authored by albertvaka).
Fixed all tests
Mon, Feb 11, 8:45 PM
albertvaka committed R225:78b38b5a0038: Use ClassIndex to create a list of plugins in compile time (authored by albertvaka).
Use ClassIndex to create a list of plugins in compile time
Mon, Feb 11, 7:08 PM
albertvaka committed R225:33c9f70cb53e: build.gradle: Bump dependencies minor versions (authored by albertvaka).
build.gradle: Bump dependencies minor versions
Mon, Feb 11, 7:01 PM
albertvaka committed R225:bd23eb924d32: These maps are accessed concurrently, better use a thread-safe container (authored by albertvaka).
These maps are accessed concurrently, better use a thread-safe container
Mon, Feb 11, 4:56 PM

Sat, Feb 9

albertvaka committed R225:ec66b86dbbb8: Set artist in MediaSession (authored by nicolasfella).
Set artist in MediaSession
Sat, Feb 9, 12:08 PM
albertvaka committed R225:b529ab74840c: Removed stale comment from old code (authored by albertvaka).
Removed stale comment from old code
Sat, Feb 9, 11:12 AM
albertvaka committed R225:d4286e7f170e: Made setupTcpListener and setupUdpListener more similar (authored by albertvaka).
Made setupTcpListener and setupUdpListener more similar
Sat, Feb 9, 11:12 AM

Fri, Feb 8

albertvaka committed R225:dca60706a3b6: Remove legacy UDP port support (authored by albertvaka).
Remove legacy UDP port support
Fri, Feb 8, 12:06 PM

Fri, Jan 25

albertvaka accepted D16071: Use input field from Kaidan.

Approving to unlock this, but if we want to put this in Kirigami so it is shared with other projects someone needs to take the ownership to make it happen. Otherwise it's difficult it gets done.

Fri, Jan 25, 12:30 PM · KDE Connect

Jan 21 2019

albertvaka added a comment to D18140: Add plugin for taking photos on remote device.
In D18140#392884, @apol wrote:

Can you elaborate a bit on the use-case?

Jan 21 2019, 3:44 PM · KDE Connect
albertvaka accepted D18354: Simplify notification handling.

LGTM, just two comments.

Jan 21 2019, 3:42 PM · KDE Connect

Jan 17 2019

albertvaka accepted D18298: Use androidx version of AlertDialog.

Cool!

Jan 17 2019, 11:26 AM · KDE Connect

Jan 16 2019

albertvaka accepted D18181: Allow disabling persistent notification in Android 8.0 and up.
Jan 16 2019, 1:14 PM · KDE Connect
albertvaka added a comment to D18039: Switch to MaterialComponents theme.

Since this patch, buttons in dialog boxes have no margin on my phone:

Jan 16 2019, 12:48 PM · KDE Connect
albertvaka added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Since the configuration for plugins is quite hidden, I agree with Simon it can be confusing. I have two ideas:

Jan 16 2019, 12:25 PM · KDE Connect
albertvaka accepted D18264: Update for Android Studio 3.3.
Jan 16 2019, 12:07 PM · KDE Connect
albertvaka accepted D18223: Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all.

Makes sense. Probably this was copied-and-pasted from another KIOslave.

Jan 16 2019, 12:05 PM · KDE Connect
albertvaka added a comment to D18217: Allow newer TLS versions.

What is the default protocol when not set explicitly? Does the default allow SslV2 and/or SslV3?
I liked TlsV1_0OrLater better...

Jan 16 2019, 12:01 PM · KDE Connect
albertvaka accepted D18217: Allow newer TLS versions.
Jan 16 2019, 11:56 AM · KDE Connect
albertvaka accepted D18219: [Android] Don't force TLS version.

Have you tested in API < 16? Should still work but :shrug:

Jan 16 2019, 11:52 AM · KDE Connect
albertvaka accepted D17987: Add description of bluetooth multiplexing protocol.

Looks good to me. Something like this could even end up being used for TCP instead of using lots of sockets. Also, the MESSAGE_READ is a good idea: with our current TCP approach, sometimes we create sockets that no one is going to read from and they are leaked.

Jan 16 2019, 11:47 AM · KDE Connect

Jan 7 2019

albertvaka accepted D18039: Switch to MaterialComponents theme.
Jan 7 2019, 8:02 PM · KDE Connect
albertvaka added a comment to D17790: Port away from QCA.
In D17790#387972, @pino wrote:

Please do not use libcrypto/libssl directly:

  • it does not have a stable ABI
  • its API changes often too
  • its license is not exactly nice, imposing extra clauses on what uses it; see https://www.openssl.org/docs/faq.html#LEGAL2 and https://people.gnome.org/~markmc/openssl-and-the-gpl.html (and they will switch soon to Apache 2.0)

    To get to the point of this patch: what is the problem it is trying to solve? The linked bug (402323) just mentions a generic failure, when loading a certificate via QSslCertificate::fromPath() on macOS. Was any debugging done to know why?
Jan 7 2019, 1:18 PM · KDE Connect
albertvaka added a comment to D17790: Port away from QCA.

I'm not sure I'm understanding the conversation. The library is called libssl. It's apparently a little complicated to use, but there is a good StackOverflow example of how it is done: https://stackoverflow.com/questions/256405/programmatically-create-x509-certificate-using-openssl

Jan 7 2019, 10:58 AM · KDE Connect
albertvaka accepted D16553: Cache and delete old ConversationsDbusInterfaces to avoid memory leak.
Jan 7 2019, 10:56 AM · KDE Connect
albertvaka accepted D17627: Simplify receiving multiple files using only 1 notification.
Jan 7 2019, 10:52 AM · KDE Connect

Dec 28 2018

albertvaka added a comment to D17702: [mpriscontrol] add primitive windows support.

You have a few merged patches already, so feel free to ask for a developer account if you want to have commit rights to land your own patches :)

Dec 28 2018, 1:17 AM · Windows, KDE Connect

Dec 26 2018

albertvaka added a comment to D17790: Port away from QCA.

Using the command line tool means this is a runtime dependency only. You could run kdeconnect without having openssl installed and it would fail mysteriously.

Dec 26 2018, 2:28 PM · KDE Connect

Dec 25 2018

albertvaka accepted D17788: [cli] Show all reachable devices.
Dec 25 2018, 12:33 AM · KDE Connect
albertvaka accepted D17787: [Reveivenotification] Put notifications into own channel.
Dec 25 2018, 12:32 AM · KDE Connect

Dec 24 2018

albertvaka added a comment to D17786: [Receivenotification] Support long text.

Maybe set empty string as a default? Null ticker might break the bigtext?

Dec 24 2018, 9:54 PM · KDE Connect
albertvaka accepted D17786: [Receivenotification] Support long text.
Dec 24 2018, 9:53 PM · KDE Connect
albertvaka accepted D17776: Don't send our own notifications.
Dec 24 2018, 9:20 PM · KDE Connect
albertvaka accepted D17777: [ReceiveNotifications] Honor silent property.
Dec 24 2018, 9:20 PM · KDE Connect
albertvaka accepted D17779: Drop custom string compare.
Dec 24 2018, 9:19 PM · KDE Connect
albertvaka accepted D17778: Use try-with-resource.
Dec 24 2018, 9:18 PM · KDE Connect

Dec 21 2018

albertvaka committed R224:f4c7e12ea697: [mpriscontrol] add primitive windows support (authored by jambon).
[mpriscontrol] add primitive windows support
Dec 21 2018, 6:24 PM
albertvaka closed D17702: [mpriscontrol] add primitive windows support.
Dec 21 2018, 6:24 PM · Windows, KDE Connect
albertvaka accepted D17702: [mpriscontrol] add primitive windows support.

Looks good to me.

Dec 21 2018, 5:25 PM · Windows, KDE Connect
albertvaka accepted D17644: Allow browsing sdcard when there is an unreadable file in it (eg .android_secure).

Nice job finding these problems!

Dec 21 2018, 10:34 AM · KDE Connect

Dec 12 2018

albertvaka accepted D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching.

I don't like the fact that we block waiting on a packet, but it's better to move this forward anyway. If it becomes a problem we can revise it later.

Dec 12 2018, 2:06 PM · KDE Connect
albertvaka accepted D17521: Add incremental notifications plugin settings database upgrade.
Dec 12 2018, 11:37 AM · KDE Connect

Dec 11 2018

albertvaka committed R877:843f72d51a36: Update openal (authored by albertvaka).
Update openal
Dec 11 2018, 7:58 PM

Dec 7 2018

albertvaka accepted D17407: Add icons to indicator.
Dec 7 2018, 3:58 PM · KDE Connect
albertvaka accepted D17400: Make toast work from a background thread.
Dec 7 2018, 12:24 PM · KDE Connect

Dec 4 2018

albertvaka committed R225:c80a905f1bbc: Allow multi-line, expandable notifications if text doesn't fit (authored by albertvaka).
Allow multi-line, expandable notifications if text doesn't fit
Dec 4 2018, 4:40 PM

Dec 3 2018

albertvaka committed R225:918e62b4291d: Check returned dialogs for null (authored by albertvaka).
Check returned dialogs for null
Dec 3 2018, 6:39 PM

Dec 2 2018

albertvaka committed R225:18cba01f290b: Fix key auth for sftp (authored by albertvaka).
Fix key auth for sftp
Dec 2 2018, 7:04 PM
albertvaka committed R224:d017d5293a8e: Make plugin less verbose (authored by albertvaka).
Make plugin less verbose
Dec 2 2018, 6:26 PM
albertvaka added inline comments to D17235: Handle receiving an empty file.
Dec 2 2018, 5:01 PM · KDE Connect
albertvaka accepted D17235: Handle receiving an empty file.
Dec 2 2018, 5:00 PM · KDE Connect
albertvaka accepted D17271: Use one port more.
Dec 2 2018, 4:57 PM · KDE Connect

Nov 30 2018

albertvaka accepted D17259: Clear currentShareInfo when transfer is complete.
Nov 30 2018, 4:45 PM · KDE Connect

Nov 29 2018

albertvaka accepted D17236: Align NetworkPacket.hasPayload with desktop.
Nov 29 2018, 10:19 PM · KDE Connect
albertvaka accepted D17242: Suppoer sharing text from kdeconnect-cli.
Nov 29 2018, 10:18 PM · KDE Connect
albertvaka added a comment to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

The only thing, but seems hard to fix is: when there is a transfer in progress and I add another file, the job is updated to say "sending N+1 files", but on Android it still says "receiving N files".

On android it will be updated when the next share packet is received (see D17157). I've thought about that but it I don't think there is a way to improve this without a 2-way protocol or introducing a new share packet to update the running transfer info

Nov 29 2018, 10:17 PM · KDE Connect
albertvaka accepted D17157: Receive multiple files using 1 notification.
Nov 29 2018, 8:46 PM · KDE Connect
albertvaka added a comment to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

The only thing, but seems hard to fix is: when there is a transfer in progress and I add another file, the job is updated to say "sending N+1 files", but on Android it still says "receiving N files".

Nov 29 2018, 8:36 PM · KDE Connect
albertvaka accepted D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

I've been playing with this and it works as it should.

Nov 29 2018, 8:35 PM · KDE Connect
albertvaka committed R225:c5961d651487: Bump version code to release (authored by albertvaka).
Bump version code to release
Nov 29 2018, 7:23 PM
albertvaka added inline comments to D17235: Handle receiving an empty file.
Nov 29 2018, 1:52 PM · KDE Connect
albertvaka accepted D17235: Handle receiving an empty file.
Nov 29 2018, 1:45 PM · KDE Connect

Nov 28 2018

albertvaka added a reviewer for D17214: GCI [KDE Connect] Start New Conversation in Messaging App: KDE Connect.
Nov 28 2018, 1:46 PM · KDE Connect
albertvaka accepted D17176: Allow sharing of empty files.
Nov 28 2018, 1:39 PM · KDE Connect
albertvaka accepted D17175: Handle receiving empty file from Android.

Maybe add a comment to the else branch explaining this is for empty files? It's not obvious from the code.

Nov 28 2018, 1:31 PM · KDE Connect
albertvaka added inline comments to D17125: Title (/Header) in Run Command, Remote Input and Multimedia control was "Remote control". This patch fixes the said Title (/Header) to their respective plugin titles..
Nov 28 2018, 1:19 PM · KDE Connect

Nov 26 2018

albertvaka added a comment to D17176: Allow sharing of empty files.

Oh, I just saw the other patch that makes this work. It's not backwards compatible, but we can probably go with that as it's not very common to send 0 byte files.

Nov 26 2018, 5:41 PM · KDE Connect
albertvaka added a comment to D17176: Allow sharing of empty files.

This will not send the file, though...

Nov 26 2018, 5:37 PM · KDE Connect
albertvaka accepted D17036: Updated README.md.

I found something else we could change, but all the changes look good to me. Can you update the diff and I will merge it? See inline.

Nov 26 2018, 11:36 AM · KDE Connect
albertvaka accepted D17166: [clazy] Properly emit signals.
Nov 26 2018, 11:28 AM · KDE Connect
albertvaka accepted D17165: Don't make signals const.
Nov 26 2018, 11:24 AM · KDE Connect

Nov 21 2018

albertvaka added a reviewer for D16951: Resolve merge conflict: KDE Connect.
Nov 21 2018, 8:04 AM · Frameworks

Nov 20 2018

albertvaka committed R224:b9932769c991: Fix env variable on Windows (authored by albertvaka).
Fix env variable on Windows
Nov 20 2018, 8:50 PM
albertvaka accepted D15293: Enable opening on connected device (Android).

You re-added an old version check while rebasing, remove it.

Nov 20 2018, 8:46 PM · KDE Connect
albertvaka committed R225:6ecf443238f7: Only send icons of new notification, not updates (authored by albertvaka).
Only send icons of new notification, not updates
Nov 20 2018, 8:24 PM
albertvaka accepted D16758: A SO_TIMEOUT of 1 second often leads to the socket timing out when transferring large files..

Let's merge this as it seems to fix problems for you guys. I'm not a network expert, but 1 second seemed like plenty of time for a LAN, though :/

Nov 20 2018, 9:58 AM · KDE Connect
albertvaka requested changes to D17036: Updated README.md.

Found some typos and a small change.

Nov 20 2018, 9:27 AM · KDE Connect
albertvaka added a comment to D16936: Added Windows support to systemvolume plugin.

Done Android change here: https://commits.kde.org/kdeconnect-android/df0d02cd0d1f66e738d4072135a0baf657e86c19

Nov 20 2018, 12:15 AM · Windows, KDE Connect
albertvaka committed R224:929fd062f2b6: Added Windows support to systemvolume plugin (authored by jambon).
Added Windows support to systemvolume plugin
Nov 20 2018, 12:15 AM
albertvaka closed D16936: Added Windows support to systemvolume plugin.
Nov 20 2018, 12:15 AM · Windows, KDE Connect
albertvaka committed R225:df0d02cd0d1f: Allow packets that carry both muted and volume (authored by albertvaka).
Allow packets that carry both muted and volume
Nov 20 2018, 12:10 AM

Nov 19 2018

albertvaka added inline comments to D16962: Add mute button with dynamic icon to MPRIS volume control.
Nov 19 2018, 7:22 PM · KDE Connect
albertvaka accepted D16936: Added Windows support to systemvolume plugin.

I have a couple minor comments, but looks good to me. It would be nice to implement a really simple MPRIS plugin for Windows now (even if only sending multimedia key inputs), so this can be used form the Android app :P

Nov 19 2018, 12:09 PM · Windows, KDE Connect
albertvaka accepted D17009: QTcpServer already has a list of pending connections and emits newConnection after calling incomingConnection.
Nov 19 2018, 11:34 AM · KDE Connect
albertvaka added a comment to T10000: Media player control on Windows.

Is this what we want? https://docs.microsoft.com/en-us/uwp/api/windows.media.systemmediatransportcontrols

Nov 19 2018, 10:39 AM · Windows, KDE Connect
albertvaka updated the task description for T10000: Media player control on Windows.
Nov 19 2018, 10:38 AM · Windows, KDE Connect
albertvaka updated the task description for T10000: Media player control on Windows.
Nov 19 2018, 10:37 AM · Windows, KDE Connect
albertvaka added a reviewer for D16935: Align behaviour of the desktop app with the Android app: KDE Connect.
Nov 19 2018, 9:46 AM · KDE Connect

Nov 16 2018

albertvaka requested changes to D16909: Align behaviour of the desktop app with the Android appP.S.It's a GCI task..
Nov 16 2018, 10:36 AM · KDE Connect