- User Since
- Sep 11 2015, 4:03 PM (179 w, 6 d)
Wed, Feb 20
Tue, Feb 12
Mon, Feb 11
Sat, Feb 9
Fri, Feb 8
Fri, Jan 25
Approving to unlock this, but if we want to put this in Kirigami so it is shared with other projects someone needs to take the ownership to make it happen. Otherwise it's difficult it gets done.
Jan 21 2019
LGTM, just two comments.
Jan 17 2019
Jan 16 2019
Since this patch, buttons in dialog boxes have no margin on my phone:
Since the configuration for plugins is quite hidden, I agree with Simon it can be confusing. I have two ideas:
Makes sense. Probably this was copied-and-pasted from another KIOslave.
Have you tested in API < 16? Should still work but :shrug:
Looks good to me. Something like this could even end up being used for TCP instead of using lots of sockets. Also, the MESSAGE_READ is a good idea: with our current TCP approach, sometimes we create sockets that no one is going to read from and they are leaked.
Jan 7 2019
Dec 28 2018
You have a few merged patches already, so feel free to ask for a developer account if you want to have commit rights to land your own patches :)
Dec 26 2018
Using the command line tool means this is a runtime dependency only. You could run kdeconnect without having openssl installed and it would fail mysteriously.
Dec 25 2018
Dec 24 2018
Maybe set empty string as a default? Null ticker might break the bigtext?
Dec 21 2018
Looks good to me.
Nice job finding these problems!
Dec 12 2018
I don't like the fact that we block waiting on a packet, but it's better to move this forward anyway. If it becomes a problem we can revise it later.
Dec 11 2018
Dec 7 2018
Dec 4 2018
Dec 3 2018
Dec 2 2018
Nov 30 2018
Nov 29 2018
The only thing, but seems hard to fix is: when there is a transfer in progress and I add another file, the job is updated to say "sending N+1 files", but on Android it still says "receiving N files".
I've been playing with this and it works as it should.
Nov 28 2018
Maybe add a comment to the else branch explaining this is for empty files? It's not obvious from the code.
Nov 26 2018
Oh, I just saw the other patch that makes this work. It's not backwards compatible, but we can probably go with that as it's not very common to send 0 byte files.
This will not send the file, though...
I found something else we could change, but all the changes look good to me. Can you update the diff and I will merge it? See inline.
Nov 21 2018
Nov 20 2018
You re-added an old version check while rebasing, remove it.
Let's merge this as it seems to fix problems for you guys. I'm not a network expert, but 1 second seemed like plenty of time for a LAN, though :/
Found some typos and a small change.
Done Android change here: https://commits.kde.org/kdeconnect-android/df0d02cd0d1f66e738d4072135a0baf657e86c19
Nov 19 2018
I have a couple minor comments, but looks good to me. It would be nice to implement a really simple MPRIS plugin for Windows now (even if only sending multimedia key inputs), so this can be used form the Android app :P
Is this what we want? https://docs.microsoft.com/en-us/uwp/api/windows.media.systemmediatransportcontrols