albertvaka (Albert Vaca Cintora)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 11 2015, 4:03 PM (200 w, 4 d)
Availability
Available

Recent Activity

Fri, Jul 5

albertvaka added inline comments to D22105: WIP : Fix SFTP Plugin of KIO for Windows.
Fri, Jul 5, 7:57 PM · Frameworks, Dolphin
albertvaka committed R225:f2c0f0222640: Make service name translatable (authored by albertvaka).
Make service name translatable
Fri, Jul 5, 7:55 PM
albertvaka committed R225:044e56184a1b: Bump version to release (authored by albertvaka).
Bump version to release
Fri, Jul 5, 7:41 PM
albertvaka accepted D21658: add snoretoast for win32 builds to knotifs blueprint.

Sure, you've got 2 approvals (3 now).

Fri, Jul 5, 1:01 PM · Craft
albertvaka committed R224:f044384c15d7: fix race condition on tests. (authored by knauss).
fix race condition on tests.
Fri, Jul 5, 12:53 PM

Thu, Jul 4

albertvaka committed R225:98c366ee6a89: Simplify enabling the pointer (authored by albertvaka).
Simplify enabling the pointer
Thu, Jul 4, 11:37 PM
albertvaka committed R224:b8e50e976fa8: Revert "Simplify contains + get value" (authored by albertvaka).
Revert "Simplify contains + get value"
Thu, Jul 4, 10:59 PM
albertvaka added a reverting change for R224:f7e86ed1310a: Simplify contains + get value: R224:b8e50e976fa8: Revert "Simplify contains + get value".
Thu, Jul 4, 10:59 PM
albertvaka committed R224:f7e86ed1310a: Simplify contains + get value (authored by albertvaka).
Simplify contains + get value
Thu, Jul 4, 10:17 PM
albertvaka committed R224:1e9a0f68085b: Add braces (authored by albertvaka).
Add braces
Thu, Jul 4, 10:17 PM
albertvaka committed R225:bfadb84b9f40: Fix potential race condition caused by early unlocking (authored by albertvaka).
Fix potential race condition caused by early unlocking
Thu, Jul 4, 7:01 PM
albertvaka committed R225:7db40ee20ac6: Fix potential race condition (authored by albertvaka).
Fix potential race condition
Thu, Jul 4, 7:01 PM

Wed, Jul 3

albertvaka added inline comments to D22105: WIP : Fix SFTP Plugin of KIO for Windows.
Wed, Jul 3, 6:25 PM · Frameworks, Dolphin

Jun 15 2019

albertvaka committed R225:7e5df06972e2: 1.12.9.1 (authored by albertvaka).
1.12.9.1
Jun 15 2019, 11:12 PM
albertvaka committed R225:1e585595846f: Release 1.12.9 (authored by albertvaka).
Release 1.12.9
Jun 15 2019, 12:01 PM
albertvaka committed R225:503eaa7ca88a: Remove overly-complicated code that isn't working well (authored by albertvaka).
Remove overly-complicated code that isn't working well
Jun 15 2019, 12:01 PM
albertvaka committed R225:46cd99ba85e3: Upgrade gradle plugin for AS 3.4.1 (authored by albertvaka).
Upgrade gradle plugin for AS 3.4.1
Jun 15 2019, 12:01 PM
albertvaka committed R225:a7d6b9a8058d: Fix crash if icon can't be found (authored by albertvaka).
Fix crash if icon can't be found
Jun 15 2019, 12:01 PM
albertvaka added a comment to D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects.

If I understand correctly, the only reason to use KContacts here is so we can use its PhoneNumber type. We could change it to a QString?

Jun 15 2019, 10:49 AM · Frameworks

Jun 14 2019

albertvaka committed R225:906c04ac1a65: Bump version number to release (authored by albertvaka).
Bump version number to release
Jun 14 2019, 6:55 PM

Jun 10 2019

albertvaka added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

Which package is actually broken? python?

Jun 10 2019, 4:12 PM

Jun 9 2019

albertvaka added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Jun 9 2019, 4:24 PM · Frameworks
albertvaka accepted D21657: remove phonon from deps if building for win32.

LGTM

Jun 9 2019, 4:17 PM · Craft
albertvaka accepted D21658: add snoretoast for win32 builds to knotifs blueprint.

LGTM

Jun 9 2019, 4:16 PM · Craft

Jun 8 2019

albertvaka committed R224:b77661764680: Added new indicator icons for dark and clear backgrounds (authored by albertvaka).
Added new indicator icons for dark and clear backgrounds
Jun 8 2019, 11:08 AM

Jun 5 2019

albertvaka committed R224:b6231f121870: Change plugin name (authored by nicolasfella).
Change plugin name
Jun 5 2019, 10:48 PM
albertvaka committed R224:f79a1c1c6d09: [sftp] Fix error message wording (authored by nicolasfella).
[sftp] Fix error message wording
Jun 5 2019, 10:48 PM
albertvaka committed R224:201bb400da75: [sftp] Give better error messages for common errors (authored by nicolasfella).
[sftp] Give better error messages for common errors
Jun 5 2019, 10:48 PM
albertvaka committed R224:989873595945: Use KAboutData to set information about the daemon (authored by heikobecker).
Use KAboutData to set information about the daemon
Jun 5 2019, 10:48 PM
albertvaka committed R224:d1b20be4ec46: [sftp] Improve error reporting (authored by nicolasfella).
[sftp] Improve error reporting
Jun 5 2019, 10:48 PM

May 20 2019

albertvaka committed R225:ea136498b491: Re-generate cert if it's for a different device ID (authored by albertvaka).
Re-generate cert if it's for a different device ID
May 20 2019, 10:25 PM
albertvaka updated the diff for D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

Rebasing.

May 20 2019, 10:19 PM
albertvaka committed R225:3087530da560: Coding style. (authored by albertvaka).
Coding style.
May 20 2019, 10:16 PM

May 17 2019

albertvaka accepted D21247: [pretty please] allow fetching of cover art in mpris plugin from connected computer.

LGTM

May 17 2019, 11:38 AM · KDE Connect

May 8 2019

albertvaka committed R224:5ddaadd47123: More logging and remove redundant check as per CR (authored by albertvaka).
More logging and remove redundant check as per CR
May 8 2019, 10:04 PM
albertvaka committed R224:8c65f093cbd1: Fix build (authored by albertvaka).
Fix build
May 8 2019, 10:04 PM
albertvaka committed R224:3fc7df550ba0: Better error handling when loading cert and key (authored by albertvaka).
Better error handling when loading cert and key
May 8 2019, 10:04 PM
albertvaka committed R225:5f4db1ac164b: Re-generate cert if it's for a different device ID (authored by albertvaka).
Re-generate cert if it's for a different device ID
May 8 2019, 9:58 PM
albertvaka committed R224:3a2ada53993f: Better error handling when loading cert and key (authored by albertvaka).
Better error handling when loading cert and key
May 8 2019, 9:15 PM
albertvaka committed R224:d4c716be1f31: More logging and remove redundant check as per CR (authored by albertvaka).
More logging and remove redundant check as per CR
May 8 2019, 9:11 PM
albertvaka committed R224:760ab3e1bbaf: Fix build (authored by albertvaka).
Fix build
May 8 2019, 9:11 PM
albertvaka committed R224:09ba6b763182: Better error handling when loading cert and key (authored by albertvaka).
Better error handling when loading cert and key
May 8 2019, 9:11 PM

May 5 2019

albertvaka committed R877:8cf027043779: Replaced phonon by qmultimedia (authored by albertvaka).
Replaced phonon by qmultimedia
May 5 2019, 9:15 PM

May 1 2019

albertvaka committed R225:2bfd9c645f79: Release 1.12.7 (authored by albertvaka).
Release 1.12.7
May 1 2019, 12:48 PM
albertvaka committed R224:3eb2f67d3899: Fixme from 2014 is probably not a fixme (authored by albertvaka).
Fixme from 2014 is probably not a fixme
May 1 2019, 12:46 PM
albertvaka committed R225:87ddf4799949: Upgrade gradle plugin for AS 3.4 (authored by albertvaka).
Upgrade gradle plugin for AS 3.4
May 1 2019, 12:34 PM

Apr 18 2019

albertvaka committed R225:235e93be5e83: More unclosed stuff found by lgtm.com (authored by albertvaka).
More unclosed stuff found by lgtm.com
Apr 18 2019, 7:07 PM
albertvaka committed R225:aa776739b7fe: Try-with-resources on inputstreams (authored by albertvaka).
Try-with-resources on inputstreams
Apr 18 2019, 7:00 PM
albertvaka committed R225:168b16527c43: Remove compat with protocol 6 with RSA encryption (authored by albertvaka).
Remove compat with protocol 6 with RSA encryption
Apr 18 2019, 5:57 PM

Apr 17 2019

albertvaka committed R225:be85d28d911d: Remove compat with protocol 6 (authored by albertvaka).
Remove compat with protocol 6
Apr 17 2019, 6:25 PM

Apr 15 2019

albertvaka added a reverting change for R224:a19713fbebe7: Remove FileItemActionPlugin: R224:c8b51fb33944: Restore FileItemActionPlugin.
Apr 15 2019, 8:36 PM
albertvaka committed R224:c8b51fb33944: Restore FileItemActionPlugin (authored by albertvaka).
Restore FileItemActionPlugin
Apr 15 2019, 8:36 PM

Mar 29 2019

albertvaka added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

Any update on this? Is it good to merge?

Mar 29 2019, 11:18 PM

Mar 24 2019

albertvaka closed D20015: Add phonon-vlc backend for FindMyDevice plugin (WIn32 port).
Mar 24 2019, 7:21 PM
albertvaka committed R877:a0d8fa3d2ac4: Add phonon-vlc backend for FindMyDevice plugin (WIn32 port) (authored by brute4s99).
Add phonon-vlc backend for FindMyDevice plugin (WIn32 port)
Mar 24 2019, 7:21 PM
albertvaka accepted D20015: Add phonon-vlc backend for FindMyDevice plugin (WIn32 port).

+1

Mar 24 2019, 7:18 PM

Mar 23 2019

albertvaka committed R225:8ff45db1f37a: Bump version to release (authored by albertvaka).
Bump version to release
Mar 23 2019, 8:54 PM

Mar 22 2019

albertvaka committed R224:3dd470137810: Remove mention to SMS from telephony plugin description (authored by albertvaka).
Remove mention to SMS from telephony plugin description
Mar 22 2019, 7:52 AM
albertvaka committed R225:7b6d8a4c357e: Remove mention to SMS from the description (authored by albertvaka).
Remove mention to SMS from the description
Mar 22 2019, 7:40 AM
albertvaka committed R225:ca90b64094b3: Bump version to release (authored by albertvaka).
Bump version to release
Mar 22 2019, 7:40 AM

Mar 21 2019

albertvaka committed R224:b6f61e097fff: fix Ring for Windows port (authored by brute4s99).
fix Ring for Windows port
Mar 21 2019, 10:26 PM
albertvaka committed R225:a8bc4f24c719: Fix crash on old API (authored by albertvaka).
Fix crash on old API
Mar 21 2019, 10:02 PM
albertvaka committed R225:3b82cd44e43c: After unbinding, this will prevent other code from using any view (authored by albertvaka).
After unbinding, this will prevent other code from using any view
Mar 21 2019, 10:02 PM
albertvaka committed R225:7dc023385ef3: Remove directives that aren't needed (authored by albertvaka).
Remove directives that aren't needed
Mar 21 2019, 8:50 AM

Mar 20 2019

albertvaka committed R225:aada931d6a2f: Re-enable SMS plugin now that we know the secrets to approval (authored by albertvaka).
Re-enable SMS plugin now that we know the secrets to approval
Mar 20 2019, 10:48 PM
albertvaka committed R225:a918f0cfe632: Bump version to release (authored by albertvaka).
Bump version to release
Mar 20 2019, 10:48 PM
albertvaka added a reverting change for R225:7799f7e817df: Stop using ClassIndex, it seems to be causing problems: R225:eed77c530ba5: Revert "Stop using ClassIndex, it seems to be causing problems".
Mar 20 2019, 9:37 PM
albertvaka committed R225:eed77c530ba5: Revert "Stop using ClassIndex, it seems to be causing problems" (authored by albertvaka).
Revert "Stop using ClassIndex, it seems to be causing problems"
Mar 20 2019, 9:37 PM
albertvaka committed R225:3b7edf2d2f42: Merge branch 'master' into play-store (authored by albertvaka).
Merge branch 'master' into play-store
Mar 20 2019, 9:36 PM
albertvaka committed R225:37657388c6a9: Uppercasing some stuff (authored by albertvaka).
Uppercasing some stuff
Mar 20 2019, 9:14 PM
albertvaka committed R225:360e4bc1cb9b: Fix ConcurrentModificationException (authored by albertvaka).
Fix ConcurrentModificationException
Mar 20 2019, 9:14 PM
albertvaka committed R225:b689548aa953: Remove private API usage (authored by albertvaka).
Remove private API usage
Mar 20 2019, 9:07 PM
albertvaka committed R225:adac026dfa93: Change RunCommand to runWithPlugin (authored by albertvaka).
Change RunCommand to runWithPlugin
Mar 20 2019, 9:07 PM
albertvaka committed R225:4d38f9753ca8: Disable plugin that breaks on Android 4 (authored by albertvaka).
Disable plugin that breaks on Android 4
Mar 20 2019, 8:47 AM
albertvaka committed R225:18548fb6dfb2: Added missing "unregister" (authored by albertvaka).
Added missing "unregister"
Mar 20 2019, 8:36 AM

Mar 19 2019

albertvaka committed R225:7799f7e817df: Stop using ClassIndex, it seems to be causing problems (authored by albertvaka).
Stop using ClassIndex, it seems to be causing problems
Mar 19 2019, 9:50 PM
albertvaka committed R225:8db8937927a6: Update version to release (to Play Store only) (authored by albertvaka).
Update version to release (to Play Store only)
Mar 19 2019, 8:03 AM
albertvaka committed R225:13e6f2d25011: Emergency update to fix Play Store's policy violation (authored by albertvaka).
Emergency update to fix Play Store's policy violation
Mar 19 2019, 8:03 AM

Mar 18 2019

albertvaka added a comment to D17790: Port away from QCA.

I split the generation from loading, to a separate function and added some error checks if the key can't be loaded, is empty, etc.

Mar 18 2019, 7:41 PM · KDE Connect
albertvaka added a comment to D17790: Port away from QCA.

I changed this code so rebasing this is not trivial now :/

Mar 18 2019, 7:39 PM · KDE Connect

Mar 14 2019

albertvaka committed R224:ad21af639ff4: Assert after waiting and not before (authored by albertvaka).
Assert after waiting and not before
Mar 14 2019, 1:27 PM
albertvaka committed R224:d72e4a1131c4: Fix build on CI for Windows (authored by albertvaka).
Fix build on CI for Windows
Mar 14 2019, 11:39 AM

Mar 8 2019

albertvaka committed R225:e033aad42507: Bump version to release (authored by albertvaka).
Bump version to release
Mar 8 2019, 7:46 PM
albertvaka updated the diff for D16491: Allow shares from desktop to be canceled.

Rebased

Mar 8 2019, 5:37 PM · KDE Connect
albertvaka accepted D16491: Allow shares from desktop to be canceled.

Tested on my OnePlus and it works well.

Mar 8 2019, 5:32 PM · KDE Connect
albertvaka accepted D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Fixes it for the OnePlus 6

Mar 8 2019, 2:00 PM · KDE Connect
albertvaka committed R225:f48b5612c71d: Fragments must be public classes (authored by albertvaka).
Fragments must be public classes
Mar 8 2019, 1:50 PM

Mar 7 2019

albertvaka added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

I've tested it on API 19, API 21, and API 28 and seems to work well.

Mar 7 2019, 8:45 PM · KDE Connect
albertvaka added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Sorry for all this updates to your patch >.< I thought rebasing would be way simpler...

Mar 7 2019, 7:57 PM · KDE Connect
albertvaka updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Updated to new getOptionalPermissionExplanationDialog interface

Mar 7 2019, 7:56 PM · KDE Connect
albertvaka updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Now without conflicts

Mar 7 2019, 7:26 PM · KDE Connect
albertvaka updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Rebased

Mar 7 2019, 7:20 PM · KDE Connect
albertvaka added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

The field shouldn't be editable only clickable what API are you testing on? I'll have a look tomorrow. Signed my contract today so having a little party tonight

Mar 7 2019, 7:18 PM · KDE Connect
albertvaka added a reviewer for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above): albertvaka.
Mar 7 2019, 6:56 PM · KDE Connect
albertvaka added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

This has been stuck for super long, I'm really sorry... testing now.

Mar 7 2019, 6:55 PM · KDE Connect
albertvaka committed R224:0ecf00822b06: Fixed warnings (authored by albertvaka).
Fixed warnings
Mar 7 2019, 6:48 PM
albertvaka added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

Yes, the issue happens on Windows. And I think it always happens, because the line before the one I added reads: "prefix the path with dev-utils/bin"... and Craft's python3.exe is installed right there.

Mar 7 2019, 5:39 PM
albertvaka committed R225:f568c420fa57: Bump version to release (authored by albertvaka).
Bump version to release
Mar 7 2019, 11:48 AM
albertvaka committed R225:0226712ab56d: Upgrade gradle plugin (authored by albertvaka).
Upgrade gradle plugin
Mar 7 2019, 11:19 AM
albertvaka committed R225:e4275d85f63f: Change the plugin description, it doesn't actually take pictures (authored by albertvaka).
Change the plugin description, it doesn't actually take pictures
Mar 7 2019, 11:12 AM