albertvaka (Albert Vaca Cintora)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 11 2015, 4:03 PM (169 w, 2 d)
Availability
Available

Recent Activity

Fri, Dec 7

albertvaka accepted D17407: Add icons to indicator.
Fri, Dec 7, 3:58 PM · KDE Connect
albertvaka accepted D17400: Make toast work from a background thread.
Fri, Dec 7, 12:24 PM · KDE Connect

Tue, Dec 4

albertvaka committed R225:c80a905f1bbc: Allow multi-line, expandable notifications if text doesn't fit (authored by albertvaka).
Allow multi-line, expandable notifications if text doesn't fit
Tue, Dec 4, 4:40 PM

Mon, Dec 3

albertvaka committed R225:918e62b4291d: Check returned dialogs for null (authored by albertvaka).
Check returned dialogs for null
Mon, Dec 3, 6:39 PM

Sun, Dec 2

albertvaka committed R225:18cba01f290b: Fix key auth for sftp (authored by albertvaka).
Fix key auth for sftp
Sun, Dec 2, 7:04 PM
albertvaka committed R224:d017d5293a8e: Make plugin less verbose (authored by albertvaka).
Make plugin less verbose
Sun, Dec 2, 6:26 PM
albertvaka added inline comments to D17235: Handle receiving an empty file.
Sun, Dec 2, 5:01 PM · KDE Connect
albertvaka accepted D17235: Handle receiving an empty file.
Sun, Dec 2, 5:00 PM · KDE Connect
albertvaka accepted D17271: Use one port more.
Sun, Dec 2, 4:57 PM · KDE Connect

Fri, Nov 30

albertvaka accepted D17259: Clear currentShareInfo when transfer is complete.
Fri, Nov 30, 4:45 PM · KDE Connect

Thu, Nov 29

albertvaka accepted D17236: Align NetworkPacket.hasPayload with desktop.
Thu, Nov 29, 10:19 PM · KDE Connect
albertvaka accepted D17242: Suppoer sharing text from kdeconnect-cli.
Thu, Nov 29, 10:18 PM · KDE Connect
albertvaka added a comment to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

The only thing, but seems hard to fix is: when there is a transfer in progress and I add another file, the job is updated to say "sending N+1 files", but on Android it still says "receiving N files".

On android it will be updated when the next share packet is received (see D17157). I've thought about that but it I don't think there is a way to improve this without a 2-way protocol or introducing a new share packet to update the running transfer info

Thu, Nov 29, 10:17 PM · KDE Connect
albertvaka accepted D17157: Receive multiple files using 1 notification.
Thu, Nov 29, 8:46 PM · KDE Connect
albertvaka added a comment to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

The only thing, but seems hard to fix is: when there is a transfer in progress and I add another file, the job is updated to say "sending N+1 files", but on Android it still says "receiving N files".

Thu, Nov 29, 8:36 PM · KDE Connect
albertvaka accepted D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

I've been playing with this and it works as it should.

Thu, Nov 29, 8:35 PM · KDE Connect
albertvaka committed R225:c5961d651487: Bump version code to release (authored by albertvaka).
Bump version code to release
Thu, Nov 29, 7:23 PM
albertvaka added inline comments to D17235: Handle receiving an empty file.
Thu, Nov 29, 1:52 PM · KDE Connect
albertvaka accepted D17235: Handle receiving an empty file.
Thu, Nov 29, 1:45 PM · KDE Connect

Wed, Nov 28

albertvaka added a reviewer for D17214: GCI [KDE Connect] Start New Conversation in Messaging App: KDE Connect.
Wed, Nov 28, 1:46 PM · KDE Connect
albertvaka accepted D17176: Allow sharing of empty files.
Wed, Nov 28, 1:39 PM · KDE Connect
albertvaka accepted D17175: Handle receiving empty file from Android.

Maybe add a comment to the else branch explaining this is for empty files? It's not obvious from the code.

Wed, Nov 28, 1:31 PM · KDE Connect
albertvaka added inline comments to D17125: Title (/Header) in Run Command, Remote Input and Multimedia control was "Remote control". This patch fixes the said Title (/Header) to their respective plugin titles..
Wed, Nov 28, 1:19 PM · KDE Connect

Mon, Nov 26

albertvaka added a comment to D17176: Allow sharing of empty files.

Oh, I just saw the other patch that makes this work. It's not backwards compatible, but we can probably go with that as it's not very common to send 0 byte files.

Mon, Nov 26, 5:41 PM · KDE Connect
albertvaka added a comment to D17176: Allow sharing of empty files.

This will not send the file, though...

Mon, Nov 26, 5:37 PM · KDE Connect
albertvaka accepted D17036: Updated README.md.

I found something else we could change, but all the changes look good to me. Can you update the diff and I will merge it? See inline.

Mon, Nov 26, 11:36 AM · KDE Connect
albertvaka accepted D17166: [clazy] Properly emit signals.
Mon, Nov 26, 11:28 AM · KDE Connect
albertvaka accepted D17165: Don't make signals const.
Mon, Nov 26, 11:24 AM · KDE Connect

Wed, Nov 21

albertvaka added a reviewer for D16951: Resolve merge conflict: KDE Connect.
Wed, Nov 21, 8:04 AM · Frameworks

Tue, Nov 20

albertvaka committed R224:b9932769c991: Fix env variable on Windows (authored by albertvaka).
Fix env variable on Windows
Tue, Nov 20, 8:50 PM
albertvaka accepted D15293: Enable opening on connected device (Android).

You re-added an old version check while rebasing, remove it.

Tue, Nov 20, 8:46 PM · KDE Connect
albertvaka committed R225:6ecf443238f7: Only send icons of new notification, not updates (authored by albertvaka).
Only send icons of new notification, not updates
Tue, Nov 20, 8:24 PM
albertvaka accepted D16758: A SO_TIMEOUT of 1 second often leads to the socket timing out when transferring large files..

Let's merge this as it seems to fix problems for you guys. I'm not a network expert, but 1 second seemed like plenty of time for a LAN, though :/

Tue, Nov 20, 9:58 AM · KDE Connect
albertvaka requested changes to D17036: Updated README.md.

Found some typos and a small change.

Tue, Nov 20, 9:27 AM · KDE Connect
albertvaka added a comment to D16936: Added Windows support to systemvolume plugin.

Done Android change here: https://commits.kde.org/kdeconnect-android/df0d02cd0d1f66e738d4072135a0baf657e86c19

Tue, Nov 20, 12:15 AM · Windows, KDE Connect
albertvaka committed R224:929fd062f2b6: Added Windows support to systemvolume plugin (authored by jambon).
Added Windows support to systemvolume plugin
Tue, Nov 20, 12:15 AM
albertvaka closed D16936: Added Windows support to systemvolume plugin.
Tue, Nov 20, 12:15 AM · Windows, KDE Connect
albertvaka committed R225:df0d02cd0d1f: Allow packets that carry both muted and volume (authored by albertvaka).
Allow packets that carry both muted and volume
Tue, Nov 20, 12:10 AM

Mon, Nov 19

albertvaka added inline comments to D16962: Add mute button with dynamic icon to MPRIS volume control.
Mon, Nov 19, 7:22 PM · KDE Connect
albertvaka accepted D16936: Added Windows support to systemvolume plugin.

I have a couple minor comments, but looks good to me. It would be nice to implement a really simple MPRIS plugin for Windows now (even if only sending multimedia key inputs), so this can be used form the Android app :P

Mon, Nov 19, 12:09 PM · Windows, KDE Connect
albertvaka accepted D17009: QTcpServer already has a list of pending connections and emits newConnection after calling incomingConnection.
Mon, Nov 19, 11:34 AM · KDE Connect
albertvaka added a comment to T10000: Media player control on Windows.

Is this what we want? https://docs.microsoft.com/en-us/uwp/api/windows.media.systemmediatransportcontrols

Mon, Nov 19, 10:39 AM · Windows, KDE Connect
albertvaka updated the task description for T10000: Media player control on Windows.
Mon, Nov 19, 10:38 AM · Windows, KDE Connect
albertvaka updated the task description for T10000: Media player control on Windows.
Mon, Nov 19, 10:37 AM · Windows, KDE Connect
albertvaka added a reviewer for D16935: Align behaviour of the desktop app with the Android app: KDE Connect.
Mon, Nov 19, 9:46 AM · KDE Connect

Fri, Nov 16

albertvaka requested changes to D16909: Align behaviour of the desktop app with the Android appP.S.It's a GCI task..
Fri, Nov 16, 10:36 AM · KDE Connect
albertvaka added a reviewer for D16909: Align behaviour of the desktop app with the Android appP.S.It's a GCI task.: KDE Connect.
Fri, Nov 16, 10:19 AM · KDE Connect

Nov 9 2018

albertvaka added a comment to D16758: A SO_TIMEOUT of 1 second often leads to the socket timing out when transferring large files..

Strange, shouldn't 1 second be enough?

Nov 9 2018, 10:08 PM · KDE Connect
albertvaka accepted D16778: Test if file was received completely if not delete the partial file.
Nov 9 2018, 10:06 PM · KDE Connect

Nov 8 2018

albertvaka added a comment to D16746: [runcommand] Add windows support.

Merged, but arcanist (the command line tool for Phabricator) gave me some problems because it looks like you cloned the repo from Github. It will work better if you clone it from https://anongit.kde.org/kdeconnect-kde.git

Nov 8 2018, 2:00 PM · Windows, KDE Connect
albertvaka committed R225:7784a66df00b: Fixed untranslatable strings (authored by albertvaka).
Fixed untranslatable strings
Nov 8 2018, 1:55 PM
albertvaka committed R224:f0486e16c9d0: [runcommand] Add windows support (authored by albertvaka).
[runcommand] Add windows support
Nov 8 2018, 1:55 PM
albertvaka closed D16746: [runcommand] Add windows support.
Nov 8 2018, 1:55 PM · Windows, KDE Connect
albertvaka accepted D16746: [runcommand] Add windows support.

Would powershell be a better default, though? I don't think you can do much with cmd, actually.

Nov 8 2018, 1:40 PM · Windows, KDE Connect

Nov 7 2018

albertvaka accepted D16696: Add support for sharing text from plasmoid.
Nov 7 2018, 6:22 PM · KDE Connect
albertvaka committed R225:b29e7eb00052: Need to dynamically register broadcast receiver for ConnectivityManager. (authored by eduisters).
Need to dynamically register broadcast receiver for ConnectivityManager.
Nov 7 2018, 5:45 PM
albertvaka closed D16738: Need to dynamically register broadcast receiver for ConnectivityManager.CONNECTIVITY_ACTION broadcast on API >= 24.
Nov 7 2018, 5:45 PM · KDE Connect
albertvaka accepted D16738: Need to dynamically register broadcast receiver for ConnectivityManager.CONNECTIVITY_ACTION broadcast on API >= 24.

Although, documentation says:
This constant was deprecated in API level 28. Apps should use the more versatile requestNetwork(NetworkRequest, PendingIntent), registerNetworkCallback(NetworkRequest, PendingIntent) or registerDefaultNetworkCallback(ConnectivityManager.NetworkCallback)

Nov 7 2018, 5:07 PM · KDE Connect
albertvaka committed R225:1fa8f3c99d33: Load image with resampling to prevent OOM (authored by eduisters).
Load image with resampling to prevent OOM
Nov 7 2018, 4:53 PM
albertvaka closed D16712: Load image with resampling to prevent OOM.
Nov 7 2018, 4:53 PM · KDE Connect
albertvaka accepted D16712: Load image with resampling to prevent OOM.
Nov 7 2018, 4:40 PM · KDE Connect
albertvaka committed R224:a70c9aad642f: Fix Windows build which I just broke (authored by albertvaka).
Fix Windows build which I just broke
Nov 7 2018, 4:13 PM
albertvaka committed R224:06d4cb580e46: Disable bad cipher suites now that we dropped support for Android<14 (authored by albertvaka).
Disable bad cipher suites now that we dropped support for Android<14
Nov 7 2018, 3:32 PM
albertvaka committed R225:9e1e4796504c: Disable bad cipher suites now that we dropped support for API<14 (authored by albertvaka).
Disable bad cipher suites now that we dropped support for API<14
Nov 7 2018, 3:24 PM
albertvaka requested changes to D16712: Load image with resampling to prevent OOM.
Nov 7 2018, 3:13 PM · KDE Connect
albertvaka added a comment to D13505: T8539 - Create a new flow to manage trusted networks.

Now that we have a settings screen, this would fit there really well there.

Nov 7 2018, 3:10 PM · KDE Connect
albertvaka committed R224:a685a4910e0b: Add detection of the Meta/Super key press (authored by bobli).
Add detection of the Meta/Super key press
Nov 7 2018, 3:06 PM
albertvaka closed D16613: Manifest.permission.READ_EXTERNAL_STORAGE is not needed for API < 16.
Nov 7 2018, 3:06 PM · KDE Connect
albertvaka committed R225:4eecf187c325: Manifest.permission.READ_EXTERNAL_STORAGE is not needed for API < 16 (authored by eduisters).
Manifest.permission.READ_EXTERNAL_STORAGE is not needed for API < 16
Nov 7 2018, 3:06 PM
albertvaka closed D10379: Add detection of the Meta/Super key press.
Nov 7 2018, 3:06 PM · KDE Connect
albertvaka committed R225:8c48df62936a: Add detection of the Meta/Super key press (authored by bobli).
Add detection of the Meta/Super key press
Nov 7 2018, 3:06 PM
albertvaka accepted D16613: Manifest.permission.READ_EXTERNAL_STORAGE is not needed for API < 16.
Nov 7 2018, 3:03 PM · KDE Connect

Nov 6 2018

albertvaka committed R224:ede8f17e151d: Incorrect Q_EMIT syntax (authored by albertvaka).
Incorrect Q_EMIT syntax
Nov 6 2018, 10:30 PM
albertvaka committed R224:73129abbf532: Unused var (authored by albertvaka).
Unused var
Nov 6 2018, 10:30 PM
albertvaka committed R224:80395d4ca6e2: Missing Q_OBJECT macro (authored by albertvaka).
Missing Q_OBJECT macro
Nov 6 2018, 10:30 PM
albertvaka added a reviewer for D16696: Add support for sharing text from plasmoid: KDE Connect.
Nov 6 2018, 8:51 PM · KDE Connect
albertvaka closed D16707: When creating sharePendingIntent use a unique requestCode so a new PendingIntent is created.
Nov 6 2018, 8:50 PM · KDE Connect
albertvaka committed R225:b4853508e045: When creating sharePendingIntent use a unique requestCode so a new… (authored by eduisters).
When creating sharePendingIntent use a unique requestCode so a new…
Nov 6 2018, 8:50 PM
albertvaka accepted D16707: When creating sharePendingIntent use a unique requestCode so a new PendingIntent is created.

Wow, certainly a bug. Thanks!

Nov 6 2018, 3:41 PM · KDE Connect
albertvaka added a comment to D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon.

I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit message.

Is this workaround/fix only needed on neon or is the message wrong?

I think only Neon ships frameworks 5.51

Why would you think that? 5.51 got released almost a month ago.

Nov 6 2018, 3:29 PM · KDE Connect
albertvaka added a comment to D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon.

I'm wondering why this specifically mentions "KDE Neon" both in the title and in the commit message.

Is this workaround/fix only needed on neon or is the message wrong?

Nov 6 2018, 3:15 PM · KDE Connect
albertvaka committed R224:72b3d91539f2: Merge branch '1.3' (authored by albertvaka).
Merge branch '1.3'
Nov 6 2018, 1:30 PM
albertvaka committed R224:14e6ed8d607b: Bump patch version to release (authored by albertvaka).
Bump patch version to release
Nov 6 2018, 1:29 PM
albertvaka committed R224:8388ed0603f0: A QApplication object needs to be instantiated for kio-kdeconnect to work on… (authored by eduisters).
A QApplication object needs to be instantiated for kio-kdeconnect to work on…
Nov 6 2018, 1:27 PM
albertvaka committed R224:560e8638e8dd: A QApplication object needs to be instantiated for kio-kdeconnect to work on… (authored by eduisters).
A QApplication object needs to be instantiated for kio-kdeconnect to work on…
Nov 6 2018, 1:20 PM
albertvaka closed D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon.
Nov 6 2018, 1:20 PM · KDE Connect
albertvaka added a comment to D16189: kio_help: Fix crash in QCoreApplication when accessing help://.

Old apps that didn't have a QApplication are broken by this version of KIO. Definitely a regression to me :/

Nov 6 2018, 11:05 AM · Frameworks
albertvaka accepted D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon.

Let's ship this, but I still think we should see if something can be done on the KIO side to not break old apps.

Nov 6 2018, 10:52 AM · KDE Connect

Nov 5 2018

albertvaka added a comment to D16189: kio_help: Fix crash in QCoreApplication when accessing help://.

As I commented in this similar patch (https://phabricator.kde.org/D16692 ) I think this is a regression that should be fixed in KIO. Opinions?

Nov 5 2018, 11:25 PM · Frameworks
albertvaka requested changes to D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon.

In my opinion this is a regression in KIO and it would be nice to check if it can somehow be fixed there: Upgrading KIO should not break existing apps.

Nov 5 2018, 11:20 PM · KDE Connect
albertvaka committed R7:0597f8adfe5b: Remove redundant setDefault (authored by albertvaka).
Remove redundant setDefault
Nov 5 2018, 1:49 PM
albertvaka added a comment to T8637: [Junior Job] Open on remote device.

Oh, ok 😊

Nov 5 2018, 12:52 PM · Junior Jobs, KDE Connect
albertvaka abandoned D14821: Remove redundant setDefault.

I merged this directly.

Nov 5 2018, 11:43 AM
albertvaka closed T8637: [Junior Job] Open on remote device as Resolved.
Nov 5 2018, 10:41 AM · Junior Jobs, KDE Connect

Nov 4 2018

albertvaka accepted D15294: Add open on remote device (Desktop).
Nov 4 2018, 10:44 AM · KDE Connect

Nov 2 2018

albertvaka committed R225:067739104094: Bumping version again to release (authored by albertvaka).
Bumping version again to release
Nov 2 2018, 12:27 PM
albertvaka committed R225:ef3fd68f7378: This seems to fix SFTP for Android < 8 (authored by albertvaka).
This seems to fix SFTP for Android < 8
Nov 2 2018, 12:27 PM

Oct 31 2018

albertvaka committed R225:58c4dfbdbd3f: Bump version code to release (authored by albertvaka).
Bump version code to release
Oct 31 2018, 2:30 PM
albertvaka committed R225:9d2d0697ff0d: Fix SFTP not working due to proguard removing classes (authored by albertvaka).
Fix SFTP not working due to proguard removing classes
Oct 31 2018, 2:30 PM
albertvaka accepted D16533: Add editorconfig file.

This was the "implicit" style anyway.

Oct 31 2018, 9:57 AM · KDE Connect