- User Since
- Sep 11 2015, 4:03 PM (169 w, 2 d)
Fri, Dec 7
Tue, Dec 4
Mon, Dec 3
Sun, Dec 2
Fri, Nov 30
Thu, Nov 29
The only thing, but seems hard to fix is: when there is a transfer in progress and I add another file, the job is updated to say "sending N+1 files", but on Android it still says "receiving N files".
I've been playing with this and it works as it should.
Wed, Nov 28
Maybe add a comment to the else branch explaining this is for empty files? It's not obvious from the code.
Mon, Nov 26
Oh, I just saw the other patch that makes this work. It's not backwards compatible, but we can probably go with that as it's not very common to send 0 byte files.
This will not send the file, though...
I found something else we could change, but all the changes look good to me. Can you update the diff and I will merge it? See inline.
Wed, Nov 21
Tue, Nov 20
You re-added an old version check while rebasing, remove it.
Let's merge this as it seems to fix problems for you guys. I'm not a network expert, but 1 second seemed like plenty of time for a LAN, though :/
Found some typos and a small change.
Done Android change here: https://commits.kde.org/kdeconnect-android/df0d02cd0d1f66e738d4072135a0baf657e86c19
Mon, Nov 19
I have a couple minor comments, but looks good to me. It would be nice to implement a really simple MPRIS plugin for Windows now (even if only sending multimedia key inputs), so this can be used form the Android app :P
Is this what we want? https://docs.microsoft.com/en-us/uwp/api/windows.media.systemmediatransportcontrols
Fri, Nov 16
Nov 9 2018
Strange, shouldn't 1 second be enough?
Nov 8 2018
Merged, but arcanist (the command line tool for Phabricator) gave me some problems because it looks like you cloned the repo from Github. It will work better if you clone it from https://anongit.kde.org/kdeconnect-kde.git
Would powershell be a better default, though? I don't think you can do much with cmd, actually.
Nov 7 2018
Although, documentation says:
This constant was deprecated in API level 28. Apps should use the more versatile requestNetwork(NetworkRequest, PendingIntent), registerNetworkCallback(NetworkRequest, PendingIntent) or registerDefaultNetworkCallback(ConnectivityManager.NetworkCallback)
Now that we have a settings screen, this would fit there really well there.
Nov 6 2018
Wow, certainly a bug. Thanks!
Old apps that didn't have a QApplication are broken by this version of KIO. Definitely a regression to me :/
Let's ship this, but I still think we should see if something can be done on the KIO side to not break old apps.
Nov 5 2018
As I commented in this similar patch (https://phabricator.kde.org/D16692 ) I think this is a regression that should be fixed in KIO. Opinions?
In my opinion this is a regression in KIO and it would be nice to check if it can somehow be fixed there: Upgrading KIO should not break existing apps.
Oh, ok 😊
I merged this directly.