You're completely right in the sense that for a batch rename files will be in the same folder. However, rename really is just a move operation. The current BatchRenameJob has a hardcoded logic about placeholders and extensions which make it unusable outside of its current scope.

I honestly think the GUI is mostly ready, at least what I wanted to achieve with it: Something that is advanced enough but not over the top with options as there's already tools for that. Will check at some point to finish the items left from the review here. What this needs to be fully implemented is support from KIO for a "proper" batch move operation. I've submitted a patch for that at D27760 but am still waiting for a review.

In that it supports moving them to different directories but as well as moving them with a different name. This operation is to allow also batch renaming of items. See this patch for more details: D14631

Well, this patch is more or less complete but it doesn't make sense to be deployed without batch operations from KIO as it would spawn a job for each file to be renamed.

I spent some time with modifying CopyJob but didn't make much progress and it's too deep into KIO internals - a lot one has to familiarize himself with. Maybe it's best someone who already did work on KIO to add the batch stuff. Once that is done and merged we can resume over here.

#232627 barely makes any difference compared to #000. Marking this as abandoned for now as it's an old revision.

In D14631#499038, @dfaure wrote:

KIO::move (implemented by CopyJob) can move N files to a single destination directory, but they get the same name at that dest.
KIO::moveAs (implemented by CopyJob too) can move/rename a single file to a specific filename at destination.

What you're suggesting is a new job that can move N files to a destination directory (to make this generic it doesn't have to be in-place renames, right?), but you're providing the filename at destination for each file, right?

Before continuing work I'd like to hear some opinions on this.

I'll need to rewrite the BatchRenameJob part which does the batch processing without breaking binary compatibility. Been unusually busy lately between job and uni but I'll start working on this sooner than later.

Looks like a few git conflict markers have made their way in the code.

Perhaps this patch might not be it, but Okular does actually need a "Night Mode" or "Reading Mode" of sorts, in similar fashion to many epub/pdf readers like @filipf suggests.

Agree, something similar is being proposed over at D18384. These dialogs are getting out of hand.

• change option label when on a single screen

Ah, thought you and @nicolasfella meant to change the wording on the "Current Screen" option. Isn't it a bit awkward to have "Full Screen (All monitors)" when there is just one active though? Ideally, "Current Screen" could be changed to "Full Screen" when there is only 1 monitor and left as is when there's more than one.

• Rename action

I am of the opinion that such dialogs are not very user friendly and honestly very much against them. Not commenting on the usefulness of this particular warning, but dolphin has quite a few of these kind of dialogs with the same process: Input something -> Get error -> Restart. Feedback should instead be given inplace.

• Code style fix

Chiming in here as the author of the bug report mentioned in this patch.

@dhaumann It's not about the lines of code but about making the dialog consistent in all the applications in a way that one cannot get it wrong. You can notice that the title, text, icons, confirmation are all different in each of them even though the dialog itself is trivial to implement. Okuar goes the extra step and even inverts the check box action. Even this patch, which is designed after the Dolphin implementation gets the title wrong.

Honestly this multiple tabs stuff is all over the place and IMO it should go into the frameworks as a sort of utility function in order to stay consistent instead of being written at application level. I'm sure everyone involved is familiar with the topic but I'll attach some of the confirmations just in case.

Pinging @chinmoyr as the original author of the BatchRenameJob class.

• convert to namespace from class
• do not show first captured group
• remove help button
• Use d-ptr pattern
• remove show/hide methods and autoshow dialog
• update doc
• KFileItemList -> QList<QUrl>; KFileItem usage was unnecessary
• update doc
• WIP Change BatchRenameJobPrivate class

FWIW: The patch over at D11304 changes the behavior to select the currently existing folder instead of doing nothing.

• remove qdebug include
• remove unnecessary prefixes

• Merge remote-tracking branch 'origin/master' into arcpatch-D11304
• Fix item would not scroll and selection issue

IMO it would be great if this would just rename inline rather than opening a dialog.

There's still some work to do with the actual BatchRenameClass now and the d-pointer pattern. I'll update this in a few days.

The only difference in the process list is that the plasmashell icon becomes smaller. Aren't the charts and process list handled by libksysguard instead of this repository?

There are no side effects from what I can tell.

@anishgiri What is the advantage of using this outlined version of the Konsole icon(which we haven't seen in a light scheme yet) compared to using one of the monochrome icons already available?

Agree with @ndavis with respect to the icon. I would be in favor of using something similar (if not identical) to dialog-scripts. It's monochrome and works with dark and light backgrounds.

Would be great if the "Line spacing" and "Margins" checkboxes were aligned.

FWIW I agree with @mart. Just give it a default value and leave it at that. More configuration doesn't necessarily mean better.

The classical solution to these problems is always a white text with black outline. Works well for both light and dark backgrounds.

@trickyricky26 I think we should stick to whatever conventions the KDE community has. I checked with Dolphin and the arrow goes up for descending and down for ascending, however the VDG makes these calls in the end.

1. Aren't the names in reverse? view-sort-ascending shows a list in descending order
2. In view-sort-descending the items are not even sorted. Not sure how i feel about that.

• create on stack
• upd define
• remove unused import
• use qstringliteral
• remove unused export
• match file name
• remove import prefixes
• remove q_unused on used parameter
• use fwd class declaration
• reserve space for items
• Do not use _p for cpp files
• simplify expressions
• add cpp files w/o _p
• optimize imports

I feel like hosting community projects under the kde.org subdomain would go a long way towards brand recognition(krita.kde.org, kdenlive.kde.org)

• Initialize pointers to nullptr
• Code style fix

Also, thoughts on my previous comments regarding BatchRenameJob?

• coding style fix

The prompt "Do you still want to rename it" feels unnatural/unusual. "Continue?" or "Do you wish to continue?" or something similar might work better. Just a suggestion, I do not have a strong opinion on the matter.

Something that might need a bit of input is BatchRenameJob.

• Remove QtCore/

• fix indent
• remove setlayout call
• Add missing parent parameters
• Remove unnecessary QtCore/ prefix

• use _p notation. Add BatchRenameDialog to installable headers

In D14631#303886, @aacid wrote:

As far as i can see none of these headers get installed so should they all be renamed to _p.h ?

Also if the headers don't get installed how do you use the new classes?

• Code style fixes
• use .insert instead of []
• Indent Q_OBJECT
• use isEmpty instead of len==0
• use aggregate initialization
• protected -> private
• added parent check
• use functions instead of QString fields
• delete itemData
• code format
• FileNameUtils converted to namespace
• remove unnecessary using

Abandoned in favor of D14631

In D10698#257863, @nmel wrote:

It seems like a small tool independent of Dolphin to me.

In D13346#274446, @abetts wrote:
Could we have a button that enables/disables bluetooth instead? We can show the warning message only if it doesn't seem to be working? or for example, if it runs into an error when enabling, "then" show a warning sign?

Thoughts?

I think application-octet-stream or application-x-desktop could be used for this.

Thoughts on it rendering some default icon instead of processing it as text when the .desktop contains no icon?

I just want to chime in with a little observation (sorry if this had been addressed before, the thread is huge).

Works for me as well. One potential issue is that the object is not deleted if the rename operation is cancelled as the flag is not there anymore.

Since this appears to be the main hub for Open/Save dialogs:

They will have to wait a tad more until I take care of a few other things first. By late June I will resume work with all my pending patches.

In D10698#253974, @ngraham wrote:

This is so nice, and getting nicer all the time. Here's an idea for Capture Groups: we could add a little piece of explanatory text to the window to help people make sense of what they're seeing. I just worry that 99% of people who see that tab will have no idea what it does and feel stupid.

More little nitpicks:

• Table view cells are still uselessly selectable. Is this not possible to turn off?
• Let's change the Close button to say "Cancel" to users can be assured that clicking it will leave their files untouched.
• The Insert Token button needs a downward-pointing arrow to indicate that it opens a menu. I know there's a way to get this automatically but I ran't remember what it is right now.
• #ext contains the dot and maybe shouldn't?
  
  Still giving a +1 for moving this into KIO so Gwenview and Krusader can use it too if they'd like.
  
  Again, truly excellent work. You should be very proud of this.

In T8552#139578, @anemeth wrote:

Could we have the same icon zoom slider as in Dolphin?

• Predefined sizes only, no arbitary icon sizes
• No zoom buttons, (optionally) instead a wider slider It is really difficult setting a specific size. It's like putting a thread in a needle.

Rename the "Rename" tab to be "Sequential numbering" or something like that

The issue with this is that there are more tokens now than just "#", so perhaps that could be misleading in a way?

• use a list to keep track of items to be renamed.
• handle update preview on tab change
• Add "Insert token"
• fix check whether file already exists or not
• wrap strings w/ QStringliteral
• show captured groups text
• table column width fits to content
• update labels
• Add help button
• encode new name using KIO::encodeFileName
• make const
• hide "ready to rename" message
• use monospace font for group names
• show status icon when there is an empty filename
• remove empty line

So I stumbled on something as a result of this patch. When navigating the Network(remote:/) path, right clicking an entry's "Show Original" action raises the following error.

In D10698#239369, @ngraham wrote:

Might this patch also fix https://bugs.kde.org/show_bug.cgi?id=392681, or be trivially adjusted to do so?

I don't see why not. Even though this does seem like rather irrelevant functionality for an image viewer. Perhaps it could be useful to the fokls on the Krusader Project ?

Moved the code which finds the child to a separate function + added a test suite for it.

Revert to original state (Uploaded wrong diff via arcanist by using arc diff --update with the wrong differential number)

So this is finally updated with the latest changes and a new test suite for some utility functions and the code which does the macro substitution, find&replace and group capturing.

• Added column headers
• Remove preview button & add automatic preview when content changes.
• Use i18nc
• remove unnecessary comment
• translate table headers
• use KMessageWidget for status update
• focus the edit of the first tab
• code format
• reorganize imports
• removed qdebug import
• reorganized files
• added tests for filenameutils
• update filenameutilstest
• Moved filename utils to a class
• Add tests for rename types
• Added capture groups tests
• rename newnamebuilder to capturegroups
• translate (empty name) string

Everything's alright. Just being a bit busier than usual. On the weekend I will update this with some more thoughts on the matter and a new diff.

In D11324#228467, @elvisangelaccio wrote:

The feature is that you can open a file by typing its name in the url navigator, see e9463ffe2ac11019.

Apologies in advance for the wall of text.

Hi, while I do appreciate the icons I also have a question: Why the use of laptop and projector over of two simple generic screens. Wouldn't that be better for all use cases?

New arc diff.

In D11324#226859, @elvisangelaccio wrote:

I don't understand, this is a feature. Why would we want to remove it? If you want to select the file you can use --select, no?

I'm also not sold on the usefulness of this. Dolphin can already be fully controlled by keyboard only. Ranger also has to have these extensive key bindings since it's not a GUI application so without those you can't really use it.

• Open archive in new tab only when the appropriate setting is selected.