Differential D13332

Don't generate thumbnail for desktop files with custom icon
ClosedPublic
Actions

Authored by broulik on Jun 4 2018, 1:33 PM.

Details

Reviewers
dfaure
Group Reviewers
VDG
Commits
R320:9b27cf15433f: Don't generate thumbnail for desktop files
Summary

Desktop files aren't traditional text files

BUG: 220330

Test Plan


Top is before, bottom is after

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik requested review of this revision.Jun 4 2018, 1:33 PM
broulik created this revision.
emateli added a subscriber: emateli.Jun 4 2018, 1:48 PM

Thoughts on it rendering some default icon instead of processing it as text when the .desktop contains no icon?

broulik added a comment.Jun 4 2018, 2:59 PM

I could also just render no thumbnail at all for desktop files. I thought maybe the user wants to see the text instead, I wouldn't mind doing it either way.

ngraham added a subscriber: ngraham.Jun 4 2018, 3:17 PM

+1 for some sort of default icon instead of a text file preview when there's no icon. Do we currently have anything that would suffice?

emateli added a comment.Jun 4 2018, 3:31 PM

I think application-octet-stream or application-x-desktop could be used for this.

broulik updated this revision to Diff 35609.Jun 5 2018, 11:27 AM
broulik edited the summary of this revision. (Show Details)
  • Bail out for all .desktop files no matter if they have an icon or not
dfaure accepted this revision.Jun 5 2018, 5:40 PM
This revision is now accepted and ready to land.Jun 5 2018, 5:40 PM
Closed by commit R320:9b27cf15433f: Don't generate thumbnail for desktop files (authored by broulik). · Explain WhyJun 6 2018, 7:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mthumbnail/textcreator.cpp (7 lines)

Diff 35666

View Options

thumbnail/textcreator.cpp

Loading...