nmel (Nikita Melnichenko)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 7:40 AM (83 w, 2 d)
Availability
Available

Recent Activity

Today

nmel added a comment to D22891: If an item that is going to be renamed is also going to be hidden by default, then warn the user.

3rd opinion. I agree it should be shown only if the file is actually going to be hidden (Show Hidden is off in settings), otherwise Krusader looks dumb. I agree that users should be able to disable the warning, because for us it may look like an uncommon operation, however some users may work with dot files extensively. This kind of attention to small details make a huge difference in user experience.

Mon, Sep 16, 4:24 AM · Krusader

Yesterday

nmel accepted D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

Works great and the code looks clean and neat! Thanks for working on this.

Sun, Sep 15, 6:36 PM · Krusader
nmel accepted D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

a) Under non-Windows operating systems: The "#ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN" code paths have to work (as they did before this commit), because Q_OS_WIN is not defined there now, nor Q_WS_WIN was defined there previously.
b) Under Windows operating systems is where the behavior has to change (the Q_OS_WIN code paths are aimed to work, because Q_OS_WIN is defined there).

Sun, Sep 15, 6:11 PM · Krusader

Thu, Sep 12

nmel requested changes to D23309: Change the document about helping Krusader, add other ways.

This diff contains combined changes on two separate repositories. Phabricator will have a problem with this kind of change. Please split into two reviews. I'm ok with the content.

Thu, Sep 12, 5:33 AM · Krusader, Documentation
nmel accepted D23885: Update build status icon.
Thu, Sep 12, 5:26 AM · Krusader

Fri, Sep 6

nmel accepted D22932: Remove 'isExiting' logic from closing sequence.

Reviewed and tested (I'm using Plasma) - works good. Thanks for the fix, Alex!

Fri, Sep 6, 6:16 AM · Krusader
nmel accepted D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.

Reviewed and tested - works good. Thanks for the fix, Toni!

Fri, Sep 6, 6:02 AM · Krusader

Tue, Sep 3

nmel requested changes to D23409: In the main page, add a very visible link asking people to help Krusader.

The first screenshot looks better than others, IMO.

Tue, Sep 3, 6:41 AM · Krusader
nmel added a comment to D23574: Erase an old page.

It can be restored from git history in case it's needed. It's your call.

Tue, Sep 3, 6:26 AM · Krusader

Mon, Sep 2

nmel accepted D23574: Erase an old page.

I also have seen it when I tested published changelog files and wanted to remove it. Thanks for bringing my thoughts to live. :)

Mon, Sep 2, 5:46 AM · Krusader
nmel accepted D23606: Provide two keyboard shortcuts in (de-)selection and filter dialogs.

Reviewed and tested - all good! Thanks for the fix, Toni!

Mon, Sep 2, 5:40 AM · Krusader

Sun, Aug 25

nmel committed R938:e6c91441ccae: Updates related to v2.7.2 release (authored by nmel).
Updates related to v2.7.2 release
Sun, Aug 25, 6:51 PM
nmel committed R938:eec4ad729cc3: Published v2.7.2 (authored by nmel).
Published v2.7.2
Sun, Aug 25, 6:51 PM
nmel committed R938:8fd760b7403f: Updated copyright year (authored by nmel).
Updated copyright year
Sun, Aug 25, 6:51 PM
nmel closed D23236: Updates related to v2.7.2 release.
Sun, Aug 25, 6:51 PM · Krusader
nmel committed R167:ae6ef194cf9b: Merged v2.7.2 updates (authored by nmel).
Merged v2.7.2 updates
Sun, Aug 25, 6:43 PM
nmel committed R230:b3d5aa6d5548: createtarball: krusader version bump (v2.7.2) (authored by nmel).
createtarball: krusader version bump (v2.7.2)
Sun, Aug 25, 6:26 PM
nmel updated the diff for D23236: Updates related to v2.7.2 release.
  • updated SHA256 checksum
Sun, Aug 25, 7:03 AM · Krusader
nmel committed R167:f66e9fe20760: Released v2.7.2 (authored by nmel).
Released v2.7.2
Sun, Aug 25, 6:47 AM
nmel committed R167:a05646d16d88: Version bump: 2.7.3-dev (authored by nmel).
Version bump: 2.7.3-dev
Sun, Aug 25, 6:47 AM
nmel closed D23235: Released v2.7.2.
Sun, Aug 25, 6:47 AM · Krusader

Thu, Aug 22

nmel added a comment to D23309: Change the document about helping Krusader, add other ways.
In D23309#516339, @pino wrote:

The only problem with https://krusader.org/get-involved/ is that it is even more conservative than our user docs

https://cgit.kde.org/websites/krusader-org.git/
Just open a review request for that repository (or commit directly), it is not complicated...

Please always open a review! Committed and pushed changes are deployed directly to live site. People make mistakes, it's normal, and reviews reduce the likelihood of a mistake.

Thu, Aug 22, 6:36 AM · Krusader, Documentation
nmel committed R167:a9c8cfdf8bdc: Updated ChangeLog and NEWS with v2.7.2 changes (authored by nmel).
Updated ChangeLog and NEWS with v2.7.2 changes
Thu, Aug 22, 5:52 AM
nmel committed R167:7ba212f14c66: Updated NEWS (authored by nmel).
Updated NEWS
Thu, Aug 22, 5:52 AM
nmel committed R167:aee964f3c12d: Updated documentation ChangeLog (authored by nmel).
Updated documentation ChangeLog
Thu, Aug 22, 5:52 AM
nmel committed R167:519ef907d1c3: ChangeLog: Added manual updates caught by browsing git history (authored by nmel).
ChangeLog: Added manual updates caught by browsing git history
Thu, Aug 22, 5:52 AM
nmel committed R167:ab064b8d6cc5: ChangeLog: Added changes from v2.7.1 release that are mentioned in commits (authored by nmel).
ChangeLog: Added changes from v2.7.1 release that are mentioned in commits
Thu, Aug 22, 5:52 AM
nmel closed D23197: Updated ChangeLog and NEWS with v2.7.2 changes.
Thu, Aug 22, 5:52 AM · Krusader
nmel added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Thanks everyone!

Thu, Aug 22, 5:48 AM · Krusader

Mon, Aug 19

nmel added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

For example, you can fork krusader on github or other platform [...]. What do you think about this idea, Toni?

I don't think people would find it, Nikita.

Mon, Aug 19, 6:17 AM · Documentation, Krusader

Sun, Aug 18

nmel added a comment to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

When I see the usage of the method, like

const float fontWidth = (fm.QFONTMETRICS_WIDTH("WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW") - fm.QFONTMETRICS_WIDTH("W")) / 99.0;

or

headerView->resizeSection(KrViewProperties::Ext, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("tar.bz2  "));
headerView->resizeSection(KrViewProperties::KrPermissions, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("rwx  "));
headerView->resizeSection(KrViewProperties::Size, QFontMetrics(_viewFont).QFONTMETRICS_WIDTH("9") * 10);

which are all dirty hacks, I doubt we need to care too much about the differences mentioned. This code needs to be refactored properly but it's not a goal of this change. QFONTMETRICS_WIDTH will actually become a good marker of the places that need review if someone will find time and courage to make it right one day...

Sun, Aug 18, 6:47 AM · Krusader
nmel added a comment to D22957: Replace Q_WS_WIN with Q_OS_WIN in all the source code.

This is a very serious change because now #ifndef Q_OS_WIN or #else block after #ifdef Q_OS_WIN will include the code that previously was ignored. We must look at all those code paths and test features it affects. BTW, does it mean that some of those code paths do not work correctly in the current state?

Sun, Aug 18, 6:37 AM · Krusader
nmel added a comment to D23118: Changed shortcut for the embedded terminal emulator.

Good catch, Toni! No objections for the new shortcut. Please look into

  1. Making the commit headline shorter. Something like "Changed shortcut for the embedded terminal emulator". It's easier to read in the graph view. Please keep everything else, it's very good to have a detailed explanation in the commit message!
  2. Specifying CHANGED: tag, so this is not missed in the ChangeLog on the next release.
Sun, Aug 18, 6:30 AM · Krusader
nmel added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

I have no problem when someone is trying to improve a dead branch. If the person finds this useful and wants to share their changes to others — he or she is welcome to do so. It's an Open Source after all. In the same time, I understand what Luigi is saying that it might send a wrong signal to users. In addition, commits we push to the official repo are reviewed and tested, and should be only pushed when approved by at least another dev and no objections from others (unfortunately, it's not enforced due to a weak infrastructure). It means someone needs to test the changes you propose in 10 code reviews. Personally, I have no interest in kde4 commits anymore and even have no environment to test it. I doubt you'll find another dev who has.

Sun, Aug 18, 6:21 AM · Documentation, Krusader
nmel added a project to D23236: Updates related to v2.7.2 release: Krusader.

Related review: D23197 (same changelog)

Sun, Aug 18, 5:59 AM · Krusader
nmel added a project to D23235: Released v2.7.2: Krusader.
Sun, Aug 18, 5:56 AM · Krusader
nmel requested review of D23236: Updates related to v2.7.2 release.
Sun, Aug 18, 5:53 AM · Krusader
nmel requested review of D23235: Released v2.7.2.
Sun, Aug 18, 5:28 AM · Krusader

Aug 17 2019

nmel added a comment to D23197: Updated ChangeLog and NEWS with v2.7.2 changes.

Hi Toni,

Aug 17 2019, 5:42 AM · Krusader

Aug 16 2019

nmel edited the content of Release Howto.
Aug 16 2019, 5:59 AM · Krusader
nmel added a project to D23197: Updated ChangeLog and NEWS with v2.7.2 changes: Krusader.
Aug 16 2019, 5:38 AM · Krusader
nmel requested review of D23197: Updated ChangeLog and NEWS with v2.7.2 changes.
Aug 16 2019, 5:38 AM · Krusader

Aug 9 2019

nmel committed R167:5e011b150db2: Updated release information in docs and AppStream files (authored by nmel).
Updated release information in docs and AppStream files
Aug 9 2019, 6:02 AM
nmel closed D22982: Updated release information in docs.
Aug 9 2019, 6:02 AM · Krusader, Documentation
nmel edited the content of Krusader.
Aug 9 2019, 5:55 AM · Krusader
nmel added a comment to D22982: Updated release information in docs.

Updated AppStream files. Thanks Luigi and Toni!

Aug 9 2019, 5:41 AM · Krusader, Documentation
nmel updated the diff for D22982: Updated release information in docs.
  • Updated AppStream files with previous and upcoming release info
Aug 9 2019, 5:40 AM · Krusader, Documentation

Aug 7 2019

nmel added a comment to D22982: Updated release information in docs.

@yurchor, this was fast! Thanks!

Aug 7 2019, 6:06 AM · Krusader, Documentation
nmel added a project to D22982: Updated release information in docs: Krusader.

Please review by August 10, EOD. Thanks!

Aug 7 2019, 6:05 AM · Krusader, Documentation
nmel requested review of D22982: Updated release information in docs.
Aug 7 2019, 6:03 AM · Krusader, Documentation

Jul 31 2019

nmel requested changes to D15693: Shift+Del in order to remove cruft from the history of the "Search for" comboBox in the search dialog.

It's a useful feature for people that like to keep their environment clean. Thanks for working on this, Toni!

Jul 31 2019, 5:07 PM · Krusader
nmel added a comment to D22666: Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled.

If you'd like this fix to be included in v2.7.2, please push it to master by Aug 4 and I'll backport to stable. Please don't forget to specify BUG, FIXED, Differential Revision tags in the commit message.

Jul 31 2019, 4:25 PM · Krusader
nmel added a comment to D22673: Set the focus on the first search result.

If you'd like this fix to be included in v2.7.2, please push it to master by Aug 4 and I'll backport to stable. Please don't forget to specify BUG, FIXED, Differential Revision tags in the commit message.

Jul 31 2019, 4:25 PM · Krusader

Jul 28 2019

nmel accepted D22666: Achieve that Krusader searches correctly if the "Follow links" checkbox is disabled.

It works properly now - thanks!
I checked the commit you mentioned in the bug. Before it the checkbox was still ignored but the links were always not followed.

Jul 28 2019, 6:48 AM · Krusader
nmel accepted D22673: Set the focus on the first search result.

It works and I'm fine with the proposed fix. Thanks Toni!

Jul 28 2019, 6:12 AM · Krusader

Jul 22 2019

nmel committed R167:a6856ebe1fa1: Updated copyright years (authored by nmel).
Updated copyright years
Jul 22 2019, 6:41 AM
nmel committed R167:fc2090be0866: Synchronizer: Set column headers to adjust widths automatically (authored by nmel).
Synchronizer: Set column headers to adjust widths automatically
Jul 22 2019, 6:41 AM
nmel committed R167:258d9d122600: Wrap text in copy/move confirmation dialog (authored by gengisdave).
Wrap text in copy/move confirmation dialog
Jul 22 2019, 6:41 AM
nmel accepted D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

Thanks Davide! It's cleaner and macro name is good. No issues with fonts were discovered when I tested.

Jul 22 2019, 6:26 AM · Krusader
nmel committed R167:5c7c776d3341: Updated copyright years (authored by nmel).
Updated copyright years
Jul 22 2019, 6:15 AM
nmel closed D22602: Updated copyright years.
Jul 22 2019, 6:15 AM · Krusader, Documentation

Jul 21 2019

nmel added a comment to D22443: Wrap text in copy/move confirmation dialog.

If you'd like this fix to be included into v2.7.2, please merge by the end of the month.

Jul 21 2019, 6:13 AM · Krusader
nmel added a comment to D22174: Synchronizer: Set column headers to adjust widths automatically.

If you'd like this fix to be included into v2.7.2, please merge by the end of the month.

Jul 21 2019, 6:10 AM · Krusader
nmel added a project to D22602: Updated copyright years: Krusader.
Jul 21 2019, 6:04 AM · Krusader, Documentation
nmel requested review of D22602: Updated copyright years.
Jul 21 2019, 6:03 AM · Krusader, Documentation

Jul 20 2019

nmel committed R167:ca225e291284: Fixed lost editor when file is updating and the list model to correctly handle… (authored by nmel).
Fixed lost editor when file is updating and the list model to correctly handle…
Jul 20 2019, 6:57 AM
nmel accepted D22443: Wrap text in copy/move confirmation dialog.

It works fine but please fix coding style before pushing your changes. Thanks!

Jul 20 2019, 6:44 AM · Krusader
nmel requested changes to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

I agree we can substitute the width method with the horizontalAdvance, however I propose we use compat.h to eliminate code duplication here.

Jul 20 2019, 6:35 AM · Krusader
nmel accepted D22435: Remove obsolete qt version check.

Reasonable!

Jul 20 2019, 6:22 AM · Krusader
nmel added a comment to D22431: Fixed lost editor when file is updating and the list model to correctly handle next item.

Thanks for checking, Davide! :)

Jul 20 2019, 6:20 AM · Krusader
nmel committed R167:34764ed6dc1b: Fixed lost editor when file is updating and the list model to correctly handle… (authored by nmel).
Fixed lost editor when file is updating and the list model to correctly handle…
Jul 20 2019, 6:17 AM
nmel closed D22431: Fixed lost editor when file is updating and the list model to correctly handle next item.
Jul 20 2019, 6:17 AM · Krusader

Jul 13 2019

nmel added a comment to D22177: Panel: Improve open actions in context menu.

Reminder for git push :)

Jul 13 2019, 7:04 AM · Krusader
nmel added a project to D22431: Fixed lost editor when file is updating and the list model to correctly handle next item: Krusader.
Jul 13 2019, 6:59 AM · Krusader
nmel requested review of D22431: Fixed lost editor when file is updating and the list model to correctly handle next item.
Jul 13 2019, 6:58 AM · Krusader

Jul 1 2019

nmel committed R167:951ab660d733: FileSystem: Fix using creation time from KIO as changed time (ctime) (authored by nmel).
FileSystem: Fix using creation time from KIO as changed time (ctime)
Jul 1 2019, 8:07 AM
nmel committed R167:279c88da25ae: Updated minimal Qt version to the earliest supported version (5.9) (authored by nmel).
Updated minimal Qt version to the earliest supported version (5.9)
Jul 1 2019, 8:07 AM
nmel committed R167:262a96c795c7: Fixed new file permissions (authored by nmel).
Fixed new file permissions
Jul 1 2019, 8:07 AM
nmel accepted D22177: Panel: Improve open actions in context menu.

Reviewed the code and tested — everything is great!

Jul 1 2019, 6:32 AM · Krusader

Jun 14 2019

nmel accepted D21323: Shortcuts for move tab.

New revision is also good - feel free to push to master.

Jun 14 2019, 5:25 AM · Krusader

May 27 2019

nmel added a comment to D21420: Ignore Synchronize Folders redundant resize.

Thank you for the patch, Mark!

May 27 2019, 6:50 AM

May 22 2019

nmel accepted D21323: Shortcuts for move tab.

Thanks Davide!

May 22 2019, 6:58 AM · Krusader

Apr 27 2019

nmel accepted D20741: FileSystem: Fix using creation time from KIO as changed time (ctime).

Thanks for the fix and refactoring, Alex! Compiles and works as expected. Please check my inline comments.

Apr 27 2019, 3:47 AM · Krusader

Apr 15 2019

nmel added a comment to D20373: Updated minimal Qt version to the earliest supported version (5.9).

Thank you, Yuri and Alex!

Apr 15 2019, 6:51 AM · Krusader
nmel committed R167:0a80cc3ef6c4: Updated minimal Qt version to the earliest supported version (5.9) (authored by nmel).
Updated minimal Qt version to the earliest supported version (5.9)
Apr 15 2019, 6:49 AM
nmel closed D20373: Updated minimal Qt version to the earliest supported version (5.9).
Apr 15 2019, 6:49 AM · Krusader

Apr 10 2019

nmel added reviewers for D20373: Updated minimal Qt version to the earliest supported version (5.9): mchabrecek, abika, yurchor.
Apr 10 2019, 6:49 AM · Krusader

Apr 8 2019

nmel added a project to D20373: Updated minimal Qt version to the earliest supported version (5.9): Krusader.

QOverload is only available in Qt >= 5.7, and Qt 5.9 is the earliest supported version.
See also https://bugs.kde.org/show_bug.cgi?id=405212 .
I proposed this change in the discussion of D19623 and there were no objections for a month.

Apr 8 2019, 7:59 AM · Krusader
nmel requested review of D20373: Updated minimal Qt version to the earliest supported version (5.9).
Apr 8 2019, 7:54 AM · Krusader

Mar 29 2019

nmel accepted D20099: Compilation fixed with Qt < 5.11.
Mar 29 2019, 7:53 AM
nmel added a comment to D20099: Compilation fixed with Qt < 5.11.

I agree that WriteOnly is the best approximation to the NewOnly for older Qt. However, NewOnly is more advanced:

Mar 29 2019, 7:25 AM

Mar 9 2019

nmel added a comment to D19623: Replace all usages QOverload with static_cast.

Good point, Yuri. We should look into other cases as well.

Mar 9 2019, 6:49 AM

Mar 7 2019

nmel accepted D19277: Create new text files with umask applied.

Tested with various umasks and local / remote fs - works nicely. Please don't forget to fix the build (and possibly, the commit messages) before merging. Thanks!

Mar 7 2019, 6:54 AM · Krusader

Mar 4 2019

nmel added a comment to D19277: Create new text files with umask applied.

Alex, it looks good now - thanks! Let me test it and I'll get back to you in a few days.

Mar 4 2019, 7:44 AM · Krusader

Mar 2 2019

nmel committed R167:052472312f2a: Fix compile warnings on missing override declarations (authored by gengisdave).
Fix compile warnings on missing override declarations
Mar 2 2019, 5:49 AM
nmel committed R167:f12d6ce099c2: Replaced deprecated UDSEntry::insert with UDSEntry::fastInsert (authored by nmel).
Replaced deprecated UDSEntry::insert with UDSEntry::fastInsert
Mar 2 2019, 5:49 AM
nmel committed R167:0ee73d92036f: Search: Fix copy-to-clipboard action to only copy selected items Search… (authored by nmel).
Search: Fix copy-to-clipboard action to only copy selected items Search…
Mar 2 2019, 5:49 AM
nmel committed R167:73214a6672fc: Prefer to find oktetapart by desktop file, not binary name (authored by kossebau).
Prefer to find oktetapart by desktop file, not binary name
Mar 2 2019, 5:49 AM
nmel committed R167:3423920b3ad5: Updated links and used https:// where appropriate (authored by yurchor).
Updated links and used https:// where appropriate
Mar 2 2019, 5:49 AM
nmel committed R167:8901bf217486: Follow renaming of SVNNEWS in docs (authored by yurchor).
Follow renaming of SVNNEWS in docs
Mar 2 2019, 5:49 AM