nmel (Nikita Melnichenko)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2018, 7:40 AM (57 w, 2 d)
Availability
Available

Recent Activity

Sat, Mar 9

nmel added a comment to D19623: Replace all usages QOverload with static_cast.

Good point, Yuri. We should look into other cases as well.

Sat, Mar 9, 6:49 AM

Thu, Mar 7

nmel accepted D19277: Create new text files with umask applied.

Tested with various umasks and local / remote fs - works nicely. Please don't forget to fix the build (and possibly, the commit messages) before merging. Thanks!

Thu, Mar 7, 6:54 AM · Krusader

Mon, Mar 4

nmel added a comment to D19277: Create new text files with umask applied.

Alex, it looks good now - thanks! Let me test it and I'll get back to you in a few days.

Mon, Mar 4, 7:44 AM · Krusader

Sat, Mar 2

nmel committed R167:052472312f2a: Fix compile warnings on missing override declarations (authored by gengisdave).
Fix compile warnings on missing override declarations
Sat, Mar 2, 5:49 AM
nmel committed R167:f12d6ce099c2: Replaced deprecated UDSEntry::insert with UDSEntry::fastInsert (authored by nmel).
Replaced deprecated UDSEntry::insert with UDSEntry::fastInsert
Sat, Mar 2, 5:49 AM
nmel committed R167:0ee73d92036f: Search: Fix copy-to-clipboard action to only copy selected items Search… (authored by nmel).
Search: Fix copy-to-clipboard action to only copy selected items Search…
Sat, Mar 2, 5:49 AM
nmel committed R167:73214a6672fc: Prefer to find oktetapart by desktop file, not binary name (authored by kossebau).
Prefer to find oktetapart by desktop file, not binary name
Sat, Mar 2, 5:49 AM
nmel committed R167:3423920b3ad5: Updated links and used https:// where appropriate (authored by yurchor).
Updated links and used https:// where appropriate
Sat, Mar 2, 5:49 AM
nmel committed R167:8901bf217486: Follow renaming of SVNNEWS in docs (authored by yurchor).
Follow renaming of SVNNEWS in docs
Sat, Mar 2, 5:49 AM

Mon, Feb 25

nmel added a comment to D19277: Create new text files with umask applied.

Refactoring code is fine, however setting 644 unconditionally introduces a security issue. The permissions for new files should follow umask setting. Otherwise users may unintentionally share their new files with other users.

Mon, Feb 25, 6:49 AM · Krusader
nmel committed R167:a7ebda9a8054: Replaced deprecated UDSEntry::insert with UDSEntry::fastInsert (authored by nmel).
Replaced deprecated UDSEntry::insert with UDSEntry::fastInsert
Mon, Feb 25, 6:32 AM
nmel closed D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
Mon, Feb 25, 6:32 AM · Krusader

Mon, Feb 18

nmel added reviewers for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert: abika, asensi, mchabrecek.
Mon, Feb 18, 7:53 AM · Krusader
nmel accepted D19104: Search: Improve right-click context menu.

Nice fix and improvement. Thanks!

Mon, Feb 18, 7:50 AM · Krusader
nmel accepted D15987: Automatic code linting using clang-tidy..

Thanks for improving the code quality, Alex!

Mon, Feb 18, 7:29 AM
nmel updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
  • fixed build and formatting
Mon, Feb 18, 7:13 AM · Krusader
nmel commandeered D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Due to no response from Davide, I'm taking over. I also see lots of deprecation warnings and would like to fix it. The most recent revision doesn't compile, however. I have a fix and will update shortly.

Mon, Feb 18, 7:11 AM · Krusader
nmel accepted D18881: Prefer to find oktetapart by desktop file, not binary name.

I verified it's working correctly in both cases. Thanks for the patch! Please push it to the master, I'll take care of the stable branch afterwards.

Mon, Feb 18, 6:49 AM

Feb 13 2019

nmel added a comment to D18881: Prefer to find oktetapart by desktop file, not binary name.

The code looks fine to me. Let me test it over the weekend and I'll sign off if no issue found. I can also test a new code path if there is a way to modify v0.25 accordingly.

Feb 13 2019, 7:14 AM

Nov 1 2018

nmel accepted D16397: Replaced old connect() with QT5 style. Part 2.

Fixed missing this pointer in lamba call.

Nov 1 2018, 4:35 AM

Oct 27 2018

nmel requested changes to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Kindly ping.

Oct 27 2018, 7:52 AM · Krusader
nmel added a comment to D16397: Replaced old connect() with QT5 style. Part 2.

Also, summary is incorrect:

This is just the fist part, more will follow.

Oct 27 2018, 7:51 AM
nmel requested changes to D16397: Replaced old connect() with QT5 style. Part 2.

I have realized now that used lambdas in two ways, with and without this, examples:
connect(new QShortcut(QKeySequence("Ctrl++"), this), &QShortcut::activated, this, [=]() { zoomIn(); });
connect(diskUsage, &DiskUsage::enteringDirectory, [=]() { DiskUsageViewer::slotUpdateStatus(); });

Even compiler didn't complain, I suppose it should be without this.
What is your opinion?

Oct 27 2018, 7:49 AM

Oct 19 2018

nmel added a comment to D16223: Replaced old connect() with QT5 style. Part 1.

I can push it, I might need some help:
Is it enough to merge my branch to master, add code review link (= Differential revision https://phabricator.kde.org/D16223 ??) and push the master?
Or is there something more?

Oct 19 2018, 6:30 AM · Krusader

Oct 16 2018

nmel accepted D16223: Replaced old connect() with QT5 style. Part 1.

Is it approved and will be landed, or I have to send another arc diff with these 3 adjustments?

Oct 16 2018, 3:36 PM · Krusader
nmel accepted D16223: Replaced old connect() with QT5 style. Part 1.

Thanks and welcome aboard Miroslav!

Oct 16 2018, 7:21 AM · Krusader
nmel requested changes to D15987: Automatic code linting using clang-tidy..

Other than minor things noted inline, looks good! Thanks Alex.

Oct 16 2018, 7:13 AM
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Looks much better, thanks!

Oct 16 2018, 6:27 AM · Krusader

Sep 22 2018

nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Thanks Davide! This looks less cluttered.

Sep 22 2018, 5:31 AM · Krusader
nmel accepted D15678: Solve a memory leak in the Locate dialog, achieve that its destructor is able to work, and so on.

Thanks Toni!

Sep 22 2018, 5:18 AM · Krusader
nmel added a comment to D15400: Fix compile warnings on missing override declarations.

every user is a tester too.

More importantly, whenever we make a change after this is merged, we will see the warning and fix the code. We put an effort before v2.7 release to make Krusader warning-free and we should keep it this way. So now the -Wsuggest-override is on the list of warning directives that we track. Thanks Davide (and Toni ;) )!

Sep 22 2018, 5:04 AM · Krusader

Sep 15 2018

nmel added a comment to D15400: Fix compile warnings on missing override declarations.

Why not to update the flags for both debug and release (CMAKE_CXX_FLAGS var)? What's your reasoning? Does it hurt the release build?

Sep 15 2018, 5:17 AM · Krusader

Sep 13 2018

nmel accepted D15400: Fix compile warnings on missing override declarations.

Indeed, all warnings of this type are fixed. Thanks Davide!

Sep 13 2018, 6:07 AM · Krusader
nmel added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Where to put the macro? The three files don't have a common header file and I haven't found a suitable .h file; any advice?

Sep 13 2018, 5:48 AM · Krusader

Sep 12 2018

nmel added a comment to D15400: Fix compile warnings on missing override declarations.

and reproducible adding -Wsuggest-override or -Winconsistent-missing-override (not sure, haven't tested with clang) to CMAKE_CXX_FLAGS

Should we add this into cmake config file to ensure that these flags are always on?

Sep 12 2018, 6:29 AM · Krusader
nmel requested changes to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

inline

Sep 12 2018, 6:21 AM · Krusader

Aug 23 2018

nmel committed R230:3c89f435449f: createtarball: switched translation branch to stable for krusader (authored by nmel).
createtarball: switched translation branch to stable for krusader
Aug 23 2018, 7:04 AM
nmel committed R230:61fced5cc064: createtarball: krusader version bump (v2.7.1) (authored by nmel).
createtarball: krusader version bump (v2.7.1)
Aug 23 2018, 7:04 AM
nmel edited the content of Release Howto.
Aug 23 2018, 5:40 AM · Krusader

Aug 16 2018

nmel edited the content of Release Howto.
Aug 16 2018, 7:55 AM · Krusader
nmel edited the content of Release Howto.
Aug 16 2018, 7:49 AM · Krusader

Aug 12 2018

nmel committed R938:8a2f50de8b61: Published v2.7.1 (authored by nmel).
Published v2.7.1
Aug 12 2018, 4:59 PM
nmel closed D14622: Published v2.7.1.
Aug 12 2018, 4:59 PM · Krusader
nmel committed R167:8d5946a150c7: Merged v2.7.1 updates (authored by nmel).
Merged v2.7.1 updates
Aug 12 2018, 4:21 PM
nmel edited the content of Release Howto.
Aug 12 2018, 8:38 AM · Krusader
nmel edited the content of Release Howto.
Aug 12 2018, 8:30 AM · Krusader
nmel edited the content of Release Howto.
Aug 12 2018, 7:58 AM · Krusader
nmel edited the content of Release Howto.
Aug 12 2018, 7:53 AM · Krusader
nmel edited the content of Release Howto.
Aug 12 2018, 7:10 AM · Krusader
nmel edited the content of Release Howto.
Aug 12 2018, 7:01 AM · Krusader
nmel updated the diff for D14622: Published v2.7.1.
  • updated SHA256
Aug 12 2018, 6:55 AM · Krusader
nmel edited the content of Release Howto.
Aug 12 2018, 6:41 AM · Krusader
nmel committed R167:db4bed8ab65d: Version bump: 2.7.2-dev (authored by nmel).
Version bump: 2.7.2-dev
Aug 12 2018, 5:11 AM
nmel committed R167:12c18d821d86: Released v2.7.1 (authored by nmel).
Released v2.7.1
Aug 12 2018, 5:11 AM
nmel committed R167:b54bd42b623e: Updated ChangeLog and NEWS with v2.7.1 changes (authored by nmel).
Updated ChangeLog and NEWS with v2.7.1 changes
Aug 12 2018, 5:11 AM
nmel closed D14621: Released v2.7.1.
Aug 12 2018, 5:11 AM · Krusader
nmel committed R167:cad21a778115: Updated NEWS (authored by nmel).
Updated NEWS
Aug 12 2018, 5:11 AM
nmel committed R167:c9ea7b579f93: updated documentation ChangeLog (authored by nmel).
updated documentation ChangeLog
Aug 12 2018, 5:11 AM
nmel committed R167:f671c7b31c7a: ChangeLog: Added manual updates caught by browsing git history (authored by nmel).
ChangeLog: Added manual updates caught by browsing git history
Aug 12 2018, 5:11 AM
nmel committed R167:d7c9b44ca116: ChangeLog: Added changes from v2.7.0 release that are mentioned in commits (authored by nmel).
ChangeLog: Added changes from v2.7.0 release that are mentioned in commits
Aug 12 2018, 5:11 AM
nmel closed D14619: Updated ChangeLog and NEWS with v2.7.1 changes.
Aug 12 2018, 5:11 AM · Krusader

Aug 5 2018

nmel added a project to D14621: Released v2.7.1: Krusader.

Apply to stable branch. This will go after changelog / news update commits.

Aug 5 2018, 6:35 AM · Krusader
nmel added a project to D14622: Published v2.7.1: Krusader.
Aug 5 2018, 6:33 AM · Krusader
nmel requested review of D14622: Published v2.7.1.
Aug 5 2018, 6:32 AM · Krusader
nmel requested review of D14621: Released v2.7.1.
Aug 5 2018, 6:19 AM · Krusader
nmel updated the diff for D14619: Updated ChangeLog and NEWS with v2.7.1 changes.
  • updated documentation ChangeLog
Aug 5 2018, 6:12 AM · Krusader
nmel added a project to D14619: Updated ChangeLog and NEWS with v2.7.1 changes: Krusader.
Aug 5 2018, 6:08 AM · Krusader
nmel requested review of D14619: Updated ChangeLog and NEWS with v2.7.1 changes.
Aug 5 2018, 6:08 AM · Krusader
nmel edited the content of Release Howto.
Aug 5 2018, 5:42 AM · Krusader
nmel edited the content of Krusader.
Aug 5 2018, 5:39 AM · Krusader
nmel edited the content of Krusader.
Aug 5 2018, 5:19 AM · Krusader

Jul 31 2018

nmel committed R167:0c38cfab1496: Correct the tab order in the Manage User Actions dialog (authored by asensi).
Correct the tab order in the Manage User Actions dialog
Jul 31 2018, 4:48 AM

Jul 29 2018

nmel accepted D14230: Correct the tab order in the Manage User Actions dialog.

Thanks Toni! Works nicely.

Jul 29 2018, 5:45 AM · Krusader
nmel added a comment to D14416: Replace "sensative" with "sensitive" in several places.
In D14416#299821, @pino wrote:

Or, even better, use kconf_update to automatically migrate the setting to the new name, with no need to add fallback code to the application itself.
See https://techbase.kde.org/Development/Tools/Using_kconf_update
You can find examples of scripts for kconf_update in many applications, e.g. kmail, konversation, kontact, okular, tellico, kget, kcalc, akregator, gwenview, kile, etc.

Jul 29 2018, 5:36 AM · Krusader
nmel edited the content of Krusader.
Jul 29 2018, 5:29 AM · Krusader
nmel added a comment to D14416: Replace "sensative" with "sensitive" in several places.

Please also add FIXED: tag. See https://phabricator.kde.org/w/krusader/#commit-patch-guidelines

Jul 29 2018, 4:57 AM · Krusader
nmel requested changes to D14416: Replace "sensative" with "sensitive" in several places.

Please add fallback logic for the old setting. We can deprecate the fallback code with 2.9+ release.

Jul 29 2018, 4:48 AM · Krusader
nmel added a comment to D14317: Updated release information in docs.

Thanks Toni!

Jul 29 2018, 3:56 AM · Documentation
nmel committed R167:fad207ced43c: Fix minor typo (authored by yurchor).
Fix minor typo
Jul 29 2018, 3:55 AM
nmel committed R167:0d9b1950eca0: Reorganized section on quick search in BookMan II (idea by Toni Asensi Esteve) (authored by yurchor).
Reorganized section on quick search in BookMan II (idea by Toni Asensi Esteve)
Jul 29 2018, 3:55 AM
nmel committed R167:b8d80980559b: Updated release information in docs (authored by nmel).
Updated release information in docs
Jul 29 2018, 3:53 AM
nmel closed D14317: Updated release information in docs.
Jul 29 2018, 3:53 AM · Documentation
nmel committed R167:20cc78118f6f: Improve actions_tutorial doc (authored by szafar).
Improve actions_tutorial doc
Jul 29 2018, 3:53 AM

Jul 24 2018

nmel added a comment to D13904: Adapt and improve the debug logging system. Some related changes.

Thanks, Nikita. I'm not aware of a way to choose the kioslave modules that are going to be used, if it may help: to debug a kioslave what I did was using a virtual machine, where I was able to use the standard places for Krusader.

Jul 24 2018, 7:30 AM · Krusader
nmel added a comment to D14230: Correct the tab order in the Manage User Actions dialog.

... if users pressed Tab when using the KTextEdit named textDescription, then the focus would go to the next control ...

Jul 24 2018, 7:27 AM · Krusader
nmel edited the content of Release Howto.
Jul 24 2018, 7:22 AM · Krusader
nmel requested review of D14317: Updated release information in docs.
Jul 24 2018, 7:19 AM · Documentation
nmel edited the content of Release Howto.
Jul 24 2018, 6:57 AM · Krusader

Jul 18 2018

nmel added a comment to D13499: End a quicksearch after an item has been found.

Thanks! Please use git cherry-pick -x when updating 2.7 branch in the future.

Jul 18 2018, 7:00 AM · Krusader

Jul 17 2018

nmel accepted D14159: Changes in the "get-krusader" webpages to add a SHA256 checksum, remove the references to Sourceforge files, use references to KDE Plasma, etc..
Jul 17 2018, 5:24 AM
nmel added a comment to T9185: Update the icons section in https://krusader.org/report-bugs/index.html.

For this kind of change please go through reviews in the future because any change becomes live automatically.

Jul 17 2018, 5:20 AM · Krusader
nmel added a comment to T8662: In the developer documentation: add more files that have to be changed when a new Krusader version is released.

I prefer reviewing changes before applying them, but I understand that we often lack time :-)

Jul 17 2018, 5:15 AM · Krusader
nmel accepted D13499: End a quicksearch after an item has been found.

Tested, works as expected. Thanks a lot Toni!

Jul 17 2018, 5:11 AM · Krusader

Jul 15 2018

nmel committed R167:cb2a88039b39: Synchronizer is not disabled by default anymore (fix docs) (authored by yurchor).
Synchronizer is not disabled by default anymore (fix docs)
Jul 15 2018, 7:29 AM
nmel committed R167:28332e7e8af6: Panel: Always delete files by their URL (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>).
Panel: Always delete files by their URL
Jul 15 2018, 7:29 AM
nmel committed R167:cb6bed7ed0ac: Improved default values in Edit New File and View File dialogs (authored by nmel).
Improved default values in Edit New File and View File dialogs
Jul 15 2018, 7:29 AM
nmel added a comment to D13499: End a quicksearch after an item has been found.

I have trouble applying the patch to current master:

$ arc patch D13499
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D13499.
Checking patch krusader/Panel/panelfunc.cpp...
error: while searching for:
Jul 15 2018, 7:02 AM · Krusader
nmel added a comment to T8662: In the developer documentation: add more files that have to be changed when a new Krusader version is released.

Hi Toni,

Jul 15 2018, 6:06 AM · Krusader

Jul 8 2018

nmel accepted D13572: Panel: Always delete files by their URL.

Reviewed and tested - works nicely!
Please push this.

Jul 8 2018, 6:41 AM · Krusader
nmel requested changes to D13499: End a quicksearch after an item has been found.

Unfortunately, I need to take this back. I recently tested TC and it doesn't cancel the filter in this case, only hides the bar

You don't have to worry, I suppose that nobody was thinking about e.g. ending a quickfilter after F4 is used.

Jul 8 2018, 6:31 AM · Krusader