- User Since
- Jun 11 2017, 11:14 AM (96 w, 5 d)
Feb 19 2019
Looks like a few git conflict markers have made their way in the code.
Jan 31 2019
Perhaps this patch might not be it, but Okular does actually need a "Night Mode" or "Reading Mode" of sorts, in similar fashion to many epub/pdf readers like @filipf suggests.
Jan 30 2019
Agree, something similar is being proposed over at D18384. These dialogs are getting out of hand.
- change option label when on a single screen
Ah, thought you and @nicolasfella meant to change the wording on the "Current Screen" option. Isn't it a bit awkward to have "Full Screen (All monitors)" when there is just one active though? Ideally, "Current Screen" could be changed to "Full Screen" when there is only 1 monitor and left as is when there's more than one.
- Rename action
I am of the opinion that such dialogs are not very user friendly and honestly very much against them. Not commenting on the usefulness of this particular warning, but dolphin has quite a few of these kind of dialogs with the same process: Input something -> Get error -> Restart. Feedback should instead be given inplace.
Jan 29 2019
- Code style fix
Jan 19 2019
Chiming in here as the author of the bug report mentioned in this patch.
Jan 15 2019
Jan 12 2019
@dhaumann It's not about the lines of code but about making the dialog consistent in all the applications in a way that one cannot get it wrong. You can notice that the title, text, icons, confirmation are all different in each of them even though the dialog itself is trivial to implement. Okuar goes the extra step and even inverts the check box action. Even this patch, which is designed after the Dolphin implementation gets the title wrong.
Honestly this multiple tabs stuff is all over the place and IMO it should go into the frameworks as a sort of utility function in order to stay consistent instead of being written at application level. I'm sure everyone involved is familiar with the topic but I'll attach some of the confirmations just in case.
Dec 16 2018
Pinging @chinmoyr as the original author of the BatchRenameJob class.
- convert to namespace from class
- do not show first captured group
- remove help button
- Use d-ptr pattern
- remove show/hide methods and autoshow dialog
- update doc
- KFileItemList -> QList<QUrl>; KFileItem usage was unnecessary
- update doc
- WIP Change BatchRenameJobPrivate class
FWIW: The patch over at D11304 changes the behavior to select the currently existing folder instead of doing nothing.
- remove qdebug include
- remove unnecessary prefixes
- Merge remote-tracking branch 'origin/master' into arcpatch-D11304
- Fix item would not scroll and selection issue
Dec 15 2018
IMO it would be great if this would just rename inline rather than opening a dialog.
Dec 14 2018
There's still some work to do with the actual BatchRenameClass now and the d-pointer pattern. I'll update this in a few days.
The only difference in the process list is that the plasmashell icon becomes smaller. Aren't the charts and process list handled by libksysguard instead of this repository?
Dec 13 2018
There are no side effects from what I can tell.
Dec 10 2018
@anishgiri What is the advantage of using this outlined version of the Konsole icon(which we haven't seen in a light scheme yet) compared to using one of the monochrome icons already available?
Dec 7 2018
Agree with @ndavis with respect to the icon. I would be in favor of using something similar (if not identical) to dialog-scripts. It's monochrome and works with dark and light backgrounds.
Dec 5 2018
Would be great if the "Line spacing" and "Margins" checkboxes were aligned.
Nov 23 2018
FWIW I agree with @mart. Just give it a default value and leave it at that. More configuration doesn't necessarily mean better.
The classical solution to these problems is always a white text with black outline. Works well for both light and dark backgrounds.
Nov 16 2018
@trickyricky26 I think we should stick to whatever conventions the KDE community has. I checked with Dolphin and the arrow goes up for descending and down for ascending, however the VDG makes these calls in the end.
- Aren't the names in reverse? view-sort-ascending shows a list in descending order
- In view-sort-descending the items are not even sorted. Not sure how i feel about that.
Nov 13 2018
- create on stack
- upd define
- remove unused import
- use qstringliteral
- remove unused export
- match file name
- remove import prefixes
- remove q_unused on used parameter
- use fwd class declaration
- reserve space for items
- Do not use _p for cpp files
- simplify expressions
- add cpp files w/o _p
- optimize imports
I feel like hosting community projects under the kde.org subdomain would go a long way towards brand recognition(krita.kde.org, kdenlive.kde.org)
Nov 5 2018
- Initialize pointers to nullptr
- Code style fix
Nov 2 2018
Also, thoughts on my previous comments regarding BatchRenameJob?
- coding style fix
The prompt "Do you still want to rename it" feels unnatural/unusual. "Continue?" or "Do you wish to continue?" or something similar might work better. Just a suggestion, I do not have a strong opinion on the matter.
Oct 25 2018
Something that might need a bit of input is BatchRenameJob.
- Remove QtCore/
- fix indent
- remove setlayout call
- Add missing parent parameters
- Remove unnecessary QtCore/ prefix
Oct 24 2018
- use _p notation. Add BatchRenameDialog to installable headers
Sep 25 2018
- Code style fixes
- use .insert instead of 
- Indent Q_OBJECT
- use isEmpty instead of len==0
- use aggregate initialization
- protected -> private
- added parent check
- use functions instead of QString fields
- delete itemData
- code format
- FileNameUtils converted to namespace
- remove unnecessary using
Aug 5 2018
Abandoned in favor of D14631
Jun 30 2018
Jun 5 2018
In D13346#274446, @abetts wrote:
Could we have a button that enables/disables bluetooth instead? We can show the warning message only if it doesn't seem to be working? or for example, if it runs into an error when enabling, "then" show a warning sign?
Jun 4 2018
I think application-octet-stream or application-x-desktop could be used for this.
Thoughts on it rendering some default icon instead of processing it as text when the .desktop contains no icon?
I just want to chime in with a little observation (sorry if this had been addressed before, the thread is huge).
Works for me as well. One potential issue is that the object is not deleted if the rename operation is cancelled as the flag is not there anymore.
May 29 2018
Since this appears to be the main hub for Open/Save dialogs:
May 27 2018
They will have to wait a tad more until I take care of a few other things first. By late June I will resume work with all my pending patches.
Apr 27 2018
Apr 25 2018
Apr 22 2018
Rename the "Rename" tab to be "Sequential numbering" or something like that
The issue with this is that there are more tokens now than just "#", so perhaps that could be misleading in a way?
- use a list to keep track of items to be renamed.
- handle update preview on tab change
- Add "Insert token"
- fix check whether file already exists or not
- wrap strings w/ QStringliteral
- show captured groups text
- table column width fits to content
- update labels
- Add help button
- encode new name using KIO::encodeFileName
- make const
- hide "ready to rename" message
- use monospace font for group names
- show status icon when there is an empty filename
- remove empty line
Apr 4 2018
So I stumbled on something as a result of this patch. When navigating the Network(remote:/) path, right clicking an entry's "Show Original" action raises the following error.
Apr 3 2018
I don't see why not. Even though this does seem like rather irrelevant functionality for an image viewer. Perhaps it could be useful to the fokls on the Krusader Project ?
Mar 31 2018
Moved the code which finds the child to a separate function + added a test suite for it.
Revert to original state (Uploaded wrong diff via arcanist by using arc diff --update with the wrong differential number)
So this is finally updated with the latest changes and a new test suite for some utility functions and the code which does the macro substitution, find&replace and group capturing.
- Added column headers
- Remove preview button & add automatic preview when content changes.
- Use i18nc
- remove unnecessary comment
- translate table headers
- use KMessageWidget for status update
- focus the edit of the first tab
- code format
- reorganize imports
- removed qdebug import
- reorganized files
- added tests for filenameutils
- update filenameutilstest
- Moved filename utils to a class
- Add tests for rename types
- Added capture groups tests
- rename newnamebuilder to capturegroups
- translate (empty name) string
Mar 26 2018
Everything's alright. Just being a bit busier than usual. On the weekend I will update this with some more thoughts on the matter and a new diff.
Mar 18 2018
Mar 17 2018
Apologies in advance for the wall of text.
Mar 16 2018
Hi, while I do appreciate the icons I also have a question: Why the use of laptop and projector over of two simple generic screens. Wouldn't that be better for all use cases?
New arc diff.
Mar 15 2018
I'm also not sold on the usefulness of this. Dolphin can already be fully controlled by keyboard only. Ranger also has to have these extensive key bindings since it's not a GUI application so without those you can't really use it.
Mar 14 2018
- Open archive in new tab only when the appropriate setting is selected.
Mar 12 2018
Adds column names & fetches latest changes from master
@rkflx The VM on which I initially started the patch and did the first revision failed on me after I did a virtual disk resize, so I had to make a new machine. Since it was late when I finished my work I uploaded it manually rather than finding out if arcanist would allow me to "resume" my work on the existing differential (is there some quick way to do so by the way?).
Mar 11 2018
Update to latest diff.
Mar 9 2018
Yeah, it's shaping up quite nicely. Most likely on Sunday I'll update this revision with the latest changes. I'll have to look at a few things regarding batch rename added on D9103 which appears to automatically add sequence numbers even though no placeholders were given.
Feb 25 2018
+1 for the toolbar approach. Could be added at the very end, right after control. Also would be good to handle enabled/disabled or shown/hidden state based on the trash state.
Feb 22 2018
Another possible solution would be to remove those two and allow date formatting like Spectacle does: %Y-%M-%D and so on, however things like #now and #today seem a bit easier to use and they would respect the user's locale anyways. As far as translating goes, not 100% sure on that on either way.