| elvisangelaccio |
| Dolphin |
When Dolphin opens a new tab and immediately switches to it, the URL navigator gets focus if it's editable. If it's not, the breadcrumbs bar gets keyboard focus, which is not very useful since it's not really intended for keyboard navigation.
This patch changes that behavior so that the view always gets focus, which seems more useful and more consistent.
BUG: 401899
FIXED-IN: 19.04.0
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
This feels like a workaround. Why does the url navigator get focus in the first place? We should try to understand where this is happening and fix it there.
Investigated a bit. The focus seems to be automatically placed on the URL navigator, so the existing code actually does nothing. I've adjusted the patch to make it select all if the URL navigator is editable, since that facilitates rapid replacement of the existing text with a new path.
| src/dolphintabwidget.cpp | ||
|---|---|---|
| 139–141 | I'd be ok with this, but it seems unrelated. Please either update the commit message or move this change to another commit. | |
Chiming in here as the author of the bug report mentioned in this patch.
The focus should always go to the view, as it allows the user to interact with the newly opened tab and navigating from there without needing mouse input as all other elements are accessible from keyboard. The proposal of focusing the location bar or something else depending on the location bar being editable or not, is very arbitrary. The location bar can also be focused via F6 and Ctrl+L.
@elvisangelaccio would you be okay with changing the behavior to always focus the view upon opening a new tab as @emateli requests? I'm pretty much fine with anything, but I'd rather we decide on something so this poor patch can come to the end of its end its identity crisis. :-)