anemeth (Alex Nemeth)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 12 2018, 10:57 PM (83 w, 5 d)
Availability
Available

Recent Activity

Jun 16 2019

anemeth added a comment to D18377: [effects/blur] Update blur to be more natural.

Could you please try lowering the noise strength all the way down?
Noise caused some problems very similar to this a few months ago but I """fixed it"""


Does the problem persist if you use 1x scaling ?

Jun 16 2019, 5:46 PM · KWin
anemeth added a comment to D18377: [effects/blur] Update blur to be more natural.

I just downloaded the KDE Neon 5.16 iso from the website, installed it and updated it
I can't reproduce the issue

Jun 16 2019, 5:23 PM · KWin

Feb 23 2019

anemeth added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.
In D18798#418056, @pino wrote:

Also, please do not resort to psychological tricks like "torture our users", as if this is any worse than any behaviour issues there.

There is no psychological trick. This is simply how I see things: we are doing this for the users. Users are experiencing this bug. We have a known, working, low-risk (or even risk-free) patch that fixes the issue. The patch is a workaround rather than a true fix, but this is because nobody has so far figured out how to fix the issue itself without introducing substantially more risk. Given these conditions, I don't see the harm in landing the patch. Everything in life involves trade-offs, and to me, this patch falls into the category of "don't let the perfect be the enemy of the good."

I heartily agree with you on the general principle of avoiding workarounds and fixing issues at their root causes. However so far nobody has been able to do so for this issue. On the other hand, we have a workaround that we already know works and does not cause regressions because we already uses it with success in other places. In this messy world we live in, sometimes workarounds are the lesser evil. The alternative is that this remains broken for users and we continue to get bug reports about it.

If you don't have time to dig into this, do you by any chance know anyone who does?

Feb 23 2019, 3:45 PM · Frameworks

Feb 19 2019

anemeth added a comment to T9041: New "Home" tab for Kickoff.

In your mockup, do you want to make the power buttons always visible?

When we moved from windows 7 to windows 10 the #1 user ticket was "how do I shut down the computer?" and "how do I log off?" because these actions are on a button with no label.
In my opinion shutdown, restart and logoff should be visible on the main page, opposed to the current Leave page, but suspend and hibernate could be tucked away for example in a little arrow next to Shut down.

Feb 19 2019, 8:30 PM · Plasma, VDG
anemeth added a comment to T9041: New "Home" tab for Kickoff.

I'd like to add my humble thoughts to this if you don't mind.
I personally really love this proposed start menu, especially the list of newly installed apps.

Feb 19 2019, 8:03 PM · Plasma, VDG

Feb 16 2019

anemeth added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.

Wait, do we need to add this workaround to every popup menu around? What about 3d-party apps?

Can't we fix the actual bug in Qt/breeze/whatever instead?

Feb 16 2019, 8:40 PM · Frameworks

Feb 6 2019

anemeth added a comment to D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.

I will wait for someone from the frameworks team to review this before landing it.

Feb 6 2019, 10:21 PM · Frameworks
anemeth added a reviewer for D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency: kde-frameworks-devel.
Feb 6 2019, 10:18 PM · Frameworks
anemeth added a reviewer for D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency: Frameworks.
Feb 6 2019, 10:03 PM · Frameworks
anemeth requested review of D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency.
Feb 6 2019, 9:58 PM · Frameworks

Jan 31 2019

anemeth committed R108:3c2148a5fbc4: [effects/blur] Update blur to be more natural (authored by anemeth).
[effects/blur] Update blur to be more natural
Jan 31 2019, 6:21 PM
anemeth closed D18377: [effects/blur] Update blur to be more natural.
Jan 31 2019, 6:21 PM · KWin
anemeth added a comment to D18377: [effects/blur] Update blur to be more natural.
In D18377#402740, @zzag wrote:

Please re-title the change, it should look something like "[effects/blur] ...". Also, please remove the video link from the summary.

Jan 31 2019, 4:31 PM · KWin
anemeth updated the summary of D18377: [effects/blur] Update blur to be more natural.
Jan 31 2019, 4:31 PM · KWin

Jan 30 2019

anemeth added a comment to D18377: [effects/blur] Update blur to be more natural.

Updated the summary and the screenshots

Jan 30 2019, 10:38 PM · KWin
anemeth updated the test plan for D18377: [effects/blur] Update blur to be more natural.
Jan 30 2019, 10:38 PM · KWin
anemeth updated the diff for D18377: [effects/blur] Update blur to be more natural.
  • Add brackets to if for convention
Jan 30 2019, 10:01 PM · KWin

Jan 27 2019

anemeth added a comment to D18377: [effects/blur] Update blur to be more natural.

@zzag @fredrik what do you think now?

Jan 27 2019, 8:50 PM · KWin
anemeth updated the diff for D18377: [effects/blur] Update blur to be more natural.
  • Handle GLES
Jan 27 2019, 8:50 PM · KWin
anemeth added a comment to D18377: [effects/blur] Update blur to be more natural.

Given all this, it's probably best to limit this to desktop GL for now.

Jan 27 2019, 2:00 PM · KWin
anemeth added a comment to D18377: [effects/blur] Update blur to be more natural.

@rooty please test it again with this

Jan 27 2019, 11:27 AM · KWin
anemeth updated the diff for D18377: [effects/blur] Update blur to be more natural.

Fix taskbar blur

Jan 27 2019, 11:26 AM · KWin

Jan 26 2019

anemeth added a comment to D18377: [effects/blur] Update blur to be more natural.

@fredrik swoops in and solves every problem!
how it looks with this diff:

Jan 26 2019, 3:46 PM · KWin
anemeth updated the diff for D18377: [effects/blur] Update blur to be more natural.

Use sRGB textures for blur

Jan 26 2019, 3:43 PM · KWin

Jan 25 2019

anemeth added a comment to D18377: [effects/blur] Update blur to be more natural.

I tried experimenting what fredrik suggested without luck so far.
@fredrik @zzag is this the correct approach? This gives the exact same result as not using sRGB textures.

Jan 25 2019, 10:35 PM · KWin

Jan 19 2019

anemeth updated the test plan for D18377: [effects/blur] Update blur to be more natural.
Jan 19 2019, 12:15 AM · KWin

Jan 18 2019

anemeth updated the summary of D18377: [effects/blur] Update blur to be more natural.
Jan 18 2019, 11:46 PM · KWin
anemeth added reviewers for D18377: [effects/blur] Update blur to be more natural: davidedmundson, zzag.
Jan 18 2019, 11:44 PM · KWin
anemeth updated the diff for D18377: [effects/blur] Update blur to be more natural.

Added wrong file

Jan 18 2019, 11:43 PM · KWin
anemeth added reviewers for D18377: [effects/blur] Update blur to be more natural: VDG, KWin.
Jan 18 2019, 11:42 PM · KWin
anemeth requested review of D18377: [effects/blur] Update blur to be more natural.
Jan 18 2019, 11:39 PM · KWin

Oct 29 2018

anemeth added a comment to D12285: [RFC] Change drawer header image.

You put an image there for the sake of an image being there.
It is completely irrelevant to the menu.
How about putting there something relevant, like a png image of a phone and tablet and computer there showing connections?

Oct 29 2018, 6:30 PM · KDE Connect

Oct 2 2018

anemeth resigned from D15880: Khelpcenter menu does not work (some parts of TreeView not expanded).
Oct 2 2018, 3:50 PM · Documentation

Sep 24 2018

anemeth added a comment to T8707: Window borders.

I think the vertical and horizontal gray lines look great. Less so the diagonal ones that make up the corner.

Sep 24 2018, 8:47 PM · VDG
anemeth added a comment to T8707: Window borders.

It still looks great when the corners are over a dark area but when over a light area the rounding looks off. It's like the opacity isn't completely right. It is actually also visible in the screenshot you posted. If you look closely (or zoom in) on the lower right corner on the window with Konqi you can see that a few pixels are "off"

Sep 24 2018, 8:42 PM · VDG
anemeth added a comment to T8707: Window borders.

Sep 24 2018, 5:49 PM · VDG
anemeth added a comment to T8707: Window borders.

Does your effect keep the corners square when the window is tiled or maximized?

Sep 24 2018, 5:47 PM · VDG
anemeth added a comment to T8707: Window borders.

Discover also integrates nicely

Sep 24 2018, 5:43 PM · VDG
anemeth added a comment to T8707: Window borders.

If anyone interested there is a KWin effect that rounds the corners of windows.
Here is my fork of it with a few tweaks: https://github.com/alex47/KDE-Rounded-Corners

Sep 24 2018, 5:38 PM · VDG

Sep 21 2018

anemeth added a comment to D15683: Add lock icon to desktop context menu.

My arcanist is still borked. Could someone please push this? Thank you.

Sep 21 2018, 8:11 PM · Plasma
anemeth retitled D15683: Add lock icon to desktop context menu from Add lock icon to context menu to Add lock icon to desktop context menu.
Sep 21 2018, 6:21 PM · Plasma
anemeth added reviewers for D15683: Add lock icon to desktop context menu: ngraham, VDG.
Sep 21 2018, 6:20 PM · Plasma
anemeth requested review of D15683: Add lock icon to desktop context menu.
Sep 21 2018, 6:18 PM · Plasma

Sep 12 2018

anemeth added a comment to D15435: Add translucent background attribute to desktop icon popup menu.

I'm having problems with my arcanist.
Could someone please land this for me?

Sep 12 2018, 9:09 PM · Plasma

Sep 11 2018

anemeth retitled D15435: Add translucent background attribute to desktop icon popup menu from Add translucent background attribute to popup menu to Add translucent background attribute to desktop icon popup menu.
Sep 11 2018, 8:46 PM · Plasma
anemeth updated subscribers of D15435: Add translucent background attribute to desktop icon popup menu.
Sep 11 2018, 7:49 PM · Plasma
anemeth updated the summary of D15435: Add translucent background attribute to desktop icon popup menu.
Sep 11 2018, 7:43 PM · Plasma
anemeth added reviewers for D15435: Add translucent background attribute to desktop icon popup menu: hein, davidedmundson, Plasma.
Sep 11 2018, 7:42 PM · Plasma
anemeth updated the diff for D15435: Add translucent background attribute to desktop icon popup menu.

Add translucent background attribute to popup menu

Sep 11 2018, 7:36 PM · Plasma
anemeth requested review of D15435: Add translucent background attribute to desktop icon popup menu.
Sep 11 2018, 7:35 PM · Plasma

Sep 6 2018

anemeth abandoned D12545: Set focus on the filename line edit when a file is selected.

@ngraham I'm sorry, but because of my new job I don't have much free time left so I can't actively develop anymore. I'd really like if someone took over this patch.

Sep 6 2018, 7:48 PM · Frameworks

Jul 13 2018

anemeth added a comment to D12804: Fix window frame rounding when scaling is used.

Jul 13 2018, 11:00 PM · Plasma
anemeth added a comment to D12804: Fix window frame rounding when scaling is used.

As others said the dpi scaling should normally be dealt with QImage::setDevicePixelRatio()
As far as I can tell this is not working with Breeze for the following reason:

Jul 13 2018, 10:59 PM · Plasma
anemeth updated the diff for D12804: Fix window frame rounding when scaling is used.

Rebase on master

Jul 13 2018, 10:45 PM · Plasma

Jul 4 2018

anemeth added a comment to R319:452cced03e40: Revert "Show the scrollbar only when needed".

Why was this reverted?

Jul 4 2018, 6:27 PM

Jun 17 2018

anemeth added a comment to D13579: apply blur to windows using Konsole as KPart.

In D10063 @hein raised a problem that is an (IMHO very very) edge case when the user has a split terminal (for example in Yakuake) that has different profiles with blur enabled and disabled:

Jun 17 2018, 12:52 PM · Konsole

Jun 15 2018

anemeth updated the diff for D11843: Show the scrollbar only when needed.

Rebase on master

Jun 15 2018, 9:12 PM · Konsole

Jun 8 2018

anemeth added a comment to D12678: Fix multimonitor blur.
In D12678#275913, @apol wrote:

Shouldn't this go to to Plasma/5.13?

Jun 8 2018, 4:51 PM · KWin

Jun 3 2018

anemeth added a comment to T8707: Window borders.

@ngraham it looks weird at the top where the titlebar and the sideborder contact
How about a nice gradient between them?


(This would be just a breeze specific change)

Jun 3 2018, 7:02 PM · VDG

Jun 1 2018

anemeth committed R125:311324a004c7: [Khelpcenter] Use HiDPI icons (authored by anemeth).
[Khelpcenter] Use HiDPI icons
Jun 1 2018, 2:59 PM
anemeth closed D13265: [Khelpcenter] Use HiDPI icons.
Jun 1 2018, 2:59 PM · Documentation
anemeth added reviewers for D13265: [Khelpcenter] Use HiDPI icons: davidedmundson, lueck.
Jun 1 2018, 12:03 PM · Documentation
anemeth requested review of D13265: [Khelpcenter] Use HiDPI icons.
Jun 1 2018, 11:59 AM · Documentation
anemeth added inline comments to D13246: [effects/blur] Check for blitting support.
Jun 1 2018, 10:52 AM · KWin
anemeth committed R108:81f38abe6d6d: [effects/blur] Check for blitting support (authored by anemeth).
[effects/blur] Check for blitting support
Jun 1 2018, 10:19 AM
anemeth closed D13246: [effects/blur] Check for blitting support.
Jun 1 2018, 10:19 AM · KWin

May 31 2018

anemeth retitled D13246: [effects/blur] Check for blitting support from Check for blitting support to [effects/blur] Check for blitting support.
May 31 2018, 7:09 PM · KWin
anemeth added reviewers for D13246: [effects/blur] Check for blitting support: KWin, davidedmundson.
May 31 2018, 7:06 PM · KWin
anemeth requested review of D13246: [effects/blur] Check for blitting support.
May 31 2018, 7:03 PM · KWin
anemeth committed R108:b3b691a25074: Fix blur on Wayland when scaling is used (authored by anemeth).
Fix blur on Wayland when scaling is used
May 31 2018, 12:35 PM
anemeth closed D12700: Fix blur on Wayland when scaling is used.
May 31 2018, 12:35 PM · KWin
anemeth added a comment to D12700: Fix blur on Wayland when scaling is used.

You can just download the patch as raw diff, reapply to current master and copy the description text from Phab in a new commit message (copy the scheme from earlier commits).

May 31 2018, 12:26 PM · KWin
anemeth added a comment to D12700: Fix blur on Wayland when scaling is used.

Could someone please land this revision?
My arcanist has a problem with this patch.

May 31 2018, 12:23 PM · KWin

May 29 2018

anemeth committed R108:99532fb95c1e: Fix multimonitor blur (authored by anemeth).
Fix multimonitor blur
May 29 2018, 1:33 PM
anemeth closed D12678: Fix multimonitor blur.
May 29 2018, 1:33 PM · KWin
anemeth committed R108:8342cdd3b6d9: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in… (authored by anemeth).
[libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in…
May 29 2018, 1:27 PM
anemeth closed D12452: [libkwineffects/kwinglutils] Calculate correct srcY0 and srcY1 in GLRenderTarget::blitFromFramebuffer.
May 29 2018, 1:27 PM · KWin

May 25 2018

anemeth added a comment to D12678: Fix multimonitor blur.

This revision depends on D12452
@zzag could you please tell us the status of D12452? I see it's accepted, but not yet landed.

May 25 2018, 6:14 PM · KWin

May 17 2018

anemeth added a comment to D12678: Fix multimonitor blur.

@davidedmundson @zzag
I tested yTranslate = -screen.y(); with kwin_wayland --windowed --xwayland --output-count 2
Once there is a height difference between the displays it doesn't work.

May 17 2018, 11:37 AM · KWin

May 15 2018

anemeth added a comment to T8707: Window borders.

What if we used the same color as the titlebar?

May 15 2018, 12:41 PM · VDG

May 14 2018

anemeth added a comment to D12804: Fix window frame rounding when scaling is used.

Here is Breeze close button modified to use QPainter::drawRoundedRect() and uses the same radius (3) as the titlebar:

May 14 2018, 3:38 PM · Plasma
anemeth added a comment to D12804: Fix window frame rounding when scaling is used.
In D12804#262333, @zzag wrote:

Also, what session it is? (X11 or Wayland)

I think you're facing one of X11 issues.

May 14 2018, 3:07 PM · Plasma

May 13 2018

anemeth updated the diff for D12848: Set fix steps for icon sizes.
  • Remove unused function
May 13 2018, 11:18 AM · Frameworks
anemeth updated the summary of D12848: Set fix steps for icon sizes.
May 13 2018, 11:16 AM · Frameworks
anemeth updated subscribers of D12848: Set fix steps for icon sizes.
May 13 2018, 11:15 AM · Frameworks
anemeth added reviewers for D12848: Set fix steps for icon sizes: Frameworks, VDG.
May 13 2018, 11:15 AM · Frameworks
anemeth requested review of D12848: Set fix steps for icon sizes.
May 13 2018, 11:11 AM · Frameworks

May 12 2018

anemeth committed R374:8c356069a9df: [Kolourpaint] Use HiDPI icons (authored by anemeth).
[Kolourpaint] Use HiDPI icons
May 12 2018, 5:05 PM
anemeth closed D12582: [Kolourpaint] Use HiDPI icons.
May 12 2018, 5:05 PM
anemeth committed R374:b0baf57142cd: Add .arcconfig file (authored by anemeth).
Add .arcconfig file
May 12 2018, 5:01 PM
anemeth closed D12805: Add .arcconfig file.
May 12 2018, 5:01 PM

May 10 2018

anemeth added a comment to D12804: Fix window frame rounding when scaling is used.

Also: how does it work with multiple monitors ? (I see you get the info from ::primaryScreen, not for the screen the window is actually on ?

May 10 2018, 1:32 PM · Plasma
anemeth added a reviewer for D12804: Fix window frame rounding when scaling is used: davidedmundson.
May 10 2018, 1:29 PM · Plasma
anemeth added reviewers for D12805: Add .arcconfig file: aacid, lueck, davidedmundson.
May 10 2018, 12:27 PM
anemeth requested review of D12805: Add .arcconfig file.
May 10 2018, 12:26 PM
anemeth updated the test plan for D12804: Fix window frame rounding when scaling is used.
May 10 2018, 12:03 PM · Plasma
anemeth added reviewers for D12804: Fix window frame rounding when scaling is used: Breeze, VDG, hpereiradacosta.
May 10 2018, 12:02 PM · Plasma
anemeth requested review of D12804: Fix window frame rounding when scaling is used.
May 10 2018, 11:58 AM · Plasma
anemeth added a comment to D12582: [Kolourpaint] Use HiDPI icons.

The only thing I found that was out of place was the action menu icons.
They don't seem to honor the Qt attribute.

May 10 2018, 8:36 AM
anemeth committed R241:c537a717363c: Allow accepting by double-click in save dialog (authored by anemeth).
Allow accepting by double-click in save dialog
May 10 2018, 8:29 AM