Fix pixmap scaling on HiDPI screens
Needs RevisionPublic

Authored by emateli on Dec 13 2018, 7:45 PM.

Details

Summary

Adds the usual flag needed for HiDPI screens.

Test Plan

The process list and charts are not hidpi aware as they are handled by libksysguard from what I can tell.

Diff Detail

Repository
R106 KSysguard
Branch
hidpi
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6004
Build 6022: arc lint + arc unit
emateli created this revision.Dec 13 2018, 7:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 13 2018, 7:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
emateli requested review of this revision.Dec 13 2018, 7:45 PM
emateli edited the test plan for this revision. (Show Details)Dec 13 2018, 7:51 PM
emateli added a reviewer: mlaurent.
davidedmundson accepted this revision.Dec 13 2018, 7:53 PM
davidedmundson added a subscriber: davidedmundson.

Adds the usual flag needed for HiDPI screens.

Usual flag, usual reply.

Please be sure to open every dialog / config screen / etc that you can find.
Setting this flag means the code will get pixmaps in sizes it might not expect which has the potential to break applications. It's why it's opt-in.

This revision is now accepted and ready to land.Dec 13 2018, 7:53 PM

There are no side effects from what I can tell.

mlaurent accepted this revision.Dec 14 2018, 6:26 AM
broulik requested changes to this revision.Dec 14 2018, 8:31 AM
broulik added a subscriber: broulik.

I didnt push D14490 yet as there are issues.
For instance, KWindowSystem::icon returns incorrect dpr for pixmaps, so the application icons are glitchy:


I didn't notice any painting issues in the plotters so far at least

This revision now requires changes to proceed.Dec 14 2018, 8:31 AM

The only difference in the process list is that the plasmashell icon becomes smaller. Aren't the charts and process list handled by libksysguard instead of this repository?

Aren't the charts and process list handled by libksysguard instead of this repository?

This flag affects the process not where the code comes from.