This mode uses the QPalette to find a background and foreground color.
Details
Diff Detail
- Repository
- R223 Okular
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7709 Build 7727: arc lint + arc unit
I agree, there is no chance anyone would want to use this. As your video demonstrates, contrast is terrible with all color schemes (especially Oxygen) and would cause severe eye strain if you actually tried to read anything with it. It's an anti-accessibility feature lol
Reading PDFs can be a bit painful in the dark, especially if your eyes are already tired. (I sometimes use KWin's Invert effect to help me out). So do I see the benefit in this, but only as a night mode of sorts.
EDIT: There's existing tools to deal with that, this would only make some sense then if we had a day vs. night color scheme option.
My use case is that I contently switch between breeze and breeze dark with a script that call lookandfeeltool and change Konsole colorscheme. So I wanted that more parts of my system could adapt to this script. I could probably also hack something so that it use the existing change dark & light colors option with kwriteconfig5.
Perhaps this patch might not be it, but Okular does actually need a "Night Mode" or "Reading Mode" of sorts, in similar fashion to many epub/pdf readers like @filipf suggests.
I totally agree with this.
In my opinion, to use the system color sheme, this is also needed:
- Text hinting or even changing the font [1]
- More colors from color sheme for text highlighting, drawing, etc.
- Images are not changed
[1] If the font is changed, the kerning should fit to the new font (not like https://bugs.kde.org/show_bug.cgi?id=367959)
Is it possible to get the color of PDF text, sort the used colors, and assign them different system highlighting colors?
Ok, thanks for the suggestion I will try to look how to create a better dark theme patch when I have time :D