Sorry, I kind of forgot about this revision.
But looks all good now!

In T12011#207874, @manueljlin wrote:

my take on this

What do you think of this? The symbol with 1px lines.

In D24959#556058, @ngraham wrote:

Better now @trickyricky26?

In D15580#554598, @simgunz wrote:

Is the icon fine for the toolbar hide/close button? Do you have a better suggestion?

*Hide toolbar button*

Some of my thoughts on the new preferences-desktop-search icons (D24959#554523) also apply here: I think that lines of the magnifying glass symbol feel a bit too thick for Breeze, and IMO the large glass-to-handle ratio doesn't feel quite right, although I realize you have to fit that paw symbol in there. Also, this kind of icon is a classic candidate for the 45° degree shadow.

On the technical side, we usually convert everything to paths, and even though I can't imagine Qt SVG Renderer would have a problem with circle, it might be better to convert the background to a path.

In D24753#550676, @simgunz wrote:

First, thanks for the excellent work on the new icons for Okular. I really like them.

I have noticed that the edit-opacity icon does not render correctly in some cases:

Preview in Cuttlefish.

Okular annotation toolbar

• Remove top stripe, reduce the opacity of the remaining stripes

With the blue color, I like these icons. Please remember to update images in the test plan when you make changes such as this color change, they're very helpful for judging things e.g. on a phone.

Before this is can be landed, you will have to also add/change the Konsole and Yakuake icons in the icons-dark directory.

Please optimize the SVG files using one of these methods: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

• Use design with multiple lines of different thickness

In D24412#542056, @ndavis wrote:

I think something similar to this line width icon would work well:

Inkscape uses a similar icon, but for all line styles:

Visually I think this is fine and a good improvement.

In D24185#537880, @ngraham wrote:

Now the butt ends are gone again. :)

• Use sine wave as suggested by ndavis

In D24185#537365, @ndavis wrote:

I have some improvements to the squiggle, but unfortunately, I have no internet in my house except on my phone until the 27th.

basically, I

• made a rectangle
• gave it a stroke
• shrunk the height to fit in the 12x3 area under the U
• used the function plotter to generate a sine wave
  • adjusted the width and function x/y parameters of the function plotter until I got exactly the right length from the low point (left) to the high point (right)
• converted the stroke to a path
• cut it at the low point (left)/high point (right)
• simplified the path
  
  this probably could have been simpler

• Use butt line ending for slightly nicer asthetics

• A tiny bit more optimized

Should I land this or abandon it?
It doesn't really make a difference if the icon is in Breeze in addition to being shipped with the app, but IMO it would also be strange to not have this Breeze-style icon for a KDE app in Breeze.

In D23761#527355, @meven wrote:

Is that the expected result ?

If so, it needs some polishing IMO.

In D23782#527623, @ndavis wrote:

What is this icon used for?

I love this patch, however I am curious as to why you moved the sidebar to the bottom.
Judging from your screenshot, it results in quite a bit of empty horizontal space.
Conceptually I think it is nicer to have the scrollable view go to the bottom of the window and have the details of the selected item be shown in a sidebar.

My thoughts on your submission:

In D23116#511430, @GB_2 wrote:

Maybe instead of hardcoding the blue and red colors you can use the stylesheet colors ButtonFocus and NegativeText: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets

• Fix stylesheet ids

I am not quite sure of the version for the FIXED-IN tag.

The new design looks great!
The dark mode is certainly a nice addition, but I feel the "Note" Box feels a bit out of place there with its dark text on a light green background. I think the box would look nicer in dark mode if you used the same color palette as inline notifications in Plasma with the Breeze Dark theme. I'll try to find a screenshot as I'm on mobile right now.

I think the cyan color is too bright and saturated. It fits the original branding well, but stands out from other Breeze icons.

Sure, go ahead. I'm busy right now

• Use design by @ndavis with tighter spacing

• Name -symbolic icons properly

• Change 16px player-volume-muted to symlink in order to pass duplicate test

• Lower opacity of inactive sound waves to 0.25

• Add -symbolic symlinks to the 16px version

• Add the bottom 1px shadow

• Improve contrast by making the camera silver, add Breeze-style shadows to screen and buttons

• Use a 64px design with a shotgun-type mic; use steeper angle for the lens on small versions

I will make some minor changes to the 64px design.

As they are now it's long, short, long (exact same length as rectangle number 1), shorter than height (which looks bad imo). There are no medium lengths and the same length is used twice. I would suggest giving every bar a different length.

I like it!

In D18986#411807, @ngraham wrote:

I like the head-on camcorder style, but there's the risk that it's less recognizable than the "classic" style of video recorder icon that's used pretty much everywhere. If we go with the head-on style, it needs to be perfect.

I think the monochrome version is fine.
For the colorful version, I suggest making the screen much bigger if that side isn't going to be filled with more buttons or the like.

In D18940#410980, @ndavis wrote:

I think having a different location based on battery level would get annoying

Try rendering pngs of these icons with the montage-breeze commands found here: https://invent.kde.org/ndavis/hig-kde-org/wikis/home

I like it!
Would you consider moving the green charging to either the filled-in or the white part where the symbol is currently above the line where the filled-in part ends?

• Use a circular design for the rotor to make it more recognisable

In D18901#409255, @ngraham wrote:

From a distance, I wonder if those stationary rotors really connote the right thing. How hard would it be to make them look spinning, by replacing them with circles instead?