Did you commit in 19.04 branch, i still get hangs in KMail on logout in QtWebEngineCore::ProfileAdapter::~ProfileAdapter then in QtWebEngineCore::WebContentsAdapter::~WebContentsAdapter.

Use spaces instead of tabs.

It does not look correct either, the problem is that the focus on location bar is delayed and setActive(false) isn't applied, this is workaround. But we have problems on that before, exactly that part with focusIn on location bar. You should correct there but it can break something other.

https://phabricator.kde.org/source/solid/browse/master/src/solid/devices/frontend/devicemanager.cpp$301
@bruns, It's backend per thread

In D22155#488593, @ngraham wrote:

In D22155#488485, @anthonyfieroni wrote:

Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new features + bugs fix and Plasma offers LTS.

Do you have any examples of distros that do this? To my knowledge, all "LTS" style distros freeze all versions of KDE software, not just Plasma and apps.

In D22155#488497, @GB_2 wrote:

We can backport the changes in Plasma to the LTS branch though.

Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new features + bugs fix and Plasma offers LTS.

Alternatively you can add message widget that explore double click functionality, when double click is applied it can change its message that save is applied. But rater OK/Apply became a bit pointless.

QList<KNSCore::Comment*> should be QList<shared_ptr<KNSCore::Comment>>, don't leave ownership to consumers.

it's removed in D20157

I saw filters does not compile when it compiles Karbon only, i should correct that, but i have much time now.
Edit: I investigate and it works correctly, i mislead APP_KARBON and KARBON.

In D20400#475648, @danders wrote:

In D20400#475477, @anthonyfieroni wrote:

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

If you mean export to svg here, afaics there are no page element in svg. Have I missed it?

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right?
Full cmake command

cmake .. -DCMAKE_INSTALL_PREFIX=/usr  -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR=/usr/lib/qt5/plugins -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DBUILD_TESTING=FALSE -DPACKAGERS_BUILD=true -DBUILD_UNMAINTAINED=TRUE -DPRODUCTSET=APP_KARBON

Someone test it, code wise looks good, i plan to test it soon.

In flavor of D20400

In flavor of D20400

The change is correct to me.

In D16648#473249, @thomasp wrote:

I failed to request changes for D16648#inline-121014.
This is bound to randomly exhibit strange behaviour.

Activity id can be appended to dbus name, so it will be trivial to check.

Can we make readyItems unique_ptr?

That's not the right place do it, it should be done in ItemRetrievalManager.

dymanic_cast is expensive, prefer qobject_cast if you want to check result against nullptr, if you don't want - static_cast.

That's maybe KAuth bug or KCoreAddons one, when job fails it should have errorString. Also check jobs does not delete itself.

Will be good see how it looks in dark theme, especially dark pictures.

That's for right click action menu, i notice that after upgrading to 19.04, since i'm not using Baloo tags action does nothing, patch looks good it should work.

In D19947#438052, @apol wrote:

In D19947#438003, @davidedmundson wrote:

It's subtle but I quite like it.

\o/

It feels a bit inconsistent given it affects plasmoids on keyshortcut, but not on click.

Agreed, but here the bug is that on click it doesn't happen I'd say, and we'll have to go over all plasmoids I'm afraid, because they all implement a MouseArea to deal with triggering.
I was looking into introducing context menu on pressAndHold and there's a similar problem.

Ping this looks sane, anyone ?

What happen to this? Put it to 19.04 for testing.

Video or screenshot will be helpful.

Test now, i can't reproduce behavior mentioned above.

It's good to +1

Ok, so @trmdi you can apply exactly David suggest and discard D18804, i've test it and it works. Push it in 5.15 not 5.16 that's bug fix not feature. 5.12 can be also interested path as LTS version.

@davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ?

I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in.

Did you understand why it happen?

I notice it, because i use SQLite backend, LGTM to me +1