When on click is enabled the timeout is always set to -1.
This breaks the logic inside captureScreenshot to display the progressbar in the
taskmanager.
BUG: 409218
nicolasfella | |
ngraham |
Spectacle |
When on click is enabled the timeout is always set to -1.
This breaks the logic inside captureScreenshot to display the progressbar in the
taskmanager.
BUG: 409218
Check on click or use spectacle in a wayland session
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
src/Gui/KSMainWindow.cpp | ||
---|---|---|
276–279 | Just make it 0 if (theTimeout < 0) { theTimeout = 0; } |
src/Gui/KSMainWindow.cpp | ||
---|---|---|
279 | I had the same idea but that unfortunately doesn't work because the timeout is used inside spectacle core to figure out if the screenshot should happen after a time or on click. If it isn't onclick platformkwinwayland will just return and do nothing |
src/Gui/KSMainWindow.cpp | ||
---|---|---|
279 | To me, it still better to be there, you can discard time in platformwayland and just do it. You can wait for other opinions as well. |
It works for me.
Why don't we support timeouts on Wayland? Is there anything fundamental blocking it?
Because the available KWin functions that we use to read the image from a pipe on wayland show a confirmation overlay that the user has to click to take a screenshot or has to select with his click which screen/window to capture.
src/Gui/KSMainWindow.cpp | ||
---|---|---|
279 | After thinking about it that wouldn't work because then we couldn't differentiate on X anymore, too. |