That's second patch follows D17640 it tries to use new syntax connect by identify its parent as dolphin view and connect to activate signal. Another approach is to make new public slot and connect in dolphin view constructor.
- Group Reviewers
- R318:ec29cfff2017: [versioncontrolobserver] Update working directory on tab activation
VersionControlObserver is exported class changing its constructor type parameter can brake ABI, but does it user of ? In other hand addition of public slot is ABI comfortable, so another approach can be better solution.
I prefer your previous approach: an "observer" class is not supposed to have public slots, it should react on its own when stuff happens.
To avoid changing the constructor, we could add a new method setView(), similar to setModel() which we already have.