In T12815#238382, @marcboocha wrote:Just wondering, is there any use of karbon inside the suite?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Aug 28 2020
Aug 28 2020
anthonyfieroni added a comment to T12815: Create Calligra Framework by separating out applications and libraries.
Jul 1 2020
Jul 1 2020
anthonyfieroni added a comment to D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.
Ping, it should be committed?
Jun 27 2020
Jun 27 2020
anthonyfieroni added a comment to D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS.
I test, current situation, i don't think the parch is needed as is. 2 monitors FullHD and 4K (HDMI) now KScreen does not allow different scale factor to distinct monitor but you can change the kdeglobals
[KScreen] ScaleFactor=1 ScreenScaleFactors=eDP1=1;HDMI1=2;VIRTUAL1=1; # NOTE 2 on HDMI
That seems to work, but not well enough. When you move window from low res monitor to high res one window is scaled automatically, but it seems glitchy. Window content is looking a bit broken (font is scaled and readable well)
Jun 23 2020
Jun 23 2020
New patches go in https://invent.kde.org/ You can fork https://invent.kde.org/utilities/yakuake apply patch and make pull request.
anthonyfieroni added inline comments to D17462: Close Yakuake window when it loses focus under Wayland.
Jun 21 2020
Jun 21 2020
anthonyfieroni added a comment to D29329: Introduce AbstractDataSource round the DataSourceInterface.
Ping, do not forget.
Jun 6 2020
Jun 6 2020
anthonyfieroni added inline comments to D29829: Fix divide-by-zero crash for zero-sized cropped images.
Jun 1 2020
Jun 1 2020
anthonyfieroni accepted D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.
@ngraham i don't think it's needed this for existing reviews, it's double work for nothing.
It has 2 weeks testing before 5.71 release just push it, it can be reverted if broke something.
May 26 2020
May 26 2020
anthonyfieroni added a reviewer for D29833: Akonadi searches for file mysql-global.conf at wrong path: mlaurent.
In D29833#673879, @ZaWertun wrote:Another approach is to remove prefix akonadi/ from all calls to the StandardDirs::locateResourceFile (second parameter):
May 25 2020
May 25 2020
anthonyfieroni added a comment to D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag.
Wait @davidedmundson to accept it.
May 20 2020
May 20 2020
anthonyfieroni added a reviewer for D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag: davidedmundson.
So change should be fine, (https://phabricator.kde.org/source/plasma-workspace/browse/master/appmenu) since KDED loads only modules they don't know where and when qApp is instantiated.
May 19 2020
May 19 2020
May 18 2020
May 18 2020
anthonyfieroni added a reviewer for D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag: zzag.
Is that KWin that set titlebar menus?
May 17 2020
May 17 2020
But I'm not quite ready for 5.70 yet, that would probably mean recompiling most of KDE
Commented code should be removed.
May 16 2020
May 16 2020
In D15111#672155, @boemann wrote:Even for line thickness it doesn't make sense to enable it in general. the image will change if you zoom in and out.
I miss something here, the idea behind the patch is to have pixel metrics in thickness, geometry etc. @boemann i got your opinion as to have configurable pixel units, is that right?
May 15 2020
May 15 2020
May 14 2020
May 14 2020
Rebase on master
May 13 2020
May 13 2020
Thank you, i should wait ship it, but just got Dag comment as it is.
Should it /var/lib/flatpak (or just /flatpak/) be included as well?
Refactor main window views
Fix canvas event handling
Fix canvas event handling
Seems fine, i'll push pageapp/flake changes as part of this review in 3.2 branch and master, refactoring main window in separate commit master only.
May 12 2020
May 12 2020
@danders i saw your patch on my email. d->viewportWidget->canvas()->removeEventFilter(this); fixes the issue but i still prefer all of refactoring code. Please test on all components does not have regressions.
anthonyfieroni retitled D29542: Refactor canvas event handling from Refactor MainWindow view to Refactor canvas event handling.
May 11 2020
May 11 2020
We should call removeEventFilter or found exactly why signal is emitted in destructor.
d->rootPart->createView(doc, this); Creates the view which parent is main window.
anthonyfieroni added inline comments to D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent.
May 9 2020
May 9 2020
anthonyfieroni added a reviewer for D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11: zzag.
anthonyfieroni added inline comments to D29568: use KSycoca for updating OpenPreferredSearchTool action.
Add more context
May 8 2020
May 8 2020
May 7 2020
May 7 2020
anthonyfieroni added inline comments to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
anthonyfieroni added inline comments to D29486: xdgshellclient: Allow menus from panels to take focus.
anthonyfieroni added inline comments to D25339: update lineHeight if boundingRect indicates a larger value..
May 6 2020
May 6 2020
anthonyfieroni added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
I don't see why qApp is not deleted here
https://api.kde.org/frameworks-api/frameworks-apidocs/frameworks/kdbusaddons/html/kdbusservice_8cpp_source.html#l00099
Probably because it can be allocated on stack.
anthonyfieroni added inline comments to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
May 2 2020
May 2 2020
KNewstuff is framework, it has only master.
Apr 29 2020
Apr 29 2020
QSignalBlocker ?
Is this still WIP, it looks good, can we proceed?
Apr 28 2020
Apr 28 2020
The idea is to remove some of the configuration possibility: for example only allowing the KoModeBoxDocker to be a left or right sidebar. (putting at the top and bottom was completely broken anyway so I don't think many people did it).
I don't know why everyone wants tools to be above edit window. That's pretty old style when resolution ratio was 4:3 that's why they was arranged one above another. But i agree that it should be flexible to be horizontal or vertical as needed.
Apr 27 2020
Apr 27 2020
anthonyfieroni added a comment to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
What kind of GHNS dialog you spot about? It's a service menu, right click on supported file format (deb, rpm, zst)
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
anthonyfieroni added a comment to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
+1, well done. Wait ship it from maintainer.
anthonyfieroni added a comment to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
You can rename summary to inform that Debian, RPM and Pacman packages are supported.
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
anthonyfieroni added inline comments to D29119: Dolphin: Implement package kit for deb/rpm/pacman service packages.
Apr 22 2020
Apr 22 2020
In D29028#653194, @romangg wrote:In D29028#653192, @apol wrote:I don't really see why we'd want to support something that is not offering ABI stability and doesn't push Plasma in any direction.
It is offering in the same way ABI stability as most other components of Plasma, i.e. until a new minor Plasma release.
Apr 20 2020
Apr 20 2020
Apr 18 2020
Apr 18 2020
anthonyfieroni added a comment to D25339: update lineHeight if boundingRect indicates a larger value..
+1, looks great.
Apr 17 2020
Apr 17 2020
Apr 14 2020
Apr 14 2020
In D28817#647912, @bport wrote:I don't think we have a leak, on destructor we delete all view
qDeleteAll(m_views);
anthonyfieroni added inline comments to D28817: fix (kcm): correct output identifier position on wayland.
anthonyfieroni added a reviewer for D28812: Avoid fullRepaint loop penalty in paintSimpleScreen: zzag.
Create patch like this git diff -U999 > 1.patch it will add more context to be shown to reviewers.
Apr 9 2020
Apr 9 2020
Apr 8 2020
Apr 8 2020
anthonyfieroni added inline comments to D28127: Add some new battery sensors : energy_now, energy_full and power_now..
If you want to kill the job how this loop will be break?
Apr 5 2020
Apr 5 2020
@elvisangelaccio this peace of code is purely wrong at least m_storages is not updated to new device and not only. This code should never exists or try to hide some other bug.
Apr 4 2020
Apr 4 2020
In D28286#641165, @dfaure wrote:That wouldn't work either, you need to be able to choose between a Notification delegate, a Dialog delegate (which lives in a different library due to the QtWidgets dependency), and some more.
OK, let's keep things as they are. Because the best i can make without dedicated function is new KIO::ApplicationLauncherJob(service, KIO::ApplicationLauncher::WITH_AUTO_ERROR_HANDLED_DELEGATE)
Ok that's look good to me. We can move that code in constructor just before loop for storages, then use m_mtpdevice instead of raw device, but it looks like removed code is just a noise and it shouldn't present at all.
And what about the idea to pass delegate to job constructor? At least it's better than current one. I'm pretty pedantic about duplicate code in plus it makes porting harder.
Apr 3 2020
Apr 3 2020
In D28535#640699, @feverfew wrote:So to be succinct, the only correct fix here is to change getDevice() to return m_mtpdevice?
@feverfew are you gonna try what i'm writing about or i should do it? Just use cached device, do not reopen since it'll return nullptr.
I see we don't speak in same language :)
LIBMTP_Open_Raw_Device_Uncached(&m_rawdevice);
returns nullptr that's normal since device is inaccessible, i mean it does not need to call LIBMTP_Release_Device using m_mtpdevice is safe it's not nullptr, it's just a disconnected device and libmtp knows that.
In D28535#640672, @fvogt wrote:If getDevice() returns nullptr, this means that MTPDevice::getDevice() returns nullptr. This can only happen if m_mtpdevice is nullptr, which will crash in MTPDevice::~MTPDevice sooner or later anyway.
anthonyfieroni added inline comments to D28215: [RFC]: WIP: Make mobile broadband actually functional.
You're right about bug report, but it can fail in any other place, just in particular version it happen in updateStorageInfo Can we cache getDevice in m_device (in constructor) then use it everywhere. I think libmtp has guard against disconnected device and will not crash.
Apr 2 2020
Apr 2 2020
anthonyfieroni added inline comments to D28498: [xdgoutput] Explicitly set version of server interface.
Apr 1 2020
Apr 1 2020
anthonyfieroni committed R449:609887228ab1: [git] Set combo box to current branch in pull dialog (authored by anthonyfieroni).
[git] Set combo box to current branch in pull dialog
anthonyfieroni added inline comments to D28476: Samba: Ensure to differenciate mounts sharing the same source.
Mar 31 2020
Mar 31 2020
anthonyfieroni added inline comments to D28445: Reduce the amount of objects that are compiled several times.
Mar 29 2020
Mar 29 2020
In D28286#636881, @dfaure wrote:Why not -> because it just doesn't scale. 30 jobs * 4 delegates = 120 wrapper methods...