Changes the height of the date string to match that of the
time string so the date is readable with a vertical panel
BUG: 404611
davidedmundson | |
Zren | |
ngraham | |
rooty |
VDG | |
Plasma |
Changes the height of the date string to match that of the
time string so the date is readable with a vertical panel
BUG: 404611
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
applets/digital-clock/package/contents/ui/DigitalClock.qml | ||
---|---|---|
305 | You should check if panel orientation, now it's broken horizontal view? |
Is the panel orientation checked on lines 101, 183, and 256? I haven't noticed any changes or problems with the horizontal panel with this change on my system.
Thank you for the patch! You did great, and on the first try, too!
I can confirm that this change fixes the issue for me and I do not notice any visual regressions when using a horizontal or vertical panel, either with the default height, or a taller/wider height. The code change looks sane on the surface (more than sane even, since it's removing the use of a magic number), however I'm not super familiar with this code so I'd like @Zren and/or @davidedmundson to sign off on this first.
applets/digital-clock/package/contents/ui/DigitalClock.qml | ||
---|---|---|
305 | This is inside a State { when: plasmoid.formFactor == PlasmaCore.Types.Vertical } |
applets/digital-clock/package/contents/ui/DigitalClock.qml | ||
---|---|---|
305 | Could you please clarify? Are changes needed? |
No, changes are not needed.
This works great for me and the code makes sense. I could not find any regressions in my testing. I recommend landing it.
applets/digital-clock/package/contents/ui/DigitalClock.qml | ||
---|---|---|
305 | No changes are needed; that comment was indicating why @anthonyfieroni's comment was not applicable. |