thomasp (Thomas Posch)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 12 2017, 6:38 PM (126 w, 3 d)
Availability
Available

Recent Activity

Jun 2 2019

thomasp added a comment to D21547: Tighter match own service when trying to find suitable window to open path in..

Can you please commit on my behalf?

Jun 2 2019, 10:49 PM · Dolphin
thomasp updated the summary of D21547: Tighter match own service when trying to find suitable window to open path in..
Jun 2 2019, 7:15 PM · Dolphin
thomasp accepted D16648: Open externally called files/directories in new tabs.

Opened distinct PR D21547.

Jun 2 2019, 6:48 PM · Dolphin
thomasp updated the summary of D21547: Tighter match own service when trying to find suitable window to open path in..
Jun 2 2019, 6:47 PM · Dolphin
thomasp requested review of D21547: Tighter match own service when trying to find suitable window to open path in..
Jun 2 2019, 6:43 PM · Dolphin
thomasp requested changes to D16648: Open externally called files/directories in new tabs.

I failed to request changes for D16648#inline-121014.
This is bound to randomly exhibit strange behaviour.

Jun 2 2019, 6:11 PM · Dolphin
thomasp added a comment to D16648: Open externally called files/directories in new tabs.

I was about to suggest about the same, but ngraham beat me to it.
If it is easy to find out which Activity/VD a Dolphin window belongs to, then additionally filtering for those values in

Dolphin::attachToExistingInstance

should do the trick.

Jun 2 2019, 6:07 PM · Dolphin
thomasp added a comment to D16648: Open externally called files/directories in new tabs.

Reopening because I believe this is broken in combination with activities.

Jun 2 2019, 12:25 PM · Dolphin
thomasp added a comment to D19150: Dolphin single instance tabbed navigation.
Jun 2 2019, 12:23 PM · Dolphin
thomasp reopened D16648: Open externally called files/directories in new tabs.
Jun 2 2019, 12:10 PM · Dolphin

Jan 13 2019

thomasp added a comment to D18217: Allow newer TLS versions.

What is the default protocol when not set explicitly? Does the default allow SslV2 and/or SslV3?
I liked TlsV1_0OrLater better...

Jan 13 2019, 7:41 AM · KDE Connect

Nov 30 2017

thomasp updated subscribers of D8942: Make the player status a per-player object in the MPRIS plugin.

I can not. Maybe you can ping @apol.

Nov 30 2017, 3:56 AM

Nov 29 2017

thomasp accepted D8942: Make the player status a per-player object in the MPRIS plugin.

MprisPlayer.Seek() is the only one starting with a capital.
Then ship it.

Nov 29 2017, 2:01 PM
thomasp added a comment to D8942: Make the player status a per-player object in the MPRIS plugin.

More suggestions:
MprisPlugin.sendAction(), MprisPlugin.setVolume(), MprisPlugin.setPosition(), MprisPlugin.seek() look quite alike and could be collapsed.
Add MprisPlayer.next(), MprisPlayer.previous() and MprisPlayer.playPause() in favour of sendAction("MAGIC").

Nov 29 2017, 9:39 AM

Nov 28 2017

thomasp added a comment to D8942: Make the player status a per-player object in the MPRIS plugin.

I think you should give MprisPlayer a reference to MprisPlugin and move the setters into MprisPlayer too.
Then change MprisActivity.targetPlayer to be a MprisPlayer.

Nov 28 2017, 3:42 AM

Nov 7 2017

thomasp added inline comments to D7960: Add commands to RunCommandPlugin - Desktop part.
Nov 7 2017, 6:03 PM · KDE Connect
thomasp added inline comments to D7960: Add commands to RunCommandPlugin - Desktop part.
Nov 7 2017, 5:42 PM · KDE Connect

Oct 16 2017

thomasp added inline comments to D7960: Add commands to RunCommandPlugin - Desktop part.
Oct 16 2017, 5:31 PM · KDE Connect

Sep 24 2017

thomasp created D7963: share plugin: path display.
Sep 24 2017, 8:02 AM

Sep 22 2017

thomasp added a comment to D7922: Use pactl instead of KMix in PauseMusic Plugin.

I would be ok with keeping the KMix codepath, but I think its quite a corner-case since most people use pulseaudio anyway. If we keep it we should make sure people are aware that they need pactl OR kmix for that feature. I am not aware that Kmix is a dependency on any distro (I wasn't even aware that we have this feature until yesterday :D)

I am totally fine with kmix support being removed. Please disable the option in the UI when it will not work if at all possible. It will prevent grieve for the dying breed of pulseaudio deniers.

Sep 22 2017, 1:58 PM · KDE Connect
thomasp added a comment to D7922: Use pactl instead of KMix in PauseMusic Plugin.

I took a quick look on how to do this with ALSA:

  • amixer set Master mute
  • amixer set Master unmute
Sep 22 2017, 12:24 PM · KDE Connect
thomasp added inline comments to D7922: Use pactl instead of KMix in PauseMusic Plugin.
Sep 22 2017, 12:18 PM · KDE Connect
thomasp added a comment to D7922: Use pactl instead of KMix in PauseMusic Plugin.

Sorry for the fuss. I do not have this option enabled. Just got scared there for a second.

Sep 22 2017, 12:16 PM · KDE Connect
thomasp added a comment to D7922: Use pactl instead of KMix in PauseMusic Plugin.

I know I am in the minority, but pulseaudio just does not work with dolby digital and dts on my system.
Please retain the functionality with kmix.
Can you maybe #ifdef it with a PULSEAUDIO_ENABLED option or check on ${PACMD} STREQUAL "PACMD-NOTFOUND"?

Sep 22 2017, 5:06 AM · KDE Connect

Sep 5 2017

thomasp added a comment to D7692: Set text and border color from palette for syndication preview.

Please commit.
Thank you!

Sep 5 2017, 12:57 PM
thomasp added a reviewer for D7692: Set text and border color from palette for syndication preview: stikonas.
Sep 5 2017, 12:50 PM

Sep 4 2017

thomasp created D7692: Set text and border color from palette for syndication preview.
Sep 4 2017, 7:58 PM

Aug 7 2017

thomasp added inline comments to D7146: Fix information leak via /tmp.
Aug 7 2017, 4:22 PM · KDE Connect

Aug 5 2017

thomasp added inline comments to D7146: Fix information leak via /tmp.
Aug 5 2017, 8:27 PM · KDE Connect

Jul 17 2017

thomasp added a comment to D6752: Fix build with ocaml 4.04.

fixes the problem for me on gentoo using ocaml-4.04.2

Jul 17 2017, 4:56 PM

Feb 12 2017

thomasp reopened D3850: Pass -fno-operator-names when supported.

Alternative tokens [lex.digraph] are standard c++ and have been since it's was standardized (and I don't know of any plan to deprecate them). They are a accessibility feature, since not every keyboard has those keys.
Disabling operator names makes it impossible to include a header file which uses them in an template, inline or constexpr function. Since it is also not possible to re-enable operator names in icc and clang this seems less like a 'discouragement' than a force.
Making three(!) compilers diverge from the standard and forcing users of ECM to diverge too because MSVC needs a switch to follow the standard is in my opinion a bad idea.
A standards conformant compiler is a requirement for portability, not a limit.

Feb 12 2017, 7:14 PM