Fix dir change when show hidden terminal panel with running program in it
ClosedPublic

Authored by AndreyYashkin on Jul 12 2019, 2:35 PM.

Details

Summary

Terminal panel doesn't change its working directory, while any procces is running in it. However, if you hide it and show again the program will get a string with a cd path command.

Test Plan
  1. Open dolphin
  2. Press F4
  3. Start any process like gnu nano
  4. Press F4 two more times

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
AndreyYashkin requested review of this revision.Jul 12 2019, 2:35 PM
AndreyYashkin created this revision.
anthonyfieroni added inline comments.
src/panels/terminal/terminalpanel.cpp
180–181

Just add braces, first on same line as condition.

Added braces

elvisangelaccio accepted this revision.Sun, Jul 28, 4:31 PM
elvisangelaccio added a subscriber: elvisangelaccio.

Thanks, going to push to 19.08 :)

This revision is now accepted and ready to land.Sun, Jul 28, 4:31 PM
This revision was automatically updated to reflect the committed changes.