Only show tags action when baloo is enabled
AbandonedPublic

Authored by nicolasfella on Apr 23 2019, 9:50 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Dolphin
Summary

The Tags FIAP querys the tags ioslave for all known tags, which is filled by Baloo. This makes the FIAP useless without Baloo, so don't show it when baloo is disabled
Bug: 406814

Test Plan

balooctl diable -> action is not shown
balooctl enable - > action is shown

Diff Detail

Repository
R824 Baloo Widgets
Branch
baloo
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11163
Build 11181: arc lint + arc unit
nicolasfella created this revision.Apr 23 2019, 9:50 PM
Restricted Application added a project: Baloo. · View Herald TranscriptApr 23 2019, 9:50 PM
nicolasfella requested review of this revision.Apr 23 2019, 9:50 PM
nicolasfella edited the summary of this revision. (Show Details)Apr 23 2019, 9:51 PM
nicolasfella edited the test plan for this revision. (Show Details)

I'm afraid this doesn't work for me. After applying the patch, disabling Baloo, and restarting Dolphin, the FIAP and Places Panel entries are still visible in Dolphin.

That's for right click action menu, i notice that after upgrading to 19.04, since i'm not using Baloo tags action does nothing, patch looks good it should work.

bruns added a subscriber: bruns.Apr 24 2019, 4:36 PM

I think we should step back and create Task for proper Tag handling:

  1. Removing a tag from the last file removes it from the tag list
  2. Creating a tag is only possible by assigning it to a file
  3. We have no tag attributes, e.g. color, custom emblem ...
  4. The FIAP is also shown for files on e.g. FAT, where XAttr and thus tags are not supported
bruns added a comment.Fri, May 3, 12:37 AM

I think this is obsolete now

In that case, what fixed 406814? Or should it be closed?

bruns added a comment.Fri, May 3, 1:25 AM

In that case, what fixed 406814? Or should it be closed?

D20857 makes it possible to remove file tags, and it was always possible to add tags via "New tag...". I 406814 is mostly invalid.

bruns added a comment.Sat, May 25, 4:23 PM

please close

nicolasfella abandoned this revision.Sat, May 25, 4:33 PM