Yep, you're right. That desaturate will be a problem for other icon themes.

I forgot to fix the indentation again :)

• Shuffle/repeat settings are now saved (added them to persistent settings)
• Fixed margins in RTL
• Made icons 22px to avoid blurring in some cases
• Made icons cycle instead of fading. I used desaturation to get rid of the red in the repeat-none button which was pretty distracting, not sure it's the best idea though.
• I ended up removing the border. Getting it to keep the buttons centered while adding a bit of padding and separation in both LTL/RTL was near impossible. I reworked the margins to make everything more evenly grouped.

In D12714#259483, @mgallien wrote:

I tried with reversed layout (RTL support) and the margins are wrong.
You can test by starting elisa with the -reverse option :
elisa -reverse

TBH I don't think the sidebar and view are too separate, but the line does help separate things better (specially when scrolling). I duplicated the playlist separator line for this. I've also made the sidebar a bit smaller to slide another album per row for the album view

In D12714#258646, @astippich wrote:

I just wondered about the border around the repeat and shuffle buttons. Since borders are removed everywhere else, I think it may be better not to add them there again. Also one comment inline

• Remove unused line
• Move shuffle/repeat bindings back to where they were in master
• Fix indent for border
• Bump required KF to 5.45

I did a quick test without changing files between runs, the first startup took a few seconds to finish importing but subsequent startups were instantaneous. This is looking really good.

Works as advertised, thanks!

IMO, the last version looks better than the current menu. That said, I think the top/bottom paddings are still too tight, I would try adding 2-3px for each.
It's true that there's a question of taste but more whitespace is generally a good thing (unless you go overboard and start making huge widgets). A couple more pixels in the menus will help focus the elements better (by framing them in negative space), it will make the ui look less "full of stuff" and less tense.

Sure thing, here's all the variations with the proper type:

The clock size has been changed for 5.12, so this task can be closed. Unless you want to keep it open for configuring the clock size instead.

I can't +1 this hard enough. There's no point in having a line separating the titlebar from the window. For users that want their titlebars the same color as the window it just gets in the way, and for users that want a clear separation it adds nothing (since there's already the background color change to visually separate them).

Agree with the text not being useful for small sizes, but it could look good for a large logo-style image (like say, a 256px logo on the wiki/homepage).
A cassette is definitely an interesting idea for an icon. At least it's not another musical note or play icon :)

In the end, I traced over it with inkscape :) I couldn't figure out what type you were using so I just used noto (we can change it later).
Here's some ideas using the blue-purple gradient and others.

Hey sure! I'll try to work something out this evening. @abetts BTW, could you post the svg file for your logo? it would easier to work with that, instead of painting over with krita

+1 I wouldn't have this as a default for Breeze, but it looks really cool. I'm sure it'd be a popular option, specially among those trying to mimic macOS.

In T6859#125347, @abetts wrote:

I really like the variations! I like the one with the yellow highlight and the connecting highlight in the name. Love it! I would even add another highlight at the top to accentuate!

This is looking really cool! Here are some suggestions. (@abetts I took the liberty of painting over your work, hope you don't mind :) )

Just gave this a quick try and it really ties the UI together, nice work!

Check for > -1 to catch tracks tagged with a track number 0
Also include PlayListEntry.qml

Sure! I'll update the description too

+1 Looks way more organized, and it's easier to grasp what application you're seeing and what it does on a quick glance. Minor nitpick: I'd add more margin around the summary text (to separate it better from screenshots and the summary link).

The fourth screenshot (after on windows) has the perfect level of transparency IMO. The linux (after) one is a great improvement too though.

I have to agree with @ngraham. I think the player bar actually needs more contrast. With some dark backgrounds I have to squint/get close to the screen to read the minutes.

Hey this looks even better than the old default, great idea!

Hey guys! Are these design tasks still open? I'd be interested in contributing

Adding them at the bottom is probably the best, specially if there's going to be more filtering options later on. They don't have to be visible all the time though, there could be a button next to the action buttons to toggle the filtering bar.

Make shadows larger using a bigger radius and some spread

In D9681#186553, @ngraham wrote:

Also, Elisa looks like it's really coming along. I'm addicted to Lollypop at the moment, which is a super polished GNOME music player, but I keep meaning to check out Elisa at some point. Expect a flurry of Bugzilla tickets and patches if and when I do :)

In D9681#186551, @mgallien wrote:

In D9681#186520, @ngraham wrote:

Looks great. I would even make them a bit bigger, but that's just me. :-) I like big shadows and I cannot lie...

Thanks for your work.
I agree, they could be bigger.

Make it really obvious where newly-installed apps can be found

In D9560#184178, @mgallien wrote:

Thanks for your work.
I would like to add the missing rating (5 stars) widget to the top bar. Do you have an advice about its best position ?

Update to remove unneded desaturate element.

I knew it would look better, but not this much better!
Please accept this change

In T6686#121823, @michaeltunnell wrote:

@januz

Not sure if there's still a lot of Unity refugees, a lot people seem to have settled on Gnome+dash to dock (and other extensions).

I say there is still a LOT of people who havent switched yet because Unity is deployed in a massive amount of LTS users. I think there have been a lot of people to transition already but still a huge amount that haven't.

+1 Definitely an improvement. What do you think about grouping the homepage with the rest of the info at the top?

Thanks for the tips guys!

• Tweaked regexes to fit better with the other regex in the file
• Version bump
• Added autotests and updated references

In D9265#180847, @mgallien wrote:

Do you have a contributor account or should I push your changes myself ?

Not sure if there's still a lot of Unity refugees, a lot people seem to have settled on Gnome+dash to dock (and other extensions).
That said, it shouldn't be too complicated to make a unity look and feel for plasma (following @michaeltunnell's video).
Also, I'd consider using Unity 8's look, it was way more modern looking than 7.

I don't have commit rights (AFAIK :P), please push it.

Added a comment for magic numbers

Use relative scaling. The 0.71 factor looks funny but it aligns with the icons the best.
Also reverted the change for clock+date.

Hey, shadows are now getting disabled on albums and tracks views.
One small detail: When there's no cover, image is undefined in albums and tracks but for artists it's passed as an empty string.

In D6764#178028, @romangg wrote:

Why did you change the 0.56 * main.height value in case a date is shown? Reduces the clock size in two line mode and in this mode it was not too big.

Add units.smallSpacing to single line height

Reducing the scope of this patch a bit, it now sets the clock fontsize to a fixed value. This prevents all the layout issues from relative scales. The code changes now are minimal, so it won't add pile more complexity on the code.
I'll continue working on the rewrite when I have some free time again, and submit a patch when/if I have feature parity with the current clock.

In D8371#177673, @cullmann wrote:

b) an extended unit test would be nice, to really show that the regex are right.

+1 for this patch. The three-line buttons happen in many other places too (dolphin, window title bars, firefox, chrome, etc.). Users quickly learn that pattern and recognize it as the "menu button" so I don't think that would be a problem.

In D6764#172831, @mmustac wrote:

I think this describes the main problem for most users (including me) very good:
KDE Forum: Padding in plasma panels

Thanks for the replies guys.
@davidedmundson Good point! I'll keep a close eye on the current code while I work on this.

So, I've been fighting with this for a few weekends already and I just can't get it to work reliably with a relative scale. The spacing goes all wonk and sometimes the labels' font size don't change the way you expect them to (probably because of the maze of bindings).

Awesome! thanks