Disable track number for songs that don't have it
ClosedPublic

Authored by januz on Jan 20 2018, 10:09 PM.

Details

Summary

This patch hides the track number for tracks that don't have it in the album, playlist, track and metadata views.

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
januz requested review of this revision.Jan 20 2018, 10:09 PM
januz created this revision.
januz added a project: Elisa.
januz edited the summary of this revision. (Show Details)Jan 20 2018, 10:13 PM

Thanks!
It is actually Elisa that is initializing the value with -1 (see musicaudiotrack.cpp if you are interested). The playlist (PlayListEntry.qml) already does the check, but does != -1. Could you change your patch to check for >-1 for all three files? This way we would handle the case if a track is incorrectly tagged with a track number 0.

Sure! I'll update the description too

januz updated this revision to Diff 25731.Jan 21 2018, 10:29 PM

Check for > -1 to catch tracks tagged with a track number 0
Also include PlayListEntry.qml

januz edited the summary of this revision. (Show Details)Jan 21 2018, 10:31 PM
mgallien accepted this revision.EditedJan 22 2018, 8:01 AM
mgallien added a subscriber: mgallien.

Thanks for your work

This revision is now accepted and ready to land.Jan 22 2018, 8:01 AM
This revision was automatically updated to reflect the committed changes.