@mgallien Hey, sure! Thanks for finishing it

I tried to take another look at this, but after rebasing on master I started getting an error when building:

I'll try to look into this again next weekend. I think Elisa was missing some way to go properly from Now Playing to a specific album view, so it went straight to all albums.

Hi guys, sorry I've been dropping the ball on this one. I had reverted this some weeks ago but couldn't find another way to center it. And then I didn't have time to get back on it.
+1 for landing it now

This is mostly done too but there's still one small bug: when I go to the now playing view and then click on the album name it doesn't open the album, but only switches to the album view.
Still trying to figure this out

• Use new AlbumId data

Thanks for the ping! This was mostly done but I had forgotten about it

Hey, great! I can't see the bug anymore. The only thing that's missing now is toggling when the window is maximized, right now the button switches but there's no change in the UI.
BTW, maximizing the UI + window looks awesome. Specially with high-res covers.

Looking good. I noticed the bug seems to show up consistently when the window is maximized (I think that's the one you're talking about)

In D14736#306615, @ognarb wrote:

For the moment, I've only implemented the button for hiding the bottom part. How can I detect if I'm in the party mode or in the minimal mode?

Hi @ognarb, great work! There's one change I think would make this better. Let the window become smaller when this setting is enabled so it can be the same height as the headerbar in the normal window state. When party mode is disabled though, the window should have the same minimum height as it does now. You can find the properties to do that in ElisaMainWindow.qml

In T7884#151224, @astippich wrote:

• Names in both dolphin and elisa are aligned to the center

Do you mean this as a wish? They are left aligned, which is also consistent with the other views.

Tested this on my branch and it works now, thanks guys

• Reverse clear list icon
• Add ellipsis on load/save texts (for tooltips)

Looks like ToolButtons ignore text. I managed to hack this by shoving a Text object inside them but it really messes up the layout and only the icon is clickable.

In D14015#291572, @ngraham wrote:

How about putting the icons on top and making them toolbuttons without a visible button-looking border? There's plenty of unused vertical space there, and square buttons might fit well in the available space.

There is some room, but it ends up looking more cramped.

Replace menu with buttons (also eliminates the reverse mode problem)

Hey guys, yeah there's room for the 4 buttons up there. The main pro for the dropdown was having text for the buttons that modified the playlist, but having the buttons could also simplify things. Sorry I keep forgetting about reversed mode

LGTM. Tested this by adding MOD files to the playlist and now they show up correctly.
One small issue is that they are all inside a blank album (with only a CD icon) which looks a bit strange but that's a topic for another patch.

Hey, thanks for working on this. I tried this in the links branch but it seems all albums are giving back zero (even after deleting/rebuilding the db).

@mgallien Thanks!

Bring back goBack action

In D13834#290249, @mgallien wrote:

In D13834#286910, @januz wrote:

I don't quite understand what you guys mean by a different workflow.

I downloaded Lollypop to try it out, but the workflow is almost the same as Elisa for me. There's a global playlist (in a popup), if you click the play button the playlist is cleared and replaced, and you can click the + button to enqueue.

(offtopic: I'm really digging those giant cover images)

I do not know Lolypop very well. I meant players in general where you do not see an explicit global playlist but where you just play the music currently shown.
Some people kept asking for an iTunes like behavior. I also do not know it but I understood that it was optimized to work well without a global playlist.

Good point in the ellipsis. The broom icon is way better but I'm going to wait for confirmation from @mgallien or @astippich since we are on 5.45 now.

Thinking a bit more about this, we might want to use PgUp/ PgDn to scroll in the playlist/content views so maybe we should go straight for the chord.

This patch isn't finished yet. I've come across a problem with the album view: the openOneAlbum() function requires a databaseID to get the album data but I have no way of getting that in the header bar. I looked around the headerbarmanager code for a bit but I have no idea how we could fetch that. Everything else works.

• Make menu text contextual (show/hide)
• Let window be smaller when playlist is disabled (up to 700px)
• Disable menu action in Now Playing view
• Add customizable shortcut for the action (wohoo, I figured it out! It's F9 by default)

Based on the old mockups at: https://diegogangl.github.io/

@ngraham Good point about Ctrl+T , I tried to make them mnemonic but I can see how it could be confusing. What do you think about F9? It's used by the place's panel in Dolphin, so it's a bit similar.

I don't quite understand what you guys mean by a different workflow.

In D13834#285807, @ngraham wrote:

Very nice! You'll lure me away from Lollypop yet. :)

In D12841#286645, @mgallien wrote:

Sorry for the big delay on my side.
Let's get it in the 0.2 branch. It is much better with than without it.
We will do a real 0.2.1 with stuff being fixed !!!

There's one small thing left to do for this one: add a customizable shortcut. I couldn't figure out how to do it though, should I add the action in C++ to do that?

I don't have albums with more than with two digit disc numbers, so I'll take your word for it :)
LGTM

In D13639#284146, @mgallien wrote:

Unfortunately, I have not yet found a reliable way to get light text with all fonts. Some work, some does not work.

I think it looks really good right now! Two more things:

• Every track has the multi-disc format now (1/2, 1/3, etc.) even when they are not multi disc. Some individual tracks show " / 1".
• The screen you shared earlier had the track numbers and artist names in a lighter grey, did you decide against it?

In D13639#282787, @mgallien wrote:

In D13639#281508, @januz wrote:

I can see what you mean, the alternating colors would look weird if they go across albums. The other option could be making the alternating colors "local" to albums, but I'm not sure how we could do that since we can't rely on track numbers.

Did you had a look at the last screenshot where all album headers have a third color distinct from the rows ? The difference may be too small but at the same time, I am a bit lost on which solution apply.

Tested and LGTM

I can see what you mean, the alternating colors would look weird if they go across albums. The other option could be making the alternating colors "local" to albums, but I'm not sure how we could do that since we can't rely on track numbers.

+1 I've been using borderless windows all the time since I came back to KDE Plasma and haven't had any workflow issues.

A couple more things:

• I think a bit of marginBottom in the title row would be good too, to separate the artist name from the first song name
• The track being played gets a bold font, but only for the title. I think it'd be more consistent to have bold text in the whole row
• Looks like the "-1" for songs without a track number came back
• RTL has some issues (though it's probably not done yet)

I might be biased but I absolutely love this :D

In D12975#276525, @astippich wrote:

Unfortunately still a while. KFileMetaData has currently not the ability to write these tags, and Elisa itself also has no infrastructure yet to actually edit the metadata

In D12841#273743, @mgallien wrote:

In D12841#272366, @januz wrote:

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Thanks for your work.

I tried increasing the font size to 14 (OK, this is a corner case) and the bottom of the buttons are no longer aligned.
Did you consider using TextMetrics to get the exact height of the label ?

In D12975#271297, @astippich wrote:

we could actually flip the position of the buttons and the star ratings...

Make filter rating stars always visible

When I tried this the first time I got this error and the loading animation running constantly.

Tried this from master and it works really well. The thing that gets excites me the most is that Elisa can now play MOD files! I can confirm that .xm, .it, .mod and .s3m formats work. MIDI files are also recognized and shown but they failed to play for me.

Tried this again from Master after nuking my DB. I get more genres (I think) but they are all empty and if I try to play them I get an empty playlist.

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Gave this a quick try:

No problem :)

In D12992#267534, @lshoravi wrote:

I agree in that a circle doesn't have as much personality as maybe a
casette. I also agree in that the casette felt off when looking at it.

How would something like an LP player with the E on top feel? I won't have
time until Monday (finals coming up), but my gut says that a brown-ish
square with a dark circle (like seeing an LP player from above) with some
iconography on top could look good.

Here's a test for the "columns" idea.

• Revert size changes
• Remove blank line
• Tweak border colors (size change)

TBH I like the concept of the cassette icon more than the current implementation of it. What was good about about is that it had personality, which is a big deal since usually icons also double as logos. IMO a solid icon should be 1) Memorable and 2) Descriptive. Imagine both icons amongst these google search results and consider which one would stand out, which one you would know it's elisa's. These icons are technically great, they are just not memorable.

Heh I thought this was only affecting desktops so it didn't need to be touchable, I completely forgot PCs have touchscreens too these days.
Good points, I'll revert that later

In D12992#266673, @mgallien wrote:

In D12992#266288, @alex-l wrote:

^ I'm for this one without the quaver

I also prefer this one without the quaver.
Is it possible to really simplify the background for the small size icon ? It would be probably much easier to read it.

@astippich and @januz what is your opinion ? You are also working on Elisa and should have the rights to speak ;)

Did a quick test going back and forth from albums to artists and works great

I don't think the buttons look so bad jumping around, after all there's only two positions they can be. However I think if we keep them in the same position (in the middle) but actually push them farther to the left we could create the illusion of columns, and it wouldn't look so weird. I'll take a look at it.

Yep it's probably the font, I'm using the ubuntu font and it looks like this:

Could be dpi, are you using a high-dpi screen? Could you post a screen so I can see how far off it is?
I'm thinking it could also be the system font. What font are you using?

Tighten margins

LGTM. The tracks icon is much better now

Sorry I forgot to check albums with covers.