Sidebar design changes
ClosedPublic

Authored by januz on May 6 2018, 12:55 AM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:3f9782721913: Sidebar design changes
Summary

Design changes for the sidebar according to the mockups in the ML

In this patch

  • Make sidebar smaller
  • Make the selected view use the highlight color for the text and icon
  • Add a small margin to align with the views titles
  • Remove backgrounds

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
januz requested review of this revision.May 6 2018, 12:55 AM
januz created this revision.
januz edited the summary of this revision. (Show Details)May 6 2018, 12:57 AM
januz added a project: Elisa.
ngraham added a subscriber: ngraham.May 6 2018, 1:42 AM

No line between the sidebar and the main view? Not sure that's a good idea. Separating dissimilar elements helps guide the eye to different parts of the app. Without enough separation, parts that are different can start to blend together.

No line between the sidebar and the main view? Not sure that's a good idea. Separating dissimilar elements helps guide the eye to different parts of the app. Without enough separation, parts that are different can start to blend together.

I tend to agree. If we want to make the sidebar looks lighter, we can still add a very thin line to separate it from the main view.

januz updated this revision to Diff 33735.EditedMay 6 2018, 11:43 PM

TBH I don't think the sidebar and view are too separate, but the line does help separate things better (specially when scrolling). I duplicated the playlist separator line for this. I've also made the sidebar a bit smaller to slide another album per row for the album view

mgallien accepted this revision.May 8 2018, 7:28 AM

It is really good looking. Nice work.

This revision is now accepted and ready to land.May 8 2018, 7:28 AM
This revision was automatically updated to reflect the committed changes.