- User Since
- Jul 17 2017, 6:17 PM (21 w, 1 d)
Add units.smallSpacing to single line height
Sun, Dec 10
Reducing the scope of this patch a bit, it now sets the clock fontsize to a fixed value. This prevents all the layout issues from relative scales. The code changes now are minimal, so it won't add pile more complexity on the code.
I'll continue working on the rewrite when I have some free time again, and submit a patch when/if I have feature parity with the current clock.
Sat, Dec 9
Fri, Dec 8
+1 for this patch. The three-line buttons happen in many other places too (dolphin, window title bars, firefox, chrome, etc.). Users quickly learn that pattern and recognize it as the "menu button" so I don't think that would be a problem.
Wed, Nov 29
Tue, Nov 28
Thanks for the replies guys.
@davidedmundson Good point! I'll keep a close eye on the current code while I work on this.
Sun, Nov 26
So, I've been fighting with this for a few weekends already and I just can't get it to work reliably with a relative scale. The spacing goes all wonk and sometimes the labels' font size don't change the way you expect them to (probably because of the maze of bindings).
Nov 7 2017
Nov 6 2017
Nov 5 2017
Use zoomSliderHeight for space/progress bars
Here's a screen using oxygen
Forget what I said in the previous comment. I need a looooot of sleep :)
This version fixes the free space and connection progress bars for non-breeze styles
Nov 3 2017
We could do without the extra padding on the sides for the sake of other styles. It's mostly a problem of rounded corners (IMO), it's hard to follow the alignment of the widgets below the panes.
Nov 2 2017
Fix path in diff
@ngraham Use firstname.lastname@example.org
Thanks for the tip. I had arc set up for Blender and thought setting for KDE would be a hassle. Turns out it was a single command heh
Nov 1 2017
Hey, thanks for the comments guys!
Fixed paths in diff
Oct 31 2017
@abetts Good news on the 3 bottom buttons. I was thinking of posting a mockup
with defaults and reset moved to the main menu too. About the GHNS window:
I thought that was decided against in the other thread, because qmlgrid couldn't
The grid with margins is the best IMO. It's the best use of screen space (and it looks better than the others) . I totally agree with the frame-in-frame problem (I wish dolphin looked more like your mockup!), but I think that adding too many lines can also end up adding visual noise.
Oct 29 2017
Oct 28 2017
Oct 26 2017
Here's a mockup I made based on @mart 's:
Oct 24 2017
Some ideas from a n00b contributor:
Oct 20 2017
Oct 19 2017
Oct 15 2017
Personally, I'm in the centered shadows camp. I have windows set up to have no borders and they always seem to visually blend into each other in a similar way to what @rkflx describes.
I don't understand the reasoning behind light coming from the top-left, it seems arbitrary. If it's because of the reading direction, then I'm sure speakers of RTL languages would prefer top-right lighting :).
Sep 10 2017
I think this explains why you haven't had a review, this existing code is already sketchy as-is :/
But we should be trying to fix that not just all of us ignoring it. Sorry about that.
Sep 7 2017
Hey guys, the beta is starting next week. Any chance we can still land this or https://phabricator.kde.org/D6813 for 5.11?
Aug 30 2017
Jul 29 2017
Jul 22 2017
@Zren Thanks! I've updated the rev
@mart I can see some parts of the code look a little too hacky but the new setting is nothing fancy, and I've been using for about 3 weeks without issues. It also fixes these two bugs: https://bugs.kde.org/show_bug.cgi?id=191889 and https://bugs.kde.org/show_bug.cgi?id=323223
- Use pixelSize with units.devicePixelRatio to set the size
- Update the default value to fit with the default panel