januz (Diego Gangl)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 17 2017, 6:17 PM (73 w, 1 d)
Availability
Available

Recent Activity

Oct 27 2018

januz added a comment to D14018: [WIP] Make labels in header bar clickeable.

I tried to take another look at this, but after rebasing on master I started getting an error when building:

Oct 27 2018, 10:28 PM · Elisa

Oct 15 2018

januz added a comment to D14018: [WIP] Make labels in header bar clickeable.

I'll try to look into this again next weekend. I think Elisa was missing some way to go properly from Now Playing to a specific album view, so it went straight to all albums.

Oct 15 2018, 12:56 AM · Elisa

Oct 14 2018

januz removed a watcher for Elisa: januz.
Oct 14 2018, 10:46 PM

Oct 8 2018

januz added a comment to D14120: Tweak inital state for playlist.

Hi guys, sorry I've been dropping the ball on this one. I had reverted this some weeks ago but couldn't find another way to center it. And then I didn't have time to get back on it.
+1 for landing it now

Oct 8 2018, 6:51 PM · Elisa

Aug 24 2018

januz added a comment to D14018: [WIP] Make labels in header bar clickeable.

This is mostly done too but there's still one small bug: when I go to the now playing view and then click on the album name it doesn't open the album, but only switches to the album view.
Still trying to figure this out

Aug 24 2018, 3:14 PM · Elisa
januz updated the diff for D14018: [WIP] Make labels in header bar clickeable.
  • Use new AlbumId data
Aug 24 2018, 3:13 PM · Elisa
januz updated the diff for D14120: Tweak inital state for playlist.

Thanks for the ping! This was mostly done but I had forgotten about it

Aug 24 2018, 2:30 PM · Elisa

Aug 14 2018

januz added a comment to D14736: Add a mode where all the bottom part can be hidden.

Hey, great! I can't see the bug anymore. The only thing that's missing now is toggling when the window is maximized, right now the button switches but there's no change in the UI.
BTW, maximizing the UI + window looks awesome. Specially with high-res covers.

Aug 14 2018, 11:21 PM

Aug 13 2018

januz added a comment to D14736: Add a mode where all the bottom part can be hidden.

Looking good. I noticed the bug seems to show up consistently when the window is maximized (I think that's the one you're talking about)

Aug 13 2018, 9:52 PM

Aug 11 2018

januz added a comment to D14736: Add a mode where all the bottom part can be hidden.

For the moment, I've only implemented the button for hiding the bottom part. How can I detect if I'm in the party mode or in the minimal mode?

Aug 11 2018, 9:51 PM

Aug 10 2018

januz requested changes to D14736: Add a mode where all the bottom part can be hidden.

Hi @ognarb, great work! There's one change I think would make this better. Let the window become smaller when this setting is enabled so it can be the same height as the headerbar in the normal window state. When party mode is disabled though, the window should have the same minimum height as it does now. You can find the properties to do that in ElisaMainWindow.qml

Aug 10 2018, 10:37 PM

Jul 26 2018

januz awarded D12290: Don't draw list dividers a Like token.
Jul 26 2018, 9:32 PM · KDE Connect

Jul 15 2018

januz committed R255:f3f15b0f62a1: New header style for playlist (authored by januz).
New header style for playlist
Jul 15 2018, 11:35 PM
januz closed D14015: New header style for playlist.
Jul 15 2018, 11:35 PM · Elisa
januz added a comment to T7884: file browser.
  • Names in both dolphin and elisa are aligned to the center

Do you mean this as a wish? They are left aligned, which is also consistent with the other views.

Jul 15 2018, 11:34 PM · Elisa
januz awarded M128: Plasma Sets a 100 token.
Jul 15 2018, 2:19 AM

Jul 14 2018

januz added a project to D14120: Tweak inital state for playlist: Elisa.
Jul 14 2018, 11:07 PM · Elisa
januz requested review of D14120: Tweak inital state for playlist.
Jul 14 2018, 11:06 PM · Elisa
januz accepted D14080: add albumId role to MediaPlayList and use it in ManageHeaderBar.

Tested this on my branch and it works now, thanks guys

Jul 14 2018, 10:04 PM
januz updated the diff for D14015: New header style for playlist.
  • Reverse clear list icon
  • Add ellipsis on load/save texts (for tooltips)
Jul 14 2018, 9:37 PM · Elisa
januz added a comment to D14015: New header style for playlist.

Looks like ToolButtons ignore text. I managed to hack this by shoving a Text object inside them but it really messes up the layout and only the icon is clickable.

Jul 14 2018, 12:34 AM · Elisa

Jul 13 2018

januz added a comment to D14015: New header style for playlist.

How about putting the icons on top and making them toolbuttons without a visible button-looking border? There's plenty of unused vertical space there, and square buttons might fit well in the available space.

Jul 13 2018, 2:31 PM · Elisa
januz added a comment to D14015: New header style for playlist.

There is some room, but it ends up looking more cramped.

Jul 13 2018, 2:19 PM · Elisa
januz updated the diff for D14015: New header style for playlist.

Replace menu with buttons (also eliminates the reverse mode problem)

Jul 13 2018, 2:17 PM · Elisa
januz added a comment to D14015: New header style for playlist.

Hey guys, yeah there's room for the 4 buttons up there. The main pro for the dropdown was having text for the buttons that modified the playlist, but having the buttons could also simplify things. Sorry I keep forgetting about reversed mode

Jul 13 2018, 2:00 PM · Elisa
januz accepted D14084: always display the title of the playlist entries.

LGTM. Tested this by adding MOD files to the playlist and now they show up correctly.
One small issue is that they are all inside a blank album (with only a CD icon) which looks a bit strange but that's a topic for another patch.

Jul 13 2018, 1:31 PM

Jul 12 2018

januz added a comment to D14080: add albumId role to MediaPlayList and use it in ManageHeaderBar.

Hey, thanks for working on this. I tried this in the links branch but it seems all albums are giving back zero (even after deleting/rebuilding the db).

Jul 12 2018, 6:18 PM
januz added a comment to D14018: [WIP] Make labels in header bar clickeable.

@mgallien Thanks!

Jul 12 2018, 1:22 AM · Elisa
januz committed R255:8e519573210f: Allow playlist to be hidden (authored by januz).
Allow playlist to be hidden
Jul 12 2018, 1:21 AM
januz closed D13834: Allow playlist to be hidden.
Jul 12 2018, 1:21 AM · Elisa

Jul 11 2018

januz added inline comments to D13834: Allow playlist to be hidden.
Jul 11 2018, 5:41 PM · Elisa
januz updated the diff for D13834: Allow playlist to be hidden.

Bring back goBack action

Jul 11 2018, 5:41 PM · Elisa
januz added a comment to D13834: Allow playlist to be hidden.

I don't quite understand what you guys mean by a different workflow.

I downloaded Lollypop to try it out, but the workflow is almost the same as Elisa for me. There's a global playlist (in a popup), if you click the play button the playlist is cleared and replaced, and you can click the + button to enqueue.

(offtopic: I'm really digging those giant cover images)

I do not know Lolypop very well. I meant players in general where you do not see an explicit global playlist but where you just play the music currently shown.
Some people kept asking for an iTunes like behavior. I also do not know it but I understood that it was optimized to work well without a global playlist.

Jul 11 2018, 3:46 PM · Elisa
januz awarded D14046: [effects/desktopgrid] Don't change activities a Party Time token.
Jul 11 2018, 2:30 PM · KWin

Jul 10 2018

januz updated subscribers of D14015: New header style for playlist.

Good point in the ellipsis. The broom icon is way better but I'm going to wait for confirmation from @mgallien or @astippich since we are on 5.45 now.

Jul 10 2018, 5:40 PM · Elisa
januz added a comment to T9153: Global shortcuts.

Thinking a bit more about this, we might want to use PgUp/ PgDn to scroll in the playlist/content views so maybe we should go straight for the chord.

Jul 10 2018, 3:16 AM · Elisa

Jul 9 2018

januz updated the summary of D14018: [WIP] Make labels in header bar clickeable.
Jul 9 2018, 11:33 PM · Elisa
januz added a comment to D14018: [WIP] Make labels in header bar clickeable.

This patch isn't finished yet. I've come across a problem with the album view: the openOneAlbum() function requires a databaseID to get the album data but I have no way of getting that in the header bar. I looked around the headerbarmanager code for a bit but I have no idea how we could fetch that. Everything else works.

Jul 9 2018, 11:32 PM · Elisa
januz added a project to D14018: [WIP] Make labels in header bar clickeable: Elisa.
Jul 9 2018, 11:28 PM · Elisa
januz requested review of D14018: [WIP] Make labels in header bar clickeable.
Jul 9 2018, 11:28 PM · Elisa
januz updated the diff for D13834: Allow playlist to be hidden.
  • Make menu text contextual (show/hide)
  • Let window be smaller when playlist is disabled (up to 700px)
  • Disable menu action in Now Playing view
  • Add customizable shortcut for the action (wohoo, I figured it out! It's F9 by default)
Jul 9 2018, 11:17 PM · Elisa
januz added a comment to D14015: New header style for playlist.

Based on the old mockups at: https://diegogangl.github.io/

Jul 9 2018, 10:27 PM · Elisa
januz added a project to D14015: New header style for playlist: Elisa.
Jul 9 2018, 10:26 PM · Elisa
januz requested review of D14015: New header style for playlist.
Jul 9 2018, 10:25 PM · Elisa
januz added a comment to T9153: Global shortcuts.

@ngraham Good point about Ctrl+T , I tried to make them mnemonic but I can see how it could be confusing. What do you think about F9? It's used by the place's panel in Dolphin, so it's a bit similar.

Jul 9 2018, 10:19 PM · Elisa

Jul 7 2018

januz triaged T9153: Global shortcuts as Wishlist priority.
Jul 7 2018, 9:22 PM · Elisa

Jul 4 2018

januz added a comment to D13834: Allow playlist to be hidden.

I don't quite understand what you guys mean by a different workflow.

Jul 4 2018, 3:06 PM · Elisa
januz added a comment to D13834: Allow playlist to be hidden.

Very nice! You'll lure me away from Lollypop yet. :)

Jul 4 2018, 12:49 AM · Elisa
januz updated the summary of D13834: Allow playlist to be hidden.
Jul 4 2018, 12:37 AM · Elisa
januz updated the summary of D13834: Allow playlist to be hidden.
Jul 4 2018, 12:36 AM · Elisa

Jul 3 2018

januz added a comment to D12841: Align view buttons vertically.

Sorry for the big delay on my side.
Let's get it in the 0.2 branch. It is much better with than without it.
We will do a real 0.2.1 with stuff being fixed !!!

Jul 3 2018, 9:50 PM · Elisa
januz committed R255:b1846b212f86: Align view buttons vertically (authored by januz).
Align view buttons vertically
Jul 3 2018, 9:26 PM
januz closed D12841: Align view buttons vertically.
Jul 3 2018, 9:26 PM · Elisa

Jul 1 2018

januz added a comment to D13834: Allow playlist to be hidden.

There's one small thing left to do for this one: add a customizable shortcut. I couldn't figure out how to do it though, should I add the action in C++ to do that?

Jul 1 2018, 11:01 PM · Elisa
januz added a project to D13834: Allow playlist to be hidden: Elisa.
Jul 1 2018, 11:00 PM · Elisa
januz requested review of D13834: Allow playlist to be hidden.
Jul 1 2018, 10:56 PM · Elisa

Jun 30 2018

januz accepted D13639: move the playing indicator to be first on line and align titles.

I don't have albums with more than with two digit disc numbers, so I'll take your word for it :)
LGTM

Jun 30 2018, 9:45 PM

Jun 28 2018

januz added a comment to D13639: move the playing indicator to be first on line and align titles.

Unfortunately, I have not yet found a reliable way to get light text with all fonts. Some work, some does not work.

Jun 28 2018, 3:07 PM

Jun 26 2018

januz added a comment to D13639: move the playing indicator to be first on line and align titles.

I think it looks really good right now! Two more things:

  • Every track has the multi-disc format now (1/2, 1/3, etc.) even when they are not multi disc. Some individual tracks show " / 1".
  • The screen you shared earlier had the track numbers and artist names in a lighter grey, did you decide against it?
Jun 26 2018, 10:17 PM
januz added a comment to D13639: move the playing indicator to be first on line and align titles.

I can see what you mean, the alternating colors would look weird if they go across albums. The other option could be making the alternating colors "local" to albums, but I'm not sure how we could do that since we can't rely on track numbers.

Did you had a look at the last screenshot where all album headers have a third color distinct from the rows ? The difference may be too small but at the same time, I am a bit lost on which solution apply.

Jun 26 2018, 12:55 AM

Jun 23 2018

januz awarded D13700: implement reading of the replaygain tags a 100 token.
Jun 23 2018, 10:54 PM · Baloo, Frameworks

Jun 22 2018

januz accepted D13681: fix artist being empty when they are only used as album artists.

Tested and LGTM

Jun 22 2018, 6:15 PM
januz added a comment to D13639: move the playing indicator to be first on line and align titles.

I can see what you mean, the alternating colors would look weird if they go across albums. The other option could be making the alternating colors "local" to albums, but I'm not sure how we could do that since we can't rely on track numbers.

Jun 22 2018, 12:15 AM

Jun 20 2018

januz added a comment to D13481: Recommend window border size "None".

+1 I've been using borderless windows all the time since I came back to KDE Plasma and haven't had any workflow issues.

Jun 20 2018, 11:47 PM · Plasma
januz requested changes to D13639: move the playing indicator to be first on line and align titles.

A couple more things:

  • I think a bit of marginBottom in the title row would be good too, to separate the artist name from the first song name
  • The track being played gets a bold font, but only for the title. I think it'd be more consistent to have bold text in the whole row
  • Looks like the "-1" for songs without a track number came back
  • RTL has some issues (though it's probably not done yet)
Jun 20 2018, 11:43 PM
januz added a comment to D13639: move the playing indicator to be first on line and align titles.

I might be biased but I absolutely love this :D

Jun 20 2018, 10:30 PM
januz added a comment to D12975: Hide stars when there is no rating.

Unfortunately still a while. KFileMetaData has currently not the ability to write these tags, and Elisa itself also has no infrastructure yet to actually edit the metadata

Jun 20 2018, 10:30 PM · Elisa
januz committed R255:f9eafddd068c: Hide stars when there is no rating (authored by januz).
Hide stars when there is no rating
Jun 20 2018, 10:27 PM
januz closed D12975: Hide stars when there is no rating.
Jun 20 2018, 10:27 PM · Elisa

Jun 8 2018

januz added a comment to D12841: Align view buttons vertically.

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Thanks for your work.

I tried increasing the font size to 14 (OK, this is a corner case) and the bottom of the buttons are no longer aligned.
Did you consider using TextMetrics to get the exact height of the label ?

Jun 8 2018, 10:45 PM · Elisa
januz added a comment to D12975: Hide stars when there is no rating.

we could actually flip the position of the buttons and the star ratings...

Jun 8 2018, 10:15 PM · Elisa
januz updated the diff for D12975: Hide stars when there is no rating.

Make filter rating stars always visible

Jun 8 2018, 9:59 PM · Elisa
januz added a comment to D13423: unmerge albums by using the paths of their tracks.

When I tried this the first time I got this error and the loading animation running constantly.

Jun 8 2018, 1:29 PM

Jun 3 2018

januz added a comment to T7884: file browser.

Tried this from master and it works really well. The thing that gets excites me the most is that Elisa can now play MOD files! I can confirm that .xm, .it, .mod and .s3m formats work. MIDI files are also recognized and shown but they failed to play for me.

Jun 3 2018, 12:52 AM · Elisa
januz added a comment to T7883: year and genre browser.

Tried this again from Master after nuking my DB. I get more genres (I think) but they are all empty and if I try to play them I get an empty playlist.

Jun 3 2018, 12:34 AM · Elisa

Jun 2 2018

januz updated the diff for D12841: Align view buttons vertically.

Here's a new solution for alignment. It should stay in mostly the same place with different fonts, unless you are using some weird fantasy font with bad metrics.

Jun 2 2018, 12:02 AM · Elisa

May 31 2018

januz added a comment to T7883: year and genre browser.

Gave this a quick try:

May 31 2018, 11:02 PM · Elisa

May 30 2018

januz added a comment to D12842: Tweak size and color of handles for the seek/volume sliders.

No problem :)

May 30 2018, 12:36 AM · Elisa
januz committed R255:143347526272: Tweak size and color of handles for the seek/volume sliders (authored by januz).
Tweak size and color of handles for the seek/volume sliders
May 30 2018, 12:35 AM
januz closed D12842: Tweak size and color of handles for the seek/volume sliders.
May 30 2018, 12:35 AM · Elisa

May 27 2018

januz added a comment to D12992: New elisa icon.

I agree in that a circle doesn't have as much personality as maybe a
casette. I also agree in that the casette felt off when looking at it.

How would something like an LP player with the E on top feel? I won't have
time until Monday (finals coming up), but my gut says that a brown-ish
square with a dark circle (like seeing an LP player from above) with some
iconography on top could look good.

May 27 2018, 11:04 PM · Frameworks, Elisa

May 26 2018

januz updated the diff for D12975: Hide stars when there is no rating.

Here's a test for the "columns" idea.

May 26 2018, 12:28 AM · Elisa

May 25 2018

januz updated the diff for D12842: Tweak size and color of handles for the seek/volume sliders.
  • Revert size changes
  • Remove blank line
  • Tweak border colors (size change)
May 25 2018, 1:00 AM · Elisa

May 24 2018

januz added a comment to D12992: New elisa icon.

TBH I like the concept of the cassette icon more than the current implementation of it. What was good about about is that it had personality, which is a big deal since usually icons also double as logos. IMO a solid icon should be 1) Memorable and 2) Descriptive. Imagine both icons amongst these google search results and consider which one would stand out, which one you would know it's elisa's. These icons are technically great, they are just not memorable.

May 24 2018, 1:27 AM · Frameworks, Elisa

May 22 2018

januz added a comment to D12842: Tweak size and color of handles for the seek/volume sliders.

Heh I thought this was only affecting desktops so it didn't need to be touchable, I completely forgot PCs have touchscreens too these days.
Good points, I'll revert that later

May 22 2018, 11:19 PM · Elisa
januz added a comment to D12992: New elisa icon.

^ I'm for this one without the quaver

I also prefer this one without the quaver.
Is it possible to really simplify the background for the small size icon ? It would be probably much easier to read it.

@astippich and @januz what is your opinion ? You are also working on Elisa and should have the rights to speak ;)

May 22 2018, 10:26 PM · Frameworks, Elisa
januz added a comment to D12951: fix several issues caused by the use of loaders for the music views.

Did a quick test going back and forth from albums to artists and works great

May 22 2018, 10:11 PM

May 21 2018

januz added a comment to D12975: Hide stars when there is no rating.

I don't think the buttons look so bad jumping around, after all there's only two positions they can be. However I think if we keep them in the same position (in the middle) but actually push them farther to the left we could create the illusion of columns, and it wouldn't look so weird. I'll take a look at it.

May 21 2018, 5:50 PM · Elisa
januz added a comment to D12841: Align view buttons vertically.

Yep it's probably the font, I'm using the ubuntu font and it looks like this:

May 21 2018, 3:41 PM · Elisa

May 20 2018

januz awarded T8753: Launcher Menus Convergence a Like token.
May 20 2018, 2:19 AM · Plasma, VDG

May 19 2018

januz added a comment to D12841: Align view buttons vertically.

Could be dpi, are you using a high-dpi screen? Could you post a screen so I can see how far off it is?
I'm thinking it could also be the system font. What font are you using?

May 19 2018, 10:19 PM · Elisa

May 18 2018

januz added a project to D12975: Hide stars when there is no rating: Elisa.
May 18 2018, 11:47 PM · Elisa
januz requested review of D12975: Hide stars when there is no rating.
May 18 2018, 11:45 PM · Elisa
januz updated the diff for D12841: Align view buttons vertically.

Tighten margins

May 18 2018, 12:36 AM · Elisa

May 16 2018

januz accepted D12915: use more appropriate icon names for the tracks and play list views.

LGTM. The tracks icon is much better now

May 16 2018, 12:39 PM

May 13 2018

januz updated the diff for D12841: Align view buttons vertically.

Sorry I forgot to check albums with covers.

May 13 2018, 11:23 PM · Elisa
januz added a project to D12842: Tweak size and color of handles for the seek/volume sliders: Elisa.
May 13 2018, 1:37 AM · Elisa
januz requested review of D12842: Tweak size and color of handles for the seek/volume sliders.
May 13 2018, 1:36 AM · Elisa
januz added a project to D12841: Align view buttons vertically: Elisa.
May 13 2018, 12:38 AM · Elisa
januz requested review of D12841: Align view buttons vertically.
May 13 2018, 12:34 AM · Elisa