Differential D9895

[UDisks] Ignore non-user mounts
ClosedPublic
Actions

Authored by broulik on Jan 15 2018, 6:00 PM.

Details

Reviewers
bshah
Group Reviewers
Plasma
VDG
Frameworks
Commits
R245:1384f275ab2f: [UDisks] Ignore non-user mounts
Summary

This gets rid of all those internal mounts, such as /snap mounts.
The approach is similar to GVFS which ignores everything outside /media, /home/user, and /media/run, cf. https://github.com/GNOME/gvfs/blob/master/monitor/udisks2/what-is-shown.txt
Explicitly creating a mount in /etc/fstab outside of those directories is still possible and will always show up.

BUG: 379516
CCBUG: 319998

Test Plan

My snaps no longer show up as "Loop Device"s
Mounted an ISO file in my home dir, showed up fine
Plugged in a USB key, showed up fine
My cifs mount in /etc/fstab still showed up

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 15 2018, 6:00 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 15 2018, 6:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 15 2018, 6:00 PM
sitter added a subscriber: sitter.Jan 22 2018, 2:25 PM
januz awarded a token.Jan 22 2018, 4:52 PM
bshah accepted this revision as: bshah.Jan 23 2018, 2:14 PM
This revision is now accepted and ready to land.Jan 23 2018, 2:14 PM
broulik edited the summary of this revision. (Show Details)Jan 23 2018, 3:41 PM
Closed by commit R245:1384f275ab2f: [UDisks] Ignore non-user mounts (authored by broulik). · Explain WhyJan 23 2018, 4:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25828

View Options

src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

Loading...
View Options

src/solid/devices/backends/udisks2/udisksstoragevolume.cpp

Loading...