Changes on header
ClosedPublic

Authored by januz on Dec 30 2017, 1:16 AM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:b3f5ee70c1f6: Changes on header
Summary

This patch increases the blur in the headerbar background, increases contrast
between background and text, and brings the labels closer together.

(I increased the saturation a bit after talking about it in the ML)

Screen:

Test Plan

Play some music :)

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
januz requested review of this revision.Dec 30 2017, 1:16 AM
januz created this revision.
januz edited the summary of this revision. (Show Details)Dec 30 2017, 1:18 AM
januz added reviewers: mgallien, Elisa.
januz added projects: Elisa, VDG.
mgallien accepted this revision.Dec 30 2017, 7:27 PM

Thanks for your work.
I would like to add the missing rating (5 stars) widget to the top bar. Do you have an advice about its best position ?

Do you need me to push it ?

This revision is now accepted and ready to land.Dec 30 2017, 7:27 PM
januz updated this revision to Diff 24506.Dec 30 2017, 10:21 PM

Update to remove unneded desaturate element.

Sorry, there was a desaturate element that wasn't needed anymore (set to zero) that I forgot to remove yesterday.

big improvement from the design (text styles are way better). the play sometimes preview sometimes next stuff look a bit confuse. I would have this 3 actions always available.

for the cover I would suggest to have something like a frame around them like you know it from dolphin previewer.

Thanks for your work.
I would like to add the missing rating (5 stars) widget to the top bar. Do you have an advice about its best position ?

I think their current position looks ok (after this patch). Maybe it could be a bit bigger, and the stars need to be filled with white or the text's color.

Do you need me to push it ?

Yes, please. I've applied for a dev account but haven't received any reply yet.
My details: Diego Gangl / diego@sinestesia.co

This revision was automatically updated to reflect the committed changes.