replace default background for HeaderBar by a wallpaper from Breeze
ClosedPublic
Actions

Authored by mgallien on Jan 12 2018, 8:41 PM.

Details

Reviewers

Group Reviewers

Elisa
VDG

Commits

R255:4426272b9c16: replace default background for HeaderBar by a wallpaper from Breeze

Summary

replace default background for HeaderBar by a wallpaper from Breeze

Test Plan

wallpaper from Breeze with an LGPLv3 license compatible with elisa license

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Jan 12 2018, 8:41 PM

mgallien created this revision.

New header bar with default background

Can you use the user wallpaper? Than you dont need to add an wallpaper and have to care.

Hey this looks even better than the old default, great idea!

In D9847#190079, @andreaska wrote:

Can you use the user wallpaper? Than you dont need to add an wallpaper and have to care.

This isn't a bad idea either but I have the feeling it would add a ton of complexity (supporting windows, android, etc.) for little gain. IMO, in the end Elisa should strive to find a cover in any possible way (in a jpg, embedded or online).

That wasnt my intension to bring more complexity

Thanks for your feedback. I believe I will probably discard this diff

Why that? I think it is still an improvement and fixes the license.

astippich accepted this revision.Jan 14 2018, 9:06 AM

This revision is now accepted and ready to land.Jan 14 2018, 9:06 AM

Closed by commit R255:4426272b9c16: replace default background for HeaderBar by a wallpaper from Breeze (authored by mgallien). · Explain WhyJan 14 2018, 8:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
M			src/HeaderBar.qml (16 lines)
M			src/Theme.qml (2 lines)
D	M	(bin)	src/background.jpg
A	M	(bin)	src/background.png
M			src/upnpControl.qrc (2 lines)
M			src/windows/WindowsTheme.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25247	8acb793		Jan 12 2018, 8:41 PM	★	★
Diff 2	25346	d9f0779	R255:4426272b9c163d855ba82194d5e7d6ef7306b48c	Jan 14 2018, 8:24 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
453650bda8c5	d40d654bbf93	8acb7931d982	Matthieu Gallien	replace default background for HeaderBar by a wallpaper from Breeze (Show More…)	Jan 12 2018, 8:29 PM