remove extra contrast for buttons on Linux and tune opacity of background
AbandonedPublic

Authored by mgallien on Jan 12 2018, 8:32 PM.

Details

Reviewers
None
Group Reviewers
Elisa
VDG
Summary

remove extra contrast for buttons on Linux and tune opacity of background

Test Plan

looks better

Diff Detail

Repository
R255 Elisa
Branch
playerControl
Lint
No Linters Available
Unit
No Unit Test Coverage
mgallien requested review of this revision.Jan 12 2018, 8:32 PM
mgallien created this revision.
mgallien added projects: Elisa, VDG.

Before changes

After changes

mgallien removed a project: VDG.

Honestly I like the Before picture better. Contrast is better and elements don't blend into one another.

januz added a subscriber: januz.Jan 13 2018, 12:35 AM

I have to agree with @ngraham. I think the player bar actually needs more contrast. With some dark backgrounds I have to squint/get close to the screen to read the minutes.

mgallien added a subscriber: alake.Jan 13 2018, 8:30 AM
In D9846#190120, @januz wrote:

I have to agree with @ngraham. I think the player bar actually needs more contrast. With some dark backgrounds I have to squint/get close to the screen to read the minutes.

Thanks both for your feedback.
I believe I may go to the previous state (more like the mockup of @alake ) where the cover is only on top of the player bar. The player bar itself does not have transparency and the contrast should be much better. What do you think ?

I should probably have communicated my plans better in that regard. I haven't forgotten to fix the contrast of the buttons for all platforms and themes, it just took me a while to get a Windows build going to properly test the changes. I have patches ready that also address the issue. I will post some screenshots this evening or tomorrow.

... The player bar itself does not have transparency and the contrast should be much better. What do you think ?

Sounds great to me.

Ok, here are my changes. They actually go into the same direction as the mockups by @alake, but not quite. Note that also some consistency fixes regarding margins and icon sizes are included.

Before


After

On windows the opacity has to be increased even more to maintain the contrast.
Before


After

What do you think?

The contrast is definitely better, but I kind of liked the bar with the prior level of transparency. If there's no way to marry these two, then I agree that contrast (=usability) should win the day.

mgallien abandoned this revision.Jan 14 2018, 9:01 PM

The contrast is definitely better, but I kind of liked the bar with the prior level of transparency. If there's no way to marry these two, then I agree that contrast (=usability) should win the day.

I did thought that the transparency would be fun when adding it. Nowadays, I see ugliness with some backgrounds and contrast problems with other backgrounds.
I recognize that it is more boring but we should strive to make this zone more useful (like adding repeat and random buttons or more). This way, the user will focus on it instead of finding it boring.

@astippich , do you know if you can take over the diff ? I will happily cancel this one if you open one yourself.

The fourth screenshot (after on windows) has the perfect level of transparency IMO. The linux (after) one is a great improvement too though.

I've updated D9412 which I left open for this purpose.