Drop shadow tweaks for delegates
ClosedPublic

Authored by januz on Jan 5 2018, 4:07 PM.

Details

Summary

Make shadows centered and slightly larger. Fits better with other shadows in the
desktop (like dolphin and widgets), and it also aligns with the new shadows for
breeze (D9549).

Current:

Patch:

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
januz requested review of this revision.Jan 5 2018, 4:07 PM
januz created this revision.
januz edited the summary of this revision. (Show Details)Jan 5 2018, 4:07 PM
januz added a reviewer: Elisa.
januz added projects: Elisa, VDG.
ngraham added a subscriber: ngraham.Jan 5 2018, 4:16 PM

Looks great. I would even make them a bit bigger, but that's just me. :-) I like big shadows and I cannot lie...

Looks great. I would even make them a bit bigger, but that's just me. :-) I like big shadows and I cannot lie...

Thanks for your work.
I agree, they could be bigger.

Also, Elisa looks like it's really coming along. I'm addicted to Lollypop at the moment, which is a super polished GNOME music player, but I keep meaning to check out Elisa at some point. Expect a flurry of Bugzilla tickets and patches if and when I do :)

januz added a comment.Jan 5 2018, 5:44 PM

Looks great. I would even make them a bit bigger, but that's just me. :-) I like big shadows and I cannot lie...

Thanks for your work.
I agree, they could be bigger.

Not sure if it can be done with QML's dropshadow. The radius settings make them softer, and spread makes the border more solid.
http://doc.qt.io/qt-5/qml-qtgraphicaleffects-dropshadow.html

Maybe enlarging radius + a darker color?

januz added a comment.Jan 5 2018, 5:46 PM

Also, Elisa looks like it's really coming along. I'm addicted to Lollypop at the moment, which is a super polished GNOME music player, but I keep meaning to check out Elisa at some point. Expect a flurry of Bugzilla tickets and patches if and when I do :)

I've been using it daily for the last few weeks and it's pretty good!

januz updated this revision to Diff 24800.EditedJan 5 2018, 11:30 PM

Make shadows larger using a bigger radius and some spread

Here's the new look:

ngraham accepted this revision.Jan 6 2018, 1:40 AM

Nicer! I like it.

This revision is now accepted and ready to land.Jan 6 2018, 1:40 AM
astippich accepted this revision.Jan 6 2018, 12:53 PM
This revision was automatically updated to reflect the committed changes.