Differential D9265

Disable shadows when no artist image is present
ClosedPublic
Actions

Authored by januz on Dec 8 2017, 11:34 PM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:1571bf4e3027: Disable shadows when no artist image is present
Summary

This patch disables the shadow effect in the artists section when it shows the artist icon.
Just an aesthetic change, I think Breeze's monochromatic icons look better without shadows.

Before:

After:

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
januz requested review of this revision.Dec 8 2017, 11:34 PM
januz created this revision.
januz edited the summary of this revision. (Show Details)Dec 8 2017, 11:35 PM
januz added a reviewer: Elisa.
januz added a project: VDG.
astippich added a subscriber: astippich.Dec 10 2017, 6:25 PM

+1 from me, looks cleaner. But if we do this we should probably also do the same for the MediaAlbumDelegate

mgallien requested changes to this revision.Dec 12 2017, 5:30 PM
mgallien added a subscriber: mgallien.

Thanks for your work.
Indeed, it is much better this way but I agree with Alexander. Please do it also for the other views.

This revision now requires changes to proceed.Dec 12 2017, 5:30 PM
januz updated this revision to Diff 23974.EditedDec 15 2017, 11:55 PM

Hey, shadows are now getting disabled on albums and tracks views.
One small detail: When there's no cover, image is undefined in albums and tracks but for artists it's passed as an empty string.

mgallien accepted this revision.Dec 16 2017, 8:03 AM

Thanks

This revision is now accepted and ready to land.Dec 16 2017, 8:03 AM
mgallien added a comment.Dec 18 2017, 10:08 PM

Do you have a contributor account or should I push your changes myself ?

januz added a comment.Dec 18 2017, 11:09 PM
In D9265#180847, @mgallien wrote:

Do you have a contributor account or should I push your changes myself ?

I should probably get a contributor account :)
Please push them.

Name: Diego Gangl
Email: diego@sinestesia.co

andreask added a subscriber: andreask.Dec 18 2017, 11:18 PM

please disable shadows. In general you need colored icons for default artist and album

Closed by commit R255:1571bf4e3027: Disable shadows when no artist image is present (authored by januz, committed by mgallien). · Explain WhyDec 19 2017, 9:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24121

View Options

src/MediaAlbumDelegate.qml

Loading...
View Options

src/MediaArtistDelegate.qml

Loading...
View Options

src/MediaTracksDelegate.qml

Loading...