| apol | |
| abetts | |
| colomar | |
| andreaska |
| Discover Software Store | |
| VDG |
Looks better on desktop and mobile now--IMHO of course!
This patch does not include any string changes, so it can go into 5.12.
Supports D9976, which changes the source switcher UI to use a combobox instead of links.
Tested in KDE Neon (please pardon the fact that the before and after screenshots have different window sizes):
Krita, before:
Krita, after
Endless Sky, before:
Endless Sky, after
Blender, before:
Blender, after
Mobile UI, before:
Mobile UI, after
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I just realized that this can't go into 5.12 because I changed a string and there's a string freeze. I'm going to remove the combobox part of this patch and put it in a second one to make this patch potentially able to go into 5.12.
Revert Combobox changes, as they changed a string and we're past the string freeze date for 5.12
In my opinion this looks absolutely wonderful!
When we last discussed Discover app pages in VDG Telegram channel I said that the version selection should be at top together with the other basic information, but by this I meant foremost that the info should be together not necessarily at the top. In fact later on I also had the thought that all this metadata info actually does not belong to the top of the app page. At the top there should be the name and if available screenshots of the app, such that the user gets a direct first impression without being overwhelmed with data. This is executed here perfectly.
Just a quick question: how do the reviews open up if clicked on the text link? Will they move the details further down?
Thanks for the vote of confidence, Roman! In this patch, I didn't touch the review UI; it's still a pop-up.
+1 Looks way more organized, and it's easier to grasp what application you're seeing and what it does on a quick glance. Minor nitpick: I'd add more margin around the summary text (to separate it better from screenshots and the summary link).
Big improvement from design and usability. Top the app information and bottom tecnical stuff
This is a clear improvement from my perspective, and I don't see it introducing any usability issues.
I like it, some nitpicking:
This is the application delegate, I think it would make sense to do the same use of the blue line that is here.
Also I would remove the blue line under Details much like we don't have it under Description at the moment.
| discover/qml/ApplicationPage.qml | ||
|---|---|---|
| 145–186 | This is a new string. Can't have new strings for 5.12. | |
| discover/qml/ApplicationPage.qml | ||
|---|---|---|
| 145–186 | Aww darn. | |