Differential D9964

Change color of elapsed time in seek/volume bars
ClosedPublic
Actions

Authored by januz on Jan 18 2018, 3:39 PM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:8958c9bd3d4a: Change color of elapsed time in seek/volume bars
Summary

Use a neutral color for the elapsed time in the Media Player control's bars.
This follows the original mockup (https://community.kde.org/File:Banagarang_Music_Mockup1a.png)

I think it also looks better because it limits the colors in the header area to the cover's.

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
januz requested review of this revision.Jan 18 2018, 3:39 PM
januz created this revision.
januz edited the summary of this revision. (Show Details)Jan 18 2018, 3:40 PM
januz added a reviewer: Elisa.
januz added a project: Elisa.
mgallien accepted this revision.Jan 19 2018, 4:33 PM
mgallien added a subscriber: mgallien.

We always wanted to use the Qt Quick Controls 2 style from frameworks. Currently, your patch is really the thing to do. Later we may want to move to the default display from the framework.

This revision is now accepted and ready to land.Jan 19 2018, 4:33 PM
Closed by commit R255:8958c9bd3d4a: Change color of elapsed time in seek/volume bars (authored by januz). · Explain WhyJan 19 2018, 5:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/MediaPlayerControl.qml (4 lines)

Diff 25649

View Options

src/MediaPlayerControl.qml

Loading...